From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Permerror (SPF Permanent Error: More than 10 MX records returned) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 28C96220EE136 for ; Tue, 12 Dec 2017 16:30:47 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2017 16:35:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,395,1508828400"; d="scan'208";a="2327675" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 12 Dec 2017 16:35:25 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Dec 2017 16:35:24 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Dec 2017 16:35:24 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Wed, 13 Dec 2017 08:35:22 +0800 From: "Zeng, Star" To: Laszlo Ersek , "Yao, Jiewen" , edk2-devel-01 CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error Thread-Index: AQHTc0dKUt9OvR92T0ahjcDwUqRI6KM/I+eAgAAEkYCAAUVr4A== Date: Wed, 13 Dec 2017 00:35:22 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9C2D13@shsmsx102.ccr.corp.intel.com> References: <20171212124630.7637-1-lersek@redhat.com> <74D8A39837DF1E4DA445A8C0B3885C503AA43F8D@shsmsx102.ccr.corp.intel.com> <07e8b107-57b2-e5ba-5a79-50a4d0b6c354@redhat.com> In-Reply-To: <07e8b107-57b2-e5ba-5a79-50a4d0b6c354@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 00:30:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the fix. Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Lasz= lo Ersek Sent: Tuesday, December 12, 2017 9:10 PM To: Yao, Jiewen ; edk2-devel-01 Cc: Dong, Eric ; Zeng, Star Subject: Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error On 12/12/17 13:54, Yao, Jiewen wrote: > Thanks ,Laszlo. > Reviewed-by: Jiewen.yao@intel.com Thanks! > Since it breaks the build, can we check in as soon as possible? Sure; commit dfc5a4dec602. Thanks! Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf=20 >> Of Laszlo Ersek >> Sent: Tuesday, December 12, 2017 8:47 PM >> To: edk2-devel-01 >> Cc: Dong, Eric ; Zeng, Star=20 >> >> Subject: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error >> >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c: In function >>> 'SmmReadyToBootHandler': >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:323:14: error: passing >> argument >>> 3 of 'SmmLocateProtocol' from incompatible pointer type [-Werror] >>> ); >>> ^ >>> In file included from MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:15:0: >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h:586:1: note: expected 'void >> **' >>> but argument is of type 'struct EFI_SMM_SX_DISPATCH2_PROTOCOL **' >>> SmmLocateProtocol ( >>> ^ >>> cc1: all warnings being treated as errors >> >> Cc: Eric Dong >> Cc: Star Zeng >> Fixes: 7b9b55b2ef7be13608605dc58a54b9ca04be4e40 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek >> --- >> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> index dbb89932e75b..1ccb9c7787ad 100644 >> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> @@ -319,7 +319,7 @@ SmmReadyToBootHandler ( >> Status =3D SmmLocateProtocol ( >> &gEfiSmmSxDispatch2ProtocolGuid, >> NULL, >> - &SxDispatch >> + (VOID **)&SxDispatch >> ); >> if (!EFI_ERROR (Status)) { >> // >> -- >> 2.14.1.3.gb7cf6e02401b >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel