public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [Patch] MdeModulePkg PeiCore: Update debug message to print the correct FV length
Date: Thu, 28 Dec 2017 06:44:48 +0000	[thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9DE6A6@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1514442975-9148-1-git-send-email-liming.gao@intel.com>

The code without this patch will have incorrect value shown for handle, please update the commit title.

With title updated,
Reviewed-by: Star Zeng <Star.Zeng@intel.com>


Thanks,
Star
-----Original Message-----
From: Gao, Liming 
Sent: Thursday, December 28, 2017 2:36 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>
Subject: [Patch] MdeModulePkg PeiCore: Update debug message to print the correct FV length

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
 MdeModulePkg/Core/Pei/FwVol/FwVol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
index 7cb295c..8009546 100644
--- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
+++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
@@ -514,7 +514,7 @@ PeiInitializeFv (
     "The %dth FV start address is 0x%11p, size is 0x%08x, handle is 0x%p\n", 
     (UINT32) PrivateData->FvCount, 
     (VOID *) BfvHeader, 
-    BfvHeader->FvLength,
+    (UINT32) BfvHeader->FvLength,
     FvHandle
     ));    
   PrivateData->FvCount ++;
-- 
2.8.0.windows.1



      reply	other threads:[~2017-12-28  6:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-28  6:36 [Patch] MdeModulePkg PeiCore: Update debug message to print the correct FV length Liming Gao
2017-12-28  6:44 ` Zeng, Star [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B9DE6A6@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox