From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F31EB2220D20A for ; Wed, 10 Jan 2018 18:25:51 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 18:31:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,342,1511856000"; d="scan'208";a="192672742" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 10 Jan 2018 18:31:04 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 Jan 2018 18:31:04 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 Jan 2018 18:31:03 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Thu, 11 Jan 2018 10:31:02 +0800 From: "Zeng, Star" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: Andrew Fish , "Zeng, Star" Thread-Topic: [Patch 3/7] MdeModulePkg: Update DebugSupportDxe to pass XCODE5 build Thread-Index: AQHTiidsD7JX7tyGKUyJpDcYCp58IKNt9Akw Date: Thu, 11 Jan 2018 02:31:01 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9FA196@shsmsx102.ccr.corp.intel.com> References: <20180110152432.15964-1-liming.gao@intel.com> <20180110152432.15964-4-liming.gao@intel.com> In-Reply-To: <20180110152432.15964-4-liming.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 3/7] MdeModulePkg: Update DebugSupportDxe to pass XCODE5 build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 02:25:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Gao, Liming=20 Sent: Wednesday, January 10, 2018 11:24 PM To: edk2-devel@lists.01.org Cc: Andrew Fish ; Zeng, Star Subject: [Patch 3/7] MdeModulePkg: Update DebugSupportDxe to pass XCODE5 bu= ild XCODE5 doesn't support absolute addressing in the assembly code. This change uses lea instruction to get the address. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Andrew Fish Cc: Star Zeng --- MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm b/Mde= ModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm index 134842a68a..31d8b0a717 100644 --- a/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm +++ b/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm @@ -1,7 +1,7 @@ ;/** @file ; Low level x64 routines used by the debug support driver. ; -; Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.
+; Copyright (c) 2007 - 2018, Intel Corporation. All rights=20 +reserved.
; This program and the accompanying materials ; are licensed and made a= vailable under the terms and conditions of the BSD License ; which accomp= anies this distribution. The full text of the license may be found at @@ -= 226,7 +226,7 @@ ASM_PFX(CommonIdtEntry): pop rax add rsp, 8 ; pop vector numb= er mov [AppRsp], rsp ; save stack top - mov rsp, DebugStackBegin ; switch to debug= ger stack + lea rsp, [DebugStackBegin] ; switch to debug= ger stack sub rsp, 8 ; leave space for= vector number =20 ;; UINT64 Rdi, Rsi, Rbp, Rsp, Rbx, Rdx, Rcx, Rax; @@ -529,7 +529,7 @@ Cha= in: push rbx mov rax, cs push rax - mov rax, PhonyIretq + lea rax, [PhonyIretq] push rax iretq PhonyIretq: -- 2.11.0.windows.1