From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 395332215BDB2 for ; Mon, 29 Jan 2018 19:29:19 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 19:34:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,433,1511856000"; d="scan'208";a="170182586" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 29 Jan 2018 19:34:53 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 29 Jan 2018 19:34:52 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 29 Jan 2018 19:34:52 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.145]) with mapi id 14.03.0319.002; Tue, 30 Jan 2018 11:34:51 +0800 From: "Zeng, Star" To: Heyi Guo , "leif.lindholm@linaro.org" , "linaro-uefi@lists.linaro.org" , "edk2-devel@lists.01.org" , "graeme.gregory@linaro.org" CC: "huangming23@huawei.com" , "ard.biesheuvel@linaro.org" , "Gao, Liming" , "mengfanrong@huawei.com" , "guoheyi@huawei.com" , "zhangjinsong2@huawei.com" , "Kinney, Michael D" , "waip23@126.com" , "wanghuiqiang@huawei.com" , "huangdaode@hisilicon.com" , "Zeng, Star" , "Yao, Jiewen" Thread-Topic: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT Thread-Index: AQHTmXWh6BxvgmJZiU2wxiKgy57ekqOLwx6A Date: Tue, 30 Jan 2018 03:34:50 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA19B4D@shsmsx102.ccr.corp.intel.com> References: <1517280842-48914-1-git-send-email-heyi.guo@linaro.org> <1517280842-48914-2-git-send-email-heyi.guo@linaro.org> In-Reply-To: <1517280842-48914-2-git-send-email-heyi.guo@linaro.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags struct of PPTT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 03:29:20 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The change looks good to me, Reviewed-by: Star Zeng . But the title seems not so correct. It is about EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR, but not EFI_ACPI_6_2_PPT= T_STRUCTURE_PROCESSOR_FLAGS. How about to refine the title? Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Heyi= Guo Sent: Tuesday, January 30, 2018 10:54 AM To: leif.lindholm@linaro.org; linaro-uefi@lists.linaro.org; edk2-devel@list= s.01.org; graeme.gregory@linaro.org Cc: huangming23@huawei.com; ard.biesheuvel@linaro.org; Gao, Liming ; mengfanrong@huawei.com; guoheyi@huawei.com; Heyi Guo ; zhangjinsong2@huawei.com; Kinney, Michael D ; waip23@126.com; wanghuiqiang@huawei.com; huangdaode@hisilic= on.com Subject: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Correct processor flags= struct of PPTT From: Ming Huang The Type field of EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR should be UINT8 as = ACPI version 6.2 specification. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/Indu= stryStandard/Acpi62.h index 82d1425..2904d34 100644 --- a/MdePkg/Include/IndustryStandard/Acpi62.h +++ b/MdePkg/Include/IndustryStandard/Acpi62.h @@ -2569,7 +2569,7 @@ typedef struct { /// Processor hierarchy node structure /// typedef struct { - UINT32 Type; + UINT8 Type; UINT8 Length; UINT8 Reserved[2]; EFI_ACPI_6_2_PPTT_STRUCTURE_PROCESSOR_FLAGS Flags; -- 1.9.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel