public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: "Huangming (Mark)" <huangming23@huawei.com>,
	Heyi Guo <heyi.guo@linaro.org>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	 "linaro-uefi@lists.linaro.org" <linaro-uefi@lists.linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"graeme.gregory@linaro.org" <graeme.gregory@linaro.org>
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	"Gao, Liming" <liming.gao@intel.com>,
	"mengfanrong@huawei.com" <mengfanrong@huawei.com>,
	"guoheyi@huawei.com" <guoheyi@huawei.com>,
	"zhangjinsong2@huawei.com" <zhangjinsong2@huawei.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	 "waip23@126.com" <waip23@126.com>,
	"wanghuiqiang@huawei.com" <wanghuiqiang@huawei.com>,
	"huangdaode@hisilicon.com" <huangdaode@hisilicon.com>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros for PPTT
Date: Tue, 6 Feb 2018 06:29:42 +0000	[thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA393DB@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <b214e903-0596-1e25-544a-16ed8b6bf483@huawei.com>

I mean

+#define EFI_ACPI_6_2_PPTT_PROCESSOR_ID_INVALID            0x0
+#define EFI_ACPI_6_2_PPTT_PROCESSOR_ID_VALID              0x1


Thanks,
Star
-----Original Message-----
From: Huangming (Mark) [mailto:huangming23@huawei.com] 
Sent: Tuesday, February 6, 2018 2:12 PM
To: Zeng, Star <star.zeng@intel.com>; Heyi Guo <heyi.guo@linaro.org>; leif.lindholm@linaro.org; linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org
Cc: ard.biesheuvel@linaro.org; Gao, Liming <liming.gao@intel.com>; mengfanrong@huawei.com; guoheyi@huawei.com; zhangjinsong2@huawei.com; Kinney, Michael D <michael.d.kinney@intel.com>; waip23@126.com; wanghuiqiang@huawei.com; huangdaode@hisilicon.com
Subject: Re: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros for PPTT



On 2018/2/6 12:16, Zeng, Star wrote:
> How about using EFI_ACPI_6_2_PPTT_PROCESSOR_ID_XXX to be more specific?
> 

like this?
EFI_ACPI_6_2_PPTT_PROCESSOR_ID_PHYSICAL_PACKAGE 0x01
EFI_ACPI_6_2_PPTT_PROCESSOR_ID_ACPI_PROCESSOR   0x01

> Others are good to me.
> 
> 
> Thanks,
> Star
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
> Heyi Guo
> Sent: Friday, February 2, 2018 11:30 AM
> To: leif.lindholm@linaro.org; linaro-uefi@lists.linaro.org; 
> edk2-devel@lists.01.org; graeme.gregory@linaro.org
> Cc: huangming23@huawei.com; ard.biesheuvel@linaro.org; Gao, Liming 
> <liming.gao@intel.com>; mengfanrong@huawei.com; guoheyi@huawei.com; 
> Heyi Guo <heyi.guo@linaro.org>; zhangjinsong2@huawei.com; Kinney, 
> Michael D <michael.d.kinney@intel.com>; waip23@126.com; 
> wanghuiqiang@huawei.com; huangdaode@hisilicon.com
> Subject: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros 
> for PPTT
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
>  MdePkg/Include/IndustryStandard/Acpi62.h | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h 
> b/MdePkg/Include/IndustryStandard/Acpi62.h
> index 2904d34..30faba9 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi62.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h
> @@ -2557,6 +2557,12 @@ typedef struct {  } 
> EFI_ACPI_6_2_PPTT_STRUCTURE_HEADER;
>  
>  ///
> +/// Value for valid fields in PPTT struct ///
> +#define EFI_ACPI_6_2_PPTT_INVALID            0x0
> +#define EFI_ACPI_6_2_PPTT_VALID              0x1
> +
> +///
>  /// Processor hierarchy node structure flags  ///  typedef struct { 
> @@ -2593,6 +2599,18 @@ typedef struct {  } 
> EFI_ACPI_6_2_PPTT_STRUCTURE_CACHE_FLAGS;
>  
>  ///
> +/// For cache attributes
> +///
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ            0x0
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_WRITE           0x1
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ_WRITE      0x2
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_DATA            0x0
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_INSTRUCTION     0x1
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_UNIFIED         0x2
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_BACK    0x0
> +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_THROUGH 0x1
> +
> +///
>  /// Cache Type Structure cache attributes  ///  typedef struct {
> 

--
Best Regards,

Ming



      reply	other threads:[~2018-02-06  6:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02  3:30 [PATCH edk2/MdePkg v1] Add some macros for PPTT Heyi Guo
2018-02-02  3:30 ` [PATCH edk2/MdePkg v1] MdePkg ACPI: " Heyi Guo
2018-02-06  3:44   ` Huangming (Mark)
2018-02-06  4:16   ` Zeng, Star
2018-02-06  6:11     ` Huangming (Mark)
2018-02-06  6:29       ` Zeng, Star [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103BA393DB@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox