From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EF71E21E0B9F0 for ; Mon, 5 Feb 2018 22:58:10 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 23:03:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,467,1511856000"; d="scan'208";a="32356212" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 05 Feb 2018 23:03:51 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 5 Feb 2018 23:03:51 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Tue, 6 Feb 2018 15:03:49 +0800 From: "Zeng, Star" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] [Patch] MdeModulePkg: Don't build VarCheckUefiLib and DxeCore for EBC arch Thread-Index: AQHTmYvgKwHK1V3i9kuabrrxctPSYaOW+b9g//99N4CAAIaXoA== Date: Tue, 6 Feb 2018 07:03:49 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA3A497@shsmsx102.ccr.corp.intel.com> References: <1517290396-16916-1-git-send-email-liming.gao@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BA3A453@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1C7EF1@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1C7EF1@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg: Don't build VarCheckUefiLib and DxeCore for EBC arch X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 06:58:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, I am aware the purpose of the change. And I do not want VarCheckUefiLib and VariableRuntimeDxe to be separated. So I prefer to move VariableRuntimeDxe. With that handled, Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Gao, Liming=20 Sent: Tuesday, February 6, 2018 3:00 PM To: Zeng, Star ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch] MdeModulePkg: Don't build VarCheckUefiLib and D= xeCore for EBC arch Star: I don't know why only VariableRuntimeDxe and EmuVariableRuntimeDxe are in= [Components.IA32, Components.X64, Components.Ebc]. This patch is not to bu= ild VarCheckUefiLib and DxeCore for EBC arch. It doesn't touch others. For = your comments, I can change VariableRuntimeDxe not build for EBC.=20 Thanks Liming >-----Original Message----- >From: Zeng, Star >Sent: Tuesday, February 06, 2018 2:53 PM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Zeng, Star >Subject: RE: [edk2] [Patch] MdeModulePkg: Don't build VarCheckUefiLib=20 >and DxeCore for EBC arch > >Liming, > >Moving VarCheckUefiLib to be separated with VariableRuntimeDxe is=20 >strange to me. >It is not just for build, and also to demonstrate how is the library=20 >linked with VariableRuntimeDxe. >And why only VariableRuntimeDxe and EmuVariableRuntimeDxe are put in=20 >[Components.IA32, Components.X64, Components.Ebc], but not others, for=20 >example RegularExpressionDxe and RamDiskDxe, etc? > >If feasible, I prefer to move VariableRuntimeDxe (include its linking=20 >libraries) and EmuVariableRuntimeDxe to [Components.IA32,=20 >Components.X64, Components.IPF, Components.AARCH64]. > > >Thanks, >Star >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 >Liming Gao >Sent: Tuesday, January 30, 2018 1:33 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] MdeModulePkg: Don't build VarCheckUefiLib and=20 >DxeCore for EBC arch > >EBC build failure is caused by d7a09cb86a0416c099fa3a9e0fbe2c8f399b28de. >It changes MAX_UINTN and MAX_ADDRESS definition as below. >VarCheckUefiLib and DxeCore uses MAX_UINTN and MAX_ADDRESS in the=20 >global data initialization. >New style has >> operator, and not supported by EBC compiler. >The fix is not to build VarCheckUefiLib and DxeCore for EBC arch. > >#define MAX_UINTN ((UINTN) ~0) >=3D=3D> >#define MAX_UINTN ((UINTN)(~0ULL >> (64 - sizeof (INTN) * 8))) > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Liming Gao >--- > MdeModulePkg/MdeModulePkg.dsc | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > >diff --git a/MdeModulePkg/MdeModulePkg.dsc=20 >b/MdeModulePkg/MdeModulePkg.dsc index dd7e9d5..f4062fa 100644 >--- a/MdeModulePkg/MdeModulePkg.dsc >+++ b/MdeModulePkg/MdeModulePkg.dsc >@@ -267,10 +267,6 @@ > MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf > >MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePci >DeviceDxe.inf > >- MdeModulePkg/Core/Dxe/DxeMain.inf { >- >- >NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32G >uidedSectionExtractLib.inf >- } > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf > MdeModulePkg/Core/Pei/PeiMain.inf > MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf >@@ -314,7 +310,6 @@ > >MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull. >inf > MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf > MdeModulePkg/Library/VarCheckPcdLib/VarCheckPcdLib.inf > MdeModulePkg/Library/PlatformVarCleanupLib/PlatformVarCleanupLib.inf >@@ -439,10 +434,16 @@ > MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf > MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > >+[Components.IA32, Components.X64, Components.IPF, Components.ARM,=20 >+Components.AARCH64] >+ MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf >+ MdeModulePkg/Core/Dxe/DxeMain.inf { >+ >+ >+NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32 >Guide >+dSectionExtractLib.inf >+ } >+ > [Components.IA32, Components.X64, Components.Ebc] > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { > >- NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > NULL|MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf > NULL|MdeModulePkg/Library/VarCheckPcdLib/VarCheckPcdLib.inf > } >-- >2.8.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel