From: "Zeng, Star" <star.zeng@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"Laszlo Ersek (lersek@redhat.com)" <lersek@redhat.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure
Date: Wed, 7 Feb 2018 01:44:32 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA3BB8B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1517967056-18112-1-git-send-email-dandan.bi@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Cc Laszlo.
You can add similar comment like 1ea53108f6c1010a00a828d1d59ea28934025415 as recommended by https://bugzilla.tianocore.org/show_bug.cgi?id=607.
Thanks,
Star
-----Original Message-----
From: Bi, Dandan
Sent: Wednesday, February 7, 2018 9:31 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure
Initialize local variable to suppress warning C4703:
potentially uninitialized local pointer variable.
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
index c48e3bb..13221b9 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
@@ -242,10 +242,12 @@ PciBusDriverBindingStart ( {
EFI_STATUS Status;
EFI_DEVICE_PATH_PROTOCOL *ParentDevicePath;
EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL *PciRootBridgeIo;
+ PciRootBridgeIo = NULL;
+
//
// Check RemainingDevicePath validation
//
if (RemainingDevicePath != NULL) {
//
--
1.9.5.msysgit.1
next prev parent reply other threads:[~2018-02-07 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 1:30 [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure Dandan Bi
2018-02-07 1:44 ` Zeng, Star [this message]
2018-02-07 1:58 ` Bi, Dandan
[not found] ` <2d354a20-80eb-f0e4-25dc-3f19f9828c88@redhat.com>
2018-02-07 8:25 ` Bi, Dandan
2018-02-07 3:29 ` Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103BA3BB8B@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox