From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B9CA9223DB786 for ; Thu, 8 Feb 2018 20:50:17 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 20:56:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,482,1511856000"; d="scan'208";a="16797465" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 08 Feb 2018 20:56:02 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Feb 2018 20:56:02 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Feb 2018 20:56:01 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.125]) with mapi id 14.03.0319.002; Fri, 9 Feb 2018 12:56:00 +0800 From: "Zeng, Star" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] [PATCH v2 00/10] Formalize the reset system core design Thread-Index: AQHToVzO3i1gEOpQ50CfiF+Ijtb01qObf9tA Date: Fri, 9 Feb 2018 04:55:59 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA3DFBD@shsmsx102.ccr.corp.intel.com> References: <20180209041635.320856-1-ruiyu.ni@intel.com> In-Reply-To: <20180209041635.320856-1-ruiyu.ni@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 00/10] Formalize the reset system core design X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 04:50:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the new version patch series. With minor comments (I provided to V1) handled, Reviewed-by: Star Zeng to the patch series. :) For patch 007: "@param[in] ResetType Base reset type as defined in UEF= I spec." needs to be removed in ResetUtilityLib.h For patch 009: It changed EFI_SOFTWARE_RUNTIME_SERVICE to EFI_SOFTWARE_PEI_= SERVICE, but forgets to change 'runtime' to 'PEI' in comments and change EF= I_SW_RS_PC_RESET_SYSTEM to EFI_SW_PS_PC_RESET_SYSTEM. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiy= u Ni Sent: Friday, February 9, 2018 12:16 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2 00/10] Formalize the reset system core design The patches add/update two core modules that perform the reset action ResetSystemPei and ResetSystemRuntimeDxe With the two core modules, every time a reset action is performed in either= PEI phase or DXE phase, the accordingly registerred reset filter/notificat= ion/handler will be triggered. Reset filters are processed first so the final reset type and reset data ca= n be determined. Reset Notifications are processed second so all component= s that have registered for a Reset Notification can perform any required cl= ean up actions. Reset handlers are processed third. If there are no regist= ered reset handlers or none of them resets the platform, then the default r= eset action based on the ResetSystemLib is performed. The v2 changes against v2 are attached in the end of this mail.=20 Bret Barkelew (1): MdeModulePkg/ResetSystemPei: Add reset notifications in PEI Michael D Kinney (6): MdePkg/PeiServicesLib: Add PeiServicesResetSystem2() MdeModulePkg/PeiMain: Always attempt to use Reset2 PPI first MdeModulePkg/PeiMain: Cleanup whitespace in Reset.c MdeModulePkg/ResetSystemRuntimeDxe: Add platform filter and handler MdeModulePkg: Add ResetSystemLib instances that call core services MdeModulePkg: Add ResetUtility librray class and BASE instance Ruiyu Ni (3): MdeModulePkg/ResetSystemRuntimeDxe: Add more debug message MdePkg/UefiRuntimeLib: Support more module types. MdeModulePkg: Add ResetSystemPei PEIM MdeModulePkg/Core/Pei/Reset/Reset.c | 67 ++-- MdeModulePkg/Include/Library/ResetUtilityLib.h | 111 ++++++ .../Include/Ppi/PlatformSpecificResetFilter.h | 31 ++ .../Include/Ppi/PlatformSpecificResetHandler.h | 29 ++ .../Ppi/PlatformSpecificResetNotification.h | 32 ++ .../Include/Protocol/PlatformSpecificResetFilter.h | 31 ++ .../Protocol/PlatformSpecificResetHandler.h | 29 ++ .../Library/DxeResetSystemLib/DxeResetSystemLib.c | 98 ++++++ .../DxeResetSystemLib/DxeResetSystemLib.inf | 39 +++ .../DxeResetSystemLib/DxeResetSystemLib.uni | 21 ++ .../Library/PeiResetSystemLib/PeiResetSystemLib.c | 98 ++++++ .../PeiResetSystemLib/PeiResetSystemLib.inf | 39 +++ .../PeiResetSystemLib/PeiResetSystemLib.uni | 21 ++ .../Library/ResetUtilityLib/ResetUtility.c | 220 ++++++++++++ .../Library/ResetUtilityLib/ResetUtilityLib.inf | 40 +++ MdeModulePkg/MdeModulePkg.dec | 20 ++ MdeModulePkg/MdeModulePkg.dsc | 7 + MdeModulePkg/MdeModulePkg.uni | 7 +- .../Universal/ResetSystemPei/ResetSystem.c | 371 +++++++++++++++++= ++++ .../Universal/ResetSystemPei/ResetSystem.h | 130 ++++++++ .../ResetSystemPei.inf} | 45 ++- .../Universal/ResetSystemPei/ResetSystemPei.uni | 20 ++ .../ResetSystemPei/ResetSystemPeiExtra.uni | 20 ++ .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 91 ++++- .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 7 + .../ResetSystemRuntimeDxe.inf | 7 +- MdePkg/Include/Library/PeiServicesLib.h | 24 ++ MdePkg/Library/PeiServicesLib/PeiServicesLib.c | 26 ++ MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf | 4 +- 29 files changed, 1615 insertions(+), 70 deletions(-) create mode 100644 = MdeModulePkg/Include/Library/ResetUtilityLib.h create mode 100644 MdeModulePkg/Include/Ppi/PlatformSpecificResetFilter.h create mode 100644 MdeModulePkg/Include/Ppi/PlatformSpecificResetHandler.h create mode 100644 MdeModulePkg/Include/Ppi/PlatformSpecificResetNotificat= ion.h create mode 100644 MdeModulePkg/Include/Protocol/PlatformSpecificResetFilt= er.h create mode 100644 MdeModulePkg/Include/Protocol/PlatformSpecificResetHand= ler.h create mode 100644 MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLi= b.c create mode 100644 MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLi= b.inf create mode 100644 MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLi= b.uni create mode 100644 MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLi= b.c create mode 100644 MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLi= b.inf create mode 100644 MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLi= b.uni create mode 100644 MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c create mode 100644 MdeModulePkg/Library/ResetUtilityLib/ResetUtilityLib.in= f create mode 100644 MdeModulePkg/Universal/ResetSystemPei/ResetSystem.c create mode 100644 MdeModulePkg/Universal/ResetSystemPei/ResetSystem.h copy MdeModulePkg/Universal/{ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.i= nf =3D> ResetSystemPei/ResetSystemPei.inf} (50%) create mode 100644 MdeMod= ulePkg/Universal/ResetSystemPei/ResetSystemPei.uni create mode 100644 MdeModulePkg/Universal/ResetSystemPei/ResetSystemPeiExt= ra.uni diff --git a/MdeModulePkg/Include/Ppi/PlatformSpecificResetFilter.h b/MdeMo= dulePkg/Include/Ppi/PlatformSpecificResetFilter.h index 0f1432f5f8..1f728387b7 100644 --- a/MdeModulePkg/Include/Ppi/PlatformSpecificResetFilter.h +++ b/MdeModulePkg/Include/Ppi/PlatformSpecificResetFilter.h @@ -3,9 +3,9 @@ for ResetSystem(). A reset filter evaluates the parameters passed to ResetSystem() and converts a ResetType of EfiResetPlatformSpecific to a non-platform specific reset type. The registered filters are processed = before - EDKII_PLATFORM_SPECIFIC_RESET_HANDLER_PPI handlers. + EDKII_PLATFORM_SPECIFIC_RESET_NOTIFICATION_PPI handlers. =20 - Copyright (c) 2017 Intel Corporation. All rights reserved.
+ Copyright (c) 2017 - 2018 Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availa= ble under the terms and conditions of the BSD License that accompanies this distri= bution. The full text of the license may be found at diff --git a/MdeModulePkg/I= nclude/Ppi/PlatformSpecificResetHandler.h b/MdeModulePkg/Include/Ppi/Platfo= rmSpecificResetHandler.h index d5f1350c69..8d938abb02 100644 --- a/MdeModulePkg/Include/Ppi/PlatformSpecificResetHandler.h +++ b/MdeModulePkg/Include/Ppi/PlatformSpecificResetHandler.h @@ -1,9 +1,9 @@ /** @file This PPI provides services to register a platform specific handler for ResetSystem(). The registered handlers are processed after - EDKII_PLATFORM_SPECIFIC_RESET_FILTER_PPI notifications. + EDKII_PLATFORM_SPECIFIC_RESET_NOTIFICATION_PPI notifications. =20 - Copyright (c) 2017 Intel Corporation. All rights reserved.
+ Copyright (c) 2017 - 2018 Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availa= ble under the terms and conditions of the BSD License that accompanies this distri= bution. The full text of the license may be found at diff --git a/MdeModulePkg/I= nclude/Ppi/PlatformSpecificResetNotification.h b/MdeModulePkg/Include/Ppi/P= latformSpecificResetNotification.h index ea53e24133..cf6d1f18a6 100644 --- a/MdeModulePkg/Include/Ppi/PlatformSpecificResetNotification.h +++ b/MdeModulePkg/Include/Ppi/PlatformSpecificResetNotification.h @@ -1,9 +1,10 @@ /** @file This PPI provides services to register a platform specific notification = callback for ResetSystem(). The registered handlers are processed after - EDKII_PLATFORM_SPECIFIC_RESET_FILTER_PPI notifications. + EDKII_PLATFORM_SPECIFIC_RESET_FILTER_PPI notifications and before =20 + EDKII_PLATFORM_SPECIFIC_RESET_HANDLER_PPI notifications. =20 - Copyright (c) 2017 Intel Corporation. All rights reserved.
+ Copyright (c) 2017 - 2018 Intel Corporation. All rights reserved.
Copyright (c) 2017 Microsoft Corporation. All rights reserved.
=20 This program and the accompanying materials are licensed and made availa= ble under diff --git a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSyste= mLib.c b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c index 70ee1175d5..ea452e3231 100644 --- a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c +++ b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c @@ -1,7 +1,7 @@ /** @file DXE Reset System Library instance that calls gRT->ResetSystem(). =20 - Copyright (c) 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2017 - 2018, Intel Corporation. All rights=20 + reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -13,9 +13,7 @@ **/ =20 #include - #include -#include #include =20 /** diff --git a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf b= /MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf index f2e04cfd00..6eb2766b93 100644 --- a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf +++ b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf @@ -1,7 +1,7 @@ ## @file # DXE Reset System Library instance that calls gRT->ResetSystem(). # -# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2018, Intel Corporation. All rights=20 +reserved.
# # This program and the accompanying materials # are licensed and made a= vailable under the terms and conditions of the BSD License @@ -35,6 +35,5 @= @ [Packages] MdeModulePkg/MdeModulePkg.dec =20 [LibraryClasses] - DebugLib UefiRuntimeLib =20 diff --git a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c b/M= deModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c index b7e10110b0..30225d73a5 100644 --- a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c +++ b/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c @@ -1,7 +1,7 @@ /** @file PEI Reset System Library instance that calls the ResetSystem2() PEI Serv= ice. =20 - Copyright (c) 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2017 - 2018, Intel Corporation. All rights=20 + reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -13,9 +13,7 @@ **/ =20 #include - #include -#include #include =20 /** diff --git a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.inf b= /MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.inf index e82ec6b2b6..b1b9388c63 100644 --- a/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.inf +++ b/MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.inf @@ -1,7 +1,7 @@ ## @file # PEI Reset System Library instance that calls the ResetSystem2() PEI Ser= vice. # -# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2018, Intel Corporation. All rights=20 +reserved.
# # This program and the accompanying materials # are licensed and made a= vailable under the terms and conditions of the BSD License @@ -35,6 +35,5 @= @ [Packages] MdeModulePkg/MdeModulePkg.dec =20 [LibraryClasses] - DebugLib PeiServicesLib =20 diff --git a/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c b/MdeModul= ePkg/Library/ResetUtilityLib/ResetUtility.c index 5bbe002be0..90de94ca9b 100644 --- a/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c +++ b/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c @@ -37,7 +37,6 @@ typedef struct { are not initialized. For DXE, you can add gEfiResetArchProtocolGui= d to your DEPEX. =20 - @param[in] ResetType Base reset type as defined in UEFI spec. @param[in] ResetSubtype GUID pointer for the reset subtype to be used. =20 **/ @@ -90,7 +89,7 @@ GetResetPlatformSpecificGuid ( } =20 // - // Determine the number of bytes in in the Null-terminated Unicode strin= g + // Determine the number of bytes in the Null-terminated Unicode=20 + string // at the beginning of ResetData including the Null terminator. // ResetDataStringSize =3D StrnSizeS (ResetData, (DataSize / sizeof (CHAR16= ))); diff --git a/MdeModulePkg/Library/ResetUtilityLib/ResetUtilityLib.inf = b/MdeModulePkg/Library/ResetUtilityLib/ResetUtilityLib.inf index 7a403749c5..2a4e53a8a6 100644 --- a/MdeModulePkg/Library/ResetUtilityLib/ResetUtilityLib.inf +++ b/MdeModulePkg/Library/ResetUtilityLib/ResetUtilityLib.inf @@ -1,10 +1,7 @@ ## @file # This file contains the Reset Utility functions. # -# The application pops up a menu showing all the boot options referenced = by -# BootOrder NV variable and user can choose to boot from one of them. -# -# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2018, Intel Corporation. All rights=20 +reserved.
# Copyright (c) 2016, Microsoft Corporation. All rights reserved.
# = This program and the accompanying materials # are licensed and made avai= lable under the terms and conditions of the BSD License diff --git a/MdeMod= ulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 297b02ffa9..0= 695ce607e 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -54,6 +54,9 @@ [LibraryClasses] ## @libraryclass Defines a set of methods to reset whole system. ResetSystemLib|Include/Library/ResetSystemLib.h =20 + ## @libraryclass Defines a set of helper functions for resetting the s= ystem. + ResetUtilityLib|Include/Library/ResetUtilityLib.h + ## @libraryclass Defines a set of methods related do S3 mode. # This library class is no longer used and modules using this library = should # directly locate EFI_PEI_S3_RESUME_PPI defined in PI 1.2 specificatio= n. @@ -1422,8 +1425,8 @@ [PcdsFixedAtBuild, PcdsPatchableInModule] # @Prompt CapsuleMax value in capsule report variable. gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax|0xFFFF|UINT16|0x00000107 =20 - ## Indicates the allowable maximum number of Reset Filters or Reset Hand= lers in PEI phase. - # @Prompt Maximum Number of PEI Reset Filters or Reset Handlers. + ## Indicates the allowable maximum number of Reset Filters, Reset Notifi= cations or Reset Handlers in PEI phase. + # @Prompt Maximum Number of PEI Reset Filters, Reset Notifications or Re= set Handlers. gEfiMdeModulePkgTokenSpaceGuid.PcdMaximumPeiResetNotifies|0x10|UINT32|0x= 00000109 =20 [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] diff --git a/MdeModule= Pkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index 0e068422e4..d8cc= 7416c5 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -4,7 +4,7 @@ // It also provides the definitions(including PPIs/PROTOCOLs/GUIDs and lib= rary classes) // and libraries instances, which are used for those modules= . // -// Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.
+// Copyright (c) 2007 - 2018, Intel Corporation. All rights=20 +reserved.
// // This program and the accompanying materials are licensed and made avail= able under // the terms and conditions of the BSD License that accompanies= this distribution. @@ -1059,6 +1059,11 @@ =20 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleMax_HELP #language e= n-US "CapsuleMax value in capsule report variable." =20 +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdMaximumPeiResetNotifies_PROM= PT #language en-US "Maximum Number of PEI Reset Filters, Reset Notificatio= ns or Reset Handlers." + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdMaximumPeiResetNotifies_HELP= #language en-US "Indicates the allowable maximum number of Reset Filters,=
\n" + = "Reset Notifications or Reset Handlers in PEI phase." + #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdRecoveryFileName_PROMPT #la= nguage en-US "Recover file name in PEI phase" =20 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdRecoveryFileName_HELP #lang= uage en-US "This is recover file name in PEI phase.\n" diff --git a/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.c b/MdeModul= ePkg/Universal/ResetSystemPei/ResetSystem.c index 4dfe303f77..c2ee592d56 100644 --- a/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.c +++ b/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.c @@ -80,13 +80,13 @@ EFI_PEI_PPI_DESCRIPTOR mPpiListReset[] =3D { Register a notification function to be called when ResetSystem() is call= ed. =20 The RegisterResetNotify() function registers a notification function tha= t is called when - ResetSystem()is called and prior to completing the reset of the platform= . + ResetSystem() is called and prior to completing the reset of the platfor= m. The registered functions must not perform a platform reset themselves. T= hese notifications are intended only for the notification of components which= may need some special-purpose maintenance prior to the platform resetting. The list of registered reset notification functions are processed if Res= etSystem()is called before ExitBootServices(). The list of registered reset notification fun= ctions is ignored if - ResetSystem()is called after ExitBootServices(). + ResetSystem() is called after ExitBootServices(). =20 @param[in] This A pointer to the EFI_RESET_NOTIFICATION_PR= OTOCOL instance. @param[in] ResetFunction Points to the function to be called when a= ResetSystem() is executed. @@ -312,7 +312,7 @@ ResetSystem2 ( // // Indicate reset system runtime service is called. // - REPORT_STATUS_CODE (EFI_PROGRESS_CODE, (EFI_SOFTWARE_EFI_RUNTIME_SERVI= CE | EFI_SW_RS_PC_RESET_SYSTEM)); + REPORT_STATUS_CODE (EFI_PROGRESS_CODE, (EFI_SOFTWARE_PEI_SERVICE |=20 + EFI_SW_RS_PC_RESET_SYSTEM)); } =20 // diff --git a/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.h b/MdeModul= ePkg/Universal/ResetSystemPei/ResetSystem.h index b623a4c381..8e9f872056 100644 --- a/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.h +++ b/MdeModulePkg/Universal/ResetSystemPei/ResetSystem.h @@ -1,6 +1,6 @@ /** @file =20 - Copyright (c) 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2017 - 2018, Intel Corporation. All rights=20 + reserved.
=20 This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License @@ -34,7 +34,7 @@ =20 =20 // -// The maximum recurstion depth to ResetSystem() by reset notification han= dlers +// The maximum recursion depth to ResetSystem() by reset notification=20 +handlers // #define MAX_RESET_NOTIFY_DEPTH 10 =20 diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/M= deModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c index 4b5af76999..2c795426f5 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c @@ -294,7 +294,7 @@ ResetSystem ( } // // call reset notification functions registered through the=20 - // EDKII_PLATFORM_SPECIFIC_RESET_NOTIFICATION_PROTOCOL. + // EDKII_PLATFORM_SPECIFIC_RESET_HANDLER_PROTOCOL. // for ( Link =3D GetFirstNode (&mPlatformSpecificResetHandler.ResetNot= ifies) ; !IsNull (&mPlatformSpecificResetHandler.ResetNotifies, Link) -- 2.16.1.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel