From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B0E4321CF1CE7 for ; Mon, 12 Feb 2018 16:45:37 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2018 16:51:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,504,1511856000"; d="scan'208";a="174369901" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 12 Feb 2018 16:51:27 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Feb 2018 16:51:26 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Feb 2018 16:51:26 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Tue, 13 Feb 2018 08:51:24 +0800 From: "Zeng, Star" To: Laszlo Ersek , edk2-devel-01 CC: "Dong, Eric" , "Carsey, Jaben" , "Ni, Ruiyu" , "Zeng, Star" Thread-Topic: [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency Thread-Index: AQHTpAfB55iPcLrsbUKl1rXNrbDZ8qOhgWCw Date: Tue, 13 Feb 2018 00:51:23 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA3EF5A@shsmsx102.ccr.corp.intel.com> References: <20180212134513.6882-1-lersek@redhat.com> <20180212134513.6882-4-lersek@redhat.com> In-Reply-To: <20180212134513.6882-4-lersek@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 00:45:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Laszlo Ersek [mailto:lersek@redhat.com]=20 Sent: Monday, February 12, 2018 9:45 PM To: edk2-devel-01 Cc: Dong, Eric ; Carsey, Jaben ; Ni, Ruiyu ; Zeng, Star Subject: [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous Ti= merLib dependency In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the useles= s perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData() function w= as removed. No TimerLib API calls are left, thus remove the TimerLib class = dependency from "InternalBm.h" and "UefiBootManagerLib.inf" as well. Cc: Eric Dong Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 - MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 - 2 files changed, 2 deletions(-) diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf= b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf index 1adffd70d06a..8d5b89ea2970 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf @@ -52,7 +52,6 @@ [LibraryClasses] PcdLib BaseLib UefiLib - TimerLib DebugLib PrintLib BaseMemoryLib diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModu= lePkg/Library/UefiBootManagerLib/InternalBm.h index ed0cd16ef322..25a1d522fe84 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h +++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h @@ -68,7 +68,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include #include #include -#include #i= nclude #include = #include -- 2.14.1.3.gb7cf6e02401b