From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1DC7D2034D8C5 for ; Thu, 22 Feb 2018 19:18:46 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Feb 2018 19:24:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,381,1515484800"; d="scan'208";a="20165988" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 22 Feb 2018 19:24:47 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Feb 2018 19:24:46 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Fri, 23 Feb 2018 11:24:46 +0800 From: "Zeng, Star" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: Sean Brogan , Bret Barkelew , "Yao, Jiewen" , "Dong, Eric" , "Zeng, Star" Thread-Topic: [Patch v2 0/3] MdeModulePkg: Add Boot Logo 2 Protocol Thread-Index: AQHTpq+ivHZLdRgl30GyaRhYp41L2aOxXRjw Date: Fri, 23 Feb 2018 03:24:45 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA4281C@shsmsx102.ccr.corp.intel.com> References: <20180215225205.16856-1-michael.d.kinney@intel.com> In-Reply-To: <20180215225205.16856-1-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v2 0/3] MdeModulePkg: Add Boot Logo 2 Protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 03:18:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Two minor comments, with them handled, Reviewed-by: Star Zeng . 1. For patch 1 and 2, update 'registers' to 'registered' in the comments fo= r parameters DestinationX/DestinationY/Width/Height of EDKII_GET_BOOT_LOGO2= ? 2. For patch 3, update 'functionm' to ' function'? Thanks, Star -----Original Message----- From: Kinney, Michael D=20 Sent: Friday, February 16, 2018 6:52 AM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Bret Barkelew ; Yao, Jiewen ; Zeng, Star ; Dong, Eric ; Kinney, Michael D Subject: [Patch v2 0/3] MdeModulePkg: Add Boot Logo 2 Protocol V2: * Make Boot Logo2 Protocol higher priority than Boot Logo Protocol. If both are present, then only use Boot Logo 2 Protocol Branch for review: https://github.com/mdkinney/edk2/tree/Bug_799_BootLogo2Protocol_V4 https://bugzilla.tianocore.org/show_bug.cgi?id=3D799 Based on content from the following branch/commit: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2= e60302b2d Add new Boot Logo 2 Protocol that adds a GetBootLogo() service that can be = used to retrieve the GOP BLT buffer, location, and size of the boot logo th= at was previously registered with the SetBootLogo() service. The Boot Logo 2 Protocol service GetBootLogo() is amended to return the poi= nter to the GOP BLT buffer previously registered with the SetBootLogo() ser= vice. Cc: Sean Brogan Cc: Bret Barkelew Cc: Jiewen Yao Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney Kinney, Michael D (2): MdeModulePkg: Add Boot Logo 2 Protocol MdeModulePkg/BootLogoLib: Use Boot Logo 2 Protocol Michael D Kinney (1): MdeModulePkg/BootGraphicsResourceDxe: Add Boot Logo 2 Protocol MdeModulePkg/Include/Protocol/BootLogo2.h | 118 ++++++++++++ MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 32 +++- MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 2 + MdeModulePkg/MdeModulePkg.dec | 3 + .../BootGraphicsResourceTableDxe.c | 208 +++++++++++++++++= ++-- .../BootGraphicsResourceTableDxe.inf | 2 + 6 files changed, 349 insertions(+), 16 deletions(-) create mode 100644 Md= eModulePkg/Include/Protocol/BootLogo2.h -- 2.14.2.windows.3