From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 30F0B222630CB for ; Sun, 11 Mar 2018 19:22:02 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2018 19:28:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,459,1515484800"; d="scan'208";a="37327898" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 11 Mar 2018 19:28:22 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 11 Mar 2018 19:28:22 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 11 Mar 2018 19:28:22 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.226]) with mapi id 14.03.0319.002; Mon, 12 Mar 2018 10:28:20 +0800 From: "Zeng, Star" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Ni, Ruiyu" , "Zeng, Star" Thread-Topic: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU Thread-Index: AQHTuUvsfj7jgLygoEiK6WuqW3DjGqPLVaIAgACKsxA= Date: Mon, 12 Mar 2018 02:28:19 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA625DE@shsmsx102.ccr.corp.intel.com> References: <20180311151619.1260-1-star.zeng@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 02:22:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hao, Good catch. :) It is a mistake when splitting patch. Thanks, Star -----Original Message----- From: Wu, Hao A=20 Sent: Monday, March 12, 2018 10:10 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni, Ruiyu Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements aft= er supporting IOMMU One minor comment: For patch 3, within changes in function Usb3PciIoNotify(): Usb3NamedEventListen ( &gEfiDxeSmmReadyToLockProtocolGuid, TPL_NOTIFY, Usb3DxeSmmReadyToLockNotify, &SmmReadyToLockEvent <--- Does this change related with patch 2? ); Otherwise, for me, patch 2 is storing the event for DxeSmmReadyToLockProtoc= ol in an event which will be closed right after. Best Regards, Hao Wu > -----Original Message----- > From: Zeng, Star > Sent: Sunday, March 11, 2018 11:16 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Yao, Jiewen; Ni, Ruiyu; Wu, Hao A > Subject: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements=20 > after supporting IOMMU >=20 > Please get detailed information in the separated patches. >=20 > Cc: Jiewen Yao > Cc: Ruiyu Ni > Cc: Hao Wu >=20 > Star Zeng (3): > SourceLevelDebugPkg DebugCommUsb3: Refine some formats > SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer > SourceLevelDebugPkg DebugCommUsb3: Use the Handle from DebugAgentLib >=20 > .../DebugCommunicationLibUsb3Common.c | 96 +++++- > .../DebugCommunicationLibUsb3Dxe.c | 365 ++++++++++++---= ------ > .../DebugCommunicationLibUsb3Dxe.inf | 11 +- > .../DebugCommunicationLibUsb3Internal.h | 60 +--- > .../DebugCommunicationLibUsb3Pei.c | 50 ++- > .../DebugCommunicationLibUsb3Pei.inf | 4 +- > 6 files changed, 332 insertions(+), 254 deletions(-) >=20 > -- > 2.13.3.windows.1