From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E4A17220C2A4C for ; Mon, 12 Mar 2018 23:30:54 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2018 23:37:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,464,1515484800"; d="scan'208";a="33360221" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 12 Mar 2018 23:37:15 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Mar 2018 23:37:15 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Mar 2018 23:37:14 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002; Tue, 13 Mar 2018 14:37:13 +0800 From: "Zeng, Star" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [Patch] MdeModulePkg PCD: Remove unused PCD attribute PCD_TYPE_SKU_ENABLED Thread-Index: AQHTupT435BFFwuWjEK3v9S17quX2qPNthtQ Date: Tue, 13 Mar 2018 06:37:12 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA62C2E@shsmsx102.ccr.corp.intel.com> References: <1520410518-17144-1-git-send-email-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1E5CC4@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1E5CC4@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjhkZTM4MGEtMTMyMS00ZWRjLThkZWItYmFlMzg4MjVlNjc3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJUMFRhUVliQVk0TVo4R09SdE5VWTNYZ1hIWDF3Y09XRWFQdk9ZakV2RmVnTmZJN2tyN0hNRDUrT1Joc1Bpc2NCIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg PCD: Remove unused PCD attribute PCD_TYPE_SKU_ENABLED X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 06:30:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Gao, Liming Sent: Wednesday, March 7, 2018 4:15 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] MdeModulePkg PCD: Remove unused PCD attribute PCD_TYPE_SKU= _ENABLED PcdDb optimization has handled PCD DB for each SKU, not for single PCD. So, this PCD attribute is not used any more. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Reviewed-by: Liming Gao --- MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h | 3 +-- MdeModulePkg/Universal/PCD/Dxe/Pcd.inf | 3 +-- MdeModulePkg/Universal/PCD/Dxe/PcdDxe.uni | 3 +-- MdeModulePkg/Universal/PCD/Pei/Pcd.inf | 3 +-- MdeModulePkg/Universal/PCD/Pei/PcdPeim.uni | 3 +-- 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h b/MdeModu= lePkg/Include/Guid/PcdDataBaseSignatureGuid.h index d670af1..5767ac8 100644 --- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h +++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h @@ -1,7 +1,7 @@ /** @file Guid for Pcd DataBase Signature. =20 -Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2012 - 2018, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availabl= e under the terms and conditions of the BSD License that accompanies this = distribution. The full text of the license may be found at @@ -30,7 +30,6 @@ typedef UIN= T64 SKU_ID; #define PCD_TYPE_DATA (0x0U << PCD_TYPE_SHIFT) #define PCD_TYPE_HII (0x8U << PCD_TYPE_SHIFT) #define PCD_TYPE_VPD (0x4U << PCD_TYPE_SHIFT) -#define PCD_TYPE_SKU_ENABLED (0x2U << PCD_TYPE_SHIFT) #define PCD_TYPE_STRING (0x1U << PCD_TYPE_SHIFT) =20 #define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD= | PCD_TYPE_SKU_ENABLED | PCD_TYPE_STRING) diff --git a/MdeModulePkg/Universal/PCD/Dxe/Pcd.inf b/MdeModulePkg/Universa= l/PCD/Dxe/Pcd.inf index 54cd8d9..a20b645 100644 --- a/MdeModulePkg/Universal/PCD/Dxe/Pcd.inf +++ b/MdeModulePkg/Universal/PCD/Dxe/Pcd.inf @@ -174,7 +174,6 @@ # PCD_TYPE_DATA # PCD_TYPE_HII # PCD_TYPE_VPD -# PCD_TYPE_SKU_ENABLED # PCD_TYPE_STRING # Datum Type : indicate PCD vaue type from following macro: # PCD_DATUM_TYPE_POINTER @@ -279,7 +278,7 @@ # - Variable GUID for HII type PCD # - Token space GUID for dynamicex type PCD=20 # =20 -# Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
+# Copyright (c) 2006 - 2018, Intel Corporation. All rights=20 +reserved.
# # This program and the accompanying materials # are licensed and made a= vailable under the terms and conditions of the BSD License diff --git a/Mde= ModulePkg/Universal/PCD/Dxe/PcdDxe.uni b/MdeModulePkg/Universal/PCD/Dxe/Pcd= Dxe.uni index 922391c..0883ad8 100644 --- a/MdeModulePkg/Universal/PCD/Dxe/PcdDxe.uni +++ b/MdeModulePkg/Universal/PCD/Dxe/PcdDxe.uni @@ -174,7 +174,6 @@ // PCD_TYPE_DATA // PCD_TYPE_HII // PCD_TYPE_VPD -// PCD_TYPE_SKU_ENABLED // PCD_TYPE_STRING // Datum Type : indicate PCD vaue type from following macro: // PCD_DATUM_TYPE_POINTER @@ -279,7 +278,7 @@ // - Variable GUID for HII type PCD // - Token space GUID for dynamicex type PCD // -// Copyright (c) 2006 - = 2014, Intel Corporation. All rights reserved.
+// Copyright (c) 2006 - 2018, Intel Corporation. All rights=20 +reserved.
// // This program and the accompanying materials // are licensed and made a= vailable under the terms and conditions of the BSD License diff --git a/Mde= ModulePkg/Universal/PCD/Pei/Pcd.inf b/MdeModulePkg/Universal/PCD/Pei/Pcd.in= f index e1ea5be..3cba289 100644 --- a/MdeModulePkg/Universal/PCD/Pei/Pcd.inf +++ b/MdeModulePkg/Universal/PCD/Pei/Pcd.inf @@ -173,7 +173,6 @@ # PCD_TYPE_DATA # PCD_TYPE_HII # PCD_TYPE_VPD -# PCD_TYPE_SKU_ENABLED # PCD_TYPE_STRING # Datum Type : indicate PCD vaue type from following macro: # PCD_DATUM_TYPE_POINTER @@ -278,7 +277,7 @@ # - Variable GUID for HII type PCD # - Token space GUID for dynamicex type PCD=20 # =20 -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2006 - 2018, Intel Corporation. All rights=20 +reserved.
# # This program and the accompanying materials # are licensed and made a= vailable under the terms and conditions of the BSD License diff --git a/Mde= ModulePkg/Universal/PCD/Pei/PcdPeim.uni b/MdeModulePkg/Universal/PCD/Pei/Pc= dPeim.uni index b0d3f1f..3e7c556 100644 --- a/MdeModulePkg/Universal/PCD/Pei/PcdPeim.uni +++ b/MdeModulePkg/Universal/PCD/Pei/PcdPeim.uni @@ -173,7 +173,6 @@ // PCD_TYPE_DATA // PCD_TYPE_HII // PCD_TYPE_VPD -// PCD_TYPE_SKU_ENABLED // PCD_TYPE_STRING // Datum Type : indicate PCD vaue type from following macro: // PCD_DATUM_TYPE_POINTER @@ -278,7 +277,7 @@ // - Variable GUID for HII type PCD // - Token space GUID for dynamicex type PCD // -// Copyright (c) 2006 - = 2014, Intel Corporation. All rights reserved.
+// Copyright (c) 2006 - 2018, Intel Corporation. All rights=20 +reserved.
// // This program and the accompanying materials // are licensed and made a= vailable under the terms and conditions of the BSD License -- 2.8.0.windows.1