* Re: [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
2018-03-13 9:04 [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET Star Zeng
@ 2018-03-13 9:14 ` Thomas Lamprecht
2018-03-13 9:22 ` Thomas Lamprecht
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Thomas Lamprecht @ 2018-03-13 9:14 UTC (permalink / raw)
To: Star Zeng, edk2-devel; +Cc: Liming Gao
On 03/13/2018 10:04 AM, Star Zeng wrote:
> Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET.
> This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> index 5767ac82da21..c30a3ac7200f 100644
> --- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> +++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> @@ -32,7 +32,7 @@ typedef UINT64 SKU_ID;
> #define PCD_TYPE_VPD (0x4U << PCD_TYPE_SHIFT)
> #define PCD_TYPE_STRING (0x1U << PCD_TYPE_SHIFT)
>
> -#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_SKU_ENABLED | PCD_TYPE_STRING)
> +#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_STRING)
>
> #define PCD_DATUM_TYPE_SHIFT 24
>
>
Works again here, much thanks for your fast response!
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
2018-03-13 9:04 [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET Star Zeng
2018-03-13 9:14 ` Thomas Lamprecht
@ 2018-03-13 9:22 ` Thomas Lamprecht
2018-03-13 9:37 ` Zeng, Star
2018-03-13 12:42 ` Ard Biesheuvel
2018-03-13 12:47 ` Dong, Eric
3 siblings, 1 reply; 7+ messages in thread
From: Thomas Lamprecht @ 2018-03-13 9:22 UTC (permalink / raw)
To: Star Zeng, edk2-devel; +Cc: Liming Gao
On 03/13/2018 10:04 AM, Star Zeng wrote:
> Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET.
> This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> index 5767ac82da21..c30a3ac7200f 100644
> --- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> +++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> @@ -32,7 +32,7 @@ typedef UINT64 SKU_ID;
> #define PCD_TYPE_VPD (0x4U << PCD_TYPE_SHIFT)
> #define PCD_TYPE_STRING (0x1U << PCD_TYPE_SHIFT)
>
> -#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_SKU_ENABLED | PCD_TYPE_STRING)
> +#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_STRING)
>
> #define PCD_DATUM_TYPE_SHIFT 24
>
>
Oh forgot to mention, had a bit problems to apply this with git am,
could it be that your MTA changed out the edk2 newline format (windows,
\r\n) with an plain UNIX one (\n)?
Sorry that I forgot to mention this in my other mail.
cheers,
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
2018-03-13 9:22 ` Thomas Lamprecht
@ 2018-03-13 9:37 ` Zeng, Star
0 siblings, 0 replies; 7+ messages in thread
From: Zeng, Star @ 2018-03-13 9:37 UTC (permalink / raw)
To: Thomas Lamprecht, edk2-devel@lists.01.org; +Cc: Gao, Liming, Zeng, Star
Maybe.
I am using the MS outlook.
Thanks,
Star
-----Original Message-----
From: Thomas Lamprecht [mailto:t.lamprecht@proxmox.com]
Sent: Tuesday, March 13, 2018 5:22 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
On 03/13/2018 10:04 AM, Star Zeng wrote:
> Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET.
> This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> index 5767ac82da21..c30a3ac7200f 100644
> --- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> +++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> @@ -32,7 +32,7 @@ typedef UINT64 SKU_ID;
> #define PCD_TYPE_VPD (0x4U << PCD_TYPE_SHIFT)
> #define PCD_TYPE_STRING (0x1U << PCD_TYPE_SHIFT)
>
> -#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_SKU_ENABLED | PCD_TYPE_STRING)
> +#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_STRING)
>
> #define PCD_DATUM_TYPE_SHIFT 24
>
>
Oh forgot to mention, had a bit problems to apply this with git am, could it be that your MTA changed out the edk2 newline format (windows,
\r\n) with an plain UNIX one (\n)?
Sorry that I forgot to mention this in my other mail.
cheers,
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
2018-03-13 9:04 [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET Star Zeng
2018-03-13 9:14 ` Thomas Lamprecht
2018-03-13 9:22 ` Thomas Lamprecht
@ 2018-03-13 12:42 ` Ard Biesheuvel
2018-03-13 12:52 ` Zeng, Star
2018-03-13 12:47 ` Dong, Eric
3 siblings, 1 reply; 7+ messages in thread
From: Ard Biesheuvel @ 2018-03-13 12:42 UTC (permalink / raw)
To: Star Zeng; +Cc: edk2-devel@lists.01.org, Liming Gao, Thomas Lamprecht
On 13 March 2018 at 09:04, Star Zeng <star.zeng@intel.com> wrote:
> Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET.
> This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Please apply
> ---
> MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> index 5767ac82da21..c30a3ac7200f 100644
> --- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> +++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> @@ -32,7 +32,7 @@ typedef UINT64 SKU_ID;
> #define PCD_TYPE_VPD (0x4U << PCD_TYPE_SHIFT)
> #define PCD_TYPE_STRING (0x1U << PCD_TYPE_SHIFT)
>
> -#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_SKU_ENABLED | PCD_TYPE_STRING)
> +#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_STRING)
>
> #define PCD_DATUM_TYPE_SHIFT 24
>
> --
> 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
2018-03-13 12:42 ` Ard Biesheuvel
@ 2018-03-13 12:52 ` Zeng, Star
0 siblings, 0 replies; 7+ messages in thread
From: Zeng, Star @ 2018-03-13 12:52 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: edk2-devel@lists.01.org, Thomas Lamprecht, Gao, Liming,
Zeng, Star
Not wait more time any more as it is an urgent build failure.
Pushed at d154a4dfaec4bf25acaca643e9ac15a3bc8d7a12.
Thanks all.
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
Sent: Tuesday, March 13, 2018 8:42 PM
To: Zeng, Star <star.zeng@intel.com>
Cc: edk2-devel@lists.01.org; Thomas Lamprecht <t.lamprecht@proxmox.com>; Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
On 13 March 2018 at 09:04, Star Zeng <star.zeng@intel.com> wrote:
> Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET.
> This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Please apply
> ---
> MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> index 5767ac82da21..c30a3ac7200f 100644
> --- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> +++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> @@ -32,7 +32,7 @@ typedef UINT64 SKU_ID;
> #define PCD_TYPE_VPD (0x4U << PCD_TYPE_SHIFT)
> #define PCD_TYPE_STRING (0x1U << PCD_TYPE_SHIFT)
>
> -#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_SKU_ENABLED | PCD_TYPE_STRING)
> +#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_STRING)
>
> #define PCD_DATUM_TYPE_SHIFT 24
>
> --
> 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
2018-03-13 9:04 [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET Star Zeng
` (2 preceding siblings ...)
2018-03-13 12:42 ` Ard Biesheuvel
@ 2018-03-13 12:47 ` Dong, Eric
3 siblings, 0 replies; 7+ messages in thread
From: Dong, Eric @ 2018-03-13 12:47 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org
Cc: Gao, Liming, Zeng, Star, Thomas Lamprecht
Reviewed-by: Eric Dong <eric.dong@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star Zeng
Sent: Tuesday, March 13, 2018 5:04 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>; Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: [edk2] [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET.
This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
index 5767ac82da21..c30a3ac7200f 100644
--- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
+++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
@@ -32,7 +32,7 @@ typedef UINT64 SKU_ID;
#define PCD_TYPE_VPD (0x4U << PCD_TYPE_SHIFT)
#define PCD_TYPE_STRING (0x1U << PCD_TYPE_SHIFT)
-#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_SKU_ENABLED | PCD_TYPE_STRING)
+#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_STRING)
#define PCD_DATUM_TYPE_SHIFT 24
--
2.7.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread