From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1FC6C224CCC38 for ; Tue, 13 Mar 2018 05:52:08 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 05:58:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,464,1515484800"; d="scan'208";a="182267556" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 13 Mar 2018 05:58:29 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 13 Mar 2018 05:58:23 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 13 Mar 2018 05:58:22 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.108]) with mapi id 14.03.0319.002; Tue, 13 Mar 2018 20:58:20 +0800 From: "Zeng, Star" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Ni, Ruiyu" , "Zeng, Star" Thread-Topic: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU Thread-Index: AQHTuUvsfj7jgLygoEiK6WuqW3DjGqPLVaIAgACKsxCAABOF0IABqMUAgACGlbA= Date: Tue, 13 Mar 2018 12:58:20 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA63F3F@shsmsx102.ccr.corp.intel.com> References: <20180311151619.1260-1-star.zeng@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BA625DE@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BA6263B@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 12:52:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good finding. The typo has been fixed in local. Thanks very much. Star -----Original Message----- From: Wu, Hao A=20 Sent: Tuesday, March 13, 2018 8:56 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni, Ruiyu Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements aft= er supporting IOMMU > -----Original Message----- > From: Zeng, Star > Sent: Monday, March 12, 2018 11:37 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Yao, Jiewen; Ni, Ruiyu; Zeng, Star > Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: > Enhancements after supporting IOMMU >=20 > I have handled the mistake at > https://github.com/lzeng14/edk2/tree/DebugCommUsb3AfterIOMMUV2_WIP. >=20 > If you need, I can resend V2 patch. :) Another comment for patch 2, also within function Usb3PciIoNotify(): if (Usb3GetIoMmu !=3D NULL) { ^^^ should be: if (Usb3GetIoMmu () !=3D NULL) { With that typo fixed, the 2nd commit on the above link seems good to me. And for the series, Reviewed-by: Hao Wu Best Regards, Hao Wu >=20 > Thanks, > Star > -----Original Message----- > From: Zeng, Star > Sent: Monday, March 12, 2018 10:28 AM > To: Wu, Hao A ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Ni, Ruiyu=20 > ; Zeng, Star > Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: > Enhancements after supporting IOMMU >=20 > Hao, >=20 > Good catch. :) > It is a mistake when splitting patch. >=20 >=20 > Thanks, > Star > -----Original Message----- > From: Wu, Hao A > Sent: Monday, March 12, 2018 10:10 AM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Ni, Ruiyu > Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: > Enhancements after supporting IOMMU >=20 > One minor comment: > For patch 3, within changes in function Usb3PciIoNotify(): >=20 > Usb3NamedEventListen ( > &gEfiDxeSmmReadyToLockProtocolGuid, > TPL_NOTIFY, > Usb3DxeSmmReadyToLockNotify, > &SmmReadyToLockEvent <--- Does this change related with patch 2? > ); >=20 > Otherwise, for me, patch 2 is storing the event for=20 > DxeSmmReadyToLockProtocol in an event which will be closed right after. >=20 >=20 > Best Regards, > Hao Wu >=20 >=20 > > -----Original Message----- > > From: Zeng, Star > > Sent: Sunday, March 11, 2018 11:16 PM > > To: edk2-devel@lists.01.org > > Cc: Zeng, Star; Yao, Jiewen; Ni, Ruiyu; Wu, Hao A > > Subject: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements=20 > > after supporting IOMMU > > > > Please get detailed information in the separated patches. > > > > Cc: Jiewen Yao > > Cc: Ruiyu Ni > > Cc: Hao Wu > > > > Star Zeng (3): > > SourceLevelDebugPkg DebugCommUsb3: Refine some formats > > SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer > > SourceLevelDebugPkg DebugCommUsb3: Use the Handle from > DebugAgentLib > > > > .../DebugCommunicationLibUsb3Common.c | 96 +++++- > > .../DebugCommunicationLibUsb3Dxe.c | 365 ++++++++++++-= -------- > > .../DebugCommunicationLibUsb3Dxe.inf | 11 +- > > .../DebugCommunicationLibUsb3Internal.h | 60 +--- > > .../DebugCommunicationLibUsb3Pei.c | 50 ++- > > .../DebugCommunicationLibUsb3Pei.inf | 4 +- > > 6 files changed, 332 insertions(+), 254 deletions(-) > > > > -- > > 2.13.3.windows.1