From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D130B2246801F for ; Sat, 17 Mar 2018 01:20:52 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Mar 2018 01:27:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,319,1517904000"; d="scan'208";a="39749368" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 17 Mar 2018 01:27:18 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 17 Mar 2018 01:27:18 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 17 Mar 2018 01:27:16 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.108]) with mapi id 14.03.0319.002; Sat, 17 Mar 2018 16:27:13 +0800 From: "Zeng, Star" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [patch] MdeModulePkg: Fix coding style issues in file/function comments Thread-Index: AQHTvOdP3IIdP/xyMUyYMg3BOQ4w76PUGLhQ Date: Sat, 17 Mar 2018 08:27:12 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA6BF49@shsmsx102.ccr.corp.intel.com> References: <1521177951-75328-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1521177951-75328-1-git-send-email-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg: Fix coding style issues in file/function comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2018 08:20:53 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Only one minor comment. Do you think BaseBmpSupportLib.uni should be also updated accordingly based= on the change in BaseBmpSupportLib? With that covered, Reviewed-by: Star Zeng . Thanks, Star -----Original Message----- From: Bi, Dandan=20 Sent: Friday, March 16, 2018 1:26 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [patch] MdeModulePkg: Fix coding style issues in file/function com= ments Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdeModulePkg/Include/Protocol/BootLogo2.h | 2 +- MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf | 1 + MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 12 ++++++++= +--- MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmpDebugPrint.c | 4 ++-- 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Include/Protocol/BootLogo2.h b/MdeModulePkg/Inclu= de/Protocol/BootLogo2.h index 583a253..905197a 100644 --- a/MdeModulePkg/Include/Protocol/BootLogo2.h +++ b/MdeModulePkg/Include/Protocol/BootLogo2.h @@ -1,6 +1,6 @@ -/** +/** @file Boot Logo 2 Protocol is used to convey information of Logo dispayed during= boot. =20 The Boot Logo 2 Protocol is a replacement for the Boot Logo Protocol. If = a platform produces both the Boot Logo 2 Protocol and the Boot Logo Protoc= ol then the Boot Logo 2 Protocol must be used instead of the Boot Logo Pro= tocol. diff --git a/MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf b= /MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf index 02c3fae..2ee2e7e 100644 --- a/MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf +++ b/MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf @@ -1,6 +1,7 @@ ## @file +# Base library to support BMP graphics image conversion. # # Provides services to convert a BMP graphics image to a GOP BLT buffer an= d # from a GOP BLT buffer to a BMP graphics image. # # Copyright (c) 2017, Microsoft Corporation diff --git a/MdeModulePkg/Univ= ersal/EsrtFmpDxe/EsrtFmp.c b/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c index b98430e..3da4a62 100644 --- a/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c +++ b/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c @@ -36,13 +36,16 @@ #include #include #include #i= nclude =20 -// -// Print ESRT to debug console -// +/** + Print ESRT to debug console. + + @param[in] Table Pointer to the ESRT table. + +**/ VOID EFIAPI PrintTable ( IN EFI_SYSTEM_RESOURCE_TABLE *Table ); @@ -130,10 +133,13 @@ IsSystemFmp ( /** Function to create a single ESRT Entry and add it to the ESRT given a FMP descriptor. If the guid is already in the ESRT it will be ignored. The ESRT will grow if it does not have enough room. =20 + @param[in] FmpImageInfoBuf Pointer to the EFI_FIRMWARE_IMAGE_DESCRIP= TOR. + @param[in] FmpVersion FMP Version. + @return Status code. =20 **/ EFI_STATUS EFIAPI diff --git a/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmpDebugPrint.c b/MdeMod= ulePkg/Universal/EsrtFmpDxe/EsrtFmpDebugPrint.c index b4e5135..8e60385 100644 --- a/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmpDebugPrint.c +++ b/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmpDebugPrint.c @@ -32,11 +32,11 @@ #include #include #include =20 /** - Function to print a single ESRT Entry (ESRE) to the debug console + Function to print a single ESRT Entry (ESRE) to the debug console. =20 Print Format: | 00000000-0000-0000-0000-000000000000 | SSSSSSSSSSSS | 0x00000000 | 0x0= 0000000 | 0x00000000 | 0x00000000 | 0x00000000 | =20 @param[in] Entry - Pointer to an ESRE entry @@ -99,11 +99,11 @@ PrintO= utEsrtEntry ( =20 return EFI_SUCCESS; } =20 /** - Function to print the ESRT table to the debug console + Function to print the ESRT table to the debug console. =20 @param[in] Table - Pointer to the ESRT table **/ VOID EFIAPI -- 1.9.5.msysgit.1