From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 70D4B21ED1C60 for ; Mon, 19 Mar 2018 02:11:11 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2018 02:17:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,329,1517904000"; d="scan'208";a="29207915" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 19 Mar 2018 02:17:39 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 19 Mar 2018 02:17:39 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 19 Mar 2018 02:17:38 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.226]) with mapi id 14.03.0319.002; Mon, 19 Mar 2018 17:17:36 +0800 From: "Zeng, Star" To: Ard Biesheuvel , Leif Lindholm , "Yao, Jiewen" , "Ni, Ruiyu" , "Dong, Eric" CC: "edk2-devel@lists.01.org" , "Zeng, Star" Thread-Topic: [edk2] [RFC PATCH edk2-platforms 4/6] Silicon/SynQuacer: make lowest supported f/w version PCD configurable Thread-Index: AQHTvUHSaREpr7+mkkafp8e4hYxPwKPWs3qAgAABtQCAAJYTEA== Date: Mon, 19 Mar 2018 09:17:35 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA6F046@shsmsx102.ccr.corp.intel.com> References: <20180316161322.6756-1-ard.biesheuvel@linaro.org> <20180316161322.6756-5-ard.biesheuvel@linaro.org> <20180319081240.6ueqdnizbcyutut5@bivouac.eciton.net> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [RFC PATCH edk2-platforms 4/6] Silicon/SynQuacer: make lowest supported f/w version PCD configurable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2018 09:11:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It is to be used to fill the structure with EDKII_SYSTEM_FIRMWARE_IMAGE_DES= CRIPTOR type, right? EDKII_SYSTEM_FIRMWARE_IMAGE_DESCRIPTOR is defined in SignedCapsulePkg. Is it better to define this PCD in SignedCapsulePkg if needed? Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard = Biesheuvel Sent: Monday, March 19, 2018 4:19 PM To: Leif Lindholm ; Zeng, Star ; Ni, Ruiyu ; Dong, Eric Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [RFC PATCH edk2-platforms 4/6] Silicon/SynQuacer: make = lowest supported f/w version PCD configurable On 19 March 2018 at 16:12, Leif Lindholm wrote: > On Fri, Mar 16, 2018 at 04:13:20PM +0000, Ard Biesheuvel wrote: >> Allow the lowest supported firmware version to be configured by PCD=20 >> so that each platform can set it individually. > > Is there a case for adding this PCD to MdeModulePkg? > Given that generic Capsule support is implemented there, I agree this shoul= d probably be added to MdeModulePkg instead. >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmware= Descriptor.inf | 2 ++ >> Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmware= DescriptorTable.aslc | 2 +- >> Silicon/Socionext/SynQuacer/SynQuacer.dec = | 3 +++ >> 3 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git=20 >> a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirm >> wareDescriptor.inf=20 >> b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirm >> wareDescriptor.inf index 95a5e482a713..db0c9c43b2e5 100644 >> ---=20 >> a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirm >> wareDescriptor.inf >> +++ b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/System >> +++ FirmwareDescriptor.inf >> @@ -29,6 +29,7 @@ [Packages] >> MdeModulePkg/MdeModulePkg.dec >> MdePkg/MdePkg.dec >> SignedCapsulePkg/SignedCapsulePkg.dec >> + Silicon/Socionext/SynQuacer/SynQuacer.dec >> >> [LibraryClasses] >> DebugLib >> @@ -39,6 +40,7 @@ [LibraryClasses] >> [FixedPcd] >> gArmTokenSpaceGuid.PcdFdSize >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareRevision >> + gSynQuacerTokenSpaceGuid.PcdLowestSupportedFirmwareVersion >> >> [Pcd] >> =20 >> gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescrip >> tor diff --git=20 >> a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirm >> wareDescriptorTable.aslc=20 >> b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirm >> wareDescriptorTable.aslc index fb69de078313..12a56315a5ab 100644 >> ---=20 >> a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirm >> wareDescriptorTable.aslc >> +++ b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/System >> +++ FirmwareDescriptorTable.aslc >> @@ -25,7 +25,7 @@ >> #define BUILD_STRING(x) L"build #" __BUILD_STRING(x= ) >> #define CURRENT_FIRMWARE_VERSION FixedPcdGet32 (PcdFirmwareR= evision) >> #define CURRENT_FIRMWARE_VERSION_STRING BUILD_STRING (FixedPcdGet32= (PcdFirmwareRevision)) >> -#define LOWEST_SUPPORTED_FIRMWARE_VERSION 0x00000001 >> +#define LOWEST_SUPPORTED_FIRMWARE_VERSION FixedPcdGet32 (PcdLowestSup= portedFirmwareVersion) >> >> #define IMAGE_ID SIGNATURE_64('S', 'N', 'D',= 'E', 'V', 'B', 'O', 'X') >> #define IMAGE_ID_STRING L"Socionext Developer Box" >> diff --git a/Silicon/Socionext/SynQuacer/SynQuacer.dec=20 >> b/Silicon/Socionext/SynQuacer/SynQuacer.dec >> index eb4fc4ace2f7..ccaf80def06b 100644 >> --- a/Silicon/Socionext/SynQuacer/SynQuacer.dec >> +++ b/Silicon/Socionext/SynQuacer/SynQuacer.dec >> @@ -44,6 +44,9 @@ [PcdsFixedAtBuild] >> >> =20 >> gSynQuacerTokenSpaceGuid.PcdI2cReferenceClock|62500000|UINT32|0x00000 >> 005 >> >> + # for capsule update >> + =20 >> + gSynQuacerTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|1|UINT32 >> + |0x00000009 >> + >> [PcdsPatchableInModule, PcdsDynamic] >> # Enable both RC #0 and RC #1 by default >> gSynQuacerTokenSpaceGuid.PcdPcieEnableMask|0x3|UINT8|0x00000007 >> -- >> 2.15.1 >> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel