Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec

["Zeng, Star" <star.zeng@intel.com>]

I agree.


Thanks,
Star
-----Original Message-----
From: Guo Heyi [mailto:heyi.guo@linaro.org] 
Sent: Thursday, March 22, 2018 7:43 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec

+cc Maintainers of MdeModulePkg.

On Thu, Mar 22, 2018 at 07:39:42PM +0800, Guo Heyi wrote:
> Hi folks,
> 
> The SetAttributes() interface of generic SerialDxe driver in 
> MdeModulePkg/Universal does not fully follow UEFI spec. The spec 
> requires to use default time out value when the input "Timeout" is 0, 
> but the current implementation will set timeout to 0 directly.  It 
> tries to pass "Timeout" to SerialPortSetAttributes(), but none of 
> SerialPortLib instances in edk2 tree will deal with this parameter. 
> What's more, Timeout is actually a software parameter and is only used 
> in SerialDxe itself, not in SerialPortLib instances, so I think it 
> makes more sense to set Timeout in SerialDxe directly instead of in SerialPortLib.
> 
> Please advise.
> 
> Thanks and regards,
> 
> Heyi