From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A6FA1225E4038 for ; Thu, 22 Mar 2018 17:43:46 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2018 17:50:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,347,1517904000"; d="scan'208";a="26293735" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 22 Mar 2018 17:50:18 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Mar 2018 17:50:17 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 22 Mar 2018 17:50:17 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002; Fri, 23 Mar 2018 08:50:15 +0800 From: "Zeng, Star" To: Guo Heyi , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Ni, Ruiyu" , "Zeng, Star" Thread-Topic: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec Thread-Index: AQHTwdL/FGFkUkptIkmLhLb8dGEAqqPc/hzg Date: Fri, 23 Mar 2018 00:50:14 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA72963@shsmsx102.ccr.corp.intel.com> References: <20180322113942.GC53577@SZX1000114654> <20180322114307.GD53577@SZX1000114654> In-Reply-To: <20180322114307.GD53577@SZX1000114654> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 00:43:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I agree. Thanks, Star -----Original Message----- From: Guo Heyi [mailto:heyi.guo@linaro.org]=20 Sent: Thursday, March 22, 2018 7:43 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Ni,= Ruiyu Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec +cc Maintainers of MdeModulePkg. On Thu, Mar 22, 2018 at 07:39:42PM +0800, Guo Heyi wrote: > Hi folks, >=20 > The SetAttributes() interface of generic SerialDxe driver in=20 > MdeModulePkg/Universal does not fully follow UEFI spec. The spec=20 > requires to use default time out value when the input "Timeout" is 0,=20 > but the current implementation will set timeout to 0 directly. It=20 > tries to pass "Timeout" to SerialPortSetAttributes(), but none of=20 > SerialPortLib instances in edk2 tree will deal with this parameter.=20 > What's more, Timeout is actually a software parameter and is only used=20 > in SerialDxe itself, not in SerialPortLib instances, so I think it=20 > makes more sense to set Timeout in SerialDxe directly instead of in Seria= lPortLib. >=20 > Please advise. >=20 > Thanks and regards, >=20 > Heyi