public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: Laszlo Ersek <lersek@redhat.com>, Guo Heyi <heyi.guo@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Dong, Eric" <eric.dong@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec
Date: Mon, 26 Mar 2018 01:40:14 +0000	[thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BA7325B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <a48d8dc2-bb4d-78e3-34fb-0fa387b4134e@redhat.com>

Yes, there may be slowing down perceived with 1s time out. https://github.com/tianocore/edk2/commit/a7fd8452964c1a6ffeee1fe07537cb900c0ccb07

But, my understanding to Heyi's question is that caller should be aware default time out value (1000000) will be used if the 0 time out value is input. That should follow UEFI spec and the implementation in MdeModulePkg/Bus/Pci/PciSioSerialDxe and IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe.


Thanks,
Star
-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com] 
Sent: Friday, March 23, 2018 10:32 PM
To: Zeng, Star <star.zeng@intel.com>; Guo Heyi <heyi.guo@linaro.org>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: Re: [edk2] MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec

On 03/23/18 01:50, Zeng, Star wrote:
> I agree.

Wasn't there a problem with the default timeout being 1 second, and that
1 second slowing down terminal I/O on some platform? I don't remember more precisely.

Thanks
Laszlo

> -----Original Message-----
> From: Guo Heyi [mailto:heyi.guo@linaro.org]
> Sent: Thursday, March 22, 2018 7:43 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric 
> <eric.dong@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI 
> spec
> 
> +cc Maintainers of MdeModulePkg.
> 
> On Thu, Mar 22, 2018 at 07:39:42PM +0800, Guo Heyi wrote:
>> Hi folks,
>>
>> The SetAttributes() interface of generic SerialDxe driver in 
>> MdeModulePkg/Universal does not fully follow UEFI spec. The spec 
>> requires to use default time out value when the input "Timeout" is 0, 
>> but the current implementation will set timeout to 0 directly.  It 
>> tries to pass "Timeout" to SerialPortSetAttributes(), but none of 
>> SerialPortLib instances in edk2 tree will deal with this parameter.
>> What's more, Timeout is actually a software parameter and is only 
>> used in SerialDxe itself, not in SerialPortLib instances, so I think 
>> it makes more sense to set Timeout in SerialDxe directly instead of in SerialPortLib.
>>
>> Please advise.
>>
>> Thanks and regards,
>>
>> Heyi
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 


      reply	other threads:[~2018-03-26  1:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 11:39 MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec Guo Heyi
2018-03-22 11:43 ` Guo Heyi
2018-03-23  0:50   ` Zeng, Star
2018-03-23 14:32     ` Laszlo Ersek
2018-03-26  1:40       ` Zeng, Star [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103BA7325B@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox