From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B5226203B8CE9 for ; Wed, 16 May 2018 18:31:27 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2018 18:31:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,390,1520924400"; d="scan'208";a="55927875" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 16 May 2018 18:31:26 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 16 May 2018 18:31:26 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.79]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0319.002; Thu, 17 May 2018 09:31:24 +0800 From: "Zeng, Star" To: "Marvin.Haeuser@outlook.com" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Gao, Liming" , "Yao, Jiewen" , "Zeng, Star" Thread-Topic: [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. Thread-Index: AQHT7IPC73BiwYJ5j0qlJch2fSujo6QzIOmQ Date: Thu, 17 May 2018 01:31:24 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BAECDF5@shsmsx102.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 01:31:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Was HighPrecisionEventTimerTable.h just created for ACPI related, but not f= or HPET register related? We also see AlertStandardFormatTable.h, DmaRemappingReportingTable.h, etc. = They are all ACPI related. What is the criteria about including ACPI related, and including register/c= ommand/message related? Should they be included in same header file, or separated header files? We also see HEPT register related defined in PcAtChipsetPkg\Include\Registe= r\Hpet.h. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Marv= in H?user Sent: Wednesday, May 16, 2018 3:35 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. This patch adds the HPET Event Timer Block ID definition that can be found = in the IA-PC HPET Specification, section 3.2.4. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h | 18 ++++++= +++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h= b/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h index 0d83cd5335de..926445233944 100644 --- a/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h +++ b/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h @@ -2,7 +2,7 @@ ACPI high precision event timer table definition, at www.intel.com Specification name is IA-PC HPET (High Precision Event Timers) Specifica= tion. =20 - Copyright (c) 2007 - 2008, Intel Corporation. All rights reserved.
+ Copyright (c) 2007 - 2018, Intel Corporation. All rights=20 + reserved.
This program and the accompanying materials =20 are licensed and made available under the terms and conditions of the BS= D License =20 which accompanies this distribution. The full text of the license may b= e found at =20 @@ -22,6 +22,22 @@ // #pragma pack(1) =20 +/// +/// HPET Event Timer Block ID described in IA-PC HPET Specification, 3.2.4= . +/// +typedef union { + struct { + UINT32 Revision : 8; + UINT32 NumberOfTimers : 5; + UINT32 CounterSize : 1; + UINT32 Reserved : 1; + UINT32 LegacyRoute : 1; + UINT32 VendorId : 16; + } Bits; + UINT32 Uint32; +} EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_BLOCK_ID; + + /// /// High Precision Event Timer Table header definition. /// -- 2.17.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel