* [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table
@ 2018-01-30 13:53 Dandan Bi
2018-01-30 13:53 ` [PATCH v2 1/8] MdeModulePkg:Add definitions for new Performance infrastructure Dandan Bi
` (8 more replies)
0 siblings, 9 replies; 21+ messages in thread
From: Dandan Bi @ 2018-01-30 13:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Star Zeng
V2:
a.Update DxecorePerformanceLib/SmmCorePerformanceLib to report the
boot performance table address instead of records contents.
b.Update FirmwarePerformanceDxe/FirmwarePerformanceSmm to receive the address
of performance records.
This patch series also can be accessed at:
https://github.com/dandanbi/edk2/tree/NewPerformanceInfrastructureV2
These patches are to update EDKII performance infrastructure to log and dump
the performance entry as FPDT record in ACPI FPDT table.This new infrastructure
can support to dump performance data in UEFI Shell and OS both.
(1)PeiPerformanceLib/DxeCorePerformanceLib/SmmCorePerformanceLib log the
performance entry as FPDT record.
(2)FirmwarePerformancePei/FirmwarePerformanceDxe/FirmwarePerformanceSmm
install the FPDT records to the ACPI table.
(3)Update DP to dump the performance info from the FPDT records in
FPDT table.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Dandan Bi (7):
MdeModulePkg/PeiPerformance:Updated to track FPDT record in PEI phase
MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
MdeModulePkg/SmmCorePerformanceLib:Track FPDT record in SMM phase
MdeModulePkg/FirmwarePerformancePei:Add FPDT records for S3 phase
MdeModulePkg/FirmwarePerfDxe:Enhance for new pref infrastructure
MdeModulePkg/FirmwarePerfSmm:Enhance for new pref infrastructure
ShellPkg/Dp: Updated to dump perf log based on FPDT table
Gao, Liming (1):
MdeModulePkg:Add definitions for new Performance infrastructure
.../Include/Guid/ExtendedFirmwarePerformance.h | 291 ++++
MdeModulePkg/Include/Guid/FirmwarePerformance.h | 13 +-
.../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 1389 +++++++++++++++-----
.../DxeCorePerformanceLib.inf | 20 +-
.../DxeCorePerformanceLibInternal.h | 17 +-
.../Library/PeiPerformanceLib/PeiPerformanceLib.c | 565 +++++---
.../PeiPerformanceLib/PeiPerformanceLib.inf | 14 +-
.../SmmCorePerformanceLib/SmmCorePerformanceLib.c | 1145 +++++++++-------
.../SmmCorePerformanceLib.inf | 10 +-
.../SmmCorePerformanceLibInternal.h | 11 +-
MdeModulePkg/MdeModulePkg.dec | 11 +-
MdeModulePkg/MdeModulePkg.uni | 8 +-
.../FirmwarePerformanceDxe.c | 271 +---
.../FirmwarePerformanceDxe.inf | 4 +-
.../FirmwarePerformancePei.c | 59 +-
.../FirmwarePerformancePei.inf | 5 +-
.../FirmwarePerformanceSmm.c | 29 +-
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 609 ++++++++-
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h | 7 +-
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni | 11 +-
ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 5 +-
.../DpDynamicCommand/DpDynamicCommand.inf | 5 +-
.../DynamicCommand/DpDynamicCommand/DpInternal.h | 9 +-
ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c | 108 +-
.../DynamicCommand/DpDynamicCommand/DpUtilities.c | 37 +-
.../DynamicCommand/DpDynamicCommand/Literals.c | 24 +-
.../DynamicCommand/DpDynamicCommand/Literals.h | 8 +-
.../DpDynamicCommand/PerformanceTokens.h | 28 -
28 files changed, 3342 insertions(+), 1371 deletions(-)
create mode 100644 MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h
delete mode 100644 ShellPkg/DynamicCommand/DpDynamicCommand/PerformanceTokens.h
--
1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2 1/8] MdeModulePkg:Add definitions for new Performance infrastructure
2018-01-30 13:53 [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table Dandan Bi
@ 2018-01-30 13:53 ` Dandan Bi
2018-01-31 2:07 ` Zeng, Star
2018-01-30 13:53 ` [PATCH v2 2/8] MdeModulePkg/PeiPerformance:Updated to track FPDT record in PEI phase Dandan Bi
` (7 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: Dandan Bi @ 2018-01-30 13:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Gao, Liming, Star Zeng
From: "Gao, Liming" <liming.gao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Include/Guid/ExtendedFirmwarePerformance.h | 291 +++++++++++++++++++++
MdeModulePkg/Include/Guid/FirmwarePerformance.h | 13 +-
MdeModulePkg/MdeModulePkg.dec | 11 +-
MdeModulePkg/MdeModulePkg.uni | 8 +-
4 files changed, 320 insertions(+), 3 deletions(-)
create mode 100644 MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h
diff --git a/MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h b/MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h
new file mode 100644
index 0000000..0395495
--- /dev/null
+++ b/MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h
@@ -0,0 +1,291 @@
+/** @file
+ This file defines edk2 extended firmware performance records.
+ These records will be added into ACPI FPDT Firmware Basic Boot Performance Table.
+
+Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+This program and the accompanying materials are licensed and made available under
+the terms and conditions of the BSD License that accompanies this distribution.
+The full text of the license may be found at
+http://opensource.org/licenses/bsd-license.php.
+
+THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#ifndef __EXTENDED_FIRMWARE_PERFORMANCE_H__
+#define __EXTENDED_FIRMWARE_PERFORMANCE_H__
+
+#include <IndustryStandard/Acpi.h>
+
+//
+// Known performance tokens
+//
+#define SEC_TOK "SEC" ///< SEC Phase
+#define DXE_TOK "DXE" ///< DXE Phase
+#define PEI_TOK "PEI" ///< PEI Phase
+#define BDS_TOK "BDS" ///< BDS Phase
+#define DRIVERBINDING_START_TOK "DB:Start:" ///< Driver Binding Start() function call
+#define DRIVERBINDING_SUPPORT_TOK "DB:Support:" ///< Driver Binding Support() function call
+#define DRIVERBINDING_STOP_TOK "DB:Stop:" ///< Driver Binding Stop() function call
+#define LOAD_IMAGE_TOK "LoadImage:" ///< Load a dispatched module
+#define START_IMAGE_TOK "StartImage:" ///< Dispatched Modules Entry Point execution
+#define PEIM_TOK "PEIM" ///< PEIM Modules Entry Point execution
+
+//
+// Public Progress Identifiers for Event Records to map the above known token
+//
+#define MODULE_START_ID 0x01
+#define MODULE_END_ID 0x02
+#define MODULE_LOADIMAGE_START_ID 0x03
+#define MODULE_LOADIMAGE_END_ID 0x04
+#define MODULE_DB_START_ID 0x05
+#define MODULE_DB_END_ID 0x06
+#define MODULE_DB_SUPPORT_START_ID 0x07
+#define MODULE_DB_SUPPORT_END_ID 0x08
+#define MODULE_DB_STOP_START_ID 0x09
+#define MODULE_DB_STOP_END_ID 0x0A
+
+#define PERF_EVENTSIGNAL_START_ID 0x10
+#define PERF_EVENTSIGNAL_END_ID 0x11
+#define PERF_CALLBACK_START_ID 0x20
+#define PERF_CALLBACK_END_ID 0x21
+#define PERF_FUNCTION_START_ID 0x30
+#define PERF_FUNCTION_END_ID 0x31
+#define PERF_INMODULE_START_ID 0x40
+#define PERF_INMODULE_END_ID 0x41
+#define PERF_CROSSMODULE_START_ID 0x50
+#define PERF_CROSSMODULE_END_ID 0x51
+
+//
+// Misc defines
+//
+#define RECORD_REVISION_1 (0x01)
+
+//
+// Length field in EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER is a UINT8, thus:
+//
+#define MAX_PERF_RECORD_SIZE (MAX_UINT8)
+
+//
+// FPDT Record Types
+//
+#define GUID_EVENT_TYPE 0x1010
+#define DYNAMIC_STRING_EVENT_TYPE 0x1011
+#define DUAL_GUID_STRING_EVENT_TYPE 0x1012
+#define GUID_QWORD_EVENT_TYPE 0x1013
+#define GUID_QWORD_STRING_EVENT_TYPE 0x1014
+
+//
+// EDKII extended Fpdt record structures
+//
+#define EDKII_STRING_EVENT_RECORD_NAME_LENGTH 24
+
+#pragma pack(1)
+//
+// FPDT Boot Performance Guid Event Record Structure
+//
+typedef struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER Header;
+ ///
+ /// ProgressID < 0x10 are reserved for core performance entries.
+ /// Start measurement point shall have lowered one nibble set to zero and
+ /// corresponding end points shall have lowered one nibble set to non-zero value;
+ /// keeping other nibbles same as start point.
+ ///
+ UINT16 ProgressID;
+ ///
+ /// APIC ID for the processor in the system used as a timestamp clock source.
+ /// If only one timestamp clock source is used, this field is Reserved and populated as 0.
+ ///
+ UINT32 ApicID;
+ ///
+ /// 64-bit value (nanosecond) describing elapsed time since the most recent deassertion of processor reset.
+ ///
+ UINT64 Timestamp;
+ ///
+ /// If ProgressID < 0x10, GUID of the referenced module; otherwise, GUID of the module logging the event.
+ ///
+ EFI_GUID Guid;
+} GUID_EVENT_RECORD;
+
+//
+// FPDT Boot Performance Dynamic String Event Record Structure
+//
+typedef struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER Header;
+ ///
+ /// ProgressID < 0x10 are reserved for core performance entries.
+ /// Start measurement point shall have lowered one nibble set to zero and
+ /// corresponding end points shall have lowered one nibble set to non-zero value;
+ /// keeping other nibbles same as start point.
+ ///
+ UINT16 ProgressID;
+ ///
+ /// APIC ID for the processor in the system used as a timestamp clock source.
+ /// If only one timestamp clock source is used, this field is Reserved and populated as 0.
+ ///
+ UINT32 ApicID;
+ ///
+ /// 64-bit value (nanosecond) describing elapsed time since the most recent deassertion of processor reset.
+ ///
+ UINT64 Timestamp;
+ ///
+ /// If ProgressID < 0x10, GUID of the referenced module; otherwise, GUID of the module logging the event.
+ ///
+ EFI_GUID Guid;
+ ///
+ /// ASCII string describing the module. Padding supplied at the end if necessary with null characters (0x00).
+ /// It may be module name, function name, or token name.
+ ///
+ CHAR8 String[0];
+} DYNAMIC_STRING_EVENT_RECORD;
+
+//
+// FPDT Boot Performance Dual GUID String Event Record Structure
+//
+typedef struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER Header;
+ ///
+ /// ProgressID < 0x10 are reserved for core performance entries.
+ /// Start measurement point shall have lowered one nibble set to zero and
+ /// corresponding end points shall have lowered one nibble set to non-zero value;
+ /// keeping other nibbles same as start point.
+ ///
+ UINT16 ProgressID;
+ ///
+ /// APIC ID for the processor in the system used as a timestamp clock source.
+ /// If only one timestamp clock source is used, this field is Reserved and populated as 0.
+ ///
+ UINT32 ApicID;
+ ///
+ /// 64-bit value (nanosecond) describing elapsed time since the most recent deassertion of processor reset.
+ ///
+ UINT64 Timestamp;
+ ///
+ /// GUID of the module logging the event.
+ ///
+ EFI_GUID Guid1;
+ ///
+ /// Event or Ppi or Protocol GUID for Callback.
+ ///
+ EFI_GUID Guid2;
+ ///
+ /// ASCII string describing the module. Padding supplied at the end if necessary with null characters (0x00).
+ /// It is the function name.
+ ///
+ CHAR8 String[0];
+} DUAL_GUID_STRING_EVENT_RECORD;
+
+//
+// FPDT Boot Performance GUID Qword Event Record Structure
+//
+typedef struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER Header;
+ ///
+ /// ProgressID < 0x10 are reserved for core performance entries.
+ /// Start measurement point shall have lowered one nibble set to zero and
+ /// corresponding end points shall have lowered one nibble set to non-zero value;
+ /// keeping other nibbles same as start point.
+ ///
+ UINT16 ProgressID;
+ ///
+ /// APIC ID for the processor in the system used as a timestamp clock source.
+ /// If only one timestamp clock source is used, this field is Reserved and populated as 0.
+ ///
+ UINT32 ApicID;
+ ///
+ /// 64-bit value (nanosecond) describing elapsed time since the most recent deassertion of processor reset.
+ ///
+ UINT64 Timestamp;
+ ///
+ /// GUID of the module logging the event
+ ///
+ EFI_GUID Guid;
+ ///
+ /// Qword of misc data, meaning depends on the ProgressId
+ ///
+ UINT64 Qword;
+} GUID_QWORD_EVENT_RECORD;
+
+//
+// FPDT Boot Performance GUID Qword String Event Record Structure
+//
+typedef struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER Header;
+ ///
+ /// ProgressID < 0x10 are reserved for core performance entries.
+ /// Start measurement point shall have lowered one nibble set to zero and
+ /// corresponding end points shall have lowered one nibble set to non-zero value;
+ /// keeping other nibbles same as start point.
+ ///
+ UINT16 ProgressID;
+ ///
+ /// APIC ID for the processor in the system used as a timestamp clock source.
+ /// If only one timestamp clock source is used, this field is Reserved and populated as 0.
+ ///
+ UINT32 ApicID;
+ ///
+ /// 64-bit value (nanosecond) describing elapsed time since the most recent deassertion of processor reset.
+ ///
+ UINT64 Timestamp;
+ ///
+ /// GUID of the module logging the event
+ ///
+ EFI_GUID Guid;
+ ///
+ /// Qword of misc data, meaning depends on the ProgressId
+ ///
+ UINT64 Qword;
+ ///
+ /// ASCII string describing the module. Padding supplied at the end if necessary with null characters (0x00).
+ ///
+ CHAR8 String[0];
+} GUID_QWORD_STRING_EVENT_RECORD;
+
+#pragma pack()
+
+typedef struct {
+ UINT16 ProgressID;
+ UINT16 Type;
+ UINT8 RecordSize;
+} BASIC_RECORD_INFO;
+
+//
+// Union of all FPDT records
+//
+typedef union {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER RecordHeader;
+ GUID_EVENT_RECORD GuidEvent;
+ DYNAMIC_STRING_EVENT_RECORD DynamicStringEvent;
+ DUAL_GUID_STRING_EVENT_RECORD DualGuidStringEvent;
+ GUID_QWORD_EVENT_RECORD GuidQwordEvent;
+ GUID_QWORD_STRING_EVENT_RECORD GuidQwordStringEvent;
+} FPDT_RECORD;
+
+//
+// Union of all pointers to FPDT records
+//
+typedef union {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *RecordHeader;
+ GUID_EVENT_RECORD *GuidEvent;
+ DYNAMIC_STRING_EVENT_RECORD *DynamicStringEvent;
+ DUAL_GUID_STRING_EVENT_RECORD *DualGuidStringEvent;
+ GUID_QWORD_EVENT_RECORD *GuidQwordEvent;
+ GUID_QWORD_STRING_EVENT_RECORD *GuidQwordStringEvent;
+} FPDT_RECORD_PTR;
+
+///
+/// Hob:
+/// GUID - gEdkiiExtendedFirmwarePerformanceGuid
+/// Data - PEI_EXT_FIRMWARE_PERF_HEADER + one or more FPDT records
+///
+typedef struct {
+ UINT32 SizeOfAllEntries;
+ UINT32 LoadImageCount;
+ UINT32 HobIsFull;
+} PEI_EXT_FIRMWARE_PERF_HEADER;
+
+extern EFI_GUID gEdkiiExtendedFirmwarePerformanceGuid;
+
+#endif
diff --git a/MdeModulePkg/Include/Guid/FirmwarePerformance.h b/MdeModulePkg/Include/Guid/FirmwarePerformance.h
index 4697a2c..1495a46 100644
--- a/MdeModulePkg/Include/Guid/FirmwarePerformance.h
+++ b/MdeModulePkg/Include/Guid/FirmwarePerformance.h
@@ -1,9 +1,9 @@
/** @file
ACPI Firmware Performance Data Table (FPDT) implementation specific definitions.
- Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -93,10 +93,21 @@ typedef struct {
// one or more boot performance records.
//
} BOOT_PERFORMANCE_TABLE;
///
+/// Boot performance table for the performance record in SMM phase.
+///
+///
+typedef struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_TABLE_HEADER Header; ///< Common ACPI table header.
+ //
+ // one or more boot performance records.
+ //
+} SMM_BOOT_PERFORMANCE_TABLE;
+
+///
/// Performance data pointed by Performance Pointer Record.
///
typedef struct {
BOOT_PERFORMANCE_TABLE BootPerformance; ///< Basic Boot Performance.
S3_PERFORMANCE_TABLE S3Performance; ///< S3 performance.
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 0298bed..6819307 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -390,10 +390,13 @@
gEdkiiNonDiscoverableXhciDeviceGuid = { 0xB1BE0BC5, 0x6C28, 0x442D, {0xAA, 0x37, 0x15, 0x1B, 0x42, 0x57, 0xBD, 0x78 } }
## Include/Guid/PlatformHasAcpi.h
gEdkiiPlatformHasAcpiGuid = { 0xf0966b41, 0xc23f, 0x41b9, { 0x96, 0x04, 0x0f, 0xf7, 0xe1, 0x11, 0x96, 0x5a } }
+ ## Include/Guid/ExtendedFirmwarePerformance.h
+ gEdkiiExtendedFirmwarePerformanceGuid = { 0x3b387bfd, 0x7abc, 0x4cf2, { 0xa0, 0xca, 0xb6, 0xa1, 0x6c, 0x1b, 0x1b, 0x25 } }
+
## Include/Guid/EndofS3Resume.h
gEdkiiEndOfS3ResumeGuid = { 0x96f5296d, 0x05f7, 0x4f3c, {0x84, 0x67, 0xe4, 0x56, 0x89, 0x0e, 0x0c, 0xb5 } }
[Ppis]
## Include/Ppi/AtaController.h
@@ -1404,10 +1407,16 @@
## CapsuleMax value in capsule report variable.
# @Prompt CapsuleMax value in capsule report variable.
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax|0xFFFF|UINT16|0x00000107
+ ## Control which FPDT record format will be used to store the performance entry.
+ # On TRUE, the string FPDT record will be used to store every performance entry.
+ # On FALSE, the different FPDT record will be used to store the different performance entries.
+ # @Prompt String FPDT Record Enable Only
+ gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly|FALSE|BOOLEAN|0x00000109
+
[PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
## This PCD defines the Console output row. The default value is 25 according to UEFI spec.
# This PCD could be set to 0 then console output would be at max column and max row.
# @Prompt Console output row.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|25|UINT32|0x40000006
@@ -1703,11 +1712,11 @@
gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x3|UINT32|0x00010069
## This PCD specifies the additional pad size in FPDT Basic Boot Performance Table for
# the extension FPDT boot records received after ReadyToBoot and before ExitBootService.
# @Prompt Pad size for extension FPDT boot records.
- gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize|0x0|UINT32|0x0001005F
+ gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize|0x20000|UINT32|0x0001005F
## Indicates if ConIn device are connected on demand.<BR><BR>
# TRUE - ConIn device are not connected during BDS and ReadKeyStroke/ReadKeyStrokeEx produced
# by Consplitter should be called before any real key read operation.<BR>
# FALSE - ConIn device may be connected normally during BDS.<BR>
diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index 0e06842..dacd671 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -2,11 +2,11 @@
// This package provides the modules that conform to UEFI/PI Industry standards.
//
// It also provides the definitions(including PPIs/PROTOCOLs/GUIDs and library classes)
// and libraries instances, which are used for those modules.
//
-// Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR>
+// Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
//
// This program and the accompanying materials are licensed and made available under
// the terms and conditions of the BSD License that accompanies this distribution.
// The full text of the license may be found at
// http://opensource.org/licenses/bsd-license.php.
@@ -1230,5 +1230,11 @@
" When its value is set in PEI, it will trig the default setting to be applied as the default EFI variable.\n"
#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdNvStoreDefaultValueBuffer_PROMPT #language en-US "NV Storage Default Value Buffer"
#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdNvStoreDefaultValueBuffer_HELP #language en-US "This dynamic PCD holds the DynamicHii PCD value. Its value is the auto generated.\n"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEdkiiFpdtStringRecordEnableOnly_PROMPT #language en-US "String FPDT Record Enable Only"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEdkiiFpdtStringRecordEnableOnly_HELP #language en-US "Control which FPDT record format will be used to store the performance entry.\n"
+ "On TRUE, the string FPDT record will be used to store every performance entry.\n"
+ "On FALSE, the different FPDT record will be used to store the different performance entries."
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 2/8] MdeModulePkg/PeiPerformance:Updated to track FPDT record in PEI phase
2018-01-30 13:53 [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table Dandan Bi
2018-01-30 13:53 ` [PATCH v2 1/8] MdeModulePkg:Add definitions for new Performance infrastructure Dandan Bi
@ 2018-01-30 13:53 ` Dandan Bi
2018-01-30 13:53 ` [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase Dandan Bi
` (6 subsequent siblings)
8 siblings, 0 replies; 21+ messages in thread
From: Dandan Bi @ 2018-01-30 13:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Star Zeng
Updated to convert Pref entry to FPDT record in PEI phase and then
report the records to DxeCorePerfLib through GUID hob.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Library/PeiPerformanceLib/PeiPerformanceLib.c | 565 ++++++++++++++-------
.../PeiPerformanceLib/PeiPerformanceLib.inf | 14 +-
2 files changed, 380 insertions(+), 199 deletions(-)
diff --git a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c
index 62527b2..75b4c31 100644
--- a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c
+++ b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c
@@ -5,11 +5,11 @@
performance logging GUIDed HOB on the first performance logging and then logs the
performance data to the GUIDed HOB. Due to the limitation of temporary RAM, the maximum
number of performance logging entry is specified by PcdMaxPeiPerformanceLogEntries or
PcdMaxPeiPerformanceLogEntries16.
-Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -20,215 +20,446 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
**/
#include <PiPei.h>
-#include <Guid/Performance.h>
+#include <Guid/ExtendedFirmwarePerformance.h>
#include <Library/PerformanceLib.h>
#include <Library/DebugLib.h>
#include <Library/HobLib.h>
#include <Library/BaseLib.h>
#include <Library/TimerLib.h>
#include <Library/PcdLib.h>
#include <Library/BaseMemoryLib.h>
+#define STRING_SIZE (EDKII_STRING_EVENT_RECORD_NAME_LENGTH * sizeof (CHAR8))
+#define MAX_RECORD_SIZE (sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE)
/**
- Gets the GUID HOB for PEI performance.
+Check whether the Token is a known one which is uesed by core.
- This internal function searches for the GUID HOB for PEI performance.
- If that GUID HOB is not found, it will build a new one.
- It outputs the data area of that GUID HOB to record performance log.
+@param Token Pointer to a Null-terminated ASCII string
- @param PeiPerformanceLog Pointer to Pointer to PEI performance log header.
- @param PeiPerformanceIdArray Pointer to Pointer to PEI performance identifier array.
+@retval TRUE Is a known one used by core.
+@retval FALSE Not a known one.
**/
-VOID
-InternalGetPerformanceHobLog (
- OUT PEI_PERFORMANCE_LOG_HEADER **PeiPerformanceLog,
- OUT UINT32 **PeiPerformanceIdArray
+BOOLEAN
+IsKnownTokens (
+ IN CONST CHAR8 *Token
)
{
- EFI_HOB_GUID_TYPE *GuidHob;
- UINTN PeiPerformanceSize;
- UINT16 PeiPerformanceLogEntries;
+ if (AsciiStrCmp (Token, SEC_TOK) == 0 ||
+ AsciiStrCmp (Token, PEI_TOK) == 0 ||
+ AsciiStrCmp (Token, DXE_TOK) == 0 ||
+ AsciiStrCmp (Token, BDS_TOK) == 0 ||
+ AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0 ||
+ AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0 ||
+ AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0 ||
+ AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0 ||
+ AsciiStrCmp (Token, START_IMAGE_TOK) == 0 ||
+ AsciiStrCmp (Token, PEIM_TOK) == 0) {
+ return TRUE;
+ } else {
+ return FALSE;
+ }
+}
- ASSERT (PeiPerformanceLog != NULL);
- ASSERT (PeiPerformanceIdArray != NULL);
+/**
+Check whether the ID is a known one which map to the known Token.
- PeiPerformanceLogEntries = (UINT16) (PcdGet16 (PcdMaxPeiPerformanceLogEntries16) != 0 ?
- PcdGet16 (PcdMaxPeiPerformanceLogEntries16) :
- PcdGet8 (PcdMaxPeiPerformanceLogEntries));
- GuidHob = GetFirstGuidHob (&gPerformanceProtocolGuid);
+@param Identifier 32-bit identifier.
- if (GuidHob != NULL) {
- //
- // PEI Performance HOB was found, then return the existing one.
- //
- *PeiPerformanceLog = GET_GUID_HOB_DATA (GuidHob);
+@retval TRUE Is a known one used by core.
+@retval FALSE Not a known one.
- GuidHob = GetFirstGuidHob (&gPerformanceExProtocolGuid);
- ASSERT (GuidHob != NULL);
- *PeiPerformanceIdArray = GET_GUID_HOB_DATA (GuidHob);
+**/
+BOOLEAN
+IsKnownID (
+ IN UINT32 Identifier
+ )
+{
+ if (Identifier == MODULE_START_ID ||
+ Identifier == MODULE_END_ID ||
+ Identifier == MODULE_LOADIMAGE_START_ID ||
+ Identifier == MODULE_LOADIMAGE_END_ID ||
+ Identifier == MODULE_DB_START_ID ||
+ Identifier == MODULE_DB_END_ID ||
+ Identifier == MODULE_DB_SUPPORT_START_ID ||
+ Identifier == MODULE_DB_SUPPORT_END_ID ||
+ Identifier == MODULE_DB_STOP_START_ID ||
+ Identifier == MODULE_DB_STOP_END_ID) {
+ return TRUE;
} else {
- //
- // PEI Performance HOB was not found, then build one.
- //
- PeiPerformanceSize = sizeof (PEI_PERFORMANCE_LOG_HEADER) +
- sizeof (PEI_PERFORMANCE_LOG_ENTRY) * PeiPerformanceLogEntries;
- *PeiPerformanceLog = BuildGuidHob (&gPerformanceProtocolGuid, PeiPerformanceSize);
- *PeiPerformanceLog = ZeroMem (*PeiPerformanceLog, PeiPerformanceSize);
-
- PeiPerformanceSize = sizeof (UINT32) * PeiPerformanceLogEntries;
- *PeiPerformanceIdArray = BuildGuidHob (&gPerformanceExProtocolGuid, PeiPerformanceSize);
- *PeiPerformanceIdArray = ZeroMem (*PeiPerformanceIdArray, PeiPerformanceSize);
+ return FALSE;
}
}
/**
- Searches in the log array with keyword Handle, Token, Module and Identifier.
-
- This internal function searches for the log entry in the log array.
- If there is an entry that exactly matches the given keywords
- and its end time stamp is zero, then the index of that log entry is returned;
- otherwise, the the number of log entries in the array is returned.
+ Get the FPDT record info.
- @param PeiPerformanceLog Pointer to the data structure containing PEI
- performance data.
- @param PeiPerformanceIdArray Pointer to PEI performance identifier array.
+ @param IsStart TRUE if the performance log is start log.
@param Handle Pointer to environment specific context used
to identify the component being measured.
@param Token Pointer to a Null-terminated ASCII string
that identifies the component being measured.
@param Module Pointer to a Null-terminated ASCII string
that identifies the module being measured.
- @param Identifier 32-bit identifier.
+ @param RecordInfo On return, pointer to the info of the record.
- @retval The index of log entry in the array.
+ @retval EFI_SUCCESS Get record info successfully.
+ @retval EFI_UNSUPPORTED No matched FPDT record.
**/
-UINT32
-InternalSearchForLogEntry (
- IN PEI_PERFORMANCE_LOG_HEADER *PeiPerformanceLog,
- IN UINT32 *PeiPerformanceIdArray,
- IN CONST VOID *Handle, OPTIONAL
- IN CONST CHAR8 *Token, OPTIONAL
- IN CONST CHAR8 *Module, OPTIONAL
- IN UINT32 Identifier
+EFI_STATUS
+GetFpdtRecordInfo (
+ IN BOOLEAN IsStart,
+ IN CONST VOID *Handle,
+ IN CONST CHAR8 *Token,
+ IN CONST CHAR8 *Module,
+ OUT BASIC_RECORD_INFO *RecordInfo
)
{
- UINT32 Index;
- UINT32 Index2;
- UINT32 NumberOfEntries;
- PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
+ UINTN StringSize;
+ UINT16 RecordType;
+ RecordType = DYNAMIC_STRING_EVENT_TYPE;
- if (Token == NULL) {
- Token = "";
- }
- if (Module == NULL) {
- Module = "";
+ //
+ // Get the ProgressID based on the Token.
+ // When PcdEdkiiFpdtStringRecordEnableOnly is TRUE, all records are with type of DYNAMIC_STRING_EVENT_TYPE.
+ //
+ if (Token != NULL) {
+ if (AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) { // "LoadImage:"
+ if (IsStart) {
+ RecordInfo->ProgressID = MODULE_LOADIMAGE_START_ID;
+ } else {
+ RecordInfo->ProgressID = MODULE_LOADIMAGE_END_ID;
+ }
+ if(!PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
+ RecordType = GUID_QWORD_EVENT_TYPE;
+ }
+ } else if (AsciiStrCmp (Token, SEC_TOK) == 0 || // "SEC"
+ AsciiStrCmp (Token, PEI_TOK) == 0) { // "PEI"
+ if (IsStart) {
+ RecordInfo->ProgressID = PERF_CROSSMODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = PERF_CROSSMODULE_END_ID;
+ }
+ } else if (AsciiStrCmp (Token, PEIM_TOK) == 0) { // "PEIM"
+ if (IsStart) {
+ RecordInfo->ProgressID = MODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = MODULE_END_ID;
+ }
+ if(!PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
+ RecordType = GUID_EVENT_TYPE;
+ }
+ } else { //Pref used in Modules.
+ if (IsStart) {
+ RecordInfo->ProgressID = PERF_INMODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = PERF_INMODULE_END_ID;
+ }
+ }
+ } else if (Module != NULL || Handle != NULL) { //Pref used in Modules.
+ if (IsStart) {
+ RecordInfo->ProgressID = PERF_INMODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = PERF_INMODULE_END_ID;
+ }
+ } else {
+ return EFI_UNSUPPORTED;
}
- NumberOfEntries = PeiPerformanceLog->NumberOfEntries;
- LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (PeiPerformanceLog + 1);
-
- Index2 = 0;
-
- for (Index = 0; Index < NumberOfEntries; Index++) {
- Index2 = NumberOfEntries - 1 - Index;
- if (LogEntryArray[Index2].EndTimeStamp == 0 &&
- (LogEntryArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&
- AsciiStrnCmp (LogEntryArray[Index2].Token, Token, PEI_PERFORMANCE_STRING_LENGTH) == 0 &&
- AsciiStrnCmp (LogEntryArray[Index2].Module, Module, PEI_PERFORMANCE_STRING_LENGTH) == 0) {
- Index = Index2;
+
+ //
+ // Get the Guid and string.
+ //
+ if(PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
+ RecordInfo->RecordSize = sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE;
+ } else {
+ switch (RecordType) {
+ case GUID_EVENT_TYPE:
+ RecordInfo->RecordSize = sizeof (GUID_EVENT_RECORD);
break;
+
+ case GUID_QWORD_EVENT_TYPE:
+ RecordInfo->RecordSize = sizeof (GUID_QWORD_EVENT_RECORD);
+ break;
+
+ case DYNAMIC_STRING_EVENT_TYPE:
+ if (Token != NULL) {
+ StringSize = AsciiStrSize (Token);
+ } else if (Module != NULL) {
+ StringSize = AsciiStrSize (Module);
+ } else {
+ StringSize = STRING_SIZE;
+ }
+ RecordInfo->RecordSize = (UINT8)(sizeof (DYNAMIC_STRING_EVENT_RECORD) + StringSize);
+ break;
+
+ default:
+ //
+ // Other type is unsupported in PEI phase yet, return EFI_UNSUPPORTED
+ //
+ return EFI_UNSUPPORTED;
}
}
- return Index;
+ RecordInfo->Type = RecordType;
+ return EFI_SUCCESS;
}
/**
- Creates a record for the beginning of a performance measurement.
-
- Creates a record that contains the Handle, Token, Module and Identifier.
- If TimeStamp is not zero, then TimeStamp is added to the record as the start time.
- If TimeStamp is zero, then this function reads the current time stamp
- and adds that time stamp value to the record as the start time.
+ Convert PEI performance log to FPDT String boot record.
+ @param IsStart TRUE if the performance log is start log.
@param Handle Pointer to environment specific context used
to identify the component being measured.
@param Token Pointer to a Null-terminated ASCII string
that identifies the component being measured.
@param Module Pointer to a Null-terminated ASCII string
that identifies the module being measured.
- @param TimeStamp 64-bit time stamp.
+ @param Ticker 64-bit time stamp.
@param Identifier 32-bit identifier. If the value is 0, the created record
- is same as the one created by StartPerformanceMeasurement.
+ is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
- @retval RETURN_SUCCESS The start of the measurement was recorded.
- @retval RETURN_OUT_OF_RESOURCES There are not enough resources to record the measurement.
+ @retval EFI_SUCCESS Add FPDT boot record.
+ @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
+ @retval EFI_UNSUPPORTED No matched FPDT record.
**/
-RETURN_STATUS
-EFIAPI
-StartPerformanceMeasurementEx (
+EFI_STATUS
+InsertPeiFpdtMeasurement (
+ IN BOOLEAN IsStart,
IN CONST VOID *Handle, OPTIONAL
IN CONST CHAR8 *Token, OPTIONAL
IN CONST CHAR8 *Module, OPTIONAL
- IN UINT64 TimeStamp,
+ IN UINT64 Ticker,
IN UINT32 Identifier
)
{
- PEI_PERFORMANCE_LOG_HEADER *PeiPerformanceLog;
- UINT32 *PeiPerformanceIdArray;
- PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
- UINT32 Index;
- UINT16 PeiPerformanceLogEntries;
+ EFI_HOB_GUID_TYPE *GuidHob;
+ UINTN PeiPerformanceSize;
+ UINT8 *PeiFirmwarePerformance;
+ PEI_EXT_FIRMWARE_PERF_HEADER *PeiPerformanceLogHeader;
+ FPDT_RECORD_PTR FpdtRecordPtr;
+ BASIC_RECORD_INFO RecordInfo;
+ CONST VOID *ModuleGuid;
+ UINTN DestMax;
+ UINTN StrLength;
+ CONST CHAR8 *StringPtr;
+ EFI_STATUS Status;
+ UINT16 PeiPerformanceLogEntries;
+ UINT64 TimeStamp;
+
+ StringPtr = NULL;
+ FpdtRecordPtr.RecordHeader = NULL;
+ PeiPerformanceLogHeader = NULL;
+
+ //
+ // Get record info (type, size, ProgressID and Module Guid).
+ //
+ Status = GetFpdtRecordInfo (IsStart, Handle, Token, Module, &RecordInfo);
+ if (EFI_ERROR (Status)) {
+ return Status;
+ }
+
+ //
+ // If PERF_START()/PERF_END() have specified the ProgressID,it has high priority.
+ // !!! Note: If the Pref is not the known Token used in the core but have same
+ // ID with the core Token, this case will not be supported.
+ // And in currtnt usage mode, for the unkown ID, there is a general rule:
+ // If it is start pref: the lower 4 bits of the ID should be 0.
+ // If it is end pref: the lower 4 bits of the ID should not be 0.
+ // If input ID doesn't follow the rule, we will adjust it.
+ //
+ if ((Identifier != 0) && (IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
+ return EFI_UNSUPPORTED;
+ } else if ((Identifier != 0) && (!IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
+ if (IsStart && ((Identifier & 0x000F) != 0)) {
+ Identifier &= 0xFFF0;
+ } else if ((!IsStart) && ((Identifier & 0x000F) == 0)) {
+ Identifier += 1;
+ }
+ RecordInfo.ProgressID = (UINT16)Identifier;
+ }
+ //
+ // Get the number of PeiPerformanceLogEntries form PCD.
+ //
PeiPerformanceLogEntries = (UINT16) (PcdGet16 (PcdMaxPeiPerformanceLogEntries16) != 0 ?
PcdGet16 (PcdMaxPeiPerformanceLogEntries16) :
PcdGet8 (PcdMaxPeiPerformanceLogEntries));
- InternalGetPerformanceHobLog (&PeiPerformanceLog, &PeiPerformanceIdArray);
+ //
+ // Create GUID HOB Data.
+ //
+ GuidHob = GetFirstGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid);
+ PeiFirmwarePerformance = NULL;
+ while (GuidHob != NULL) {
+ //
+ // PEI Performance HOB was found, then return the existing one.
+ //
+ PeiFirmwarePerformance = (UINT8*)GET_GUID_HOB_DATA (GuidHob);
+ PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *)PeiFirmwarePerformance;
+ if (!PeiPerformanceLogHeader->HobIsFull && PeiPerformanceLogHeader->SizeOfAllEntries + RecordInfo.RecordSize > PeiPerformanceLogEntries * MAX_RECORD_SIZE) {
+ PeiPerformanceLogHeader->HobIsFull = TRUE;
+ }
+ if (!PeiPerformanceLogHeader->HobIsFull && PeiPerformanceLogHeader->SizeOfAllEntries + RecordInfo.RecordSize <= PeiPerformanceLogEntries * MAX_RECORD_SIZE) {
+ FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(PeiFirmwarePerformance + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER) + PeiPerformanceLogHeader->SizeOfAllEntries);
+ break;
+ }
+ //
+ // Previous HOB is used, then find next one.
+ //
+ GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, GET_NEXT_HOB (GuidHob));
+ }
- if (PeiPerformanceLog->NumberOfEntries >= PeiPerformanceLogEntries) {
- DEBUG ((DEBUG_ERROR, "PEI performance log array out of resources\n"));
- return RETURN_OUT_OF_RESOURCES;
+ if (GuidHob == NULL) {
+ //
+ // PEI Performance HOB was not found, then build one.
+ //
+ PeiPerformanceSize = sizeof (PEI_EXT_FIRMWARE_PERF_HEADER) +
+ MAX_RECORD_SIZE * PeiPerformanceLogEntries;
+ PeiFirmwarePerformance = (UINT8*)BuildGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, PeiPerformanceSize);
+ if (PeiFirmwarePerformance != NULL) {
+ ZeroMem (PeiFirmwarePerformance, PeiPerformanceSize);
+ }
+ PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *)PeiFirmwarePerformance;
+ FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(PeiFirmwarePerformance + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER));
}
- Index = PeiPerformanceLog->NumberOfEntries++;
- LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (PeiPerformanceLog + 1);
- LogEntryArray[Index].Handle = (EFI_PHYSICAL_ADDRESS) (UINTN) Handle;
- if (Token != NULL) {
- AsciiStrnCpyS (LogEntryArray[Index].Token, PEI_PERFORMANCE_STRING_SIZE, Token, PEI_PERFORMANCE_STRING_LENGTH);
+ if (PeiFirmwarePerformance == NULL) {
+ //
+ // there is no enough resource to store performance data
+ //
+ return EFI_OUT_OF_RESOURCES;
+ }
+
+ //
+ // Get the TimeStamp.
+ //
+ if (Ticker == 0) {
+ Ticker = GetPerformanceCounter ();
+ TimeStamp = GetTimeInNanoSecond (Ticker);
+ } else if (Ticker == 1) {
+ TimeStamp = 0;
+ } else {
+ TimeStamp = GetTimeInNanoSecond (Ticker);
}
- if (Module != NULL) {
- AsciiStrnCpyS (LogEntryArray[Index].Module, PEI_PERFORMANCE_STRING_SIZE, Module, PEI_PERFORMANCE_STRING_LENGTH);
+
+ //
+ // Get the ModuleGuid.
+ //
+ if (Handle != NULL) {
+ ModuleGuid = Handle;
+ } else {
+ ModuleGuid = &gEfiCallerIdGuid;
}
- LogEntryArray[Index].EndTimeStamp = 0;
- PeiPerformanceIdArray[Index] = Identifier;
+ switch (RecordInfo.Type) {
+ case GUID_EVENT_TYPE:
+ FpdtRecordPtr.GuidEvent->Header.Type = GUID_EVENT_TYPE;
+ FpdtRecordPtr.GuidEvent->Header.Length = sizeof (GUID_EVENT_RECORD);
+ FpdtRecordPtr.GuidEvent->Header.Revision = RECORD_REVISION_1;
+ FpdtRecordPtr.GuidEvent->ProgressID = RecordInfo.ProgressID;
+ FpdtRecordPtr.GuidEvent->Timestamp = TimeStamp;
+ CopyMem (&FpdtRecordPtr.GuidEvent->Guid, ModuleGuid, sizeof (EFI_GUID));
+ PeiPerformanceLogHeader->SizeOfAllEntries += sizeof (GUID_EVENT_RECORD);
+ break;
+
+ case GUID_QWORD_EVENT_TYPE:
+ FpdtRecordPtr.GuidQwordEvent->Header.Type = GUID_QWORD_EVENT_TYPE;
+ FpdtRecordPtr.GuidQwordEvent->Header.Length = sizeof (GUID_QWORD_EVENT_RECORD);
+ FpdtRecordPtr.GuidQwordEvent->Header.Revision = RECORD_REVISION_1;
+ FpdtRecordPtr.GuidQwordEvent->ProgressID = RecordInfo.ProgressID;
+ FpdtRecordPtr.GuidQwordEvent->Timestamp = TimeStamp;
+ PeiPerformanceLogHeader->LoadImageCount++;
+ FpdtRecordPtr.GuidQwordEvent->Qword = PeiPerformanceLogHeader->LoadImageCount;
+ CopyMem (&FpdtRecordPtr.GuidQwordEvent->Guid, ModuleGuid, sizeof (EFI_GUID));
+ PeiPerformanceLogHeader->SizeOfAllEntries += sizeof (GUID_QWORD_EVENT_RECORD);
+ break;
+
+ case DYNAMIC_STRING_EVENT_TYPE:
+ FpdtRecordPtr.DynamicStringEvent->Header.Type = DYNAMIC_STRING_EVENT_TYPE;
+ FpdtRecordPtr.DynamicStringEvent->Header.Length = RecordInfo.RecordSize;
+ FpdtRecordPtr.DynamicStringEvent->Header.Revision = RECORD_REVISION_1;
+ FpdtRecordPtr.DynamicStringEvent->ProgressID = RecordInfo.ProgressID;
+ FpdtRecordPtr.DynamicStringEvent->Timestamp = TimeStamp;
+ CopyMem (&FpdtRecordPtr.DynamicStringEvent->Guid, ModuleGuid, sizeof (EFI_GUID));
+ PeiPerformanceLogHeader->SizeOfAllEntries += RecordInfo.RecordSize;
+
+ if (Token != NULL) {
+ StringPtr = Token;
+ } else if (Module != NULL) {
+ StringPtr = Module;
+ }
+ if (StringPtr != NULL && AsciiStrLen (StringPtr) != 0) {
+ DestMax = (RecordInfo.RecordSize - sizeof (DYNAMIC_STRING_EVENT_RECORD)) / sizeof (CHAR8);
+ StrLength = AsciiStrLen (StringPtr);
+ if (StrLength >= DestMax) {
+ StrLength = DestMax -1;
+ }
+ AsciiStrnCpyS (FpdtRecordPtr.DynamicStringEvent->String, DestMax, StringPtr, StrLength);
+ }
+ break;
- if (TimeStamp == 0) {
- TimeStamp = GetPerformanceCounter ();
+ default:
+ //
+ // Record is not supported in current PEI phase, return EFI_ABORTED
+ //
+ return EFI_UNSUPPORTED;
}
- LogEntryArray[Index].StartTimeStamp = TimeStamp;
- return RETURN_SUCCESS;
+ return EFI_SUCCESS;
}
/**
- Fills in the end time of a performance measurement.
+ Creates a record for the beginning of a performance measurement.
+
+ If TimeStamp is zero, then this function reads the current time stamp
+ and adds that time stamp value to the record as the start time.
+
+ If TimeStamp is one, then this function reads 0 as the start time.
- Looks up the record that matches Handle, Token and Module.
- If the record can not be found then return RETURN_NOT_FOUND.
- If the record is found and TimeStamp is not zero,
- then TimeStamp is added to the record as the end time.
- If the record is found and TimeStamp is zero, then this function reads
- the current time stamp and adds that time stamp value to the record as the end time.
+ If TimeStamp is other value, then TimeStamp is added to the record as the start time.
+
+ @param Handle Pointer to environment specific context used
+ to identify the component being measured.
+ @param Token Pointer to a Null-terminated ASCII string
+ that identifies the component being measured.
+ @param Module Pointer to a Null-terminated ASCII string
+ that identifies the module being measured.
+ @param TimeStamp 64-bit time stamp.
+ @param Identifier 32-bit identifier. If the value is 0, the created record
+ is same as the one created by StartPerformanceMeasurement.
+
+ @retval RETURN_SUCCESS The start of the measurement was recorded.
+ @retval RETURN_OUT_OF_RESOURCES There are not enough resources to record the measurement.
+
+**/
+RETURN_STATUS
+EFIAPI
+StartPerformanceMeasurementEx (
+ IN CONST VOID *Handle, OPTIONAL
+ IN CONST CHAR8 *Token, OPTIONAL
+ IN CONST CHAR8 *Module, OPTIONAL
+ IN UINT64 TimeStamp,
+ IN UINT32 Identifier
+ )
+{
+ return InsertPeiFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
+}
+
+/**
+
+ Creates a record for the end of a performance measurement.
+
+ If the TimeStamp is not zero or one, then TimeStamp is added to the record as the end time.
+ If the TimeStamp is zero, then this function reads the current time stamp and adds that time stamp value to the record as the end time.
+ If the TimeStamp is one, then this function reads 0 as the end time.
@param Handle Pointer to environment specific context used
to identify the component being measured.
@param Token Pointer to a Null-terminated ASCII string
that identifies the component being measured.
@@ -250,28 +481,11 @@ EndPerformanceMeasurementEx (
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp,
IN UINT32 Identifier
)
{
- PEI_PERFORMANCE_LOG_HEADER *PeiPerformanceLog;
- UINT32 *PeiPerformanceIdArray;
- PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
- UINT32 Index;
-
- if (TimeStamp == 0) {
- TimeStamp = GetPerformanceCounter ();
- }
-
- InternalGetPerformanceHobLog (&PeiPerformanceLog, &PeiPerformanceIdArray);
- Index = InternalSearchForLogEntry (PeiPerformanceLog, PeiPerformanceIdArray, Handle, Token, Module, Identifier);
- if (Index >= PeiPerformanceLog->NumberOfEntries) {
- return RETURN_NOT_FOUND;
- }
- LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (PeiPerformanceLog + 1);
- LogEntryArray[Index].EndTimeStamp = TimeStamp;
-
- return RETURN_SUCCESS;
+ return InsertPeiFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
}
/**
Attempts to retrieve a performance measurement log entry from the performance measurement log.
It can also retrieve the log created by StartPerformanceMeasurement and EndPerformanceMeasurement,
@@ -293,10 +507,12 @@ EndPerformanceMeasurementEx (
If Module is NULL, then ASSERT().
If StartTimeStamp is NULL, then ASSERT().
If EndTimeStamp is NULL, then ASSERT().
If Identifier is NULL, then ASSERT().
+ !!!NOT Support yet!!!
+
@param LogEntryKey On entry, the key of the performance measurement log entry to retrieve.
0, then the first performance measurement log entry is retrieved.
On exit, the key of the next performance of entry entry.
@param Handle Pointer to environment specific context used to identify the component
being measured.
@@ -323,56 +539,24 @@ GetPerformanceMeasurementEx (
OUT UINT64 *StartTimeStamp,
OUT UINT64 *EndTimeStamp,
OUT UINT32 *Identifier
)
{
- PEI_PERFORMANCE_LOG_HEADER *PeiPerformanceLog;
- UINT32 *PeiPerformanceIdArray;
- PEI_PERFORMANCE_LOG_ENTRY *CurrentLogEntry;
- PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
- UINTN NumberOfEntries;
-
- ASSERT (Handle != NULL);
- ASSERT (Token != NULL);
- ASSERT (Module != NULL);
- ASSERT (StartTimeStamp != NULL);
- ASSERT (EndTimeStamp != NULL);
- ASSERT (Identifier != NULL);
-
- InternalGetPerformanceHobLog (&PeiPerformanceLog, &PeiPerformanceIdArray);
-
- NumberOfEntries = (UINTN) (PeiPerformanceLog->NumberOfEntries);
- LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (PeiPerformanceLog + 1);
- //
- // Make sure that LogEntryKey is a valid log entry key.
- //
- ASSERT (LogEntryKey <= NumberOfEntries);
-
- if (LogEntryKey == NumberOfEntries) {
- return 0;
- }
-
- CurrentLogEntry = &(LogEntryArray[LogEntryKey]);
-
- *Handle = (VOID *) (UINTN) (CurrentLogEntry->Handle);
- *Token = CurrentLogEntry->Token;
- *Module = CurrentLogEntry->Module;
- *StartTimeStamp = CurrentLogEntry->StartTimeStamp;
- *EndTimeStamp = CurrentLogEntry->EndTimeStamp;
- *Identifier = PeiPerformanceIdArray[LogEntryKey++];
-
- return LogEntryKey;
+ return 0;
}
/**
Creates a record for the beginning of a performance measurement.
- Creates a record that contains the Handle, Token, and Module.
- If TimeStamp is not zero, then TimeStamp is added to the record as the start time.
If TimeStamp is zero, then this function reads the current time stamp
and adds that time stamp value to the record as the start time.
+ If TimeStamp is one, then this function reads 0 as the start time.
+
+ If TimeStamp is other value, then TimeStamp is added to the record as the start time.
+
+
@param Handle Pointer to environment specific context used
to identify the component being measured.
@param Token Pointer to a Null-terminated ASCII string
that identifies the component being measured.
@param Module Pointer to a Null-terminated ASCII string
@@ -390,22 +574,20 @@ StartPerformanceMeasurement (
IN CONST CHAR8 *Token, OPTIONAL
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp
)
{
- return StartPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
+ return InsertPeiFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, 0);
}
/**
- Fills in the end time of a performance measurement.
- Looks up the record that matches Handle, Token, and Module.
- If the record can not be found then return RETURN_NOT_FOUND.
- If the record is found and TimeStamp is not zero,
- then TimeStamp is added to the record as the end time.
- If the record is found and TimeStamp is zero, then this function reads
- the current time stamp and adds that time stamp value to the record as the end time.
+ Creates a record for the end of a performance measurement.
+
+ If the TimeStamp is not zero or one, then TimeStamp is added to the record as the end time.
+ If the TimeStamp is zero, then this function reads the current time stamp and adds that time stamp value to the record as the end time.
+ If the TimeStamp is one, then this function reads 0 as the end time.
@param Handle Pointer to environment specific context used
to identify the component being measured.
@param Token Pointer to a Null-terminated ASCII string
that identifies the component being measured.
@@ -424,11 +606,11 @@ EndPerformanceMeasurement (
IN CONST CHAR8 *Token, OPTIONAL
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp
)
{
- return EndPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
+ return InsertPeiFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, 0);
}
/**
Attempts to retrieve a performance measurement log entry from the performance measurement log.
It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
@@ -449,10 +631,12 @@ EndPerformanceMeasurement (
If Token is NULL, then ASSERT().
If Module is NULL, then ASSERT().
If StartTimeStamp is NULL, then ASSERT().
If EndTimeStamp is NULL, then ASSERT().
+ NOT Support yet.
+
@param LogEntryKey On entry, the key of the performance measurement log entry to retrieve.
0, then the first performance measurement log entry is retrieved.
On exit, the key of the next performance of entry entry.
@param Handle Pointer to environment specific context used to identify the component
being measured.
@@ -477,12 +661,11 @@ GetPerformanceMeasurement (
OUT CONST CHAR8 **Module,
OUT UINT64 *StartTimeStamp,
OUT UINT64 *EndTimeStamp
)
{
- UINT32 Identifier;
- return GetPerformanceMeasurementEx (LogEntryKey, Handle, Token, Module, StartTimeStamp, EndTimeStamp, &Identifier);
+ return 0;
}
/**
Returns TRUE if the performance measurement macros are enabled.
diff --git a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
index 08aa064..7239673 100644
--- a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
+++ b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
@@ -3,11 +3,11 @@
#
# This library provides the performance measurement interfaces in PEI phase, it creates
# and consumes GUIDed HOB for performance logging. The GUIDed HOB is passed to DXE phase
# so that it can be taken over by DxeCorePerformanceLib.
#
-# Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
# (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
# http://opensource.org/licenses/bsd-license.php
@@ -51,14 +51,12 @@
[Guids]
## PRODUCES ## HOB
## CONSUMES ## HOB
- gPerformanceProtocolGuid
- ## PRODUCES ## HOB
- ## CONSUMES ## HOB
- gPerformanceExProtocolGuid
+ gEdkiiExtendedFirmwarePerformanceGuid
[Pcd]
- gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16 ## CONSUMES
- gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries ## CONSUMES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16 ## CONSUMES
+ gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly ## CONSUMES
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-01-30 13:53 [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table Dandan Bi
2018-01-30 13:53 ` [PATCH v2 1/8] MdeModulePkg:Add definitions for new Performance infrastructure Dandan Bi
2018-01-30 13:53 ` [PATCH v2 2/8] MdeModulePkg/PeiPerformance:Updated to track FPDT record in PEI phase Dandan Bi
@ 2018-01-30 13:53 ` Dandan Bi
2018-05-01 16:26 ` Ard Biesheuvel
2018-01-30 13:53 ` [PATCH v2 4/8] MdeModulePkg/SmmCorePerformanceLib:Track FPDT record in SMM phase Dandan Bi
` (5 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: Dandan Bi @ 2018-01-30 13:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Star Zeng
V2:
Update DxecorePerformanceLib to report the boot performance table
address instead of records contents.
Updated to convert Pref entry to FPDT record in DXE phase and then
allocate boot performance table to save the record and report
the address of boot performance table to FirmwarePerformanceDxe.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 1389 +++++++++++++++-----
.../DxeCorePerformanceLib.inf | 20 +-
.../DxeCorePerformanceLibInternal.h | 17 +-
3 files changed, 1108 insertions(+), 318 deletions(-)
diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
index 7c0e207..c6f8a16 100644
--- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
+++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
@@ -8,11 +8,11 @@
which are consumed by DxePerformanceLib to logging performance data in DXE phase.
This library is mainly used by DxeCore to start performance logging to ensure that
Performance Protocol is installed at the very beginning of DXE phase.
-Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -23,27 +23,65 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
**/
#include "DxeCorePerformanceLibInternal.h"
-
//
-// The data structure to hold global performance data.
+// Data for FPDT performance records.
//
-GAUGE_DATA_HEADER *mGaugeData;
+#define SMM_BOOT_RECORD_COMM_SIZE (OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + sizeof(SMM_BOOT_RECORD_COMMUNICATE))
+#define STRING_SIZE (EDKII_STRING_EVENT_RECORD_NAME_LENGTH * sizeof (CHAR8))
+#define MAX_RECORD_SIZE (sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE)
+#define FIRMWARE_RECORD_BUFFER 0x10000
+#define CACHE_HANDLE_GUID_COUNT 0x1000
+
+BOOT_PERFORMANCE_TABLE *mAcpiBootPerformanceTable = NULL;
+BOOT_PERFORMANCE_TABLE mBootPerformanceTableTemplate = {
+ {
+ EFI_ACPI_5_0_FPDT_BOOT_PERFORMANCE_TABLE_SIGNATURE,
+ sizeof (BOOT_PERFORMANCE_TABLE)
+ },
+ {
+ {
+ EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_TYPE_FIRMWARE_BASIC_BOOT, // Type
+ sizeof (EFI_ACPI_5_0_FPDT_FIRMWARE_BASIC_BOOT_RECORD), // Length
+ EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_REVISION_FIRMWARE_BASIC_BOOT // Revision
+ },
+ 0, // Reserved
+ //
+ // These values will be updated at runtime.
+ //
+ 0, // ResetEnd
+ 0, // OsLoaderLoadImageStart
+ 0, // OsLoaderStartImageStart
+ 0, // ExitBootServicesEntry
+ 0 // ExitBootServicesExit
+ }
+};
-//
-// The current maximum number of logging entries. If current number of
-// entries exceeds this value, it will re-allocate a larger array and
-// migration the old data to the larger array.
-//
-UINT32 mMaxGaugeRecords;
+typedef struct {
+ EFI_HANDLE Handle;
+ CHAR8 NameString[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
+ EFI_GUID ModuleGuid;
+} HANDLE_GUID_MAP;
-//
-// The handle to install Performance Protocol instance.
-//
-EFI_HANDLE mHandle = NULL;
+HANDLE_GUID_MAP mCacheHandleGuidTable[CACHE_HANDLE_GUID_COUNT];
+UINTN mCachePairCount = 0;
+
+UINT32 mLoadImageCount = 0;
+UINT32 mPerformanceLength = 0;
+UINT32 mMaxPerformanceLength = 0;
+UINT32 mBootRecordSize = 0;
+UINT32 mBootRecordMaxSize = 0;
+
+BOOLEAN mFpdtBufferIsReported = FALSE;
+BOOLEAN mLackSpaceIsReported = FALSE;
+CHAR8 *mPlatformLanguage = NULL;
+UINT8 *mPerformancePointer = NULL;
+UINT8 *mBootRecordBuffer = NULL;
+
+EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *mDevicePathToText = NULL;
//
// Interfaces for Performance Protocol.
//
PERFORMANCE_PROTOCOL mPerformanceInterface = {
@@ -61,179 +99,1069 @@ PERFORMANCE_EX_PROTOCOL mPerformanceExInterface = {
GetGaugeEx
};
PERFORMANCE_PROPERTY mPerformanceProperty;
-//
-// Gauge record lock to avoid data corruption or even memory overflow
-//
-STATIC EFI_LOCK mPerfRecordLock = EFI_INITIALIZE_LOCK_VARIABLE (TPL_NOTIFY);
+/**
+Check whether the Token is a known one which is uesed by core.
+
+@param Token Pointer to a Null-terminated ASCII string
+
+@retval TRUE Is a known one used by core.
+@retval FALSE Not a known one.
+
+**/
+BOOLEAN
+IsKnownTokens (
+ IN CONST CHAR8 *Token
+ )
+{
+ if (AsciiStrCmp (Token, SEC_TOK) == 0 ||
+ AsciiStrCmp (Token, PEI_TOK) == 0 ||
+ AsciiStrCmp (Token, DXE_TOK) == 0 ||
+ AsciiStrCmp (Token, BDS_TOK) == 0 ||
+ AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0 ||
+ AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0 ||
+ AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0 ||
+ AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0 ||
+ AsciiStrCmp (Token, START_IMAGE_TOK) == 0 ||
+ AsciiStrCmp (Token, PEIM_TOK) == 0) {
+ return TRUE;
+ } else {
+ return FALSE;
+ }
+}
+
+/**
+Check whether the ID is a known one which map to the known Token.
+
+@param Identifier 32-bit identifier.
+
+@retval TRUE Is a known one used by core.
+@retval FALSE Not a known one.
+
+**/
+BOOLEAN
+IsKnownID (
+ IN UINT32 Identifier
+ )
+{
+ if (Identifier == MODULE_START_ID ||
+ Identifier == MODULE_END_ID ||
+ Identifier == MODULE_LOADIMAGE_START_ID ||
+ Identifier == MODULE_LOADIMAGE_END_ID ||
+ Identifier == MODULE_DB_START_ID ||
+ Identifier == MODULE_DB_END_ID ||
+ Identifier == MODULE_DB_SUPPORT_START_ID ||
+ Identifier == MODULE_DB_SUPPORT_END_ID ||
+ Identifier == MODULE_DB_STOP_START_ID ||
+ Identifier == MODULE_DB_STOP_END_ID) {
+ return TRUE;
+ } else {
+ return FALSE;
+ }
+}
/**
- Searches in the gauge array with keyword Handle, Token, Module and Identifier.
+ Allocate EfiReservedMemoryType below 4G memory address.
+
+ This function allocates EfiReservedMemoryType below 4G memory address.
+
+ @param[in] Size Size of memory to allocate.
+
+ @return Allocated address for output.
+
+**/
+VOID *
+FpdtAllocateReservedMemoryBelow4G (
+ IN UINTN Size
+ )
+{
+ UINTN Pages;
+ EFI_PHYSICAL_ADDRESS Address;
+ EFI_STATUS Status;
+ VOID *Buffer;
+
+ Buffer = NULL;
+ Pages = EFI_SIZE_TO_PAGES (Size);
+ Address = 0xffffffff;
+
+ Status = gBS->AllocatePages (
+ AllocateMaxAddress,
+ EfiReservedMemoryType,
+ Pages,
+ &Address
+ );
+ ASSERT_EFI_ERROR (Status);
+
+ if (!EFI_ERROR (Status)) {
+ Buffer = (VOID *) (UINTN) Address;
+ ZeroMem (Buffer, Size);
+ }
+
+ return Buffer;
+}
+
+/**
+ Allocate buffer for Boot Performance table.
+
+ @return Status code.
+
+**/
+EFI_STATUS
+AllocateBootPerformanceTable (
+ )
+{
+ EFI_STATUS Status;
+ UINTN Size;
+ UINT8 *SmmBootRecordCommBuffer;
+ EFI_SMM_COMMUNICATE_HEADER *SmmCommBufferHeader;
+ SMM_BOOT_RECORD_COMMUNICATE *SmmCommData;
+ UINTN CommSize;
+ UINTN BootPerformanceDataSize;
+ UINT8 *BootPerformanceData;
+ EFI_SMM_COMMUNICATION_PROTOCOL *Communication;
+ FIRMWARE_PERFORMANCE_VARIABLE PerformanceVariable;
+ EDKII_PI_SMM_COMMUNICATION_REGION_TABLE *SmmCommRegionTable;
+ EFI_MEMORY_DESCRIPTOR *SmmCommMemRegion;
+ UINTN Index;
+ VOID *SmmBootRecordData;
+ UINTN SmmBootRecordDataSize;
+ UINTN ReservedMemSize;
+
+ //
+ // Collect boot records from SMM drivers.
+ //
+ SmmBootRecordCommBuffer = NULL;
+ SmmCommData = NULL;
+ SmmBootRecordData = NULL;
+ SmmBootRecordDataSize = 0;
+ ReservedMemSize = 0;
+ Status = gBS->LocateProtocol (&gEfiSmmCommunicationProtocolGuid, NULL, (VOID **) &Communication);
+ if (!EFI_ERROR (Status)) {
+ //
+ // Initialize communicate buffer
+ // Get the prepared Reserved Memory Range
+ //
+ Status = EfiGetSystemConfigurationTable (
+ &gEdkiiPiSmmCommunicationRegionTableGuid,
+ (VOID **) &SmmCommRegionTable
+ );
+ if (!EFI_ERROR (Status)) {
+ ASSERT (SmmCommRegionTable != NULL);
+ SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) (SmmCommRegionTable + 1);
+ for (Index = 0; Index < SmmCommRegionTable->NumberOfEntries; Index ++) {
+ if (SmmCommMemRegion->Type == EfiConventionalMemory) {
+ break;
+ }
+ SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) ((UINT8 *) SmmCommMemRegion + SmmCommRegionTable->DescriptorSize);
+ }
+ ASSERT (Index < SmmCommRegionTable->NumberOfEntries);
+ ASSERT (SmmCommMemRegion->PhysicalStart > 0);
+ ASSERT (SmmCommMemRegion->NumberOfPages > 0);
+ ReservedMemSize = (UINTN) SmmCommMemRegion->NumberOfPages * EFI_PAGE_SIZE;
+
+ //
+ // Check enough reserved memory space
+ //
+ if (ReservedMemSize > SMM_BOOT_RECORD_COMM_SIZE) {
+ SmmBootRecordCommBuffer = (VOID *) (UINTN) SmmCommMemRegion->PhysicalStart;
+ SmmCommBufferHeader = (EFI_SMM_COMMUNICATE_HEADER*)SmmBootRecordCommBuffer;
+ SmmCommData = (SMM_BOOT_RECORD_COMMUNICATE*)SmmCommBufferHeader->Data;
+ ZeroMem((UINT8*)SmmCommData, sizeof(SMM_BOOT_RECORD_COMMUNICATE));
+
+ CopyGuid (&SmmCommBufferHeader->HeaderGuid, &gEfiFirmwarePerformanceGuid);
+ SmmCommBufferHeader->MessageLength = sizeof(SMM_BOOT_RECORD_COMMUNICATE);
+ CommSize = SMM_BOOT_RECORD_COMM_SIZE;
+
+ //
+ // Get the size of boot records.
+ //
+ SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_SIZE;
+ SmmCommData->BootRecordData = NULL;
+ Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
+ ASSERT_EFI_ERROR (Status);
+
+ if (!EFI_ERROR (SmmCommData->ReturnStatus) && SmmCommData->BootRecordSize != 0) {
+ //
+ // Get all boot records
+ //
+ SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
+ SmmBootRecordDataSize = SmmCommData->BootRecordSize;
+ SmmBootRecordData = AllocateZeroPool(SmmBootRecordDataSize);
+ ASSERT (SmmBootRecordData != NULL);
+ SmmCommData->BootRecordOffset = 0;
+ SmmCommData->BootRecordData = (VOID *) ((UINTN) SmmCommMemRegion->PhysicalStart + SMM_BOOT_RECORD_COMM_SIZE);
+ SmmCommData->BootRecordSize = ReservedMemSize - SMM_BOOT_RECORD_COMM_SIZE;
+ while (SmmCommData->BootRecordOffset < SmmBootRecordDataSize) {
+ Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
+ ASSERT_EFI_ERROR (Status);
+ ASSERT_EFI_ERROR(SmmCommData->ReturnStatus);
+ if (SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize > SmmBootRecordDataSize) {
+ CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmBootRecordDataSize - SmmCommData->BootRecordOffset);
+ } else {
+ CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmCommData->BootRecordSize);
+ }
+ SmmCommData->BootRecordOffset = SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize;
+ }
+ }
+ }
+ }
+ }
+
+ //
+ // Prepare memory for Boot Performance table.
+ // Boot Performance table includes BasicBoot record, and one or more appended Boot Records.
+ //
+ BootPerformanceDataSize = sizeof (BOOT_PERFORMANCE_TABLE) + mPerformanceLength + PcdGet32 (PcdExtFpdtBootRecordPadSize);
+ if (SmmCommData != NULL) {
+ BootPerformanceDataSize += SmmBootRecordDataSize;
+ }
+
+ //
+ // Try to allocate the same runtime buffer as last time boot.
+ //
+ ZeroMem (&PerformanceVariable, sizeof (PerformanceVariable));
+ Size = sizeof (PerformanceVariable);
+ Status = gRT->GetVariable (
+ EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
+ &gEfiFirmwarePerformanceGuid,
+ NULL,
+ &Size,
+ &PerformanceVariable
+ );
+ if (!EFI_ERROR (Status)) {
+ Status = gBS->AllocatePages (
+ AllocateAddress,
+ EfiReservedMemoryType,
+ EFI_SIZE_TO_PAGES (BootPerformanceDataSize),
+ &PerformanceVariable.BootPerformanceTablePointer
+ );
+ if (!EFI_ERROR (Status)) {
+ mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) (UINTN) PerformanceVariable.BootPerformanceTablePointer;
+ }
+ }
+
+ if (mAcpiBootPerformanceTable == NULL) {
+ //
+ // Fail to allocate at specified address, continue to allocate at any address.
+ //
+ mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) FpdtAllocateReservedMemoryBelow4G (BootPerformanceDataSize);
+ }
+ DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: ACPI Boot Performance Table address = 0x%x\n", mAcpiBootPerformanceTable));
+
+ if (mAcpiBootPerformanceTable == NULL) {
+ if (SmmCommData != NULL && SmmBootRecordData != NULL) {
+ FreePool (SmmBootRecordData);
+ }
+ return EFI_OUT_OF_RESOURCES;
+ }
+
+ //
+ // Prepare Boot Performance Table.
+ //
+ BootPerformanceData = (UINT8 *) mAcpiBootPerformanceTable;
+ //
+ // Fill Basic Boot record to Boot Performance Table.
+ //
+ CopyMem (mAcpiBootPerformanceTable, &mBootPerformanceTableTemplate, sizeof (mBootPerformanceTableTemplate));
+ BootPerformanceData = BootPerformanceData + mAcpiBootPerformanceTable->Header.Length;
+ //
+ // Fill Boot records from boot drivers.
+ //
+ if (mPerformancePointer != NULL) {
+ CopyMem (BootPerformanceData, mPerformancePointer, mPerformanceLength);
+ mAcpiBootPerformanceTable->Header.Length += mPerformanceLength;
+ BootPerformanceData = BootPerformanceData + mPerformanceLength;
+ }
+ if (SmmCommData != NULL && SmmBootRecordData != NULL) {
+ //
+ // Fill Boot records from SMM drivers.
+ //
+ CopyMem (BootPerformanceData, SmmBootRecordData, SmmBootRecordDataSize);
+ FreePool (SmmBootRecordData);
+ mAcpiBootPerformanceTable->Header.Length = (UINT32) (mAcpiBootPerformanceTable->Header.Length + SmmBootRecordDataSize);
+ BootPerformanceData = BootPerformanceData + SmmBootRecordDataSize;
+ }
+
+ //
+ // Save Boot Performance Table address to Variable for use in S4 resume.
+ //
+ PerformanceVariable.BootPerformanceTablePointer = (EFI_PHYSICAL_ADDRESS) (UINTN) mAcpiBootPerformanceTable;
+
+ //
+ // Save Runtime Performance Table pointers to Variable.
+ // Don't check SetVariable return status. It doesn't impact FPDT table generation.
+ //
+ gRT->SetVariable (
+ EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
+ &gEfiFirmwarePerformanceGuid,
+ EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
+ sizeof (PerformanceVariable),
+ &PerformanceVariable
+ );
+
+ mBootRecordBuffer = (UINT8 *) mAcpiBootPerformanceTable;
+ mBootRecordSize = mAcpiBootPerformanceTable->Header.Length;
+ mBootRecordMaxSize = mBootRecordSize + PcdGet32 (PcdExtFpdtBootRecordPadSize);
+
+ return EFI_SUCCESS;
+}
+
+/**
+ Get a human readable module name and module guid for the given image handle.
+ If module name can't be found, "" string will return.
+ If module guid can't be found, Zero Guid will return.
+
+ @param Handle Image handle or Controller handle.
+ @param NameString The ascii string will be filled into it. If not found, null string will return.
+ @param BufferSize Size of the input NameString buffer.
+ @param ModuleGuid Point to the guid buffer to store the got module guid value.
+
+ @retval EFI_SUCCESS Successfully get module name and guid.
+ @retval EFI_INVALID_PARAMETER The input parameter NameString is NULL.
+ @retval other value Module Name can't be got.
+**/
+EFI_STATUS
+GetModuleInfoFromHandle (
+ IN EFI_HANDLE Handle,
+ OUT CHAR8 *NameString,
+ IN UINTN BufferSize,
+ OUT EFI_GUID *ModuleGuid OPTIONAL
+ )
+{
+ EFI_STATUS Status;
+ EFI_LOADED_IMAGE_PROTOCOL *LoadedImage;
+ EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
+ CHAR8 *PdbFileName;
+ EFI_GUID *TempGuid;
+ UINTN StartIndex;
+ UINTN Index;
+ INTN Count;
+ BOOLEAN ModuleGuidIsGet;
+ UINTN StringSize;
+ CHAR16 *StringPtr;
+ EFI_COMPONENT_NAME2_PROTOCOL *ComponentName2;
+ MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *FvFilePath;
+
+ if (NameString == NULL || BufferSize == 0) {
+ return EFI_INVALID_PARAMETER;
+ }
+ //
+ // Try to get the ModuleGuid and name string form the caached array.
+ //
+ if (mCachePairCount > 0) {
+ for (Count = mCachePairCount -1; Count >= 0; Count--) {
+ if (Handle == mCacheHandleGuidTable[Count].Handle) {
+ CopyGuid (ModuleGuid, &mCacheHandleGuidTable[Count].ModuleGuid);
+ AsciiStrCpyS (NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, mCacheHandleGuidTable[Count].NameString);
+ return EFI_SUCCESS;
+ }
+ }
+ }
+
+ Status = EFI_INVALID_PARAMETER;
+ LoadedImage = NULL;
+ ModuleGuidIsGet = FALSE;
+
+ //
+ // Initialize GUID as zero value.
+ //
+ TempGuid = &gZeroGuid;
+ //
+ // Initialize it as "" string.
+ //
+ NameString[0] = 0;
+
+ if (Handle != NULL) {
+ //
+ // Try Handle as ImageHandle.
+ //
+ Status = gBS->HandleProtocol (
+ Handle,
+ &gEfiLoadedImageProtocolGuid,
+ (VOID**) &LoadedImage
+ );
+
+ if (EFI_ERROR (Status)) {
+ //
+ // Try Handle as Controller Handle
+ //
+ Status = gBS->OpenProtocol (
+ Handle,
+ &gEfiDriverBindingProtocolGuid,
+ (VOID **) &DriverBinding,
+ NULL,
+ NULL,
+ EFI_OPEN_PROTOCOL_GET_PROTOCOL
+ );
+ if (!EFI_ERROR (Status)) {
+ //
+ // Get Image protocol from ImageHandle
+ //
+ Status = gBS->HandleProtocol (
+ DriverBinding->ImageHandle,
+ &gEfiLoadedImageProtocolGuid,
+ (VOID**) &LoadedImage
+ );
+ }
+ }
+ }
+
+ if (!EFI_ERROR (Status) && LoadedImage != NULL) {
+ //
+ // Get Module Guid from DevicePath.
+ //
+ if (LoadedImage->FilePath != NULL &&
+ LoadedImage->FilePath->Type == MEDIA_DEVICE_PATH &&
+ LoadedImage->FilePath->SubType == MEDIA_PIWG_FW_FILE_DP
+ ) {
+ //
+ // Determine GUID associated with module logging performance
+ //
+ ModuleGuidIsGet = TRUE;
+ FvFilePath = (MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *) LoadedImage->FilePath;
+ TempGuid = &FvFilePath->FvFileName;
+ }
+
+ //
+ // Method 1 Get Module Name from PDB string.
+ //
+ PdbFileName = PeCoffLoaderGetPdbPointer (LoadedImage->ImageBase);
+ if (PdbFileName != NULL && BufferSize > 0) {
+ StartIndex = 0;
+ for (Index = 0; PdbFileName[Index] != 0; Index++) {
+ if ((PdbFileName[Index] == '\\') || (PdbFileName[Index] == '/')) {
+ StartIndex = Index + 1;
+ }
+ }
+ //
+ // Copy the PDB file name to our temporary string.
+ // If the length is bigger than BufferSize, trim the redudant characters to avoid overflow in array boundary.
+ //
+ for (Index = 0; Index < BufferSize - 1; Index++) {
+ NameString[Index] = PdbFileName[Index + StartIndex];
+ if (NameString[Index] == 0 || NameString[Index] == '.') {
+ NameString[Index] = 0;
+ break;
+ }
+ }
- This internal function searches for the gauge entry in the gauge array.
- If there is an entry that exactly matches the given keywords
- and its end time stamp is zero, then the index of that gauge entry is returned;
- otherwise, the the number of gauge entries in the array is returned.
+ if (Index == BufferSize - 1) {
+ NameString[Index] = 0;
+ }
+ //
+ // Module Name is got.
+ //
+ goto Done;
+ }
+ }
+ //
+ // Method 2: Get the name string from ComponentName2 protocol
+ //
+ Status = gBS->HandleProtocol (
+ Handle,
+ &gEfiComponentName2ProtocolGuid,
+ (VOID **) &ComponentName2
+ );
+ if (!EFI_ERROR (Status)) {
+ //
+ // Get the current platform language setting
+ //
+ if (mPlatformLanguage == NULL) {
+ GetEfiGlobalVariable2 (L"PlatformLang", (VOID **) &mPlatformLanguage, NULL);
+ }
+ if (mPlatformLanguage != NULL) {
+ Status = ComponentName2->GetDriverName (
+ ComponentName2,
+ mPlatformLanguage != NULL ? mPlatformLanguage : "en-US",
+ &StringPtr
+ );
+ if (!EFI_ERROR (Status)) {
+ for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
+ NameString[Index] = (CHAR8) StringPtr[Index];
+ }
+ NameString[Index] = 0;
+ //
+ // Module Name is got.
+ //
+ goto Done;
+ }
+ }
+ }
+
+ if (ModuleGuidIsGet) {
+ //
+ // Method 3 Try to get the image's FFS UI section by image GUID
+ //
+ StringPtr = NULL;
+ StringSize = 0;
+ Status = GetSectionFromAnyFv (
+ TempGuid,
+ EFI_SECTION_USER_INTERFACE,
+ 0,
+ (VOID **) &StringPtr,
+ &StringSize
+ );
+
+ if (!EFI_ERROR (Status)) {
+ //
+ // Method 3. Get the name string from FFS UI section
+ //
+ for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
+ NameString[Index] = (CHAR8) StringPtr[Index];
+ }
+ NameString[Index] = 0;
+ FreePool (StringPtr);
+ }
+ }
+
+Done:
+ //
+ // Copy Module Guid
+ //
+ if (ModuleGuid != NULL) {
+ CopyGuid (ModuleGuid, TempGuid);
+ if (IsZeroGuid(TempGuid) && (Handle != NULL) && !ModuleGuidIsGet) {
+ // Handle is GUID
+ CopyGuid (ModuleGuid, (EFI_GUID *) Handle);
+ }
+ }
+
+ //
+ // Cache the Handle and Guid pairs.
+ //
+ if (mCachePairCount < CACHE_HANDLE_GUID_COUNT) {
+ mCacheHandleGuidTable[mCachePairCount].Handle = Handle;
+ CopyGuid (&mCacheHandleGuidTable[mCachePairCount].ModuleGuid, ModuleGuid);
+ AsciiStrCpyS (mCacheHandleGuidTable[mCachePairCount].NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, NameString);
+ mCachePairCount ++;
+ }
+
+ return Status;
+}
+
+/**
+ Get the FPDT record info.
+
+ @param IsStart TRUE if the performance log is start log.
@param Handle Pointer to environment specific context used
to identify the component being measured.
@param Token Pointer to a Null-terminated ASCII string
that identifies the component being measured.
@param Module Pointer to a Null-terminated ASCII string
that identifies the module being measured.
- @param Identifier 32-bit identifier.
+ @param RecordInfo On return, pointer to the info of the record.
+ @param UseModuleName Only useful for DYNAMIC_STRING_EVENT_TYPE, indicate that whether need use
+ Module name to fill the string field in the DYNAMIC_STRING_EVENT_RECORD.
- @retval The index of gauge entry in the array.
+ @retval EFI_SUCCESS Get record info successfully.
+ @retval EFI_UNSUPPORTED No matched FPDT record.
**/
-UINT32
-InternalSearchForGaugeEntry (
- IN CONST VOID *Handle, OPTIONAL
- IN CONST CHAR8 *Token, OPTIONAL
- IN CONST CHAR8 *Module, OPTIONAL
- IN UINT32 Identifier
+EFI_STATUS
+GetFpdtRecordInfo (
+ IN BOOLEAN IsStart,
+ IN CONST VOID *Handle,
+ IN CONST CHAR8 *Token,
+ IN CONST CHAR8 *Module,
+ OUT BASIC_RECORD_INFO *RecordInfo,
+ IN OUT BOOLEAN *UseModuleName
)
{
- UINT32 Index;
- UINT32 Index2;
- UINT32 NumberOfEntries;
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
+ UINT16 RecordType;
+ UINTN StringSize;
- if (Token == NULL) {
- Token = "";
- }
- if (Module == NULL) {
- Module = "";
+ RecordType = DYNAMIC_STRING_EVENT_TYPE;
+
+ //
+ // Token to Type and Id.
+ //
+ if (Token != NULL) {
+ if (AsciiStrCmp (Token, START_IMAGE_TOK) == 0) { // "StartImage:"
+ *UseModuleName = TRUE;
+ RecordType = GUID_EVENT_TYPE;
+ if (IsStart) {
+ RecordInfo->ProgressID = MODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = MODULE_END_ID;
+ }
+ } else if (AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) { // "LoadImage:"
+ *UseModuleName = TRUE;
+ RecordType = GUID_QWORD_EVENT_TYPE;
+ if (IsStart) {
+ RecordInfo->ProgressID = MODULE_LOADIMAGE_START_ID;
+ } else {
+ RecordInfo->ProgressID = MODULE_LOADIMAGE_END_ID;
+ }
+ } else if (AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0) { // "DB:Start:"
+ *UseModuleName = TRUE;
+ if (IsStart) {
+ RecordInfo->ProgressID = MODULE_DB_START_ID;
+ RecordType = GUID_QWORD_EVENT_TYPE;
+ } else {
+ RecordInfo->ProgressID = MODULE_DB_END_ID;
+ RecordType = GUID_QWORD_STRING_EVENT_TYPE;
+ }
+ } else if (AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0) { // "DB:Support:"
+ *UseModuleName = TRUE;
+ if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
+ return RETURN_UNSUPPORTED;
+ }
+ RecordType = GUID_QWORD_EVENT_TYPE;
+ if (IsStart) {
+ RecordInfo->ProgressID = MODULE_DB_SUPPORT_START_ID;
+ } else {
+ RecordInfo->ProgressID = MODULE_DB_SUPPORT_END_ID;
+ }
+ } else if (AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0) { // "DB:Stop:"
+ *UseModuleName = TRUE;
+ if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
+ return RETURN_UNSUPPORTED;
+ }
+ RecordType = GUID_QWORD_EVENT_TYPE;
+ if (IsStart) {
+ RecordInfo->ProgressID = MODULE_DB_STOP_START_ID;
+ } else {
+ RecordInfo->ProgressID = MODULE_DB_STOP_END_ID;
+ }
+ } else if (AsciiStrCmp (Token, PEI_TOK) == 0 || // "PEI"
+ AsciiStrCmp (Token, DXE_TOK) == 0 || // "DXE"
+ AsciiStrCmp (Token, BDS_TOK) == 0) { // "BDS"
+ if (IsStart) {
+ RecordInfo->ProgressID = PERF_CROSSMODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = PERF_CROSSMODULE_END_ID;
+ }
+ } else { // Pref used in Modules.
+ if (IsStart) {
+ RecordInfo->ProgressID = PERF_INMODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = PERF_INMODULE_END_ID;
+ }
+ }
+ } else if (Handle!= NULL || Module != NULL) { // Pref used in Modules.
+ if (IsStart) {
+ RecordInfo->ProgressID = PERF_INMODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = PERF_INMODULE_END_ID;
+ }
+ } else {
+ return EFI_UNSUPPORTED;
}
- NumberOfEntries = mGaugeData->NumberOfEntries;
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
+ //
+ // Get Record size baesed on the record type.
+ // When PcdEdkiiFpdtStringRecordEnableOnly is TRUE, all records are with type of DYNAMIC_STRING_EVENT_TYPE.
+ //
+ if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
+ RecordType = DYNAMIC_STRING_EVENT_TYPE;
+ RecordInfo->RecordSize = sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE;
+ } else {
+ switch (RecordType) {
+ case GUID_EVENT_TYPE:
+ RecordInfo->RecordSize = sizeof (GUID_EVENT_RECORD);
+ break;
- Index2 = 0;
+ case DYNAMIC_STRING_EVENT_TYPE:
+ if (*UseModuleName) {
+ StringSize = STRING_SIZE;
+ } else if (Token != NULL) {
+ StringSize = AsciiStrSize (Token);
+ } else if (Module != NULL) {
+ StringSize = AsciiStrSize (Module);
+ } else {
+ StringSize = STRING_SIZE;
+ }
+ if (StringSize > STRING_SIZE) {
+ StringSize = STRING_SIZE;
+ }
+ RecordInfo->RecordSize = (UINT8)(sizeof (DYNAMIC_STRING_EVENT_RECORD) + StringSize);
+ break;
- for (Index = 0; Index < NumberOfEntries; Index++) {
- Index2 = NumberOfEntries - 1 - Index;
- if (GaugeEntryExArray[Index2].EndTimeStamp == 0 &&
- (GaugeEntryExArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&
- AsciiStrnCmp (GaugeEntryExArray[Index2].Token, Token, DXE_PERFORMANCE_STRING_LENGTH) == 0 &&
- AsciiStrnCmp (GaugeEntryExArray[Index2].Module, Module, DXE_PERFORMANCE_STRING_LENGTH) == 0) {
- Index = Index2;
+ case GUID_QWORD_EVENT_TYPE:
+ RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_EVENT_RECORD);
break;
+
+ case GUID_QWORD_STRING_EVENT_TYPE:
+ RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_STRING_EVENT_RECORD);
+ break;
+
+ default:
+ //
+ // Record is unsupported yet, return EFI_UNSUPPORTED
+ //
+ return EFI_UNSUPPORTED;
}
}
- return Index;
+ RecordInfo->Type = RecordType;
+ return EFI_SUCCESS;
}
/**
- Adds a record at the end of the performance measurement log
- that records the start time of a performance measurement.
-
- Adds a record to the end of the performance measurement log
- that contains the Handle, Token, Module and Identifier.
- The end time of the new record must be set to zero.
- If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
- If TimeStamp is zero, the start time in the record is filled in with the value
- read from the current time stamp.
+ Add performance log to FPDT boot record table.
+ @param IsStart TRUE if the performance log is start log.
@param Handle Pointer to environment specific context used
to identify the component being measured.
@param Token Pointer to a Null-terminated ASCII string
that identifies the component being measured.
@param Module Pointer to a Null-terminated ASCII string
that identifies the module being measured.
- @param TimeStamp 64-bit time stamp.
+ @param Ticker 64-bit time stamp.
@param Identifier 32-bit identifier. If the value is 0, the created record
is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
- @retval EFI_SUCCESS The data was read correctly from the device.
+ @retval EFI_SUCCESS Add FPDT boot record.
@retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
+ @retval EFI_UNSUPPORTED No matched FPDT record.
**/
EFI_STATUS
-EFIAPI
-StartGaugeEx (
+InsertFpdtMeasurement (
+ IN BOOLEAN IsStart,
IN CONST VOID *Handle, OPTIONAL
IN CONST CHAR8 *Token, OPTIONAL
IN CONST CHAR8 *Module, OPTIONAL
- IN UINT64 TimeStamp,
+ IN UINT64 Ticker,
IN UINT32 Identifier
)
{
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
- UINTN GaugeDataSize;
- GAUGE_DATA_HEADER *NewGaugeData;
- UINTN OldGaugeDataSize;
- GAUGE_DATA_HEADER *OldGaugeData;
- UINT32 Index;
- EFI_STATUS Status;
+ EFI_GUID ModuleGuid;
+ CHAR8 ModuleName[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
+ UINT8 FpdtRecord[MAX_RECORD_SIZE];
+ EFI_STATUS Status;
+ FPDT_RECORD_PTR FpdtRecordPtr;
+ BASIC_RECORD_INFO RecordInfo;
+ UINT64 TimeStamp;
+ UINTN DestMax;
+ UINTN StrLength;
+ CONST CHAR8 *StringPtr;
+ BOOLEAN UseModuleName;
+
+ StringPtr = NULL;
+ UseModuleName = FALSE;
+ ZeroMem (ModuleName, sizeof (ModuleName));
+ ZeroMem (FpdtRecord, sizeof (FpdtRecord));
- Status = EfiAcquireLockOrFail (&mPerfRecordLock);
+ //
+ // Get record info (type, size, ProgressID and Module Guid).
+ //
+ Status = GetFpdtRecordInfo (IsStart, Handle, Token, Module, &RecordInfo, &UseModuleName);
if (EFI_ERROR (Status)) {
return Status;
}
- Index = mGaugeData->NumberOfEntries;
- if (Index >= mMaxGaugeRecords) {
+ //
+ // If PERF_START()/PERF_END() have specified the ProgressID,it has high priority.
+ // !!! Note: If the Pref is not the known Token used in the core but have same
+ // ID with the core Token, this case will not be supported.
+ // And in currtnt usage mode, for the unkown ID, there is a general rule:
+ // If it is start pref: the lower 4 bits of the ID should be 0.
+ // If it is end pref: the lower 4 bits of the ID should not be 0.
+ // If input ID doesn't follow the rule, we will adjust it.
+ //
+ if ((Identifier != 0) && (IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
+ return EFI_UNSUPPORTED;
+ } else if ((Identifier != 0) && (!IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
+ if (IsStart && ((Identifier & 0x000F) != 0)) {
+ Identifier &= 0xFFF0;
+ } else if ((!IsStart) && ((Identifier & 0x000F) == 0)) {
+ Identifier += 1;
+ }
+ RecordInfo.ProgressID = (UINT16)Identifier;
+ }
+
+ if (mFpdtBufferIsReported) {
+ FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)FpdtRecord;
+ } else {
+ //
+ // Check if pre-allocated buffer is full
//
- // Try to enlarge the scale of gauge array.
+ if (mPerformanceLength + RecordInfo.RecordSize > mMaxPerformanceLength) {
+ mPerformancePointer = ReallocatePool (
+ mPerformanceLength,
+ mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER,
+ mPerformancePointer
+ );
+
+ if (mPerformancePointer == NULL) {
+ return EFI_OUT_OF_RESOURCES;
+ }
+ mMaxPerformanceLength = mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER;
+ }
//
- OldGaugeData = mGaugeData;
- OldGaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords;
+ // Covert buffer to FPDT Ptr Union type.
+ //
+ FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(mPerformancePointer + mPerformanceLength);
+ }
+ FpdtRecordPtr.RecordHeader->Length = 0;
- GaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords * 2;
+ //
+ // Get the TimeStamp.
+ //
+ if (Ticker == 0) {
+ Ticker = GetPerformanceCounter ();
+ TimeStamp = GetTimeInNanoSecond (Ticker);
+ } else if (Ticker == 1) {
+ TimeStamp = 0;
+ } else {
+ TimeStamp = GetTimeInNanoSecond (Ticker);
+ }
- NewGaugeData = AllocateZeroPool (GaugeDataSize);
- if (NewGaugeData == NULL) {
- EfiReleaseLock (&mPerfRecordLock);
- return EFI_OUT_OF_RESOURCES;
+ //
+ // Get the ModuleName and ModuleGuid form the handle.
+ //
+ GetModuleInfoFromHandle ((EFI_HANDLE *)Handle, ModuleName, sizeof (ModuleName), &ModuleGuid);
+
+ //
+ // Fill in the record information.
+ //
+ switch (RecordInfo.Type) {
+ case GUID_EVENT_TYPE:
+ FpdtRecordPtr.GuidEvent->Header.Type = GUID_EVENT_TYPE;
+ FpdtRecordPtr.GuidEvent->Header.Length = RecordInfo.RecordSize;
+ FpdtRecordPtr.GuidEvent->Header.Revision = RECORD_REVISION_1;
+ FpdtRecordPtr.GuidEvent->ProgressID = RecordInfo.ProgressID;
+ FpdtRecordPtr.GuidEvent->Timestamp = TimeStamp;
+ CopyMem (&FpdtRecordPtr.GuidEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidEvent->Guid));
+ break;
+
+ case DYNAMIC_STRING_EVENT_TYPE:
+ FpdtRecordPtr.DynamicStringEvent->Header.Type = DYNAMIC_STRING_EVENT_TYPE;
+ FpdtRecordPtr.DynamicStringEvent->Header.Length = RecordInfo.RecordSize;
+ FpdtRecordPtr.DynamicStringEvent->Header.Revision = RECORD_REVISION_1;
+ FpdtRecordPtr.DynamicStringEvent->ProgressID = RecordInfo.ProgressID;
+ FpdtRecordPtr.DynamicStringEvent->Timestamp = TimeStamp;
+ CopyMem (&FpdtRecordPtr.DynamicStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.DynamicStringEvent->Guid));
+
+ if (UseModuleName) {
+ StringPtr = ModuleName;
+ } else if (Token != NULL) {
+ StringPtr = Token;
+ } else if (Module != NULL) {
+ StringPtr = Module;
+ } else if (ModuleName != NULL) {
+ StringPtr = ModuleName;
+ }
+ if (StringPtr != NULL && AsciiStrLen (StringPtr) != 0) {
+ StrLength = AsciiStrLen (StringPtr);
+ DestMax = (RecordInfo.RecordSize - sizeof (DYNAMIC_STRING_EVENT_RECORD)) / sizeof (CHAR8);
+ if (StrLength >= DestMax) {
+ StrLength = DestMax -1;
+ }
+ AsciiStrnCpyS (FpdtRecordPtr.DynamicStringEvent->String, DestMax, StringPtr, StrLength);
}
+ break;
+
+ case GUID_QWORD_EVENT_TYPE:
+ FpdtRecordPtr.GuidQwordEvent->Header.Type = GUID_QWORD_EVENT_TYPE;
+ FpdtRecordPtr.GuidQwordEvent->Header.Length = RecordInfo.RecordSize;
+ FpdtRecordPtr.GuidQwordEvent->Header.Revision = RECORD_REVISION_1;
+ FpdtRecordPtr.GuidQwordEvent->ProgressID = RecordInfo.ProgressID;
+ FpdtRecordPtr.GuidQwordEvent->Timestamp = TimeStamp;
+ CopyMem (&FpdtRecordPtr.GuidQwordEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordEvent->Guid));
+ if ((MODULE_LOADIMAGE_START_ID == RecordInfo.ProgressID) && AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) {
+ mLoadImageCount++;
+ FpdtRecordPtr.GuidQwordEvent->Qword = mLoadImageCount;
+ }
+ break;
+
+ case GUID_QWORD_STRING_EVENT_TYPE:
+ FpdtRecordPtr.GuidQwordStringEvent->Header.Type = GUID_QWORD_STRING_EVENT_TYPE;
+ FpdtRecordPtr.GuidQwordStringEvent->Header.Length = RecordInfo.RecordSize;
+ FpdtRecordPtr.GuidQwordStringEvent->Header.Revision = RECORD_REVISION_1;
+ FpdtRecordPtr.GuidQwordStringEvent->ProgressID = RecordInfo.ProgressID;
+ FpdtRecordPtr.GuidQwordStringEvent->Timestamp = TimeStamp;
+ CopyMem (&FpdtRecordPtr.GuidQwordStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordStringEvent->Guid));
+ break;
+
+ default:
+ //
+ // Record is not supported in current DXE phase, return EFI_ABORTED
+ //
+ return EFI_UNSUPPORTED;
+ }
+
+ //
+ // Report record one by one after records have been reported together.
+ //
+ if (mFpdtBufferIsReported) {
+ //
+ // Append Boot records to the boot performance table.
+ //
+ if (mBootRecordSize + FpdtRecordPtr.RecordHeader->Length > mBootRecordMaxSize) {
+ if (!mLackSpaceIsReported) {
+ DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: No enough space to save boot records\n"));
+ mLackSpaceIsReported = TRUE;
+ }
+ return EFI_OUT_OF_RESOURCES;
+ } else {
+ //
+ // Save boot record into BootPerformance table
+ //
+ CopyMem (mBootRecordBuffer + mBootRecordSize, FpdtRecordPtr.RecordHeader, FpdtRecordPtr.RecordHeader->Length);
+ mBootRecordSize += FpdtRecordPtr.RecordHeader->Length;
+ mAcpiBootPerformanceTable->Header.Length += FpdtRecordPtr.RecordHeader->Length;
+ }
+ } else {
+ //
+ // Update the cached FPDT record buffer.
+ //
+ mPerformanceLength += FpdtRecordPtr.RecordHeader->Length;
+ }
+
+ return EFI_SUCCESS;
+}
+
+/**
+ Dumps all the PEI performance.
+
+ @param HobStart A pointer to a Guid.
- mGaugeData = NewGaugeData;
- mMaxGaugeRecords *= 2;
+ This internal function dumps all the PEI performance log to the DXE performance gauge array.
+ It retrieves the optional GUID HOB for PEI performance and then saves the performance data
+ to DXE performance data structures.
+**/
+VOID
+InternalGetPeiPerformance (
+ VOID *HobStart
+ )
+{
+ UINT8 *FirmwarePerformanceHob;
+ PEI_EXT_FIRMWARE_PERF_HEADER *PeiPerformanceLogHeader;
+ UINT8 *EventRec;
+ EFI_HOB_GUID_TYPE *GuidHob;
+
+ GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, HobStart);
+ while (GuidHob != NULL) {
+ FirmwarePerformanceHob = GET_GUID_HOB_DATA (GuidHob);
+ PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *)FirmwarePerformanceHob;
+
+ if (mPerformanceLength + PeiPerformanceLogHeader->SizeOfAllEntries > mMaxPerformanceLength) {
+ mPerformancePointer = ReallocatePool (
+ mPerformanceLength,
+ mPerformanceLength +
+ (UINTN)PeiPerformanceLogHeader->SizeOfAllEntries +
+ FIRMWARE_RECORD_BUFFER,
+ mPerformancePointer
+ );
+ ASSERT (mPerformancePointer != NULL);
+ mMaxPerformanceLength = mPerformanceLength +
+ (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries) +
+ FIRMWARE_RECORD_BUFFER;
+ }
+
+ EventRec = mPerformancePointer + mPerformanceLength;
+ CopyMem (EventRec, FirmwarePerformanceHob + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER), (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries));
//
- // Initialize new data array and migrate old data one.
+ // Update the used buffer size.
//
- mGaugeData = CopyMem (mGaugeData, OldGaugeData, OldGaugeDataSize);
+ mPerformanceLength += (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries);
+ mLoadImageCount += PeiPerformanceLogHeader->LoadImageCount;
- FreePool (OldGaugeData);
+ //
+ // Get next performance guid hob
+ //
+ GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, GET_NEXT_HOB (GuidHob));
}
+}
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
- GaugeEntryExArray[Index].Handle = (EFI_PHYSICAL_ADDRESS) (UINTN) Handle;
+/**
+ Report Boot Perforamnce table address as report status code.
- if (Token != NULL) {
- AsciiStrnCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, Token, DXE_PERFORMANCE_STRING_LENGTH);
- }
- if (Module != NULL) {
- AsciiStrnCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, Module, DXE_PERFORMANCE_STRING_LENGTH);
+ @param Event The event of notify protocol.
+ @param Context Notify event context.
+
+**/
+VOID
+EFIAPI
+ReportFpdtRecordBuffer (
+ IN EFI_EVENT Event,
+ IN VOID *Context
+ )
+{
+ EFI_STATUS Status;
+ UINT64 BPDTAddr;
+
+ if (!mFpdtBufferIsReported) {
+ Status = AllocateBootPerformanceTable ();
+ if (!EFI_ERROR(Status)) {
+ BPDTAddr = (UINT64)(UINTN)mAcpiBootPerformanceTable;
+ REPORT_STATUS_CODE_EX (
+ EFI_PROGRESS_CODE,
+ EFI_SOFTWARE_DXE_BS_DRIVER,
+ 0,
+ NULL,
+ &gEfiFirmwarePerformanceGuid,
+ &BPDTAddr,
+ sizeof (UINT64)
+ );
+ }
+ //
+ // Free Cached FPDT record Buffer
+ //
+ if (mPerformancePointer != NULL) {
+ FreePool (mPerformancePointer);
+ mPerformancePointer = NULL;
+ }
+ mPerformanceLength = 0;
+ mMaxPerformanceLength = 0;
+ //
+ // Set FPDT report state to TRUE.
+ //
+ mFpdtBufferIsReported = TRUE;
}
+}
- GaugeEntryExArray[Index].EndTimeStamp = 0;
- GaugeEntryExArray[Index].Identifier = Identifier;
+/**
+ Adds a record at the end of the performance measurement log
+ that records the start time of a performance measurement.
- if (TimeStamp == 0) {
- TimeStamp = GetPerformanceCounter ();
- }
- GaugeEntryExArray[Index].StartTimeStamp = TimeStamp;
+ Adds a record to the end of the performance measurement log
+ that contains the Handle, Token, Module and Identifier.
+ The end time of the new record must be set to zero.
+ If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
+ If TimeStamp is zero, the start time in the record is filled in with the value
+ read from the current time stamp.
- mGaugeData->NumberOfEntries++;
+ @param Handle Pointer to environment specific context used
+ to identify the component being measured.
+ @param Token Pointer to a Null-terminated ASCII string
+ that identifies the component being measured.
+ @param Module Pointer to a Null-terminated ASCII string
+ that identifies the module being measured.
+ @param TimeStamp 64-bit time stamp.
+ @param Identifier 32-bit identifier. If the value is 0, the created record
+ is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
- EfiReleaseLock (&mPerfRecordLock);
+ @retval EFI_SUCCESS The data was read correctly from the device.
+ @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
- return EFI_SUCCESS;
+**/
+EFI_STATUS
+EFIAPI
+StartGaugeEx (
+ IN CONST VOID *Handle, OPTIONAL
+ IN CONST CHAR8 *Token, OPTIONAL
+ IN CONST CHAR8 *Module, OPTIONAL
+ IN UINT64 TimeStamp,
+ IN UINT32 Identifier
+ )
+{
+ return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
}
/**
Searches the performance measurement log from the beginning of the log
for the first matching record that contains a zero end time and fills in a valid end time.
Searches the performance measurement log from the beginning of the log
- for the first record that matches Handle, Token and Module and has an end time value of zero.
+ for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
If the record can not be found then return EFI_NOT_FOUND.
If the record is found and TimeStamp is not zero,
then the end time in the record is filled in with the value specified by TimeStamp.
If the record is found and TimeStamp is zero, then the end time in the matching record
is filled in with the current time stamp value.
@@ -260,89 +1188,19 @@ EndGaugeEx (
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp,
IN UINT32 Identifier
)
{
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
- UINT32 Index;
- EFI_STATUS Status;
-
- Status = EfiAcquireLockOrFail (&mPerfRecordLock);
- if (EFI_ERROR (Status)) {
- return Status;
- }
-
- if (TimeStamp == 0) {
- TimeStamp = GetPerformanceCounter ();
- }
-
- Index = InternalSearchForGaugeEntry (Handle, Token, Module, Identifier);
- if (Index >= mGaugeData->NumberOfEntries) {
- EfiReleaseLock (&mPerfRecordLock);
- return EFI_NOT_FOUND;
- }
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
- GaugeEntryExArray[Index].EndTimeStamp = TimeStamp;
-
- EfiReleaseLock (&mPerfRecordLock);
- return EFI_SUCCESS;
+ return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
}
/**
Retrieves a previously logged performance measurement.
It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
and then assign the Identifier with 0.
- Retrieves the performance log entry from the performance log specified by LogEntryKey.
- If it stands for a valid entry, then EFI_SUCCESS is returned and
- GaugeDataEntryEx stores the pointer to that entry.
-
- This internal function is added to avoid releasing lock before each return statement.
-
- @param LogEntryKey The key for the previous performance measurement log entry.
- If 0, then the first performance measurement log entry is retrieved.
- @param GaugeDataEntryEx The indirect pointer to the extended gauge data entry specified by LogEntryKey
- if the retrieval is successful.
-
- @retval EFI_SUCCESS The GuageDataEntryEx is successfully found based on LogEntryKey.
- @retval EFI_NOT_FOUND The LogEntryKey is the last entry (equals to the total entry number).
- @retval EFI_INVALIDE_PARAMETER The LogEntryKey is not a valid entry (greater than the total entry number).
- @retval EFI_INVALIDE_PARAMETER GaugeDataEntryEx is NULL.
-
-**/
-EFI_STATUS
-EFIAPI
-InternalGetGaugeEx (
- IN UINTN LogEntryKey,
- OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
- )
-{
- UINTN NumberOfEntries;
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
-
- NumberOfEntries = (UINTN) (mGaugeData->NumberOfEntries);
- if (LogEntryKey > NumberOfEntries) {
- return EFI_INVALID_PARAMETER;
- }
- if (LogEntryKey == NumberOfEntries) {
- return EFI_NOT_FOUND;
- }
-
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
-
- if (GaugeDataEntryEx == NULL) {
- return EFI_INVALID_PARAMETER;
- }
- *GaugeDataEntryEx = &GaugeEntryExArray[LogEntryKey];
-
- return EFI_SUCCESS;
-}
-
-/**
- Retrieves a previously logged performance measurement.
- It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
- and then assign the Identifier with 0.
+ !!! Not support!!!
Retrieves the performance log entry from the performance log specified by LogEntryKey.
If it stands for a valid entry, then EFI_SUCCESS is returned and
GaugeDataEntryEx stores the pointer to that entry.
@@ -362,22 +1220,11 @@ EFIAPI
GetGaugeEx (
IN UINTN LogEntryKey,
OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
)
{
- EFI_STATUS Status;
-
- Status = EfiAcquireLockOrFail (&mPerfRecordLock);
- if (EFI_ERROR (Status)) {
- return Status;
- }
-
- Status = InternalGetGaugeEx (LogEntryKey, GaugeDataEntryEx);
-
- EfiReleaseLock (&mPerfRecordLock);
-
- return Status;
+ return EFI_UNSUPPORTED;
}
/**
Adds a record at the end of the performance measurement log
that records the start time of a performance measurement.
@@ -452,10 +1299,12 @@ EndGauge (
/**
Retrieves a previously logged performance measurement.
It can also retrieve the log created by StartGaugeEx and EndGaugeEx of PERFORMANCE_EX_PROTOCOL,
and then eliminate the Identifier.
+ !!! Not support!!!
+
Retrieves the performance log entry from the performance log specified by LogEntryKey.
If it stands for a valid entry, then EFI_SUCCESS is returned and
GaugeDataEntry stores the pointer to that entry.
@param LogEntryKey The key for the previous performance measurement log entry.
@@ -474,81 +1323,13 @@ EFIAPI
GetGauge (
IN UINTN LogEntryKey,
OUT GAUGE_DATA_ENTRY **GaugeDataEntry
)
{
- EFI_STATUS Status;
- GAUGE_DATA_ENTRY_EX *GaugeEntryEx;
-
- GaugeEntryEx = NULL;
-
- Status = GetGaugeEx (LogEntryKey, &GaugeEntryEx);
- if (EFI_ERROR (Status)) {
- return Status;
- }
-
- if (GaugeDataEntry == NULL) {
- return EFI_INVALID_PARAMETER;
- }
-
- *GaugeDataEntry = (GAUGE_DATA_ENTRY *) GaugeEntryEx;
-
- return EFI_SUCCESS;
+ return EFI_UNSUPPORTED;
}
-/**
- Dumps all the PEI performance log to DXE performance gauge array.
-
- This internal function dumps all the PEI performance log to the DXE performance gauge array.
- It retrieves the optional GUID HOB for PEI performance and then saves the performance data
- to DXE performance data structures.
-
-**/
-VOID
-InternalGetPeiPerformance (
- VOID
- )
-{
- EFI_HOB_GUID_TYPE *GuidHob;
- PEI_PERFORMANCE_LOG_HEADER *LogHob;
- PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
- UINT32 *LogIdArray;
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
- UINT32 Index;
- UINT32 NumberOfEntries;
-
- NumberOfEntries = 0;
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
-
- //
- // Dump PEI Log Entries to DXE Guage Data structure.
- //
- GuidHob = GetFirstGuidHob (&gPerformanceProtocolGuid);
- if (GuidHob != NULL) {
- LogHob = GET_GUID_HOB_DATA (GuidHob);
- LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (LogHob + 1);
-
- NumberOfEntries = LogHob->NumberOfEntries;
- for (Index = 0; Index < NumberOfEntries; Index++) {
- GaugeEntryExArray[Index].Handle = LogEntryArray[Index].Handle;
- AsciiStrCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Token);
- AsciiStrCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Module);
- GaugeEntryExArray[Index].StartTimeStamp = LogEntryArray[Index].StartTimeStamp;
- GaugeEntryExArray[Index].EndTimeStamp = LogEntryArray[Index].EndTimeStamp;
- GaugeEntryExArray[Index].Identifier = 0;
- }
-
- GuidHob = GetFirstGuidHob (&gPerformanceExProtocolGuid);
- if (GuidHob != NULL) {
- LogIdArray = GET_GUID_HOB_DATA (GuidHob);
- for (Index = 0; Index < NumberOfEntries; Index++) {
- GaugeEntryExArray[Index].Identifier = LogIdArray[Index];
- }
- }
- }
- mGaugeData->NumberOfEntries = NumberOfEntries;
-}
/**
The constructor function initializes Performance infrastructure for DXE phase.
The constructor function publishes Performance and PerformanceEx protocol, allocates memory to log DXE performance
@@ -567,40 +1348,53 @@ DxeCorePerformanceLibConstructor (
IN EFI_HANDLE ImageHandle,
IN EFI_SYSTEM_TABLE *SystemTable
)
{
EFI_STATUS Status;
+ EFI_HANDLE Handle;
+ EFI_EVENT ReadyToBootEvent;
PERFORMANCE_PROPERTY *PerformanceProperty;
-
if (!PerformanceMeasurementEnabled ()) {
//
// Do not initialize performance infrastructure if not required.
//
return EFI_SUCCESS;
}
+
+ //
+ // Dump normal PEI performance records
+ //
+ InternalGetPeiPerformance (GetHobList());
+
//
- // Install the protocol interfaces.
+ // Install the protocol interfaces for DXE performance library instance.
//
+ Handle = NULL;
Status = gBS->InstallMultipleProtocolInterfaces (
- &mHandle,
+ &Handle,
&gPerformanceProtocolGuid,
&mPerformanceInterface,
&gPerformanceExProtocolGuid,
&mPerformanceExInterface,
NULL
);
ASSERT_EFI_ERROR (Status);
- mMaxGaugeRecords = INIT_DXE_GAUGE_DATA_ENTRIES + (UINT16) (PcdGet16 (PcdMaxPeiPerformanceLogEntries16) != 0 ?
- PcdGet16 (PcdMaxPeiPerformanceLogEntries16) :
- PcdGet8 (PcdMaxPeiPerformanceLogEntries));
-
- mGaugeData = AllocateZeroPool (sizeof (GAUGE_DATA_HEADER) + (sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords));
- ASSERT (mGaugeData != NULL);
+ //
+ // Register ReadyToBoot event to report StatusCode data
+ //
+ Status = gBS->CreateEventEx (
+ EVT_NOTIFY_SIGNAL,
+ TPL_CALLBACK,
+ ReportFpdtRecordBuffer,
+ NULL,
+ &gEfiEventReadyToBootGuid,
+ &ReadyToBootEvent
+ );
- InternalGetPeiPerformance ();
+ ASSERT_EFI_ERROR (Status);
Status = EfiGetSystemConfigurationTable (&gPerformanceProtocolGuid, (VOID **) &PerformanceProperty);
if (EFI_ERROR (Status)) {
//
// Install configuration table for performance property.
@@ -651,19 +1445,19 @@ StartPerformanceMeasurementEx (
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp,
IN UINT32 Identifier
)
{
- return (RETURN_STATUS) StartGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
+ return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
}
/**
Searches the performance measurement log from the beginning of the log
for the first matching record that contains a zero end time and fills in a valid end time.
Searches the performance measurement log from the beginning of the log
- for the first record that matches Handle, Token and Module and has an end time value of zero.
+ for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
If the record can not be found then return RETURN_NOT_FOUND.
If the record is found and TimeStamp is not zero,
then the end time in the record is filled in with the value specified by TimeStamp.
If the record is found and TimeStamp is zero, then the end time in the matching record
is filled in with the current time stamp value.
@@ -690,18 +1484,20 @@ EndPerformanceMeasurementEx (
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp,
IN UINT32 Identifier
)
{
- return (RETURN_STATUS) EndGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
+ return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
}
/**
Attempts to retrieve a performance measurement log entry from the performance measurement log.
It can also retrieve the log created by StartPerformanceMeasurement and EndPerformanceMeasurement,
and then assign the Identifier with 0.
+ !!! Not support!!!
+
Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
zero on entry, then an attempt is made to retrieve the first entry from the performance log,
and the key for the second entry in the log is returned. If the performance log is empty,
then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
@@ -729,63 +1525,29 @@ EndPerformanceMeasurementEx (
being measured.
@param StartTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
was started.
@param EndTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
was ended.
- @param Identifier Pointer to the 32-bit identifier that was recorded.
+ @param Identifier Pointer to the 32-bit identifier that was recorded when the measurement
+ was ended.
@return The key for the next performance log entry (in general case).
**/
UINTN
EFIAPI
GetPerformanceMeasurementEx (
- IN UINTN LogEntryKey,
+ IN UINTN LogEntryKey,
OUT CONST VOID **Handle,
OUT CONST CHAR8 **Token,
OUT CONST CHAR8 **Module,
OUT UINT64 *StartTimeStamp,
OUT UINT64 *EndTimeStamp,
OUT UINT32 *Identifier
)
{
- EFI_STATUS Status;
- GAUGE_DATA_ENTRY_EX *GaugeData;
-
- GaugeData = NULL;
-
- ASSERT (Handle != NULL);
- ASSERT (Token != NULL);
- ASSERT (Module != NULL);
- ASSERT (StartTimeStamp != NULL);
- ASSERT (EndTimeStamp != NULL);
- ASSERT (Identifier != NULL);
-
- Status = GetGaugeEx (LogEntryKey++, &GaugeData);
-
- //
- // Make sure that LogEntryKey is a valid log entry key,
- //
- ASSERT (Status != EFI_INVALID_PARAMETER);
-
- if (EFI_ERROR (Status)) {
- //
- // The LogEntryKey is the last entry (equals to the total entry number).
- //
- return 0;
- }
-
- ASSERT (GaugeData != NULL);
-
- *Handle = (VOID *) (UINTN) GaugeData->Handle;
- *Token = GaugeData->Token;
- *Module = GaugeData->Module;
- *StartTimeStamp = GaugeData->StartTimeStamp;
- *EndTimeStamp = GaugeData->EndTimeStamp;
- *Identifier = GaugeData->Identifier;
-
- return LogEntryKey;
+ return 0;
}
/**
Adds a record at the end of the performance measurement log
that records the start time of a performance measurement.
@@ -816,11 +1578,11 @@ StartPerformanceMeasurement (
IN CONST CHAR8 *Token, OPTIONAL
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp
)
{
- return StartPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
+ return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, 0);
}
/**
Searches the performance measurement log from the beginning of the log
for the first matching record that contains a zero end time and fills in a valid end time.
@@ -852,18 +1614,20 @@ EndPerformanceMeasurement (
IN CONST CHAR8 *Token, OPTIONAL
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp
)
{
- return EndPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
+ return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, 0);
}
/**
Attempts to retrieve a performance measurement log entry from the performance measurement log.
It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
and then eliminate the Identifier.
+ !!! Not support!!!
+
Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
zero on entry, then an attempt is made to retrieve the first entry from the performance log,
and the key for the second entry in the log is returned. If the performance log is empty,
then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
@@ -905,12 +1669,11 @@ GetPerformanceMeasurement (
OUT CONST CHAR8 **Module,
OUT UINT64 *StartTimeStamp,
OUT UINT64 *EndTimeStamp
)
{
- UINT32 Identifier;
- return GetPerformanceMeasurementEx (LogEntryKey, Handle, Token, Module, StartTimeStamp, EndTimeStamp, &Identifier);
+ return 0;
}
/**
Returns TRUE if the performance measurement macros are enabled.
diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
index 5b89ce2..71c181f 100644
--- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
+++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
@@ -7,11 +7,11 @@
# It initializes DXE phase performance logging by publishing the Performance and PerformanceEx Protocol,
# which is consumed by DxePerformanceLib to logging performance data in DXE phase.
# This library is mainly used by DxeCore to start performance logging to ensure that
# Performance and PerformanceEx Protocol are installed at the very beginning of DXE phase.
#
-# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
# (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
# http://opensource.org/licenses/bsd-license.php
@@ -48,27 +48,39 @@
[LibraryClasses]
MemoryAllocationLib
UefiBootServicesTableLib
+ UefiRuntimeServicesTableLib
PcdLib
TimerLib
BaseMemoryLib
BaseLib
HobLib
DebugLib
UefiLib
+ ReportStatusCodeLib
+ DxeServicesLib
+ PeCoffGetEntryPointLib
+
+[Protocols]
+ gEfiSmmCommunicationProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
## SOMETIMES_CONSUMES ## HOB
## PRODUCES ## UNDEFINED # Install protocol
## PRODUCES ## SystemTable
gPerformanceProtocolGuid
## SOMETIMES_CONSUMES ## HOB
## PRODUCES ## UNDEFINED # Install protocol
gPerformanceExProtocolGuid
+ gZeroGuid ## SOMETIMES_CONSUMES ## GUID
+ gEfiFirmwarePerformanceGuid ## SOMETIMES_PRODUCES ## UNDEFINED # StatusCode Data
+ gEdkiiExtendedFirmwarePerformanceGuid ## SOMETIMES_CONSUMES ## HOB # StatusCode Data
+ gEfiEventReadyToBootGuid ## CONSUMES ## Event
+ gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable
[Pcd]
- gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries ## CONSUMES
- gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16 ## CONSUMES
- gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
+ gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly ## CONSUMES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES
diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
index f1540d8..7e79675 100644
--- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
+++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
@@ -2,11 +2,11 @@
Master header files for DxeCorePerformanceLib instance.
This header file holds the prototypes of the Performance and PerformanceEx Protocol published by this
library instance at its constructor.
-Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -20,21 +20,36 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#include <PiDxe.h>
#include <Guid/Performance.h>
+#include <Guid/ExtendedFirmwarePerformance.h>
+#include <Guid/ZeroGuid.h>
+#include <Guid/EventGroup.h>
+#include <Guid/FirmwarePerformance.h>
+#include <Guid/PiSmmCommunicationRegionTable.h>
+
+#include <Protocol/DriverBinding.h>
+#include <Protocol/LoadedImage.h>
+#include <Protocol/ComponentName2.h>
+#include <Protocol/DevicePathToText.h>
+#include <Protocol/SmmCommunication.h>
#include <Library/PerformanceLib.h>
#include <Library/DebugLib.h>
#include <Library/HobLib.h>
#include <Library/BaseLib.h>
#include <Library/BaseMemoryLib.h>
#include <Library/TimerLib.h>
#include <Library/PcdLib.h>
#include <Library/UefiBootServicesTableLib.h>
+#include <Library/UefiRuntimeServicesTableLib.h>
#include <Library/MemoryAllocationLib.h>
#include <Library/UefiLib.h>
+#include <Library/ReportStatusCodeLib.h>
+#include <Library/DxeServicesLib.h>
+#include <Library/PeCoffGetEntryPointLib.h>
//
// Interface declarations for PerformanceEx Protocol.
//
/**
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 4/8] MdeModulePkg/SmmCorePerformanceLib:Track FPDT record in SMM phase
2018-01-30 13:53 [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table Dandan Bi
` (2 preceding siblings ...)
2018-01-30 13:53 ` [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase Dandan Bi
@ 2018-01-30 13:53 ` Dandan Bi
2018-01-30 13:53 ` [PATCH v2 5/8] MdeModulePkg/FirmwarePerformancePei:Add FPDT records for S3 phase Dandan Bi
` (4 subsequent siblings)
8 siblings, 0 replies; 21+ messages in thread
From: Dandan Bi @ 2018-01-30 13:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Star Zeng
V2:
Update SmmCorePerformanceLib to report the buffer address of
boot performance records instead of records contents.
Updated to convert Pref entry to FPDT record in SMM phase and then
export records to FPDT table.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../SmmCorePerformanceLib/SmmCorePerformanceLib.c | 1145 ++++++++++++--------
.../SmmCorePerformanceLib.inf | 10 +-
.../SmmCorePerformanceLibInternal.h | 11 +-
3 files changed, 724 insertions(+), 442 deletions(-)
diff --git a/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.c b/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.c
index cd1f1a5..815ed45 100644
--- a/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.c
+++ b/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.c
@@ -14,11 +14,11 @@
This external input must be validated carefully to avoid security issue like
buffer overflow, integer overflow.
SmmPerformanceHandlerEx(), SmmPerformanceHandler() will receive untrusted input and do basic validation.
-Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -28,30 +28,38 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
**/
#include "SmmCorePerformanceLibInternal.h"
-//
-// The data structure to hold global performance data.
-//
-GAUGE_DATA_HEADER *mGaugeData;
-
-//
-// The current maximum number of logging entries. If current number of
-// entries exceeds this value, it will re-allocate a larger array and
-// migration the old data to the larger array.
-//
-UINT32 mMaxGaugeRecords;
-
-//
-// The handle to install Performance Protocol instance.
-//
-EFI_HANDLE mHandle = NULL;
-
-BOOLEAN mPerformanceMeasurementEnabled;
-
-SPIN_LOCK mSmmPerfLock;
+#define STRING_SIZE (EDKII_STRING_EVENT_RECORD_NAME_LENGTH * sizeof (CHAR8))
+#define MAX_RECORD_SIZE (sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE)
+#define FIRMWARE_RECORD_BUFFER 0x1000
+#define EXTENSION_RECORD_SIZE 0x1000
+#define CACHE_HANDLE_GUID_COUNT 0x1000
+
+SMM_BOOT_PERFORMANCE_TABLE *mSmmBootPerformanceTable = NULL;
+
+typedef struct {
+ EFI_HANDLE Handle;
+ CHAR8 NameString[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
+ EFI_GUID ModuleGuid;
+} HANDLE_GUID_MAP;
+
+HANDLE_GUID_MAP mCacheHandleGuidTable[CACHE_HANDLE_GUID_COUNT];
+UINTN mCachePairCount = 0;
+
+UINT8 *mBootRecordBuffer = NULL;
+UINT32 mBootRecordSize = 0;
+UINT32 mBootRecordMaxSize = 0;
+UINT8 *mPerformancePointer = NULL;
+UINT32 mPerformanceLength = 0;
+UINT32 mMaxPerformanceLength = 0;
+BOOLEAN mFpdtDataIsReported = FALSE;
+BOOLEAN mLackSpaceIsReport = FALSE;
+CHAR8 *mPlatformLanguage = NULL;
+SPIN_LOCK mSmmFpdtLock;
+PERFORMANCE_PROPERTY mPerformanceProperty;
//
// Interfaces for SMM Performance Protocol.
//
PERFORMANCE_PROTOCOL mPerformanceInterface = {
@@ -67,172 +75,680 @@ PERFORMANCE_EX_PROTOCOL mPerformanceExInterface = {
StartGaugeEx,
EndGaugeEx,
GetGaugeEx
};
-PERFORMANCE_PROPERTY mPerformanceProperty;
+/**
+Check whether the Token is a known one which is uesed by core.
+
+@param Token Pointer to a Null-terminated ASCII string
+
+@retval TRUE Is a known one used by core.
+@retval FALSE Not a known one.
+
+**/
+BOOLEAN
+IsKnownTokens (
+ IN CONST CHAR8 *Token
+ )
+{
+ if (AsciiStrCmp (Token, SEC_TOK) == 0 ||
+ AsciiStrCmp (Token, PEI_TOK) == 0 ||
+ AsciiStrCmp (Token, DXE_TOK) == 0 ||
+ AsciiStrCmp (Token, BDS_TOK) == 0 ||
+ AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0 ||
+ AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0 ||
+ AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0 ||
+ AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0 ||
+ AsciiStrCmp (Token, START_IMAGE_TOK) == 0 ||
+ AsciiStrCmp (Token, PEIM_TOK) == 0) {
+ return TRUE;
+ } else {
+ return FALSE;
+ }
+}
/**
- Searches in the gauge array with keyword Handle, Token, Module and Identfier.
+Check whether the ID is a known one which map to the known Token.
+
+@param Identifier 32-bit identifier.
+
+@retval TRUE Is a known one used by core.
+@retval FALSE Not a known one.
- This internal function searches for the gauge entry in the gauge array.
- If there is an entry that exactly matches the given keywords
- and its end time stamp is zero, then the index of that gauge entry is returned;
- otherwise, the the number of gauge entries in the array is returned.
+**/
+BOOLEAN
+IsKnownID (
+ IN UINT32 Identifier
+ )
+{
+ if (Identifier == MODULE_START_ID ||
+ Identifier == MODULE_END_ID ||
+ Identifier == MODULE_LOADIMAGE_START_ID ||
+ Identifier == MODULE_LOADIMAGE_END_ID ||
+ Identifier == MODULE_DB_START_ID ||
+ Identifier == MODULE_DB_END_ID ||
+ Identifier == MODULE_DB_SUPPORT_START_ID ||
+ Identifier == MODULE_DB_SUPPORT_END_ID ||
+ Identifier == MODULE_DB_STOP_START_ID ||
+ Identifier == MODULE_DB_STOP_END_ID) {
+ return TRUE;
+ } else {
+ return FALSE;
+ }
+}
+/**
+ Get the FPDT record info.
+
+ @param IsStart TRUE if the performance log is start log.
@param Handle Pointer to environment specific context used
to identify the component being measured.
@param Token Pointer to a Null-terminated ASCII string
that identifies the component being measured.
@param Module Pointer to a Null-terminated ASCII string
that identifies the module being measured.
- @param Identifier 32-bit identifier.
+ @param RecordInfo On return, pointer to the info of the record.
+ @param UseModuleName Only useful for DYNAMIC_STRING_EVENT_TYPE, indicate that whether need use
+ Module name to fill the string field in the DYNAMIC_STRING_EVENT_RECORD.
- @retval The index of gauge entry in the array.
+ @retval EFI_SUCCESS Get record info successfully.
+ @retval EFI_UNSUPPORTED No matched FPDT record.
**/
-UINT32
-SmmSearchForGaugeEntry (
- IN CONST VOID *Handle, OPTIONAL
- IN CONST CHAR8 *Token, OPTIONAL
- IN CONST CHAR8 *Module, OPTIONAL
- IN CONST UINT32 Identifier
+EFI_STATUS
+GetFpdtRecordInfo (
+ IN BOOLEAN IsStart,
+ IN CONST VOID *Handle,
+ IN CONST CHAR8 *Token,
+ IN CONST CHAR8 *Module,
+ OUT BASIC_RECORD_INFO *RecordInfo,
+ IN OUT BOOLEAN *UseModuleName
)
{
- UINT32 Index;
- UINT32 Index2;
- UINT32 NumberOfEntries;
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
+ UINT16 RecordType;
+ UINTN StringSize;
- if (Token == NULL) {
- Token = "";
- }
- if (Module == NULL) {
- Module = "";
+ RecordType = DYNAMIC_STRING_EVENT_TYPE;
+
+ //
+ // Token to Type and Id.
+ //
+ if (Token != NULL) {
+ if (AsciiStrCmp (Token, START_IMAGE_TOK) == 0) { // "StartImage:"
+ *UseModuleName = TRUE;
+ RecordType = GUID_EVENT_TYPE;
+ if (IsStart) {
+ RecordInfo->ProgressID = MODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = MODULE_END_ID;
+ }
+ } else if (AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) { // "LoadImage:"
+ *UseModuleName = TRUE;
+ RecordType = GUID_QWORD_EVENT_TYPE;
+ if (IsStart) {
+ RecordInfo->ProgressID = MODULE_LOADIMAGE_START_ID;
+ } else {
+ RecordInfo->ProgressID = MODULE_LOADIMAGE_END_ID;
+ }
+ } else { // Pref used in Modules
+ if (IsStart) {
+ RecordInfo->ProgressID = PERF_INMODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = PERF_INMODULE_END_ID;
+ }
+ }
+ } else if (Handle != NULL || Module != NULL) { // Pref used in Modules
+ if (IsStart) {
+ RecordInfo->ProgressID = PERF_INMODULE_START_ID;
+ } else {
+ RecordInfo->ProgressID = PERF_INMODULE_END_ID;
+ }
+ } else {
+ return EFI_UNSUPPORTED;
}
- NumberOfEntries = mGaugeData->NumberOfEntries;
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
+ if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
+ RecordType = DYNAMIC_STRING_EVENT_TYPE;
+ RecordInfo->RecordSize = sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE;
+ } else {
+ switch (RecordType) {
+ case GUID_EVENT_TYPE:
+ RecordInfo->RecordSize = sizeof (GUID_EVENT_RECORD);
+ break;
- Index2 = 0;
+ case DYNAMIC_STRING_EVENT_TYPE:
+ if (*UseModuleName) {
+ StringSize = STRING_SIZE;
+ } else if (Token != NULL) {
+ StringSize = AsciiStrSize (Token);
+ } else if (Module != NULL) {
+ StringSize = AsciiStrSize (Module);
+ } else {
+ StringSize = STRING_SIZE;
+ }
+ if (StringSize > STRING_SIZE) {
+ StringSize = STRING_SIZE;
+ }
+ RecordInfo->RecordSize = (UINT8)(sizeof (DYNAMIC_STRING_EVENT_RECORD) + StringSize);
+ break;
- for (Index = 0; Index < NumberOfEntries; Index++) {
- Index2 = NumberOfEntries - 1 - Index;
- if (GaugeEntryExArray[Index2].EndTimeStamp == 0 &&
- (GaugeEntryExArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&
- AsciiStrnCmp (GaugeEntryExArray[Index2].Token, Token, SMM_PERFORMANCE_STRING_LENGTH) == 0 &&
- AsciiStrnCmp (GaugeEntryExArray[Index2].Module, Module, SMM_PERFORMANCE_STRING_LENGTH) == 0) {
- Index = Index2;
+ case GUID_QWORD_EVENT_TYPE:
+ RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_EVENT_RECORD);
break;
+
+ default:
+ //
+ // Record type is unsupported in SMM phase.
+ //
+ return EFI_UNSUPPORTED;
}
}
- return Index;
+ RecordInfo->Type = RecordType;
+ return EFI_SUCCESS;
}
/**
- Adds a record at the end of the performance measurement log
- that records the start time of a performance measurement.
+ Get a human readable module name and module guid for the given image handle.
+ If module name can't be found, "" string will return.
+ If module guid can't be found, Zero Guid will return.
+
+ @param Handle Image handle or Controller handle.
+ @param NameString The ascii string will be filled into it. If not found, null string will return.
+ @param BufferSize Size of the input NameString buffer.
+ @param ModuleGuid Point to the guid buffer to store the got module guid value.
+
+ @retval EFI_SUCCESS Successfully get module name and guid.
+ @retval EFI_INVALID_PARAMETER The input parameter NameString is NULL.
+ @retval other value Module Name can't be got.
+**/
+EFI_STATUS
+EFIAPI
+GetModuleInfoFromHandle (
+ IN EFI_HANDLE Handle,
+ OUT CHAR8 *NameString,
+ IN UINTN BufferSize,
+ OUT EFI_GUID *ModuleGuid OPTIONAL
+ )
+{
+ EFI_STATUS Status;
+ EFI_LOADED_IMAGE_PROTOCOL *LoadedImage;
+ EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
+ CHAR8 *PdbFileName;
+ EFI_GUID *TempGuid;
+ UINTN StartIndex;
+ UINTN Index;
+ INTN Count;
+ BOOLEAN ModuleGuidIsGet;
+ UINTN StringSize;
+ CHAR16 *StringPtr;
+ MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *FvFilePath;
+
+ if (NameString == NULL || BufferSize == 0) {
+ return EFI_INVALID_PARAMETER;
+ }
- Adds a record to the end of the performance measurement log
- that contains the Handle, Token, Module and Identifier.
- The end time of the new record must be set to zero.
- If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
- If TimeStamp is zero, the start time in the record is filled in with the value
- read from the current time stamp.
+ //
+ // Try to get the ModuleGuid and name string form the caached array.
+ //
+ if (mCachePairCount > 0) {
+ for (Count = mCachePairCount - 1; Count >= 0; Count--) {
+ if (Handle == mCacheHandleGuidTable[Count].Handle) {
+ CopyGuid (ModuleGuid, &mCacheHandleGuidTable[Count].ModuleGuid);
+ AsciiStrCpyS (NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, mCacheHandleGuidTable[Count].NameString);
+ return EFI_SUCCESS;
+ }
+ }
+ }
+
+ Status = EFI_INVALID_PARAMETER;
+ LoadedImage = NULL;
+ ModuleGuidIsGet = FALSE;
+
+ //
+ // Initialize GUID as zero value.
+ //
+ TempGuid = &gZeroGuid;
+ //
+ // Initialize it as "" string.
+ //
+ NameString[0] = 0;
+
+ if (Handle != NULL) {
+ //
+ // Try Handle as ImageHandle.
+ //
+ Status = gBS->HandleProtocol (
+ Handle,
+ &gEfiLoadedImageProtocolGuid,
+ (VOID**) &LoadedImage
+ );
+
+ if (EFI_ERROR (Status)) {
+ //
+ // Try Handle as Controller Handle
+ //
+ Status = gBS->OpenProtocol (
+ Handle,
+ &gEfiDriverBindingProtocolGuid,
+ (VOID **) &DriverBinding,
+ NULL,
+ NULL,
+ EFI_OPEN_PROTOCOL_GET_PROTOCOL
+ );
+ if (!EFI_ERROR (Status)) {
+ //
+ // Get Image protocol from ImageHandle
+ //
+ Status = gBS->HandleProtocol (
+ DriverBinding->ImageHandle,
+ &gEfiLoadedImageProtocolGuid,
+ (VOID**) &LoadedImage
+ );
+ }
+ }
+ }
+
+ if (!EFI_ERROR (Status) && LoadedImage != NULL) {
+ //
+ // Get Module Guid from DevicePath.
+ //
+ if (LoadedImage->FilePath != NULL &&
+ LoadedImage->FilePath->Type == MEDIA_DEVICE_PATH &&
+ LoadedImage->FilePath->SubType == MEDIA_PIWG_FW_FILE_DP
+ ) {
+ //
+ // Determine GUID associated with module logging performance
+ //
+ ModuleGuidIsGet = TRUE;
+ FvFilePath = (MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *) LoadedImage->FilePath;
+ TempGuid = &FvFilePath->FvFileName;
+ }
+
+ //
+ // Method 1 Get Module Name from PDB string.
+ //
+ PdbFileName = PeCoffLoaderGetPdbPointer (LoadedImage->ImageBase);
+ if (PdbFileName != NULL && BufferSize > 0) {
+ StartIndex = 0;
+ for (Index = 0; PdbFileName[Index] != 0; Index++) {
+ if ((PdbFileName[Index] == '\\') || (PdbFileName[Index] == '/')) {
+ StartIndex = Index + 1;
+ }
+ }
+ //
+ // Copy the PDB file name to our temporary string.
+ // If the length is bigger than BufferSize, trim the redudant characters to avoid overflow in array boundary.
+ //
+ for (Index = 0; Index < BufferSize - 1; Index++) {
+ NameString[Index] = PdbFileName[Index + StartIndex];
+ if (NameString[Index] == 0 || NameString[Index] == '.') {
+ NameString[Index] = 0;
+ break;
+ }
+ }
+
+ if (Index == BufferSize - 1) {
+ NameString[Index] = 0;
+ }
+ //
+ // Module Name is got.
+ //
+ goto Done;
+ }
+ }
+
+ if (ModuleGuidIsGet) {
+ //
+ // Method 2 Try to get the image's FFS UI section by image GUID
+ //
+ StringPtr = NULL;
+ StringSize = 0;
+ Status = GetSectionFromAnyFv (
+ TempGuid,
+ EFI_SECTION_USER_INTERFACE,
+ 0,
+ (VOID **) &StringPtr,
+ &StringSize
+ );
+
+ if (!EFI_ERROR (Status)) {
+ //
+ // Method 3. Get the name string from FFS UI section
+ //
+ for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
+ NameString[Index] = (CHAR8) StringPtr[Index];
+ }
+ NameString[Index] = 0;
+ FreePool (StringPtr);
+ }
+ }
+
+Done:
+ //
+ // Copy Module Guid
+ //
+ if (ModuleGuid != NULL) {
+ CopyGuid (ModuleGuid, TempGuid);
+ if (IsZeroGuid(TempGuid) && (Handle != NULL) && !ModuleGuidIsGet) {
+ // Handle is GUID
+ CopyGuid (ModuleGuid, (EFI_GUID *) Handle);
+ }
+ }
+
+ //
+ // Cache the Handle and Guid pairs.
+ //
+ if (mCachePairCount < CACHE_HANDLE_GUID_COUNT) {
+ mCacheHandleGuidTable[mCachePairCount].Handle = Handle;
+ CopyGuid (&mCacheHandleGuidTable[mCachePairCount].ModuleGuid, ModuleGuid);
+ AsciiStrCpyS (mCacheHandleGuidTable[mCachePairCount].NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, NameString);
+ mCachePairCount ++;
+ }
+ return Status;
+}
+
+/**
+ Add performance log to FPDT boot record table.
+
+ @param IsStart TRUE if the performance log is start log.
@param Handle Pointer to environment specific context used
to identify the component being measured.
@param Token Pointer to a Null-terminated ASCII string
that identifies the component being measured.
@param Module Pointer to a Null-terminated ASCII string
that identifies the module being measured.
- @param TimeStamp 64-bit time stamp.
+ @param Ticker 64-bit time stamp.
@param Identifier 32-bit identifier. If the value is 0, the created record
is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
- @retval EFI_SUCCESS The data was read correctly from the device.
+ @retval EFI_SUCCESS Add FPDT boot record.
@retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
+ @retval EFI_UNSUPPORTED No matched FPDT record.
**/
EFI_STATUS
-EFIAPI
-StartGaugeEx (
+InsertFpdtMeasurement (
+ IN BOOLEAN IsStart,
IN CONST VOID *Handle, OPTIONAL
IN CONST CHAR8 *Token, OPTIONAL
IN CONST CHAR8 *Module, OPTIONAL
- IN UINT64 TimeStamp,
+ IN UINT64 Ticker,
IN UINT32 Identifier
)
{
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
- UINTN GaugeDataSize;
- GAUGE_DATA_HEADER *NewGaugeData;
- UINTN OldGaugeDataSize;
- GAUGE_DATA_HEADER *OldGaugeData;
- UINT32 Index;
+ EFI_GUID ModuleGuid;
+ CHAR8 ModuleName[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
+ UINT8 FpdtRecord[MAX_RECORD_SIZE];
+ EFI_STATUS Status;
+ FPDT_RECORD_PTR FpdtRecordPtr;
+ UINT64 TimeStamp;
+ BASIC_RECORD_INFO RecordInfo;
+ UINTN DestMax;
+ UINTN StrLength;
+ CONST CHAR8 *StringPtr;
+ BOOLEAN UseModuleName;
+
+ StringPtr = NULL;
+ UseModuleName = FALSE;
+ ZeroMem (ModuleName, sizeof (ModuleName));
+ ZeroMem (FpdtRecord, sizeof (FpdtRecord));
+
+ //
+ // Get record info includes type, size, ProgressID.
+ //
+ Status = GetFpdtRecordInfo (IsStart, Handle, Token, Module, &RecordInfo, &UseModuleName);
+ if (EFI_ERROR (Status)) {
+ return Status;
+ }
- AcquireSpinLock (&mSmmPerfLock);
+ //
+ // If PERF_START()/PERF_END() have specified the ProgressID,it has high priority.
+ // !!! Note: If the Pref is not the known Token used in the core but have same
+ // ID with the core Token, this case will not be supported.
+ // And in currtnt usage mode, for the unkown ID, there is a general rule:
+ // If it is start pref: the lower 4 bits of the ID should be 0.
+ // If it is end pref: the lower 4 bits of the ID should not be 0.
+ // If input ID doesn't follow the rule, we will adjust it.
+ //
+ if ((Identifier != 0) && (IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
+ return EFI_UNSUPPORTED;
+ } else if ((Identifier != 0) && (!IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
+ if (IsStart && ((Identifier & 0x000F) != 0)) {
+ Identifier &= 0xFFF0;
+ } else if ((!IsStart) && ((Identifier & 0x000F) == 0)) {
+ Identifier += 1;
+ }
+ RecordInfo.ProgressID = (UINT16)Identifier;
+ }
- Index = mGaugeData->NumberOfEntries;
- if (Index >= mMaxGaugeRecords) {
+ if (mFpdtDataIsReported) {
//
- // Try to enlarge the scale of gauge array.
+ // Cached FPDT data has been reported. Now, report FPDT record one by one.
//
- OldGaugeData = mGaugeData;
- OldGaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords;
-
- GaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords * 2;
-
- NewGaugeData = AllocateZeroPool (GaugeDataSize);
- if (NewGaugeData == NULL) {
- ReleaseSpinLock (&mSmmPerfLock);
- return EFI_OUT_OF_RESOURCES;
+ FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)FpdtRecord;
+ } else {
+ //
+ // Check if pre-allocated buffer is full
+ //
+ if (mPerformanceLength + RecordInfo.RecordSize > mMaxPerformanceLength) {
+ mPerformancePointer = ReallocatePool (
+ mPerformanceLength,
+ mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER,
+ mPerformancePointer
+ );
+
+ if (mPerformancePointer == NULL) {
+ return EFI_OUT_OF_RESOURCES;
+ }
+ mMaxPerformanceLength = mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER;
}
-
- mGaugeData = NewGaugeData;
- mMaxGaugeRecords *= 2;
-
//
- // Initialize new data array and migrate old data one.
+ // Covert buffer to FPDT Ptr Union type.
//
- mGaugeData = CopyMem (mGaugeData, OldGaugeData, OldGaugeDataSize);
+ FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(mPerformancePointer + mPerformanceLength);
+ }
+ FpdtRecordPtr.RecordHeader->Length = 0;
- FreePool (OldGaugeData);
+ //
+ // Get the TimeStamp.
+ //
+ if (Ticker == 0) {
+ Ticker = GetPerformanceCounter ();
+ TimeStamp = GetTimeInNanoSecond (Ticker);
+ } else if (Ticker == 1) {
+ TimeStamp = 0;
+ } else {
+ TimeStamp = GetTimeInNanoSecond (Ticker);
}
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
- GaugeEntryExArray[Index].Handle = (EFI_PHYSICAL_ADDRESS) (UINTN) Handle;
+ //
+ // Get the ModuleName and ModuleGuid form the handle.
+ //
+ GetModuleInfoFromHandle ((EFI_HANDLE *)Handle, ModuleName, sizeof (ModuleName), &ModuleGuid);
- if (Token != NULL) {
- AsciiStrnCpyS (GaugeEntryExArray[Index].Token, SMM_PERFORMANCE_STRING_SIZE, Token, SMM_PERFORMANCE_STRING_LENGTH);
+ //
+ // Fill in the record information.
+ //
+ switch (RecordInfo.Type) {
+ case GUID_EVENT_TYPE:
+ FpdtRecordPtr.GuidEvent->Header.Type = GUID_EVENT_TYPE;
+ FpdtRecordPtr.GuidEvent->Header.Length = RecordInfo.RecordSize;
+ FpdtRecordPtr.GuidEvent->Header.Revision = RECORD_REVISION_1;
+ FpdtRecordPtr.GuidEvent->ProgressID = RecordInfo.ProgressID;
+ FpdtRecordPtr.GuidEvent->Timestamp = TimeStamp;
+ CopyMem (&FpdtRecordPtr.GuidEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidEvent->Guid));
+ break;
+
+ case DYNAMIC_STRING_EVENT_TYPE:
+ FpdtRecordPtr.DynamicStringEvent->Header.Type = DYNAMIC_STRING_EVENT_TYPE;
+ FpdtRecordPtr.DynamicStringEvent->Header.Length = RecordInfo.RecordSize;
+ FpdtRecordPtr.DynamicStringEvent->Header.Revision = RECORD_REVISION_1;
+ FpdtRecordPtr.DynamicStringEvent->ProgressID = RecordInfo.ProgressID;
+ FpdtRecordPtr.DynamicStringEvent->Timestamp = TimeStamp;
+ CopyMem (&FpdtRecordPtr.DynamicStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.DynamicStringEvent->Guid));
+
+ if (UseModuleName) {
+ StringPtr = ModuleName;
+ } else if (Token != NULL) {
+ StringPtr = Token;
+ } else if (Module != NULL) {
+ StringPtr = Module;
+ } else if (ModuleName != NULL) {
+ StringPtr = ModuleName;
+ }
+ if (StringPtr != NULL && AsciiStrLen (StringPtr) != 0) {
+ StrLength = AsciiStrLen (StringPtr);
+ DestMax = (RecordInfo.RecordSize - sizeof (DYNAMIC_STRING_EVENT_RECORD)) / sizeof (CHAR8);
+ if (StrLength >= DestMax) {
+ StrLength = DestMax -1;
+ }
+ AsciiStrnCpyS (FpdtRecordPtr.DynamicStringEvent->String, DestMax, StringPtr, StrLength);
+ }
+ break;
+
+ case GUID_QWORD_EVENT_TYPE:
+ FpdtRecordPtr.GuidQwordEvent->Header.Type = GUID_QWORD_EVENT_TYPE;
+ FpdtRecordPtr.GuidQwordEvent->Header.Length = RecordInfo.RecordSize;
+ FpdtRecordPtr.GuidQwordEvent->Header.Revision = RECORD_REVISION_1;
+ FpdtRecordPtr.GuidQwordEvent->ProgressID = RecordInfo.ProgressID;
+ FpdtRecordPtr.GuidQwordEvent->Timestamp = TimeStamp;
+ CopyMem (&FpdtRecordPtr.GuidQwordEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordEvent->Guid));
+ break;
+
+ default:
+ //
+ // Record is not supported in current SMM phase, return EFI_UNSUPPORTED
+ //
+ return EFI_UNSUPPORTED;
}
- if (Module != NULL) {
- AsciiStrnCpyS (GaugeEntryExArray[Index].Module, SMM_PERFORMANCE_STRING_SIZE, Module, SMM_PERFORMANCE_STRING_LENGTH);
+ //
+ // Report record one by one after records have been reported together.
+ //
+ if (mFpdtDataIsReported) {
+ //
+ // Append Boot records after Smm boot performance records have been reported.
+ //
+ if (mBootRecordSize + FpdtRecordPtr.RecordHeader->Length > mBootRecordMaxSize) {
+ //
+ // No enough space to save boot record.
+ //
+ if (!mLackSpaceIsReport) {
+ DEBUG ((DEBUG_INFO, "SmmCorePerformanceLib: No enough space to save boot records\n"));
+ mLackSpaceIsReport = TRUE;
+ }
+ return EFI_OUT_OF_RESOURCES;
+ } else {
+ //
+ // Save boot record into BootPerformance table
+ //
+ CopyMem (mBootRecordBuffer + mBootRecordSize, FpdtRecordPtr.RecordHeader, FpdtRecordPtr.RecordHeader->Length);
+ mBootRecordSize += FpdtRecordPtr.RecordHeader->Length;
+ mSmmBootPerformanceTable->Header.Length += FpdtRecordPtr.RecordHeader->Length;
+ }
+ } else {
+ //
+ // Update the cached FPDT record buffer.
+ //
+ mPerformanceLength += FpdtRecordPtr.RecordHeader->Length;
}
- GaugeEntryExArray[Index].EndTimeStamp = 0;
- GaugeEntryExArray[Index].Identifier = Identifier;
+ return EFI_SUCCESS;
+}
+
+/**
+ Allocate buffer for boot performance record in SMM phase.
+
+ @return Status code.
+
+**/
+EFI_STATUS
+AllocateSmmBootPerformanceTable (
+ )
+{
+ UINTN SmmBootPerformanceDataSize;
+ UINT8 *SmmBootPerformanceData;
+ //
+ // Prepare memory for SMM Boot Performance table.
+ // SMM Boot Performance table includes one or more appended Boot Records.
+ //
+ SmmBootPerformanceDataSize = sizeof (SMM_BOOT_PERFORMANCE_TABLE) + mPerformanceLength + EXTENSION_RECORD_SIZE;
- if (TimeStamp == 0) {
- TimeStamp = GetPerformanceCounter ();
+ mSmmBootPerformanceTable = AllocateZeroPool (SmmBootPerformanceDataSize);
+ if (mSmmBootPerformanceTable == NULL) {
+ return EFI_OUT_OF_RESOURCES;
}
- GaugeEntryExArray[Index].StartTimeStamp = TimeStamp;
+ SmmBootPerformanceData = (UINT8 *) mSmmBootPerformanceTable;
+
+ mSmmBootPerformanceTable->Header.Length = sizeof (SMM_BOOT_PERFORMANCE_TABLE);
+ SmmBootPerformanceData += sizeof (SMM_BOOT_PERFORMANCE_TABLE);
- mGaugeData->NumberOfEntries++;
+ CopyMem (SmmBootPerformanceData, mPerformancePointer, mPerformanceLength);
+ mSmmBootPerformanceTable->Header.Length += mPerformanceLength;
+ SmmBootPerformanceData = SmmBootPerformanceData + mPerformanceLength;
- ReleaseSpinLock (&mSmmPerfLock);
+ mBootRecordBuffer = (UINT8 *) mSmmBootPerformanceTable;
+ mBootRecordSize = mSmmBootPerformanceTable->Header.Length;
+ mBootRecordMaxSize = mBootRecordSize + EXTENSION_RECORD_SIZE;
return EFI_SUCCESS;
}
/**
+ Adds a record at the end of the performance measurement log
+ that records the start time of a performance measurement.
+
+ Adds a record to the end of the performance measurement log
+ that contains the Handle, Token, Module and Identifier.
+ The end time of the new record must be set to zero.
+ If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
+ If TimeStamp is zero, the start time in the record is filled in with the value
+ read from the current time stamp.
+
+ @param Handle Pointer to environment specific context used
+ to identify the component being measured.
+ @param Token Pointer to a Null-terminated ASCII string
+ that identifies the component being measured.
+ @param Module Pointer to a Null-terminated ASCII string
+ that identifies the module being measured.
+ @param TimeStamp 64-bit time stamp.
+ @param Identifier 32-bit identifier. If the value is 0, the created record
+ is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
+
+ @retval EFI_SUCCESS The data was read correctly from the device.
+ @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
+
+**/
+EFI_STATUS
+EFIAPI
+StartGaugeEx (
+ IN CONST VOID *Handle, OPTIONAL
+ IN CONST CHAR8 *Token, OPTIONAL
+ IN CONST CHAR8 *Module, OPTIONAL
+ IN UINT64 TimeStamp,
+ IN UINT32 Identifier
+ )
+{
+ EFI_STATUS Status;
+
+ AcquireSpinLock (&mSmmFpdtLock);
+
+ Status = InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
+
+ ReleaseSpinLock (&mSmmFpdtLock);
+
+ return Status;
+}
+
+/**
Searches the performance measurement log from the beginning of the log
for the first matching record that contains a zero end time and fills in a valid end time.
Searches the performance measurement log from the beginning of the log
- for the first record that matches Handle, Token and Module and has an end time value of zero.
+ for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
If the record can not be found then return EFI_NOT_FOUND.
If the record is found and TimeStamp is not zero,
then the end time in the record is filled in with the value specified by TimeStamp.
If the record is found and TimeStamp is zero, then the end time in the matching record
is filled in with the current time stamp value.
@@ -259,37 +775,28 @@ EndGaugeEx (
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp,
IN UINT32 Identifier
)
{
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
- UINT32 Index;
+ EFI_STATUS Status;
- AcquireSpinLock (&mSmmPerfLock);
+ AcquireSpinLock (&mSmmFpdtLock);
- if (TimeStamp == 0) {
- TimeStamp = GetPerformanceCounter ();
- }
-
- Index = SmmSearchForGaugeEntry (Handle, Token, Module, Identifier);
- if (Index >= mGaugeData->NumberOfEntries) {
- ReleaseSpinLock (&mSmmPerfLock);
- return EFI_NOT_FOUND;
- }
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
- GaugeEntryExArray[Index].EndTimeStamp = TimeStamp;
+ Status = InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
- ReleaseSpinLock (&mSmmPerfLock);
+ ReleaseSpinLock (&mSmmFpdtLock);
- return EFI_SUCCESS;
+ return Status;
}
/**
Retrieves a previously logged performance measurement.
It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
and then assign the Identifier with 0.
+ !!! Not Support!!!
+
Retrieves the performance log entry from the performance log specified by LogEntryKey.
If it stands for a valid entry, then EFI_SUCCESS is returned and
GaugeDataEntryEx stores the pointer to that entry.
@param LogEntryKey The key for the previous performance measurement log entry.
@@ -308,29 +815,11 @@ EFIAPI
GetGaugeEx (
IN UINTN LogEntryKey,
OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
)
{
- UINTN NumberOfEntries;
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
-
- NumberOfEntries = (UINTN) (mGaugeData->NumberOfEntries);
- if (LogEntryKey > NumberOfEntries) {
- return EFI_INVALID_PARAMETER;
- }
- if (LogEntryKey == NumberOfEntries) {
- return EFI_NOT_FOUND;
- }
-
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
-
- if (GaugeDataEntryEx == NULL) {
- return EFI_INVALID_PARAMETER;
- }
- *GaugeDataEntryEx = &GaugeEntryExArray[LogEntryKey];
-
- return EFI_SUCCESS;
+ return EFI_UNSUPPORTED;
}
/**
Adds a record at the end of the performance measurement log
that records the start time of a performance measurement.
@@ -405,10 +894,12 @@ EndGauge (
/**
Retrieves a previously logged performance measurement.
It can also retrieve the log created by StartGaugeEx and EndGaugeEx of PERFORMANCE_EX_PROTOCOL,
and then eliminate the Identifier.
+ !!! Not Support!!!
+
Retrieves the performance log entry from the performance log specified by LogEntryKey.
If it stands for a valid entry, then EFI_SUCCESS is returned and
GaugeDataEntry stores the pointer to that entry.
@param LogEntryKey The key for the previous performance measurement log entry.
@@ -427,256 +918,73 @@ EFIAPI
GetGauge (
IN UINTN LogEntryKey,
OUT GAUGE_DATA_ENTRY **GaugeDataEntry
)
{
- EFI_STATUS Status;
- GAUGE_DATA_ENTRY_EX *GaugeEntryEx;
-
- GaugeEntryEx = NULL;
-
- Status = GetGaugeEx (LogEntryKey, &GaugeEntryEx);
- if (EFI_ERROR (Status)) {
- return Status;
- }
-
- if (GaugeDataEntry == NULL) {
- return EFI_INVALID_PARAMETER;
- }
-
- *GaugeDataEntry = (GAUGE_DATA_ENTRY *) GaugeEntryEx;
-
- return EFI_SUCCESS;
+ return EFI_UNSUPPORTED;
}
-/**
- Communication service SMI Handler entry.
-
- This SMI handler provides services for the performance wrapper driver.
-
- Caution: This function may receive untrusted input.
- Communicate buffer and buffer size are external input, so this function will do basic validation.
-
- @param[in] DispatchHandle The unique handle assigned to this handler by SmiHandlerRegister().
- @param[in] RegisterContext Points to an optional handler context which was specified when the
- handler was registered.
- @param[in, out] CommBuffer A pointer to a collection of data in memory that will
- be conveyed from a non-SMM environment into an SMM environment.
- @param[in, out] CommBufferSize The size of the CommBuffer.
-
- @retval EFI_SUCCESS The interrupt was handled and quiesced. No other handlers
- should still be called.
- @retval EFI_WARN_INTERRUPT_SOURCE_QUIESCED The interrupt has been quiesced but other handlers should
- still be called.
- @retval EFI_WARN_INTERRUPT_SOURCE_PENDING The interrupt is still pending and other handlers should still
- be called.
- @retval EFI_INTERRUPT_PENDING The interrupt could not be quiesced.
-**/
-EFI_STATUS
-EFIAPI
-SmmPerformanceHandlerEx (
- IN EFI_HANDLE DispatchHandle,
- IN CONST VOID *RegisterContext,
- IN OUT VOID *CommBuffer,
- IN OUT UINTN *CommBufferSize
- )
-{
- EFI_STATUS Status;
- SMM_PERF_COMMUNICATE_EX *SmmPerfCommData;
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
- UINT64 DataSize;
- UINTN Index;
- GAUGE_DATA_ENTRY_EX *GaugeDataEx;
- UINTN NumberOfEntries;
- UINTN LogEntryKey;
- UINTN TempCommBufferSize;
-
- GaugeEntryExArray = NULL;
-
- //
- // If input is invalid, stop processing this SMI
- //
- if (CommBuffer == NULL || CommBufferSize == NULL) {
- return EFI_SUCCESS;
- }
-
- TempCommBufferSize = *CommBufferSize;
-
- if(TempCommBufferSize < sizeof (SMM_PERF_COMMUNICATE_EX)) {
- return EFI_SUCCESS;
- }
-
- if (!SmmIsBufferOutsideSmmValid ((UINTN)CommBuffer, TempCommBufferSize)) {
- DEBUG ((EFI_D_ERROR, "SmmPerformanceHandlerEx: SMM communcation data buffer in SMRAM or overflow!\n"));
- return EFI_SUCCESS;
- }
-
- SmmPerfCommData = (SMM_PERF_COMMUNICATE_EX *)CommBuffer;
-
- switch (SmmPerfCommData->Function) {
- case SMM_PERF_FUNCTION_GET_GAUGE_ENTRY_NUMBER :
- SmmPerfCommData->NumberOfEntries = mGaugeData->NumberOfEntries;
- Status = EFI_SUCCESS;
- break;
-
- case SMM_PERF_FUNCTION_GET_GAUGE_DATA :
- GaugeDataEx = SmmPerfCommData->GaugeDataEx;
- NumberOfEntries = SmmPerfCommData->NumberOfEntries;
- LogEntryKey = SmmPerfCommData->LogEntryKey;
- if (GaugeDataEx == NULL || NumberOfEntries == 0 || LogEntryKey > mGaugeData->NumberOfEntries ||
- NumberOfEntries > mGaugeData->NumberOfEntries || LogEntryKey > (mGaugeData->NumberOfEntries - NumberOfEntries)) {
- Status = EFI_INVALID_PARAMETER;
- break;
- }
-
- //
- // Sanity check
- //
- DataSize = MultU64x32 (NumberOfEntries, sizeof(GAUGE_DATA_ENTRY_EX));
- if (!SmmIsBufferOutsideSmmValid ((UINTN) GaugeDataEx, DataSize)) {
- DEBUG ((EFI_D_ERROR, "SmmPerformanceHandlerEx: SMM Performance Data buffer in SMRAM or overflow!\n"));
- Status = EFI_ACCESS_DENIED;
- break;
- }
-
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
-
- for (Index = 0; Index < NumberOfEntries; Index++) {
- CopyMem (
- (UINT8 *) &GaugeDataEx[Index],
- (UINT8 *) &GaugeEntryExArray[LogEntryKey++],
- sizeof (GAUGE_DATA_ENTRY_EX)
- );
- }
- Status = EFI_SUCCESS;
- break;
- default:
- Status = EFI_UNSUPPORTED;
- }
+/**
+ SmmReadyToBoot protocol notification event handler.
+ @param Protocol Points to the protocol's unique identifier
+ @param Interface Points to the interface instance
+ @param Handle The handle on which the interface was installed
- SmmPerfCommData->ReturnStatus = Status;
-
- return EFI_SUCCESS;
-}
+ @retval EFI_SUCCESS SmmReadyToBootCallback runs successfully
-/**
- Communication service SMI Handler entry.
-
- This SMI handler provides services for the performance wrapper driver.
-
- Caution: This function may receive untrusted input.
- Communicate buffer and buffer size are external input, so this function will do basic validation.
-
- @param[in] DispatchHandle The unique handle assigned to this handler by SmiHandlerRegister().
- @param[in] RegisterContext Points to an optional handler context which was specified when the
- handler was registered.
- @param[in, out] CommBuffer A pointer to a collection of data in memory that will
- be conveyed from a non-SMM environment into an SMM environment.
- @param[in, out] CommBufferSize The size of the CommBuffer.
-
- @retval EFI_SUCCESS The interrupt was handled and quiesced. No other handlers
- should still be called.
- @retval EFI_WARN_INTERRUPT_SOURCE_QUIESCED The interrupt has been quiesced but other handlers should
- still be called.
- @retval EFI_WARN_INTERRUPT_SOURCE_PENDING The interrupt is still pending and other handlers should still
- be called.
- @retval EFI_INTERRUPT_PENDING The interrupt could not be quiesced.
**/
EFI_STATUS
EFIAPI
-SmmPerformanceHandler (
- IN EFI_HANDLE DispatchHandle,
- IN CONST VOID *RegisterContext,
- IN OUT VOID *CommBuffer,
- IN OUT UINTN *CommBufferSize
+SmmReportFpdtRecordData (
+ IN CONST EFI_GUID *Protocol,
+ IN VOID *Interface,
+ IN EFI_HANDLE Handle
)
{
- EFI_STATUS Status;
- SMM_PERF_COMMUNICATE *SmmPerfCommData;
- GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
- UINT64 DataSize;
- UINTN Index;
- GAUGE_DATA_ENTRY *GaugeData;
- UINTN NumberOfEntries;
- UINTN LogEntryKey;
- UINTN TempCommBufferSize;
-
- GaugeEntryExArray = NULL;
-
- //
- // If input is invalid, stop processing this SMI
- //
- if (CommBuffer == NULL || CommBufferSize == NULL) {
- return EFI_SUCCESS;
- }
-
- TempCommBufferSize = *CommBufferSize;
-
- if(TempCommBufferSize < sizeof (SMM_PERF_COMMUNICATE)) {
- return EFI_SUCCESS;
- }
-
- if (!SmmIsBufferOutsideSmmValid ((UINTN)CommBuffer, TempCommBufferSize)) {
- DEBUG ((EFI_D_ERROR, "SmmPerformanceHandler: SMM communcation data buffer in SMRAM or overflow!\n"));
- return EFI_SUCCESS;
- }
-
- SmmPerfCommData = (SMM_PERF_COMMUNICATE *)CommBuffer;
-
- switch (SmmPerfCommData->Function) {
- case SMM_PERF_FUNCTION_GET_GAUGE_ENTRY_NUMBER :
- SmmPerfCommData->NumberOfEntries = mGaugeData->NumberOfEntries;
- Status = EFI_SUCCESS;
- break;
-
- case SMM_PERF_FUNCTION_GET_GAUGE_DATA :
- GaugeData = SmmPerfCommData->GaugeData;
- NumberOfEntries = SmmPerfCommData->NumberOfEntries;
- LogEntryKey = SmmPerfCommData->LogEntryKey;
- if (GaugeData == NULL || NumberOfEntries == 0 || LogEntryKey > mGaugeData->NumberOfEntries ||
- NumberOfEntries > mGaugeData->NumberOfEntries || LogEntryKey > (mGaugeData->NumberOfEntries - NumberOfEntries)) {
- Status = EFI_INVALID_PARAMETER;
- break;
- }
-
- //
- // Sanity check
- //
- DataSize = MultU64x32 (NumberOfEntries, sizeof(GAUGE_DATA_ENTRY));
- if (!SmmIsBufferOutsideSmmValid ((UINTN) GaugeData, DataSize)) {
- DEBUG ((EFI_D_ERROR, "SmmPerformanceHandler: SMM Performance Data buffer in SMRAM or overflow!\n"));
- Status = EFI_ACCESS_DENIED;
- break;
- }
-
- GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
-
- for (Index = 0; Index < NumberOfEntries; Index++) {
- CopyMem (
- (UINT8 *) &GaugeData[Index],
- (UINT8 *) &GaugeEntryExArray[LogEntryKey++],
- sizeof (GAUGE_DATA_ENTRY)
- );
- }
- Status = EFI_SUCCESS;
- break;
+ EFI_STATUS Status;
+ UINT64 SmmBootPerfTableAddr;
+
+ Status = EFI_SUCCESS;
+
+ if (!mFpdtDataIsReported) {
+ Status = AllocateSmmBootPerformanceTable (&SmmBootPerfTableAddr);
+ if (!EFI_ERROR(Status)) {
+ SmmBootPerfTableAddr = (UINT64)(UINTN)mSmmBootPerformanceTable;
+
+ REPORT_STATUS_CODE_EX (
+ EFI_PROGRESS_CODE,
+ EFI_SOFTWARE_SMM_DRIVER,
+ 0,
+ NULL,
+ &gEfiFirmwarePerformanceGuid,
+ &SmmBootPerfTableAddr,
+ sizeof (UINT64)
+ );
+ }
+ //
+ // Free Cached FPDT record Buffer
+ //
+ if (mPerformancePointer != NULL) {
+ FreePool (mPerformancePointer);
+ mPerformancePointer = NULL;
+ }
- default:
- Status = EFI_UNSUPPORTED;
+ mPerformanceLength = 0;
+ mMaxPerformanceLength = 0;
+ //
+ // Set FPDT report state to TRUE.
+ //
+ mFpdtDataIsReported = TRUE;
}
-
-
- SmmPerfCommData->ReturnStatus = Status;
-
- return EFI_SUCCESS;
+ return Status;
}
/**
- SmmBase2 protocol notify callback function, when SMST and SMM memory service get initialized
- this function is callbacked to initialize the Smm Performance Lib
+ SmmBase2 protocol notify callback function, when SMST and SMM memory service get initialized
+ this function is callbacked to initialize the Smm Performance Lib
@param Event The event of notify protocol.
@param Context Notify event context.
**/
@@ -685,52 +993,44 @@ EFIAPI
InitializeSmmCorePerformanceLib (
IN EFI_EVENT Event,
IN VOID *Context
)
{
- EFI_STATUS Status;
EFI_HANDLE Handle;
+ EFI_STATUS Status;
+ VOID *SmmReadyToBootRegistration;
PERFORMANCE_PROPERTY *PerformanceProperty;
//
// Initialize spin lock
//
- InitializeSpinLock (&mSmmPerfLock);
-
- mMaxGaugeRecords = INIT_SMM_GAUGE_DATA_ENTRIES;
+ InitializeSpinLock (&mSmmFpdtLock);
- mGaugeData = AllocateZeroPool (sizeof (GAUGE_DATA_HEADER) + (sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords));
- ASSERT (mGaugeData != NULL);
-
//
- // Install the protocol interfaces.
+ // Install the protocol interfaces for SMM performance library instance.
//
+ Handle = NULL;
Status = gSmst->SmmInstallProtocolInterface (
- &mHandle,
+ &Handle,
&gSmmPerformanceProtocolGuid,
EFI_NATIVE_INTERFACE,
&mPerformanceInterface
);
ASSERT_EFI_ERROR (Status);
-
Status = gSmst->SmmInstallProtocolInterface (
- &mHandle,
+ &Handle,
&gSmmPerformanceExProtocolGuid,
EFI_NATIVE_INTERFACE,
&mPerformanceExInterface
);
ASSERT_EFI_ERROR (Status);
- ///
- /// Register SMM Performance SMI handler
- ///
- Handle = NULL;
- Status = gSmst->SmiHandlerRegister (SmmPerformanceHandler, &gSmmPerformanceProtocolGuid, &Handle);
- ASSERT_EFI_ERROR (Status);
- Status = gSmst->SmiHandlerRegister (SmmPerformanceHandlerEx, &gSmmPerformanceExProtocolGuid, &Handle);
- ASSERT_EFI_ERROR (Status);
-
+ Status = gSmst->SmmRegisterProtocolNotify (
+ &gEdkiiSmmReadyToBootProtocolGuid,
+ SmmReportFpdtRecordData,
+ &SmmReadyToBootRegistration
+ );
Status = EfiGetSystemConfigurationTable (&gPerformanceProtocolGuid, (VOID **) &PerformanceProperty);
if (EFI_ERROR (Status)) {
//
// Install configuration table for performance property.
//
@@ -744,11 +1044,11 @@ InitializeSmmCorePerformanceLib (
ASSERT_EFI_ERROR (Status);
}
}
/**
- The constructor function initializes the Performance Measurement Enable flag and
+ The constructor function initializes the Performance Measurement Enable flag and
registers SmmBase2 protocol notify callback.
It will ASSERT() if one of these operations fails and it will always return EFI_SUCCESS.
@param ImageHandle The firmware allocated handle for the EFI image.
@param SystemTable A pointer to the EFI System Table.
@@ -765,12 +1065,11 @@ SmmCorePerformanceLibConstructor (
{
EFI_STATUS Status;
EFI_EVENT Event;
VOID *Registration;
- mPerformanceMeasurementEnabled = (BOOLEAN) ((PcdGet8(PcdPerformanceLibraryPropertyMask) & PERFORMANCE_LIBRARY_PROPERTY_MEASUREMENT_ENABLED) != 0);
- if (!mPerformanceMeasurementEnabled) {
+ if (!PerformanceMeasurementEnabled ()) {
//
// Do not initialize performance infrastructure if not required.
//
return EFI_SUCCESS;
}
@@ -842,11 +1141,11 @@ StartPerformanceMeasurementEx (
/**
Searches the performance measurement log from the beginning of the log
for the first matching record that contains a zero end time and fills in a valid end time.
Searches the performance measurement log from the beginning of the log
- for the first record that matches Handle, Token and Module and has an end time value of zero.
+ for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
If the record can not be found then return RETURN_NOT_FOUND.
If the record is found and TimeStamp is not zero,
then the end time in the record is filled in with the value specified by TimeStamp.
If the record is found and TimeStamp is zero, then the end time in the matching record
is filled in with the current time stamp value.
@@ -881,10 +1180,12 @@ EndPerformanceMeasurementEx (
/**
Attempts to retrieve a performance measurement log entry from the performance measurement log.
It can also retrieve the log created by StartPerformanceMeasurement and EndPerformanceMeasurement,
and then assign the Identifier with 0.
+ !!! Not Support!!!
+
Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
zero on entry, then an attempt is made to retrieve the first entry from the performance log,
and the key for the second entry in the log is returned. If the performance log is empty,
then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
@@ -920,55 +1221,20 @@ EndPerformanceMeasurementEx (
**/
UINTN
EFIAPI
GetPerformanceMeasurementEx (
- IN UINTN LogEntryKey,
+ IN UINTN LogEntryKey,
OUT CONST VOID **Handle,
OUT CONST CHAR8 **Token,
OUT CONST CHAR8 **Module,
OUT UINT64 *StartTimeStamp,
OUT UINT64 *EndTimeStamp,
OUT UINT32 *Identifier
)
{
- EFI_STATUS Status;
- GAUGE_DATA_ENTRY_EX *GaugeData;
-
- GaugeData = NULL;
-
- ASSERT (Handle != NULL);
- ASSERT (Token != NULL);
- ASSERT (Module != NULL);
- ASSERT (StartTimeStamp != NULL);
- ASSERT (EndTimeStamp != NULL);
- ASSERT (Identifier != NULL);
-
- Status = GetGaugeEx (LogEntryKey++, &GaugeData);
-
- //
- // Make sure that LogEntryKey is a valid log entry key,
- //
- ASSERT (Status != EFI_INVALID_PARAMETER);
-
- if (EFI_ERROR (Status)) {
- //
- // The LogEntryKey is the last entry (equals to the total entry number).
- //
- return 0;
- }
-
- ASSERT (GaugeData != NULL);
-
- *Handle = (VOID *) (UINTN) GaugeData->Handle;
- *Token = GaugeData->Token;
- *Module = GaugeData->Module;
- *StartTimeStamp = GaugeData->StartTimeStamp;
- *EndTimeStamp = GaugeData->EndTimeStamp;
- *Identifier = GaugeData->Identifier;
-
- return LogEntryKey;
+ return 0;
}
/**
Adds a record at the end of the performance measurement log
that records the start time of a performance measurement.
@@ -999,11 +1265,11 @@ StartPerformanceMeasurement (
IN CONST CHAR8 *Token, OPTIONAL
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp
)
{
- return StartPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
+ return StartGaugeEx (Handle, Token, Module, TimeStamp, 0);
}
/**
Searches the performance measurement log from the beginning of the log
for the first matching record that contains a zero end time and fills in a valid end time.
@@ -1035,18 +1301,20 @@ EndPerformanceMeasurement (
IN CONST CHAR8 *Token, OPTIONAL
IN CONST CHAR8 *Module, OPTIONAL
IN UINT64 TimeStamp
)
{
- return EndPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
+ return EndGaugeEx (Handle, Token, Module, TimeStamp, 0);
}
/**
Attempts to retrieve a performance measurement log entry from the performance measurement log.
It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
and then eliminate the Identifier.
+ !!! Not Support!!!
+
Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
zero on entry, then an attempt is made to retrieve the first entry from the performance log,
and the key for the second entry in the log is returned. If the performance log is empty,
then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
@@ -1088,12 +1356,11 @@ GetPerformanceMeasurement (
OUT CONST CHAR8 **Module,
OUT UINT64 *StartTimeStamp,
OUT UINT64 *EndTimeStamp
)
{
- UINT32 Identifier;
- return GetPerformanceMeasurementEx (LogEntryKey, Handle, Token, Module, StartTimeStamp, EndTimeStamp, &Identifier);
+ return 0;
}
/**
Returns TRUE if the performance measurement macros are enabled.
@@ -1110,7 +1377,7 @@ BOOLEAN
EFIAPI
PerformanceMeasurementEnabled (
VOID
)
{
- return mPerformanceMeasurementEnabled;
+ return (BOOLEAN) ((PcdGet8(PcdPerformanceLibraryPropertyMask) & PERFORMANCE_LIBRARY_PROPERTY_MEASUREMENT_ENABLED) != 0);
}
diff --git a/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.inf b/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.inf
index 1b2fbd3..1d1841c 100644
--- a/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.inf
+++ b/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.inf
@@ -6,11 +6,11 @@
# It initializes SMM phase performance logging by publishing the SMM Performance and PerformanceEx Protocol,
# which is consumed by SmmPerformanceLib to logging performance data in SMM phase.
# This library is mainly used by SMM Core to start performance logging to ensure that
# SMM Performance and PerformanceEx Protocol are installed at the very beginning of SMM phase.
#
-# Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
# http://opensource.org/licenses/bsd-license.php
#
@@ -56,21 +56,27 @@
DebugLib
SynchronizationLib
SmmServicesTableLib
SmmMemLib
UefiLib
+ ReportStatusCodeLib
+ PeCoffGetEntryPointLib
[Protocols]
gEfiSmmBase2ProtocolGuid ## CONSUMES
+ gEdkiiSmmReadyToBootProtocolGuid ## NOTIFY
[Guids]
## PRODUCES ## UNDEFINED # Install protocol
## CONSUMES ## UNDEFINED # SmiHandlerRegister
gSmmPerformanceProtocolGuid
## PRODUCES ## UNDEFINED # Install protocol
## CONSUMES ## UNDEFINED # SmiHandlerRegister
gSmmPerformanceExProtocolGuid
## PRODUCES ## SystemTable
gPerformanceProtocolGuid
+ gEfiFirmwarePerformanceGuid ## SOMETIMES_PRODUCES ## UNDEFINED # StatusCode Data
+ gZeroGuid ## SOMETIMES_CONSUMES ## GUID
[Pcd]
- gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
+ gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly ## CONSUMES
diff --git a/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLibInternal.h b/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLibInternal.h
index 8eb3032..9d24d9f 100644
--- a/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLibInternal.h
+++ b/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLibInternal.h
@@ -2,11 +2,11 @@
Master header files for SmmCorePerformanceLib instance.
This header file holds the prototypes of the SMM Performance and PerformanceEx Protocol published by this
library instance at its constructor.
-Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -18,10 +18,14 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#ifndef _SMM_CORE_PERFORMANCE_LIB_INTERNAL_H_
#define _SMM_CORE_PERFORMANCE_LIB_INTERNAL_H_
#include <Guid/Performance.h>
+#include <Guid/ExtendedFirmwarePerformance.h>
+#include <Guid/FirmwarePerformance.h>
+#include <Guid/ZeroGuid.h>
+#include <Guid/EventGroup.h>
#include <Library/SmmServicesTableLib.h>
#include <Library/DebugLib.h>
#include <Library/PerformanceLib.h>
#include <Library/BaseLib.h>
@@ -31,12 +35,17 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#include <Library/UefiLib.h>
#include <Library/UefiBootServicesTableLib.h>
#include <Library/MemoryAllocationLib.h>
#include <Library/SynchronizationLib.h>
#include <Library/SmmMemLib.h>
+#include <Library/ReportStatusCodeLib.h>
+#include <Library/DxeServicesLib.h>
+#include <Library/PeCoffGetEntryPointLib.h>
#include <Protocol/SmmBase2.h>
+#include <Protocol/LoadedImage.h>
+#include <Protocol/DevicePathToText.h>
//
// Interface declarations for SMM PerformanceEx Protocol.
//
/**
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 5/8] MdeModulePkg/FirmwarePerformancePei:Add FPDT records for S3 phase
2018-01-30 13:53 [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table Dandan Bi
` (3 preceding siblings ...)
2018-01-30 13:53 ` [PATCH v2 4/8] MdeModulePkg/SmmCorePerformanceLib:Track FPDT record in SMM phase Dandan Bi
@ 2018-01-30 13:53 ` Dandan Bi
2018-01-30 13:53 ` [PATCH v2 6/8] MdeModulePkg/FirmwarePerfDxe:Enhance for new pref infrastructure Dandan Bi
` (3 subsequent siblings)
8 siblings, 0 replies; 21+ messages in thread
From: Dandan Bi @ 2018-01-30 13:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Star Zeng
Add FPDT records into boot performance table for S3 phase
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../FirmwarePerformancePei.c | 59 +++++++++++++++++++++-
.../FirmwarePerformancePei.inf | 5 +-
2 files changed, 62 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.c b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.c
index e4800b7..e81f96c 100644
--- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.c
+++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.c
@@ -3,11 +3,11 @@
Data Table in S3 resume boot mode.
This module register report status code listener to collect performance data
for S3 Resume Performance Record on S3 resume boot path.
- Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -17,20 +17,24 @@
**/
#include <PiPei.h>
#include <Ppi/ReportStatusCodeHandler.h>
+#include <Ppi/ReadOnlyVariable2.h>
#include <Guid/FirmwarePerformance.h>
+#include <Guid/Performance.h>
+#include <Guid/ExtendedFirmwarePerformance.h>
#include <Library/PeiServicesLib.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
#include <Library/TimerLib.h>
#include <Library/BaseMemoryLib.h>
#include <Library/LockBoxLib.h>
#include <Library/PcdLib.h>
+#include <Library/HobLib.h>
/**
Report status code listener for PEI. This is used to record the performance
data for S3 FullResume in FPDT.
@@ -68,10 +72,17 @@ FpdtStatusCodeListenerPei (
S3_PERFORMANCE_TABLE *AcpiS3PerformanceTable;
EFI_ACPI_5_0_FPDT_S3_RESUME_RECORD *AcpiS3ResumeRecord;
UINT64 S3ResumeTotal;
EFI_ACPI_5_0_FPDT_S3_SUSPEND_RECORD S3SuspendRecord;
EFI_ACPI_5_0_FPDT_S3_SUSPEND_RECORD *AcpiS3SuspendRecord;
+ EFI_PEI_READ_ONLY_VARIABLE2_PPI *VariableServices;
+ UINT8 *BootPerformanceTable;
+ FIRMWARE_PERFORMANCE_VARIABLE PerformanceVariable;
+ EFI_HOB_GUID_TYPE *GuidHob;
+ PEI_EXT_FIRMWARE_PERF_HEADER *PeiPerformanceLogHeader;
+ UINT8 *FirmwarePerformanceData;
+ UINT8 *FirmwarePerformanceTablePtr;
//
// Check whether status code is what we are interested in.
//
if (((CodeType & EFI_STATUS_CODE_TYPE_MASK) != EFI_PROGRESS_CODE) ||
@@ -128,10 +139,56 @@ FpdtStatusCodeListenerPei (
AcpiS3SuspendRecord->SuspendEnd = S3SuspendRecord.SuspendEnd;
DEBUG ((EFI_D_INFO, "FPDT: S3 Suspend Performance - SuspendStart = %ld\n", AcpiS3SuspendRecord->SuspendStart));
DEBUG ((EFI_D_INFO, "FPDT: S3 Suspend Performance - SuspendEnd = %ld\n", AcpiS3SuspendRecord->SuspendEnd));
+ Status = PeiServicesLocatePpi (
+ &gEfiPeiReadOnlyVariable2PpiGuid,
+ 0,
+ NULL,
+ (VOID **) &VariableServices
+ );
+ ASSERT_EFI_ERROR (Status);
+
+ //
+ // Update S3 boot records into the basic boot performance table.
+ //
+ VarSize = sizeof (PerformanceVariable);
+ Status = VariableServices->GetVariable (
+ VariableServices,
+ EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
+ &gEfiFirmwarePerformanceGuid,
+ NULL,
+ &VarSize,
+ &PerformanceVariable
+ );
+ if (EFI_ERROR (Status)) {
+ return Status;
+ }
+ BootPerformanceTable = (UINT8*) (UINTN) PerformanceVariable.BootPerformanceTablePointer;
+
+ //
+ // Dump PEI boot records
+ //
+ FirmwarePerformanceTablePtr = (BootPerformanceTable + sizeof (BOOT_PERFORMANCE_TABLE));
+ GuidHob = GetFirstGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid);
+ while (GuidHob != NULL) {
+ FirmwarePerformanceData = GET_GUID_HOB_DATA (GuidHob);
+ PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *) FirmwarePerformanceData;
+
+ CopyMem (FirmwarePerformanceTablePtr, FirmwarePerformanceData + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER), (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries));
+
+ GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, GET_NEXT_HOB (GuidHob));
+
+ FirmwarePerformanceTablePtr += (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries);
+ }
+
+ //
+ // Update Table length.
+ //
+ ((BOOT_PERFORMANCE_TABLE *) BootPerformanceTable)->Header.Length = (UINT32)((UINTN)FirmwarePerformanceTablePtr - (UINTN)BootPerformanceTable);
+
return EFI_SUCCESS;
}
/**
Main entry for Firmware Performance Data Table PEIM.
diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.inf b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.inf
index 53b45a2..703caf4 100644
--- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.inf
+++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.inf
@@ -4,11 +4,11 @@
# In S3 resume boot mode, it updates S3 Resume Performance Record in ACPI Firmware Performance Data Table.
#
# This module register report status code listener to collect performance data
# for S3 Resume Performance Record on S3 resume boot path.
#
-# Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
# http://opensource.org/licenses/bsd-license.php
#
@@ -46,18 +46,21 @@
DebugLib
TimerLib
BaseMemoryLib
LockBoxLib
PcdLib
+ HobLib
[Ppis]
gEfiPeiRscHandlerPpiGuid ## CONSUMES
+ gEfiPeiReadOnlyVariable2PpiGuid ## CONSUMES
[Guids]
## SOMETIMES_CONSUMES ## UNDEFINED # RestoreLockBox
gEfiFirmwarePerformanceGuid
gFirmwarePerformanceS3PointerGuid ## SOMETIMES_CONSUMES ## UNDEFINED # RestoreLockBox
+ gEdkiiExtendedFirmwarePerformanceGuid ## SOMETIMES_CONSUMES ## HOB
[FeaturePcd]
gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwarePerformanceDataTableS3Support ## CONSUMES
[Depex]
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 6/8] MdeModulePkg/FirmwarePerfDxe:Enhance for new pref infrastructure
2018-01-30 13:53 [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table Dandan Bi
` (4 preceding siblings ...)
2018-01-30 13:53 ` [PATCH v2 5/8] MdeModulePkg/FirmwarePerformancePei:Add FPDT records for S3 phase Dandan Bi
@ 2018-01-30 13:53 ` Dandan Bi
2018-01-30 13:53 ` [PATCH v2 7/8] MdeModulePkg/FirmwarePerfSmm:Enhance " Dandan Bi
` (2 subsequent siblings)
8 siblings, 0 replies; 21+ messages in thread
From: Dandan Bi @ 2018-01-30 13:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Star Zeng
V2:
Update FirmwarePerformanceDxe to receive the address
of performance records instead of records content.
1. Remove the macro EXTENSION_RECORD_SIZE, since the extension
size can be got through PcdExtFpdtBootRecordPadSize.
2. Hook EFI_SW_DXE_BS_PC_READY_TO_BOOT_EVENT to install ACPI table
3. Copy SMM record accord to the allocated size
4. Receive Boot performance table address instead of
contents which are reported DxeCorePerformanceLib.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../FirmwarePerformanceDxe.c | 271 ++-------------------
.../FirmwarePerformanceDxe.inf | 4 +-
2 files changed, 18 insertions(+), 257 deletions(-)
diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c
index b004cac..da1db9b 100644
--- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c
+++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c
@@ -3,11 +3,11 @@
This module register report status code listener to collect performance data
for Firmware Basic Boot Performance Record and other boot performance records,
and install FPDT to ACPI table.
- Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -18,19 +18,17 @@
#include <PiDxe.h>
#include <Protocol/ReportStatusCodeHandler.h>
#include <Protocol/AcpiTable.h>
-#include <Protocol/SmmCommunication.h>
#include <Protocol/LockBox.h>
#include <Protocol/Variable.h>
#include <Guid/Acpi.h>
#include <Guid/FirmwarePerformance.h>
#include <Guid/EventGroup.h>
#include <Guid/EventLegacyBios.h>
-#include <Guid/PiSmmCommunicationRegionTable.h>
#include <Library/UefiBootServicesTableLib.h>
#include <Library/UefiRuntimeServicesTableLib.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
@@ -40,26 +38,23 @@
#include <Library/PcdLib.h>
#include <Library/HobLib.h>
#include <Library/LockBoxLib.h>
#include <Library/UefiLib.h>
-#define EXTENSION_RECORD_SIZE 0x10000
-#define SMM_BOOT_RECORD_COMM_SIZE OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + sizeof(SMM_BOOT_RECORD_COMMUNICATE)
+#define SMM_BOOT_RECORD_COMM_SIZE (OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + sizeof(SMM_BOOT_RECORD_COMMUNICATE))
EFI_RSC_HANDLER_PROTOCOL *mRscHandlerProtocol = NULL;
BOOLEAN mLockBoxReady = FALSE;
EFI_EVENT mReadyToBootEvent;
EFI_EVENT mLegacyBootEvent;
EFI_EVENT mExitBootServicesEvent;
UINTN mFirmwarePerformanceTableTemplateKey = 0;
-UINT32 mBootRecordSize = 0;
-UINT32 mBootRecordMaxSize = 0;
-UINT8 *mBootRecordBuffer = NULL;
BOOLEAN mDxeCoreReportStatusCodeEnable = FALSE;
BOOT_PERFORMANCE_TABLE *mAcpiBootPerformanceTable = NULL;
+BOOT_PERFORMANCE_TABLE *mReceivedAcpiBootPerformanceTable = NULL;
S3_PERFORMANCE_TABLE *mAcpiS3PerformanceTable = NULL;
FIRMWARE_PERFORMANCE_TABLE mFirmwarePerformanceTableTemplate = {
{
EFI_ACPI_5_0_FIRMWARE_PERFORMANCE_DATA_TABLE_SIGNATURE,
@@ -327,186 +322,23 @@ InstallFirmwarePerformanceDataTable (
VOID
)
{
EFI_STATUS Status;
EFI_ACPI_TABLE_PROTOCOL *AcpiTableProtocol;
- UINTN Size;
- UINT8 *SmmBootRecordCommBuffer;
- EFI_SMM_COMMUNICATE_HEADER *SmmCommBufferHeader;
- SMM_BOOT_RECORD_COMMUNICATE *SmmCommData;
- UINTN CommSize;
UINTN BootPerformanceDataSize;
- UINT8 *BootPerformanceData;
- EFI_SMM_COMMUNICATION_PROTOCOL *Communication;
FIRMWARE_PERFORMANCE_VARIABLE PerformanceVariable;
- EDKII_PI_SMM_COMMUNICATION_REGION_TABLE *SmmCommRegionTable;
- EFI_MEMORY_DESCRIPTOR *SmmCommMemRegion;
- UINTN Index;
- VOID *SmmBootRecordData;
- UINTN SmmBootRecordDataSize;
- UINTN ReservedMemSize;
//
// Get AcpiTable Protocol.
//
Status = gBS->LocateProtocol (&gEfiAcpiTableProtocolGuid, NULL, (VOID **) &AcpiTableProtocol);
if (EFI_ERROR (Status)) {
return Status;
}
- //
- // Collect boot records from SMM drivers.
- //
- SmmBootRecordCommBuffer = NULL;
- SmmCommData = NULL;
- SmmBootRecordData = NULL;
- SmmBootRecordDataSize = 0;
- ReservedMemSize = 0;
- Status = gBS->LocateProtocol (&gEfiSmmCommunicationProtocolGuid, NULL, (VOID **) &Communication);
- if (!EFI_ERROR (Status)) {
- //
- // Initialize communicate buffer
- // Get the prepared Reserved Memory Range
- //
- Status = EfiGetSystemConfigurationTable (
- &gEdkiiPiSmmCommunicationRegionTableGuid,
- (VOID **) &SmmCommRegionTable
- );
- if (!EFI_ERROR (Status)) {
- ASSERT (SmmCommRegionTable != NULL);
- SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) (SmmCommRegionTable + 1);
- for (Index = 0; Index < SmmCommRegionTable->NumberOfEntries; Index ++) {
- if (SmmCommMemRegion->Type == EfiConventionalMemory) {
- break;
- }
- SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) ((UINT8 *) SmmCommMemRegion + SmmCommRegionTable->DescriptorSize);
- }
- ASSERT (Index < SmmCommRegionTable->NumberOfEntries);
- ASSERT (SmmCommMemRegion->PhysicalStart > 0);
- ASSERT (SmmCommMemRegion->NumberOfPages > 0);
- ReservedMemSize = (UINTN) SmmCommMemRegion->NumberOfPages * EFI_PAGE_SIZE;
-
- //
- // Check enough reserved memory space
- //
- if (ReservedMemSize > SMM_BOOT_RECORD_COMM_SIZE) {
- SmmBootRecordCommBuffer = (VOID *) (UINTN) SmmCommMemRegion->PhysicalStart;
- SmmCommBufferHeader = (EFI_SMM_COMMUNICATE_HEADER*)SmmBootRecordCommBuffer;
- SmmCommData = (SMM_BOOT_RECORD_COMMUNICATE*)SmmCommBufferHeader->Data;
- ZeroMem((UINT8*)SmmCommData, sizeof(SMM_BOOT_RECORD_COMMUNICATE));
-
- CopyGuid (&SmmCommBufferHeader->HeaderGuid, &gEfiFirmwarePerformanceGuid);
- SmmCommBufferHeader->MessageLength = sizeof(SMM_BOOT_RECORD_COMMUNICATE);
- CommSize = SMM_BOOT_RECORD_COMM_SIZE;
-
- //
- // Get the size of boot records.
- //
- SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_SIZE;
- SmmCommData->BootRecordData = NULL;
- Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
- ASSERT_EFI_ERROR (Status);
-
- if (!EFI_ERROR (SmmCommData->ReturnStatus) && SmmCommData->BootRecordSize != 0) {
- //
- // Get all boot records
- //
- SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
- SmmBootRecordDataSize = SmmCommData->BootRecordSize;
- SmmBootRecordData = AllocateZeroPool(SmmBootRecordDataSize);
- ASSERT (SmmBootRecordData != NULL);
- SmmCommData->BootRecordOffset = 0;
- SmmCommData->BootRecordData = (VOID *) ((UINTN) SmmCommMemRegion->PhysicalStart + SMM_BOOT_RECORD_COMM_SIZE);
- SmmCommData->BootRecordSize = ReservedMemSize - SMM_BOOT_RECORD_COMM_SIZE;
- while (SmmCommData->BootRecordOffset < SmmBootRecordDataSize) {
- Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
- ASSERT_EFI_ERROR (Status);
- ASSERT_EFI_ERROR(SmmCommData->ReturnStatus);
- CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmCommData->BootRecordSize);
- SmmCommData->BootRecordOffset = SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize;
- }
- }
- }
- }
- }
-
- //
- // Prepare memory for Boot Performance table.
- // Boot Performance table includes BasicBoot record, and one or more appended Boot Records.
- //
- BootPerformanceDataSize = sizeof (BOOT_PERFORMANCE_TABLE) + mBootRecordSize + PcdGet32 (PcdExtFpdtBootRecordPadSize);
- if (SmmCommData != NULL) {
- BootPerformanceDataSize += SmmBootRecordDataSize;
- }
-
- //
- // Try to allocate the same runtime buffer as last time boot.
- //
- ZeroMem (&PerformanceVariable, sizeof (PerformanceVariable));
- Size = sizeof (PerformanceVariable);
- Status = gRT->GetVariable (
- EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
- &gEfiFirmwarePerformanceGuid,
- NULL,
- &Size,
- &PerformanceVariable
- );
- if (!EFI_ERROR (Status)) {
- Status = gBS->AllocatePages (
- AllocateAddress,
- EfiReservedMemoryType,
- EFI_SIZE_TO_PAGES (BootPerformanceDataSize),
- &PerformanceVariable.BootPerformanceTablePointer
- );
- if (!EFI_ERROR (Status)) {
- mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) (UINTN) PerformanceVariable.BootPerformanceTablePointer;
- }
- }
-
- if (mAcpiBootPerformanceTable == NULL) {
- //
- // Fail to allocate at specified address, continue to allocate at any address.
- //
- mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) FpdtAllocateReservedMemoryBelow4G (BootPerformanceDataSize);
- }
- DEBUG ((EFI_D_INFO, "FPDT: ACPI Boot Performance Table address = 0x%x\n", mAcpiBootPerformanceTable));
-
- if (mAcpiBootPerformanceTable == NULL) {
- if (SmmCommData != NULL && SmmBootRecordData != NULL) {
- FreePool (SmmBootRecordData);
- }
- if (mAcpiS3PerformanceTable != NULL) {
- FreePages (mAcpiS3PerformanceTable, EFI_SIZE_TO_PAGES (sizeof (S3_PERFORMANCE_TABLE)));
- mAcpiS3PerformanceTable = NULL;
- }
- return EFI_OUT_OF_RESOURCES;
- }
-
- //
- // Prepare Boot Performance Table.
- //
- BootPerformanceData = (UINT8 *) mAcpiBootPerformanceTable;
- //
- // Fill Basic Boot record to Boot Performance Table.
- //
- CopyMem (mAcpiBootPerformanceTable, &mBootPerformanceTableTemplate, sizeof (mBootPerformanceTableTemplate));
- BootPerformanceData = BootPerformanceData + mAcpiBootPerformanceTable->Header.Length;
- //
- // Fill Boot records from boot drivers.
- //
- CopyMem (BootPerformanceData, mBootRecordBuffer, mBootRecordSize);
- mAcpiBootPerformanceTable->Header.Length += mBootRecordSize;
- BootPerformanceData = BootPerformanceData + mBootRecordSize;
- if (SmmCommData != NULL && SmmBootRecordData != NULL) {
- //
- // Fill Boot records from SMM drivers.
- //
- CopyMem (BootPerformanceData, SmmBootRecordData, SmmBootRecordDataSize);
- FreePool (SmmBootRecordData);
- mAcpiBootPerformanceTable->Header.Length = (UINT32) (mAcpiBootPerformanceTable->Header.Length + SmmBootRecordDataSize);
- BootPerformanceData = BootPerformanceData + SmmBootRecordDataSize;
- }
+ mAcpiBootPerformanceTable = mReceivedAcpiBootPerformanceTable;
+ BootPerformanceDataSize = mAcpiBootPerformanceTable->Header.Length;
//
// Save Boot Performance Table address to Variable for use in S4 resume.
//
PerformanceVariable.BootPerformanceTablePointer = (EFI_PHYSICAL_ADDRESS) (UINTN) mAcpiBootPerformanceTable;
@@ -523,11 +355,11 @@ InstallFirmwarePerformanceDataTable (
// Update S3 Performance Table Pointer in template.
//
mFirmwarePerformanceTableTemplate.S3PointerRecord.S3PerformanceTablePointer = (UINT64) (UINTN) mAcpiS3PerformanceTable;
//
// Save Runtime Performance Table pointers to Variable.
- // Don't check SetVariable return status. It doesn't impact FPDT table generation.
+ // Don't check SetVariable return status. It doesn't impact FPDT table generation.
//
gRT->SetVariable (
EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
&gEfiFirmwarePerformanceGuid,
EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
@@ -544,56 +376,24 @@ InstallFirmwarePerformanceDataTable (
&mFirmwarePerformanceTableTemplate,
mFirmwarePerformanceTableTemplate.Header.Length,
&mFirmwarePerformanceTableTemplateKey
);
if (EFI_ERROR (Status)) {
- FreePages (mAcpiBootPerformanceTable, EFI_SIZE_TO_PAGES (BootPerformanceDataSize));
+ if (mAcpiBootPerformanceTable != NULL) {
+ FreePages (mAcpiBootPerformanceTable, EFI_SIZE_TO_PAGES (BootPerformanceDataSize));
+ }
if (mAcpiS3PerformanceTable != NULL) {
FreePages (mAcpiS3PerformanceTable, EFI_SIZE_TO_PAGES (sizeof (S3_PERFORMANCE_TABLE)));
}
mAcpiBootPerformanceTable = NULL;
mAcpiS3PerformanceTable = NULL;
return Status;
}
-
- //
- // Free temp Boot record, and update Boot Record to point to Basic Boot performance table.
- //
- if (mBootRecordBuffer != NULL) {
- FreePool (mBootRecordBuffer);
- }
- mBootRecordBuffer = (UINT8 *) mAcpiBootPerformanceTable;
- mBootRecordSize = mAcpiBootPerformanceTable->Header.Length;
- mBootRecordMaxSize = mBootRecordSize + PcdGet32 (PcdExtFpdtBootRecordPadSize);
-
return EFI_SUCCESS;
}
/**
- Notify function for event group EFI_EVENT_GROUP_READY_TO_BOOT. This is used to
- install the Firmware Performance Data Table.
-
- @param[in] Event The Event that is being processed.
- @param[in] Context The Event Context.
-
-**/
-VOID
-EFIAPI
-FpdtReadyToBootEventNotify (
- IN EFI_EVENT Event,
- IN VOID *Context
- )
-{
- if (mAcpiBootPerformanceTable == NULL) {
- //
- // ACPI Firmware Performance Data Table not installed yet, install it now.
- //
- InstallFirmwarePerformanceDataTable ();
- }
-}
-
-/**
Report status code listener of FPDT. This is used to collect performance data
for OsLoaderLoadImageStart and OsLoaderStartImageStart in FPDT.
@param[in] CodeType Indicates the type of status code being reported.
@param[in] Value Describes the current status of a hardware or software entity.
@@ -697,46 +497,22 @@ FpdtStatusCodeListenerDxe (
DEBUG ((EFI_D_INFO, "FPDT: Boot Performance - ResetEnd = %ld\n", mAcpiBootPerformanceTable->BasicBoot.ResetEnd));
DEBUG ((EFI_D_INFO, "FPDT: Boot Performance - OsLoaderLoadImageStart = 0\n"));
DEBUG ((EFI_D_INFO, "FPDT: Boot Performance - OsLoaderStartImageStart = %ld\n", mAcpiBootPerformanceTable->BasicBoot.OsLoaderStartImageStart));
DEBUG ((EFI_D_INFO, "FPDT: Boot Performance - ExitBootServicesEntry = 0\n"));
DEBUG ((EFI_D_INFO, "FPDT: Boot Performance - ExitBootServicesExit = 0\n"));
- } else if (Data != NULL && CompareGuid (&Data->Type, &gEfiFirmwarePerformanceGuid)) {
- //
- // Append one or more Boot records
- //
+ } else if (Value == (EFI_SOFTWARE_DXE_BS_DRIVER | EFI_SW_DXE_BS_PC_READY_TO_BOOT_EVENT)) {
if (mAcpiBootPerformanceTable == NULL) {
//
- // Append Boot records before FPDT ACPI table is installed.
- //
- if (mBootRecordSize + Data->Size > mBootRecordMaxSize) {
- mBootRecordBuffer = ReallocatePool (mBootRecordSize, mBootRecordSize + Data->Size + EXTENSION_RECORD_SIZE, mBootRecordBuffer);
- ASSERT (mBootRecordBuffer != NULL);
- mBootRecordMaxSize = mBootRecordSize + Data->Size + EXTENSION_RECORD_SIZE;
- }
- //
- // Save boot record into the temp memory space.
- //
- CopyMem (mBootRecordBuffer + mBootRecordSize, Data + 1, Data->Size);
- mBootRecordSize += Data->Size;
- } else {
+ // ACPI Firmware Performance Data Table not installed yet, install it now.
//
- // Append Boot records after FPDT ACPI table is installed.
- //
- if (mBootRecordSize + Data->Size > mBootRecordMaxSize) {
- //
- // No enough space to save boot record.
- //
- Status = EFI_OUT_OF_RESOURCES;
- } else {
- //
- // Save boot record into BootPerformance table
- //
- CopyMem (mBootRecordBuffer + mBootRecordSize, Data + 1, Data->Size);
- mBootRecordSize += Data->Size;
- mAcpiBootPerformanceTable->Header.Length = mBootRecordSize;
- }
+ InstallFirmwarePerformanceDataTable ();
}
+ } else if (Data != NULL && CompareGuid (&Data->Type, &gEfiFirmwarePerformanceGuid)) {
+ //
+ // Get the Boot performance table and then install it to ACPI table.
+ //
+ CopyMem (&mReceivedAcpiBootPerformanceTable, Data + 1, Data->Size);
} else {
//
// Ignore else progress code.
//
Status = EFI_UNSUPPORTED;
@@ -851,23 +627,10 @@ FirmwarePerformanceDxeEntryPoint (
&mExitBootServicesEvent
);
ASSERT_EFI_ERROR (Status);
//
- // Create ready to boot event to install ACPI FPDT table.
- //
- Status = gBS->CreateEventEx (
- EVT_NOTIFY_SIGNAL,
- TPL_NOTIFY,
- FpdtReadyToBootEventNotify,
- NULL,
- &gEfiEventReadyToBootGuid,
- &mReadyToBootEvent
- );
- ASSERT_EFI_ERROR (Status);
-
- //
// Retrieve GUID HOB data that contains the ResetEnd.
//
GuidHob = GetFirstGuidHob (&gEfiFirmwarePerformanceGuid);
if (GuidHob != NULL) {
Performance = (FIRMWARE_SEC_PERFORMANCE *) GET_GUID_HOB_DATA (GuidHob);
diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf
index 49d8420..d65e04e 100644
--- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf
+++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf
@@ -3,11 +3,11 @@
#
# This module registers report status code listener to collect performance data
# for Firmware Basic Boot Performance Record and other boot performance records,
# and install FPDT to ACPI table.
#
-# Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
# http://opensource.org/licenses/bsd-license.php
#
@@ -53,11 +53,10 @@
UefiLib
[Protocols]
gEfiAcpiTableProtocolGuid ## CONSUMES
gEfiRscHandlerProtocolGuid ## CONSUMES
- gEfiSmmCommunicationProtocolGuid ## SOMETIMES_CONSUMES
gEfiVariableArchProtocolGuid ## CONSUMES
gEfiLockBoxProtocolGuid ## CONSUMES
[Guids]
gEfiEventExitBootServicesGuid ## CONSUMES ## Event
@@ -68,11 +67,10 @@
## PRODUCES ## Variable:L"FirmwarePerformance"
## SOMETIMES_CONSUMES ## UNDEFINED # Used to do smm communication
## SOMETIMES_CONSUMES ## UNDEFINED # StatusCode Data
gEfiFirmwarePerformanceGuid
gFirmwarePerformanceS3PointerGuid ## PRODUCES ## UNDEFINED # SaveLockBox
- gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable
[Pcd]
gEfiMdeModulePkgTokenSpaceGuid.PcdProgressCodeOsLoaderLoad ## CONSUMES
gEfiMdeModulePkgTokenSpaceGuid.PcdProgressCodeOsLoaderStart ## CONSUMES
gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 7/8] MdeModulePkg/FirmwarePerfSmm:Enhance for new pref infrastructure
2018-01-30 13:53 [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table Dandan Bi
` (5 preceding siblings ...)
2018-01-30 13:53 ` [PATCH v2 6/8] MdeModulePkg/FirmwarePerfDxe:Enhance for new pref infrastructure Dandan Bi
@ 2018-01-30 13:53 ` Dandan Bi
2018-01-30 13:53 ` [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table Dandan Bi
2020-04-28 7:45 ` [edk2-devel] [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI " boonewang
8 siblings, 0 replies; 21+ messages in thread
From: Dandan Bi @ 2018-01-30 13:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Star Zeng
V2:
Update FirmwarePerformanceSmm to receive the address
of performance records instead of records content.
Receive buffer address of Boot performance records
which are reported by SmmCorePerformanceLib.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../FirmwarePerformanceSmm.c | 29 +++++-----------------
1 file changed, 6 insertions(+), 23 deletions(-)
diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwarePerformanceSmm.c b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwarePerformanceSmm.c
index c750331..28fb3d0 100644
--- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwarePerformanceSmm.c
+++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwarePerformanceSmm.c
@@ -82,11 +82,11 @@ FpdtStatusCodeListenerSmm (
)
{
EFI_STATUS Status;
UINT64 CurrentTime;
EFI_ACPI_5_0_FPDT_S3_SUSPEND_RECORD S3SuspendRecord;
- UINT8 *NewRecordBuffer;
+ SMM_BOOT_PERFORMANCE_TABLE *mSmmBootPerformanceTable;
//
// Check whether status code is what we are interested in.
//
if ((CodeType & EFI_STATUS_CODE_TYPE_MASK) != EFI_PROGRESS_CODE) {
@@ -96,34 +96,17 @@ FpdtStatusCodeListenerSmm (
//
// Collect one or more Boot records in boot time
//
if (Data != NULL && CompareGuid (&Data->Type, &gEfiFirmwarePerformanceGuid)) {
AcquireSpinLock (&mSmmFpdtLock);
-
- if (mBootRecordSize + Data->Size > mBootRecordMaxSize) {
- //
- // Try to allocate big SMRAM data to store Boot record.
- //
- if (mSmramIsOutOfResource) {
- ReleaseSpinLock (&mSmmFpdtLock);
- return EFI_OUT_OF_RESOURCES;
- }
- NewRecordBuffer = ReallocatePool (mBootRecordSize, mBootRecordSize + Data->Size + EXTENSION_RECORD_SIZE, mBootRecordBuffer);
- if (NewRecordBuffer == NULL) {
- ReleaseSpinLock (&mSmmFpdtLock);
- mSmramIsOutOfResource = TRUE;
- return EFI_OUT_OF_RESOURCES;
- }
- mBootRecordBuffer = NewRecordBuffer;
- mBootRecordMaxSize = mBootRecordSize + Data->Size + EXTENSION_RECORD_SIZE;
- }
//
- // Save boot record into the temp memory space.
+ // Get the boot performance data.
//
- CopyMem (mBootRecordBuffer + mBootRecordSize, Data + 1, Data->Size);
- mBootRecordSize += Data->Size;
-
+ CopyMem (&mSmmBootPerformanceTable, Data + 1, Data->Size);
+ mBootRecordBuffer = ((UINT8 *) (mSmmBootPerformanceTable)) + sizeof (SMM_BOOT_PERFORMANCE_TABLE);
+ mBootRecordSize = mSmmBootPerformanceTable->Header.Length - sizeof (SMM_BOOT_PERFORMANCE_TABLE) ;
+
ReleaseSpinLock (&mSmmFpdtLock);
return EFI_SUCCESS;
}
if ((Value != PcdGet32 (PcdProgressCodeS3SuspendStart)) &&
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table
2018-01-30 13:53 [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table Dandan Bi
` (6 preceding siblings ...)
2018-01-30 13:53 ` [PATCH v2 7/8] MdeModulePkg/FirmwarePerfSmm:Enhance " Dandan Bi
@ 2018-01-30 13:53 ` Dandan Bi
2020-04-28 7:45 ` [edk2-devel] [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI " boonewang
8 siblings, 0 replies; 21+ messages in thread
From: Dandan Bi @ 2018-01-30 13:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Star Zeng, Ruiyu Ni, Jaben Carsey
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 609 ++++++++++++++++++++-
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h | 7 +-
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni | 11 +-
ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 5 +-
.../DpDynamicCommand/DpDynamicCommand.inf | 5 +-
.../DynamicCommand/DpDynamicCommand/DpInternal.h | 9 +-
ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c | 108 ++--
.../DynamicCommand/DpDynamicCommand/DpUtilities.c | 37 +-
.../DynamicCommand/DpDynamicCommand/Literals.c | 24 +-
.../DynamicCommand/DpDynamicCommand/Literals.h | 8 +-
.../DpDynamicCommand/PerformanceTokens.h | 28 -
11 files changed, 724 insertions(+), 127 deletions(-)
delete mode 100644 ShellPkg/DynamicCommand/DpDynamicCommand/PerformanceTokens.h
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
index 3ecc753..f41f18d 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
@@ -11,40 +11,64 @@
Measurement records contain identifying information (Handle, Token, Module)
and start and end time values.
Dp uses this information to group records in different ways. It also uses
timer information to calculate elapsed time for each measurement.
- Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
**/
-#include "PerformanceTokens.h"
#include "Dp.h"
#include "Literals.h"
#include "DpInternal.h"
+#pragma pack(1)
+
+typedef struct {
+ EFI_ACPI_DESCRIPTION_HEADER Header;
+ UINT32 Entry;
+} RSDT_TABLE;
+
+typedef struct {
+ EFI_ACPI_DESCRIPTION_HEADER Header;
+ UINT64 Entry;
+} XSDT_TABLE;
+
+#pragma pack()
+
EFI_HANDLE mDpHiiHandle;
+typedef struct {
+ EFI_HANDLE Handle;
+ EFI_GUID ModuleGuid;
+} HANDLE_GUID_MAP;
+
+HANDLE_GUID_MAP *mCacheHandleGuidTable;
+UINTN mCachePairCount = 0;
+
//
/// Module-Global Variables
///@{
CHAR16 mGaugeString[DP_GAUGE_STRING_LENGTH + 1];
CHAR16 mUnicodeToken[DXE_PERFORMANCE_STRING_SIZE];
UINT64 mInterestThreshold;
BOOLEAN mShowId = FALSE;
+UINT8 *mBootPerformanceTable;
+UINTN mBootPerformanceTableSize;
+BOOLEAN mPeiPhase = FALSE;
+BOOLEAN mDxePhase = FALSE;
PERF_SUMMARY_DATA SummaryData = { 0 }; ///< Create the SummaryData structure and init. to ZERO.
-
-/// Timer Specific Information.
-TIMER_INFO TimerInfo;
+MEASUREMENT_RECORD *mMeasurementList = NULL;
+UINTN mMeasurementNum = 0;
/// Items for which to gather cumulative statistics.
PERF_CUM_DATA CumData[] = {
PERF_INIT_CUM_DATA (LOAD_IMAGE_TOK),
PERF_INIT_CUM_DATA (START_IMAGE_TOK),
@@ -98,10 +122,540 @@ DumpStatistics( void )
SHELL_FREE_NON_NULL (StringPtr);
SHELL_FREE_NON_NULL (StringPtrUnknown);
}
/**
+ This function scan ACPI table in RSDT.
+
+ @param Rsdt ACPI RSDT
+ @param Signature ACPI table signature
+
+ @return ACPI table
+**/
+VOID *
+ScanTableInRSDT (
+ IN RSDT_TABLE *Rsdt,
+ IN UINT32 Signature
+ )
+{
+ UINTN Index;
+ UINT32 EntryCount;
+ UINT32 *EntryPtr;
+ EFI_ACPI_DESCRIPTION_HEADER *Table;
+
+ EntryCount = (Rsdt->Header.Length - sizeof (EFI_ACPI_DESCRIPTION_HEADER)) / sizeof(UINT32);
+
+ EntryPtr = &Rsdt->Entry;
+ for (Index = 0; Index < EntryCount; Index ++, EntryPtr ++) {
+ Table = (EFI_ACPI_DESCRIPTION_HEADER*)((UINTN)(*EntryPtr));
+ if (Table->Signature == Signature) {
+ return Table;
+ }
+ }
+
+ return NULL;
+}
+
+/**
+ This function scan ACPI table in XSDT.
+
+ @param Xsdt ACPI XSDT
+ @param Signature ACPI table signature
+
+ @return ACPI table
+**/
+VOID *
+ScanTableInXSDT (
+ IN XSDT_TABLE *Xsdt,
+ IN UINT32 Signature
+ )
+{
+ UINTN Index;
+ UINT32 EntryCount;
+ UINT64 EntryPtr;
+ UINTN BasePtr;
+ EFI_ACPI_DESCRIPTION_HEADER *Table;
+
+ EntryCount = (Xsdt->Header.Length - sizeof (EFI_ACPI_DESCRIPTION_HEADER)) / sizeof(UINT64);
+
+ BasePtr = (UINTN)(&(Xsdt->Entry));
+ for (Index = 0; Index < EntryCount; Index ++) {
+ CopyMem (&EntryPtr, (VOID *)(BasePtr + Index * sizeof(UINT64)), sizeof(UINT64));
+ Table = (EFI_ACPI_DESCRIPTION_HEADER*)((UINTN)(EntryPtr));
+ if (Table->Signature == Signature) {
+ return Table;
+ }
+ }
+
+ return NULL;
+}
+
+/**
+ This function scan ACPI table in RSDP.
+
+ @param Rsdp ACPI RSDP
+ @param Signature ACPI table signature
+
+ @return ACPI table
+**/
+VOID *
+FindAcpiPtr (
+ IN EFI_ACPI_5_0_ROOT_SYSTEM_DESCRIPTION_POINTER *Rsdp,
+ IN UINT32 Signature
+ )
+{
+ EFI_ACPI_DESCRIPTION_HEADER *AcpiTable;
+ RSDT_TABLE *Rsdt;
+ XSDT_TABLE *Xsdt;
+
+ AcpiTable = NULL;
+
+ //
+ // Check ACPI2.0 table
+ //
+ Rsdt = (RSDT_TABLE *)(UINTN)Rsdp->RsdtAddress;
+ Xsdt = NULL;
+ if ((Rsdp->Revision >= 2) && (Rsdp->XsdtAddress < (UINT64)(UINTN)-1)) {
+ Xsdt = (XSDT_TABLE *)(UINTN)Rsdp->XsdtAddress;
+ }
+ //
+ // Check Xsdt
+ //
+ if (Xsdt != NULL) {
+ AcpiTable = ScanTableInXSDT (Xsdt, Signature);
+ }
+ //
+ // Check Rsdt
+ //
+ if ((AcpiTable == NULL) && (Rsdt != NULL)) {
+ AcpiTable = ScanTableInRSDT (Rsdt, Signature);
+ }
+
+ return AcpiTable;
+}
+
+/**
+ Get Boot performance table form Acpi table.
+
+**/
+EFI_STATUS
+GetBootPerformanceTable (
+ )
+{
+ EFI_STATUS Status;
+ VOID *AcpiTable;
+ FIRMWARE_PERFORMANCE_TABLE *FirmwarePerformanceTable;
+
+ AcpiTable = NULL;
+
+ Status = EfiGetSystemConfigurationTable (
+ &gEfiAcpi20TableGuid,
+ &AcpiTable
+ );
+ if (EFI_ERROR (Status)) {
+ Status = EfiGetSystemConfigurationTable (
+ &gEfiAcpi10TableGuid,
+ &AcpiTable
+ );
+ }
+ if (EFI_ERROR(Status)) {
+ return Status;
+ }
+
+ FirmwarePerformanceTable = FindAcpiPtr (
+ (EFI_ACPI_5_0_ROOT_SYSTEM_DESCRIPTION_POINTER *)AcpiTable,
+ EFI_ACPI_5_0_FIRMWARE_PERFORMANCE_DATA_TABLE_SIGNATURE
+ );
+ if (FirmwarePerformanceTable == NULL) {
+ return EFI_NOT_FOUND;
+ }
+
+ mBootPerformanceTable = (UINT8*) (UINTN)FirmwarePerformanceTable->BootPointerRecord.BootPerformanceTablePointer;
+ mBootPerformanceTableSize = ((BOOT_PERFORMANCE_TABLE *) mBootPerformanceTable)->Header.Length;
+
+ return EFI_SUCCESS;
+}
+
+/**
+ Get Handle form Module Guid.
+
+ @param ModuleGuid Module Guid.
+ @param Handle The handle to be returned.
+
+**/
+VOID
+GetHandleFormModuleGuid (
+ IN EFI_GUID *ModuleGuid,
+ IN OUT EFI_HANDLE *Handle
+ )
+{
+ UINTN Index;
+
+ if (IsZeroGuid (ModuleGuid)) {
+ *Handle = NULL;
+ }
+ //
+ // Try to get the Handle form the caached array.
+ //
+ for (Index = 0; Index < mCachePairCount; Index++) {
+ if (CompareGuid (ModuleGuid, &mCacheHandleGuidTable[Index].ModuleGuid)) {
+ *Handle = mCacheHandleGuidTable[Index].Handle;
+ break;
+ }
+ }
+ if (Index >= mCachePairCount) {
+ *Handle = NULL;
+ }
+}
+
+/**
+Cache the GUID and handle mapping pairs. In order to save time for searching.
+
+**/
+EFI_STATUS
+BuildCachedGuidHandleTable (
+ VOID
+ )
+{
+ EFI_STATUS Status;
+ EFI_HANDLE *HandleBuffer;
+ UINTN HandleCount;
+ UINTN Index;
+ EFI_LOADED_IMAGE_PROTOCOL *LoadedImage;
+ EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
+ EFI_GUID *TempGuid;
+ MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *FvFilePath;
+
+ Status = gBS->LocateHandleBuffer (AllHandles, NULL, NULL, &HandleCount, &HandleBuffer);
+ if (EFI_ERROR (Status)) {
+ ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_HANDLES_ERROR), mDpHiiHandle, Status);
+ return Status;
+ }
+
+ mCacheHandleGuidTable = AllocateZeroPool (HandleCount * sizeof (HANDLE_GUID_MAP));
+ if (mCacheHandleGuidTable == NULL) {
+ return EFI_OUT_OF_RESOURCES;
+ }
+
+ for (Index = 0; Index < HandleCount; Index++) {
+ //
+ // Try Handle as ImageHandle.
+ //
+ Status = gBS->HandleProtocol (
+ HandleBuffer[Index],
+ &gEfiLoadedImageProtocolGuid,
+ (VOID**) &LoadedImage
+ );
+ if (EFI_ERROR (Status)) {
+ //
+ // Try Handle as Controller Handle
+ //
+ Status = gBS->OpenProtocol (
+ HandleBuffer[Index],
+ &gEfiDriverBindingProtocolGuid,
+ (VOID **) &DriverBinding,
+ NULL,
+ NULL,
+ EFI_OPEN_PROTOCOL_GET_PROTOCOL
+ );
+ if (!EFI_ERROR (Status)) {
+ //
+ // Get Image protocol from ImageHandle
+ //
+ Status = gBS->HandleProtocol (
+ DriverBinding->ImageHandle,
+ &gEfiLoadedImageProtocolGuid,
+ (VOID**) &LoadedImage
+ );
+ }
+ }
+
+ if (!EFI_ERROR (Status) && LoadedImage != NULL) {
+ //
+ // Get Module Guid from DevicePath.
+ //
+ if (LoadedImage->FilePath != NULL &&
+ LoadedImage->FilePath->Type == MEDIA_DEVICE_PATH &&
+ LoadedImage->FilePath->SubType == MEDIA_PIWG_FW_FILE_DP
+ ) {
+ FvFilePath = (MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *) LoadedImage->FilePath;
+ TempGuid = &FvFilePath->FvFileName;
+
+ mCacheHandleGuidTable[mCachePairCount].Handle = HandleBuffer[Index];
+ CopyGuid (&mCacheHandleGuidTable[mCachePairCount].ModuleGuid, TempGuid);
+ mCachePairCount ++;
+ }
+ }
+ }
+ if (HandleBuffer != NULL) {
+ FreePool (HandleBuffer);
+ HandleBuffer = NULL;
+ }
+ return Status;
+}
+
+/**
+ Get Measurement form Fpdt records.
+
+ @param RecordHeader Pointer to the start record.
+ @param IsStart Is start record or End record.
+ @param Measurement Pointer to the measurement which need to be filled.
+
+**/
+VOID
+GetMeasurementInfo (
+ IN EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *RecordHeader,
+ IN BOOLEAN IsStart,
+ IN OUT MEASUREMENT_RECORD *Measurement
+ )
+{
+ VOID *ModuleGuid;
+ EFI_HANDLE StartHandle;
+
+ switch (RecordHeader->Type) {
+ case GUID_EVENT_TYPE:
+ ModuleGuid = &(((GUID_EVENT_RECORD *)RecordHeader)->Guid);
+ Measurement->Identifier = ((UINT32)((GUID_EVENT_RECORD *)RecordHeader)->ProgressID);
+ if (IsStart) {
+ Measurement->StartTimeStamp = ((GUID_EVENT_RECORD *)RecordHeader)->Timestamp;
+ } else {
+ Measurement->EndTimeStamp = ((GUID_EVENT_RECORD *)RecordHeader)->Timestamp;
+ }
+ switch (Measurement->Identifier) {
+ case MODULE_START_ID:
+ case MODULE_END_ID:
+ if (mPeiPhase) {
+ Measurement->Token = ALit_PEIM;
+ Measurement->Module = ALit_PEIM;
+ } else if (mDxePhase) {
+ Measurement->Token = ALit_START_IMAGE;
+ Measurement->Module = ALit_START_IMAGE;
+ }
+ break;
+ default:
+ ASSERT(FALSE);
+ }
+
+ if (AsciiStrCmp (Measurement->Token, ALit_PEIM) == 0) {
+ Measurement->Handle = &(((GUID_EVENT_RECORD *)RecordHeader)->Guid);
+ } else {
+ GetHandleFormModuleGuid(ModuleGuid, &StartHandle);
+ Measurement->Handle = StartHandle;
+ }
+ break;
+
+ case DYNAMIC_STRING_EVENT_TYPE:
+ ModuleGuid = &(((DYNAMIC_STRING_EVENT_RECORD *)RecordHeader)->Guid);
+ Measurement->Identifier = ((UINT32)((DYNAMIC_STRING_EVENT_RECORD *)RecordHeader)->ProgressID);
+ if (IsStart) {
+ Measurement->StartTimeStamp = ((DYNAMIC_STRING_EVENT_RECORD *)RecordHeader)->Timestamp;
+ } else {
+ Measurement->EndTimeStamp = ((DYNAMIC_STRING_EVENT_RECORD *)RecordHeader)->Timestamp;
+ }
+ switch (Measurement->Identifier) {
+ case MODULE_START_ID:
+ case MODULE_END_ID:
+ if (mPeiPhase) {
+ Measurement->Token = ALit_PEIM;
+ } else if (mDxePhase) {
+ Measurement->Token = ALit_START_IMAGE;
+ }
+ break;
+
+ case MODULE_LOADIMAGE_START_ID:
+ case MODULE_LOADIMAGE_END_ID:
+ Measurement->Token = ALit_LOAD_IMAGE;
+ break;
+
+ case MODULE_DB_START_ID:
+ case MODULE_DB_END_ID:
+ Measurement->Token = ALit_DB_START;
+ break;
+
+ case MODULE_DB_SUPPORT_START_ID:
+ case MODULE_DB_SUPPORT_END_ID:
+ Measurement->Token = ALit_DB_SUPPORT;
+ break;
+
+ case MODULE_DB_STOP_START_ID:
+ case MODULE_DB_STOP_END_ID:
+ Measurement->Token = ALit_DB_STOP;
+ break;
+
+ default:
+ Measurement->Token = ((DYNAMIC_STRING_EVENT_RECORD *)RecordHeader)->String;
+ break;
+ }
+
+ Measurement->Module = ((DYNAMIC_STRING_EVENT_RECORD *)RecordHeader)->String;
+
+ if (AsciiStrCmp (Measurement->Token, ALit_PEIM) == 0) {
+ Measurement->Handle = &(((GUID_EVENT_RECORD *)RecordHeader)->Guid);
+ } else {
+ GetHandleFormModuleGuid(ModuleGuid, &StartHandle);
+ Measurement->Handle = StartHandle;
+ }
+ break;
+
+ case GUID_QWORD_EVENT_TYPE:
+ ModuleGuid = &(((GUID_QWORD_EVENT_RECORD *)RecordHeader)->Guid);
+ Measurement->Identifier = ((UINT32)((GUID_QWORD_EVENT_RECORD *)RecordHeader)->ProgressID);
+ if (IsStart) {
+ Measurement->StartTimeStamp = ((GUID_QWORD_EVENT_RECORD *)RecordHeader)->Timestamp;
+ } else {
+ Measurement->EndTimeStamp = ((GUID_QWORD_EVENT_RECORD *)RecordHeader)->Timestamp;
+ }
+ switch (Measurement->Identifier) {
+ case MODULE_DB_START_ID:
+ Measurement->Token = ALit_DB_START;
+ Measurement->Module = ALit_DB_START;
+ break;
+
+ case MODULE_DB_SUPPORT_START_ID:
+ case MODULE_DB_SUPPORT_END_ID:
+ Measurement->Token = ALit_DB_SUPPORT;
+ Measurement->Module = ALit_DB_SUPPORT;
+ break;
+
+ case MODULE_DB_STOP_START_ID:
+ case MODULE_DB_STOP_END_ID:
+ Measurement->Token = ALit_DB_STOP;
+ Measurement->Module = ALit_DB_STOP;
+ break;
+
+ case MODULE_LOADIMAGE_START_ID:
+ case MODULE_LOADIMAGE_END_ID:
+ Measurement->Token = ALit_LOAD_IMAGE;
+ Measurement->Module = ALit_LOAD_IMAGE;
+ break;
+
+ default:
+ ASSERT(FALSE);
+ }
+ GetHandleFormModuleGuid(ModuleGuid, &StartHandle);
+ Measurement->Handle = StartHandle;
+ break;
+
+ case GUID_QWORD_STRING_EVENT_TYPE:
+ ModuleGuid = &(((GUID_QWORD_STRING_EVENT_RECORD *)RecordHeader)->Guid);
+ Measurement->Identifier = ((UINT32)((GUID_QWORD_STRING_EVENT_RECORD *)RecordHeader)->ProgressID);
+ if (IsStart) {
+ Measurement->StartTimeStamp = ((GUID_QWORD_STRING_EVENT_RECORD*)RecordHeader)->Timestamp;
+ } else {
+ Measurement->EndTimeStamp = ((GUID_QWORD_STRING_EVENT_RECORD *)RecordHeader)->Timestamp;
+ }
+ //
+ // Currently only "DB:Start:" end record with GUID_QWORD_STRING_EVENT_TYPE.
+ //
+ switch (Measurement->Identifier) {
+ case MODULE_DB_END_ID:
+ Measurement->Token = ALit_DB_START;
+ Measurement->Module = ALit_DB_START;
+ break;
+ default:
+ ASSERT(FALSE);
+ }
+ GetHandleFormModuleGuid(ModuleGuid, &StartHandle);
+ Measurement->Handle = StartHandle;
+ break;
+
+ default:
+ break;
+ }
+}
+
+/**
+ Search the start measurement in the mMeasurementList for the end measurement.
+
+ @param EndMeasureMent Measurement for end record.
+
+**/
+VOID
+SearchMeasurement (
+ IN MEASUREMENT_RECORD *EndMeasureMent
+ )
+{
+ INTN Index;
+
+ for (Index = mMeasurementNum - 1; Index >= 0; Index--) {
+ if (AsciiStrCmp (EndMeasureMent->Token, ALit_PEIM) == 0) {
+ if (mMeasurementList[Index].EndTimeStamp == 0 && EndMeasureMent->Handle!= NULL && mMeasurementList[Index].Handle != NULL&&
+ CompareGuid(mMeasurementList[Index].Handle, EndMeasureMent->Handle) &&
+ (AsciiStrCmp (mMeasurementList[Index].Token, EndMeasureMent->Token) == 0) &&
+ (AsciiStrCmp (mMeasurementList[Index].Module, EndMeasureMent->Module) == 0)) {
+ mMeasurementList[Index].EndTimeStamp = EndMeasureMent->EndTimeStamp;
+ break;
+ }
+ } else {
+ if (mMeasurementList[Index].EndTimeStamp == 0 && mMeasurementList[Index].Handle == EndMeasureMent->Handle &&
+ (AsciiStrCmp (mMeasurementList[Index].Token, EndMeasureMent->Token) == 0) &&
+ (AsciiStrCmp (mMeasurementList[Index].Module, EndMeasureMent->Module) == 0)) {
+ mMeasurementList[Index].EndTimeStamp = EndMeasureMent->EndTimeStamp;
+ break;
+ }
+ }
+ }
+}
+
+/**
+ Generate the measure record array.
+
+**/
+EFI_STATUS
+BuildMeasurementList (
+ )
+{
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *RecordHeader;
+ UINT8 *PerformanceTablePtr;
+ UINT16 StartProgressId;
+ UINTN TableLength;
+ UINT8 *StartRecordEvent;
+ MEASUREMENT_RECORD MeasureMent;
+
+ mMeasurementList = AllocateZeroPool (mBootPerformanceTableSize);
+ if (mMeasurementList == NULL) {
+ return EFI_OUT_OF_RESOURCES;
+ }
+
+ TableLength = sizeof (BOOT_PERFORMANCE_TABLE);
+ PerformanceTablePtr = (mBootPerformanceTable + TableLength);
+
+ while (TableLength < mBootPerformanceTableSize) {
+ RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER*) PerformanceTablePtr;
+ StartRecordEvent = (UINT8 *)RecordHeader;
+ StartProgressId = ((GUID_EVENT_RECORD *)StartRecordEvent)->ProgressID;
+
+ //
+ // If the record is the start record, fill the info to the measurement in the mMeasurementList.
+ // If the record is the end record, find the related start measurement in the mMeasurementList and fill the EndTimeStamp.
+ //
+ if (((StartProgressId >= PERF_EVENTSIGNAL_START_ID && ((StartProgressId & 0x000F) == 0)) ||
+ (StartProgressId < PERF_EVENTSIGNAL_START_ID && ((StartProgressId & 0x0001) != 0)))) {
+ //
+ // Since PEIM and StartImage has same Type and ID when PCD PcdEdkiiFpdtStringRecordEnableOnly = FALSE
+ // So we need to identify these two kinds of record through different phase.
+ //
+ if (AsciiStrCmp (((DYNAMIC_STRING_EVENT_RECORD *)StartRecordEvent)->String, ALit_PEI) == 0) {
+ mPeiPhase = TRUE;
+ } else if (AsciiStrCmp (((DYNAMIC_STRING_EVENT_RECORD *)StartRecordEvent)->String, ALit_DXE) == 0) {
+ mDxePhase = TRUE;
+ mPeiPhase = FALSE;
+ }
+ // Get measurement info form the start record to the mMeasurementList.
+ GetMeasurementInfo (RecordHeader, TRUE, &(mMeasurementList[mMeasurementNum]));
+ mMeasurementNum ++;
+ } else {
+ GetMeasurementInfo (RecordHeader, FALSE, &MeasureMent);
+ SearchMeasurement (&MeasureMent);
+ }
+ TableLength += RecordHeader->Length;
+ PerformanceTablePtr += RecordHeader->Length;
+ }
+ return EFI_SUCCESS;
+}
+
+/**
Initialize the cumulative data.
**/
VOID
InitCumulativeData (
@@ -153,10 +707,11 @@ RunDp (
BOOLEAN CumulativeMode;
CONST CHAR16 *CustomCumulativeToken;
PERF_CUM_DATA *CustomCumulativeData;
UINTN NameSize;
SHELL_STATUS ShellStatus;
+ TIMER_INFO TimerInfo;
StringPtr = NULL;
SummaryMode = FALSE;
VerboseMode = FALSE;
AllMode = FALSE;
@@ -173,10 +728,40 @@ RunDp (
//
Status = ShellInitialize();
ASSERT_EFI_ERROR(Status);
//
+ // DP dump performance data by parsing FPDT table in ACPI table.
+ // Folloing 3 steps are to get the measurement form the FPDT table.
+ //
+
+ //
+ //1. Get FPDT from ACPI table.
+ //
+ Status = GetBootPerformanceTable ();
+ if (EFI_ERROR(Status)) {
+ ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_GET_BOOT_PERFORMANCE_TABLE_FAIL), mDpHiiHandle);
+ return Status;
+ }
+
+ //
+ //2. Cache the ModuleGuid and hanlde mapping table.
+ //
+ Status = BuildCachedGuidHandleTable();
+ if (EFI_ERROR (Status)) {
+ return Status;
+ }
+
+ //
+ //3. Build the measurement array form the FPDT records.
+ //
+ Status = BuildMeasurementList ();
+ if (EFI_ERROR(Status)) {
+ return Status;
+ }
+
+ //
// Process Command Line arguments
//
Status = ShellCommandLineParse (ParamList, &ParamPackage, NULL, TRUE);
if (EFI_ERROR(Status)) {
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_INVALID_ARG), mDpHiiHandle);
@@ -265,15 +850,13 @@ RunDp (
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_PERF_PROPERTY_NOT_FOUND), mDpHiiHandle);
goto Done;
}
TimerInfo.Frequency = (UINT32)DivU64x32 (PerformanceProperty->Frequency, 1000);
- TimerInfo.StartCount = PerformanceProperty->TimerStartValue;
- TimerInfo.EndCount = PerformanceProperty->TimerEndValue;
-
- // Determine in which direction the performance counter counts.
- TimerInfo.CountUp = (BOOLEAN) (TimerInfo.EndCount >= TimerInfo.StartCount);
+ TimerInfo.StartCount = 0;
+ TimerInfo.EndCount = 0xFFFF;
+ TimerInfo.CountUp = TRUE;
//
// Print header
//
// print DP's build version
@@ -383,10 +966,16 @@ Done:
if (CustomCumulativeData != NULL) {
SHELL_FREE_NON_NULL (CustomCumulativeData->Name);
}
SHELL_FREE_NON_NULL (CustomCumulativeData);
+ SHELL_FREE_NON_NULL (mMeasurementList);
+
+ SHELL_FREE_NON_NULL (mCacheHandleGuidTable);
+
+ mMeasurementNum = 0;
+ mCachePairCount = 0;
return ShellStatus;
}
/**
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
index 4027b6b..9fd8857 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
@@ -1,9 +1,9 @@
/** @file
Header file for 'dp' command functions.
- Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -17,10 +17,13 @@
#include <Uefi.h>
#include <Guid/Performance.h>
+#include <Guid/ExtendedFirmwarePerformance.h>
+#include <Guid/FirmwarePerformance.h>
+#include <Guid/Acpi.h>
#include <Protocol/HiiPackageList.h>
#include <Protocol/DevicePath.h>
#include <Protocol/LoadedImage.h>
#include <Protocol/UnicodeCollation.h>
@@ -40,11 +43,11 @@
#include <Library/UefiHiiServicesLib.h>
extern EFI_HANDLE mDpHiiHandle;
#define DP_MAJOR_VERSION 2
-#define DP_MINOR_VERSION 4
+#define DP_MINOR_VERSION 5
/**
* The value assigned to DP_DEBUG controls which debug output
* is generated. Set it to ZERO to disable.
**/
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni
index b77c507..b6069ae 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni
@@ -1,9 +1,9 @@
// *++
//
// (C) Copyright 2014-2015 Hewlett-Packard Development Company, L.P.<BR>
-// Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
+// Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
// (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
// This program and the accompanying materials
// are licensed and made available under the terms and conditions of the BSD License
// which accompanies this distribution. The full text of the license may be found at
// http://opensource.org/licenses/bsd-license.php
@@ -49,14 +49,14 @@
#string STR_DP_HANDLE_SECTION #language en-US "Index: Handle Driver Name Description Time(us)\n"
#string STR_DP_HANDLE_VARS #language en-US "%5d: [%3x] %36s %11s %L8d\n"
#string STR_DP_HANDLE_SECTION2 #language en-US "Index: Handle Driver Name Description Time(us) ID\n"
#string STR_DP_HANDLE_VARS2 #language en-US "%5d: [%3x] %36s %11s %L8d %5d\n"
#string STR_DP_SECTION_PEIMS #language en-US "PEIMs"
-#string STR_DP_PEIM_SECTION #language en-US "Index: Pointer Value Instance GUID Token Time(us)\n"
-#string STR_DP_PEIM_VARS #language en-US "%5d: 0x%11p %g PEIM %L8d\n"
-#string STR_DP_PEIM_SECTION2 #language en-US "Index: Pointer Value Instance GUID Token Time(us) ID\n"
-#string STR_DP_PEIM_VARS2 #language en-US "%5d: 0x%11p %g PEIM %L8d %5d\n"
+#string STR_DP_PEIM_SECTION #language en-US "Index: Instance GUID Token Time(us)\n"
+#string STR_DP_PEIM_VARS #language en-US "%5d: %g PEIM %L8d\n"
+#string STR_DP_PEIM_SECTION2 #language en-US "Index: Instance GUID Token Time(us) ID\n"
+#string STR_DP_PEIM_VARS2 #language en-US "%5d: %g PEIM %L8d %5d\n"
#string STR_DP_SECTION_GENERAL #language en-US "General"
#string STR_DP_GLOBAL_SECTION #language en-US "Index Name Description Time(us)\n"
#string STR_DP_GLOBAL_VARS #language en-US "%5d:%25s %31s %L8d\n"
#string STR_DP_GLOBAL_SECTION2 #language en-US "Index Name Description Time(us) ID\n"
#string STR_DP_GLOBAL_VARS2 #language en-US "%5d:%25s %31s %L8d %5d\n"
@@ -88,10 +88,11 @@
#string STR_DP_RAW_VARS2 #language en-US "%5d: %16LX %16LX %16LX %31a %31a %5d\n"
#string STR_DP_RAW_HEADR2 #language en-US "\nIndex Handle Start Count End Count Token Module ID\n"
#string STR_DP_INCOMPLETE #language en-US " I "
#string STR_DP_COMPLETE #language en-US " "
#string STR_ALIT_UNKNOWN #language en-US "Unknown"
+#string STR_DP_GET_BOOT_PERFORMANCE_TABLE_FAIL #language en-US "Fail to get boot performance table\n"
#string STR_GET_HELP_DP #language en-US ""
".TH dp 0 "Display performance metrics"\r\n"
".SH NAME\r\n"
"Displays performance metrics that are stored in memory.\r\n"
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
index b0ed229..54fe001 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
@@ -1,9 +1,9 @@
## @file
# Provides Shell 'dp' standalone application.
#
-# Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
# http://opensource.org/licenses/bsd-license.php
# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
@@ -23,11 +23,10 @@
# This flag specifies whether HII resource section is generated into PE image.
#
UEFI_HII_RESOURCE_SECTION = TRUE
[Sources.common]
- PerformanceTokens.h
Dp.uni
Dp.c
Dp.h
Literals.h
Literals.c
@@ -59,10 +58,12 @@
DxeServicesLib
PeCoffGetEntryPointLib
[Guids]
gPerformanceProtocolGuid ## CONSUMES ## SystemTable
+ gEfiAcpi20TableGuid ## CONSUMES ## SystemTable
+ gEfiAcpi10TableGuid ## CONSUMES ## SystemTable
[Protocols]
gEfiLoadedImageProtocolGuid ## CONSUMES
gEfiDriverBindingProtocolGuid ## SOMETIMES_CONSUMES
gEfiComponentName2ProtocolGuid ## SOMETIMES_CONSUMES
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
index 3164561..e906870 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
@@ -1,9 +1,9 @@
## @file
# Provides Shell 'dp' dynamic command.
#
-# Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
# http://opensource.org/licenses/bsd-license.php
# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
@@ -24,11 +24,10 @@
# This flag specifies whether HII resource section is generated into PE image.
#
UEFI_HII_RESOURCE_SECTION = TRUE
[Sources.common]
- PerformanceTokens.h
Dp.uni
Dp.c
Dp.h
Literals.h
Literals.c
@@ -60,10 +59,12 @@
DxeServicesLib
PeCoffGetEntryPointLib
[Guids]
gPerformanceProtocolGuid ## CONSUMES ## SystemTable
+ gEfiAcpi20TableGuid ## CONSUMES
+ gEfiAcpi10TableGuid ## CONSUMES
[Protocols]
gEfiLoadedImageProtocolGuid ## CONSUMES
gEfiDriverBindingProtocolGuid ## SOMETIMES_CONSUMES
gEfiComponentName2ProtocolGuid ## SOMETIMES_CONSUMES
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpInternal.h b/ShellPkg/DynamicCommand/DpDynamicCommand/DpInternal.h
index ece1c23..eedc377 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpInternal.h
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpInternal.h
@@ -4,11 +4,11 @@
Declarations of data and functions which are private to the Dp application.
This file should never be referenced by anything other than components of the
Dp application. In addition to global data, function declarations for
DpUtilities.c, DpTrace.c, and DpProfile.c are included here.
- Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -27,16 +27,17 @@
extern EFI_HII_HANDLE mDpHiiHandle;
extern CHAR16 mGaugeString[DP_GAUGE_STRING_LENGTH + 1];
extern CHAR16 mUnicodeToken[DXE_PERFORMANCE_STRING_SIZE];
extern UINT64 mInterestThreshold;
extern BOOLEAN mShowId;
+extern UINT8 *mBootPerformanceTable;
+extern UINTN mBootPerformanceTableLength;
+extern MEASUREMENT_RECORD *mMeasurementList;
+extern UINTN mMeasurementNum;
extern PERF_SUMMARY_DATA SummaryData; ///< Create the SummaryData structure and init. to ZERO.
-/// Timer Specific Information.
-extern TIMER_INFO TimerInfo;
-
/// Items for which to gather cumulative statistics.
extern PERF_CUM_DATA CumData[];
/// Number of items for which we are gathering cumulative statistics.
extern UINT32 const NumCum;
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c b/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
index bc882be..7f7d296 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
@@ -1,9 +1,9 @@
/** @file
Trace reporting for the Dp utility.
- Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -21,17 +21,65 @@
#include <Library/PerformanceLib.h>
#include <Library/PrintLib.h>
#include <Library/HiiLib.h>
#include <Library/PcdLib.h>
-#include <Guid/Performance.h>
-
#include "Dp.h"
#include "Literals.h"
#include "DpInternal.h"
/**
+ Attempts to retrieve a performance measurement log entry from the performance measurement log.
+
+
+ @param LogEntryKey On entry, the key of the performance measurement log entry to retrieve.
+ 0, then the first performance measurement log entry is retrieved.
+ On exit, the key of the next performance log entry.
+ @param Handle Pointer to environment specific context used to identify the component
+ being measured.
+ @param Token Pointer to a Null-terminated ASCII string that identifies the component
+ being measured.
+ @param Module Pointer to a Null-terminated ASCII string that identifies the module
+ being measured.
+ @param StartTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
+ was started.
+ @param EndTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
+ was ended.
+ @param Identifier Pointer to the 32-bit identifier that was recorded when the measurement
+ was ended.
+
+ @return The key for the next performance log entry (in general case).
+
+**/
+UINTN
+GetPerformanceMeasurementRecord (
+ IN UINTN LogEntryKey,
+ OUT CONST VOID **Handle,
+ OUT CONST CHAR8 **Token,
+ OUT CONST CHAR8 **Module,
+ OUT UINT64 *StartTimeStamp,
+ OUT UINT64 *EndTimeStamp,
+ OUT UINT32 *Identifier
+ )
+{
+ if (LogEntryKey == mMeasurementNum) {
+ return 0;
+ }
+
+ *Handle = (VOID *) (UINTN) mMeasurementList[LogEntryKey].Handle;
+ *Token = mMeasurementList[LogEntryKey].Token;
+ *Module = mMeasurementList[LogEntryKey].Module;
+ *StartTimeStamp = mMeasurementList[LogEntryKey].StartTimeStamp;
+ *EndTimeStamp = mMeasurementList[LogEntryKey].EndTimeStamp;
+ *Identifier = mMeasurementList[LogEntryKey].Identifier;
+
+ LogEntryKey ++;
+
+ return LogEntryKey;
+}
+
+/**
Collect verbose statistics about the logged performance measurements.
General Summary information for all Trace measurements is gathered and
stored within the SummaryData structure. This information is both
used internally by subsequent reporting functions, and displayed
@@ -55,11 +103,11 @@ GatherStatistics(
UINT64 Duration;
UINTN LogEntryKey;
INTN TIndex;
LogEntryKey = 0;
- while ((LogEntryKey = GetPerformanceMeasurementEx (
+ while ((LogEntryKey = GetPerformanceMeasurementRecord (
LogEntryKey,
&Measurement.Handle,
&Measurement.Token,
&Measurement.Module,
&Measurement.StartTimeStamp,
@@ -77,17 +125,17 @@ GatherStatistics(
}
if (IsPhase( &Measurement)) {
++SummaryData.NumSummary; // Count the number of major phases
}
- else { // !IsPhase(...
+ else { // !IsPhase
if(Measurement.Handle == NULL) {
++SummaryData.NumGlobal;
}
}
- if (AsciiStrnCmp (Measurement.Token, ALit_PEIM, PERF_TOKEN_LENGTH) == 0) {
+ if (AsciiStrCmp (Measurement.Token, ALit_PEIM) == 0) {
++SummaryData.NumPEIMs; // Count PEIM measurements
}
Duration = GetDuration (&Measurement);
TIndex = GetCumulativeItem (&Measurement);
@@ -188,11 +236,11 @@ DumpAllTrace(
LogEntryKey = 0;
Count = 0;
Index = 0;
while ( WITHIN_LIMIT(Count, Limit) &&
- ((LogEntryKey = GetPerformanceMeasurementEx (
+ ((LogEntryKey = GetPerformanceMeasurementRecord (
LogEntryKey,
&Measurement.Handle,
&Measurement.Token,
&Measurement.Module,
&Measurement.StartTimeStamp,
@@ -229,11 +277,11 @@ DumpAllTrace(
break;
}
}
}
- if (AsciiStrnCmp (Measurement.Token, ALit_PEIM, PERF_TOKEN_LENGTH) == 0) {
+ if (AsciiStrCmp (Measurement.Token, ALit_PEIM) == 0) {
UnicodeSPrint (mGaugeString, sizeof (mGaugeString), L"%g", Measurement.Handle);
}
// Ensure that the argument strings are not too long.
mGaugeString[DP_GAUGE_STRING_LENGTH] = 0;
@@ -329,11 +377,11 @@ DumpRawTrace(
LogEntryKey = 0;
Count = 0;
Index = 0;
while ( WITHIN_LIMIT(Count, Limit) &&
- ((LogEntryKey = GetPerformanceMeasurementEx (
+ ((LogEntryKey = GetPerformanceMeasurementRecord (
LogEntryKey,
&Measurement.Handle,
&Measurement.Token,
&Measurement.Module,
&Measurement.StartTimeStamp,
@@ -418,11 +466,11 @@ ProcessPhases(
(StringPtr == NULL) ? StringPtrUnknown : StringPtr);
FreePool (StringPtr);
FreePool (StringPtrUnknown);
LogEntryKey = 0;
- while ((LogEntryKey = GetPerformanceMeasurementEx (
+ while ((LogEntryKey = GetPerformanceMeasurementRecord (
LogEntryKey,
&Measurement.Handle,
&Measurement.Token,
&Measurement.Module,
&Measurement.StartTimeStamp,
@@ -432,21 +480,21 @@ ProcessPhases(
if (Measurement.EndTimeStamp == 0) { // Skip "incomplete" records
continue;
}
Duration = GetDuration (&Measurement);
if ( Measurement.Handle != NULL
- && (AsciiStrnCmp (Measurement.Token, ALit_BdsTO, PERF_TOKEN_LENGTH) == 0)
+ && (AsciiStrCmp (Measurement.Token, ALit_BdsTO) == 0)
)
{
BdsTimeoutValue = Duration;
- } else if (AsciiStrnCmp (Measurement.Token, ALit_SEC, PERF_TOKEN_LENGTH) == 0) {
+ } else if (AsciiStrCmp (Measurement.Token, ALit_SEC) == 0) {
SecTime = Duration;
- } else if (AsciiStrnCmp (Measurement.Token, ALit_PEI, PERF_TOKEN_LENGTH) == 0) {
+ } else if (AsciiStrCmp (Measurement.Token, ALit_PEI) == 0) {
PeiTime = Duration;
- } else if (AsciiStrnCmp (Measurement.Token, ALit_DXE, PERF_TOKEN_LENGTH) == 0) {
+ } else if (AsciiStrCmp (Measurement.Token, ALit_DXE) == 0) {
DxeTime = Duration;
- } else if (AsciiStrnCmp (Measurement.Token, ALit_BDS, PERF_TOKEN_LENGTH) == 0) {
+ } else if (AsciiStrCmp (Measurement.Token, ALit_BDS) == 0) {
BdsTime = Duration;
}
}
Total = 0;
@@ -460,45 +508,33 @@ ProcessPhases(
}
// print PEI phase duration time
//
if (PeiTime > 0) {
- ElapsedTime = DivU64x32 (
- PeiTime,
- (UINT32)TimerInfo.Frequency
- );
+ ElapsedTime = DivU64x32 (PeiTime, 1000000);
Total += ElapsedTime;
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_PHASE_DURATION), mDpHiiHandle, ALit_PEI, ElapsedTime);
}
// print DXE phase duration time
//
if (DxeTime > 0) {
- ElapsedTime = DivU64x32 (
- DxeTime,
- (UINT32)TimerInfo.Frequency
- );
+ ElapsedTime = DivU64x32 (DxeTime, 1000000);
Total += ElapsedTime;
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_PHASE_DURATION), mDpHiiHandle, ALit_DXE, ElapsedTime);
}
// print BDS phase duration time
//
if (BdsTime > 0) {
- ElapsedTime = DivU64x32 (
- BdsTime,
- (UINT32)TimerInfo.Frequency
- );
+ ElapsedTime = DivU64x32 (BdsTime, 1000000);
Total += ElapsedTime;
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_PHASE_DURATION), mDpHiiHandle, ALit_BDS, ElapsedTime);
}
if (BdsTimeoutValue > 0) {
- ElapsedTime = DivU64x32 (
- BdsTimeoutValue,
- (UINT32)TimerInfo.Frequency
- );
+ ElapsedTime = DivU64x32 (BdsTimeoutValue, 1000000);
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_PHASE_BDSTO), mDpHiiHandle, ALit_BdsTO, ElapsedTime);
}
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_TOTAL_DURATION), mDpHiiHandle, Total);
}
@@ -552,11 +588,11 @@ ProcessHandles(
}
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_DASHES), mDpHiiHandle);
LogEntryKey = 0;
Count = 0;
- while ((LogEntryKey = GetPerformanceMeasurementEx (
+ while ((LogEntryKey = GetPerformanceMeasurementRecord (
LogEntryKey,
&Measurement.Handle,
&Measurement.Token,
&Measurement.Module,
&Measurement.StartTimeStamp,
@@ -655,22 +691,22 @@ ProcessPeims(
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_PEIM_SECTION), mDpHiiHandle);
}
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_DASHES), mDpHiiHandle);
TIndex = 0;
LogEntryKey = 0;
- while ((LogEntryKey = GetPerformanceMeasurementEx (
+ while ((LogEntryKey = GetPerformanceMeasurementRecord (
LogEntryKey,
&Measurement.Handle,
&Measurement.Token,
&Measurement.Module,
&Measurement.StartTimeStamp,
&Measurement.EndTimeStamp,
&Measurement.Identifier)) != 0)
{
TIndex++;
if ((Measurement.EndTimeStamp == 0) ||
- (AsciiStrnCmp (Measurement.Token, ALit_PEIM, PERF_TOKEN_LENGTH) != 0)
+ (AsciiStrCmp (Measurement.Token, ALit_PEIM) != 0)
) {
continue;
}
Duration = GetDuration (&Measurement);
@@ -678,19 +714,17 @@ ProcessPeims(
if (ElapsedTime >= mInterestThreshold) {
// PEIM FILE Handle is the start address of its FFS file that contains its file guid.
if (mShowId) {
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_PEIM_VARS2), mDpHiiHandle,
TIndex, // 1 based, Which measurement record is being printed
- Measurement.Handle, // base address
Measurement.Handle, // file guid
ElapsedTime,
Measurement.Identifier
);
} else {
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_PEIM_VARS), mDpHiiHandle,
TIndex, // 1 based, Which measurement record is being printed
- Measurement.Handle, // base address
Measurement.Handle, // file guid
ElapsedTime
);
}
}
@@ -744,11 +778,11 @@ ProcessGlobal(
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_DASHES), mDpHiiHandle);
Index = 1;
LogEntryKey = 0;
- while ((LogEntryKey = GetPerformanceMeasurementEx (
+ while ((LogEntryKey = GetPerformanceMeasurementRecord (
LogEntryKey,
&Measurement.Handle,
&Measurement.Token,
&Measurement.Module,
&Measurement.StartTimeStamp,
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpUtilities.c b/ShellPkg/DynamicCommand/DpDynamicCommand/DpUtilities.c
index b98ec4b..39f71a0 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpUtilities.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpUtilities.c
@@ -1,9 +1,9 @@
/** @file
Utility functions used by the Dp application.
- Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -69,26 +69,12 @@ GetDuration (
if (Measurement->EndTimeStamp == 0) {
return 0;
}
- // PERF_START macros are called with a value of 1 to indicate
- // the beginning of time. So, adjust the start ticker value
- // to the real beginning of time.
- // Assumes no wraparound. Even then, there is a very low probability
- // of having a valid StartTicker value of 1.
- if (Measurement->StartTimeStamp == 1) {
- Measurement->StartTimeStamp = TimerInfo.StartCount;
- }
- if (TimerInfo.CountUp) {
- Duration = Measurement->EndTimeStamp - Measurement->StartTimeStamp;
- Error = (BOOLEAN)(Duration > Measurement->EndTimeStamp);
- }
- else {
- Duration = Measurement->StartTimeStamp - Measurement->EndTimeStamp;
- Error = (BOOLEAN)(Duration > Measurement->StartTimeStamp);
- }
+ Duration = Measurement->EndTimeStamp - Measurement->StartTimeStamp;
+ Error = (BOOLEAN)(Duration > Measurement->EndTimeStamp);
if (Error) {
DEBUG ((EFI_D_ERROR, ALit_TimerLibError));
Duration = 0;
}
@@ -111,15 +97,15 @@ IsPhase(
IN MEASUREMENT_RECORD *Measurement
)
{
BOOLEAN RetVal;
- RetVal = (BOOLEAN)( ( *Measurement->Module == '\0') &&
- ((AsciiStrnCmp (Measurement->Token, ALit_SEC, PERF_TOKEN_LENGTH) == 0) ||
- (AsciiStrnCmp (Measurement->Token, ALit_PEI, PERF_TOKEN_LENGTH) == 0) ||
- (AsciiStrnCmp (Measurement->Token, ALit_DXE, PERF_TOKEN_LENGTH) == 0) ||
- (AsciiStrnCmp (Measurement->Token, ALit_BDS, PERF_TOKEN_LENGTH) == 0))
+ RetVal = (BOOLEAN)(
+ ((AsciiStrCmp (Measurement->Token, ALit_SEC) == 0) ||
+ (AsciiStrCmp (Measurement->Token, ALit_PEI) == 0) ||
+ (AsciiStrCmp (Measurement->Token, ALit_DXE) == 0) ||
+ (AsciiStrCmp (Measurement->Token, ALit_BDS) == 0))
);
return RetVal;
}
/**
@@ -376,14 +362,11 @@ DpGetNameFromHandle (
UINT64
DurationInMicroSeconds (
IN UINT64 Duration
)
{
- UINT64 Temp;
-
- Temp = MultU64x32 (Duration, 1000);
- return DivU64x32 (Temp, TimerInfo.Frequency);
+ return DivU64x32 (Duration, 1000);
}
/**
Get index of Measurement Record's match in the CumData array.
@@ -403,11 +386,11 @@ GetCumulativeItem(
)
{
INTN Index;
for( Index = 0; Index < (INTN)NumCum; ++Index) {
- if (AsciiStrnCmp (Measurement->Token, CumData[Index].Name, PERF_TOKEN_LENGTH) == 0) {
+ if (AsciiStrCmp (Measurement->Token, CumData[Index].Name) == 0) {
return Index; // Exit, we found a match
}
}
// If the for loop exits, Token was not found.
return -1; // Indicate failure
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Literals.c b/ShellPkg/DynamicCommand/DpDynamicCommand/Literals.c
index c1cddfb..69dfc57 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Literals.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Literals.c
@@ -1,22 +1,28 @@
/** @file
Definitions of ASCII string literals used by DP.
- Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
**/
-#include <PerformanceTokens.h>
+#include <Guid/ExtendedFirmwarePerformance.h>
// ASCII String literals which probably don't need translation
-CHAR8 const ALit_TimerLibError[] = "Timer library instance error!\n";
-CHAR8 const ALit_SEC[] = SEC_TOK;
-CHAR8 const ALit_DXE[] = DXE_TOK;
-CHAR8 const ALit_PEI[] = PEI_TOK;
-CHAR8 const ALit_BDS[] = BDS_TOK;
-CHAR8 const ALit_BdsTO[] = "BdsTimeOut";
-CHAR8 const ALit_PEIM[] = "PEIM";
+CHAR8 const ALit_TimerLibError[] = "Timer library instance error!\n";
+CHAR8 const ALit_SEC[] = SEC_TOK;
+CHAR8 const ALit_DXE[] = DXE_TOK;
+CHAR8 const ALit_PEI[] = PEI_TOK;
+CHAR8 const ALit_BDS[] = BDS_TOK;
+CHAR8 const ALit_START_IMAGE[] = START_IMAGE_TOK;
+CHAR8 const ALit_LOAD_IMAGE[] = LOAD_IMAGE_TOK;
+CHAR8 const ALit_DB_START[] = DRIVERBINDING_START_TOK;
+CHAR8 const ALit_DB_SUPPORT[] = DRIVERBINDING_SUPPORT_TOK;
+CHAR8 const ALit_DB_STOP[] = DRIVERBINDING_STOP_TOK;
+
+CHAR8 const ALit_BdsTO[] = "BdsTimeOut";
+CHAR8 const ALit_PEIM[] = "PEIM";
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Literals.h b/ShellPkg/DynamicCommand/DpDynamicCommand/Literals.h
index 8aec09c..8695b1e 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Literals.h
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Literals.h
@@ -1,9 +1,9 @@
/** @file
Declarations of ASCII string literals used by DP.
- Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -18,9 +18,15 @@ extern CHAR8 const ALit_TimerLibError[];
extern CHAR8 const ALit_SEC[];
extern CHAR8 const ALit_DXE[];
extern CHAR8 const ALit_SHELL[];
extern CHAR8 const ALit_PEI[];
extern CHAR8 const ALit_BDS[];
+extern CHAR8 const ALit_PEIM[];
+extern CHAR8 const ALit_START_IMAGE[];
+extern CHAR8 const ALit_LOAD_IMAGE[];
+extern CHAR8 const ALit_DB_START[];
+extern CHAR8 const ALit_DB_SUPPORT[];
+extern CHAR8 const ALit_DB_STOP[];
extern CHAR8 const ALit_BdsTO[];
extern CHAR8 const ALit_PEIM[];
#endif // _LITERALS_H_
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/PerformanceTokens.h b/ShellPkg/DynamicCommand/DpDynamicCommand/PerformanceTokens.h
deleted file mode 100644
index bbbc48d..0000000
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/PerformanceTokens.h
+++ /dev/null
@@ -1,28 +0,0 @@
-/** @file
- ASCII String Literals with special meaning to Performance measurement and the Dp utility.
-
-Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
-This program and the accompanying materials
-are licensed and made available under the terms and conditions of the BSD License
-which accompanies this distribution. The full text of the license may be found at
-http://opensource.org/licenses/bsd-license.php
-
-THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
-**/
-
-#ifndef __PERFORMANCE_TOKENS_H__
-#define __PERFORMANCE_TOKENS_H__
-
-#define SEC_TOK "SEC" ///< SEC Phase
-#define DXE_TOK "DXE" ///< DEC Phase
-#define SHELL_TOK "SHELL" ///< Shell Phase
-#define PEI_TOK "PEI" ///< PEI Phase
-#define BDS_TOK "BDS" ///< BDS Phase
-#define DRIVERBINDING_START_TOK "DB:Start:" ///< Driver Binding Start() function call
-#define DRIVERBINDING_SUPPORT_TOK "DB:Support:" ///< Driver Binding Support() function call
-#define LOAD_IMAGE_TOK "LoadImage:" ///< Load a dispatched module
-#define START_IMAGE_TOK "StartImage:" ///< Dispatched Modules Entry Point execution
-
-#endif // __PERFORMANCE_TOKENS_H__
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH v2 1/8] MdeModulePkg:Add definitions for new Performance infrastructure
2018-01-30 13:53 ` [PATCH v2 1/8] MdeModulePkg:Add definitions for new Performance infrastructure Dandan Bi
@ 2018-01-31 2:07 ` Zeng, Star
0 siblings, 0 replies; 21+ messages in thread
From: Zeng, Star @ 2018-01-31 2:07 UTC (permalink / raw)
To: Gao, Liming, Bi, Dandan, edk2-devel@lists.01.org; +Cc: Zeng, Star
A minor comment.
Do you think is it better to add prefix for new definitions in ExtendedFirmwarePerformance.h? Maybe FPDT_ ?
Thanks,
Star
-----Original Message-----
From: Bi, Dandan
Sent: Tuesday, January 30, 2018 9:54 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH v2 1/8] MdeModulePkg:Add definitions for new Performance infrastructure
From: "Gao, Liming" <liming.gao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Include/Guid/ExtendedFirmwarePerformance.h | 291 +++++++++++++++++++++
MdeModulePkg/Include/Guid/FirmwarePerformance.h | 13 +-
MdeModulePkg/MdeModulePkg.dec | 11 +-
MdeModulePkg/MdeModulePkg.uni | 8 +-
4 files changed, 320 insertions(+), 3 deletions(-) create mode 100644 MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h
diff --git a/MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h b/MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h
new file mode 100644
index 0000000..0395495
--- /dev/null
+++ b/MdeModulePkg/Include/Guid/ExtendedFirmwarePerformance.h
@@ -0,0 +1,291 @@
+/** @file
+ This file defines edk2 extended firmware performance records.
+ These records will be added into ACPI FPDT Firmware Basic Boot Performance Table.
+
+Copyright (c) 2018, Intel Corporation. All rights reserved.<BR> This
+program and the accompanying materials are licensed and made available
+under the terms and conditions of the BSD License that accompanies this distribution.
+The full text of the license may be found at
+http://opensource.org/licenses/bsd-license.php.
+
+THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#ifndef __EXTENDED_FIRMWARE_PERFORMANCE_H__
+#define __EXTENDED_FIRMWARE_PERFORMANCE_H__
+
+#include <IndustryStandard/Acpi.h>
+
+//
+// Known performance tokens
+//
+#define SEC_TOK "SEC" ///< SEC Phase
+#define DXE_TOK "DXE" ///< DXE Phase
+#define PEI_TOK "PEI" ///< PEI Phase
+#define BDS_TOK "BDS" ///< BDS Phase
+#define DRIVERBINDING_START_TOK "DB:Start:" ///< Driver Binding Start() function call
+#define DRIVERBINDING_SUPPORT_TOK "DB:Support:" ///< Driver Binding Support() function call
+#define DRIVERBINDING_STOP_TOK "DB:Stop:" ///< Driver Binding Stop() function call
+#define LOAD_IMAGE_TOK "LoadImage:" ///< Load a dispatched module
+#define START_IMAGE_TOK "StartImage:" ///< Dispatched Modules Entry Point execution
+#define PEIM_TOK "PEIM" ///< PEIM Modules Entry Point execution
+
+//
+// Public Progress Identifiers for Event Records to map the above known
+token //
+#define MODULE_START_ID 0x01
+#define MODULE_END_ID 0x02
+#define MODULE_LOADIMAGE_START_ID 0x03
+#define MODULE_LOADIMAGE_END_ID 0x04
+#define MODULE_DB_START_ID 0x05
+#define MODULE_DB_END_ID 0x06
+#define MODULE_DB_SUPPORT_START_ID 0x07
+#define MODULE_DB_SUPPORT_END_ID 0x08
+#define MODULE_DB_STOP_START_ID 0x09
+#define MODULE_DB_STOP_END_ID 0x0A
+
+#define PERF_EVENTSIGNAL_START_ID 0x10
+#define PERF_EVENTSIGNAL_END_ID 0x11
+#define PERF_CALLBACK_START_ID 0x20
+#define PERF_CALLBACK_END_ID 0x21
+#define PERF_FUNCTION_START_ID 0x30
+#define PERF_FUNCTION_END_ID 0x31
+#define PERF_INMODULE_START_ID 0x40
+#define PERF_INMODULE_END_ID 0x41
+#define PERF_CROSSMODULE_START_ID 0x50
+#define PERF_CROSSMODULE_END_ID 0x51
+
+//
+// Misc defines
+//
+#define RECORD_REVISION_1 (0x01)
+
+//
+// Length field in EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER is a UINT8, thus:
+//
+#define MAX_PERF_RECORD_SIZE (MAX_UINT8)
+
+//
+// FPDT Record Types
+//
+#define GUID_EVENT_TYPE 0x1010
+#define DYNAMIC_STRING_EVENT_TYPE 0x1011
+#define DUAL_GUID_STRING_EVENT_TYPE 0x1012
+#define GUID_QWORD_EVENT_TYPE 0x1013
+#define GUID_QWORD_STRING_EVENT_TYPE 0x1014
+
+//
+// EDKII extended Fpdt record structures // #define
+EDKII_STRING_EVENT_RECORD_NAME_LENGTH 24
+
+#pragma pack(1)
+//
+// FPDT Boot Performance Guid Event Record Structure // typedef struct
+{
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER Header;
+ ///
+ /// ProgressID < 0x10 are reserved for core performance entries.
+ /// Start measurement point shall have lowered one nibble set to zero
+and
+ /// corresponding end points shall have lowered one nibble set to
+non-zero value;
+ /// keeping other nibbles same as start point.
+ ///
+ UINT16 ProgressID;
+ ///
+ /// APIC ID for the processor in the system used as a timestamp clock source.
+ /// If only one timestamp clock source is used, this field is Reserved and populated as 0.
+ ///
+ UINT32 ApicID;
+ ///
+ /// 64-bit value (nanosecond) describing elapsed time since the most recent deassertion of processor reset.
+ ///
+ UINT64 Timestamp;
+ ///
+ /// If ProgressID < 0x10, GUID of the referenced module; otherwise, GUID of the module logging the event.
+ ///
+ EFI_GUID Guid;
+} GUID_EVENT_RECORD;
+
+//
+// FPDT Boot Performance Dynamic String Event Record Structure //
+typedef struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER Header;
+ ///
+ /// ProgressID < 0x10 are reserved for core performance entries.
+ /// Start measurement point shall have lowered one nibble set to zero
+and
+ /// corresponding end points shall have lowered one nibble set to
+non-zero value;
+ /// keeping other nibbles same as start point.
+ ///
+ UINT16 ProgressID;
+ ///
+ /// APIC ID for the processor in the system used as a timestamp clock source.
+ /// If only one timestamp clock source is used, this field is Reserved and populated as 0.
+ ///
+ UINT32 ApicID;
+ ///
+ /// 64-bit value (nanosecond) describing elapsed time since the most recent deassertion of processor reset.
+ ///
+ UINT64 Timestamp;
+ ///
+ /// If ProgressID < 0x10, GUID of the referenced module; otherwise, GUID of the module logging the event.
+ ///
+ EFI_GUID Guid;
+ ///
+ /// ASCII string describing the module. Padding supplied at the end if necessary with null characters (0x00).
+ /// It may be module name, function name, or token name.
+ ///
+ CHAR8 String[0];
+} DYNAMIC_STRING_EVENT_RECORD;
+
+//
+// FPDT Boot Performance Dual GUID String Event Record Structure //
+typedef struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER Header;
+ ///
+ /// ProgressID < 0x10 are reserved for core performance entries.
+ /// Start measurement point shall have lowered one nibble set to zero
+and
+ /// corresponding end points shall have lowered one nibble set to
+non-zero value;
+ /// keeping other nibbles same as start point.
+ ///
+ UINT16 ProgressID;
+ ///
+ /// APIC ID for the processor in the system used as a timestamp clock source.
+ /// If only one timestamp clock source is used, this field is Reserved and populated as 0.
+ ///
+ UINT32 ApicID;
+ ///
+ /// 64-bit value (nanosecond) describing elapsed time since the most recent deassertion of processor reset.
+ ///
+ UINT64 Timestamp;
+ ///
+ /// GUID of the module logging the event.
+ ///
+ EFI_GUID Guid1;
+ ///
+ /// Event or Ppi or Protocol GUID for Callback.
+ ///
+ EFI_GUID Guid2;
+ ///
+ /// ASCII string describing the module. Padding supplied at the end if necessary with null characters (0x00).
+ /// It is the function name.
+ ///
+ CHAR8 String[0];
+} DUAL_GUID_STRING_EVENT_RECORD;
+
+//
+// FPDT Boot Performance GUID Qword Event Record Structure // typedef
+struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER Header;
+ ///
+ /// ProgressID < 0x10 are reserved for core performance entries.
+ /// Start measurement point shall have lowered one nibble set to zero
+and
+ /// corresponding end points shall have lowered one nibble set to
+non-zero value;
+ /// keeping other nibbles same as start point.
+ ///
+ UINT16 ProgressID;
+ ///
+ /// APIC ID for the processor in the system used as a timestamp clock source.
+ /// If only one timestamp clock source is used, this field is Reserved and populated as 0.
+ ///
+ UINT32 ApicID;
+ ///
+ /// 64-bit value (nanosecond) describing elapsed time since the most recent deassertion of processor reset.
+ ///
+ UINT64 Timestamp;
+ ///
+ /// GUID of the module logging the event
+ ///
+ EFI_GUID Guid;
+ ///
+ /// Qword of misc data, meaning depends on the ProgressId
+ ///
+ UINT64 Qword;
+} GUID_QWORD_EVENT_RECORD;
+
+//
+// FPDT Boot Performance GUID Qword String Event Record Structure //
+typedef struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER Header;
+ ///
+ /// ProgressID < 0x10 are reserved for core performance entries.
+ /// Start measurement point shall have lowered one nibble set to zero
+and
+ /// corresponding end points shall have lowered one nibble set to
+non-zero value;
+ /// keeping other nibbles same as start point.
+ ///
+ UINT16 ProgressID;
+ ///
+ /// APIC ID for the processor in the system used as a timestamp clock source.
+ /// If only one timestamp clock source is used, this field is Reserved and populated as 0.
+ ///
+ UINT32 ApicID;
+ ///
+ /// 64-bit value (nanosecond) describing elapsed time since the most recent deassertion of processor reset.
+ ///
+ UINT64 Timestamp;
+ ///
+ /// GUID of the module logging the event
+ ///
+ EFI_GUID Guid;
+ ///
+ /// Qword of misc data, meaning depends on the ProgressId
+ ///
+ UINT64 Qword;
+ ///
+ /// ASCII string describing the module. Padding supplied at the end if necessary with null characters (0x00).
+ ///
+ CHAR8 String[0];
+} GUID_QWORD_STRING_EVENT_RECORD;
+
+#pragma pack()
+
+typedef struct {
+ UINT16 ProgressID;
+ UINT16 Type;
+ UINT8 RecordSize;
+} BASIC_RECORD_INFO;
+
+//
+// Union of all FPDT records
+//
+typedef union {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER RecordHeader;
+ GUID_EVENT_RECORD GuidEvent;
+ DYNAMIC_STRING_EVENT_RECORD DynamicStringEvent;
+ DUAL_GUID_STRING_EVENT_RECORD DualGuidStringEvent;
+ GUID_QWORD_EVENT_RECORD GuidQwordEvent;
+ GUID_QWORD_STRING_EVENT_RECORD GuidQwordStringEvent;
+} FPDT_RECORD;
+
+//
+// Union of all pointers to FPDT records // typedef union {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *RecordHeader;
+ GUID_EVENT_RECORD *GuidEvent;
+ DYNAMIC_STRING_EVENT_RECORD *DynamicStringEvent;
+ DUAL_GUID_STRING_EVENT_RECORD *DualGuidStringEvent;
+ GUID_QWORD_EVENT_RECORD *GuidQwordEvent;
+ GUID_QWORD_STRING_EVENT_RECORD *GuidQwordStringEvent;
+} FPDT_RECORD_PTR;
+
+///
+/// Hob:
+/// GUID - gEdkiiExtendedFirmwarePerformanceGuid
+/// Data - PEI_EXT_FIRMWARE_PERF_HEADER + one or more FPDT records
+///
+typedef struct {
+ UINT32 SizeOfAllEntries;
+ UINT32 LoadImageCount;
+ UINT32 HobIsFull;
+} PEI_EXT_FIRMWARE_PERF_HEADER;
+
+extern EFI_GUID gEdkiiExtendedFirmwarePerformanceGuid;
+
+#endif
diff --git a/MdeModulePkg/Include/Guid/FirmwarePerformance.h b/MdeModulePkg/Include/Guid/FirmwarePerformance.h
index 4697a2c..1495a46 100644
--- a/MdeModulePkg/Include/Guid/FirmwarePerformance.h
+++ b/MdeModulePkg/Include/Guid/FirmwarePerformance.h
@@ -1,9 +1,9 @@
/** @file
ACPI Firmware Performance Data Table (FPDT) implementation specific definitions.
- Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2011 - 2018, Intel Corporation. All rights
+ reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -93,10 +93,21 @@ typedef struct {
// one or more boot performance records.
//
} BOOT_PERFORMANCE_TABLE;
///
+/// Boot performance table for the performance record in SMM phase.
+///
+///
+typedef struct {
+ EFI_ACPI_5_0_FPDT_PERFORMANCE_TABLE_HEADER Header; ///< Common ACPI table header.
+ //
+ // one or more boot performance records.
+ //
+} SMM_BOOT_PERFORMANCE_TABLE;
+
+///
/// Performance data pointed by Performance Pointer Record.
///
typedef struct {
BOOT_PERFORMANCE_TABLE BootPerformance; ///< Basic Boot Performance.
S3_PERFORMANCE_TABLE S3Performance; ///< S3 performance.
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 0298bed..6819307 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -390,10 +390,13 @@
gEdkiiNonDiscoverableXhciDeviceGuid = { 0xB1BE0BC5, 0x6C28, 0x442D, {0xAA, 0x37, 0x15, 0x1B, 0x42, 0x57, 0xBD, 0x78 } }
## Include/Guid/PlatformHasAcpi.h
gEdkiiPlatformHasAcpiGuid = { 0xf0966b41, 0xc23f, 0x41b9, { 0x96, 0x04, 0x0f, 0xf7, 0xe1, 0x11, 0x96, 0x5a } }
+ ## Include/Guid/ExtendedFirmwarePerformance.h
+ gEdkiiExtendedFirmwarePerformanceGuid = { 0x3b387bfd, 0x7abc, 0x4cf2,
+ { 0xa0, 0xca, 0xb6, 0xa1, 0x6c, 0x1b, 0x1b, 0x25 } }
+
## Include/Guid/EndofS3Resume.h
gEdkiiEndOfS3ResumeGuid = { 0x96f5296d, 0x05f7, 0x4f3c, {0x84, 0x67, 0xe4, 0x56, 0x89, 0x0e, 0x0c, 0xb5 } }
[Ppis]
## Include/Ppi/AtaController.h
@@ -1404,10 +1407,16 @@
## CapsuleMax value in capsule report variable.
# @Prompt CapsuleMax value in capsule report variable.
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax|0xFFFF|UINT16|0x00000107
+ ## Control which FPDT record format will be used to store the performance entry.
+ # On TRUE, the string FPDT record will be used to store every performance entry.
+ # On FALSE, the different FPDT record will be used to store the different performance entries.
+ # @Prompt String FPDT Record Enable Only
+
+ gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly|FALS
+ E|BOOLEAN|0x00000109
+
[PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
## This PCD defines the Console output row. The default value is 25 according to UEFI spec.
# This PCD could be set to 0 then console output would be at max column and max row.
# @Prompt Console output row.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|25|UINT32|0x40000006
@@ -1703,11 +1712,11 @@
gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x3|UINT32|0x00010069
## This PCD specifies the additional pad size in FPDT Basic Boot Performance Table for
# the extension FPDT boot records received after ReadyToBoot and before ExitBootService.
# @Prompt Pad size for extension FPDT boot records.
- gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize|0x0|UINT32|0x0001005F
+
+ gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize|0x20000|UIN
+ T32|0x0001005F
## Indicates if ConIn device are connected on demand.<BR><BR>
# TRUE - ConIn device are not connected during BDS and ReadKeyStroke/ReadKeyStrokeEx produced
# by Consplitter should be called before any real key read operation.<BR>
# FALSE - ConIn device may be connected normally during BDS.<BR>
diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index 0e06842..dacd671 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -2,11 +2,11 @@
// This package provides the modules that conform to UEFI/PI Industry standards.
//
// It also provides the definitions(including PPIs/PROTOCOLs/GUIDs and library classes) // and libraries instances, which are used for those modules.
//
-// Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR>
+// Copyright (c) 2007 - 2018, Intel Corporation. All rights
+reserved.<BR>
//
// This program and the accompanying materials are licensed and made available under // the terms and conditions of the BSD License that accompanies this distribution.
// The full text of the license may be found at // http://opensource.org/licenses/bsd-license.php.
@@ -1230,5 +1230,11 @@
" When its value is set in PEI, it will trig the default setting to be applied as the default EFI variable.\n"
#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdNvStoreDefaultValueBuffer_PROMPT #language en-US "NV Storage Default Value Buffer"
#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdNvStoreDefaultValueBuffer_HELP #language en-US "This dynamic PCD holds the DynamicHii PCD value. Its value is the auto generated.\n"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEdkiiFpdtStringRecordEnableOnly_PROMPT #language en-US "String FPDT Record Enable Only"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEdkiiFpdtStringRecordEnableOnly_HELP #language en-US "Control which FPDT record format will be used to store the performance entry.\n"
+ "On TRUE, the string FPDT record will be used to store every performance entry.\n"
+ "On FALSE, the different FPDT record will be used to store the different performance entries."
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-01-30 13:53 ` [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase Dandan Bi
@ 2018-05-01 16:26 ` Ard Biesheuvel
2018-05-22 0:33 ` Bi, Dandan
0 siblings, 1 reply; 21+ messages in thread
From: Ard Biesheuvel @ 2018-05-01 16:26 UTC (permalink / raw)
To: Dandan Bi, Leif Lindholm
Cc: edk2-devel@lists.01.org, Star Zeng, Liming Gao, Matt Sealey
On 30 January 2018 at 14:53, Dandan Bi <dandan.bi@intel.com> wrote:
> V2:
> Update DxecorePerformanceLib to report the boot performance table
> address instead of records contents.
>
> Updated to convert Pref entry to FPDT record in DXE phase and then
> allocate boot performance table to save the record and report
> the address of boot performance table to FirmwarePerformanceDxe.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 1389 +++++++++++++++-----
> .../DxeCorePerformanceLib.inf | 20 +-
> .../DxeCorePerformanceLibInternal.h | 17 +-
> 3 files changed, 1108 insertions(+), 318 deletions(-)
>
> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> index 7c0e207..c6f8a16 100644
> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> @@ -8,11 +8,11 @@
> which are consumed by DxePerformanceLib to logging performance data in DXE phase.
>
> This library is mainly used by DxeCore to start performance logging to ensure that
> Performance Protocol is installed at the very beginning of DXE phase.
>
> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> which accompanies this distribution. The full text of the license may be found at
> http://opensource.org/licenses/bsd-license.php
> @@ -23,27 +23,65 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> **/
>
>
> #include "DxeCorePerformanceLibInternal.h"
>
> -
> //
> -// The data structure to hold global performance data.
> +// Data for FPDT performance records.
> //
> -GAUGE_DATA_HEADER *mGaugeData;
> +#define SMM_BOOT_RECORD_COMM_SIZE (OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + sizeof(SMM_BOOT_RECORD_COMMUNICATE))
> +#define STRING_SIZE (EDKII_STRING_EVENT_RECORD_NAME_LENGTH * sizeof (CHAR8))
> +#define MAX_RECORD_SIZE (sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE)
> +#define FIRMWARE_RECORD_BUFFER 0x10000
> +#define CACHE_HANDLE_GUID_COUNT 0x1000
> +
> +BOOT_PERFORMANCE_TABLE *mAcpiBootPerformanceTable = NULL;
> +BOOT_PERFORMANCE_TABLE mBootPerformanceTableTemplate = {
> + {
> + EFI_ACPI_5_0_FPDT_BOOT_PERFORMANCE_TABLE_SIGNATURE,
> + sizeof (BOOT_PERFORMANCE_TABLE)
> + },
> + {
> + {
> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_TYPE_FIRMWARE_BASIC_BOOT, // Type
> + sizeof (EFI_ACPI_5_0_FPDT_FIRMWARE_BASIC_BOOT_RECORD), // Length
> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_REVISION_FIRMWARE_BASIC_BOOT // Revision
> + },
> + 0, // Reserved
> + //
> + // These values will be updated at runtime.
> + //
> + 0, // ResetEnd
> + 0, // OsLoaderLoadImageStart
> + 0, // OsLoaderStartImageStart
> + 0, // ExitBootServicesEntry
> + 0 // ExitBootServicesExit
> + }
> +};
>
> -//
> -// The current maximum number of logging entries. If current number of
> -// entries exceeds this value, it will re-allocate a larger array and
> -// migration the old data to the larger array.
> -//
> -UINT32 mMaxGaugeRecords;
> +typedef struct {
> + EFI_HANDLE Handle;
> + CHAR8 NameString[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
> + EFI_GUID ModuleGuid;
> +} HANDLE_GUID_MAP;
>
> -//
> -// The handle to install Performance Protocol instance.
> -//
> -EFI_HANDLE mHandle = NULL;
> +HANDLE_GUID_MAP mCacheHandleGuidTable[CACHE_HANDLE_GUID_COUNT];
> +UINTN mCachePairCount = 0;
> +
> +UINT32 mLoadImageCount = 0;
> +UINT32 mPerformanceLength = 0;
> +UINT32 mMaxPerformanceLength = 0;
> +UINT32 mBootRecordSize = 0;
> +UINT32 mBootRecordMaxSize = 0;
> +
> +BOOLEAN mFpdtBufferIsReported = FALSE;
> +BOOLEAN mLackSpaceIsReported = FALSE;
> +CHAR8 *mPlatformLanguage = NULL;
> +UINT8 *mPerformancePointer = NULL;
> +UINT8 *mBootRecordBuffer = NULL;
> +
> +EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *mDevicePathToText = NULL;
>
> //
> // Interfaces for Performance Protocol.
> //
> PERFORMANCE_PROTOCOL mPerformanceInterface = {
> @@ -61,179 +99,1069 @@ PERFORMANCE_EX_PROTOCOL mPerformanceExInterface = {
> GetGaugeEx
> };
>
> PERFORMANCE_PROPERTY mPerformanceProperty;
>
> -//
> -// Gauge record lock to avoid data corruption or even memory overflow
> -//
> -STATIC EFI_LOCK mPerfRecordLock = EFI_INITIALIZE_LOCK_VARIABLE (TPL_NOTIFY);
> +/**
> +Check whether the Token is a known one which is uesed by core.
> +
> +@param Token Pointer to a Null-terminated ASCII string
> +
> +@retval TRUE Is a known one used by core.
> +@retval FALSE Not a known one.
> +
> +**/
> +BOOLEAN
> +IsKnownTokens (
> + IN CONST CHAR8 *Token
> + )
> +{
> + if (AsciiStrCmp (Token, SEC_TOK) == 0 ||
> + AsciiStrCmp (Token, PEI_TOK) == 0 ||
> + AsciiStrCmp (Token, DXE_TOK) == 0 ||
> + AsciiStrCmp (Token, BDS_TOK) == 0 ||
> + AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0 ||
> + AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0 ||
> + AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0 ||
> + AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0 ||
> + AsciiStrCmp (Token, START_IMAGE_TOK) == 0 ||
> + AsciiStrCmp (Token, PEIM_TOK) == 0) {
> + return TRUE;
> + } else {
> + return FALSE;
> + }
> +}
> +
> +/**
> +Check whether the ID is a known one which map to the known Token.
> +
> +@param Identifier 32-bit identifier.
> +
> +@retval TRUE Is a known one used by core.
> +@retval FALSE Not a known one.
> +
> +**/
> +BOOLEAN
> +IsKnownID (
> + IN UINT32 Identifier
> + )
> +{
> + if (Identifier == MODULE_START_ID ||
> + Identifier == MODULE_END_ID ||
> + Identifier == MODULE_LOADIMAGE_START_ID ||
> + Identifier == MODULE_LOADIMAGE_END_ID ||
> + Identifier == MODULE_DB_START_ID ||
> + Identifier == MODULE_DB_END_ID ||
> + Identifier == MODULE_DB_SUPPORT_START_ID ||
> + Identifier == MODULE_DB_SUPPORT_END_ID ||
> + Identifier == MODULE_DB_STOP_START_ID ||
> + Identifier == MODULE_DB_STOP_END_ID) {
> + return TRUE;
> + } else {
> + return FALSE;
> + }
> +}
>
> /**
> - Searches in the gauge array with keyword Handle, Token, Module and Identifier.
> + Allocate EfiReservedMemoryType below 4G memory address.
> +
> + This function allocates EfiReservedMemoryType below 4G memory address.
> +
> + @param[in] Size Size of memory to allocate.
> +
> + @return Allocated address for output.
> +
> +**/
> +VOID *
> +FpdtAllocateReservedMemoryBelow4G (
> + IN UINTN Size
> + )
> +{
> + UINTN Pages;
> + EFI_PHYSICAL_ADDRESS Address;
> + EFI_STATUS Status;
> + VOID *Buffer;
> +
> + Buffer = NULL;
> + Pages = EFI_SIZE_TO_PAGES (Size);
> + Address = 0xffffffff;
> +
> + Status = gBS->AllocatePages (
> + AllocateMaxAddress,
> + EfiReservedMemoryType,
> + Pages,
> + &Address
> + );
> + ASSERT_EFI_ERROR (Status);
This code is breaking DEBUG builds on ARM systems that have no memory
below 4 GB.
> +
> + if (!EFI_ERROR (Status)) {
> + Buffer = (VOID *) (UINTN) Address;
> + ZeroMem (Buffer, Size);
> + }
> +
> + return Buffer;
> +}
> +
> +/**
> + Allocate buffer for Boot Performance table.
> +
> + @return Status code.
> +
> +**/
> +EFI_STATUS
> +AllocateBootPerformanceTable (
> + )
> +{
> + EFI_STATUS Status;
> + UINTN Size;
> + UINT8 *SmmBootRecordCommBuffer;
> + EFI_SMM_COMMUNICATE_HEADER *SmmCommBufferHeader;
> + SMM_BOOT_RECORD_COMMUNICATE *SmmCommData;
> + UINTN CommSize;
> + UINTN BootPerformanceDataSize;
> + UINT8 *BootPerformanceData;
> + EFI_SMM_COMMUNICATION_PROTOCOL *Communication;
> + FIRMWARE_PERFORMANCE_VARIABLE PerformanceVariable;
> + EDKII_PI_SMM_COMMUNICATION_REGION_TABLE *SmmCommRegionTable;
> + EFI_MEMORY_DESCRIPTOR *SmmCommMemRegion;
> + UINTN Index;
> + VOID *SmmBootRecordData;
> + UINTN SmmBootRecordDataSize;
> + UINTN ReservedMemSize;
> +
> + //
> + // Collect boot records from SMM drivers.
> + //
> + SmmBootRecordCommBuffer = NULL;
> + SmmCommData = NULL;
> + SmmBootRecordData = NULL;
> + SmmBootRecordDataSize = 0;
> + ReservedMemSize = 0;
> + Status = gBS->LocateProtocol (&gEfiSmmCommunicationProtocolGuid, NULL, (VOID **) &Communication);
> + if (!EFI_ERROR (Status)) {
> + //
> + // Initialize communicate buffer
> + // Get the prepared Reserved Memory Range
> + //
> + Status = EfiGetSystemConfigurationTable (
> + &gEdkiiPiSmmCommunicationRegionTableGuid,
> + (VOID **) &SmmCommRegionTable
> + );
> + if (!EFI_ERROR (Status)) {
> + ASSERT (SmmCommRegionTable != NULL);
> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) (SmmCommRegionTable + 1);
> + for (Index = 0; Index < SmmCommRegionTable->NumberOfEntries; Index ++) {
> + if (SmmCommMemRegion->Type == EfiConventionalMemory) {
> + break;
> + }
> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) ((UINT8 *) SmmCommMemRegion + SmmCommRegionTable->DescriptorSize);
> + }
> + ASSERT (Index < SmmCommRegionTable->NumberOfEntries);
> + ASSERT (SmmCommMemRegion->PhysicalStart > 0);
> + ASSERT (SmmCommMemRegion->NumberOfPages > 0);
> + ReservedMemSize = (UINTN) SmmCommMemRegion->NumberOfPages * EFI_PAGE_SIZE;
> +
> + //
> + // Check enough reserved memory space
> + //
> + if (ReservedMemSize > SMM_BOOT_RECORD_COMM_SIZE) {
> + SmmBootRecordCommBuffer = (VOID *) (UINTN) SmmCommMemRegion->PhysicalStart;
> + SmmCommBufferHeader = (EFI_SMM_COMMUNICATE_HEADER*)SmmBootRecordCommBuffer;
> + SmmCommData = (SMM_BOOT_RECORD_COMMUNICATE*)SmmCommBufferHeader->Data;
> + ZeroMem((UINT8*)SmmCommData, sizeof(SMM_BOOT_RECORD_COMMUNICATE));
> +
> + CopyGuid (&SmmCommBufferHeader->HeaderGuid, &gEfiFirmwarePerformanceGuid);
> + SmmCommBufferHeader->MessageLength = sizeof(SMM_BOOT_RECORD_COMMUNICATE);
> + CommSize = SMM_BOOT_RECORD_COMM_SIZE;
> +
> + //
> + // Get the size of boot records.
> + //
> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_SIZE;
> + SmmCommData->BootRecordData = NULL;
> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
> + ASSERT_EFI_ERROR (Status);
> +
> + if (!EFI_ERROR (SmmCommData->ReturnStatus) && SmmCommData->BootRecordSize != 0) {
> + //
> + // Get all boot records
> + //
> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
> + SmmBootRecordDataSize = SmmCommData->BootRecordSize;
> + SmmBootRecordData = AllocateZeroPool(SmmBootRecordDataSize);
> + ASSERT (SmmBootRecordData != NULL);
> + SmmCommData->BootRecordOffset = 0;
> + SmmCommData->BootRecordData = (VOID *) ((UINTN) SmmCommMemRegion->PhysicalStart + SMM_BOOT_RECORD_COMM_SIZE);
> + SmmCommData->BootRecordSize = ReservedMemSize - SMM_BOOT_RECORD_COMM_SIZE;
> + while (SmmCommData->BootRecordOffset < SmmBootRecordDataSize) {
> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
> + ASSERT_EFI_ERROR (Status);
> + ASSERT_EFI_ERROR(SmmCommData->ReturnStatus);
> + if (SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize > SmmBootRecordDataSize) {
> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmBootRecordDataSize - SmmCommData->BootRecordOffset);
> + } else {
> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmCommData->BootRecordSize);
> + }
> + SmmCommData->BootRecordOffset = SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize;
> + }
> + }
> + }
> + }
> + }
> +
> + //
> + // Prepare memory for Boot Performance table.
> + // Boot Performance table includes BasicBoot record, and one or more appended Boot Records.
> + //
> + BootPerformanceDataSize = sizeof (BOOT_PERFORMANCE_TABLE) + mPerformanceLength + PcdGet32 (PcdExtFpdtBootRecordPadSize);
> + if (SmmCommData != NULL) {
> + BootPerformanceDataSize += SmmBootRecordDataSize;
> + }
> +
> + //
> + // Try to allocate the same runtime buffer as last time boot.
> + //
> + ZeroMem (&PerformanceVariable, sizeof (PerformanceVariable));
> + Size = sizeof (PerformanceVariable);
> + Status = gRT->GetVariable (
> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
> + &gEfiFirmwarePerformanceGuid,
> + NULL,
> + &Size,
> + &PerformanceVariable
> + );
> + if (!EFI_ERROR (Status)) {
> + Status = gBS->AllocatePages (
> + AllocateAddress,
> + EfiReservedMemoryType,
> + EFI_SIZE_TO_PAGES (BootPerformanceDataSize),
> + &PerformanceVariable.BootPerformanceTablePointer
> + );
> + if (!EFI_ERROR (Status)) {
> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) (UINTN) PerformanceVariable.BootPerformanceTablePointer;
> + }
> + }
> +
> + if (mAcpiBootPerformanceTable == NULL) {
> + //
> + // Fail to allocate at specified address, continue to allocate at any address.
> + //
> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) FpdtAllocateReservedMemoryBelow4G (BootPerformanceDataSize);
Why does this allocation need to live below 4 GB?
If there is no good reason, can we please get rid of this?
If there is a good reason, can we please document it in the code?
> + }
> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: ACPI Boot Performance Table address = 0x%x\n", mAcpiBootPerformanceTable));
> +
> + if (mAcpiBootPerformanceTable == NULL) {
> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
> + FreePool (SmmBootRecordData);
> + }
> + return EFI_OUT_OF_RESOURCES;
> + }
> +
> + //
> + // Prepare Boot Performance Table.
> + //
> + BootPerformanceData = (UINT8 *) mAcpiBootPerformanceTable;
> + //
> + // Fill Basic Boot record to Boot Performance Table.
> + //
> + CopyMem (mAcpiBootPerformanceTable, &mBootPerformanceTableTemplate, sizeof (mBootPerformanceTableTemplate));
> + BootPerformanceData = BootPerformanceData + mAcpiBootPerformanceTable->Header.Length;
> + //
> + // Fill Boot records from boot drivers.
> + //
> + if (mPerformancePointer != NULL) {
> + CopyMem (BootPerformanceData, mPerformancePointer, mPerformanceLength);
> + mAcpiBootPerformanceTable->Header.Length += mPerformanceLength;
> + BootPerformanceData = BootPerformanceData + mPerformanceLength;
> + }
> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
> + //
> + // Fill Boot records from SMM drivers.
> + //
> + CopyMem (BootPerformanceData, SmmBootRecordData, SmmBootRecordDataSize);
> + FreePool (SmmBootRecordData);
> + mAcpiBootPerformanceTable->Header.Length = (UINT32) (mAcpiBootPerformanceTable->Header.Length + SmmBootRecordDataSize);
> + BootPerformanceData = BootPerformanceData + SmmBootRecordDataSize;
> + }
> +
> + //
> + // Save Boot Performance Table address to Variable for use in S4 resume.
> + //
> + PerformanceVariable.BootPerformanceTablePointer = (EFI_PHYSICAL_ADDRESS) (UINTN) mAcpiBootPerformanceTable;
> +
> + //
> + // Save Runtime Performance Table pointers to Variable.
> + // Don't check SetVariable return status. It doesn't impact FPDT table generation.
> + //
> + gRT->SetVariable (
> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
> + &gEfiFirmwarePerformanceGuid,
> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
> + sizeof (PerformanceVariable),
> + &PerformanceVariable
> + );
> +
> + mBootRecordBuffer = (UINT8 *) mAcpiBootPerformanceTable;
> + mBootRecordSize = mAcpiBootPerformanceTable->Header.Length;
> + mBootRecordMaxSize = mBootRecordSize + PcdGet32 (PcdExtFpdtBootRecordPadSize);
> +
> + return EFI_SUCCESS;
> +}
> +
> +/**
> + Get a human readable module name and module guid for the given image handle.
> + If module name can't be found, "" string will return.
> + If module guid can't be found, Zero Guid will return.
> +
> + @param Handle Image handle or Controller handle.
> + @param NameString The ascii string will be filled into it. If not found, null string will return.
> + @param BufferSize Size of the input NameString buffer.
> + @param ModuleGuid Point to the guid buffer to store the got module guid value.
> +
> + @retval EFI_SUCCESS Successfully get module name and guid.
> + @retval EFI_INVALID_PARAMETER The input parameter NameString is NULL.
> + @retval other value Module Name can't be got.
> +**/
> +EFI_STATUS
> +GetModuleInfoFromHandle (
> + IN EFI_HANDLE Handle,
> + OUT CHAR8 *NameString,
> + IN UINTN BufferSize,
> + OUT EFI_GUID *ModuleGuid OPTIONAL
> + )
> +{
> + EFI_STATUS Status;
> + EFI_LOADED_IMAGE_PROTOCOL *LoadedImage;
> + EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
> + CHAR8 *PdbFileName;
> + EFI_GUID *TempGuid;
> + UINTN StartIndex;
> + UINTN Index;
> + INTN Count;
> + BOOLEAN ModuleGuidIsGet;
> + UINTN StringSize;
> + CHAR16 *StringPtr;
> + EFI_COMPONENT_NAME2_PROTOCOL *ComponentName2;
> + MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *FvFilePath;
> +
> + if (NameString == NULL || BufferSize == 0) {
> + return EFI_INVALID_PARAMETER;
> + }
> + //
> + // Try to get the ModuleGuid and name string form the caached array.
> + //
> + if (mCachePairCount > 0) {
> + for (Count = mCachePairCount -1; Count >= 0; Count--) {
> + if (Handle == mCacheHandleGuidTable[Count].Handle) {
> + CopyGuid (ModuleGuid, &mCacheHandleGuidTable[Count].ModuleGuid);
> + AsciiStrCpyS (NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, mCacheHandleGuidTable[Count].NameString);
> + return EFI_SUCCESS;
> + }
> + }
> + }
> +
> + Status = EFI_INVALID_PARAMETER;
> + LoadedImage = NULL;
> + ModuleGuidIsGet = FALSE;
> +
> + //
> + // Initialize GUID as zero value.
> + //
> + TempGuid = &gZeroGuid;
> + //
> + // Initialize it as "" string.
> + //
> + NameString[0] = 0;
> +
> + if (Handle != NULL) {
> + //
> + // Try Handle as ImageHandle.
> + //
> + Status = gBS->HandleProtocol (
> + Handle,
> + &gEfiLoadedImageProtocolGuid,
> + (VOID**) &LoadedImage
> + );
> +
> + if (EFI_ERROR (Status)) {
> + //
> + // Try Handle as Controller Handle
> + //
> + Status = gBS->OpenProtocol (
> + Handle,
> + &gEfiDriverBindingProtocolGuid,
> + (VOID **) &DriverBinding,
> + NULL,
> + NULL,
> + EFI_OPEN_PROTOCOL_GET_PROTOCOL
> + );
> + if (!EFI_ERROR (Status)) {
> + //
> + // Get Image protocol from ImageHandle
> + //
> + Status = gBS->HandleProtocol (
> + DriverBinding->ImageHandle,
> + &gEfiLoadedImageProtocolGuid,
> + (VOID**) &LoadedImage
> + );
> + }
> + }
> + }
> +
> + if (!EFI_ERROR (Status) && LoadedImage != NULL) {
> + //
> + // Get Module Guid from DevicePath.
> + //
> + if (LoadedImage->FilePath != NULL &&
> + LoadedImage->FilePath->Type == MEDIA_DEVICE_PATH &&
> + LoadedImage->FilePath->SubType == MEDIA_PIWG_FW_FILE_DP
> + ) {
> + //
> + // Determine GUID associated with module logging performance
> + //
> + ModuleGuidIsGet = TRUE;
> + FvFilePath = (MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *) LoadedImage->FilePath;
> + TempGuid = &FvFilePath->FvFileName;
> + }
> +
> + //
> + // Method 1 Get Module Name from PDB string.
> + //
> + PdbFileName = PeCoffLoaderGetPdbPointer (LoadedImage->ImageBase);
> + if (PdbFileName != NULL && BufferSize > 0) {
> + StartIndex = 0;
> + for (Index = 0; PdbFileName[Index] != 0; Index++) {
> + if ((PdbFileName[Index] == '\\') || (PdbFileName[Index] == '/')) {
> + StartIndex = Index + 1;
> + }
> + }
> + //
> + // Copy the PDB file name to our temporary string.
> + // If the length is bigger than BufferSize, trim the redudant characters to avoid overflow in array boundary.
> + //
> + for (Index = 0; Index < BufferSize - 1; Index++) {
> + NameString[Index] = PdbFileName[Index + StartIndex];
> + if (NameString[Index] == 0 || NameString[Index] == '.') {
> + NameString[Index] = 0;
> + break;
> + }
> + }
>
> - This internal function searches for the gauge entry in the gauge array.
> - If there is an entry that exactly matches the given keywords
> - and its end time stamp is zero, then the index of that gauge entry is returned;
> - otherwise, the the number of gauge entries in the array is returned.
> + if (Index == BufferSize - 1) {
> + NameString[Index] = 0;
> + }
> + //
> + // Module Name is got.
> + //
> + goto Done;
> + }
> + }
>
> + //
> + // Method 2: Get the name string from ComponentName2 protocol
> + //
> + Status = gBS->HandleProtocol (
> + Handle,
> + &gEfiComponentName2ProtocolGuid,
> + (VOID **) &ComponentName2
> + );
> + if (!EFI_ERROR (Status)) {
> + //
> + // Get the current platform language setting
> + //
> + if (mPlatformLanguage == NULL) {
> + GetEfiGlobalVariable2 (L"PlatformLang", (VOID **) &mPlatformLanguage, NULL);
> + }
> + if (mPlatformLanguage != NULL) {
> + Status = ComponentName2->GetDriverName (
> + ComponentName2,
> + mPlatformLanguage != NULL ? mPlatformLanguage : "en-US",
> + &StringPtr
> + );
> + if (!EFI_ERROR (Status)) {
> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
> + NameString[Index] = (CHAR8) StringPtr[Index];
> + }
> + NameString[Index] = 0;
> + //
> + // Module Name is got.
> + //
> + goto Done;
> + }
> + }
> + }
> +
> + if (ModuleGuidIsGet) {
> + //
> + // Method 3 Try to get the image's FFS UI section by image GUID
> + //
> + StringPtr = NULL;
> + StringSize = 0;
> + Status = GetSectionFromAnyFv (
> + TempGuid,
> + EFI_SECTION_USER_INTERFACE,
> + 0,
> + (VOID **) &StringPtr,
> + &StringSize
> + );
> +
> + if (!EFI_ERROR (Status)) {
> + //
> + // Method 3. Get the name string from FFS UI section
> + //
> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
> + NameString[Index] = (CHAR8) StringPtr[Index];
> + }
> + NameString[Index] = 0;
> + FreePool (StringPtr);
> + }
> + }
> +
> +Done:
> + //
> + // Copy Module Guid
> + //
> + if (ModuleGuid != NULL) {
> + CopyGuid (ModuleGuid, TempGuid);
> + if (IsZeroGuid(TempGuid) && (Handle != NULL) && !ModuleGuidIsGet) {
> + // Handle is GUID
> + CopyGuid (ModuleGuid, (EFI_GUID *) Handle);
> + }
> + }
> +
> + //
> + // Cache the Handle and Guid pairs.
> + //
> + if (mCachePairCount < CACHE_HANDLE_GUID_COUNT) {
> + mCacheHandleGuidTable[mCachePairCount].Handle = Handle;
> + CopyGuid (&mCacheHandleGuidTable[mCachePairCount].ModuleGuid, ModuleGuid);
> + AsciiStrCpyS (mCacheHandleGuidTable[mCachePairCount].NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, NameString);
> + mCachePairCount ++;
> + }
> +
> + return Status;
> +}
> +
> +/**
> + Get the FPDT record info.
> +
> + @param IsStart TRUE if the performance log is start log.
> @param Handle Pointer to environment specific context used
> to identify the component being measured.
> @param Token Pointer to a Null-terminated ASCII string
> that identifies the component being measured.
> @param Module Pointer to a Null-terminated ASCII string
> that identifies the module being measured.
> - @param Identifier 32-bit identifier.
> + @param RecordInfo On return, pointer to the info of the record.
> + @param UseModuleName Only useful for DYNAMIC_STRING_EVENT_TYPE, indicate that whether need use
> + Module name to fill the string field in the DYNAMIC_STRING_EVENT_RECORD.
>
> - @retval The index of gauge entry in the array.
> + @retval EFI_SUCCESS Get record info successfully.
> + @retval EFI_UNSUPPORTED No matched FPDT record.
>
> **/
> -UINT32
> -InternalSearchForGaugeEntry (
> - IN CONST VOID *Handle, OPTIONAL
> - IN CONST CHAR8 *Token, OPTIONAL
> - IN CONST CHAR8 *Module, OPTIONAL
> - IN UINT32 Identifier
> +EFI_STATUS
> +GetFpdtRecordInfo (
> + IN BOOLEAN IsStart,
> + IN CONST VOID *Handle,
> + IN CONST CHAR8 *Token,
> + IN CONST CHAR8 *Module,
> + OUT BASIC_RECORD_INFO *RecordInfo,
> + IN OUT BOOLEAN *UseModuleName
> )
> {
> - UINT32 Index;
> - UINT32 Index2;
> - UINT32 NumberOfEntries;
> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
> + UINT16 RecordType;
> + UINTN StringSize;
>
> - if (Token == NULL) {
> - Token = "";
> - }
> - if (Module == NULL) {
> - Module = "";
> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
> +
> + //
> + // Token to Type and Id.
> + //
> + if (Token != NULL) {
> + if (AsciiStrCmp (Token, START_IMAGE_TOK) == 0) { // "StartImage:"
> + *UseModuleName = TRUE;
> + RecordType = GUID_EVENT_TYPE;
> + if (IsStart) {
> + RecordInfo->ProgressID = MODULE_START_ID;
> + } else {
> + RecordInfo->ProgressID = MODULE_END_ID;
> + }
> + } else if (AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) { // "LoadImage:"
> + *UseModuleName = TRUE;
> + RecordType = GUID_QWORD_EVENT_TYPE;
> + if (IsStart) {
> + RecordInfo->ProgressID = MODULE_LOADIMAGE_START_ID;
> + } else {
> + RecordInfo->ProgressID = MODULE_LOADIMAGE_END_ID;
> + }
> + } else if (AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0) { // "DB:Start:"
> + *UseModuleName = TRUE;
> + if (IsStart) {
> + RecordInfo->ProgressID = MODULE_DB_START_ID;
> + RecordType = GUID_QWORD_EVENT_TYPE;
> + } else {
> + RecordInfo->ProgressID = MODULE_DB_END_ID;
> + RecordType = GUID_QWORD_STRING_EVENT_TYPE;
> + }
> + } else if (AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0) { // "DB:Support:"
> + *UseModuleName = TRUE;
> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
> + return RETURN_UNSUPPORTED;
> + }
> + RecordType = GUID_QWORD_EVENT_TYPE;
> + if (IsStart) {
> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_START_ID;
> + } else {
> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_END_ID;
> + }
> + } else if (AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0) { // "DB:Stop:"
> + *UseModuleName = TRUE;
> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
> + return RETURN_UNSUPPORTED;
> + }
> + RecordType = GUID_QWORD_EVENT_TYPE;
> + if (IsStart) {
> + RecordInfo->ProgressID = MODULE_DB_STOP_START_ID;
> + } else {
> + RecordInfo->ProgressID = MODULE_DB_STOP_END_ID;
> + }
> + } else if (AsciiStrCmp (Token, PEI_TOK) == 0 || // "PEI"
> + AsciiStrCmp (Token, DXE_TOK) == 0 || // "DXE"
> + AsciiStrCmp (Token, BDS_TOK) == 0) { // "BDS"
> + if (IsStart) {
> + RecordInfo->ProgressID = PERF_CROSSMODULE_START_ID;
> + } else {
> + RecordInfo->ProgressID = PERF_CROSSMODULE_END_ID;
> + }
> + } else { // Pref used in Modules.
> + if (IsStart) {
> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
> + } else {
> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
> + }
> + }
> + } else if (Handle!= NULL || Module != NULL) { // Pref used in Modules.
> + if (IsStart) {
> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
> + } else {
> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
> + }
> + } else {
> + return EFI_UNSUPPORTED;
> }
>
> - NumberOfEntries = mGaugeData->NumberOfEntries;
> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
> + //
> + // Get Record size baesed on the record type.
> + // When PcdEdkiiFpdtStringRecordEnableOnly is TRUE, all records are with type of DYNAMIC_STRING_EVENT_TYPE.
> + //
> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
> + RecordInfo->RecordSize = sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE;
> + } else {
> + switch (RecordType) {
> + case GUID_EVENT_TYPE:
> + RecordInfo->RecordSize = sizeof (GUID_EVENT_RECORD);
> + break;
>
> - Index2 = 0;
> + case DYNAMIC_STRING_EVENT_TYPE:
> + if (*UseModuleName) {
> + StringSize = STRING_SIZE;
> + } else if (Token != NULL) {
> + StringSize = AsciiStrSize (Token);
> + } else if (Module != NULL) {
> + StringSize = AsciiStrSize (Module);
> + } else {
> + StringSize = STRING_SIZE;
> + }
> + if (StringSize > STRING_SIZE) {
> + StringSize = STRING_SIZE;
> + }
> + RecordInfo->RecordSize = (UINT8)(sizeof (DYNAMIC_STRING_EVENT_RECORD) + StringSize);
> + break;
>
> - for (Index = 0; Index < NumberOfEntries; Index++) {
> - Index2 = NumberOfEntries - 1 - Index;
> - if (GaugeEntryExArray[Index2].EndTimeStamp == 0 &&
> - (GaugeEntryExArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&
> - AsciiStrnCmp (GaugeEntryExArray[Index2].Token, Token, DXE_PERFORMANCE_STRING_LENGTH) == 0 &&
> - AsciiStrnCmp (GaugeEntryExArray[Index2].Module, Module, DXE_PERFORMANCE_STRING_LENGTH) == 0) {
> - Index = Index2;
> + case GUID_QWORD_EVENT_TYPE:
> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_EVENT_RECORD);
> break;
> +
> + case GUID_QWORD_STRING_EVENT_TYPE:
> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_STRING_EVENT_RECORD);
> + break;
> +
> + default:
> + //
> + // Record is unsupported yet, return EFI_UNSUPPORTED
> + //
> + return EFI_UNSUPPORTED;
> }
> }
>
> - return Index;
> + RecordInfo->Type = RecordType;
> + return EFI_SUCCESS;
> }
>
> /**
> - Adds a record at the end of the performance measurement log
> - that records the start time of a performance measurement.
> -
> - Adds a record to the end of the performance measurement log
> - that contains the Handle, Token, Module and Identifier.
> - The end time of the new record must be set to zero.
> - If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
> - If TimeStamp is zero, the start time in the record is filled in with the value
> - read from the current time stamp.
> + Add performance log to FPDT boot record table.
>
> + @param IsStart TRUE if the performance log is start log.
> @param Handle Pointer to environment specific context used
> to identify the component being measured.
> @param Token Pointer to a Null-terminated ASCII string
> that identifies the component being measured.
> @param Module Pointer to a Null-terminated ASCII string
> that identifies the module being measured.
> - @param TimeStamp 64-bit time stamp.
> + @param Ticker 64-bit time stamp.
> @param Identifier 32-bit identifier. If the value is 0, the created record
> is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>
> - @retval EFI_SUCCESS The data was read correctly from the device.
> + @retval EFI_SUCCESS Add FPDT boot record.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
> + @retval EFI_UNSUPPORTED No matched FPDT record.
>
> **/
> EFI_STATUS
> -EFIAPI
> -StartGaugeEx (
> +InsertFpdtMeasurement (
> + IN BOOLEAN IsStart,
> IN CONST VOID *Handle, OPTIONAL
> IN CONST CHAR8 *Token, OPTIONAL
> IN CONST CHAR8 *Module, OPTIONAL
> - IN UINT64 TimeStamp,
> + IN UINT64 Ticker,
> IN UINT32 Identifier
> )
> {
> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
> - UINTN GaugeDataSize;
> - GAUGE_DATA_HEADER *NewGaugeData;
> - UINTN OldGaugeDataSize;
> - GAUGE_DATA_HEADER *OldGaugeData;
> - UINT32 Index;
> - EFI_STATUS Status;
> + EFI_GUID ModuleGuid;
> + CHAR8 ModuleName[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
> + UINT8 FpdtRecord[MAX_RECORD_SIZE];
> + EFI_STATUS Status;
> + FPDT_RECORD_PTR FpdtRecordPtr;
> + BASIC_RECORD_INFO RecordInfo;
> + UINT64 TimeStamp;
> + UINTN DestMax;
> + UINTN StrLength;
> + CONST CHAR8 *StringPtr;
> + BOOLEAN UseModuleName;
> +
> + StringPtr = NULL;
> + UseModuleName = FALSE;
> + ZeroMem (ModuleName, sizeof (ModuleName));
> + ZeroMem (FpdtRecord, sizeof (FpdtRecord));
>
> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
> + //
> + // Get record info (type, size, ProgressID and Module Guid).
> + //
> + Status = GetFpdtRecordInfo (IsStart, Handle, Token, Module, &RecordInfo, &UseModuleName);
> if (EFI_ERROR (Status)) {
> return Status;
> }
>
> - Index = mGaugeData->NumberOfEntries;
> - if (Index >= mMaxGaugeRecords) {
> + //
> + // If PERF_START()/PERF_END() have specified the ProgressID,it has high priority.
> + // !!! Note: If the Pref is not the known Token used in the core but have same
> + // ID with the core Token, this case will not be supported.
> + // And in currtnt usage mode, for the unkown ID, there is a general rule:
> + // If it is start pref: the lower 4 bits of the ID should be 0.
> + // If it is end pref: the lower 4 bits of the ID should not be 0.
> + // If input ID doesn't follow the rule, we will adjust it.
> + //
> + if ((Identifier != 0) && (IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
> + return EFI_UNSUPPORTED;
> + } else if ((Identifier != 0) && (!IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
> + if (IsStart && ((Identifier & 0x000F) != 0)) {
> + Identifier &= 0xFFF0;
> + } else if ((!IsStart) && ((Identifier & 0x000F) == 0)) {
> + Identifier += 1;
> + }
> + RecordInfo.ProgressID = (UINT16)Identifier;
> + }
> +
> + if (mFpdtBufferIsReported) {
> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)FpdtRecord;
> + } else {
> + //
> + // Check if pre-allocated buffer is full
> //
> - // Try to enlarge the scale of gauge array.
> + if (mPerformanceLength + RecordInfo.RecordSize > mMaxPerformanceLength) {
> + mPerformancePointer = ReallocatePool (
> + mPerformanceLength,
> + mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER,
> + mPerformancePointer
> + );
> +
> + if (mPerformancePointer == NULL) {
> + return EFI_OUT_OF_RESOURCES;
> + }
> + mMaxPerformanceLength = mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER;
> + }
> //
> - OldGaugeData = mGaugeData;
> - OldGaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords;
> + // Covert buffer to FPDT Ptr Union type.
> + //
> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(mPerformancePointer + mPerformanceLength);
> + }
> + FpdtRecordPtr.RecordHeader->Length = 0;
>
> - GaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords * 2;
> + //
> + // Get the TimeStamp.
> + //
> + if (Ticker == 0) {
> + Ticker = GetPerformanceCounter ();
> + TimeStamp = GetTimeInNanoSecond (Ticker);
> + } else if (Ticker == 1) {
> + TimeStamp = 0;
> + } else {
> + TimeStamp = GetTimeInNanoSecond (Ticker);
> + }
>
> - NewGaugeData = AllocateZeroPool (GaugeDataSize);
> - if (NewGaugeData == NULL) {
> - EfiReleaseLock (&mPerfRecordLock);
> - return EFI_OUT_OF_RESOURCES;
> + //
> + // Get the ModuleName and ModuleGuid form the handle.
> + //
> + GetModuleInfoFromHandle ((EFI_HANDLE *)Handle, ModuleName, sizeof (ModuleName), &ModuleGuid);
> +
> + //
> + // Fill in the record information.
> + //
> + switch (RecordInfo.Type) {
> + case GUID_EVENT_TYPE:
> + FpdtRecordPtr.GuidEvent->Header.Type = GUID_EVENT_TYPE;
> + FpdtRecordPtr.GuidEvent->Header.Length = RecordInfo.RecordSize;
> + FpdtRecordPtr.GuidEvent->Header.Revision = RECORD_REVISION_1;
> + FpdtRecordPtr.GuidEvent->ProgressID = RecordInfo.ProgressID;
> + FpdtRecordPtr.GuidEvent->Timestamp = TimeStamp;
> + CopyMem (&FpdtRecordPtr.GuidEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidEvent->Guid));
> + break;
> +
> + case DYNAMIC_STRING_EVENT_TYPE:
> + FpdtRecordPtr.DynamicStringEvent->Header.Type = DYNAMIC_STRING_EVENT_TYPE;
> + FpdtRecordPtr.DynamicStringEvent->Header.Length = RecordInfo.RecordSize;
> + FpdtRecordPtr.DynamicStringEvent->Header.Revision = RECORD_REVISION_1;
> + FpdtRecordPtr.DynamicStringEvent->ProgressID = RecordInfo.ProgressID;
> + FpdtRecordPtr.DynamicStringEvent->Timestamp = TimeStamp;
> + CopyMem (&FpdtRecordPtr.DynamicStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.DynamicStringEvent->Guid));
> +
> + if (UseModuleName) {
> + StringPtr = ModuleName;
> + } else if (Token != NULL) {
> + StringPtr = Token;
> + } else if (Module != NULL) {
> + StringPtr = Module;
> + } else if (ModuleName != NULL) {
> + StringPtr = ModuleName;
> + }
> + if (StringPtr != NULL && AsciiStrLen (StringPtr) != 0) {
> + StrLength = AsciiStrLen (StringPtr);
> + DestMax = (RecordInfo.RecordSize - sizeof (DYNAMIC_STRING_EVENT_RECORD)) / sizeof (CHAR8);
> + if (StrLength >= DestMax) {
> + StrLength = DestMax -1;
> + }
> + AsciiStrnCpyS (FpdtRecordPtr.DynamicStringEvent->String, DestMax, StringPtr, StrLength);
> }
> + break;
> +
> + case GUID_QWORD_EVENT_TYPE:
> + FpdtRecordPtr.GuidQwordEvent->Header.Type = GUID_QWORD_EVENT_TYPE;
> + FpdtRecordPtr.GuidQwordEvent->Header.Length = RecordInfo.RecordSize;
> + FpdtRecordPtr.GuidQwordEvent->Header.Revision = RECORD_REVISION_1;
> + FpdtRecordPtr.GuidQwordEvent->ProgressID = RecordInfo.ProgressID;
> + FpdtRecordPtr.GuidQwordEvent->Timestamp = TimeStamp;
> + CopyMem (&FpdtRecordPtr.GuidQwordEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordEvent->Guid));
> + if ((MODULE_LOADIMAGE_START_ID == RecordInfo.ProgressID) && AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) {
> + mLoadImageCount++;
> + FpdtRecordPtr.GuidQwordEvent->Qword = mLoadImageCount;
> + }
> + break;
> +
> + case GUID_QWORD_STRING_EVENT_TYPE:
> + FpdtRecordPtr.GuidQwordStringEvent->Header.Type = GUID_QWORD_STRING_EVENT_TYPE;
> + FpdtRecordPtr.GuidQwordStringEvent->Header.Length = RecordInfo.RecordSize;
> + FpdtRecordPtr.GuidQwordStringEvent->Header.Revision = RECORD_REVISION_1;
> + FpdtRecordPtr.GuidQwordStringEvent->ProgressID = RecordInfo.ProgressID;
> + FpdtRecordPtr.GuidQwordStringEvent->Timestamp = TimeStamp;
> + CopyMem (&FpdtRecordPtr.GuidQwordStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordStringEvent->Guid));
> + break;
> +
> + default:
> + //
> + // Record is not supported in current DXE phase, return EFI_ABORTED
> + //
> + return EFI_UNSUPPORTED;
> + }
> +
> + //
> + // Report record one by one after records have been reported together.
> + //
> + if (mFpdtBufferIsReported) {
> + //
> + // Append Boot records to the boot performance table.
> + //
> + if (mBootRecordSize + FpdtRecordPtr.RecordHeader->Length > mBootRecordMaxSize) {
> + if (!mLackSpaceIsReported) {
> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: No enough space to save boot records\n"));
> + mLackSpaceIsReported = TRUE;
> + }
> + return EFI_OUT_OF_RESOURCES;
> + } else {
> + //
> + // Save boot record into BootPerformance table
> + //
> + CopyMem (mBootRecordBuffer + mBootRecordSize, FpdtRecordPtr.RecordHeader, FpdtRecordPtr.RecordHeader->Length);
> + mBootRecordSize += FpdtRecordPtr.RecordHeader->Length;
> + mAcpiBootPerformanceTable->Header.Length += FpdtRecordPtr.RecordHeader->Length;
> + }
> + } else {
> + //
> + // Update the cached FPDT record buffer.
> + //
> + mPerformanceLength += FpdtRecordPtr.RecordHeader->Length;
> + }
> +
> + return EFI_SUCCESS;
> +}
> +
> +/**
> + Dumps all the PEI performance.
> +
> + @param HobStart A pointer to a Guid.
>
> - mGaugeData = NewGaugeData;
> - mMaxGaugeRecords *= 2;
> + This internal function dumps all the PEI performance log to the DXE performance gauge array.
> + It retrieves the optional GUID HOB for PEI performance and then saves the performance data
> + to DXE performance data structures.
>
> +**/
> +VOID
> +InternalGetPeiPerformance (
> + VOID *HobStart
> + )
> +{
> + UINT8 *FirmwarePerformanceHob;
> + PEI_EXT_FIRMWARE_PERF_HEADER *PeiPerformanceLogHeader;
> + UINT8 *EventRec;
> + EFI_HOB_GUID_TYPE *GuidHob;
> +
> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, HobStart);
> + while (GuidHob != NULL) {
> + FirmwarePerformanceHob = GET_GUID_HOB_DATA (GuidHob);
> + PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *)FirmwarePerformanceHob;
> +
> + if (mPerformanceLength + PeiPerformanceLogHeader->SizeOfAllEntries > mMaxPerformanceLength) {
> + mPerformancePointer = ReallocatePool (
> + mPerformanceLength,
> + mPerformanceLength +
> + (UINTN)PeiPerformanceLogHeader->SizeOfAllEntries +
> + FIRMWARE_RECORD_BUFFER,
> + mPerformancePointer
> + );
> + ASSERT (mPerformancePointer != NULL);
> + mMaxPerformanceLength = mPerformanceLength +
> + (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries) +
> + FIRMWARE_RECORD_BUFFER;
> + }
> +
> + EventRec = mPerformancePointer + mPerformanceLength;
> + CopyMem (EventRec, FirmwarePerformanceHob + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER), (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries));
> //
> - // Initialize new data array and migrate old data one.
> + // Update the used buffer size.
> //
> - mGaugeData = CopyMem (mGaugeData, OldGaugeData, OldGaugeDataSize);
> + mPerformanceLength += (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries);
> + mLoadImageCount += PeiPerformanceLogHeader->LoadImageCount;
>
> - FreePool (OldGaugeData);
> + //
> + // Get next performance guid hob
> + //
> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, GET_NEXT_HOB (GuidHob));
> }
> +}
>
> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
> - GaugeEntryExArray[Index].Handle = (EFI_PHYSICAL_ADDRESS) (UINTN) Handle;
> +/**
> + Report Boot Perforamnce table address as report status code.
>
> - if (Token != NULL) {
> - AsciiStrnCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, Token, DXE_PERFORMANCE_STRING_LENGTH);
> - }
> - if (Module != NULL) {
> - AsciiStrnCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, Module, DXE_PERFORMANCE_STRING_LENGTH);
> + @param Event The event of notify protocol.
> + @param Context Notify event context.
> +
> +**/
> +VOID
> +EFIAPI
> +ReportFpdtRecordBuffer (
> + IN EFI_EVENT Event,
> + IN VOID *Context
> + )
> +{
> + EFI_STATUS Status;
> + UINT64 BPDTAddr;
> +
> + if (!mFpdtBufferIsReported) {
> + Status = AllocateBootPerformanceTable ();
> + if (!EFI_ERROR(Status)) {
> + BPDTAddr = (UINT64)(UINTN)mAcpiBootPerformanceTable;
> + REPORT_STATUS_CODE_EX (
> + EFI_PROGRESS_CODE,
> + EFI_SOFTWARE_DXE_BS_DRIVER,
> + 0,
> + NULL,
> + &gEfiFirmwarePerformanceGuid,
> + &BPDTAddr,
> + sizeof (UINT64)
> + );
> + }
> + //
> + // Free Cached FPDT record Buffer
> + //
> + if (mPerformancePointer != NULL) {
> + FreePool (mPerformancePointer);
> + mPerformancePointer = NULL;
> + }
> + mPerformanceLength = 0;
> + mMaxPerformanceLength = 0;
> + //
> + // Set FPDT report state to TRUE.
> + //
> + mFpdtBufferIsReported = TRUE;
> }
> +}
>
> - GaugeEntryExArray[Index].EndTimeStamp = 0;
> - GaugeEntryExArray[Index].Identifier = Identifier;
> +/**
> + Adds a record at the end of the performance measurement log
> + that records the start time of a performance measurement.
>
> - if (TimeStamp == 0) {
> - TimeStamp = GetPerformanceCounter ();
> - }
> - GaugeEntryExArray[Index].StartTimeStamp = TimeStamp;
> + Adds a record to the end of the performance measurement log
> + that contains the Handle, Token, Module and Identifier.
> + The end time of the new record must be set to zero.
> + If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
> + If TimeStamp is zero, the start time in the record is filled in with the value
> + read from the current time stamp.
>
> - mGaugeData->NumberOfEntries++;
> + @param Handle Pointer to environment specific context used
> + to identify the component being measured.
> + @param Token Pointer to a Null-terminated ASCII string
> + that identifies the component being measured.
> + @param Module Pointer to a Null-terminated ASCII string
> + that identifies the module being measured.
> + @param TimeStamp 64-bit time stamp.
> + @param Identifier 32-bit identifier. If the value is 0, the created record
> + is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>
> - EfiReleaseLock (&mPerfRecordLock);
> + @retval EFI_SUCCESS The data was read correctly from the device.
> + @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>
> - return EFI_SUCCESS;
> +**/
> +EFI_STATUS
> +EFIAPI
> +StartGaugeEx (
> + IN CONST VOID *Handle, OPTIONAL
> + IN CONST CHAR8 *Token, OPTIONAL
> + IN CONST CHAR8 *Module, OPTIONAL
> + IN UINT64 TimeStamp,
> + IN UINT32 Identifier
> + )
> +{
> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
> }
>
> /**
> Searches the performance measurement log from the beginning of the log
> for the first matching record that contains a zero end time and fills in a valid end time.
>
> Searches the performance measurement log from the beginning of the log
> - for the first record that matches Handle, Token and Module and has an end time value of zero.
> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
> If the record can not be found then return EFI_NOT_FOUND.
> If the record is found and TimeStamp is not zero,
> then the end time in the record is filled in with the value specified by TimeStamp.
> If the record is found and TimeStamp is zero, then the end time in the matching record
> is filled in with the current time stamp value.
> @@ -260,89 +1188,19 @@ EndGaugeEx (
> IN CONST CHAR8 *Module, OPTIONAL
> IN UINT64 TimeStamp,
> IN UINT32 Identifier
> )
> {
> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
> - UINT32 Index;
> - EFI_STATUS Status;
> -
> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
> -
> - if (TimeStamp == 0) {
> - TimeStamp = GetPerformanceCounter ();
> - }
> -
> - Index = InternalSearchForGaugeEntry (Handle, Token, Module, Identifier);
> - if (Index >= mGaugeData->NumberOfEntries) {
> - EfiReleaseLock (&mPerfRecordLock);
> - return EFI_NOT_FOUND;
> - }
> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
> - GaugeEntryExArray[Index].EndTimeStamp = TimeStamp;
> -
> - EfiReleaseLock (&mPerfRecordLock);
> - return EFI_SUCCESS;
> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
> }
>
> /**
> Retrieves a previously logged performance measurement.
> It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
> and then assign the Identifier with 0.
>
> - Retrieves the performance log entry from the performance log specified by LogEntryKey.
> - If it stands for a valid entry, then EFI_SUCCESS is returned and
> - GaugeDataEntryEx stores the pointer to that entry.
> -
> - This internal function is added to avoid releasing lock before each return statement.
> -
> - @param LogEntryKey The key for the previous performance measurement log entry.
> - If 0, then the first performance measurement log entry is retrieved.
> - @param GaugeDataEntryEx The indirect pointer to the extended gauge data entry specified by LogEntryKey
> - if the retrieval is successful.
> -
> - @retval EFI_SUCCESS The GuageDataEntryEx is successfully found based on LogEntryKey.
> - @retval EFI_NOT_FOUND The LogEntryKey is the last entry (equals to the total entry number).
> - @retval EFI_INVALIDE_PARAMETER The LogEntryKey is not a valid entry (greater than the total entry number).
> - @retval EFI_INVALIDE_PARAMETER GaugeDataEntryEx is NULL.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -InternalGetGaugeEx (
> - IN UINTN LogEntryKey,
> - OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
> - )
> -{
> - UINTN NumberOfEntries;
> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
> -
> - NumberOfEntries = (UINTN) (mGaugeData->NumberOfEntries);
> - if (LogEntryKey > NumberOfEntries) {
> - return EFI_INVALID_PARAMETER;
> - }
> - if (LogEntryKey == NumberOfEntries) {
> - return EFI_NOT_FOUND;
> - }
> -
> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
> -
> - if (GaugeDataEntryEx == NULL) {
> - return EFI_INVALID_PARAMETER;
> - }
> - *GaugeDataEntryEx = &GaugeEntryExArray[LogEntryKey];
> -
> - return EFI_SUCCESS;
> -}
> -
> -/**
> - Retrieves a previously logged performance measurement.
> - It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
> - and then assign the Identifier with 0.
> + !!! Not support!!!
>
> Retrieves the performance log entry from the performance log specified by LogEntryKey.
> If it stands for a valid entry, then EFI_SUCCESS is returned and
> GaugeDataEntryEx stores the pointer to that entry.
>
> @@ -362,22 +1220,11 @@ EFIAPI
> GetGaugeEx (
> IN UINTN LogEntryKey,
> OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
> )
> {
> - EFI_STATUS Status;
> -
> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
> -
> - Status = InternalGetGaugeEx (LogEntryKey, GaugeDataEntryEx);
> -
> - EfiReleaseLock (&mPerfRecordLock);
> -
> - return Status;
> + return EFI_UNSUPPORTED;
> }
>
> /**
> Adds a record at the end of the performance measurement log
> that records the start time of a performance measurement.
> @@ -452,10 +1299,12 @@ EndGauge (
> /**
> Retrieves a previously logged performance measurement.
> It can also retrieve the log created by StartGaugeEx and EndGaugeEx of PERFORMANCE_EX_PROTOCOL,
> and then eliminate the Identifier.
>
> + !!! Not support!!!
> +
> Retrieves the performance log entry from the performance log specified by LogEntryKey.
> If it stands for a valid entry, then EFI_SUCCESS is returned and
> GaugeDataEntry stores the pointer to that entry.
>
> @param LogEntryKey The key for the previous performance measurement log entry.
> @@ -474,81 +1323,13 @@ EFIAPI
> GetGauge (
> IN UINTN LogEntryKey,
> OUT GAUGE_DATA_ENTRY **GaugeDataEntry
> )
> {
> - EFI_STATUS Status;
> - GAUGE_DATA_ENTRY_EX *GaugeEntryEx;
> -
> - GaugeEntryEx = NULL;
> -
> - Status = GetGaugeEx (LogEntryKey, &GaugeEntryEx);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
> -
> - if (GaugeDataEntry == NULL) {
> - return EFI_INVALID_PARAMETER;
> - }
> -
> - *GaugeDataEntry = (GAUGE_DATA_ENTRY *) GaugeEntryEx;
> -
> - return EFI_SUCCESS;
> + return EFI_UNSUPPORTED;
> }
>
> -/**
> - Dumps all the PEI performance log to DXE performance gauge array.
> -
> - This internal function dumps all the PEI performance log to the DXE performance gauge array.
> - It retrieves the optional GUID HOB for PEI performance and then saves the performance data
> - to DXE performance data structures.
> -
> -**/
> -VOID
> -InternalGetPeiPerformance (
> - VOID
> - )
> -{
> - EFI_HOB_GUID_TYPE *GuidHob;
> - PEI_PERFORMANCE_LOG_HEADER *LogHob;
> - PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
> - UINT32 *LogIdArray;
> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
> - UINT32 Index;
> - UINT32 NumberOfEntries;
> -
> - NumberOfEntries = 0;
> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
> -
> - //
> - // Dump PEI Log Entries to DXE Guage Data structure.
> - //
> - GuidHob = GetFirstGuidHob (&gPerformanceProtocolGuid);
> - if (GuidHob != NULL) {
> - LogHob = GET_GUID_HOB_DATA (GuidHob);
> - LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (LogHob + 1);
> -
> - NumberOfEntries = LogHob->NumberOfEntries;
> - for (Index = 0; Index < NumberOfEntries; Index++) {
> - GaugeEntryExArray[Index].Handle = LogEntryArray[Index].Handle;
> - AsciiStrCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Token);
> - AsciiStrCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Module);
> - GaugeEntryExArray[Index].StartTimeStamp = LogEntryArray[Index].StartTimeStamp;
> - GaugeEntryExArray[Index].EndTimeStamp = LogEntryArray[Index].EndTimeStamp;
> - GaugeEntryExArray[Index].Identifier = 0;
> - }
> -
> - GuidHob = GetFirstGuidHob (&gPerformanceExProtocolGuid);
> - if (GuidHob != NULL) {
> - LogIdArray = GET_GUID_HOB_DATA (GuidHob);
> - for (Index = 0; Index < NumberOfEntries; Index++) {
> - GaugeEntryExArray[Index].Identifier = LogIdArray[Index];
> - }
> - }
> - }
> - mGaugeData->NumberOfEntries = NumberOfEntries;
> -}
>
> /**
> The constructor function initializes Performance infrastructure for DXE phase.
>
> The constructor function publishes Performance and PerformanceEx protocol, allocates memory to log DXE performance
> @@ -567,40 +1348,53 @@ DxeCorePerformanceLibConstructor (
> IN EFI_HANDLE ImageHandle,
> IN EFI_SYSTEM_TABLE *SystemTable
> )
> {
> EFI_STATUS Status;
> + EFI_HANDLE Handle;
> + EFI_EVENT ReadyToBootEvent;
> PERFORMANCE_PROPERTY *PerformanceProperty;
>
> -
> if (!PerformanceMeasurementEnabled ()) {
> //
> // Do not initialize performance infrastructure if not required.
> //
> return EFI_SUCCESS;
> }
> +
> + //
> + // Dump normal PEI performance records
> + //
> + InternalGetPeiPerformance (GetHobList());
> +
> //
> - // Install the protocol interfaces.
> + // Install the protocol interfaces for DXE performance library instance.
> //
> + Handle = NULL;
> Status = gBS->InstallMultipleProtocolInterfaces (
> - &mHandle,
> + &Handle,
> &gPerformanceProtocolGuid,
> &mPerformanceInterface,
> &gPerformanceExProtocolGuid,
> &mPerformanceExInterface,
> NULL
> );
> ASSERT_EFI_ERROR (Status);
>
> - mMaxGaugeRecords = INIT_DXE_GAUGE_DATA_ENTRIES + (UINT16) (PcdGet16 (PcdMaxPeiPerformanceLogEntries16) != 0 ?
> - PcdGet16 (PcdMaxPeiPerformanceLogEntries16) :
> - PcdGet8 (PcdMaxPeiPerformanceLogEntries));
> -
> - mGaugeData = AllocateZeroPool (sizeof (GAUGE_DATA_HEADER) + (sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords));
> - ASSERT (mGaugeData != NULL);
> + //
> + // Register ReadyToBoot event to report StatusCode data
> + //
> + Status = gBS->CreateEventEx (
> + EVT_NOTIFY_SIGNAL,
> + TPL_CALLBACK,
> + ReportFpdtRecordBuffer,
> + NULL,
> + &gEfiEventReadyToBootGuid,
> + &ReadyToBootEvent
> + );
>
> - InternalGetPeiPerformance ();
> + ASSERT_EFI_ERROR (Status);
>
> Status = EfiGetSystemConfigurationTable (&gPerformanceProtocolGuid, (VOID **) &PerformanceProperty);
> if (EFI_ERROR (Status)) {
> //
> // Install configuration table for performance property.
> @@ -651,19 +1445,19 @@ StartPerformanceMeasurementEx (
> IN CONST CHAR8 *Module, OPTIONAL
> IN UINT64 TimeStamp,
> IN UINT32 Identifier
> )
> {
> - return (RETURN_STATUS) StartGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
> }
>
> /**
> Searches the performance measurement log from the beginning of the log
> for the first matching record that contains a zero end time and fills in a valid end time.
>
> Searches the performance measurement log from the beginning of the log
> - for the first record that matches Handle, Token and Module and has an end time value of zero.
> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
> If the record can not be found then return RETURN_NOT_FOUND.
> If the record is found and TimeStamp is not zero,
> then the end time in the record is filled in with the value specified by TimeStamp.
> If the record is found and TimeStamp is zero, then the end time in the matching record
> is filled in with the current time stamp value.
> @@ -690,18 +1484,20 @@ EndPerformanceMeasurementEx (
> IN CONST CHAR8 *Module, OPTIONAL
> IN UINT64 TimeStamp,
> IN UINT32 Identifier
> )
> {
> - return (RETURN_STATUS) EndGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
> }
>
> /**
> Attempts to retrieve a performance measurement log entry from the performance measurement log.
> It can also retrieve the log created by StartPerformanceMeasurement and EndPerformanceMeasurement,
> and then assign the Identifier with 0.
>
> + !!! Not support!!!
> +
> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
> and the key for the second entry in the log is returned. If the performance log is empty,
> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
> @@ -729,63 +1525,29 @@ EndPerformanceMeasurementEx (
> being measured.
> @param StartTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
> was started.
> @param EndTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
> was ended.
> - @param Identifier Pointer to the 32-bit identifier that was recorded.
> + @param Identifier Pointer to the 32-bit identifier that was recorded when the measurement
> + was ended.
>
> @return The key for the next performance log entry (in general case).
>
> **/
> UINTN
> EFIAPI
> GetPerformanceMeasurementEx (
> - IN UINTN LogEntryKey,
> + IN UINTN LogEntryKey,
> OUT CONST VOID **Handle,
> OUT CONST CHAR8 **Token,
> OUT CONST CHAR8 **Module,
> OUT UINT64 *StartTimeStamp,
> OUT UINT64 *EndTimeStamp,
> OUT UINT32 *Identifier
> )
> {
> - EFI_STATUS Status;
> - GAUGE_DATA_ENTRY_EX *GaugeData;
> -
> - GaugeData = NULL;
> -
> - ASSERT (Handle != NULL);
> - ASSERT (Token != NULL);
> - ASSERT (Module != NULL);
> - ASSERT (StartTimeStamp != NULL);
> - ASSERT (EndTimeStamp != NULL);
> - ASSERT (Identifier != NULL);
> -
> - Status = GetGaugeEx (LogEntryKey++, &GaugeData);
> -
> - //
> - // Make sure that LogEntryKey is a valid log entry key,
> - //
> - ASSERT (Status != EFI_INVALID_PARAMETER);
> -
> - if (EFI_ERROR (Status)) {
> - //
> - // The LogEntryKey is the last entry (equals to the total entry number).
> - //
> - return 0;
> - }
> -
> - ASSERT (GaugeData != NULL);
> -
> - *Handle = (VOID *) (UINTN) GaugeData->Handle;
> - *Token = GaugeData->Token;
> - *Module = GaugeData->Module;
> - *StartTimeStamp = GaugeData->StartTimeStamp;
> - *EndTimeStamp = GaugeData->EndTimeStamp;
> - *Identifier = GaugeData->Identifier;
> -
> - return LogEntryKey;
> + return 0;
> }
>
> /**
> Adds a record at the end of the performance measurement log
> that records the start time of a performance measurement.
> @@ -816,11 +1578,11 @@ StartPerformanceMeasurement (
> IN CONST CHAR8 *Token, OPTIONAL
> IN CONST CHAR8 *Module, OPTIONAL
> IN UINT64 TimeStamp
> )
> {
> - return StartPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, 0);
> }
>
> /**
> Searches the performance measurement log from the beginning of the log
> for the first matching record that contains a zero end time and fills in a valid end time.
> @@ -852,18 +1614,20 @@ EndPerformanceMeasurement (
> IN CONST CHAR8 *Token, OPTIONAL
> IN CONST CHAR8 *Module, OPTIONAL
> IN UINT64 TimeStamp
> )
> {
> - return EndPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, 0);
> }
>
> /**
> Attempts to retrieve a performance measurement log entry from the performance measurement log.
> It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
> and then eliminate the Identifier.
>
> + !!! Not support!!!
> +
> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
> and the key for the second entry in the log is returned. If the performance log is empty,
> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
> @@ -905,12 +1669,11 @@ GetPerformanceMeasurement (
> OUT CONST CHAR8 **Module,
> OUT UINT64 *StartTimeStamp,
> OUT UINT64 *EndTimeStamp
> )
> {
> - UINT32 Identifier;
> - return GetPerformanceMeasurementEx (LogEntryKey, Handle, Token, Module, StartTimeStamp, EndTimeStamp, &Identifier);
> + return 0;
> }
>
> /**
> Returns TRUE if the performance measurement macros are enabled.
>
> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
> index 5b89ce2..71c181f 100644
> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
> @@ -7,11 +7,11 @@
> # It initializes DXE phase performance logging by publishing the Performance and PerformanceEx Protocol,
> # which is consumed by DxePerformanceLib to logging performance data in DXE phase.
> # This library is mainly used by DxeCore to start performance logging to ensure that
> # Performance and PerformanceEx Protocol are installed at the very beginning of DXE phase.
> #
> -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD License
> # which accompanies this distribution. The full text of the license may be found at
> # http://opensource.org/licenses/bsd-license.php
> @@ -48,27 +48,39 @@
>
>
> [LibraryClasses]
> MemoryAllocationLib
> UefiBootServicesTableLib
> + UefiRuntimeServicesTableLib
> PcdLib
> TimerLib
> BaseMemoryLib
> BaseLib
> HobLib
> DebugLib
> UefiLib
> + ReportStatusCodeLib
> + DxeServicesLib
> + PeCoffGetEntryPointLib
> +
> +[Protocols]
> + gEfiSmmCommunicationProtocolGuid ## SOMETIMES_CONSUMES
>
>
> [Guids]
> ## SOMETIMES_CONSUMES ## HOB
> ## PRODUCES ## UNDEFINED # Install protocol
> ## PRODUCES ## SystemTable
> gPerformanceProtocolGuid
> ## SOMETIMES_CONSUMES ## HOB
> ## PRODUCES ## UNDEFINED # Install protocol
> gPerformanceExProtocolGuid
> + gZeroGuid ## SOMETIMES_CONSUMES ## GUID
> + gEfiFirmwarePerformanceGuid ## SOMETIMES_PRODUCES ## UNDEFINED # StatusCode Data
> + gEdkiiExtendedFirmwarePerformanceGuid ## SOMETIMES_CONSUMES ## HOB # StatusCode Data
> + gEfiEventReadyToBootGuid ## CONSUMES ## Event
> + gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable
>
> [Pcd]
> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries ## CONSUMES
> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16 ## CONSUMES
> - gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
> + gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
> + gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly ## CONSUMES
> + gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES
> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
> index f1540d8..7e79675 100644
> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
> @@ -2,11 +2,11 @@
> Master header files for DxeCorePerformanceLib instance.
>
> This header file holds the prototypes of the Performance and PerformanceEx Protocol published by this
> library instance at its constructor.
>
> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> which accompanies this distribution. The full text of the license may be found at
> http://opensource.org/licenses/bsd-license.php
>
> @@ -20,21 +20,36 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>
>
> #include <PiDxe.h>
>
> #include <Guid/Performance.h>
> +#include <Guid/ExtendedFirmwarePerformance.h>
> +#include <Guid/ZeroGuid.h>
> +#include <Guid/EventGroup.h>
> +#include <Guid/FirmwarePerformance.h>
> +#include <Guid/PiSmmCommunicationRegionTable.h>
> +
> +#include <Protocol/DriverBinding.h>
> +#include <Protocol/LoadedImage.h>
> +#include <Protocol/ComponentName2.h>
> +#include <Protocol/DevicePathToText.h>
> +#include <Protocol/SmmCommunication.h>
>
> #include <Library/PerformanceLib.h>
> #include <Library/DebugLib.h>
> #include <Library/HobLib.h>
> #include <Library/BaseLib.h>
> #include <Library/BaseMemoryLib.h>
> #include <Library/TimerLib.h>
> #include <Library/PcdLib.h>
> #include <Library/UefiBootServicesTableLib.h>
> +#include <Library/UefiRuntimeServicesTableLib.h>
> #include <Library/MemoryAllocationLib.h>
> #include <Library/UefiLib.h>
> +#include <Library/ReportStatusCodeLib.h>
> +#include <Library/DxeServicesLib.h>
> +#include <Library/PeCoffGetEntryPointLib.h>
>
> //
> // Interface declarations for PerformanceEx Protocol.
> //
> /**
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-05-01 16:26 ` Ard Biesheuvel
@ 2018-05-22 0:33 ` Bi, Dandan
2018-05-22 8:51 ` Ard Biesheuvel
0 siblings, 1 reply; 21+ messages in thread
From: Bi, Dandan @ 2018-05-22 0:33 UTC (permalink / raw)
To: 'Ard Biesheuvel', Leif Lindholm
Cc: edk2-devel@lists.01.org, Zeng, Star, Gao, Liming, Matt Sealey
Sorry for the delayed response.
The allocated performance table ( below 4G ) is to save the boot performance data in normal boot and S3 phase.
PEIM FirmwarePerformancePei will get the address of the performance table and update the performance date of S3 phase to the table.
The address need to be handled in PEI phase(32bit), that's the main reason why we allocate it below 4G.
Thanks,
Dandan
-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
Sent: Wednesday, May 2, 2018 12:27 AM
To: Bi, Dandan <dandan.bi@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
On 30 January 2018 at 14:53, Dandan Bi <dandan.bi@intel.com> wrote:
> V2:
> Update DxecorePerformanceLib to report the boot performance table
> address instead of records contents.
>
> Updated to convert Pref entry to FPDT record in DXE phase and then
> allocate boot performance table to save the record and report
> the address of boot performance table to FirmwarePerformanceDxe.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 1389 +++++++++++++++-----
> .../DxeCorePerformanceLib.inf | 20 +-
> .../DxeCorePerformanceLibInternal.h | 17 +-
> 3 files changed, 1108 insertions(+), 318 deletions(-)
>
> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> index 7c0e207..c6f8a16 100644
> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> @@ -8,11 +8,11 @@
> which are consumed by DxePerformanceLib to logging performance data in DXE phase.
>
> This library is mainly used by DxeCore to start performance logging to ensure that
> Performance Protocol is installed at the very beginning of DXE phase.
>
> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> which accompanies this distribution. The full text of the license may be found at
> http://opensource.org/licenses/bsd-license.php
> @@ -23,27 +23,65 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> **/
>
>
> #include "DxeCorePerformanceLibInternal.h"
>
> -
> //
> -// The data structure to hold global performance data.
> +// Data for FPDT performance records.
> //
> -GAUGE_DATA_HEADER *mGaugeData;
> +#define SMM_BOOT_RECORD_COMM_SIZE (OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + sizeof(SMM_BOOT_RECORD_COMMUNICATE))
> +#define STRING_SIZE (EDKII_STRING_EVENT_RECORD_NAME_LENGTH * sizeof (CHAR8))
> +#define MAX_RECORD_SIZE (sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE)
> +#define FIRMWARE_RECORD_BUFFER 0x10000
> +#define CACHE_HANDLE_GUID_COUNT 0x1000
> +
> +BOOT_PERFORMANCE_TABLE *mAcpiBootPerformanceTable = NULL;
> +BOOT_PERFORMANCE_TABLE mBootPerformanceTableTemplate = {
> + {
> + EFI_ACPI_5_0_FPDT_BOOT_PERFORMANCE_TABLE_SIGNATURE,
> + sizeof (BOOT_PERFORMANCE_TABLE)
> + },
> + {
> + {
> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_TYPE_FIRMWARE_BASIC_BOOT, // Type
> + sizeof (EFI_ACPI_5_0_FPDT_FIRMWARE_BASIC_BOOT_RECORD), // Length
> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_REVISION_FIRMWARE_BASIC_BOOT // Revision
> + },
> + 0, // Reserved
> + //
> + // These values will be updated at runtime.
> + //
> + 0, // ResetEnd
> + 0, // OsLoaderLoadImageStart
> + 0, // OsLoaderStartImageStart
> + 0, // ExitBootServicesEntry
> + 0 // ExitBootServicesExit
> + }
> +};
>
> -//
> -// The current maximum number of logging entries. If current number of
> -// entries exceeds this value, it will re-allocate a larger array and
> -// migration the old data to the larger array.
> -//
> -UINT32 mMaxGaugeRecords;
> +typedef struct {
> + EFI_HANDLE Handle;
> + CHAR8 NameString[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
> + EFI_GUID ModuleGuid;
> +} HANDLE_GUID_MAP;
>
> -//
> -// The handle to install Performance Protocol instance.
> -//
> -EFI_HANDLE mHandle = NULL;
> +HANDLE_GUID_MAP mCacheHandleGuidTable[CACHE_HANDLE_GUID_COUNT];
> +UINTN mCachePairCount = 0;
> +
> +UINT32 mLoadImageCount = 0;
> +UINT32 mPerformanceLength = 0;
> +UINT32 mMaxPerformanceLength = 0;
> +UINT32 mBootRecordSize = 0;
> +UINT32 mBootRecordMaxSize = 0;
> +
> +BOOLEAN mFpdtBufferIsReported = FALSE;
> +BOOLEAN mLackSpaceIsReported = FALSE;
> +CHAR8 *mPlatformLanguage = NULL;
> +UINT8 *mPerformancePointer = NULL;
> +UINT8 *mBootRecordBuffer = NULL;
> +
> +EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *mDevicePathToText = NULL;
>
> //
> // Interfaces for Performance Protocol.
> //
> PERFORMANCE_PROTOCOL mPerformanceInterface = {
> @@ -61,179 +99,1069 @@ PERFORMANCE_EX_PROTOCOL mPerformanceExInterface = {
> GetGaugeEx
> };
>
> PERFORMANCE_PROPERTY mPerformanceProperty;
>
> -//
> -// Gauge record lock to avoid data corruption or even memory overflow
> -//
> -STATIC EFI_LOCK mPerfRecordLock = EFI_INITIALIZE_LOCK_VARIABLE (TPL_NOTIFY);
> +/**
> +Check whether the Token is a known one which is uesed by core.
> +
> +@param Token Pointer to a Null-terminated ASCII string
> +
> +@retval TRUE Is a known one used by core.
> +@retval FALSE Not a known one.
> +
> +**/
> +BOOLEAN
> +IsKnownTokens (
> + IN CONST CHAR8 *Token
> + )
> +{
> + if (AsciiStrCmp (Token, SEC_TOK) == 0 ||
> + AsciiStrCmp (Token, PEI_TOK) == 0 ||
> + AsciiStrCmp (Token, DXE_TOK) == 0 ||
> + AsciiStrCmp (Token, BDS_TOK) == 0 ||
> + AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0 ||
> + AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0 ||
> + AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0 ||
> + AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0 ||
> + AsciiStrCmp (Token, START_IMAGE_TOK) == 0 ||
> + AsciiStrCmp (Token, PEIM_TOK) == 0) {
> + return TRUE;
> + } else {
> + return FALSE;
> + }
> +}
> +
> +/**
> +Check whether the ID is a known one which map to the known Token.
> +
> +@param Identifier 32-bit identifier.
> +
> +@retval TRUE Is a known one used by core.
> +@retval FALSE Not a known one.
> +
> +**/
> +BOOLEAN
> +IsKnownID (
> + IN UINT32 Identifier
> + )
> +{
> + if (Identifier == MODULE_START_ID ||
> + Identifier == MODULE_END_ID ||
> + Identifier == MODULE_LOADIMAGE_START_ID ||
> + Identifier == MODULE_LOADIMAGE_END_ID ||
> + Identifier == MODULE_DB_START_ID ||
> + Identifier == MODULE_DB_END_ID ||
> + Identifier == MODULE_DB_SUPPORT_START_ID ||
> + Identifier == MODULE_DB_SUPPORT_END_ID ||
> + Identifier == MODULE_DB_STOP_START_ID ||
> + Identifier == MODULE_DB_STOP_END_ID) {
> + return TRUE;
> + } else {
> + return FALSE;
> + }
> +}
>
> /**
> - Searches in the gauge array with keyword Handle, Token, Module and Identifier.
> + Allocate EfiReservedMemoryType below 4G memory address.
> +
> + This function allocates EfiReservedMemoryType below 4G memory address.
> +
> + @param[in] Size Size of memory to allocate.
> +
> + @return Allocated address for output.
> +
> +**/
> +VOID *
> +FpdtAllocateReservedMemoryBelow4G (
> + IN UINTN Size
> + )
> +{
> + UINTN Pages;
> + EFI_PHYSICAL_ADDRESS Address;
> + EFI_STATUS Status;
> + VOID *Buffer;
> +
> + Buffer = NULL;
> + Pages = EFI_SIZE_TO_PAGES (Size);
> + Address = 0xffffffff;
> +
> + Status = gBS->AllocatePages (
> + AllocateMaxAddress,
> + EfiReservedMemoryType,
> + Pages,
> + &Address
> + );
> + ASSERT_EFI_ERROR (Status);
This code is breaking DEBUG builds on ARM systems that have no memory
below 4 GB.
> +
> + if (!EFI_ERROR (Status)) {
> + Buffer = (VOID *) (UINTN) Address;
> + ZeroMem (Buffer, Size);
> + }
> +
> + return Buffer;
> +}
> +
> +/**
> + Allocate buffer for Boot Performance table.
> +
> + @return Status code.
> +
> +**/
> +EFI_STATUS
> +AllocateBootPerformanceTable (
> + )
> +{
> + EFI_STATUS Status;
> + UINTN Size;
> + UINT8 *SmmBootRecordCommBuffer;
> + EFI_SMM_COMMUNICATE_HEADER *SmmCommBufferHeader;
> + SMM_BOOT_RECORD_COMMUNICATE *SmmCommData;
> + UINTN CommSize;
> + UINTN BootPerformanceDataSize;
> + UINT8 *BootPerformanceData;
> + EFI_SMM_COMMUNICATION_PROTOCOL *Communication;
> + FIRMWARE_PERFORMANCE_VARIABLE PerformanceVariable;
> + EDKII_PI_SMM_COMMUNICATION_REGION_TABLE *SmmCommRegionTable;
> + EFI_MEMORY_DESCRIPTOR *SmmCommMemRegion;
> + UINTN Index;
> + VOID *SmmBootRecordData;
> + UINTN SmmBootRecordDataSize;
> + UINTN ReservedMemSize;
> +
> + //
> + // Collect boot records from SMM drivers.
> + //
> + SmmBootRecordCommBuffer = NULL;
> + SmmCommData = NULL;
> + SmmBootRecordData = NULL;
> + SmmBootRecordDataSize = 0;
> + ReservedMemSize = 0;
> + Status = gBS->LocateProtocol (&gEfiSmmCommunicationProtocolGuid, NULL, (VOID **) &Communication);
> + if (!EFI_ERROR (Status)) {
> + //
> + // Initialize communicate buffer
> + // Get the prepared Reserved Memory Range
> + //
> + Status = EfiGetSystemConfigurationTable (
> + &gEdkiiPiSmmCommunicationRegionTableGuid,
> + (VOID **) &SmmCommRegionTable
> + );
> + if (!EFI_ERROR (Status)) {
> + ASSERT (SmmCommRegionTable != NULL);
> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) (SmmCommRegionTable + 1);
> + for (Index = 0; Index < SmmCommRegionTable->NumberOfEntries; Index ++) {
> + if (SmmCommMemRegion->Type == EfiConventionalMemory) {
> + break;
> + }
> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) ((UINT8 *) SmmCommMemRegion + SmmCommRegionTable->DescriptorSize);
> + }
> + ASSERT (Index < SmmCommRegionTable->NumberOfEntries);
> + ASSERT (SmmCommMemRegion->PhysicalStart > 0);
> + ASSERT (SmmCommMemRegion->NumberOfPages > 0);
> + ReservedMemSize = (UINTN) SmmCommMemRegion->NumberOfPages * EFI_PAGE_SIZE;
> +
> + //
> + // Check enough reserved memory space
> + //
> + if (ReservedMemSize > SMM_BOOT_RECORD_COMM_SIZE) {
> + SmmBootRecordCommBuffer = (VOID *) (UINTN) SmmCommMemRegion->PhysicalStart;
> + SmmCommBufferHeader = (EFI_SMM_COMMUNICATE_HEADER*)SmmBootRecordCommBuffer;
> + SmmCommData = (SMM_BOOT_RECORD_COMMUNICATE*)SmmCommBufferHeader->Data;
> + ZeroMem((UINT8*)SmmCommData, sizeof(SMM_BOOT_RECORD_COMMUNICATE));
> +
> + CopyGuid (&SmmCommBufferHeader->HeaderGuid, &gEfiFirmwarePerformanceGuid);
> + SmmCommBufferHeader->MessageLength = sizeof(SMM_BOOT_RECORD_COMMUNICATE);
> + CommSize = SMM_BOOT_RECORD_COMM_SIZE;
> +
> + //
> + // Get the size of boot records.
> + //
> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_SIZE;
> + SmmCommData->BootRecordData = NULL;
> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
> + ASSERT_EFI_ERROR (Status);
> +
> + if (!EFI_ERROR (SmmCommData->ReturnStatus) && SmmCommData->BootRecordSize != 0) {
> + //
> + // Get all boot records
> + //
> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
> + SmmBootRecordDataSize = SmmCommData->BootRecordSize;
> + SmmBootRecordData = AllocateZeroPool(SmmBootRecordDataSize);
> + ASSERT (SmmBootRecordData != NULL);
> + SmmCommData->BootRecordOffset = 0;
> + SmmCommData->BootRecordData = (VOID *) ((UINTN) SmmCommMemRegion->PhysicalStart + SMM_BOOT_RECORD_COMM_SIZE);
> + SmmCommData->BootRecordSize = ReservedMemSize - SMM_BOOT_RECORD_COMM_SIZE;
> + while (SmmCommData->BootRecordOffset < SmmBootRecordDataSize) {
> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
> + ASSERT_EFI_ERROR (Status);
> + ASSERT_EFI_ERROR(SmmCommData->ReturnStatus);
> + if (SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize > SmmBootRecordDataSize) {
> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmBootRecordDataSize - SmmCommData->BootRecordOffset);
> + } else {
> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmCommData->BootRecordSize);
> + }
> + SmmCommData->BootRecordOffset = SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize;
> + }
> + }
> + }
> + }
> + }
> +
> + //
> + // Prepare memory for Boot Performance table.
> + // Boot Performance table includes BasicBoot record, and one or more appended Boot Records.
> + //
> + BootPerformanceDataSize = sizeof (BOOT_PERFORMANCE_TABLE) + mPerformanceLength + PcdGet32 (PcdExtFpdtBootRecordPadSize);
> + if (SmmCommData != NULL) {
> + BootPerformanceDataSize += SmmBootRecordDataSize;
> + }
> +
> + //
> + // Try to allocate the same runtime buffer as last time boot.
> + //
> + ZeroMem (&PerformanceVariable, sizeof (PerformanceVariable));
> + Size = sizeof (PerformanceVariable);
> + Status = gRT->GetVariable (
> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
> + &gEfiFirmwarePerformanceGuid,
> + NULL,
> + &Size,
> + &PerformanceVariable
> + );
> + if (!EFI_ERROR (Status)) {
> + Status = gBS->AllocatePages (
> + AllocateAddress,
> + EfiReservedMemoryType,
> + EFI_SIZE_TO_PAGES (BootPerformanceDataSize),
> + &PerformanceVariable.BootPerformanceTablePointer
> + );
> + if (!EFI_ERROR (Status)) {
> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) (UINTN) PerformanceVariable.BootPerformanceTablePointer;
> + }
> + }
> +
> + if (mAcpiBootPerformanceTable == NULL) {
> + //
> + // Fail to allocate at specified address, continue to allocate at any address.
> + //
> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) FpdtAllocateReservedMemoryBelow4G (BootPerformanceDataSize);
Why does this allocation need to live below 4 GB?
If there is no good reason, can we please get rid of this?
If there is a good reason, can we please document it in the code?
> + }
> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: ACPI Boot Performance Table address = 0x%x\n", mAcpiBootPerformanceTable));
> +
> + if (mAcpiBootPerformanceTable == NULL) {
> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
> + FreePool (SmmBootRecordData);
> + }
> + return EFI_OUT_OF_RESOURCES;
> + }
> +
> + //
> + // Prepare Boot Performance Table.
> + //
> + BootPerformanceData = (UINT8 *) mAcpiBootPerformanceTable;
> + //
> + // Fill Basic Boot record to Boot Performance Table.
> + //
> + CopyMem (mAcpiBootPerformanceTable, &mBootPerformanceTableTemplate, sizeof (mBootPerformanceTableTemplate));
> + BootPerformanceData = BootPerformanceData + mAcpiBootPerformanceTable->Header.Length;
> + //
> + // Fill Boot records from boot drivers.
> + //
> + if (mPerformancePointer != NULL) {
> + CopyMem (BootPerformanceData, mPerformancePointer, mPerformanceLength);
> + mAcpiBootPerformanceTable->Header.Length += mPerformanceLength;
> + BootPerformanceData = BootPerformanceData + mPerformanceLength;
> + }
> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
> + //
> + // Fill Boot records from SMM drivers.
> + //
> + CopyMem (BootPerformanceData, SmmBootRecordData, SmmBootRecordDataSize);
> + FreePool (SmmBootRecordData);
> + mAcpiBootPerformanceTable->Header.Length = (UINT32) (mAcpiBootPerformanceTable->Header.Length + SmmBootRecordDataSize);
> + BootPerformanceData = BootPerformanceData + SmmBootRecordDataSize;
> + }
> +
> + //
> + // Save Boot Performance Table address to Variable for use in S4 resume.
> + //
> + PerformanceVariable.BootPerformanceTablePointer = (EFI_PHYSICAL_ADDRESS) (UINTN) mAcpiBootPerformanceTable;
> +
> + //
> + // Save Runtime Performance Table pointers to Variable.
> + // Don't check SetVariable return status. It doesn't impact FPDT table generation.
> + //
> + gRT->SetVariable (
> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
> + &gEfiFirmwarePerformanceGuid,
> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
> + sizeof (PerformanceVariable),
> + &PerformanceVariable
> + );
> +
> + mBootRecordBuffer = (UINT8 *) mAcpiBootPerformanceTable;
> + mBootRecordSize = mAcpiBootPerformanceTable->Header.Length;
> + mBootRecordMaxSize = mBootRecordSize + PcdGet32 (PcdExtFpdtBootRecordPadSize);
> +
> + return EFI_SUCCESS;
> +}
> +
> +/**
> + Get a human readable module name and module guid for the given image handle.
> + If module name can't be found, "" string will return.
> + If module guid can't be found, Zero Guid will return.
> +
> + @param Handle Image handle or Controller handle.
> + @param NameString The ascii string will be filled into it. If not found, null string will return.
> + @param BufferSize Size of the input NameString buffer.
> + @param ModuleGuid Point to the guid buffer to store the got module guid value.
> +
> + @retval EFI_SUCCESS Successfully get module name and guid.
> + @retval EFI_INVALID_PARAMETER The input parameter NameString is NULL.
> + @retval other value Module Name can't be got.
> +**/
> +EFI_STATUS
> +GetModuleInfoFromHandle (
> + IN EFI_HANDLE Handle,
> + OUT CHAR8 *NameString,
> + IN UINTN BufferSize,
> + OUT EFI_GUID *ModuleGuid OPTIONAL
> + )
> +{
> + EFI_STATUS Status;
> + EFI_LOADED_IMAGE_PROTOCOL *LoadedImage;
> + EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
> + CHAR8 *PdbFileName;
> + EFI_GUID *TempGuid;
> + UINTN StartIndex;
> + UINTN Index;
> + INTN Count;
> + BOOLEAN ModuleGuidIsGet;
> + UINTN StringSize;
> + CHAR16 *StringPtr;
> + EFI_COMPONENT_NAME2_PROTOCOL *ComponentName2;
> + MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *FvFilePath;
> +
> + if (NameString == NULL || BufferSize == 0) {
> + return EFI_INVALID_PARAMETER;
> + }
> + //
> + // Try to get the ModuleGuid and name string form the caached array.
> + //
> + if (mCachePairCount > 0) {
> + for (Count = mCachePairCount -1; Count >= 0; Count--) {
> + if (Handle == mCacheHandleGuidTable[Count].Handle) {
> + CopyGuid (ModuleGuid, &mCacheHandleGuidTable[Count].ModuleGuid);
> + AsciiStrCpyS (NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, mCacheHandleGuidTable[Count].NameString);
> + return EFI_SUCCESS;
> + }
> + }
> + }
> +
> + Status = EFI_INVALID_PARAMETER;
> + LoadedImage = NULL;
> + ModuleGuidIsGet = FALSE;
> +
> + //
> + // Initialize GUID as zero value.
> + //
> + TempGuid = &gZeroGuid;
> + //
> + // Initialize it as "" string.
> + //
> + NameString[0] = 0;
> +
> + if (Handle != NULL) {
> + //
> + // Try Handle as ImageHandle.
> + //
> + Status = gBS->HandleProtocol (
> + Handle,
> + &gEfiLoadedImageProtocolGuid,
> + (VOID**) &LoadedImage
> + );
> +
> + if (EFI_ERROR (Status)) {
> + //
> + // Try Handle as Controller Handle
> + //
> + Status = gBS->OpenProtocol (
> + Handle,
> + &gEfiDriverBindingProtocolGuid,
> + (VOID **) &DriverBinding,
> + NULL,
> + NULL,
> + EFI_OPEN_PROTOCOL_GET_PROTOCOL
> + );
> + if (!EFI_ERROR (Status)) {
> + //
> + // Get Image protocol from ImageHandle
> + //
> + Status = gBS->HandleProtocol (
> + DriverBinding->ImageHandle,
> + &gEfiLoadedImageProtocolGuid,
> + (VOID**) &LoadedImage
> + );
> + }
> + }
> + }
> +
> + if (!EFI_ERROR (Status) && LoadedImage != NULL) {
> + //
> + // Get Module Guid from DevicePath.
> + //
> + if (LoadedImage->FilePath != NULL &&
> + LoadedImage->FilePath->Type == MEDIA_DEVICE_PATH &&
> + LoadedImage->FilePath->SubType == MEDIA_PIWG_FW_FILE_DP
> + ) {
> + //
> + // Determine GUID associated with module logging performance
> + //
> + ModuleGuidIsGet = TRUE;
> + FvFilePath = (MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *) LoadedImage->FilePath;
> + TempGuid = &FvFilePath->FvFileName;
> + }
> +
> + //
> + // Method 1 Get Module Name from PDB string.
> + //
> + PdbFileName = PeCoffLoaderGetPdbPointer (LoadedImage->ImageBase);
> + if (PdbFileName != NULL && BufferSize > 0) {
> + StartIndex = 0;
> + for (Index = 0; PdbFileName[Index] != 0; Index++) {
> + if ((PdbFileName[Index] == '\\') || (PdbFileName[Index] == '/')) {
> + StartIndex = Index + 1;
> + }
> + }
> + //
> + // Copy the PDB file name to our temporary string.
> + // If the length is bigger than BufferSize, trim the redudant characters to avoid overflow in array boundary.
> + //
> + for (Index = 0; Index < BufferSize - 1; Index++) {
> + NameString[Index] = PdbFileName[Index + StartIndex];
> + if (NameString[Index] == 0 || NameString[Index] == '.') {
> + NameString[Index] = 0;
> + break;
> + }
> + }
>
> - This internal function searches for the gauge entry in the gauge array.
> - If there is an entry that exactly matches the given keywords
> - and its end time stamp is zero, then the index of that gauge entry is returned;
> - otherwise, the the number of gauge entries in the array is returned.
> + if (Index == BufferSize - 1) {
> + NameString[Index] = 0;
> + }
> + //
> + // Module Name is got.
> + //
> + goto Done;
> + }
> + }
>
> + //
> + // Method 2: Get the name string from ComponentName2 protocol
> + //
> + Status = gBS->HandleProtocol (
> + Handle,
> + &gEfiComponentName2ProtocolGuid,
> + (VOID **) &ComponentName2
> + );
> + if (!EFI_ERROR (Status)) {
> + //
> + // Get the current platform language setting
> + //
> + if (mPlatformLanguage == NULL) {
> + GetEfiGlobalVariable2 (L"PlatformLang", (VOID **) &mPlatformLanguage, NULL);
> + }
> + if (mPlatformLanguage != NULL) {
> + Status = ComponentName2->GetDriverName (
> + ComponentName2,
> + mPlatformLanguage != NULL ? mPlatformLanguage : "en-US",
> + &StringPtr
> + );
> + if (!EFI_ERROR (Status)) {
> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
> + NameString[Index] = (CHAR8) StringPtr[Index];
> + }
> + NameString[Index] = 0;
> + //
> + // Module Name is got.
> + //
> + goto Done;
> + }
> + }
> + }
> +
> + if (ModuleGuidIsGet) {
> + //
> + // Method 3 Try to get the image's FFS UI section by image GUID
> + //
> + StringPtr = NULL;
> + StringSize = 0;
> + Status = GetSectionFromAnyFv (
> + TempGuid,
> + EFI_SECTION_USER_INTERFACE,
> + 0,
> + (VOID **) &StringPtr,
> + &StringSize
> + );
> +
> + if (!EFI_ERROR (Status)) {
> + //
> + // Method 3. Get the name string from FFS UI section
> + //
> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
> + NameString[Index] = (CHAR8) StringPtr[Index];
> + }
> + NameString[Index] = 0;
> + FreePool (StringPtr);
> + }
> + }
> +
> +Done:
> + //
> + // Copy Module Guid
> + //
> + if (ModuleGuid != NULL) {
> + CopyGuid (ModuleGuid, TempGuid);
> + if (IsZeroGuid(TempGuid) && (Handle != NULL) && !ModuleGuidIsGet) {
> + // Handle is GUID
> + CopyGuid (ModuleGuid, (EFI_GUID *) Handle);
> + }
> + }
> +
> + //
> + // Cache the Handle and Guid pairs.
> + //
> + if (mCachePairCount < CACHE_HANDLE_GUID_COUNT) {
> + mCacheHandleGuidTable[mCachePairCount].Handle = Handle;
> + CopyGuid (&mCacheHandleGuidTable[mCachePairCount].ModuleGuid, ModuleGuid);
> + AsciiStrCpyS (mCacheHandleGuidTable[mCachePairCount].NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, NameString);
> + mCachePairCount ++;
> + }
> +
> + return Status;
> +}
> +
> +/**
> + Get the FPDT record info.
> +
> + @param IsStart TRUE if the performance log is start log.
> @param Handle Pointer to environment specific context used
> to identify the component being measured.
> @param Token Pointer to a Null-terminated ASCII string
> that identifies the component being measured.
> @param Module Pointer to a Null-terminated ASCII string
> that identifies the module being measured.
> - @param Identifier 32-bit identifier.
> + @param RecordInfo On return, pointer to the info of the record.
> + @param UseModuleName Only useful for DYNAMIC_STRING_EVENT_TYPE, indicate that whether need use
> + Module name to fill the string field in the DYNAMIC_STRING_EVENT_RECORD.
>
> - @retval The index of gauge entry in the array.
> + @retval EFI_SUCCESS Get record info successfully.
> + @retval EFI_UNSUPPORTED No matched FPDT record.
>
> **/
> -UINT32
> -InternalSearchForGaugeEntry (
> - IN CONST VOID *Handle, OPTIONAL
> - IN CONST CHAR8 *Token, OPTIONAL
> - IN CONST CHAR8 *Module, OPTIONAL
> - IN UINT32 Identifier
> +EFI_STATUS
> +GetFpdtRecordInfo (
> + IN BOOLEAN IsStart,
> + IN CONST VOID *Handle,
> + IN CONST CHAR8 *Token,
> + IN CONST CHAR8 *Module,
> + OUT BASIC_RECORD_INFO *RecordInfo,
> + IN OUT BOOLEAN *UseModuleName
> )
> {
> - UINT32 Index;
> - UINT32 Index2;
> - UINT32 NumberOfEntries;
> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
> + UINT16 RecordType;
> + UINTN StringSize;
>
> - if (Token == NULL) {
> - Token = "";
> - }
> - if (Module == NULL) {
> - Module = "";
> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
> +
> + //
> + // Token to Type and Id.
> + //
> + if (Token != NULL) {
> + if (AsciiStrCmp (Token, START_IMAGE_TOK) == 0) { // "StartImage:"
> + *UseModuleName = TRUE;
> + RecordType = GUID_EVENT_TYPE;
> + if (IsStart) {
> + RecordInfo->ProgressID = MODULE_START_ID;
> + } else {
> + RecordInfo->ProgressID = MODULE_END_ID;
> + }
> + } else if (AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) { // "LoadImage:"
> + *UseModuleName = TRUE;
> + RecordType = GUID_QWORD_EVENT_TYPE;
> + if (IsStart) {
> + RecordInfo->ProgressID = MODULE_LOADIMAGE_START_ID;
> + } else {
> + RecordInfo->ProgressID = MODULE_LOADIMAGE_END_ID;
> + }
> + } else if (AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0) { // "DB:Start:"
> + *UseModuleName = TRUE;
> + if (IsStart) {
> + RecordInfo->ProgressID = MODULE_DB_START_ID;
> + RecordType = GUID_QWORD_EVENT_TYPE;
> + } else {
> + RecordInfo->ProgressID = MODULE_DB_END_ID;
> + RecordType = GUID_QWORD_STRING_EVENT_TYPE;
> + }
> + } else if (AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0) { // "DB:Support:"
> + *UseModuleName = TRUE;
> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
> + return RETURN_UNSUPPORTED;
> + }
> + RecordType = GUID_QWORD_EVENT_TYPE;
> + if (IsStart) {
> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_START_ID;
> + } else {
> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_END_ID;
> + }
> + } else if (AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0) { // "DB:Stop:"
> + *UseModuleName = TRUE;
> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
> + return RETURN_UNSUPPORTED;
> + }
> + RecordType = GUID_QWORD_EVENT_TYPE;
> + if (IsStart) {
> + RecordInfo->ProgressID = MODULE_DB_STOP_START_ID;
> + } else {
> + RecordInfo->ProgressID = MODULE_DB_STOP_END_ID;
> + }
> + } else if (AsciiStrCmp (Token, PEI_TOK) == 0 || // "PEI"
> + AsciiStrCmp (Token, DXE_TOK) == 0 || // "DXE"
> + AsciiStrCmp (Token, BDS_TOK) == 0) { // "BDS"
> + if (IsStart) {
> + RecordInfo->ProgressID = PERF_CROSSMODULE_START_ID;
> + } else {
> + RecordInfo->ProgressID = PERF_CROSSMODULE_END_ID;
> + }
> + } else { // Pref used in Modules.
> + if (IsStart) {
> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
> + } else {
> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
> + }
> + }
> + } else if (Handle!= NULL || Module != NULL) { // Pref used in Modules.
> + if (IsStart) {
> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
> + } else {
> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
> + }
> + } else {
> + return EFI_UNSUPPORTED;
> }
>
> - NumberOfEntries = mGaugeData->NumberOfEntries;
> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
> + //
> + // Get Record size baesed on the record type.
> + // When PcdEdkiiFpdtStringRecordEnableOnly is TRUE, all records are with type of DYNAMIC_STRING_EVENT_TYPE.
> + //
> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
> + RecordInfo->RecordSize = sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE;
> + } else {
> + switch (RecordType) {
> + case GUID_EVENT_TYPE:
> + RecordInfo->RecordSize = sizeof (GUID_EVENT_RECORD);
> + break;
>
> - Index2 = 0;
> + case DYNAMIC_STRING_EVENT_TYPE:
> + if (*UseModuleName) {
> + StringSize = STRING_SIZE;
> + } else if (Token != NULL) {
> + StringSize = AsciiStrSize (Token);
> + } else if (Module != NULL) {
> + StringSize = AsciiStrSize (Module);
> + } else {
> + StringSize = STRING_SIZE;
> + }
> + if (StringSize > STRING_SIZE) {
> + StringSize = STRING_SIZE;
> + }
> + RecordInfo->RecordSize = (UINT8)(sizeof (DYNAMIC_STRING_EVENT_RECORD) + StringSize);
> + break;
>
> - for (Index = 0; Index < NumberOfEntries; Index++) {
> - Index2 = NumberOfEntries - 1 - Index;
> - if (GaugeEntryExArray[Index2].EndTimeStamp == 0 &&
> - (GaugeEntryExArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&
> - AsciiStrnCmp (GaugeEntryExArray[Index2].Token, Token, DXE_PERFORMANCE_STRING_LENGTH) == 0 &&
> - AsciiStrnCmp (GaugeEntryExArray[Index2].Module, Module, DXE_PERFORMANCE_STRING_LENGTH) == 0) {
> - Index = Index2;
> + case GUID_QWORD_EVENT_TYPE:
> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_EVENT_RECORD);
> break;
> +
> + case GUID_QWORD_STRING_EVENT_TYPE:
> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_STRING_EVENT_RECORD);
> + break;
> +
> + default:
> + //
> + // Record is unsupported yet, return EFI_UNSUPPORTED
> + //
> + return EFI_UNSUPPORTED;
> }
> }
>
> - return Index;
> + RecordInfo->Type = RecordType;
> + return EFI_SUCCESS;
> }
>
> /**
> - Adds a record at the end of the performance measurement log
> - that records the start time of a performance measurement.
> -
> - Adds a record to the end of the performance measurement log
> - that contains the Handle, Token, Module and Identifier.
> - The end time of the new record must be set to zero.
> - If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
> - If TimeStamp is zero, the start time in the record is filled in with the value
> - read from the current time stamp.
> + Add performance log to FPDT boot record table.
>
> + @param IsStart TRUE if the performance log is start log.
> @param Handle Pointer to environment specific context used
> to identify the component being measured.
> @param Token Pointer to a Null-terminated ASCII string
> that identifies the component being measured.
> @param Module Pointer to a Null-terminated ASCII string
> that identifies the module being measured.
> - @param TimeStamp 64-bit time stamp.
> + @param Ticker 64-bit time stamp.
> @param Identifier 32-bit identifier. If the value is 0, the created record
> is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>
> - @retval EFI_SUCCESS The data was read correctly from the device.
> + @retval EFI_SUCCESS Add FPDT boot record.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
> + @retval EFI_UNSUPPORTED No matched FPDT record.
>
> **/
> EFI_STATUS
> -EFIAPI
> -StartGaugeEx (
> +InsertFpdtMeasurement (
> + IN BOOLEAN IsStart,
> IN CONST VOID *Handle, OPTIONAL
> IN CONST CHAR8 *Token, OPTIONAL
> IN CONST CHAR8 *Module, OPTIONAL
> - IN UINT64 TimeStamp,
> + IN UINT64 Ticker,
> IN UINT32 Identifier
> )
> {
> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
> - UINTN GaugeDataSize;
> - GAUGE_DATA_HEADER *NewGaugeData;
> - UINTN OldGaugeDataSize;
> - GAUGE_DATA_HEADER *OldGaugeData;
> - UINT32 Index;
> - EFI_STATUS Status;
> + EFI_GUID ModuleGuid;
> + CHAR8 ModuleName[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
> + UINT8 FpdtRecord[MAX_RECORD_SIZE];
> + EFI_STATUS Status;
> + FPDT_RECORD_PTR FpdtRecordPtr;
> + BASIC_RECORD_INFO RecordInfo;
> + UINT64 TimeStamp;
> + UINTN DestMax;
> + UINTN StrLength;
> + CONST CHAR8 *StringPtr;
> + BOOLEAN UseModuleName;
> +
> + StringPtr = NULL;
> + UseModuleName = FALSE;
> + ZeroMem (ModuleName, sizeof (ModuleName));
> + ZeroMem (FpdtRecord, sizeof (FpdtRecord));
>
> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
> + //
> + // Get record info (type, size, ProgressID and Module Guid).
> + //
> + Status = GetFpdtRecordInfo (IsStart, Handle, Token, Module, &RecordInfo, &UseModuleName);
> if (EFI_ERROR (Status)) {
> return Status;
> }
>
> - Index = mGaugeData->NumberOfEntries;
> - if (Index >= mMaxGaugeRecords) {
> + //
> + // If PERF_START()/PERF_END() have specified the ProgressID,it has high priority.
> + // !!! Note: If the Pref is not the known Token used in the core but have same
> + // ID with the core Token, this case will not be supported.
> + // And in currtnt usage mode, for the unkown ID, there is a general rule:
> + // If it is start pref: the lower 4 bits of the ID should be 0.
> + // If it is end pref: the lower 4 bits of the ID should not be 0.
> + // If input ID doesn't follow the rule, we will adjust it.
> + //
> + if ((Identifier != 0) && (IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
> + return EFI_UNSUPPORTED;
> + } else if ((Identifier != 0) && (!IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
> + if (IsStart && ((Identifier & 0x000F) != 0)) {
> + Identifier &= 0xFFF0;
> + } else if ((!IsStart) && ((Identifier & 0x000F) == 0)) {
> + Identifier += 1;
> + }
> + RecordInfo.ProgressID = (UINT16)Identifier;
> + }
> +
> + if (mFpdtBufferIsReported) {
> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)FpdtRecord;
> + } else {
> + //
> + // Check if pre-allocated buffer is full
> //
> - // Try to enlarge the scale of gauge array.
> + if (mPerformanceLength + RecordInfo.RecordSize > mMaxPerformanceLength) {
> + mPerformancePointer = ReallocatePool (
> + mPerformanceLength,
> + mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER,
> + mPerformancePointer
> + );
> +
> + if (mPerformancePointer == NULL) {
> + return EFI_OUT_OF_RESOURCES;
> + }
> + mMaxPerformanceLength = mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER;
> + }
> //
> - OldGaugeData = mGaugeData;
> - OldGaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords;
> + // Covert buffer to FPDT Ptr Union type.
> + //
> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(mPerformancePointer + mPerformanceLength);
> + }
> + FpdtRecordPtr.RecordHeader->Length = 0;
>
> - GaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords * 2;
> + //
> + // Get the TimeStamp.
> + //
> + if (Ticker == 0) {
> + Ticker = GetPerformanceCounter ();
> + TimeStamp = GetTimeInNanoSecond (Ticker);
> + } else if (Ticker == 1) {
> + TimeStamp = 0;
> + } else {
> + TimeStamp = GetTimeInNanoSecond (Ticker);
> + }
>
> - NewGaugeData = AllocateZeroPool (GaugeDataSize);
> - if (NewGaugeData == NULL) {
> - EfiReleaseLock (&mPerfRecordLock);
> - return EFI_OUT_OF_RESOURCES;
> + //
> + // Get the ModuleName and ModuleGuid form the handle.
> + //
> + GetModuleInfoFromHandle ((EFI_HANDLE *)Handle, ModuleName, sizeof (ModuleName), &ModuleGuid);
> +
> + //
> + // Fill in the record information.
> + //
> + switch (RecordInfo.Type) {
> + case GUID_EVENT_TYPE:
> + FpdtRecordPtr.GuidEvent->Header.Type = GUID_EVENT_TYPE;
> + FpdtRecordPtr.GuidEvent->Header.Length = RecordInfo.RecordSize;
> + FpdtRecordPtr.GuidEvent->Header.Revision = RECORD_REVISION_1;
> + FpdtRecordPtr.GuidEvent->ProgressID = RecordInfo.ProgressID;
> + FpdtRecordPtr.GuidEvent->Timestamp = TimeStamp;
> + CopyMem (&FpdtRecordPtr.GuidEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidEvent->Guid));
> + break;
> +
> + case DYNAMIC_STRING_EVENT_TYPE:
> + FpdtRecordPtr.DynamicStringEvent->Header.Type = DYNAMIC_STRING_EVENT_TYPE;
> + FpdtRecordPtr.DynamicStringEvent->Header.Length = RecordInfo.RecordSize;
> + FpdtRecordPtr.DynamicStringEvent->Header.Revision = RECORD_REVISION_1;
> + FpdtRecordPtr.DynamicStringEvent->ProgressID = RecordInfo.ProgressID;
> + FpdtRecordPtr.DynamicStringEvent->Timestamp = TimeStamp;
> + CopyMem (&FpdtRecordPtr.DynamicStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.DynamicStringEvent->Guid));
> +
> + if (UseModuleName) {
> + StringPtr = ModuleName;
> + } else if (Token != NULL) {
> + StringPtr = Token;
> + } else if (Module != NULL) {
> + StringPtr = Module;
> + } else if (ModuleName != NULL) {
> + StringPtr = ModuleName;
> + }
> + if (StringPtr != NULL && AsciiStrLen (StringPtr) != 0) {
> + StrLength = AsciiStrLen (StringPtr);
> + DestMax = (RecordInfo.RecordSize - sizeof (DYNAMIC_STRING_EVENT_RECORD)) / sizeof (CHAR8);
> + if (StrLength >= DestMax) {
> + StrLength = DestMax -1;
> + }
> + AsciiStrnCpyS (FpdtRecordPtr.DynamicStringEvent->String, DestMax, StringPtr, StrLength);
> }
> + break;
> +
> + case GUID_QWORD_EVENT_TYPE:
> + FpdtRecordPtr.GuidQwordEvent->Header.Type = GUID_QWORD_EVENT_TYPE;
> + FpdtRecordPtr.GuidQwordEvent->Header.Length = RecordInfo.RecordSize;
> + FpdtRecordPtr.GuidQwordEvent->Header.Revision = RECORD_REVISION_1;
> + FpdtRecordPtr.GuidQwordEvent->ProgressID = RecordInfo.ProgressID;
> + FpdtRecordPtr.GuidQwordEvent->Timestamp = TimeStamp;
> + CopyMem (&FpdtRecordPtr.GuidQwordEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordEvent->Guid));
> + if ((MODULE_LOADIMAGE_START_ID == RecordInfo.ProgressID) && AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) {
> + mLoadImageCount++;
> + FpdtRecordPtr.GuidQwordEvent->Qword = mLoadImageCount;
> + }
> + break;
> +
> + case GUID_QWORD_STRING_EVENT_TYPE:
> + FpdtRecordPtr.GuidQwordStringEvent->Header.Type = GUID_QWORD_STRING_EVENT_TYPE;
> + FpdtRecordPtr.GuidQwordStringEvent->Header.Length = RecordInfo.RecordSize;
> + FpdtRecordPtr.GuidQwordStringEvent->Header.Revision = RECORD_REVISION_1;
> + FpdtRecordPtr.GuidQwordStringEvent->ProgressID = RecordInfo.ProgressID;
> + FpdtRecordPtr.GuidQwordStringEvent->Timestamp = TimeStamp;
> + CopyMem (&FpdtRecordPtr.GuidQwordStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordStringEvent->Guid));
> + break;
> +
> + default:
> + //
> + // Record is not supported in current DXE phase, return EFI_ABORTED
> + //
> + return EFI_UNSUPPORTED;
> + }
> +
> + //
> + // Report record one by one after records have been reported together.
> + //
> + if (mFpdtBufferIsReported) {
> + //
> + // Append Boot records to the boot performance table.
> + //
> + if (mBootRecordSize + FpdtRecordPtr.RecordHeader->Length > mBootRecordMaxSize) {
> + if (!mLackSpaceIsReported) {
> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: No enough space to save boot records\n"));
> + mLackSpaceIsReported = TRUE;
> + }
> + return EFI_OUT_OF_RESOURCES;
> + } else {
> + //
> + // Save boot record into BootPerformance table
> + //
> + CopyMem (mBootRecordBuffer + mBootRecordSize, FpdtRecordPtr.RecordHeader, FpdtRecordPtr.RecordHeader->Length);
> + mBootRecordSize += FpdtRecordPtr.RecordHeader->Length;
> + mAcpiBootPerformanceTable->Header.Length += FpdtRecordPtr.RecordHeader->Length;
> + }
> + } else {
> + //
> + // Update the cached FPDT record buffer.
> + //
> + mPerformanceLength += FpdtRecordPtr.RecordHeader->Length;
> + }
> +
> + return EFI_SUCCESS;
> +}
> +
> +/**
> + Dumps all the PEI performance.
> +
> + @param HobStart A pointer to a Guid.
>
> - mGaugeData = NewGaugeData;
> - mMaxGaugeRecords *= 2;
> + This internal function dumps all the PEI performance log to the DXE performance gauge array.
> + It retrieves the optional GUID HOB for PEI performance and then saves the performance data
> + to DXE performance data structures.
>
> +**/
> +VOID
> +InternalGetPeiPerformance (
> + VOID *HobStart
> + )
> +{
> + UINT8 *FirmwarePerformanceHob;
> + PEI_EXT_FIRMWARE_PERF_HEADER *PeiPerformanceLogHeader;
> + UINT8 *EventRec;
> + EFI_HOB_GUID_TYPE *GuidHob;
> +
> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, HobStart);
> + while (GuidHob != NULL) {
> + FirmwarePerformanceHob = GET_GUID_HOB_DATA (GuidHob);
> + PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *)FirmwarePerformanceHob;
> +
> + if (mPerformanceLength + PeiPerformanceLogHeader->SizeOfAllEntries > mMaxPerformanceLength) {
> + mPerformancePointer = ReallocatePool (
> + mPerformanceLength,
> + mPerformanceLength +
> + (UINTN)PeiPerformanceLogHeader->SizeOfAllEntries +
> + FIRMWARE_RECORD_BUFFER,
> + mPerformancePointer
> + );
> + ASSERT (mPerformancePointer != NULL);
> + mMaxPerformanceLength = mPerformanceLength +
> + (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries) +
> + FIRMWARE_RECORD_BUFFER;
> + }
> +
> + EventRec = mPerformancePointer + mPerformanceLength;
> + CopyMem (EventRec, FirmwarePerformanceHob + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER), (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries));
> //
> - // Initialize new data array and migrate old data one.
> + // Update the used buffer size.
> //
> - mGaugeData = CopyMem (mGaugeData, OldGaugeData, OldGaugeDataSize);
> + mPerformanceLength += (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries);
> + mLoadImageCount += PeiPerformanceLogHeader->LoadImageCount;
>
> - FreePool (OldGaugeData);
> + //
> + // Get next performance guid hob
> + //
> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, GET_NEXT_HOB (GuidHob));
> }
> +}
>
> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
> - GaugeEntryExArray[Index].Handle = (EFI_PHYSICAL_ADDRESS) (UINTN) Handle;
> +/**
> + Report Boot Perforamnce table address as report status code.
>
> - if (Token != NULL) {
> - AsciiStrnCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, Token, DXE_PERFORMANCE_STRING_LENGTH);
> - }
> - if (Module != NULL) {
> - AsciiStrnCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, Module, DXE_PERFORMANCE_STRING_LENGTH);
> + @param Event The event of notify protocol.
> + @param Context Notify event context.
> +
> +**/
> +VOID
> +EFIAPI
> +ReportFpdtRecordBuffer (
> + IN EFI_EVENT Event,
> + IN VOID *Context
> + )
> +{
> + EFI_STATUS Status;
> + UINT64 BPDTAddr;
> +
> + if (!mFpdtBufferIsReported) {
> + Status = AllocateBootPerformanceTable ();
> + if (!EFI_ERROR(Status)) {
> + BPDTAddr = (UINT64)(UINTN)mAcpiBootPerformanceTable;
> + REPORT_STATUS_CODE_EX (
> + EFI_PROGRESS_CODE,
> + EFI_SOFTWARE_DXE_BS_DRIVER,
> + 0,
> + NULL,
> + &gEfiFirmwarePerformanceGuid,
> + &BPDTAddr,
> + sizeof (UINT64)
> + );
> + }
> + //
> + // Free Cached FPDT record Buffer
> + //
> + if (mPerformancePointer != NULL) {
> + FreePool (mPerformancePointer);
> + mPerformancePointer = NULL;
> + }
> + mPerformanceLength = 0;
> + mMaxPerformanceLength = 0;
> + //
> + // Set FPDT report state to TRUE.
> + //
> + mFpdtBufferIsReported = TRUE;
> }
> +}
>
> - GaugeEntryExArray[Index].EndTimeStamp = 0;
> - GaugeEntryExArray[Index].Identifier = Identifier;
> +/**
> + Adds a record at the end of the performance measurement log
> + that records the start time of a performance measurement.
>
> - if (TimeStamp == 0) {
> - TimeStamp = GetPerformanceCounter ();
> - }
> - GaugeEntryExArray[Index].StartTimeStamp = TimeStamp;
> + Adds a record to the end of the performance measurement log
> + that contains the Handle, Token, Module and Identifier.
> + The end time of the new record must be set to zero.
> + If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
> + If TimeStamp is zero, the start time in the record is filled in with the value
> + read from the current time stamp.
>
> - mGaugeData->NumberOfEntries++;
> + @param Handle Pointer to environment specific context used
> + to identify the component being measured.
> + @param Token Pointer to a Null-terminated ASCII string
> + that identifies the component being measured.
> + @param Module Pointer to a Null-terminated ASCII string
> + that identifies the module being measured.
> + @param TimeStamp 64-bit time stamp.
> + @param Identifier 32-bit identifier. If the value is 0, the created record
> + is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>
> - EfiReleaseLock (&mPerfRecordLock);
> + @retval EFI_SUCCESS The data was read correctly from the device.
> + @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>
> - return EFI_SUCCESS;
> +**/
> +EFI_STATUS
> +EFIAPI
> +StartGaugeEx (
> + IN CONST VOID *Handle, OPTIONAL
> + IN CONST CHAR8 *Token, OPTIONAL
> + IN CONST CHAR8 *Module, OPTIONAL
> + IN UINT64 TimeStamp,
> + IN UINT32 Identifier
> + )
> +{
> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
> }
>
> /**
> Searches the performance measurement log from the beginning of the log
> for the first matching record that contains a zero end time and fills in a valid end time.
>
> Searches the performance measurement log from the beginning of the log
> - for the first record that matches Handle, Token and Module and has an end time value of zero.
> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
> If the record can not be found then return EFI_NOT_FOUND.
> If the record is found and TimeStamp is not zero,
> then the end time in the record is filled in with the value specified by TimeStamp.
> If the record is found and TimeStamp is zero, then the end time in the matching record
> is filled in with the current time stamp value.
> @@ -260,89 +1188,19 @@ EndGaugeEx (
> IN CONST CHAR8 *Module, OPTIONAL
> IN UINT64 TimeStamp,
> IN UINT32 Identifier
> )
> {
> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
> - UINT32 Index;
> - EFI_STATUS Status;
> -
> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
> -
> - if (TimeStamp == 0) {
> - TimeStamp = GetPerformanceCounter ();
> - }
> -
> - Index = InternalSearchForGaugeEntry (Handle, Token, Module, Identifier);
> - if (Index >= mGaugeData->NumberOfEntries) {
> - EfiReleaseLock (&mPerfRecordLock);
> - return EFI_NOT_FOUND;
> - }
> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
> - GaugeEntryExArray[Index].EndTimeStamp = TimeStamp;
> -
> - EfiReleaseLock (&mPerfRecordLock);
> - return EFI_SUCCESS;
> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
> }
>
> /**
> Retrieves a previously logged performance measurement.
> It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
> and then assign the Identifier with 0.
>
> - Retrieves the performance log entry from the performance log specified by LogEntryKey.
> - If it stands for a valid entry, then EFI_SUCCESS is returned and
> - GaugeDataEntryEx stores the pointer to that entry.
> -
> - This internal function is added to avoid releasing lock before each return statement.
> -
> - @param LogEntryKey The key for the previous performance measurement log entry.
> - If 0, then the first performance measurement log entry is retrieved.
> - @param GaugeDataEntryEx The indirect pointer to the extended gauge data entry specified by LogEntryKey
> - if the retrieval is successful.
> -
> - @retval EFI_SUCCESS The GuageDataEntryEx is successfully found based on LogEntryKey.
> - @retval EFI_NOT_FOUND The LogEntryKey is the last entry (equals to the total entry number).
> - @retval EFI_INVALIDE_PARAMETER The LogEntryKey is not a valid entry (greater than the total entry number).
> - @retval EFI_INVALIDE_PARAMETER GaugeDataEntryEx is NULL.
> -
> -**/
> -EFI_STATUS
> -EFIAPI
> -InternalGetGaugeEx (
> - IN UINTN LogEntryKey,
> - OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
> - )
> -{
> - UINTN NumberOfEntries;
> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
> -
> - NumberOfEntries = (UINTN) (mGaugeData->NumberOfEntries);
> - if (LogEntryKey > NumberOfEntries) {
> - return EFI_INVALID_PARAMETER;
> - }
> - if (LogEntryKey == NumberOfEntries) {
> - return EFI_NOT_FOUND;
> - }
> -
> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
> -
> - if (GaugeDataEntryEx == NULL) {
> - return EFI_INVALID_PARAMETER;
> - }
> - *GaugeDataEntryEx = &GaugeEntryExArray[LogEntryKey];
> -
> - return EFI_SUCCESS;
> -}
> -
> -/**
> - Retrieves a previously logged performance measurement.
> - It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
> - and then assign the Identifier with 0.
> + !!! Not support!!!
>
> Retrieves the performance log entry from the performance log specified by LogEntryKey.
> If it stands for a valid entry, then EFI_SUCCESS is returned and
> GaugeDataEntryEx stores the pointer to that entry.
>
> @@ -362,22 +1220,11 @@ EFIAPI
> GetGaugeEx (
> IN UINTN LogEntryKey,
> OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
> )
> {
> - EFI_STATUS Status;
> -
> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
> -
> - Status = InternalGetGaugeEx (LogEntryKey, GaugeDataEntryEx);
> -
> - EfiReleaseLock (&mPerfRecordLock);
> -
> - return Status;
> + return EFI_UNSUPPORTED;
> }
>
> /**
> Adds a record at the end of the performance measurement log
> that records the start time of a performance measurement.
> @@ -452,10 +1299,12 @@ EndGauge (
> /**
> Retrieves a previously logged performance measurement.
> It can also retrieve the log created by StartGaugeEx and EndGaugeEx of PERFORMANCE_EX_PROTOCOL,
> and then eliminate the Identifier.
>
> + !!! Not support!!!
> +
> Retrieves the performance log entry from the performance log specified by LogEntryKey.
> If it stands for a valid entry, then EFI_SUCCESS is returned and
> GaugeDataEntry stores the pointer to that entry.
>
> @param LogEntryKey The key for the previous performance measurement log entry.
> @@ -474,81 +1323,13 @@ EFIAPI
> GetGauge (
> IN UINTN LogEntryKey,
> OUT GAUGE_DATA_ENTRY **GaugeDataEntry
> )
> {
> - EFI_STATUS Status;
> - GAUGE_DATA_ENTRY_EX *GaugeEntryEx;
> -
> - GaugeEntryEx = NULL;
> -
> - Status = GetGaugeEx (LogEntryKey, &GaugeEntryEx);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
> -
> - if (GaugeDataEntry == NULL) {
> - return EFI_INVALID_PARAMETER;
> - }
> -
> - *GaugeDataEntry = (GAUGE_DATA_ENTRY *) GaugeEntryEx;
> -
> - return EFI_SUCCESS;
> + return EFI_UNSUPPORTED;
> }
>
> -/**
> - Dumps all the PEI performance log to DXE performance gauge array.
> -
> - This internal function dumps all the PEI performance log to the DXE performance gauge array.
> - It retrieves the optional GUID HOB for PEI performance and then saves the performance data
> - to DXE performance data structures.
> -
> -**/
> -VOID
> -InternalGetPeiPerformance (
> - VOID
> - )
> -{
> - EFI_HOB_GUID_TYPE *GuidHob;
> - PEI_PERFORMANCE_LOG_HEADER *LogHob;
> - PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
> - UINT32 *LogIdArray;
> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
> - UINT32 Index;
> - UINT32 NumberOfEntries;
> -
> - NumberOfEntries = 0;
> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
> -
> - //
> - // Dump PEI Log Entries to DXE Guage Data structure.
> - //
> - GuidHob = GetFirstGuidHob (&gPerformanceProtocolGuid);
> - if (GuidHob != NULL) {
> - LogHob = GET_GUID_HOB_DATA (GuidHob);
> - LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (LogHob + 1);
> -
> - NumberOfEntries = LogHob->NumberOfEntries;
> - for (Index = 0; Index < NumberOfEntries; Index++) {
> - GaugeEntryExArray[Index].Handle = LogEntryArray[Index].Handle;
> - AsciiStrCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Token);
> - AsciiStrCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Module);
> - GaugeEntryExArray[Index].StartTimeStamp = LogEntryArray[Index].StartTimeStamp;
> - GaugeEntryExArray[Index].EndTimeStamp = LogEntryArray[Index].EndTimeStamp;
> - GaugeEntryExArray[Index].Identifier = 0;
> - }
> -
> - GuidHob = GetFirstGuidHob (&gPerformanceExProtocolGuid);
> - if (GuidHob != NULL) {
> - LogIdArray = GET_GUID_HOB_DATA (GuidHob);
> - for (Index = 0; Index < NumberOfEntries; Index++) {
> - GaugeEntryExArray[Index].Identifier = LogIdArray[Index];
> - }
> - }
> - }
> - mGaugeData->NumberOfEntries = NumberOfEntries;
> -}
>
> /**
> The constructor function initializes Performance infrastructure for DXE phase.
>
> The constructor function publishes Performance and PerformanceEx protocol, allocates memory to log DXE performance
> @@ -567,40 +1348,53 @@ DxeCorePerformanceLibConstructor (
> IN EFI_HANDLE ImageHandle,
> IN EFI_SYSTEM_TABLE *SystemTable
> )
> {
> EFI_STATUS Status;
> + EFI_HANDLE Handle;
> + EFI_EVENT ReadyToBootEvent;
> PERFORMANCE_PROPERTY *PerformanceProperty;
>
> -
> if (!PerformanceMeasurementEnabled ()) {
> //
> // Do not initialize performance infrastructure if not required.
> //
> return EFI_SUCCESS;
> }
> +
> + //
> + // Dump normal PEI performance records
> + //
> + InternalGetPeiPerformance (GetHobList());
> +
> //
> - // Install the protocol interfaces.
> + // Install the protocol interfaces for DXE performance library instance.
> //
> + Handle = NULL;
> Status = gBS->InstallMultipleProtocolInterfaces (
> - &mHandle,
> + &Handle,
> &gPerformanceProtocolGuid,
> &mPerformanceInterface,
> &gPerformanceExProtocolGuid,
> &mPerformanceExInterface,
> NULL
> );
> ASSERT_EFI_ERROR (Status);
>
> - mMaxGaugeRecords = INIT_DXE_GAUGE_DATA_ENTRIES + (UINT16) (PcdGet16 (PcdMaxPeiPerformanceLogEntries16) != 0 ?
> - PcdGet16 (PcdMaxPeiPerformanceLogEntries16) :
> - PcdGet8 (PcdMaxPeiPerformanceLogEntries));
> -
> - mGaugeData = AllocateZeroPool (sizeof (GAUGE_DATA_HEADER) + (sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords));
> - ASSERT (mGaugeData != NULL);
> + //
> + // Register ReadyToBoot event to report StatusCode data
> + //
> + Status = gBS->CreateEventEx (
> + EVT_NOTIFY_SIGNAL,
> + TPL_CALLBACK,
> + ReportFpdtRecordBuffer,
> + NULL,
> + &gEfiEventReadyToBootGuid,
> + &ReadyToBootEvent
> + );
>
> - InternalGetPeiPerformance ();
> + ASSERT_EFI_ERROR (Status);
>
> Status = EfiGetSystemConfigurationTable (&gPerformanceProtocolGuid, (VOID **) &PerformanceProperty);
> if (EFI_ERROR (Status)) {
> //
> // Install configuration table for performance property.
> @@ -651,19 +1445,19 @@ StartPerformanceMeasurementEx (
> IN CONST CHAR8 *Module, OPTIONAL
> IN UINT64 TimeStamp,
> IN UINT32 Identifier
> )
> {
> - return (RETURN_STATUS) StartGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
> }
>
> /**
> Searches the performance measurement log from the beginning of the log
> for the first matching record that contains a zero end time and fills in a valid end time.
>
> Searches the performance measurement log from the beginning of the log
> - for the first record that matches Handle, Token and Module and has an end time value of zero.
> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
> If the record can not be found then return RETURN_NOT_FOUND.
> If the record is found and TimeStamp is not zero,
> then the end time in the record is filled in with the value specified by TimeStamp.
> If the record is found and TimeStamp is zero, then the end time in the matching record
> is filled in with the current time stamp value.
> @@ -690,18 +1484,20 @@ EndPerformanceMeasurementEx (
> IN CONST CHAR8 *Module, OPTIONAL
> IN UINT64 TimeStamp,
> IN UINT32 Identifier
> )
> {
> - return (RETURN_STATUS) EndGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
> }
>
> /**
> Attempts to retrieve a performance measurement log entry from the performance measurement log.
> It can also retrieve the log created by StartPerformanceMeasurement and EndPerformanceMeasurement,
> and then assign the Identifier with 0.
>
> + !!! Not support!!!
> +
> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
> and the key for the second entry in the log is returned. If the performance log is empty,
> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
> @@ -729,63 +1525,29 @@ EndPerformanceMeasurementEx (
> being measured.
> @param StartTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
> was started.
> @param EndTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
> was ended.
> - @param Identifier Pointer to the 32-bit identifier that was recorded.
> + @param Identifier Pointer to the 32-bit identifier that was recorded when the measurement
> + was ended.
>
> @return The key for the next performance log entry (in general case).
>
> **/
> UINTN
> EFIAPI
> GetPerformanceMeasurementEx (
> - IN UINTN LogEntryKey,
> + IN UINTN LogEntryKey,
> OUT CONST VOID **Handle,
> OUT CONST CHAR8 **Token,
> OUT CONST CHAR8 **Module,
> OUT UINT64 *StartTimeStamp,
> OUT UINT64 *EndTimeStamp,
> OUT UINT32 *Identifier
> )
> {
> - EFI_STATUS Status;
> - GAUGE_DATA_ENTRY_EX *GaugeData;
> -
> - GaugeData = NULL;
> -
> - ASSERT (Handle != NULL);
> - ASSERT (Token != NULL);
> - ASSERT (Module != NULL);
> - ASSERT (StartTimeStamp != NULL);
> - ASSERT (EndTimeStamp != NULL);
> - ASSERT (Identifier != NULL);
> -
> - Status = GetGaugeEx (LogEntryKey++, &GaugeData);
> -
> - //
> - // Make sure that LogEntryKey is a valid log entry key,
> - //
> - ASSERT (Status != EFI_INVALID_PARAMETER);
> -
> - if (EFI_ERROR (Status)) {
> - //
> - // The LogEntryKey is the last entry (equals to the total entry number).
> - //
> - return 0;
> - }
> -
> - ASSERT (GaugeData != NULL);
> -
> - *Handle = (VOID *) (UINTN) GaugeData->Handle;
> - *Token = GaugeData->Token;
> - *Module = GaugeData->Module;
> - *StartTimeStamp = GaugeData->StartTimeStamp;
> - *EndTimeStamp = GaugeData->EndTimeStamp;
> - *Identifier = GaugeData->Identifier;
> -
> - return LogEntryKey;
> + return 0;
> }
>
> /**
> Adds a record at the end of the performance measurement log
> that records the start time of a performance measurement.
> @@ -816,11 +1578,11 @@ StartPerformanceMeasurement (
> IN CONST CHAR8 *Token, OPTIONAL
> IN CONST CHAR8 *Module, OPTIONAL
> IN UINT64 TimeStamp
> )
> {
> - return StartPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, 0);
> }
>
> /**
> Searches the performance measurement log from the beginning of the log
> for the first matching record that contains a zero end time and fills in a valid end time.
> @@ -852,18 +1614,20 @@ EndPerformanceMeasurement (
> IN CONST CHAR8 *Token, OPTIONAL
> IN CONST CHAR8 *Module, OPTIONAL
> IN UINT64 TimeStamp
> )
> {
> - return EndPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, 0);
> }
>
> /**
> Attempts to retrieve a performance measurement log entry from the performance measurement log.
> It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
> and then eliminate the Identifier.
>
> + !!! Not support!!!
> +
> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
> and the key for the second entry in the log is returned. If the performance log is empty,
> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
> @@ -905,12 +1669,11 @@ GetPerformanceMeasurement (
> OUT CONST CHAR8 **Module,
> OUT UINT64 *StartTimeStamp,
> OUT UINT64 *EndTimeStamp
> )
> {
> - UINT32 Identifier;
> - return GetPerformanceMeasurementEx (LogEntryKey, Handle, Token, Module, StartTimeStamp, EndTimeStamp, &Identifier);
> + return 0;
> }
>
> /**
> Returns TRUE if the performance measurement macros are enabled.
>
> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
> index 5b89ce2..71c181f 100644
> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
> @@ -7,11 +7,11 @@
> # It initializes DXE phase performance logging by publishing the Performance and PerformanceEx Protocol,
> # which is consumed by DxePerformanceLib to logging performance data in DXE phase.
> # This library is mainly used by DxeCore to start performance logging to ensure that
> # Performance and PerformanceEx Protocol are installed at the very beginning of DXE phase.
> #
> -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD License
> # which accompanies this distribution. The full text of the license may be found at
> # http://opensource.org/licenses/bsd-license.php
> @@ -48,27 +48,39 @@
>
>
> [LibraryClasses]
> MemoryAllocationLib
> UefiBootServicesTableLib
> + UefiRuntimeServicesTableLib
> PcdLib
> TimerLib
> BaseMemoryLib
> BaseLib
> HobLib
> DebugLib
> UefiLib
> + ReportStatusCodeLib
> + DxeServicesLib
> + PeCoffGetEntryPointLib
> +
> +[Protocols]
> + gEfiSmmCommunicationProtocolGuid ## SOMETIMES_CONSUMES
>
>
> [Guids]
> ## SOMETIMES_CONSUMES ## HOB
> ## PRODUCES ## UNDEFINED # Install protocol
> ## PRODUCES ## SystemTable
> gPerformanceProtocolGuid
> ## SOMETIMES_CONSUMES ## HOB
> ## PRODUCES ## UNDEFINED # Install protocol
> gPerformanceExProtocolGuid
> + gZeroGuid ## SOMETIMES_CONSUMES ## GUID
> + gEfiFirmwarePerformanceGuid ## SOMETIMES_PRODUCES ## UNDEFINED # StatusCode Data
> + gEdkiiExtendedFirmwarePerformanceGuid ## SOMETIMES_CONSUMES ## HOB # StatusCode Data
> + gEfiEventReadyToBootGuid ## CONSUMES ## Event
> + gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable
>
> [Pcd]
> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries ## CONSUMES
> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16 ## CONSUMES
> - gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
> + gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
> + gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly ## CONSUMES
> + gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES
> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
> index f1540d8..7e79675 100644
> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
> @@ -2,11 +2,11 @@
> Master header files for DxeCorePerformanceLib instance.
>
> This header file holds the prototypes of the Performance and PerformanceEx Protocol published by this
> library instance at its constructor.
>
> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> which accompanies this distribution. The full text of the license may be found at
> http://opensource.org/licenses/bsd-license.php
>
> @@ -20,21 +20,36 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>
>
> #include <PiDxe.h>
>
> #include <Guid/Performance.h>
> +#include <Guid/ExtendedFirmwarePerformance.h>
> +#include <Guid/ZeroGuid.h>
> +#include <Guid/EventGroup.h>
> +#include <Guid/FirmwarePerformance.h>
> +#include <Guid/PiSmmCommunicationRegionTable.h>
> +
> +#include <Protocol/DriverBinding.h>
> +#include <Protocol/LoadedImage.h>
> +#include <Protocol/ComponentName2.h>
> +#include <Protocol/DevicePathToText.h>
> +#include <Protocol/SmmCommunication.h>
>
> #include <Library/PerformanceLib.h>
> #include <Library/DebugLib.h>
> #include <Library/HobLib.h>
> #include <Library/BaseLib.h>
> #include <Library/BaseMemoryLib.h>
> #include <Library/TimerLib.h>
> #include <Library/PcdLib.h>
> #include <Library/UefiBootServicesTableLib.h>
> +#include <Library/UefiRuntimeServicesTableLib.h>
> #include <Library/MemoryAllocationLib.h>
> #include <Library/UefiLib.h>
> +#include <Library/ReportStatusCodeLib.h>
> +#include <Library/DxeServicesLib.h>
> +#include <Library/PeCoffGetEntryPointLib.h>
>
> //
> // Interface declarations for PerformanceEx Protocol.
> //
> /**
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-05-22 0:33 ` Bi, Dandan
@ 2018-05-22 8:51 ` Ard Biesheuvel
2018-05-22 8:58 ` Zeng, Star
0 siblings, 1 reply; 21+ messages in thread
From: Ard Biesheuvel @ 2018-05-22 8:51 UTC (permalink / raw)
To: Bi, Dandan, Laszlo Ersek, Andrew Fish, Kinney, Michael D
Cc: Leif Lindholm, edk2-devel@lists.01.org, Zeng, Star, Gao, Liming,
Matt Sealey
(+ Laszlo, Andrew, Mike)
On 22 May 2018 at 02:33, Bi, Dandan <dandan.bi@intel.com> wrote:
> Sorry for the delayed response.
>
> The allocated performance table ( below 4G ) is to save the boot performance data in normal boot and S3 phase.
> PEIM FirmwarePerformancePei will get the address of the performance table and update the performance date of S3 phase to the table.
> The address need to be handled in PEI phase(32bit), that's the main reason why we allocate it below 4G.
>
The 32-bit PEI + 64-bit DXE combo is specific to X64. You have added
code to a generic library that ASSERT()s if allocating memory below 4
GB fails, breaking non-PC architectures.
So please, fix this. Or at least suggest a way around it so that other
architectures can keep using this library.
This is another consequence of our failure to model the special 32-bit
PEI/64-bit DXE combination using proper PI interfaces, resulting in
these kinds of breakages and open coded 4 GB allocations all
throughout the code. Can we please work on getting this fixed?
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Wednesday, May 2, 2018 12:27 AM
> To: Bi, Dandan <dandan.bi@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
> Cc: edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
> Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>
> On 30 January 2018 at 14:53, Dandan Bi <dandan.bi@intel.com> wrote:
>> V2:
>> Update DxecorePerformanceLib to report the boot performance table
>> address instead of records contents.
>>
>> Updated to convert Pref entry to FPDT record in DXE phase and then
>> allocate boot performance table to save the record and report
>> the address of boot performance table to FirmwarePerformanceDxe.
>>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>> ---
>> .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 1389 +++++++++++++++-----
>> .../DxeCorePerformanceLib.inf | 20 +-
>> .../DxeCorePerformanceLibInternal.h | 17 +-
>> 3 files changed, 1108 insertions(+), 318 deletions(-)
>>
>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>> index 7c0e207..c6f8a16 100644
>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>> @@ -8,11 +8,11 @@
>> which are consumed by DxePerformanceLib to logging performance data in DXE phase.
>>
>> This library is mainly used by DxeCore to start performance logging to ensure that
>> Performance Protocol is installed at the very beginning of DXE phase.
>>
>> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>> This program and the accompanying materials
>> are licensed and made available under the terms and conditions of the BSD License
>> which accompanies this distribution. The full text of the license may be found at
>> http://opensource.org/licenses/bsd-license.php
>> @@ -23,27 +23,65 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>> **/
>>
>>
>> #include "DxeCorePerformanceLibInternal.h"
>>
>> -
>> //
>> -// The data structure to hold global performance data.
>> +// Data for FPDT performance records.
>> //
>> -GAUGE_DATA_HEADER *mGaugeData;
>> +#define SMM_BOOT_RECORD_COMM_SIZE (OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + sizeof(SMM_BOOT_RECORD_COMMUNICATE))
>> +#define STRING_SIZE (EDKII_STRING_EVENT_RECORD_NAME_LENGTH * sizeof (CHAR8))
>> +#define MAX_RECORD_SIZE (sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE)
>> +#define FIRMWARE_RECORD_BUFFER 0x10000
>> +#define CACHE_HANDLE_GUID_COUNT 0x1000
>> +
>> +BOOT_PERFORMANCE_TABLE *mAcpiBootPerformanceTable = NULL;
>> +BOOT_PERFORMANCE_TABLE mBootPerformanceTableTemplate = {
>> + {
>> + EFI_ACPI_5_0_FPDT_BOOT_PERFORMANCE_TABLE_SIGNATURE,
>> + sizeof (BOOT_PERFORMANCE_TABLE)
>> + },
>> + {
>> + {
>> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_TYPE_FIRMWARE_BASIC_BOOT, // Type
>> + sizeof (EFI_ACPI_5_0_FPDT_FIRMWARE_BASIC_BOOT_RECORD), // Length
>> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_REVISION_FIRMWARE_BASIC_BOOT // Revision
>> + },
>> + 0, // Reserved
>> + //
>> + // These values will be updated at runtime.
>> + //
>> + 0, // ResetEnd
>> + 0, // OsLoaderLoadImageStart
>> + 0, // OsLoaderStartImageStart
>> + 0, // ExitBootServicesEntry
>> + 0 // ExitBootServicesExit
>> + }
>> +};
>>
>> -//
>> -// The current maximum number of logging entries. If current number of
>> -// entries exceeds this value, it will re-allocate a larger array and
>> -// migration the old data to the larger array.
>> -//
>> -UINT32 mMaxGaugeRecords;
>> +typedef struct {
>> + EFI_HANDLE Handle;
>> + CHAR8 NameString[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
>> + EFI_GUID ModuleGuid;
>> +} HANDLE_GUID_MAP;
>>
>> -//
>> -// The handle to install Performance Protocol instance.
>> -//
>> -EFI_HANDLE mHandle = NULL;
>> +HANDLE_GUID_MAP mCacheHandleGuidTable[CACHE_HANDLE_GUID_COUNT];
>> +UINTN mCachePairCount = 0;
>> +
>> +UINT32 mLoadImageCount = 0;
>> +UINT32 mPerformanceLength = 0;
>> +UINT32 mMaxPerformanceLength = 0;
>> +UINT32 mBootRecordSize = 0;
>> +UINT32 mBootRecordMaxSize = 0;
>> +
>> +BOOLEAN mFpdtBufferIsReported = FALSE;
>> +BOOLEAN mLackSpaceIsReported = FALSE;
>> +CHAR8 *mPlatformLanguage = NULL;
>> +UINT8 *mPerformancePointer = NULL;
>> +UINT8 *mBootRecordBuffer = NULL;
>> +
>> +EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *mDevicePathToText = NULL;
>>
>> //
>> // Interfaces for Performance Protocol.
>> //
>> PERFORMANCE_PROTOCOL mPerformanceInterface = {
>> @@ -61,179 +99,1069 @@ PERFORMANCE_EX_PROTOCOL mPerformanceExInterface = {
>> GetGaugeEx
>> };
>>
>> PERFORMANCE_PROPERTY mPerformanceProperty;
>>
>> -//
>> -// Gauge record lock to avoid data corruption or even memory overflow
>> -//
>> -STATIC EFI_LOCK mPerfRecordLock = EFI_INITIALIZE_LOCK_VARIABLE (TPL_NOTIFY);
>> +/**
>> +Check whether the Token is a known one which is uesed by core.
>> +
>> +@param Token Pointer to a Null-terminated ASCII string
>> +
>> +@retval TRUE Is a known one used by core.
>> +@retval FALSE Not a known one.
>> +
>> +**/
>> +BOOLEAN
>> +IsKnownTokens (
>> + IN CONST CHAR8 *Token
>> + )
>> +{
>> + if (AsciiStrCmp (Token, SEC_TOK) == 0 ||
>> + AsciiStrCmp (Token, PEI_TOK) == 0 ||
>> + AsciiStrCmp (Token, DXE_TOK) == 0 ||
>> + AsciiStrCmp (Token, BDS_TOK) == 0 ||
>> + AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0 ||
>> + AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0 ||
>> + AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0 ||
>> + AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0 ||
>> + AsciiStrCmp (Token, START_IMAGE_TOK) == 0 ||
>> + AsciiStrCmp (Token, PEIM_TOK) == 0) {
>> + return TRUE;
>> + } else {
>> + return FALSE;
>> + }
>> +}
>> +
>> +/**
>> +Check whether the ID is a known one which map to the known Token.
>> +
>> +@param Identifier 32-bit identifier.
>> +
>> +@retval TRUE Is a known one used by core.
>> +@retval FALSE Not a known one.
>> +
>> +**/
>> +BOOLEAN
>> +IsKnownID (
>> + IN UINT32 Identifier
>> + )
>> +{
>> + if (Identifier == MODULE_START_ID ||
>> + Identifier == MODULE_END_ID ||
>> + Identifier == MODULE_LOADIMAGE_START_ID ||
>> + Identifier == MODULE_LOADIMAGE_END_ID ||
>> + Identifier == MODULE_DB_START_ID ||
>> + Identifier == MODULE_DB_END_ID ||
>> + Identifier == MODULE_DB_SUPPORT_START_ID ||
>> + Identifier == MODULE_DB_SUPPORT_END_ID ||
>> + Identifier == MODULE_DB_STOP_START_ID ||
>> + Identifier == MODULE_DB_STOP_END_ID) {
>> + return TRUE;
>> + } else {
>> + return FALSE;
>> + }
>> +}
>>
>> /**
>> - Searches in the gauge array with keyword Handle, Token, Module and Identifier.
>> + Allocate EfiReservedMemoryType below 4G memory address.
>> +
>> + This function allocates EfiReservedMemoryType below 4G memory address.
>> +
>> + @param[in] Size Size of memory to allocate.
>> +
>> + @return Allocated address for output.
>> +
>> +**/
>> +VOID *
>> +FpdtAllocateReservedMemoryBelow4G (
>> + IN UINTN Size
>> + )
>> +{
>> + UINTN Pages;
>> + EFI_PHYSICAL_ADDRESS Address;
>> + EFI_STATUS Status;
>> + VOID *Buffer;
>> +
>> + Buffer = NULL;
>> + Pages = EFI_SIZE_TO_PAGES (Size);
>> + Address = 0xffffffff;
>> +
>> + Status = gBS->AllocatePages (
>> + AllocateMaxAddress,
>> + EfiReservedMemoryType,
>> + Pages,
>> + &Address
>> + );
>> + ASSERT_EFI_ERROR (Status);
>
> This code is breaking DEBUG builds on ARM systems that have no memory
> below 4 GB.
>
>> +
>> + if (!EFI_ERROR (Status)) {
>> + Buffer = (VOID *) (UINTN) Address;
>> + ZeroMem (Buffer, Size);
>> + }
>> +
>> + return Buffer;
>> +}
>> +
>> +/**
>> + Allocate buffer for Boot Performance table.
>> +
>> + @return Status code.
>> +
>> +**/
>> +EFI_STATUS
>> +AllocateBootPerformanceTable (
>> + )
>> +{
>> + EFI_STATUS Status;
>> + UINTN Size;
>> + UINT8 *SmmBootRecordCommBuffer;
>> + EFI_SMM_COMMUNICATE_HEADER *SmmCommBufferHeader;
>> + SMM_BOOT_RECORD_COMMUNICATE *SmmCommData;
>> + UINTN CommSize;
>> + UINTN BootPerformanceDataSize;
>> + UINT8 *BootPerformanceData;
>> + EFI_SMM_COMMUNICATION_PROTOCOL *Communication;
>> + FIRMWARE_PERFORMANCE_VARIABLE PerformanceVariable;
>> + EDKII_PI_SMM_COMMUNICATION_REGION_TABLE *SmmCommRegionTable;
>> + EFI_MEMORY_DESCRIPTOR *SmmCommMemRegion;
>> + UINTN Index;
>> + VOID *SmmBootRecordData;
>> + UINTN SmmBootRecordDataSize;
>> + UINTN ReservedMemSize;
>> +
>> + //
>> + // Collect boot records from SMM drivers.
>> + //
>> + SmmBootRecordCommBuffer = NULL;
>> + SmmCommData = NULL;
>> + SmmBootRecordData = NULL;
>> + SmmBootRecordDataSize = 0;
>> + ReservedMemSize = 0;
>> + Status = gBS->LocateProtocol (&gEfiSmmCommunicationProtocolGuid, NULL, (VOID **) &Communication);
>> + if (!EFI_ERROR (Status)) {
>> + //
>> + // Initialize communicate buffer
>> + // Get the prepared Reserved Memory Range
>> + //
>> + Status = EfiGetSystemConfigurationTable (
>> + &gEdkiiPiSmmCommunicationRegionTableGuid,
>> + (VOID **) &SmmCommRegionTable
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + ASSERT (SmmCommRegionTable != NULL);
>> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) (SmmCommRegionTable + 1);
>> + for (Index = 0; Index < SmmCommRegionTable->NumberOfEntries; Index ++) {
>> + if (SmmCommMemRegion->Type == EfiConventionalMemory) {
>> + break;
>> + }
>> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) ((UINT8 *) SmmCommMemRegion + SmmCommRegionTable->DescriptorSize);
>> + }
>> + ASSERT (Index < SmmCommRegionTable->NumberOfEntries);
>> + ASSERT (SmmCommMemRegion->PhysicalStart > 0);
>> + ASSERT (SmmCommMemRegion->NumberOfPages > 0);
>> + ReservedMemSize = (UINTN) SmmCommMemRegion->NumberOfPages * EFI_PAGE_SIZE;
>> +
>> + //
>> + // Check enough reserved memory space
>> + //
>> + if (ReservedMemSize > SMM_BOOT_RECORD_COMM_SIZE) {
>> + SmmBootRecordCommBuffer = (VOID *) (UINTN) SmmCommMemRegion->PhysicalStart;
>> + SmmCommBufferHeader = (EFI_SMM_COMMUNICATE_HEADER*)SmmBootRecordCommBuffer;
>> + SmmCommData = (SMM_BOOT_RECORD_COMMUNICATE*)SmmCommBufferHeader->Data;
>> + ZeroMem((UINT8*)SmmCommData, sizeof(SMM_BOOT_RECORD_COMMUNICATE));
>> +
>> + CopyGuid (&SmmCommBufferHeader->HeaderGuid, &gEfiFirmwarePerformanceGuid);
>> + SmmCommBufferHeader->MessageLength = sizeof(SMM_BOOT_RECORD_COMMUNICATE);
>> + CommSize = SMM_BOOT_RECORD_COMM_SIZE;
>> +
>> + //
>> + // Get the size of boot records.
>> + //
>> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_SIZE;
>> + SmmCommData->BootRecordData = NULL;
>> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
>> + ASSERT_EFI_ERROR (Status);
>> +
>> + if (!EFI_ERROR (SmmCommData->ReturnStatus) && SmmCommData->BootRecordSize != 0) {
>> + //
>> + // Get all boot records
>> + //
>> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
>> + SmmBootRecordDataSize = SmmCommData->BootRecordSize;
>> + SmmBootRecordData = AllocateZeroPool(SmmBootRecordDataSize);
>> + ASSERT (SmmBootRecordData != NULL);
>> + SmmCommData->BootRecordOffset = 0;
>> + SmmCommData->BootRecordData = (VOID *) ((UINTN) SmmCommMemRegion->PhysicalStart + SMM_BOOT_RECORD_COMM_SIZE);
>> + SmmCommData->BootRecordSize = ReservedMemSize - SMM_BOOT_RECORD_COMM_SIZE;
>> + while (SmmCommData->BootRecordOffset < SmmBootRecordDataSize) {
>> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
>> + ASSERT_EFI_ERROR (Status);
>> + ASSERT_EFI_ERROR(SmmCommData->ReturnStatus);
>> + if (SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize > SmmBootRecordDataSize) {
>> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmBootRecordDataSize - SmmCommData->BootRecordOffset);
>> + } else {
>> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmCommData->BootRecordSize);
>> + }
>> + SmmCommData->BootRecordOffset = SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize;
>> + }
>> + }
>> + }
>> + }
>> + }
>> +
>> + //
>> + // Prepare memory for Boot Performance table.
>> + // Boot Performance table includes BasicBoot record, and one or more appended Boot Records.
>> + //
>> + BootPerformanceDataSize = sizeof (BOOT_PERFORMANCE_TABLE) + mPerformanceLength + PcdGet32 (PcdExtFpdtBootRecordPadSize);
>> + if (SmmCommData != NULL) {
>> + BootPerformanceDataSize += SmmBootRecordDataSize;
>> + }
>> +
>> + //
>> + // Try to allocate the same runtime buffer as last time boot.
>> + //
>> + ZeroMem (&PerformanceVariable, sizeof (PerformanceVariable));
>> + Size = sizeof (PerformanceVariable);
>> + Status = gRT->GetVariable (
>> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
>> + &gEfiFirmwarePerformanceGuid,
>> + NULL,
>> + &Size,
>> + &PerformanceVariable
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + Status = gBS->AllocatePages (
>> + AllocateAddress,
>> + EfiReservedMemoryType,
>> + EFI_SIZE_TO_PAGES (BootPerformanceDataSize),
>> + &PerformanceVariable.BootPerformanceTablePointer
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) (UINTN) PerformanceVariable.BootPerformanceTablePointer;
>> + }
>> + }
>> +
>> + if (mAcpiBootPerformanceTable == NULL) {
>> + //
>> + // Fail to allocate at specified address, continue to allocate at any address.
>> + //
>> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) FpdtAllocateReservedMemoryBelow4G (BootPerformanceDataSize);
>
> Why does this allocation need to live below 4 GB?
>
> If there is no good reason, can we please get rid of this?
> If there is a good reason, can we please document it in the code?
>
>> + }
>> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: ACPI Boot Performance Table address = 0x%x\n", mAcpiBootPerformanceTable));
>> +
>> + if (mAcpiBootPerformanceTable == NULL) {
>> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
>> + FreePool (SmmBootRecordData);
>> + }
>> + return EFI_OUT_OF_RESOURCES;
>> + }
>> +
>> + //
>> + // Prepare Boot Performance Table.
>> + //
>> + BootPerformanceData = (UINT8 *) mAcpiBootPerformanceTable;
>> + //
>> + // Fill Basic Boot record to Boot Performance Table.
>> + //
>> + CopyMem (mAcpiBootPerformanceTable, &mBootPerformanceTableTemplate, sizeof (mBootPerformanceTableTemplate));
>> + BootPerformanceData = BootPerformanceData + mAcpiBootPerformanceTable->Header.Length;
>> + //
>> + // Fill Boot records from boot drivers.
>> + //
>> + if (mPerformancePointer != NULL) {
>> + CopyMem (BootPerformanceData, mPerformancePointer, mPerformanceLength);
>> + mAcpiBootPerformanceTable->Header.Length += mPerformanceLength;
>> + BootPerformanceData = BootPerformanceData + mPerformanceLength;
>> + }
>> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
>> + //
>> + // Fill Boot records from SMM drivers.
>> + //
>> + CopyMem (BootPerformanceData, SmmBootRecordData, SmmBootRecordDataSize);
>> + FreePool (SmmBootRecordData);
>> + mAcpiBootPerformanceTable->Header.Length = (UINT32) (mAcpiBootPerformanceTable->Header.Length + SmmBootRecordDataSize);
>> + BootPerformanceData = BootPerformanceData + SmmBootRecordDataSize;
>> + }
>> +
>> + //
>> + // Save Boot Performance Table address to Variable for use in S4 resume.
>> + //
>> + PerformanceVariable.BootPerformanceTablePointer = (EFI_PHYSICAL_ADDRESS) (UINTN) mAcpiBootPerformanceTable;
>> +
>> + //
>> + // Save Runtime Performance Table pointers to Variable.
>> + // Don't check SetVariable return status. It doesn't impact FPDT table generation.
>> + //
>> + gRT->SetVariable (
>> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
>> + &gEfiFirmwarePerformanceGuid,
>> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
>> + sizeof (PerformanceVariable),
>> + &PerformanceVariable
>> + );
>> +
>> + mBootRecordBuffer = (UINT8 *) mAcpiBootPerformanceTable;
>> + mBootRecordSize = mAcpiBootPerformanceTable->Header.Length;
>> + mBootRecordMaxSize = mBootRecordSize + PcdGet32 (PcdExtFpdtBootRecordPadSize);
>> +
>> + return EFI_SUCCESS;
>> +}
>> +
>> +/**
>> + Get a human readable module name and module guid for the given image handle.
>> + If module name can't be found, "" string will return.
>> + If module guid can't be found, Zero Guid will return.
>> +
>> + @param Handle Image handle or Controller handle.
>> + @param NameString The ascii string will be filled into it. If not found, null string will return.
>> + @param BufferSize Size of the input NameString buffer.
>> + @param ModuleGuid Point to the guid buffer to store the got module guid value.
>> +
>> + @retval EFI_SUCCESS Successfully get module name and guid.
>> + @retval EFI_INVALID_PARAMETER The input parameter NameString is NULL.
>> + @retval other value Module Name can't be got.
>> +**/
>> +EFI_STATUS
>> +GetModuleInfoFromHandle (
>> + IN EFI_HANDLE Handle,
>> + OUT CHAR8 *NameString,
>> + IN UINTN BufferSize,
>> + OUT EFI_GUID *ModuleGuid OPTIONAL
>> + )
>> +{
>> + EFI_STATUS Status;
>> + EFI_LOADED_IMAGE_PROTOCOL *LoadedImage;
>> + EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
>> + CHAR8 *PdbFileName;
>> + EFI_GUID *TempGuid;
>> + UINTN StartIndex;
>> + UINTN Index;
>> + INTN Count;
>> + BOOLEAN ModuleGuidIsGet;
>> + UINTN StringSize;
>> + CHAR16 *StringPtr;
>> + EFI_COMPONENT_NAME2_PROTOCOL *ComponentName2;
>> + MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *FvFilePath;
>> +
>> + if (NameString == NULL || BufferSize == 0) {
>> + return EFI_INVALID_PARAMETER;
>> + }
>> + //
>> + // Try to get the ModuleGuid and name string form the caached array.
>> + //
>> + if (mCachePairCount > 0) {
>> + for (Count = mCachePairCount -1; Count >= 0; Count--) {
>> + if (Handle == mCacheHandleGuidTable[Count].Handle) {
>> + CopyGuid (ModuleGuid, &mCacheHandleGuidTable[Count].ModuleGuid);
>> + AsciiStrCpyS (NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, mCacheHandleGuidTable[Count].NameString);
>> + return EFI_SUCCESS;
>> + }
>> + }
>> + }
>> +
>> + Status = EFI_INVALID_PARAMETER;
>> + LoadedImage = NULL;
>> + ModuleGuidIsGet = FALSE;
>> +
>> + //
>> + // Initialize GUID as zero value.
>> + //
>> + TempGuid = &gZeroGuid;
>> + //
>> + // Initialize it as "" string.
>> + //
>> + NameString[0] = 0;
>> +
>> + if (Handle != NULL) {
>> + //
>> + // Try Handle as ImageHandle.
>> + //
>> + Status = gBS->HandleProtocol (
>> + Handle,
>> + &gEfiLoadedImageProtocolGuid,
>> + (VOID**) &LoadedImage
>> + );
>> +
>> + if (EFI_ERROR (Status)) {
>> + //
>> + // Try Handle as Controller Handle
>> + //
>> + Status = gBS->OpenProtocol (
>> + Handle,
>> + &gEfiDriverBindingProtocolGuid,
>> + (VOID **) &DriverBinding,
>> + NULL,
>> + NULL,
>> + EFI_OPEN_PROTOCOL_GET_PROTOCOL
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + //
>> + // Get Image protocol from ImageHandle
>> + //
>> + Status = gBS->HandleProtocol (
>> + DriverBinding->ImageHandle,
>> + &gEfiLoadedImageProtocolGuid,
>> + (VOID**) &LoadedImage
>> + );
>> + }
>> + }
>> + }
>> +
>> + if (!EFI_ERROR (Status) && LoadedImage != NULL) {
>> + //
>> + // Get Module Guid from DevicePath.
>> + //
>> + if (LoadedImage->FilePath != NULL &&
>> + LoadedImage->FilePath->Type == MEDIA_DEVICE_PATH &&
>> + LoadedImage->FilePath->SubType == MEDIA_PIWG_FW_FILE_DP
>> + ) {
>> + //
>> + // Determine GUID associated with module logging performance
>> + //
>> + ModuleGuidIsGet = TRUE;
>> + FvFilePath = (MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *) LoadedImage->FilePath;
>> + TempGuid = &FvFilePath->FvFileName;
>> + }
>> +
>> + //
>> + // Method 1 Get Module Name from PDB string.
>> + //
>> + PdbFileName = PeCoffLoaderGetPdbPointer (LoadedImage->ImageBase);
>> + if (PdbFileName != NULL && BufferSize > 0) {
>> + StartIndex = 0;
>> + for (Index = 0; PdbFileName[Index] != 0; Index++) {
>> + if ((PdbFileName[Index] == '\\') || (PdbFileName[Index] == '/')) {
>> + StartIndex = Index + 1;
>> + }
>> + }
>> + //
>> + // Copy the PDB file name to our temporary string.
>> + // If the length is bigger than BufferSize, trim the redudant characters to avoid overflow in array boundary.
>> + //
>> + for (Index = 0; Index < BufferSize - 1; Index++) {
>> + NameString[Index] = PdbFileName[Index + StartIndex];
>> + if (NameString[Index] == 0 || NameString[Index] == '.') {
>> + NameString[Index] = 0;
>> + break;
>> + }
>> + }
>>
>> - This internal function searches for the gauge entry in the gauge array.
>> - If there is an entry that exactly matches the given keywords
>> - and its end time stamp is zero, then the index of that gauge entry is returned;
>> - otherwise, the the number of gauge entries in the array is returned.
>> + if (Index == BufferSize - 1) {
>> + NameString[Index] = 0;
>> + }
>> + //
>> + // Module Name is got.
>> + //
>> + goto Done;
>> + }
>> + }
>>
>> + //
>> + // Method 2: Get the name string from ComponentName2 protocol
>> + //
>> + Status = gBS->HandleProtocol (
>> + Handle,
>> + &gEfiComponentName2ProtocolGuid,
>> + (VOID **) &ComponentName2
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + //
>> + // Get the current platform language setting
>> + //
>> + if (mPlatformLanguage == NULL) {
>> + GetEfiGlobalVariable2 (L"PlatformLang", (VOID **) &mPlatformLanguage, NULL);
>> + }
>> + if (mPlatformLanguage != NULL) {
>> + Status = ComponentName2->GetDriverName (
>> + ComponentName2,
>> + mPlatformLanguage != NULL ? mPlatformLanguage : "en-US",
>> + &StringPtr
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
>> + NameString[Index] = (CHAR8) StringPtr[Index];
>> + }
>> + NameString[Index] = 0;
>> + //
>> + // Module Name is got.
>> + //
>> + goto Done;
>> + }
>> + }
>> + }
>> +
>> + if (ModuleGuidIsGet) {
>> + //
>> + // Method 3 Try to get the image's FFS UI section by image GUID
>> + //
>> + StringPtr = NULL;
>> + StringSize = 0;
>> + Status = GetSectionFromAnyFv (
>> + TempGuid,
>> + EFI_SECTION_USER_INTERFACE,
>> + 0,
>> + (VOID **) &StringPtr,
>> + &StringSize
>> + );
>> +
>> + if (!EFI_ERROR (Status)) {
>> + //
>> + // Method 3. Get the name string from FFS UI section
>> + //
>> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
>> + NameString[Index] = (CHAR8) StringPtr[Index];
>> + }
>> + NameString[Index] = 0;
>> + FreePool (StringPtr);
>> + }
>> + }
>> +
>> +Done:
>> + //
>> + // Copy Module Guid
>> + //
>> + if (ModuleGuid != NULL) {
>> + CopyGuid (ModuleGuid, TempGuid);
>> + if (IsZeroGuid(TempGuid) && (Handle != NULL) && !ModuleGuidIsGet) {
>> + // Handle is GUID
>> + CopyGuid (ModuleGuid, (EFI_GUID *) Handle);
>> + }
>> + }
>> +
>> + //
>> + // Cache the Handle and Guid pairs.
>> + //
>> + if (mCachePairCount < CACHE_HANDLE_GUID_COUNT) {
>> + mCacheHandleGuidTable[mCachePairCount].Handle = Handle;
>> + CopyGuid (&mCacheHandleGuidTable[mCachePairCount].ModuleGuid, ModuleGuid);
>> + AsciiStrCpyS (mCacheHandleGuidTable[mCachePairCount].NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, NameString);
>> + mCachePairCount ++;
>> + }
>> +
>> + return Status;
>> +}
>> +
>> +/**
>> + Get the FPDT record info.
>> +
>> + @param IsStart TRUE if the performance log is start log.
>> @param Handle Pointer to environment specific context used
>> to identify the component being measured.
>> @param Token Pointer to a Null-terminated ASCII string
>> that identifies the component being measured.
>> @param Module Pointer to a Null-terminated ASCII string
>> that identifies the module being measured.
>> - @param Identifier 32-bit identifier.
>> + @param RecordInfo On return, pointer to the info of the record.
>> + @param UseModuleName Only useful for DYNAMIC_STRING_EVENT_TYPE, indicate that whether need use
>> + Module name to fill the string field in the DYNAMIC_STRING_EVENT_RECORD.
>>
>> - @retval The index of gauge entry in the array.
>> + @retval EFI_SUCCESS Get record info successfully.
>> + @retval EFI_UNSUPPORTED No matched FPDT record.
>>
>> **/
>> -UINT32
>> -InternalSearchForGaugeEntry (
>> - IN CONST VOID *Handle, OPTIONAL
>> - IN CONST CHAR8 *Token, OPTIONAL
>> - IN CONST CHAR8 *Module, OPTIONAL
>> - IN UINT32 Identifier
>> +EFI_STATUS
>> +GetFpdtRecordInfo (
>> + IN BOOLEAN IsStart,
>> + IN CONST VOID *Handle,
>> + IN CONST CHAR8 *Token,
>> + IN CONST CHAR8 *Module,
>> + OUT BASIC_RECORD_INFO *RecordInfo,
>> + IN OUT BOOLEAN *UseModuleName
>> )
>> {
>> - UINT32 Index;
>> - UINT32 Index2;
>> - UINT32 NumberOfEntries;
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>> + UINT16 RecordType;
>> + UINTN StringSize;
>>
>> - if (Token == NULL) {
>> - Token = "";
>> - }
>> - if (Module == NULL) {
>> - Module = "";
>> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
>> +
>> + //
>> + // Token to Type and Id.
>> + //
>> + if (Token != NULL) {
>> + if (AsciiStrCmp (Token, START_IMAGE_TOK) == 0) { // "StartImage:"
>> + *UseModuleName = TRUE;
>> + RecordType = GUID_EVENT_TYPE;
>> + if (IsStart) {
>> + RecordInfo->ProgressID = MODULE_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = MODULE_END_ID;
>> + }
>> + } else if (AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) { // "LoadImage:"
>> + *UseModuleName = TRUE;
>> + RecordType = GUID_QWORD_EVENT_TYPE;
>> + if (IsStart) {
>> + RecordInfo->ProgressID = MODULE_LOADIMAGE_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = MODULE_LOADIMAGE_END_ID;
>> + }
>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0) { // "DB:Start:"
>> + *UseModuleName = TRUE;
>> + if (IsStart) {
>> + RecordInfo->ProgressID = MODULE_DB_START_ID;
>> + RecordType = GUID_QWORD_EVENT_TYPE;
>> + } else {
>> + RecordInfo->ProgressID = MODULE_DB_END_ID;
>> + RecordType = GUID_QWORD_STRING_EVENT_TYPE;
>> + }
>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0) { // "DB:Support:"
>> + *UseModuleName = TRUE;
>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>> + return RETURN_UNSUPPORTED;
>> + }
>> + RecordType = GUID_QWORD_EVENT_TYPE;
>> + if (IsStart) {
>> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_END_ID;
>> + }
>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0) { // "DB:Stop:"
>> + *UseModuleName = TRUE;
>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>> + return RETURN_UNSUPPORTED;
>> + }
>> + RecordType = GUID_QWORD_EVENT_TYPE;
>> + if (IsStart) {
>> + RecordInfo->ProgressID = MODULE_DB_STOP_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = MODULE_DB_STOP_END_ID;
>> + }
>> + } else if (AsciiStrCmp (Token, PEI_TOK) == 0 || // "PEI"
>> + AsciiStrCmp (Token, DXE_TOK) == 0 || // "DXE"
>> + AsciiStrCmp (Token, BDS_TOK) == 0) { // "BDS"
>> + if (IsStart) {
>> + RecordInfo->ProgressID = PERF_CROSSMODULE_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = PERF_CROSSMODULE_END_ID;
>> + }
>> + } else { // Pref used in Modules.
>> + if (IsStart) {
>> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
>> + }
>> + }
>> + } else if (Handle!= NULL || Module != NULL) { // Pref used in Modules.
>> + if (IsStart) {
>> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
>> + }
>> + } else {
>> + return EFI_UNSUPPORTED;
>> }
>>
>> - NumberOfEntries = mGaugeData->NumberOfEntries;
>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>> + //
>> + // Get Record size baesed on the record type.
>> + // When PcdEdkiiFpdtStringRecordEnableOnly is TRUE, all records are with type of DYNAMIC_STRING_EVENT_TYPE.
>> + //
>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
>> + RecordInfo->RecordSize = sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE;
>> + } else {
>> + switch (RecordType) {
>> + case GUID_EVENT_TYPE:
>> + RecordInfo->RecordSize = sizeof (GUID_EVENT_RECORD);
>> + break;
>>
>> - Index2 = 0;
>> + case DYNAMIC_STRING_EVENT_TYPE:
>> + if (*UseModuleName) {
>> + StringSize = STRING_SIZE;
>> + } else if (Token != NULL) {
>> + StringSize = AsciiStrSize (Token);
>> + } else if (Module != NULL) {
>> + StringSize = AsciiStrSize (Module);
>> + } else {
>> + StringSize = STRING_SIZE;
>> + }
>> + if (StringSize > STRING_SIZE) {
>> + StringSize = STRING_SIZE;
>> + }
>> + RecordInfo->RecordSize = (UINT8)(sizeof (DYNAMIC_STRING_EVENT_RECORD) + StringSize);
>> + break;
>>
>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>> - Index2 = NumberOfEntries - 1 - Index;
>> - if (GaugeEntryExArray[Index2].EndTimeStamp == 0 &&
>> - (GaugeEntryExArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&
>> - AsciiStrnCmp (GaugeEntryExArray[Index2].Token, Token, DXE_PERFORMANCE_STRING_LENGTH) == 0 &&
>> - AsciiStrnCmp (GaugeEntryExArray[Index2].Module, Module, DXE_PERFORMANCE_STRING_LENGTH) == 0) {
>> - Index = Index2;
>> + case GUID_QWORD_EVENT_TYPE:
>> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_EVENT_RECORD);
>> break;
>> +
>> + case GUID_QWORD_STRING_EVENT_TYPE:
>> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_STRING_EVENT_RECORD);
>> + break;
>> +
>> + default:
>> + //
>> + // Record is unsupported yet, return EFI_UNSUPPORTED
>> + //
>> + return EFI_UNSUPPORTED;
>> }
>> }
>>
>> - return Index;
>> + RecordInfo->Type = RecordType;
>> + return EFI_SUCCESS;
>> }
>>
>> /**
>> - Adds a record at the end of the performance measurement log
>> - that records the start time of a performance measurement.
>> -
>> - Adds a record to the end of the performance measurement log
>> - that contains the Handle, Token, Module and Identifier.
>> - The end time of the new record must be set to zero.
>> - If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
>> - If TimeStamp is zero, the start time in the record is filled in with the value
>> - read from the current time stamp.
>> + Add performance log to FPDT boot record table.
>>
>> + @param IsStart TRUE if the performance log is start log.
>> @param Handle Pointer to environment specific context used
>> to identify the component being measured.
>> @param Token Pointer to a Null-terminated ASCII string
>> that identifies the component being measured.
>> @param Module Pointer to a Null-terminated ASCII string
>> that identifies the module being measured.
>> - @param TimeStamp 64-bit time stamp.
>> + @param Ticker 64-bit time stamp.
>> @param Identifier 32-bit identifier. If the value is 0, the created record
>> is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>>
>> - @retval EFI_SUCCESS The data was read correctly from the device.
>> + @retval EFI_SUCCESS Add FPDT boot record.
>> @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>> + @retval EFI_UNSUPPORTED No matched FPDT record.
>>
>> **/
>> EFI_STATUS
>> -EFIAPI
>> -StartGaugeEx (
>> +InsertFpdtMeasurement (
>> + IN BOOLEAN IsStart,
>> IN CONST VOID *Handle, OPTIONAL
>> IN CONST CHAR8 *Token, OPTIONAL
>> IN CONST CHAR8 *Module, OPTIONAL
>> - IN UINT64 TimeStamp,
>> + IN UINT64 Ticker,
>> IN UINT32 Identifier
>> )
>> {
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>> - UINTN GaugeDataSize;
>> - GAUGE_DATA_HEADER *NewGaugeData;
>> - UINTN OldGaugeDataSize;
>> - GAUGE_DATA_HEADER *OldGaugeData;
>> - UINT32 Index;
>> - EFI_STATUS Status;
>> + EFI_GUID ModuleGuid;
>> + CHAR8 ModuleName[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
>> + UINT8 FpdtRecord[MAX_RECORD_SIZE];
>> + EFI_STATUS Status;
>> + FPDT_RECORD_PTR FpdtRecordPtr;
>> + BASIC_RECORD_INFO RecordInfo;
>> + UINT64 TimeStamp;
>> + UINTN DestMax;
>> + UINTN StrLength;
>> + CONST CHAR8 *StringPtr;
>> + BOOLEAN UseModuleName;
>> +
>> + StringPtr = NULL;
>> + UseModuleName = FALSE;
>> + ZeroMem (ModuleName, sizeof (ModuleName));
>> + ZeroMem (FpdtRecord, sizeof (FpdtRecord));
>>
>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>> + //
>> + // Get record info (type, size, ProgressID and Module Guid).
>> + //
>> + Status = GetFpdtRecordInfo (IsStart, Handle, Token, Module, &RecordInfo, &UseModuleName);
>> if (EFI_ERROR (Status)) {
>> return Status;
>> }
>>
>> - Index = mGaugeData->NumberOfEntries;
>> - if (Index >= mMaxGaugeRecords) {
>> + //
>> + // If PERF_START()/PERF_END() have specified the ProgressID,it has high priority.
>> + // !!! Note: If the Pref is not the known Token used in the core but have same
>> + // ID with the core Token, this case will not be supported.
>> + // And in currtnt usage mode, for the unkown ID, there is a general rule:
>> + // If it is start pref: the lower 4 bits of the ID should be 0.
>> + // If it is end pref: the lower 4 bits of the ID should not be 0.
>> + // If input ID doesn't follow the rule, we will adjust it.
>> + //
>> + if ((Identifier != 0) && (IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
>> + return EFI_UNSUPPORTED;
>> + } else if ((Identifier != 0) && (!IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
>> + if (IsStart && ((Identifier & 0x000F) != 0)) {
>> + Identifier &= 0xFFF0;
>> + } else if ((!IsStart) && ((Identifier & 0x000F) == 0)) {
>> + Identifier += 1;
>> + }
>> + RecordInfo.ProgressID = (UINT16)Identifier;
>> + }
>> +
>> + if (mFpdtBufferIsReported) {
>> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)FpdtRecord;
>> + } else {
>> + //
>> + // Check if pre-allocated buffer is full
>> //
>> - // Try to enlarge the scale of gauge array.
>> + if (mPerformanceLength + RecordInfo.RecordSize > mMaxPerformanceLength) {
>> + mPerformancePointer = ReallocatePool (
>> + mPerformanceLength,
>> + mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER,
>> + mPerformancePointer
>> + );
>> +
>> + if (mPerformancePointer == NULL) {
>> + return EFI_OUT_OF_RESOURCES;
>> + }
>> + mMaxPerformanceLength = mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER;
>> + }
>> //
>> - OldGaugeData = mGaugeData;
>> - OldGaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords;
>> + // Covert buffer to FPDT Ptr Union type.
>> + //
>> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(mPerformancePointer + mPerformanceLength);
>> + }
>> + FpdtRecordPtr.RecordHeader->Length = 0;
>>
>> - GaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords * 2;
>> + //
>> + // Get the TimeStamp.
>> + //
>> + if (Ticker == 0) {
>> + Ticker = GetPerformanceCounter ();
>> + TimeStamp = GetTimeInNanoSecond (Ticker);
>> + } else if (Ticker == 1) {
>> + TimeStamp = 0;
>> + } else {
>> + TimeStamp = GetTimeInNanoSecond (Ticker);
>> + }
>>
>> - NewGaugeData = AllocateZeroPool (GaugeDataSize);
>> - if (NewGaugeData == NULL) {
>> - EfiReleaseLock (&mPerfRecordLock);
>> - return EFI_OUT_OF_RESOURCES;
>> + //
>> + // Get the ModuleName and ModuleGuid form the handle.
>> + //
>> + GetModuleInfoFromHandle ((EFI_HANDLE *)Handle, ModuleName, sizeof (ModuleName), &ModuleGuid);
>> +
>> + //
>> + // Fill in the record information.
>> + //
>> + switch (RecordInfo.Type) {
>> + case GUID_EVENT_TYPE:
>> + FpdtRecordPtr.GuidEvent->Header.Type = GUID_EVENT_TYPE;
>> + FpdtRecordPtr.GuidEvent->Header.Length = RecordInfo.RecordSize;
>> + FpdtRecordPtr.GuidEvent->Header.Revision = RECORD_REVISION_1;
>> + FpdtRecordPtr.GuidEvent->ProgressID = RecordInfo.ProgressID;
>> + FpdtRecordPtr.GuidEvent->Timestamp = TimeStamp;
>> + CopyMem (&FpdtRecordPtr.GuidEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidEvent->Guid));
>> + break;
>> +
>> + case DYNAMIC_STRING_EVENT_TYPE:
>> + FpdtRecordPtr.DynamicStringEvent->Header.Type = DYNAMIC_STRING_EVENT_TYPE;
>> + FpdtRecordPtr.DynamicStringEvent->Header.Length = RecordInfo.RecordSize;
>> + FpdtRecordPtr.DynamicStringEvent->Header.Revision = RECORD_REVISION_1;
>> + FpdtRecordPtr.DynamicStringEvent->ProgressID = RecordInfo.ProgressID;
>> + FpdtRecordPtr.DynamicStringEvent->Timestamp = TimeStamp;
>> + CopyMem (&FpdtRecordPtr.DynamicStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.DynamicStringEvent->Guid));
>> +
>> + if (UseModuleName) {
>> + StringPtr = ModuleName;
>> + } else if (Token != NULL) {
>> + StringPtr = Token;
>> + } else if (Module != NULL) {
>> + StringPtr = Module;
>> + } else if (ModuleName != NULL) {
>> + StringPtr = ModuleName;
>> + }
>> + if (StringPtr != NULL && AsciiStrLen (StringPtr) != 0) {
>> + StrLength = AsciiStrLen (StringPtr);
>> + DestMax = (RecordInfo.RecordSize - sizeof (DYNAMIC_STRING_EVENT_RECORD)) / sizeof (CHAR8);
>> + if (StrLength >= DestMax) {
>> + StrLength = DestMax -1;
>> + }
>> + AsciiStrnCpyS (FpdtRecordPtr.DynamicStringEvent->String, DestMax, StringPtr, StrLength);
>> }
>> + break;
>> +
>> + case GUID_QWORD_EVENT_TYPE:
>> + FpdtRecordPtr.GuidQwordEvent->Header.Type = GUID_QWORD_EVENT_TYPE;
>> + FpdtRecordPtr.GuidQwordEvent->Header.Length = RecordInfo.RecordSize;
>> + FpdtRecordPtr.GuidQwordEvent->Header.Revision = RECORD_REVISION_1;
>> + FpdtRecordPtr.GuidQwordEvent->ProgressID = RecordInfo.ProgressID;
>> + FpdtRecordPtr.GuidQwordEvent->Timestamp = TimeStamp;
>> + CopyMem (&FpdtRecordPtr.GuidQwordEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordEvent->Guid));
>> + if ((MODULE_LOADIMAGE_START_ID == RecordInfo.ProgressID) && AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) {
>> + mLoadImageCount++;
>> + FpdtRecordPtr.GuidQwordEvent->Qword = mLoadImageCount;
>> + }
>> + break;
>> +
>> + case GUID_QWORD_STRING_EVENT_TYPE:
>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Type = GUID_QWORD_STRING_EVENT_TYPE;
>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Length = RecordInfo.RecordSize;
>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Revision = RECORD_REVISION_1;
>> + FpdtRecordPtr.GuidQwordStringEvent->ProgressID = RecordInfo.ProgressID;
>> + FpdtRecordPtr.GuidQwordStringEvent->Timestamp = TimeStamp;
>> + CopyMem (&FpdtRecordPtr.GuidQwordStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordStringEvent->Guid));
>> + break;
>> +
>> + default:
>> + //
>> + // Record is not supported in current DXE phase, return EFI_ABORTED
>> + //
>> + return EFI_UNSUPPORTED;
>> + }
>> +
>> + //
>> + // Report record one by one after records have been reported together.
>> + //
>> + if (mFpdtBufferIsReported) {
>> + //
>> + // Append Boot records to the boot performance table.
>> + //
>> + if (mBootRecordSize + FpdtRecordPtr.RecordHeader->Length > mBootRecordMaxSize) {
>> + if (!mLackSpaceIsReported) {
>> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: No enough space to save boot records\n"));
>> + mLackSpaceIsReported = TRUE;
>> + }
>> + return EFI_OUT_OF_RESOURCES;
>> + } else {
>> + //
>> + // Save boot record into BootPerformance table
>> + //
>> + CopyMem (mBootRecordBuffer + mBootRecordSize, FpdtRecordPtr.RecordHeader, FpdtRecordPtr.RecordHeader->Length);
>> + mBootRecordSize += FpdtRecordPtr.RecordHeader->Length;
>> + mAcpiBootPerformanceTable->Header.Length += FpdtRecordPtr.RecordHeader->Length;
>> + }
>> + } else {
>> + //
>> + // Update the cached FPDT record buffer.
>> + //
>> + mPerformanceLength += FpdtRecordPtr.RecordHeader->Length;
>> + }
>> +
>> + return EFI_SUCCESS;
>> +}
>> +
>> +/**
>> + Dumps all the PEI performance.
>> +
>> + @param HobStart A pointer to a Guid.
>>
>> - mGaugeData = NewGaugeData;
>> - mMaxGaugeRecords *= 2;
>> + This internal function dumps all the PEI performance log to the DXE performance gauge array.
>> + It retrieves the optional GUID HOB for PEI performance and then saves the performance data
>> + to DXE performance data structures.
>>
>> +**/
>> +VOID
>> +InternalGetPeiPerformance (
>> + VOID *HobStart
>> + )
>> +{
>> + UINT8 *FirmwarePerformanceHob;
>> + PEI_EXT_FIRMWARE_PERF_HEADER *PeiPerformanceLogHeader;
>> + UINT8 *EventRec;
>> + EFI_HOB_GUID_TYPE *GuidHob;
>> +
>> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, HobStart);
>> + while (GuidHob != NULL) {
>> + FirmwarePerformanceHob = GET_GUID_HOB_DATA (GuidHob);
>> + PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *)FirmwarePerformanceHob;
>> +
>> + if (mPerformanceLength + PeiPerformanceLogHeader->SizeOfAllEntries > mMaxPerformanceLength) {
>> + mPerformancePointer = ReallocatePool (
>> + mPerformanceLength,
>> + mPerformanceLength +
>> + (UINTN)PeiPerformanceLogHeader->SizeOfAllEntries +
>> + FIRMWARE_RECORD_BUFFER,
>> + mPerformancePointer
>> + );
>> + ASSERT (mPerformancePointer != NULL);
>> + mMaxPerformanceLength = mPerformanceLength +
>> + (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries) +
>> + FIRMWARE_RECORD_BUFFER;
>> + }
>> +
>> + EventRec = mPerformancePointer + mPerformanceLength;
>> + CopyMem (EventRec, FirmwarePerformanceHob + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER), (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries));
>> //
>> - // Initialize new data array and migrate old data one.
>> + // Update the used buffer size.
>> //
>> - mGaugeData = CopyMem (mGaugeData, OldGaugeData, OldGaugeDataSize);
>> + mPerformanceLength += (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries);
>> + mLoadImageCount += PeiPerformanceLogHeader->LoadImageCount;
>>
>> - FreePool (OldGaugeData);
>> + //
>> + // Get next performance guid hob
>> + //
>> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, GET_NEXT_HOB (GuidHob));
>> }
>> +}
>>
>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>> - GaugeEntryExArray[Index].Handle = (EFI_PHYSICAL_ADDRESS) (UINTN) Handle;
>> +/**
>> + Report Boot Perforamnce table address as report status code.
>>
>> - if (Token != NULL) {
>> - AsciiStrnCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, Token, DXE_PERFORMANCE_STRING_LENGTH);
>> - }
>> - if (Module != NULL) {
>> - AsciiStrnCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, Module, DXE_PERFORMANCE_STRING_LENGTH);
>> + @param Event The event of notify protocol.
>> + @param Context Notify event context.
>> +
>> +**/
>> +VOID
>> +EFIAPI
>> +ReportFpdtRecordBuffer (
>> + IN EFI_EVENT Event,
>> + IN VOID *Context
>> + )
>> +{
>> + EFI_STATUS Status;
>> + UINT64 BPDTAddr;
>> +
>> + if (!mFpdtBufferIsReported) {
>> + Status = AllocateBootPerformanceTable ();
>> + if (!EFI_ERROR(Status)) {
>> + BPDTAddr = (UINT64)(UINTN)mAcpiBootPerformanceTable;
>> + REPORT_STATUS_CODE_EX (
>> + EFI_PROGRESS_CODE,
>> + EFI_SOFTWARE_DXE_BS_DRIVER,
>> + 0,
>> + NULL,
>> + &gEfiFirmwarePerformanceGuid,
>> + &BPDTAddr,
>> + sizeof (UINT64)
>> + );
>> + }
>> + //
>> + // Free Cached FPDT record Buffer
>> + //
>> + if (mPerformancePointer != NULL) {
>> + FreePool (mPerformancePointer);
>> + mPerformancePointer = NULL;
>> + }
>> + mPerformanceLength = 0;
>> + mMaxPerformanceLength = 0;
>> + //
>> + // Set FPDT report state to TRUE.
>> + //
>> + mFpdtBufferIsReported = TRUE;
>> }
>> +}
>>
>> - GaugeEntryExArray[Index].EndTimeStamp = 0;
>> - GaugeEntryExArray[Index].Identifier = Identifier;
>> +/**
>> + Adds a record at the end of the performance measurement log
>> + that records the start time of a performance measurement.
>>
>> - if (TimeStamp == 0) {
>> - TimeStamp = GetPerformanceCounter ();
>> - }
>> - GaugeEntryExArray[Index].StartTimeStamp = TimeStamp;
>> + Adds a record to the end of the performance measurement log
>> + that contains the Handle, Token, Module and Identifier.
>> + The end time of the new record must be set to zero.
>> + If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
>> + If TimeStamp is zero, the start time in the record is filled in with the value
>> + read from the current time stamp.
>>
>> - mGaugeData->NumberOfEntries++;
>> + @param Handle Pointer to environment specific context used
>> + to identify the component being measured.
>> + @param Token Pointer to a Null-terminated ASCII string
>> + that identifies the component being measured.
>> + @param Module Pointer to a Null-terminated ASCII string
>> + that identifies the module being measured.
>> + @param TimeStamp 64-bit time stamp.
>> + @param Identifier 32-bit identifier. If the value is 0, the created record
>> + is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>>
>> - EfiReleaseLock (&mPerfRecordLock);
>> + @retval EFI_SUCCESS The data was read correctly from the device.
>> + @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>>
>> - return EFI_SUCCESS;
>> +**/
>> +EFI_STATUS
>> +EFIAPI
>> +StartGaugeEx (
>> + IN CONST VOID *Handle, OPTIONAL
>> + IN CONST CHAR8 *Token, OPTIONAL
>> + IN CONST CHAR8 *Module, OPTIONAL
>> + IN UINT64 TimeStamp,
>> + IN UINT32 Identifier
>> + )
>> +{
>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
>> }
>>
>> /**
>> Searches the performance measurement log from the beginning of the log
>> for the first matching record that contains a zero end time and fills in a valid end time.
>>
>> Searches the performance measurement log from the beginning of the log
>> - for the first record that matches Handle, Token and Module and has an end time value of zero.
>> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
>> If the record can not be found then return EFI_NOT_FOUND.
>> If the record is found and TimeStamp is not zero,
>> then the end time in the record is filled in with the value specified by TimeStamp.
>> If the record is found and TimeStamp is zero, then the end time in the matching record
>> is filled in with the current time stamp value.
>> @@ -260,89 +1188,19 @@ EndGaugeEx (
>> IN CONST CHAR8 *Module, OPTIONAL
>> IN UINT64 TimeStamp,
>> IN UINT32 Identifier
>> )
>> {
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>> - UINT32 Index;
>> - EFI_STATUS Status;
>> -
>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>> - if (EFI_ERROR (Status)) {
>> - return Status;
>> - }
>> -
>> - if (TimeStamp == 0) {
>> - TimeStamp = GetPerformanceCounter ();
>> - }
>> -
>> - Index = InternalSearchForGaugeEntry (Handle, Token, Module, Identifier);
>> - if (Index >= mGaugeData->NumberOfEntries) {
>> - EfiReleaseLock (&mPerfRecordLock);
>> - return EFI_NOT_FOUND;
>> - }
>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>> - GaugeEntryExArray[Index].EndTimeStamp = TimeStamp;
>> -
>> - EfiReleaseLock (&mPerfRecordLock);
>> - return EFI_SUCCESS;
>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
>> }
>>
>> /**
>> Retrieves a previously logged performance measurement.
>> It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
>> and then assign the Identifier with 0.
>>
>> - Retrieves the performance log entry from the performance log specified by LogEntryKey.
>> - If it stands for a valid entry, then EFI_SUCCESS is returned and
>> - GaugeDataEntryEx stores the pointer to that entry.
>> -
>> - This internal function is added to avoid releasing lock before each return statement.
>> -
>> - @param LogEntryKey The key for the previous performance measurement log entry.
>> - If 0, then the first performance measurement log entry is retrieved.
>> - @param GaugeDataEntryEx The indirect pointer to the extended gauge data entry specified by LogEntryKey
>> - if the retrieval is successful.
>> -
>> - @retval EFI_SUCCESS The GuageDataEntryEx is successfully found based on LogEntryKey.
>> - @retval EFI_NOT_FOUND The LogEntryKey is the last entry (equals to the total entry number).
>> - @retval EFI_INVALIDE_PARAMETER The LogEntryKey is not a valid entry (greater than the total entry number).
>> - @retval EFI_INVALIDE_PARAMETER GaugeDataEntryEx is NULL.
>> -
>> -**/
>> -EFI_STATUS
>> -EFIAPI
>> -InternalGetGaugeEx (
>> - IN UINTN LogEntryKey,
>> - OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
>> - )
>> -{
>> - UINTN NumberOfEntries;
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>> -
>> - NumberOfEntries = (UINTN) (mGaugeData->NumberOfEntries);
>> - if (LogEntryKey > NumberOfEntries) {
>> - return EFI_INVALID_PARAMETER;
>> - }
>> - if (LogEntryKey == NumberOfEntries) {
>> - return EFI_NOT_FOUND;
>> - }
>> -
>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>> -
>> - if (GaugeDataEntryEx == NULL) {
>> - return EFI_INVALID_PARAMETER;
>> - }
>> - *GaugeDataEntryEx = &GaugeEntryExArray[LogEntryKey];
>> -
>> - return EFI_SUCCESS;
>> -}
>> -
>> -/**
>> - Retrieves a previously logged performance measurement.
>> - It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
>> - and then assign the Identifier with 0.
>> + !!! Not support!!!
>>
>> Retrieves the performance log entry from the performance log specified by LogEntryKey.
>> If it stands for a valid entry, then EFI_SUCCESS is returned and
>> GaugeDataEntryEx stores the pointer to that entry.
>>
>> @@ -362,22 +1220,11 @@ EFIAPI
>> GetGaugeEx (
>> IN UINTN LogEntryKey,
>> OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
>> )
>> {
>> - EFI_STATUS Status;
>> -
>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>> - if (EFI_ERROR (Status)) {
>> - return Status;
>> - }
>> -
>> - Status = InternalGetGaugeEx (LogEntryKey, GaugeDataEntryEx);
>> -
>> - EfiReleaseLock (&mPerfRecordLock);
>> -
>> - return Status;
>> + return EFI_UNSUPPORTED;
>> }
>>
>> /**
>> Adds a record at the end of the performance measurement log
>> that records the start time of a performance measurement.
>> @@ -452,10 +1299,12 @@ EndGauge (
>> /**
>> Retrieves a previously logged performance measurement.
>> It can also retrieve the log created by StartGaugeEx and EndGaugeEx of PERFORMANCE_EX_PROTOCOL,
>> and then eliminate the Identifier.
>>
>> + !!! Not support!!!
>> +
>> Retrieves the performance log entry from the performance log specified by LogEntryKey.
>> If it stands for a valid entry, then EFI_SUCCESS is returned and
>> GaugeDataEntry stores the pointer to that entry.
>>
>> @param LogEntryKey The key for the previous performance measurement log entry.
>> @@ -474,81 +1323,13 @@ EFIAPI
>> GetGauge (
>> IN UINTN LogEntryKey,
>> OUT GAUGE_DATA_ENTRY **GaugeDataEntry
>> )
>> {
>> - EFI_STATUS Status;
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryEx;
>> -
>> - GaugeEntryEx = NULL;
>> -
>> - Status = GetGaugeEx (LogEntryKey, &GaugeEntryEx);
>> - if (EFI_ERROR (Status)) {
>> - return Status;
>> - }
>> -
>> - if (GaugeDataEntry == NULL) {
>> - return EFI_INVALID_PARAMETER;
>> - }
>> -
>> - *GaugeDataEntry = (GAUGE_DATA_ENTRY *) GaugeEntryEx;
>> -
>> - return EFI_SUCCESS;
>> + return EFI_UNSUPPORTED;
>> }
>>
>> -/**
>> - Dumps all the PEI performance log to DXE performance gauge array.
>> -
>> - This internal function dumps all the PEI performance log to the DXE performance gauge array.
>> - It retrieves the optional GUID HOB for PEI performance and then saves the performance data
>> - to DXE performance data structures.
>> -
>> -**/
>> -VOID
>> -InternalGetPeiPerformance (
>> - VOID
>> - )
>> -{
>> - EFI_HOB_GUID_TYPE *GuidHob;
>> - PEI_PERFORMANCE_LOG_HEADER *LogHob;
>> - PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
>> - UINT32 *LogIdArray;
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>> - UINT32 Index;
>> - UINT32 NumberOfEntries;
>> -
>> - NumberOfEntries = 0;
>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>> -
>> - //
>> - // Dump PEI Log Entries to DXE Guage Data structure.
>> - //
>> - GuidHob = GetFirstGuidHob (&gPerformanceProtocolGuid);
>> - if (GuidHob != NULL) {
>> - LogHob = GET_GUID_HOB_DATA (GuidHob);
>> - LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (LogHob + 1);
>> -
>> - NumberOfEntries = LogHob->NumberOfEntries;
>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>> - GaugeEntryExArray[Index].Handle = LogEntryArray[Index].Handle;
>> - AsciiStrCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Token);
>> - AsciiStrCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Module);
>> - GaugeEntryExArray[Index].StartTimeStamp = LogEntryArray[Index].StartTimeStamp;
>> - GaugeEntryExArray[Index].EndTimeStamp = LogEntryArray[Index].EndTimeStamp;
>> - GaugeEntryExArray[Index].Identifier = 0;
>> - }
>> -
>> - GuidHob = GetFirstGuidHob (&gPerformanceExProtocolGuid);
>> - if (GuidHob != NULL) {
>> - LogIdArray = GET_GUID_HOB_DATA (GuidHob);
>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>> - GaugeEntryExArray[Index].Identifier = LogIdArray[Index];
>> - }
>> - }
>> - }
>> - mGaugeData->NumberOfEntries = NumberOfEntries;
>> -}
>>
>> /**
>> The constructor function initializes Performance infrastructure for DXE phase.
>>
>> The constructor function publishes Performance and PerformanceEx protocol, allocates memory to log DXE performance
>> @@ -567,40 +1348,53 @@ DxeCorePerformanceLibConstructor (
>> IN EFI_HANDLE ImageHandle,
>> IN EFI_SYSTEM_TABLE *SystemTable
>> )
>> {
>> EFI_STATUS Status;
>> + EFI_HANDLE Handle;
>> + EFI_EVENT ReadyToBootEvent;
>> PERFORMANCE_PROPERTY *PerformanceProperty;
>>
>> -
>> if (!PerformanceMeasurementEnabled ()) {
>> //
>> // Do not initialize performance infrastructure if not required.
>> //
>> return EFI_SUCCESS;
>> }
>> +
>> + //
>> + // Dump normal PEI performance records
>> + //
>> + InternalGetPeiPerformance (GetHobList());
>> +
>> //
>> - // Install the protocol interfaces.
>> + // Install the protocol interfaces for DXE performance library instance.
>> //
>> + Handle = NULL;
>> Status = gBS->InstallMultipleProtocolInterfaces (
>> - &mHandle,
>> + &Handle,
>> &gPerformanceProtocolGuid,
>> &mPerformanceInterface,
>> &gPerformanceExProtocolGuid,
>> &mPerformanceExInterface,
>> NULL
>> );
>> ASSERT_EFI_ERROR (Status);
>>
>> - mMaxGaugeRecords = INIT_DXE_GAUGE_DATA_ENTRIES + (UINT16) (PcdGet16 (PcdMaxPeiPerformanceLogEntries16) != 0 ?
>> - PcdGet16 (PcdMaxPeiPerformanceLogEntries16) :
>> - PcdGet8 (PcdMaxPeiPerformanceLogEntries));
>> -
>> - mGaugeData = AllocateZeroPool (sizeof (GAUGE_DATA_HEADER) + (sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords));
>> - ASSERT (mGaugeData != NULL);
>> + //
>> + // Register ReadyToBoot event to report StatusCode data
>> + //
>> + Status = gBS->CreateEventEx (
>> + EVT_NOTIFY_SIGNAL,
>> + TPL_CALLBACK,
>> + ReportFpdtRecordBuffer,
>> + NULL,
>> + &gEfiEventReadyToBootGuid,
>> + &ReadyToBootEvent
>> + );
>>
>> - InternalGetPeiPerformance ();
>> + ASSERT_EFI_ERROR (Status);
>>
>> Status = EfiGetSystemConfigurationTable (&gPerformanceProtocolGuid, (VOID **) &PerformanceProperty);
>> if (EFI_ERROR (Status)) {
>> //
>> // Install configuration table for performance property.
>> @@ -651,19 +1445,19 @@ StartPerformanceMeasurementEx (
>> IN CONST CHAR8 *Module, OPTIONAL
>> IN UINT64 TimeStamp,
>> IN UINT32 Identifier
>> )
>> {
>> - return (RETURN_STATUS) StartGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
>> }
>>
>> /**
>> Searches the performance measurement log from the beginning of the log
>> for the first matching record that contains a zero end time and fills in a valid end time.
>>
>> Searches the performance measurement log from the beginning of the log
>> - for the first record that matches Handle, Token and Module and has an end time value of zero.
>> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
>> If the record can not be found then return RETURN_NOT_FOUND.
>> If the record is found and TimeStamp is not zero,
>> then the end time in the record is filled in with the value specified by TimeStamp.
>> If the record is found and TimeStamp is zero, then the end time in the matching record
>> is filled in with the current time stamp value.
>> @@ -690,18 +1484,20 @@ EndPerformanceMeasurementEx (
>> IN CONST CHAR8 *Module, OPTIONAL
>> IN UINT64 TimeStamp,
>> IN UINT32 Identifier
>> )
>> {
>> - return (RETURN_STATUS) EndGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
>> }
>>
>> /**
>> Attempts to retrieve a performance measurement log entry from the performance measurement log.
>> It can also retrieve the log created by StartPerformanceMeasurement and EndPerformanceMeasurement,
>> and then assign the Identifier with 0.
>>
>> + !!! Not support!!!
>> +
>> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
>> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
>> and the key for the second entry in the log is returned. If the performance log is empty,
>> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
>> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
>> @@ -729,63 +1525,29 @@ EndPerformanceMeasurementEx (
>> being measured.
>> @param StartTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
>> was started.
>> @param EndTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
>> was ended.
>> - @param Identifier Pointer to the 32-bit identifier that was recorded.
>> + @param Identifier Pointer to the 32-bit identifier that was recorded when the measurement
>> + was ended.
>>
>> @return The key for the next performance log entry (in general case).
>>
>> **/
>> UINTN
>> EFIAPI
>> GetPerformanceMeasurementEx (
>> - IN UINTN LogEntryKey,
>> + IN UINTN LogEntryKey,
>> OUT CONST VOID **Handle,
>> OUT CONST CHAR8 **Token,
>> OUT CONST CHAR8 **Module,
>> OUT UINT64 *StartTimeStamp,
>> OUT UINT64 *EndTimeStamp,
>> OUT UINT32 *Identifier
>> )
>> {
>> - EFI_STATUS Status;
>> - GAUGE_DATA_ENTRY_EX *GaugeData;
>> -
>> - GaugeData = NULL;
>> -
>> - ASSERT (Handle != NULL);
>> - ASSERT (Token != NULL);
>> - ASSERT (Module != NULL);
>> - ASSERT (StartTimeStamp != NULL);
>> - ASSERT (EndTimeStamp != NULL);
>> - ASSERT (Identifier != NULL);
>> -
>> - Status = GetGaugeEx (LogEntryKey++, &GaugeData);
>> -
>> - //
>> - // Make sure that LogEntryKey is a valid log entry key,
>> - //
>> - ASSERT (Status != EFI_INVALID_PARAMETER);
>> -
>> - if (EFI_ERROR (Status)) {
>> - //
>> - // The LogEntryKey is the last entry (equals to the total entry number).
>> - //
>> - return 0;
>> - }
>> -
>> - ASSERT (GaugeData != NULL);
>> -
>> - *Handle = (VOID *) (UINTN) GaugeData->Handle;
>> - *Token = GaugeData->Token;
>> - *Module = GaugeData->Module;
>> - *StartTimeStamp = GaugeData->StartTimeStamp;
>> - *EndTimeStamp = GaugeData->EndTimeStamp;
>> - *Identifier = GaugeData->Identifier;
>> -
>> - return LogEntryKey;
>> + return 0;
>> }
>>
>> /**
>> Adds a record at the end of the performance measurement log
>> that records the start time of a performance measurement.
>> @@ -816,11 +1578,11 @@ StartPerformanceMeasurement (
>> IN CONST CHAR8 *Token, OPTIONAL
>> IN CONST CHAR8 *Module, OPTIONAL
>> IN UINT64 TimeStamp
>> )
>> {
>> - return StartPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, 0);
>> }
>>
>> /**
>> Searches the performance measurement log from the beginning of the log
>> for the first matching record that contains a zero end time and fills in a valid end time.
>> @@ -852,18 +1614,20 @@ EndPerformanceMeasurement (
>> IN CONST CHAR8 *Token, OPTIONAL
>> IN CONST CHAR8 *Module, OPTIONAL
>> IN UINT64 TimeStamp
>> )
>> {
>> - return EndPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, 0);
>> }
>>
>> /**
>> Attempts to retrieve a performance measurement log entry from the performance measurement log.
>> It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
>> and then eliminate the Identifier.
>>
>> + !!! Not support!!!
>> +
>> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
>> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
>> and the key for the second entry in the log is returned. If the performance log is empty,
>> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
>> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
>> @@ -905,12 +1669,11 @@ GetPerformanceMeasurement (
>> OUT CONST CHAR8 **Module,
>> OUT UINT64 *StartTimeStamp,
>> OUT UINT64 *EndTimeStamp
>> )
>> {
>> - UINT32 Identifier;
>> - return GetPerformanceMeasurementEx (LogEntryKey, Handle, Token, Module, StartTimeStamp, EndTimeStamp, &Identifier);
>> + return 0;
>> }
>>
>> /**
>> Returns TRUE if the performance measurement macros are enabled.
>>
>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>> index 5b89ce2..71c181f 100644
>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>> @@ -7,11 +7,11 @@
>> # It initializes DXE phase performance logging by publishing the Performance and PerformanceEx Protocol,
>> # which is consumed by DxePerformanceLib to logging performance data in DXE phase.
>> # This library is mainly used by DxeCore to start performance logging to ensure that
>> # Performance and PerformanceEx Protocol are installed at the very beginning of DXE phase.
>> #
>> -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>> # This program and the accompanying materials
>> # are licensed and made available under the terms and conditions of the BSD License
>> # which accompanies this distribution. The full text of the license may be found at
>> # http://opensource.org/licenses/bsd-license.php
>> @@ -48,27 +48,39 @@
>>
>>
>> [LibraryClasses]
>> MemoryAllocationLib
>> UefiBootServicesTableLib
>> + UefiRuntimeServicesTableLib
>> PcdLib
>> TimerLib
>> BaseMemoryLib
>> BaseLib
>> HobLib
>> DebugLib
>> UefiLib
>> + ReportStatusCodeLib
>> + DxeServicesLib
>> + PeCoffGetEntryPointLib
>> +
>> +[Protocols]
>> + gEfiSmmCommunicationProtocolGuid ## SOMETIMES_CONSUMES
>>
>>
>> [Guids]
>> ## SOMETIMES_CONSUMES ## HOB
>> ## PRODUCES ## UNDEFINED # Install protocol
>> ## PRODUCES ## SystemTable
>> gPerformanceProtocolGuid
>> ## SOMETIMES_CONSUMES ## HOB
>> ## PRODUCES ## UNDEFINED # Install protocol
>> gPerformanceExProtocolGuid
>> + gZeroGuid ## SOMETIMES_CONSUMES ## GUID
>> + gEfiFirmwarePerformanceGuid ## SOMETIMES_PRODUCES ## UNDEFINED # StatusCode Data
>> + gEdkiiExtendedFirmwarePerformanceGuid ## SOMETIMES_CONSUMES ## HOB # StatusCode Data
>> + gEfiEventReadyToBootGuid ## CONSUMES ## Event
>> + gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable
>>
>> [Pcd]
>> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries ## CONSUMES
>> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16 ## CONSUMES
>> - gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
>> + gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly ## CONSUMES
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES
>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>> index f1540d8..7e79675 100644
>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>> @@ -2,11 +2,11 @@
>> Master header files for DxeCorePerformanceLib instance.
>>
>> This header file holds the prototypes of the Performance and PerformanceEx Protocol published by this
>> library instance at its constructor.
>>
>> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>> This program and the accompanying materials
>> are licensed and made available under the terms and conditions of the BSD License
>> which accompanies this distribution. The full text of the license may be found at
>> http://opensource.org/licenses/bsd-license.php
>>
>> @@ -20,21 +20,36 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>>
>>
>> #include <PiDxe.h>
>>
>> #include <Guid/Performance.h>
>> +#include <Guid/ExtendedFirmwarePerformance.h>
>> +#include <Guid/ZeroGuid.h>
>> +#include <Guid/EventGroup.h>
>> +#include <Guid/FirmwarePerformance.h>
>> +#include <Guid/PiSmmCommunicationRegionTable.h>
>> +
>> +#include <Protocol/DriverBinding.h>
>> +#include <Protocol/LoadedImage.h>
>> +#include <Protocol/ComponentName2.h>
>> +#include <Protocol/DevicePathToText.h>
>> +#include <Protocol/SmmCommunication.h>
>>
>> #include <Library/PerformanceLib.h>
>> #include <Library/DebugLib.h>
>> #include <Library/HobLib.h>
>> #include <Library/BaseLib.h>
>> #include <Library/BaseMemoryLib.h>
>> #include <Library/TimerLib.h>
>> #include <Library/PcdLib.h>
>> #include <Library/UefiBootServicesTableLib.h>
>> +#include <Library/UefiRuntimeServicesTableLib.h>
>> #include <Library/MemoryAllocationLib.h>
>> #include <Library/UefiLib.h>
>> +#include <Library/ReportStatusCodeLib.h>
>> +#include <Library/DxeServicesLib.h>
>> +#include <Library/PeCoffGetEntryPointLib.h>
>>
>> //
>> // Interface declarations for PerformanceEx Protocol.
>> //
>> /**
>> --
>> 1.9.5.msysgit.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-05-22 8:51 ` Ard Biesheuvel
@ 2018-05-22 8:58 ` Zeng, Star
2018-05-22 9:02 ` Ard Biesheuvel
0 siblings, 1 reply; 21+ messages in thread
From: Zeng, Star @ 2018-05-22 8:58 UTC (permalink / raw)
To: Ard Biesheuvel, Bi, Dandan, Laszlo Ersek, Andrew Fish,
Kinney, Michael D
Cc: Leif Lindholm, edk2-devel@lists.01.org, Gao, Liming, Matt Sealey,
Zeng, Star
How about the code to try allocating <4G memory, then try allocating any memory if failed to allocate <4G memory?
For example, the code snippet in SmbiosDxe.c.
PhysicalAddress = 0xffffffff;
Status = gBS->AllocatePages (
AllocateMaxAddress,
EfiRuntimeServicesData,
EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
&PhysicalAddress
);
if (EFI_ERROR (Status)) {
DEBUG ((EFI_D_ERROR, "SmbiosCreateTable () could not allocate EntryPointStructure < 4GB\n"));
Status = gBS->AllocatePages (
AllocateAnyPages,
EfiRuntimeServicesData,
EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
&PhysicalAddress
);
if (EFI_ERROR (Status)) {
return EFI_OUT_OF_RESOURCES;
}
}
Thanks,
Star
-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
Sent: Tuesday, May 22, 2018 4:52 PM
To: Bi, Dandan <dandan.bi@intel.com>; Laszlo Ersek <lersek@redhat.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>; edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
(+ Laszlo, Andrew, Mike)
On 22 May 2018 at 02:33, Bi, Dandan <dandan.bi@intel.com> wrote:
> Sorry for the delayed response.
>
> The allocated performance table ( below 4G ) is to save the boot performance data in normal boot and S3 phase.
> PEIM FirmwarePerformancePei will get the address of the performance table and update the performance date of S3 phase to the table.
> The address need to be handled in PEI phase(32bit), that's the main reason why we allocate it below 4G.
>
The 32-bit PEI + 64-bit DXE combo is specific to X64. You have added
code to a generic library that ASSERT()s if allocating memory below 4
GB fails, breaking non-PC architectures.
So please, fix this. Or at least suggest a way around it so that other
architectures can keep using this library.
This is another consequence of our failure to model the special 32-bit
PEI/64-bit DXE combination using proper PI interfaces, resulting in
these kinds of breakages and open coded 4 GB allocations all
throughout the code. Can we please work on getting this fixed?
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Wednesday, May 2, 2018 12:27 AM
> To: Bi, Dandan <dandan.bi@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
> Cc: edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
> Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>
> On 30 January 2018 at 14:53, Dandan Bi <dandan.bi@intel.com> wrote:
>> V2:
>> Update DxecorePerformanceLib to report the boot performance table
>> address instead of records contents.
>>
>> Updated to convert Pref entry to FPDT record in DXE phase and then
>> allocate boot performance table to save the record and report
>> the address of boot performance table to FirmwarePerformanceDxe.
>>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>> ---
>> .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 1389 +++++++++++++++-----
>> .../DxeCorePerformanceLib.inf | 20 +-
>> .../DxeCorePerformanceLibInternal.h | 17 +-
>> 3 files changed, 1108 insertions(+), 318 deletions(-)
>>
>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>> index 7c0e207..c6f8a16 100644
>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>> @@ -8,11 +8,11 @@
>> which are consumed by DxePerformanceLib to logging performance data in DXE phase.
>>
>> This library is mainly used by DxeCore to start performance logging to ensure that
>> Performance Protocol is installed at the very beginning of DXE phase.
>>
>> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>> This program and the accompanying materials
>> are licensed and made available under the terms and conditions of the BSD License
>> which accompanies this distribution. The full text of the license may be found at
>> http://opensource.org/licenses/bsd-license.php
>> @@ -23,27 +23,65 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>> **/
>>
>>
>> #include "DxeCorePerformanceLibInternal.h"
>>
>> -
>> //
>> -// The data structure to hold global performance data.
>> +// Data for FPDT performance records.
>> //
>> -GAUGE_DATA_HEADER *mGaugeData;
>> +#define SMM_BOOT_RECORD_COMM_SIZE (OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + sizeof(SMM_BOOT_RECORD_COMMUNICATE))
>> +#define STRING_SIZE (EDKII_STRING_EVENT_RECORD_NAME_LENGTH * sizeof (CHAR8))
>> +#define MAX_RECORD_SIZE (sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE)
>> +#define FIRMWARE_RECORD_BUFFER 0x10000
>> +#define CACHE_HANDLE_GUID_COUNT 0x1000
>> +
>> +BOOT_PERFORMANCE_TABLE *mAcpiBootPerformanceTable = NULL;
>> +BOOT_PERFORMANCE_TABLE mBootPerformanceTableTemplate = {
>> + {
>> + EFI_ACPI_5_0_FPDT_BOOT_PERFORMANCE_TABLE_SIGNATURE,
>> + sizeof (BOOT_PERFORMANCE_TABLE)
>> + },
>> + {
>> + {
>> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_TYPE_FIRMWARE_BASIC_BOOT, // Type
>> + sizeof (EFI_ACPI_5_0_FPDT_FIRMWARE_BASIC_BOOT_RECORD), // Length
>> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_REVISION_FIRMWARE_BASIC_BOOT // Revision
>> + },
>> + 0, // Reserved
>> + //
>> + // These values will be updated at runtime.
>> + //
>> + 0, // ResetEnd
>> + 0, // OsLoaderLoadImageStart
>> + 0, // OsLoaderStartImageStart
>> + 0, // ExitBootServicesEntry
>> + 0 // ExitBootServicesExit
>> + }
>> +};
>>
>> -//
>> -// The current maximum number of logging entries. If current number of
>> -// entries exceeds this value, it will re-allocate a larger array and
>> -// migration the old data to the larger array.
>> -//
>> -UINT32 mMaxGaugeRecords;
>> +typedef struct {
>> + EFI_HANDLE Handle;
>> + CHAR8 NameString[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
>> + EFI_GUID ModuleGuid;
>> +} HANDLE_GUID_MAP;
>>
>> -//
>> -// The handle to install Performance Protocol instance.
>> -//
>> -EFI_HANDLE mHandle = NULL;
>> +HANDLE_GUID_MAP mCacheHandleGuidTable[CACHE_HANDLE_GUID_COUNT];
>> +UINTN mCachePairCount = 0;
>> +
>> +UINT32 mLoadImageCount = 0;
>> +UINT32 mPerformanceLength = 0;
>> +UINT32 mMaxPerformanceLength = 0;
>> +UINT32 mBootRecordSize = 0;
>> +UINT32 mBootRecordMaxSize = 0;
>> +
>> +BOOLEAN mFpdtBufferIsReported = FALSE;
>> +BOOLEAN mLackSpaceIsReported = FALSE;
>> +CHAR8 *mPlatformLanguage = NULL;
>> +UINT8 *mPerformancePointer = NULL;
>> +UINT8 *mBootRecordBuffer = NULL;
>> +
>> +EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *mDevicePathToText = NULL;
>>
>> //
>> // Interfaces for Performance Protocol.
>> //
>> PERFORMANCE_PROTOCOL mPerformanceInterface = {
>> @@ -61,179 +99,1069 @@ PERFORMANCE_EX_PROTOCOL mPerformanceExInterface = {
>> GetGaugeEx
>> };
>>
>> PERFORMANCE_PROPERTY mPerformanceProperty;
>>
>> -//
>> -// Gauge record lock to avoid data corruption or even memory overflow
>> -//
>> -STATIC EFI_LOCK mPerfRecordLock = EFI_INITIALIZE_LOCK_VARIABLE (TPL_NOTIFY);
>> +/**
>> +Check whether the Token is a known one which is uesed by core.
>> +
>> +@param Token Pointer to a Null-terminated ASCII string
>> +
>> +@retval TRUE Is a known one used by core.
>> +@retval FALSE Not a known one.
>> +
>> +**/
>> +BOOLEAN
>> +IsKnownTokens (
>> + IN CONST CHAR8 *Token
>> + )
>> +{
>> + if (AsciiStrCmp (Token, SEC_TOK) == 0 ||
>> + AsciiStrCmp (Token, PEI_TOK) == 0 ||
>> + AsciiStrCmp (Token, DXE_TOK) == 0 ||
>> + AsciiStrCmp (Token, BDS_TOK) == 0 ||
>> + AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0 ||
>> + AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0 ||
>> + AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0 ||
>> + AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0 ||
>> + AsciiStrCmp (Token, START_IMAGE_TOK) == 0 ||
>> + AsciiStrCmp (Token, PEIM_TOK) == 0) {
>> + return TRUE;
>> + } else {
>> + return FALSE;
>> + }
>> +}
>> +
>> +/**
>> +Check whether the ID is a known one which map to the known Token.
>> +
>> +@param Identifier 32-bit identifier.
>> +
>> +@retval TRUE Is a known one used by core.
>> +@retval FALSE Not a known one.
>> +
>> +**/
>> +BOOLEAN
>> +IsKnownID (
>> + IN UINT32 Identifier
>> + )
>> +{
>> + if (Identifier == MODULE_START_ID ||
>> + Identifier == MODULE_END_ID ||
>> + Identifier == MODULE_LOADIMAGE_START_ID ||
>> + Identifier == MODULE_LOADIMAGE_END_ID ||
>> + Identifier == MODULE_DB_START_ID ||
>> + Identifier == MODULE_DB_END_ID ||
>> + Identifier == MODULE_DB_SUPPORT_START_ID ||
>> + Identifier == MODULE_DB_SUPPORT_END_ID ||
>> + Identifier == MODULE_DB_STOP_START_ID ||
>> + Identifier == MODULE_DB_STOP_END_ID) {
>> + return TRUE;
>> + } else {
>> + return FALSE;
>> + }
>> +}
>>
>> /**
>> - Searches in the gauge array with keyword Handle, Token, Module and Identifier.
>> + Allocate EfiReservedMemoryType below 4G memory address.
>> +
>> + This function allocates EfiReservedMemoryType below 4G memory address.
>> +
>> + @param[in] Size Size of memory to allocate.
>> +
>> + @return Allocated address for output.
>> +
>> +**/
>> +VOID *
>> +FpdtAllocateReservedMemoryBelow4G (
>> + IN UINTN Size
>> + )
>> +{
>> + UINTN Pages;
>> + EFI_PHYSICAL_ADDRESS Address;
>> + EFI_STATUS Status;
>> + VOID *Buffer;
>> +
>> + Buffer = NULL;
>> + Pages = EFI_SIZE_TO_PAGES (Size);
>> + Address = 0xffffffff;
>> +
>> + Status = gBS->AllocatePages (
>> + AllocateMaxAddress,
>> + EfiReservedMemoryType,
>> + Pages,
>> + &Address
>> + );
>> + ASSERT_EFI_ERROR (Status);
>
> This code is breaking DEBUG builds on ARM systems that have no memory
> below 4 GB.
>
>> +
>> + if (!EFI_ERROR (Status)) {
>> + Buffer = (VOID *) (UINTN) Address;
>> + ZeroMem (Buffer, Size);
>> + }
>> +
>> + return Buffer;
>> +}
>> +
>> +/**
>> + Allocate buffer for Boot Performance table.
>> +
>> + @return Status code.
>> +
>> +**/
>> +EFI_STATUS
>> +AllocateBootPerformanceTable (
>> + )
>> +{
>> + EFI_STATUS Status;
>> + UINTN Size;
>> + UINT8 *SmmBootRecordCommBuffer;
>> + EFI_SMM_COMMUNICATE_HEADER *SmmCommBufferHeader;
>> + SMM_BOOT_RECORD_COMMUNICATE *SmmCommData;
>> + UINTN CommSize;
>> + UINTN BootPerformanceDataSize;
>> + UINT8 *BootPerformanceData;
>> + EFI_SMM_COMMUNICATION_PROTOCOL *Communication;
>> + FIRMWARE_PERFORMANCE_VARIABLE PerformanceVariable;
>> + EDKII_PI_SMM_COMMUNICATION_REGION_TABLE *SmmCommRegionTable;
>> + EFI_MEMORY_DESCRIPTOR *SmmCommMemRegion;
>> + UINTN Index;
>> + VOID *SmmBootRecordData;
>> + UINTN SmmBootRecordDataSize;
>> + UINTN ReservedMemSize;
>> +
>> + //
>> + // Collect boot records from SMM drivers.
>> + //
>> + SmmBootRecordCommBuffer = NULL;
>> + SmmCommData = NULL;
>> + SmmBootRecordData = NULL;
>> + SmmBootRecordDataSize = 0;
>> + ReservedMemSize = 0;
>> + Status = gBS->LocateProtocol (&gEfiSmmCommunicationProtocolGuid, NULL, (VOID **) &Communication);
>> + if (!EFI_ERROR (Status)) {
>> + //
>> + // Initialize communicate buffer
>> + // Get the prepared Reserved Memory Range
>> + //
>> + Status = EfiGetSystemConfigurationTable (
>> + &gEdkiiPiSmmCommunicationRegionTableGuid,
>> + (VOID **) &SmmCommRegionTable
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + ASSERT (SmmCommRegionTable != NULL);
>> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) (SmmCommRegionTable + 1);
>> + for (Index = 0; Index < SmmCommRegionTable->NumberOfEntries; Index ++) {
>> + if (SmmCommMemRegion->Type == EfiConventionalMemory) {
>> + break;
>> + }
>> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) ((UINT8 *) SmmCommMemRegion + SmmCommRegionTable->DescriptorSize);
>> + }
>> + ASSERT (Index < SmmCommRegionTable->NumberOfEntries);
>> + ASSERT (SmmCommMemRegion->PhysicalStart > 0);
>> + ASSERT (SmmCommMemRegion->NumberOfPages > 0);
>> + ReservedMemSize = (UINTN) SmmCommMemRegion->NumberOfPages * EFI_PAGE_SIZE;
>> +
>> + //
>> + // Check enough reserved memory space
>> + //
>> + if (ReservedMemSize > SMM_BOOT_RECORD_COMM_SIZE) {
>> + SmmBootRecordCommBuffer = (VOID *) (UINTN) SmmCommMemRegion->PhysicalStart;
>> + SmmCommBufferHeader = (EFI_SMM_COMMUNICATE_HEADER*)SmmBootRecordCommBuffer;
>> + SmmCommData = (SMM_BOOT_RECORD_COMMUNICATE*)SmmCommBufferHeader->Data;
>> + ZeroMem((UINT8*)SmmCommData, sizeof(SMM_BOOT_RECORD_COMMUNICATE));
>> +
>> + CopyGuid (&SmmCommBufferHeader->HeaderGuid, &gEfiFirmwarePerformanceGuid);
>> + SmmCommBufferHeader->MessageLength = sizeof(SMM_BOOT_RECORD_COMMUNICATE);
>> + CommSize = SMM_BOOT_RECORD_COMM_SIZE;
>> +
>> + //
>> + // Get the size of boot records.
>> + //
>> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_SIZE;
>> + SmmCommData->BootRecordData = NULL;
>> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
>> + ASSERT_EFI_ERROR (Status);
>> +
>> + if (!EFI_ERROR (SmmCommData->ReturnStatus) && SmmCommData->BootRecordSize != 0) {
>> + //
>> + // Get all boot records
>> + //
>> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
>> + SmmBootRecordDataSize = SmmCommData->BootRecordSize;
>> + SmmBootRecordData = AllocateZeroPool(SmmBootRecordDataSize);
>> + ASSERT (SmmBootRecordData != NULL);
>> + SmmCommData->BootRecordOffset = 0;
>> + SmmCommData->BootRecordData = (VOID *) ((UINTN) SmmCommMemRegion->PhysicalStart + SMM_BOOT_RECORD_COMM_SIZE);
>> + SmmCommData->BootRecordSize = ReservedMemSize - SMM_BOOT_RECORD_COMM_SIZE;
>> + while (SmmCommData->BootRecordOffset < SmmBootRecordDataSize) {
>> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
>> + ASSERT_EFI_ERROR (Status);
>> + ASSERT_EFI_ERROR(SmmCommData->ReturnStatus);
>> + if (SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize > SmmBootRecordDataSize) {
>> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmBootRecordDataSize - SmmCommData->BootRecordOffset);
>> + } else {
>> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmCommData->BootRecordSize);
>> + }
>> + SmmCommData->BootRecordOffset = SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize;
>> + }
>> + }
>> + }
>> + }
>> + }
>> +
>> + //
>> + // Prepare memory for Boot Performance table.
>> + // Boot Performance table includes BasicBoot record, and one or more appended Boot Records.
>> + //
>> + BootPerformanceDataSize = sizeof (BOOT_PERFORMANCE_TABLE) + mPerformanceLength + PcdGet32 (PcdExtFpdtBootRecordPadSize);
>> + if (SmmCommData != NULL) {
>> + BootPerformanceDataSize += SmmBootRecordDataSize;
>> + }
>> +
>> + //
>> + // Try to allocate the same runtime buffer as last time boot.
>> + //
>> + ZeroMem (&PerformanceVariable, sizeof (PerformanceVariable));
>> + Size = sizeof (PerformanceVariable);
>> + Status = gRT->GetVariable (
>> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
>> + &gEfiFirmwarePerformanceGuid,
>> + NULL,
>> + &Size,
>> + &PerformanceVariable
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + Status = gBS->AllocatePages (
>> + AllocateAddress,
>> + EfiReservedMemoryType,
>> + EFI_SIZE_TO_PAGES (BootPerformanceDataSize),
>> + &PerformanceVariable.BootPerformanceTablePointer
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) (UINTN) PerformanceVariable.BootPerformanceTablePointer;
>> + }
>> + }
>> +
>> + if (mAcpiBootPerformanceTable == NULL) {
>> + //
>> + // Fail to allocate at specified address, continue to allocate at any address.
>> + //
>> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) FpdtAllocateReservedMemoryBelow4G (BootPerformanceDataSize);
>
> Why does this allocation need to live below 4 GB?
>
> If there is no good reason, can we please get rid of this?
> If there is a good reason, can we please document it in the code?
>
>> + }
>> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: ACPI Boot Performance Table address = 0x%x\n", mAcpiBootPerformanceTable));
>> +
>> + if (mAcpiBootPerformanceTable == NULL) {
>> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
>> + FreePool (SmmBootRecordData);
>> + }
>> + return EFI_OUT_OF_RESOURCES;
>> + }
>> +
>> + //
>> + // Prepare Boot Performance Table.
>> + //
>> + BootPerformanceData = (UINT8 *) mAcpiBootPerformanceTable;
>> + //
>> + // Fill Basic Boot record to Boot Performance Table.
>> + //
>> + CopyMem (mAcpiBootPerformanceTable, &mBootPerformanceTableTemplate, sizeof (mBootPerformanceTableTemplate));
>> + BootPerformanceData = BootPerformanceData + mAcpiBootPerformanceTable->Header.Length;
>> + //
>> + // Fill Boot records from boot drivers.
>> + //
>> + if (mPerformancePointer != NULL) {
>> + CopyMem (BootPerformanceData, mPerformancePointer, mPerformanceLength);
>> + mAcpiBootPerformanceTable->Header.Length += mPerformanceLength;
>> + BootPerformanceData = BootPerformanceData + mPerformanceLength;
>> + }
>> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
>> + //
>> + // Fill Boot records from SMM drivers.
>> + //
>> + CopyMem (BootPerformanceData, SmmBootRecordData, SmmBootRecordDataSize);
>> + FreePool (SmmBootRecordData);
>> + mAcpiBootPerformanceTable->Header.Length = (UINT32) (mAcpiBootPerformanceTable->Header.Length + SmmBootRecordDataSize);
>> + BootPerformanceData = BootPerformanceData + SmmBootRecordDataSize;
>> + }
>> +
>> + //
>> + // Save Boot Performance Table address to Variable for use in S4 resume.
>> + //
>> + PerformanceVariable.BootPerformanceTablePointer = (EFI_PHYSICAL_ADDRESS) (UINTN) mAcpiBootPerformanceTable;
>> +
>> + //
>> + // Save Runtime Performance Table pointers to Variable.
>> + // Don't check SetVariable return status. It doesn't impact FPDT table generation.
>> + //
>> + gRT->SetVariable (
>> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
>> + &gEfiFirmwarePerformanceGuid,
>> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
>> + sizeof (PerformanceVariable),
>> + &PerformanceVariable
>> + );
>> +
>> + mBootRecordBuffer = (UINT8 *) mAcpiBootPerformanceTable;
>> + mBootRecordSize = mAcpiBootPerformanceTable->Header.Length;
>> + mBootRecordMaxSize = mBootRecordSize + PcdGet32 (PcdExtFpdtBootRecordPadSize);
>> +
>> + return EFI_SUCCESS;
>> +}
>> +
>> +/**
>> + Get a human readable module name and module guid for the given image handle.
>> + If module name can't be found, "" string will return.
>> + If module guid can't be found, Zero Guid will return.
>> +
>> + @param Handle Image handle or Controller handle.
>> + @param NameString The ascii string will be filled into it. If not found, null string will return.
>> + @param BufferSize Size of the input NameString buffer.
>> + @param ModuleGuid Point to the guid buffer to store the got module guid value.
>> +
>> + @retval EFI_SUCCESS Successfully get module name and guid.
>> + @retval EFI_INVALID_PARAMETER The input parameter NameString is NULL.
>> + @retval other value Module Name can't be got.
>> +**/
>> +EFI_STATUS
>> +GetModuleInfoFromHandle (
>> + IN EFI_HANDLE Handle,
>> + OUT CHAR8 *NameString,
>> + IN UINTN BufferSize,
>> + OUT EFI_GUID *ModuleGuid OPTIONAL
>> + )
>> +{
>> + EFI_STATUS Status;
>> + EFI_LOADED_IMAGE_PROTOCOL *LoadedImage;
>> + EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
>> + CHAR8 *PdbFileName;
>> + EFI_GUID *TempGuid;
>> + UINTN StartIndex;
>> + UINTN Index;
>> + INTN Count;
>> + BOOLEAN ModuleGuidIsGet;
>> + UINTN StringSize;
>> + CHAR16 *StringPtr;
>> + EFI_COMPONENT_NAME2_PROTOCOL *ComponentName2;
>> + MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *FvFilePath;
>> +
>> + if (NameString == NULL || BufferSize == 0) {
>> + return EFI_INVALID_PARAMETER;
>> + }
>> + //
>> + // Try to get the ModuleGuid and name string form the caached array.
>> + //
>> + if (mCachePairCount > 0) {
>> + for (Count = mCachePairCount -1; Count >= 0; Count--) {
>> + if (Handle == mCacheHandleGuidTable[Count].Handle) {
>> + CopyGuid (ModuleGuid, &mCacheHandleGuidTable[Count].ModuleGuid);
>> + AsciiStrCpyS (NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, mCacheHandleGuidTable[Count].NameString);
>> + return EFI_SUCCESS;
>> + }
>> + }
>> + }
>> +
>> + Status = EFI_INVALID_PARAMETER;
>> + LoadedImage = NULL;
>> + ModuleGuidIsGet = FALSE;
>> +
>> + //
>> + // Initialize GUID as zero value.
>> + //
>> + TempGuid = &gZeroGuid;
>> + //
>> + // Initialize it as "" string.
>> + //
>> + NameString[0] = 0;
>> +
>> + if (Handle != NULL) {
>> + //
>> + // Try Handle as ImageHandle.
>> + //
>> + Status = gBS->HandleProtocol (
>> + Handle,
>> + &gEfiLoadedImageProtocolGuid,
>> + (VOID**) &LoadedImage
>> + );
>> +
>> + if (EFI_ERROR (Status)) {
>> + //
>> + // Try Handle as Controller Handle
>> + //
>> + Status = gBS->OpenProtocol (
>> + Handle,
>> + &gEfiDriverBindingProtocolGuid,
>> + (VOID **) &DriverBinding,
>> + NULL,
>> + NULL,
>> + EFI_OPEN_PROTOCOL_GET_PROTOCOL
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + //
>> + // Get Image protocol from ImageHandle
>> + //
>> + Status = gBS->HandleProtocol (
>> + DriverBinding->ImageHandle,
>> + &gEfiLoadedImageProtocolGuid,
>> + (VOID**) &LoadedImage
>> + );
>> + }
>> + }
>> + }
>> +
>> + if (!EFI_ERROR (Status) && LoadedImage != NULL) {
>> + //
>> + // Get Module Guid from DevicePath.
>> + //
>> + if (LoadedImage->FilePath != NULL &&
>> + LoadedImage->FilePath->Type == MEDIA_DEVICE_PATH &&
>> + LoadedImage->FilePath->SubType == MEDIA_PIWG_FW_FILE_DP
>> + ) {
>> + //
>> + // Determine GUID associated with module logging performance
>> + //
>> + ModuleGuidIsGet = TRUE;
>> + FvFilePath = (MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *) LoadedImage->FilePath;
>> + TempGuid = &FvFilePath->FvFileName;
>> + }
>> +
>> + //
>> + // Method 1 Get Module Name from PDB string.
>> + //
>> + PdbFileName = PeCoffLoaderGetPdbPointer (LoadedImage->ImageBase);
>> + if (PdbFileName != NULL && BufferSize > 0) {
>> + StartIndex = 0;
>> + for (Index = 0; PdbFileName[Index] != 0; Index++) {
>> + if ((PdbFileName[Index] == '\\') || (PdbFileName[Index] == '/')) {
>> + StartIndex = Index + 1;
>> + }
>> + }
>> + //
>> + // Copy the PDB file name to our temporary string.
>> + // If the length is bigger than BufferSize, trim the redudant characters to avoid overflow in array boundary.
>> + //
>> + for (Index = 0; Index < BufferSize - 1; Index++) {
>> + NameString[Index] = PdbFileName[Index + StartIndex];
>> + if (NameString[Index] == 0 || NameString[Index] == '.') {
>> + NameString[Index] = 0;
>> + break;
>> + }
>> + }
>>
>> - This internal function searches for the gauge entry in the gauge array.
>> - If there is an entry that exactly matches the given keywords
>> - and its end time stamp is zero, then the index of that gauge entry is returned;
>> - otherwise, the the number of gauge entries in the array is returned.
>> + if (Index == BufferSize - 1) {
>> + NameString[Index] = 0;
>> + }
>> + //
>> + // Module Name is got.
>> + //
>> + goto Done;
>> + }
>> + }
>>
>> + //
>> + // Method 2: Get the name string from ComponentName2 protocol
>> + //
>> + Status = gBS->HandleProtocol (
>> + Handle,
>> + &gEfiComponentName2ProtocolGuid,
>> + (VOID **) &ComponentName2
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + //
>> + // Get the current platform language setting
>> + //
>> + if (mPlatformLanguage == NULL) {
>> + GetEfiGlobalVariable2 (L"PlatformLang", (VOID **) &mPlatformLanguage, NULL);
>> + }
>> + if (mPlatformLanguage != NULL) {
>> + Status = ComponentName2->GetDriverName (
>> + ComponentName2,
>> + mPlatformLanguage != NULL ? mPlatformLanguage : "en-US",
>> + &StringPtr
>> + );
>> + if (!EFI_ERROR (Status)) {
>> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
>> + NameString[Index] = (CHAR8) StringPtr[Index];
>> + }
>> + NameString[Index] = 0;
>> + //
>> + // Module Name is got.
>> + //
>> + goto Done;
>> + }
>> + }
>> + }
>> +
>> + if (ModuleGuidIsGet) {
>> + //
>> + // Method 3 Try to get the image's FFS UI section by image GUID
>> + //
>> + StringPtr = NULL;
>> + StringSize = 0;
>> + Status = GetSectionFromAnyFv (
>> + TempGuid,
>> + EFI_SECTION_USER_INTERFACE,
>> + 0,
>> + (VOID **) &StringPtr,
>> + &StringSize
>> + );
>> +
>> + if (!EFI_ERROR (Status)) {
>> + //
>> + // Method 3. Get the name string from FFS UI section
>> + //
>> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
>> + NameString[Index] = (CHAR8) StringPtr[Index];
>> + }
>> + NameString[Index] = 0;
>> + FreePool (StringPtr);
>> + }
>> + }
>> +
>> +Done:
>> + //
>> + // Copy Module Guid
>> + //
>> + if (ModuleGuid != NULL) {
>> + CopyGuid (ModuleGuid, TempGuid);
>> + if (IsZeroGuid(TempGuid) && (Handle != NULL) && !ModuleGuidIsGet) {
>> + // Handle is GUID
>> + CopyGuid (ModuleGuid, (EFI_GUID *) Handle);
>> + }
>> + }
>> +
>> + //
>> + // Cache the Handle and Guid pairs.
>> + //
>> + if (mCachePairCount < CACHE_HANDLE_GUID_COUNT) {
>> + mCacheHandleGuidTable[mCachePairCount].Handle = Handle;
>> + CopyGuid (&mCacheHandleGuidTable[mCachePairCount].ModuleGuid, ModuleGuid);
>> + AsciiStrCpyS (mCacheHandleGuidTable[mCachePairCount].NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, NameString);
>> + mCachePairCount ++;
>> + }
>> +
>> + return Status;
>> +}
>> +
>> +/**
>> + Get the FPDT record info.
>> +
>> + @param IsStart TRUE if the performance log is start log.
>> @param Handle Pointer to environment specific context used
>> to identify the component being measured.
>> @param Token Pointer to a Null-terminated ASCII string
>> that identifies the component being measured.
>> @param Module Pointer to a Null-terminated ASCII string
>> that identifies the module being measured.
>> - @param Identifier 32-bit identifier.
>> + @param RecordInfo On return, pointer to the info of the record.
>> + @param UseModuleName Only useful for DYNAMIC_STRING_EVENT_TYPE, indicate that whether need use
>> + Module name to fill the string field in the DYNAMIC_STRING_EVENT_RECORD.
>>
>> - @retval The index of gauge entry in the array.
>> + @retval EFI_SUCCESS Get record info successfully.
>> + @retval EFI_UNSUPPORTED No matched FPDT record.
>>
>> **/
>> -UINT32
>> -InternalSearchForGaugeEntry (
>> - IN CONST VOID *Handle, OPTIONAL
>> - IN CONST CHAR8 *Token, OPTIONAL
>> - IN CONST CHAR8 *Module, OPTIONAL
>> - IN UINT32 Identifier
>> +EFI_STATUS
>> +GetFpdtRecordInfo (
>> + IN BOOLEAN IsStart,
>> + IN CONST VOID *Handle,
>> + IN CONST CHAR8 *Token,
>> + IN CONST CHAR8 *Module,
>> + OUT BASIC_RECORD_INFO *RecordInfo,
>> + IN OUT BOOLEAN *UseModuleName
>> )
>> {
>> - UINT32 Index;
>> - UINT32 Index2;
>> - UINT32 NumberOfEntries;
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>> + UINT16 RecordType;
>> + UINTN StringSize;
>>
>> - if (Token == NULL) {
>> - Token = "";
>> - }
>> - if (Module == NULL) {
>> - Module = "";
>> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
>> +
>> + //
>> + // Token to Type and Id.
>> + //
>> + if (Token != NULL) {
>> + if (AsciiStrCmp (Token, START_IMAGE_TOK) == 0) { // "StartImage:"
>> + *UseModuleName = TRUE;
>> + RecordType = GUID_EVENT_TYPE;
>> + if (IsStart) {
>> + RecordInfo->ProgressID = MODULE_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = MODULE_END_ID;
>> + }
>> + } else if (AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) { // "LoadImage:"
>> + *UseModuleName = TRUE;
>> + RecordType = GUID_QWORD_EVENT_TYPE;
>> + if (IsStart) {
>> + RecordInfo->ProgressID = MODULE_LOADIMAGE_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = MODULE_LOADIMAGE_END_ID;
>> + }
>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0) { // "DB:Start:"
>> + *UseModuleName = TRUE;
>> + if (IsStart) {
>> + RecordInfo->ProgressID = MODULE_DB_START_ID;
>> + RecordType = GUID_QWORD_EVENT_TYPE;
>> + } else {
>> + RecordInfo->ProgressID = MODULE_DB_END_ID;
>> + RecordType = GUID_QWORD_STRING_EVENT_TYPE;
>> + }
>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0) { // "DB:Support:"
>> + *UseModuleName = TRUE;
>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>> + return RETURN_UNSUPPORTED;
>> + }
>> + RecordType = GUID_QWORD_EVENT_TYPE;
>> + if (IsStart) {
>> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_END_ID;
>> + }
>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0) { // "DB:Stop:"
>> + *UseModuleName = TRUE;
>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>> + return RETURN_UNSUPPORTED;
>> + }
>> + RecordType = GUID_QWORD_EVENT_TYPE;
>> + if (IsStart) {
>> + RecordInfo->ProgressID = MODULE_DB_STOP_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = MODULE_DB_STOP_END_ID;
>> + }
>> + } else if (AsciiStrCmp (Token, PEI_TOK) == 0 || // "PEI"
>> + AsciiStrCmp (Token, DXE_TOK) == 0 || // "DXE"
>> + AsciiStrCmp (Token, BDS_TOK) == 0) { // "BDS"
>> + if (IsStart) {
>> + RecordInfo->ProgressID = PERF_CROSSMODULE_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = PERF_CROSSMODULE_END_ID;
>> + }
>> + } else { // Pref used in Modules.
>> + if (IsStart) {
>> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
>> + }
>> + }
>> + } else if (Handle!= NULL || Module != NULL) { // Pref used in Modules.
>> + if (IsStart) {
>> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
>> + } else {
>> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
>> + }
>> + } else {
>> + return EFI_UNSUPPORTED;
>> }
>>
>> - NumberOfEntries = mGaugeData->NumberOfEntries;
>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>> + //
>> + // Get Record size baesed on the record type.
>> + // When PcdEdkiiFpdtStringRecordEnableOnly is TRUE, all records are with type of DYNAMIC_STRING_EVENT_TYPE.
>> + //
>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
>> + RecordInfo->RecordSize = sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE;
>> + } else {
>> + switch (RecordType) {
>> + case GUID_EVENT_TYPE:
>> + RecordInfo->RecordSize = sizeof (GUID_EVENT_RECORD);
>> + break;
>>
>> - Index2 = 0;
>> + case DYNAMIC_STRING_EVENT_TYPE:
>> + if (*UseModuleName) {
>> + StringSize = STRING_SIZE;
>> + } else if (Token != NULL) {
>> + StringSize = AsciiStrSize (Token);
>> + } else if (Module != NULL) {
>> + StringSize = AsciiStrSize (Module);
>> + } else {
>> + StringSize = STRING_SIZE;
>> + }
>> + if (StringSize > STRING_SIZE) {
>> + StringSize = STRING_SIZE;
>> + }
>> + RecordInfo->RecordSize = (UINT8)(sizeof (DYNAMIC_STRING_EVENT_RECORD) + StringSize);
>> + break;
>>
>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>> - Index2 = NumberOfEntries - 1 - Index;
>> - if (GaugeEntryExArray[Index2].EndTimeStamp == 0 &&
>> - (GaugeEntryExArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&
>> - AsciiStrnCmp (GaugeEntryExArray[Index2].Token, Token, DXE_PERFORMANCE_STRING_LENGTH) == 0 &&
>> - AsciiStrnCmp (GaugeEntryExArray[Index2].Module, Module, DXE_PERFORMANCE_STRING_LENGTH) == 0) {
>> - Index = Index2;
>> + case GUID_QWORD_EVENT_TYPE:
>> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_EVENT_RECORD);
>> break;
>> +
>> + case GUID_QWORD_STRING_EVENT_TYPE:
>> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_STRING_EVENT_RECORD);
>> + break;
>> +
>> + default:
>> + //
>> + // Record is unsupported yet, return EFI_UNSUPPORTED
>> + //
>> + return EFI_UNSUPPORTED;
>> }
>> }
>>
>> - return Index;
>> + RecordInfo->Type = RecordType;
>> + return EFI_SUCCESS;
>> }
>>
>> /**
>> - Adds a record at the end of the performance measurement log
>> - that records the start time of a performance measurement.
>> -
>> - Adds a record to the end of the performance measurement log
>> - that contains the Handle, Token, Module and Identifier.
>> - The end time of the new record must be set to zero.
>> - If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
>> - If TimeStamp is zero, the start time in the record is filled in with the value
>> - read from the current time stamp.
>> + Add performance log to FPDT boot record table.
>>
>> + @param IsStart TRUE if the performance log is start log.
>> @param Handle Pointer to environment specific context used
>> to identify the component being measured.
>> @param Token Pointer to a Null-terminated ASCII string
>> that identifies the component being measured.
>> @param Module Pointer to a Null-terminated ASCII string
>> that identifies the module being measured.
>> - @param TimeStamp 64-bit time stamp.
>> + @param Ticker 64-bit time stamp.
>> @param Identifier 32-bit identifier. If the value is 0, the created record
>> is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>>
>> - @retval EFI_SUCCESS The data was read correctly from the device.
>> + @retval EFI_SUCCESS Add FPDT boot record.
>> @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>> + @retval EFI_UNSUPPORTED No matched FPDT record.
>>
>> **/
>> EFI_STATUS
>> -EFIAPI
>> -StartGaugeEx (
>> +InsertFpdtMeasurement (
>> + IN BOOLEAN IsStart,
>> IN CONST VOID *Handle, OPTIONAL
>> IN CONST CHAR8 *Token, OPTIONAL
>> IN CONST CHAR8 *Module, OPTIONAL
>> - IN UINT64 TimeStamp,
>> + IN UINT64 Ticker,
>> IN UINT32 Identifier
>> )
>> {
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>> - UINTN GaugeDataSize;
>> - GAUGE_DATA_HEADER *NewGaugeData;
>> - UINTN OldGaugeDataSize;
>> - GAUGE_DATA_HEADER *OldGaugeData;
>> - UINT32 Index;
>> - EFI_STATUS Status;
>> + EFI_GUID ModuleGuid;
>> + CHAR8 ModuleName[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
>> + UINT8 FpdtRecord[MAX_RECORD_SIZE];
>> + EFI_STATUS Status;
>> + FPDT_RECORD_PTR FpdtRecordPtr;
>> + BASIC_RECORD_INFO RecordInfo;
>> + UINT64 TimeStamp;
>> + UINTN DestMax;
>> + UINTN StrLength;
>> + CONST CHAR8 *StringPtr;
>> + BOOLEAN UseModuleName;
>> +
>> + StringPtr = NULL;
>> + UseModuleName = FALSE;
>> + ZeroMem (ModuleName, sizeof (ModuleName));
>> + ZeroMem (FpdtRecord, sizeof (FpdtRecord));
>>
>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>> + //
>> + // Get record info (type, size, ProgressID and Module Guid).
>> + //
>> + Status = GetFpdtRecordInfo (IsStart, Handle, Token, Module, &RecordInfo, &UseModuleName);
>> if (EFI_ERROR (Status)) {
>> return Status;
>> }
>>
>> - Index = mGaugeData->NumberOfEntries;
>> - if (Index >= mMaxGaugeRecords) {
>> + //
>> + // If PERF_START()/PERF_END() have specified the ProgressID,it has high priority.
>> + // !!! Note: If the Pref is not the known Token used in the core but have same
>> + // ID with the core Token, this case will not be supported.
>> + // And in currtnt usage mode, for the unkown ID, there is a general rule:
>> + // If it is start pref: the lower 4 bits of the ID should be 0.
>> + // If it is end pref: the lower 4 bits of the ID should not be 0.
>> + // If input ID doesn't follow the rule, we will adjust it.
>> + //
>> + if ((Identifier != 0) && (IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
>> + return EFI_UNSUPPORTED;
>> + } else if ((Identifier != 0) && (!IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
>> + if (IsStart && ((Identifier & 0x000F) != 0)) {
>> + Identifier &= 0xFFF0;
>> + } else if ((!IsStart) && ((Identifier & 0x000F) == 0)) {
>> + Identifier += 1;
>> + }
>> + RecordInfo.ProgressID = (UINT16)Identifier;
>> + }
>> +
>> + if (mFpdtBufferIsReported) {
>> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)FpdtRecord;
>> + } else {
>> + //
>> + // Check if pre-allocated buffer is full
>> //
>> - // Try to enlarge the scale of gauge array.
>> + if (mPerformanceLength + RecordInfo.RecordSize > mMaxPerformanceLength) {
>> + mPerformancePointer = ReallocatePool (
>> + mPerformanceLength,
>> + mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER,
>> + mPerformancePointer
>> + );
>> +
>> + if (mPerformancePointer == NULL) {
>> + return EFI_OUT_OF_RESOURCES;
>> + }
>> + mMaxPerformanceLength = mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER;
>> + }
>> //
>> - OldGaugeData = mGaugeData;
>> - OldGaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords;
>> + // Covert buffer to FPDT Ptr Union type.
>> + //
>> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(mPerformancePointer + mPerformanceLength);
>> + }
>> + FpdtRecordPtr.RecordHeader->Length = 0;
>>
>> - GaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords * 2;
>> + //
>> + // Get the TimeStamp.
>> + //
>> + if (Ticker == 0) {
>> + Ticker = GetPerformanceCounter ();
>> + TimeStamp = GetTimeInNanoSecond (Ticker);
>> + } else if (Ticker == 1) {
>> + TimeStamp = 0;
>> + } else {
>> + TimeStamp = GetTimeInNanoSecond (Ticker);
>> + }
>>
>> - NewGaugeData = AllocateZeroPool (GaugeDataSize);
>> - if (NewGaugeData == NULL) {
>> - EfiReleaseLock (&mPerfRecordLock);
>> - return EFI_OUT_OF_RESOURCES;
>> + //
>> + // Get the ModuleName and ModuleGuid form the handle.
>> + //
>> + GetModuleInfoFromHandle ((EFI_HANDLE *)Handle, ModuleName, sizeof (ModuleName), &ModuleGuid);
>> +
>> + //
>> + // Fill in the record information.
>> + //
>> + switch (RecordInfo.Type) {
>> + case GUID_EVENT_TYPE:
>> + FpdtRecordPtr.GuidEvent->Header.Type = GUID_EVENT_TYPE;
>> + FpdtRecordPtr.GuidEvent->Header.Length = RecordInfo.RecordSize;
>> + FpdtRecordPtr.GuidEvent->Header.Revision = RECORD_REVISION_1;
>> + FpdtRecordPtr.GuidEvent->ProgressID = RecordInfo.ProgressID;
>> + FpdtRecordPtr.GuidEvent->Timestamp = TimeStamp;
>> + CopyMem (&FpdtRecordPtr.GuidEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidEvent->Guid));
>> + break;
>> +
>> + case DYNAMIC_STRING_EVENT_TYPE:
>> + FpdtRecordPtr.DynamicStringEvent->Header.Type = DYNAMIC_STRING_EVENT_TYPE;
>> + FpdtRecordPtr.DynamicStringEvent->Header.Length = RecordInfo.RecordSize;
>> + FpdtRecordPtr.DynamicStringEvent->Header.Revision = RECORD_REVISION_1;
>> + FpdtRecordPtr.DynamicStringEvent->ProgressID = RecordInfo.ProgressID;
>> + FpdtRecordPtr.DynamicStringEvent->Timestamp = TimeStamp;
>> + CopyMem (&FpdtRecordPtr.DynamicStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.DynamicStringEvent->Guid));
>> +
>> + if (UseModuleName) {
>> + StringPtr = ModuleName;
>> + } else if (Token != NULL) {
>> + StringPtr = Token;
>> + } else if (Module != NULL) {
>> + StringPtr = Module;
>> + } else if (ModuleName != NULL) {
>> + StringPtr = ModuleName;
>> + }
>> + if (StringPtr != NULL && AsciiStrLen (StringPtr) != 0) {
>> + StrLength = AsciiStrLen (StringPtr);
>> + DestMax = (RecordInfo.RecordSize - sizeof (DYNAMIC_STRING_EVENT_RECORD)) / sizeof (CHAR8);
>> + if (StrLength >= DestMax) {
>> + StrLength = DestMax -1;
>> + }
>> + AsciiStrnCpyS (FpdtRecordPtr.DynamicStringEvent->String, DestMax, StringPtr, StrLength);
>> }
>> + break;
>> +
>> + case GUID_QWORD_EVENT_TYPE:
>> + FpdtRecordPtr.GuidQwordEvent->Header.Type = GUID_QWORD_EVENT_TYPE;
>> + FpdtRecordPtr.GuidQwordEvent->Header.Length = RecordInfo.RecordSize;
>> + FpdtRecordPtr.GuidQwordEvent->Header.Revision = RECORD_REVISION_1;
>> + FpdtRecordPtr.GuidQwordEvent->ProgressID = RecordInfo.ProgressID;
>> + FpdtRecordPtr.GuidQwordEvent->Timestamp = TimeStamp;
>> + CopyMem (&FpdtRecordPtr.GuidQwordEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordEvent->Guid));
>> + if ((MODULE_LOADIMAGE_START_ID == RecordInfo.ProgressID) && AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) {
>> + mLoadImageCount++;
>> + FpdtRecordPtr.GuidQwordEvent->Qword = mLoadImageCount;
>> + }
>> + break;
>> +
>> + case GUID_QWORD_STRING_EVENT_TYPE:
>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Type = GUID_QWORD_STRING_EVENT_TYPE;
>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Length = RecordInfo.RecordSize;
>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Revision = RECORD_REVISION_1;
>> + FpdtRecordPtr.GuidQwordStringEvent->ProgressID = RecordInfo.ProgressID;
>> + FpdtRecordPtr.GuidQwordStringEvent->Timestamp = TimeStamp;
>> + CopyMem (&FpdtRecordPtr.GuidQwordStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordStringEvent->Guid));
>> + break;
>> +
>> + default:
>> + //
>> + // Record is not supported in current DXE phase, return EFI_ABORTED
>> + //
>> + return EFI_UNSUPPORTED;
>> + }
>> +
>> + //
>> + // Report record one by one after records have been reported together.
>> + //
>> + if (mFpdtBufferIsReported) {
>> + //
>> + // Append Boot records to the boot performance table.
>> + //
>> + if (mBootRecordSize + FpdtRecordPtr.RecordHeader->Length > mBootRecordMaxSize) {
>> + if (!mLackSpaceIsReported) {
>> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: No enough space to save boot records\n"));
>> + mLackSpaceIsReported = TRUE;
>> + }
>> + return EFI_OUT_OF_RESOURCES;
>> + } else {
>> + //
>> + // Save boot record into BootPerformance table
>> + //
>> + CopyMem (mBootRecordBuffer + mBootRecordSize, FpdtRecordPtr.RecordHeader, FpdtRecordPtr.RecordHeader->Length);
>> + mBootRecordSize += FpdtRecordPtr.RecordHeader->Length;
>> + mAcpiBootPerformanceTable->Header.Length += FpdtRecordPtr.RecordHeader->Length;
>> + }
>> + } else {
>> + //
>> + // Update the cached FPDT record buffer.
>> + //
>> + mPerformanceLength += FpdtRecordPtr.RecordHeader->Length;
>> + }
>> +
>> + return EFI_SUCCESS;
>> +}
>> +
>> +/**
>> + Dumps all the PEI performance.
>> +
>> + @param HobStart A pointer to a Guid.
>>
>> - mGaugeData = NewGaugeData;
>> - mMaxGaugeRecords *= 2;
>> + This internal function dumps all the PEI performance log to the DXE performance gauge array.
>> + It retrieves the optional GUID HOB for PEI performance and then saves the performance data
>> + to DXE performance data structures.
>>
>> +**/
>> +VOID
>> +InternalGetPeiPerformance (
>> + VOID *HobStart
>> + )
>> +{
>> + UINT8 *FirmwarePerformanceHob;
>> + PEI_EXT_FIRMWARE_PERF_HEADER *PeiPerformanceLogHeader;
>> + UINT8 *EventRec;
>> + EFI_HOB_GUID_TYPE *GuidHob;
>> +
>> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, HobStart);
>> + while (GuidHob != NULL) {
>> + FirmwarePerformanceHob = GET_GUID_HOB_DATA (GuidHob);
>> + PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *)FirmwarePerformanceHob;
>> +
>> + if (mPerformanceLength + PeiPerformanceLogHeader->SizeOfAllEntries > mMaxPerformanceLength) {
>> + mPerformancePointer = ReallocatePool (
>> + mPerformanceLength,
>> + mPerformanceLength +
>> + (UINTN)PeiPerformanceLogHeader->SizeOfAllEntries +
>> + FIRMWARE_RECORD_BUFFER,
>> + mPerformancePointer
>> + );
>> + ASSERT (mPerformancePointer != NULL);
>> + mMaxPerformanceLength = mPerformanceLength +
>> + (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries) +
>> + FIRMWARE_RECORD_BUFFER;
>> + }
>> +
>> + EventRec = mPerformancePointer + mPerformanceLength;
>> + CopyMem (EventRec, FirmwarePerformanceHob + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER), (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries));
>> //
>> - // Initialize new data array and migrate old data one.
>> + // Update the used buffer size.
>> //
>> - mGaugeData = CopyMem (mGaugeData, OldGaugeData, OldGaugeDataSize);
>> + mPerformanceLength += (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries);
>> + mLoadImageCount += PeiPerformanceLogHeader->LoadImageCount;
>>
>> - FreePool (OldGaugeData);
>> + //
>> + // Get next performance guid hob
>> + //
>> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, GET_NEXT_HOB (GuidHob));
>> }
>> +}
>>
>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>> - GaugeEntryExArray[Index].Handle = (EFI_PHYSICAL_ADDRESS) (UINTN) Handle;
>> +/**
>> + Report Boot Perforamnce table address as report status code.
>>
>> - if (Token != NULL) {
>> - AsciiStrnCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, Token, DXE_PERFORMANCE_STRING_LENGTH);
>> - }
>> - if (Module != NULL) {
>> - AsciiStrnCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, Module, DXE_PERFORMANCE_STRING_LENGTH);
>> + @param Event The event of notify protocol.
>> + @param Context Notify event context.
>> +
>> +**/
>> +VOID
>> +EFIAPI
>> +ReportFpdtRecordBuffer (
>> + IN EFI_EVENT Event,
>> + IN VOID *Context
>> + )
>> +{
>> + EFI_STATUS Status;
>> + UINT64 BPDTAddr;
>> +
>> + if (!mFpdtBufferIsReported) {
>> + Status = AllocateBootPerformanceTable ();
>> + if (!EFI_ERROR(Status)) {
>> + BPDTAddr = (UINT64)(UINTN)mAcpiBootPerformanceTable;
>> + REPORT_STATUS_CODE_EX (
>> + EFI_PROGRESS_CODE,
>> + EFI_SOFTWARE_DXE_BS_DRIVER,
>> + 0,
>> + NULL,
>> + &gEfiFirmwarePerformanceGuid,
>> + &BPDTAddr,
>> + sizeof (UINT64)
>> + );
>> + }
>> + //
>> + // Free Cached FPDT record Buffer
>> + //
>> + if (mPerformancePointer != NULL) {
>> + FreePool (mPerformancePointer);
>> + mPerformancePointer = NULL;
>> + }
>> + mPerformanceLength = 0;
>> + mMaxPerformanceLength = 0;
>> + //
>> + // Set FPDT report state to TRUE.
>> + //
>> + mFpdtBufferIsReported = TRUE;
>> }
>> +}
>>
>> - GaugeEntryExArray[Index].EndTimeStamp = 0;
>> - GaugeEntryExArray[Index].Identifier = Identifier;
>> +/**
>> + Adds a record at the end of the performance measurement log
>> + that records the start time of a performance measurement.
>>
>> - if (TimeStamp == 0) {
>> - TimeStamp = GetPerformanceCounter ();
>> - }
>> - GaugeEntryExArray[Index].StartTimeStamp = TimeStamp;
>> + Adds a record to the end of the performance measurement log
>> + that contains the Handle, Token, Module and Identifier.
>> + The end time of the new record must be set to zero.
>> + If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
>> + If TimeStamp is zero, the start time in the record is filled in with the value
>> + read from the current time stamp.
>>
>> - mGaugeData->NumberOfEntries++;
>> + @param Handle Pointer to environment specific context used
>> + to identify the component being measured.
>> + @param Token Pointer to a Null-terminated ASCII string
>> + that identifies the component being measured.
>> + @param Module Pointer to a Null-terminated ASCII string
>> + that identifies the module being measured.
>> + @param TimeStamp 64-bit time stamp.
>> + @param Identifier 32-bit identifier. If the value is 0, the created record
>> + is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>>
>> - EfiReleaseLock (&mPerfRecordLock);
>> + @retval EFI_SUCCESS The data was read correctly from the device.
>> + @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>>
>> - return EFI_SUCCESS;
>> +**/
>> +EFI_STATUS
>> +EFIAPI
>> +StartGaugeEx (
>> + IN CONST VOID *Handle, OPTIONAL
>> + IN CONST CHAR8 *Token, OPTIONAL
>> + IN CONST CHAR8 *Module, OPTIONAL
>> + IN UINT64 TimeStamp,
>> + IN UINT32 Identifier
>> + )
>> +{
>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
>> }
>>
>> /**
>> Searches the performance measurement log from the beginning of the log
>> for the first matching record that contains a zero end time and fills in a valid end time.
>>
>> Searches the performance measurement log from the beginning of the log
>> - for the first record that matches Handle, Token and Module and has an end time value of zero.
>> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
>> If the record can not be found then return EFI_NOT_FOUND.
>> If the record is found and TimeStamp is not zero,
>> then the end time in the record is filled in with the value specified by TimeStamp.
>> If the record is found and TimeStamp is zero, then the end time in the matching record
>> is filled in with the current time stamp value.
>> @@ -260,89 +1188,19 @@ EndGaugeEx (
>> IN CONST CHAR8 *Module, OPTIONAL
>> IN UINT64 TimeStamp,
>> IN UINT32 Identifier
>> )
>> {
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>> - UINT32 Index;
>> - EFI_STATUS Status;
>> -
>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>> - if (EFI_ERROR (Status)) {
>> - return Status;
>> - }
>> -
>> - if (TimeStamp == 0) {
>> - TimeStamp = GetPerformanceCounter ();
>> - }
>> -
>> - Index = InternalSearchForGaugeEntry (Handle, Token, Module, Identifier);
>> - if (Index >= mGaugeData->NumberOfEntries) {
>> - EfiReleaseLock (&mPerfRecordLock);
>> - return EFI_NOT_FOUND;
>> - }
>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>> - GaugeEntryExArray[Index].EndTimeStamp = TimeStamp;
>> -
>> - EfiReleaseLock (&mPerfRecordLock);
>> - return EFI_SUCCESS;
>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
>> }
>>
>> /**
>> Retrieves a previously logged performance measurement.
>> It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
>> and then assign the Identifier with 0.
>>
>> - Retrieves the performance log entry from the performance log specified by LogEntryKey.
>> - If it stands for a valid entry, then EFI_SUCCESS is returned and
>> - GaugeDataEntryEx stores the pointer to that entry.
>> -
>> - This internal function is added to avoid releasing lock before each return statement.
>> -
>> - @param LogEntryKey The key for the previous performance measurement log entry.
>> - If 0, then the first performance measurement log entry is retrieved.
>> - @param GaugeDataEntryEx The indirect pointer to the extended gauge data entry specified by LogEntryKey
>> - if the retrieval is successful.
>> -
>> - @retval EFI_SUCCESS The GuageDataEntryEx is successfully found based on LogEntryKey.
>> - @retval EFI_NOT_FOUND The LogEntryKey is the last entry (equals to the total entry number).
>> - @retval EFI_INVALIDE_PARAMETER The LogEntryKey is not a valid entry (greater than the total entry number).
>> - @retval EFI_INVALIDE_PARAMETER GaugeDataEntryEx is NULL.
>> -
>> -**/
>> -EFI_STATUS
>> -EFIAPI
>> -InternalGetGaugeEx (
>> - IN UINTN LogEntryKey,
>> - OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
>> - )
>> -{
>> - UINTN NumberOfEntries;
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>> -
>> - NumberOfEntries = (UINTN) (mGaugeData->NumberOfEntries);
>> - if (LogEntryKey > NumberOfEntries) {
>> - return EFI_INVALID_PARAMETER;
>> - }
>> - if (LogEntryKey == NumberOfEntries) {
>> - return EFI_NOT_FOUND;
>> - }
>> -
>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>> -
>> - if (GaugeDataEntryEx == NULL) {
>> - return EFI_INVALID_PARAMETER;
>> - }
>> - *GaugeDataEntryEx = &GaugeEntryExArray[LogEntryKey];
>> -
>> - return EFI_SUCCESS;
>> -}
>> -
>> -/**
>> - Retrieves a previously logged performance measurement.
>> - It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
>> - and then assign the Identifier with 0.
>> + !!! Not support!!!
>>
>> Retrieves the performance log entry from the performance log specified by LogEntryKey.
>> If it stands for a valid entry, then EFI_SUCCESS is returned and
>> GaugeDataEntryEx stores the pointer to that entry.
>>
>> @@ -362,22 +1220,11 @@ EFIAPI
>> GetGaugeEx (
>> IN UINTN LogEntryKey,
>> OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
>> )
>> {
>> - EFI_STATUS Status;
>> -
>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>> - if (EFI_ERROR (Status)) {
>> - return Status;
>> - }
>> -
>> - Status = InternalGetGaugeEx (LogEntryKey, GaugeDataEntryEx);
>> -
>> - EfiReleaseLock (&mPerfRecordLock);
>> -
>> - return Status;
>> + return EFI_UNSUPPORTED;
>> }
>>
>> /**
>> Adds a record at the end of the performance measurement log
>> that records the start time of a performance measurement.
>> @@ -452,10 +1299,12 @@ EndGauge (
>> /**
>> Retrieves a previously logged performance measurement.
>> It can also retrieve the log created by StartGaugeEx and EndGaugeEx of PERFORMANCE_EX_PROTOCOL,
>> and then eliminate the Identifier.
>>
>> + !!! Not support!!!
>> +
>> Retrieves the performance log entry from the performance log specified by LogEntryKey.
>> If it stands for a valid entry, then EFI_SUCCESS is returned and
>> GaugeDataEntry stores the pointer to that entry.
>>
>> @param LogEntryKey The key for the previous performance measurement log entry.
>> @@ -474,81 +1323,13 @@ EFIAPI
>> GetGauge (
>> IN UINTN LogEntryKey,
>> OUT GAUGE_DATA_ENTRY **GaugeDataEntry
>> )
>> {
>> - EFI_STATUS Status;
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryEx;
>> -
>> - GaugeEntryEx = NULL;
>> -
>> - Status = GetGaugeEx (LogEntryKey, &GaugeEntryEx);
>> - if (EFI_ERROR (Status)) {
>> - return Status;
>> - }
>> -
>> - if (GaugeDataEntry == NULL) {
>> - return EFI_INVALID_PARAMETER;
>> - }
>> -
>> - *GaugeDataEntry = (GAUGE_DATA_ENTRY *) GaugeEntryEx;
>> -
>> - return EFI_SUCCESS;
>> + return EFI_UNSUPPORTED;
>> }
>>
>> -/**
>> - Dumps all the PEI performance log to DXE performance gauge array.
>> -
>> - This internal function dumps all the PEI performance log to the DXE performance gauge array.
>> - It retrieves the optional GUID HOB for PEI performance and then saves the performance data
>> - to DXE performance data structures.
>> -
>> -**/
>> -VOID
>> -InternalGetPeiPerformance (
>> - VOID
>> - )
>> -{
>> - EFI_HOB_GUID_TYPE *GuidHob;
>> - PEI_PERFORMANCE_LOG_HEADER *LogHob;
>> - PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
>> - UINT32 *LogIdArray;
>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>> - UINT32 Index;
>> - UINT32 NumberOfEntries;
>> -
>> - NumberOfEntries = 0;
>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>> -
>> - //
>> - // Dump PEI Log Entries to DXE Guage Data structure.
>> - //
>> - GuidHob = GetFirstGuidHob (&gPerformanceProtocolGuid);
>> - if (GuidHob != NULL) {
>> - LogHob = GET_GUID_HOB_DATA (GuidHob);
>> - LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (LogHob + 1);
>> -
>> - NumberOfEntries = LogHob->NumberOfEntries;
>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>> - GaugeEntryExArray[Index].Handle = LogEntryArray[Index].Handle;
>> - AsciiStrCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Token);
>> - AsciiStrCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Module);
>> - GaugeEntryExArray[Index].StartTimeStamp = LogEntryArray[Index].StartTimeStamp;
>> - GaugeEntryExArray[Index].EndTimeStamp = LogEntryArray[Index].EndTimeStamp;
>> - GaugeEntryExArray[Index].Identifier = 0;
>> - }
>> -
>> - GuidHob = GetFirstGuidHob (&gPerformanceExProtocolGuid);
>> - if (GuidHob != NULL) {
>> - LogIdArray = GET_GUID_HOB_DATA (GuidHob);
>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>> - GaugeEntryExArray[Index].Identifier = LogIdArray[Index];
>> - }
>> - }
>> - }
>> - mGaugeData->NumberOfEntries = NumberOfEntries;
>> -}
>>
>> /**
>> The constructor function initializes Performance infrastructure for DXE phase.
>>
>> The constructor function publishes Performance and PerformanceEx protocol, allocates memory to log DXE performance
>> @@ -567,40 +1348,53 @@ DxeCorePerformanceLibConstructor (
>> IN EFI_HANDLE ImageHandle,
>> IN EFI_SYSTEM_TABLE *SystemTable
>> )
>> {
>> EFI_STATUS Status;
>> + EFI_HANDLE Handle;
>> + EFI_EVENT ReadyToBootEvent;
>> PERFORMANCE_PROPERTY *PerformanceProperty;
>>
>> -
>> if (!PerformanceMeasurementEnabled ()) {
>> //
>> // Do not initialize performance infrastructure if not required.
>> //
>> return EFI_SUCCESS;
>> }
>> +
>> + //
>> + // Dump normal PEI performance records
>> + //
>> + InternalGetPeiPerformance (GetHobList());
>> +
>> //
>> - // Install the protocol interfaces.
>> + // Install the protocol interfaces for DXE performance library instance.
>> //
>> + Handle = NULL;
>> Status = gBS->InstallMultipleProtocolInterfaces (
>> - &mHandle,
>> + &Handle,
>> &gPerformanceProtocolGuid,
>> &mPerformanceInterface,
>> &gPerformanceExProtocolGuid,
>> &mPerformanceExInterface,
>> NULL
>> );
>> ASSERT_EFI_ERROR (Status);
>>
>> - mMaxGaugeRecords = INIT_DXE_GAUGE_DATA_ENTRIES + (UINT16) (PcdGet16 (PcdMaxPeiPerformanceLogEntries16) != 0 ?
>> - PcdGet16 (PcdMaxPeiPerformanceLogEntries16) :
>> - PcdGet8 (PcdMaxPeiPerformanceLogEntries));
>> -
>> - mGaugeData = AllocateZeroPool (sizeof (GAUGE_DATA_HEADER) + (sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords));
>> - ASSERT (mGaugeData != NULL);
>> + //
>> + // Register ReadyToBoot event to report StatusCode data
>> + //
>> + Status = gBS->CreateEventEx (
>> + EVT_NOTIFY_SIGNAL,
>> + TPL_CALLBACK,
>> + ReportFpdtRecordBuffer,
>> + NULL,
>> + &gEfiEventReadyToBootGuid,
>> + &ReadyToBootEvent
>> + );
>>
>> - InternalGetPeiPerformance ();
>> + ASSERT_EFI_ERROR (Status);
>>
>> Status = EfiGetSystemConfigurationTable (&gPerformanceProtocolGuid, (VOID **) &PerformanceProperty);
>> if (EFI_ERROR (Status)) {
>> //
>> // Install configuration table for performance property.
>> @@ -651,19 +1445,19 @@ StartPerformanceMeasurementEx (
>> IN CONST CHAR8 *Module, OPTIONAL
>> IN UINT64 TimeStamp,
>> IN UINT32 Identifier
>> )
>> {
>> - return (RETURN_STATUS) StartGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
>> }
>>
>> /**
>> Searches the performance measurement log from the beginning of the log
>> for the first matching record that contains a zero end time and fills in a valid end time.
>>
>> Searches the performance measurement log from the beginning of the log
>> - for the first record that matches Handle, Token and Module and has an end time value of zero.
>> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
>> If the record can not be found then return RETURN_NOT_FOUND.
>> If the record is found and TimeStamp is not zero,
>> then the end time in the record is filled in with the value specified by TimeStamp.
>> If the record is found and TimeStamp is zero, then the end time in the matching record
>> is filled in with the current time stamp value.
>> @@ -690,18 +1484,20 @@ EndPerformanceMeasurementEx (
>> IN CONST CHAR8 *Module, OPTIONAL
>> IN UINT64 TimeStamp,
>> IN UINT32 Identifier
>> )
>> {
>> - return (RETURN_STATUS) EndGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
>> }
>>
>> /**
>> Attempts to retrieve a performance measurement log entry from the performance measurement log.
>> It can also retrieve the log created by StartPerformanceMeasurement and EndPerformanceMeasurement,
>> and then assign the Identifier with 0.
>>
>> + !!! Not support!!!
>> +
>> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
>> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
>> and the key for the second entry in the log is returned. If the performance log is empty,
>> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
>> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
>> @@ -729,63 +1525,29 @@ EndPerformanceMeasurementEx (
>> being measured.
>> @param StartTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
>> was started.
>> @param EndTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
>> was ended.
>> - @param Identifier Pointer to the 32-bit identifier that was recorded.
>> + @param Identifier Pointer to the 32-bit identifier that was recorded when the measurement
>> + was ended.
>>
>> @return The key for the next performance log entry (in general case).
>>
>> **/
>> UINTN
>> EFIAPI
>> GetPerformanceMeasurementEx (
>> - IN UINTN LogEntryKey,
>> + IN UINTN LogEntryKey,
>> OUT CONST VOID **Handle,
>> OUT CONST CHAR8 **Token,
>> OUT CONST CHAR8 **Module,
>> OUT UINT64 *StartTimeStamp,
>> OUT UINT64 *EndTimeStamp,
>> OUT UINT32 *Identifier
>> )
>> {
>> - EFI_STATUS Status;
>> - GAUGE_DATA_ENTRY_EX *GaugeData;
>> -
>> - GaugeData = NULL;
>> -
>> - ASSERT (Handle != NULL);
>> - ASSERT (Token != NULL);
>> - ASSERT (Module != NULL);
>> - ASSERT (StartTimeStamp != NULL);
>> - ASSERT (EndTimeStamp != NULL);
>> - ASSERT (Identifier != NULL);
>> -
>> - Status = GetGaugeEx (LogEntryKey++, &GaugeData);
>> -
>> - //
>> - // Make sure that LogEntryKey is a valid log entry key,
>> - //
>> - ASSERT (Status != EFI_INVALID_PARAMETER);
>> -
>> - if (EFI_ERROR (Status)) {
>> - //
>> - // The LogEntryKey is the last entry (equals to the total entry number).
>> - //
>> - return 0;
>> - }
>> -
>> - ASSERT (GaugeData != NULL);
>> -
>> - *Handle = (VOID *) (UINTN) GaugeData->Handle;
>> - *Token = GaugeData->Token;
>> - *Module = GaugeData->Module;
>> - *StartTimeStamp = GaugeData->StartTimeStamp;
>> - *EndTimeStamp = GaugeData->EndTimeStamp;
>> - *Identifier = GaugeData->Identifier;
>> -
>> - return LogEntryKey;
>> + return 0;
>> }
>>
>> /**
>> Adds a record at the end of the performance measurement log
>> that records the start time of a performance measurement.
>> @@ -816,11 +1578,11 @@ StartPerformanceMeasurement (
>> IN CONST CHAR8 *Token, OPTIONAL
>> IN CONST CHAR8 *Module, OPTIONAL
>> IN UINT64 TimeStamp
>> )
>> {
>> - return StartPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, 0);
>> }
>>
>> /**
>> Searches the performance measurement log from the beginning of the log
>> for the first matching record that contains a zero end time and fills in a valid end time.
>> @@ -852,18 +1614,20 @@ EndPerformanceMeasurement (
>> IN CONST CHAR8 *Token, OPTIONAL
>> IN CONST CHAR8 *Module, OPTIONAL
>> IN UINT64 TimeStamp
>> )
>> {
>> - return EndPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, 0);
>> }
>>
>> /**
>> Attempts to retrieve a performance measurement log entry from the performance measurement log.
>> It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
>> and then eliminate the Identifier.
>>
>> + !!! Not support!!!
>> +
>> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
>> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
>> and the key for the second entry in the log is returned. If the performance log is empty,
>> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
>> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
>> @@ -905,12 +1669,11 @@ GetPerformanceMeasurement (
>> OUT CONST CHAR8 **Module,
>> OUT UINT64 *StartTimeStamp,
>> OUT UINT64 *EndTimeStamp
>> )
>> {
>> - UINT32 Identifier;
>> - return GetPerformanceMeasurementEx (LogEntryKey, Handle, Token, Module, StartTimeStamp, EndTimeStamp, &Identifier);
>> + return 0;
>> }
>>
>> /**
>> Returns TRUE if the performance measurement macros are enabled.
>>
>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>> index 5b89ce2..71c181f 100644
>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>> @@ -7,11 +7,11 @@
>> # It initializes DXE phase performance logging by publishing the Performance and PerformanceEx Protocol,
>> # which is consumed by DxePerformanceLib to logging performance data in DXE phase.
>> # This library is mainly used by DxeCore to start performance logging to ensure that
>> # Performance and PerformanceEx Protocol are installed at the very beginning of DXE phase.
>> #
>> -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>> # This program and the accompanying materials
>> # are licensed and made available under the terms and conditions of the BSD License
>> # which accompanies this distribution. The full text of the license may be found at
>> # http://opensource.org/licenses/bsd-license.php
>> @@ -48,27 +48,39 @@
>>
>>
>> [LibraryClasses]
>> MemoryAllocationLib
>> UefiBootServicesTableLib
>> + UefiRuntimeServicesTableLib
>> PcdLib
>> TimerLib
>> BaseMemoryLib
>> BaseLib
>> HobLib
>> DebugLib
>> UefiLib
>> + ReportStatusCodeLib
>> + DxeServicesLib
>> + PeCoffGetEntryPointLib
>> +
>> +[Protocols]
>> + gEfiSmmCommunicationProtocolGuid ## SOMETIMES_CONSUMES
>>
>>
>> [Guids]
>> ## SOMETIMES_CONSUMES ## HOB
>> ## PRODUCES ## UNDEFINED # Install protocol
>> ## PRODUCES ## SystemTable
>> gPerformanceProtocolGuid
>> ## SOMETIMES_CONSUMES ## HOB
>> ## PRODUCES ## UNDEFINED # Install protocol
>> gPerformanceExProtocolGuid
>> + gZeroGuid ## SOMETIMES_CONSUMES ## GUID
>> + gEfiFirmwarePerformanceGuid ## SOMETIMES_PRODUCES ## UNDEFINED # StatusCode Data
>> + gEdkiiExtendedFirmwarePerformanceGuid ## SOMETIMES_CONSUMES ## HOB # StatusCode Data
>> + gEfiEventReadyToBootGuid ## CONSUMES ## Event
>> + gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable
>>
>> [Pcd]
>> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries ## CONSUMES
>> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16 ## CONSUMES
>> - gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
>> + gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly ## CONSUMES
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES
>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>> index f1540d8..7e79675 100644
>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>> @@ -2,11 +2,11 @@
>> Master header files for DxeCorePerformanceLib instance.
>>
>> This header file holds the prototypes of the Performance and PerformanceEx Protocol published by this
>> library instance at its constructor.
>>
>> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>> This program and the accompanying materials
>> are licensed and made available under the terms and conditions of the BSD License
>> which accompanies this distribution. The full text of the license may be found at
>> http://opensource.org/licenses/bsd-license.php
>>
>> @@ -20,21 +20,36 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>>
>>
>> #include <PiDxe.h>
>>
>> #include <Guid/Performance.h>
>> +#include <Guid/ExtendedFirmwarePerformance.h>
>> +#include <Guid/ZeroGuid.h>
>> +#include <Guid/EventGroup.h>
>> +#include <Guid/FirmwarePerformance.h>
>> +#include <Guid/PiSmmCommunicationRegionTable.h>
>> +
>> +#include <Protocol/DriverBinding.h>
>> +#include <Protocol/LoadedImage.h>
>> +#include <Protocol/ComponentName2.h>
>> +#include <Protocol/DevicePathToText.h>
>> +#include <Protocol/SmmCommunication.h>
>>
>> #include <Library/PerformanceLib.h>
>> #include <Library/DebugLib.h>
>> #include <Library/HobLib.h>
>> #include <Library/BaseLib.h>
>> #include <Library/BaseMemoryLib.h>
>> #include <Library/TimerLib.h>
>> #include <Library/PcdLib.h>
>> #include <Library/UefiBootServicesTableLib.h>
>> +#include <Library/UefiRuntimeServicesTableLib.h>
>> #include <Library/MemoryAllocationLib.h>
>> #include <Library/UefiLib.h>
>> +#include <Library/ReportStatusCodeLib.h>
>> +#include <Library/DxeServicesLib.h>
>> +#include <Library/PeCoffGetEntryPointLib.h>
>>
>> //
>> // Interface declarations for PerformanceEx Protocol.
>> //
>> /**
>> --
>> 1.9.5.msysgit.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-05-22 8:58 ` Zeng, Star
@ 2018-05-22 9:02 ` Ard Biesheuvel
2018-05-22 9:38 ` Zeng, Star
0 siblings, 1 reply; 21+ messages in thread
From: Ard Biesheuvel @ 2018-05-22 9:02 UTC (permalink / raw)
To: Zeng, Star
Cc: Bi, Dandan, Laszlo Ersek, Andrew Fish, Kinney, Michael D,
Leif Lindholm, edk2-devel@lists.01.org, Gao, Liming, Matt Sealey
pd On 22 May 2018 at 10:58, Zeng, Star <star.zeng@intel.com> wrote:
> How about the code to try allocating <4G memory, then try allocating any memory if failed to allocate <4G memory?
>
> For example, the code snippet in SmbiosDxe.c.
>
> PhysicalAddress = 0xffffffff;
> Status = gBS->AllocatePages (
> AllocateMaxAddress,
> EfiRuntimeServicesData,
> EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
> &PhysicalAddress
> );
> if (EFI_ERROR (Status)) {
> DEBUG ((EFI_D_ERROR, "SmbiosCreateTable () could not allocate EntryPointStructure < 4GB\n"));
> Status = gBS->AllocatePages (
> AllocateAnyPages,
> EfiRuntimeServicesData,
> EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
> &PhysicalAddress
> );
> if (EFI_ERROR (Status)) {
> return EFI_OUT_OF_RESOURCES;
> }
> }
>
Yes, that should do the trick.
But perhaps we should add something like
AllocatePeiAccessiblePages()
to MemoryAllocationLib, which just uses AllocateMaxAddress or
AllocateAnyPages depending on whether MDE_CPU_X64 is #defined.
--
Ard.
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, May 22, 2018 4:52 PM
> To: Bi, Dandan <dandan.bi@intel.com>; Laszlo Ersek <lersek@redhat.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>; edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
> Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>
> (+ Laszlo, Andrew, Mike)
>
> On 22 May 2018 at 02:33, Bi, Dandan <dandan.bi@intel.com> wrote:
>> Sorry for the delayed response.
>>
>> The allocated performance table ( below 4G ) is to save the boot performance data in normal boot and S3 phase.
>> PEIM FirmwarePerformancePei will get the address of the performance table and update the performance date of S3 phase to the table.
>> The address need to be handled in PEI phase(32bit), that's the main reason why we allocate it below 4G.
>>
>
> The 32-bit PEI + 64-bit DXE combo is specific to X64. You have added
> code to a generic library that ASSERT()s if allocating memory below 4
> GB fails, breaking non-PC architectures.
>
> So please, fix this. Or at least suggest a way around it so that other
> architectures can keep using this library.
>
> This is another consequence of our failure to model the special 32-bit
> PEI/64-bit DXE combination using proper PI interfaces, resulting in
> these kinds of breakages and open coded 4 GB allocations all
> throughout the code. Can we please work on getting this fixed?
>
>
>> -----Original Message-----
>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>> Sent: Wednesday, May 2, 2018 12:27 AM
>> To: Bi, Dandan <dandan.bi@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
>> Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>>
>> On 30 January 2018 at 14:53, Dandan Bi <dandan.bi@intel.com> wrote:
>>> V2:
>>> Update DxecorePerformanceLib to report the boot performance table
>>> address instead of records contents.
>>>
>>> Updated to convert Pref entry to FPDT record in DXE phase and then
>>> allocate boot performance table to save the record and report
>>> the address of boot performance table to FirmwarePerformanceDxe.
>>>
>>> Cc: Liming Gao <liming.gao@intel.com>
>>> Cc: Star Zeng <star.zeng@intel.com>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>>> ---
>>> .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 1389 +++++++++++++++-----
>>> .../DxeCorePerformanceLib.inf | 20 +-
>>> .../DxeCorePerformanceLibInternal.h | 17 +-
>>> 3 files changed, 1108 insertions(+), 318 deletions(-)
>>>
>>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>>> index 7c0e207..c6f8a16 100644
>>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>>> @@ -8,11 +8,11 @@
>>> which are consumed by DxePerformanceLib to logging performance data in DXE phase.
>>>
>>> This library is mainly used by DxeCore to start performance logging to ensure that
>>> Performance Protocol is installed at the very beginning of DXE phase.
>>>
>>> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>>> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>>> This program and the accompanying materials
>>> are licensed and made available under the terms and conditions of the BSD License
>>> which accompanies this distribution. The full text of the license may be found at
>>> http://opensource.org/licenses/bsd-license.php
>>> @@ -23,27 +23,65 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>>> **/
>>>
>>>
>>> #include "DxeCorePerformanceLibInternal.h"
>>>
>>> -
>>> //
>>> -// The data structure to hold global performance data.
>>> +// Data for FPDT performance records.
>>> //
>>> -GAUGE_DATA_HEADER *mGaugeData;
>>> +#define SMM_BOOT_RECORD_COMM_SIZE (OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + sizeof(SMM_BOOT_RECORD_COMMUNICATE))
>>> +#define STRING_SIZE (EDKII_STRING_EVENT_RECORD_NAME_LENGTH * sizeof (CHAR8))
>>> +#define MAX_RECORD_SIZE (sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE)
>>> +#define FIRMWARE_RECORD_BUFFER 0x10000
>>> +#define CACHE_HANDLE_GUID_COUNT 0x1000
>>> +
>>> +BOOT_PERFORMANCE_TABLE *mAcpiBootPerformanceTable = NULL;
>>> +BOOT_PERFORMANCE_TABLE mBootPerformanceTableTemplate = {
>>> + {
>>> + EFI_ACPI_5_0_FPDT_BOOT_PERFORMANCE_TABLE_SIGNATURE,
>>> + sizeof (BOOT_PERFORMANCE_TABLE)
>>> + },
>>> + {
>>> + {
>>> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_TYPE_FIRMWARE_BASIC_BOOT, // Type
>>> + sizeof (EFI_ACPI_5_0_FPDT_FIRMWARE_BASIC_BOOT_RECORD), // Length
>>> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_REVISION_FIRMWARE_BASIC_BOOT // Revision
>>> + },
>>> + 0, // Reserved
>>> + //
>>> + // These values will be updated at runtime.
>>> + //
>>> + 0, // ResetEnd
>>> + 0, // OsLoaderLoadImageStart
>>> + 0, // OsLoaderStartImageStart
>>> + 0, // ExitBootServicesEntry
>>> + 0 // ExitBootServicesExit
>>> + }
>>> +};
>>>
>>> -//
>>> -// The current maximum number of logging entries. If current number of
>>> -// entries exceeds this value, it will re-allocate a larger array and
>>> -// migration the old data to the larger array.
>>> -//
>>> -UINT32 mMaxGaugeRecords;
>>> +typedef struct {
>>> + EFI_HANDLE Handle;
>>> + CHAR8 NameString[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
>>> + EFI_GUID ModuleGuid;
>>> +} HANDLE_GUID_MAP;
>>>
>>> -//
>>> -// The handle to install Performance Protocol instance.
>>> -//
>>> -EFI_HANDLE mHandle = NULL;
>>> +HANDLE_GUID_MAP mCacheHandleGuidTable[CACHE_HANDLE_GUID_COUNT];
>>> +UINTN mCachePairCount = 0;
>>> +
>>> +UINT32 mLoadImageCount = 0;
>>> +UINT32 mPerformanceLength = 0;
>>> +UINT32 mMaxPerformanceLength = 0;
>>> +UINT32 mBootRecordSize = 0;
>>> +UINT32 mBootRecordMaxSize = 0;
>>> +
>>> +BOOLEAN mFpdtBufferIsReported = FALSE;
>>> +BOOLEAN mLackSpaceIsReported = FALSE;
>>> +CHAR8 *mPlatformLanguage = NULL;
>>> +UINT8 *mPerformancePointer = NULL;
>>> +UINT8 *mBootRecordBuffer = NULL;
>>> +
>>> +EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *mDevicePathToText = NULL;
>>>
>>> //
>>> // Interfaces for Performance Protocol.
>>> //
>>> PERFORMANCE_PROTOCOL mPerformanceInterface = {
>>> @@ -61,179 +99,1069 @@ PERFORMANCE_EX_PROTOCOL mPerformanceExInterface = {
>>> GetGaugeEx
>>> };
>>>
>>> PERFORMANCE_PROPERTY mPerformanceProperty;
>>>
>>> -//
>>> -// Gauge record lock to avoid data corruption or even memory overflow
>>> -//
>>> -STATIC EFI_LOCK mPerfRecordLock = EFI_INITIALIZE_LOCK_VARIABLE (TPL_NOTIFY);
>>> +/**
>>> +Check whether the Token is a known one which is uesed by core.
>>> +
>>> +@param Token Pointer to a Null-terminated ASCII string
>>> +
>>> +@retval TRUE Is a known one used by core.
>>> +@retval FALSE Not a known one.
>>> +
>>> +**/
>>> +BOOLEAN
>>> +IsKnownTokens (
>>> + IN CONST CHAR8 *Token
>>> + )
>>> +{
>>> + if (AsciiStrCmp (Token, SEC_TOK) == 0 ||
>>> + AsciiStrCmp (Token, PEI_TOK) == 0 ||
>>> + AsciiStrCmp (Token, DXE_TOK) == 0 ||
>>> + AsciiStrCmp (Token, BDS_TOK) == 0 ||
>>> + AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0 ||
>>> + AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0 ||
>>> + AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0 ||
>>> + AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0 ||
>>> + AsciiStrCmp (Token, START_IMAGE_TOK) == 0 ||
>>> + AsciiStrCmp (Token, PEIM_TOK) == 0) {
>>> + return TRUE;
>>> + } else {
>>> + return FALSE;
>>> + }
>>> +}
>>> +
>>> +/**
>>> +Check whether the ID is a known one which map to the known Token.
>>> +
>>> +@param Identifier 32-bit identifier.
>>> +
>>> +@retval TRUE Is a known one used by core.
>>> +@retval FALSE Not a known one.
>>> +
>>> +**/
>>> +BOOLEAN
>>> +IsKnownID (
>>> + IN UINT32 Identifier
>>> + )
>>> +{
>>> + if (Identifier == MODULE_START_ID ||
>>> + Identifier == MODULE_END_ID ||
>>> + Identifier == MODULE_LOADIMAGE_START_ID ||
>>> + Identifier == MODULE_LOADIMAGE_END_ID ||
>>> + Identifier == MODULE_DB_START_ID ||
>>> + Identifier == MODULE_DB_END_ID ||
>>> + Identifier == MODULE_DB_SUPPORT_START_ID ||
>>> + Identifier == MODULE_DB_SUPPORT_END_ID ||
>>> + Identifier == MODULE_DB_STOP_START_ID ||
>>> + Identifier == MODULE_DB_STOP_END_ID) {
>>> + return TRUE;
>>> + } else {
>>> + return FALSE;
>>> + }
>>> +}
>>>
>>> /**
>>> - Searches in the gauge array with keyword Handle, Token, Module and Identifier.
>>> + Allocate EfiReservedMemoryType below 4G memory address.
>>> +
>>> + This function allocates EfiReservedMemoryType below 4G memory address.
>>> +
>>> + @param[in] Size Size of memory to allocate.
>>> +
>>> + @return Allocated address for output.
>>> +
>>> +**/
>>> +VOID *
>>> +FpdtAllocateReservedMemoryBelow4G (
>>> + IN UINTN Size
>>> + )
>>> +{
>>> + UINTN Pages;
>>> + EFI_PHYSICAL_ADDRESS Address;
>>> + EFI_STATUS Status;
>>> + VOID *Buffer;
>>> +
>>> + Buffer = NULL;
>>> + Pages = EFI_SIZE_TO_PAGES (Size);
>>> + Address = 0xffffffff;
>>> +
>>> + Status = gBS->AllocatePages (
>>> + AllocateMaxAddress,
>>> + EfiReservedMemoryType,
>>> + Pages,
>>> + &Address
>>> + );
>>> + ASSERT_EFI_ERROR (Status);
>>
>> This code is breaking DEBUG builds on ARM systems that have no memory
>> below 4 GB.
>>
>>> +
>>> + if (!EFI_ERROR (Status)) {
>>> + Buffer = (VOID *) (UINTN) Address;
>>> + ZeroMem (Buffer, Size);
>>> + }
>>> +
>>> + return Buffer;
>>> +}
>>> +
>>> +/**
>>> + Allocate buffer for Boot Performance table.
>>> +
>>> + @return Status code.
>>> +
>>> +**/
>>> +EFI_STATUS
>>> +AllocateBootPerformanceTable (
>>> + )
>>> +{
>>> + EFI_STATUS Status;
>>> + UINTN Size;
>>> + UINT8 *SmmBootRecordCommBuffer;
>>> + EFI_SMM_COMMUNICATE_HEADER *SmmCommBufferHeader;
>>> + SMM_BOOT_RECORD_COMMUNICATE *SmmCommData;
>>> + UINTN CommSize;
>>> + UINTN BootPerformanceDataSize;
>>> + UINT8 *BootPerformanceData;
>>> + EFI_SMM_COMMUNICATION_PROTOCOL *Communication;
>>> + FIRMWARE_PERFORMANCE_VARIABLE PerformanceVariable;
>>> + EDKII_PI_SMM_COMMUNICATION_REGION_TABLE *SmmCommRegionTable;
>>> + EFI_MEMORY_DESCRIPTOR *SmmCommMemRegion;
>>> + UINTN Index;
>>> + VOID *SmmBootRecordData;
>>> + UINTN SmmBootRecordDataSize;
>>> + UINTN ReservedMemSize;
>>> +
>>> + //
>>> + // Collect boot records from SMM drivers.
>>> + //
>>> + SmmBootRecordCommBuffer = NULL;
>>> + SmmCommData = NULL;
>>> + SmmBootRecordData = NULL;
>>> + SmmBootRecordDataSize = 0;
>>> + ReservedMemSize = 0;
>>> + Status = gBS->LocateProtocol (&gEfiSmmCommunicationProtocolGuid, NULL, (VOID **) &Communication);
>>> + if (!EFI_ERROR (Status)) {
>>> + //
>>> + // Initialize communicate buffer
>>> + // Get the prepared Reserved Memory Range
>>> + //
>>> + Status = EfiGetSystemConfigurationTable (
>>> + &gEdkiiPiSmmCommunicationRegionTableGuid,
>>> + (VOID **) &SmmCommRegionTable
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + ASSERT (SmmCommRegionTable != NULL);
>>> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) (SmmCommRegionTable + 1);
>>> + for (Index = 0; Index < SmmCommRegionTable->NumberOfEntries; Index ++) {
>>> + if (SmmCommMemRegion->Type == EfiConventionalMemory) {
>>> + break;
>>> + }
>>> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) ((UINT8 *) SmmCommMemRegion + SmmCommRegionTable->DescriptorSize);
>>> + }
>>> + ASSERT (Index < SmmCommRegionTable->NumberOfEntries);
>>> + ASSERT (SmmCommMemRegion->PhysicalStart > 0);
>>> + ASSERT (SmmCommMemRegion->NumberOfPages > 0);
>>> + ReservedMemSize = (UINTN) SmmCommMemRegion->NumberOfPages * EFI_PAGE_SIZE;
>>> +
>>> + //
>>> + // Check enough reserved memory space
>>> + //
>>> + if (ReservedMemSize > SMM_BOOT_RECORD_COMM_SIZE) {
>>> + SmmBootRecordCommBuffer = (VOID *) (UINTN) SmmCommMemRegion->PhysicalStart;
>>> + SmmCommBufferHeader = (EFI_SMM_COMMUNICATE_HEADER*)SmmBootRecordCommBuffer;
>>> + SmmCommData = (SMM_BOOT_RECORD_COMMUNICATE*)SmmCommBufferHeader->Data;
>>> + ZeroMem((UINT8*)SmmCommData, sizeof(SMM_BOOT_RECORD_COMMUNICATE));
>>> +
>>> + CopyGuid (&SmmCommBufferHeader->HeaderGuid, &gEfiFirmwarePerformanceGuid);
>>> + SmmCommBufferHeader->MessageLength = sizeof(SMM_BOOT_RECORD_COMMUNICATE);
>>> + CommSize = SMM_BOOT_RECORD_COMM_SIZE;
>>> +
>>> + //
>>> + // Get the size of boot records.
>>> + //
>>> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_SIZE;
>>> + SmmCommData->BootRecordData = NULL;
>>> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
>>> + ASSERT_EFI_ERROR (Status);
>>> +
>>> + if (!EFI_ERROR (SmmCommData->ReturnStatus) && SmmCommData->BootRecordSize != 0) {
>>> + //
>>> + // Get all boot records
>>> + //
>>> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
>>> + SmmBootRecordDataSize = SmmCommData->BootRecordSize;
>>> + SmmBootRecordData = AllocateZeroPool(SmmBootRecordDataSize);
>>> + ASSERT (SmmBootRecordData != NULL);
>>> + SmmCommData->BootRecordOffset = 0;
>>> + SmmCommData->BootRecordData = (VOID *) ((UINTN) SmmCommMemRegion->PhysicalStart + SMM_BOOT_RECORD_COMM_SIZE);
>>> + SmmCommData->BootRecordSize = ReservedMemSize - SMM_BOOT_RECORD_COMM_SIZE;
>>> + while (SmmCommData->BootRecordOffset < SmmBootRecordDataSize) {
>>> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
>>> + ASSERT_EFI_ERROR (Status);
>>> + ASSERT_EFI_ERROR(SmmCommData->ReturnStatus);
>>> + if (SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize > SmmBootRecordDataSize) {
>>> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmBootRecordDataSize - SmmCommData->BootRecordOffset);
>>> + } else {
>>> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmCommData->BootRecordSize);
>>> + }
>>> + SmmCommData->BootRecordOffset = SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize;
>>> + }
>>> + }
>>> + }
>>> + }
>>> + }
>>> +
>>> + //
>>> + // Prepare memory for Boot Performance table.
>>> + // Boot Performance table includes BasicBoot record, and one or more appended Boot Records.
>>> + //
>>> + BootPerformanceDataSize = sizeof (BOOT_PERFORMANCE_TABLE) + mPerformanceLength + PcdGet32 (PcdExtFpdtBootRecordPadSize);
>>> + if (SmmCommData != NULL) {
>>> + BootPerformanceDataSize += SmmBootRecordDataSize;
>>> + }
>>> +
>>> + //
>>> + // Try to allocate the same runtime buffer as last time boot.
>>> + //
>>> + ZeroMem (&PerformanceVariable, sizeof (PerformanceVariable));
>>> + Size = sizeof (PerformanceVariable);
>>> + Status = gRT->GetVariable (
>>> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
>>> + &gEfiFirmwarePerformanceGuid,
>>> + NULL,
>>> + &Size,
>>> + &PerformanceVariable
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + Status = gBS->AllocatePages (
>>> + AllocateAddress,
>>> + EfiReservedMemoryType,
>>> + EFI_SIZE_TO_PAGES (BootPerformanceDataSize),
>>> + &PerformanceVariable.BootPerformanceTablePointer
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) (UINTN) PerformanceVariable.BootPerformanceTablePointer;
>>> + }
>>> + }
>>> +
>>> + if (mAcpiBootPerformanceTable == NULL) {
>>> + //
>>> + // Fail to allocate at specified address, continue to allocate at any address.
>>> + //
>>> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) FpdtAllocateReservedMemoryBelow4G (BootPerformanceDataSize);
>>
>> Why does this allocation need to live below 4 GB?
>>
>> If there is no good reason, can we please get rid of this?
>> If there is a good reason, can we please document it in the code?
>>
>>> + }
>>> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: ACPI Boot Performance Table address = 0x%x\n", mAcpiBootPerformanceTable));
>>> +
>>> + if (mAcpiBootPerformanceTable == NULL) {
>>> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
>>> + FreePool (SmmBootRecordData);
>>> + }
>>> + return EFI_OUT_OF_RESOURCES;
>>> + }
>>> +
>>> + //
>>> + // Prepare Boot Performance Table.
>>> + //
>>> + BootPerformanceData = (UINT8 *) mAcpiBootPerformanceTable;
>>> + //
>>> + // Fill Basic Boot record to Boot Performance Table.
>>> + //
>>> + CopyMem (mAcpiBootPerformanceTable, &mBootPerformanceTableTemplate, sizeof (mBootPerformanceTableTemplate));
>>> + BootPerformanceData = BootPerformanceData + mAcpiBootPerformanceTable->Header.Length;
>>> + //
>>> + // Fill Boot records from boot drivers.
>>> + //
>>> + if (mPerformancePointer != NULL) {
>>> + CopyMem (BootPerformanceData, mPerformancePointer, mPerformanceLength);
>>> + mAcpiBootPerformanceTable->Header.Length += mPerformanceLength;
>>> + BootPerformanceData = BootPerformanceData + mPerformanceLength;
>>> + }
>>> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
>>> + //
>>> + // Fill Boot records from SMM drivers.
>>> + //
>>> + CopyMem (BootPerformanceData, SmmBootRecordData, SmmBootRecordDataSize);
>>> + FreePool (SmmBootRecordData);
>>> + mAcpiBootPerformanceTable->Header.Length = (UINT32) (mAcpiBootPerformanceTable->Header.Length + SmmBootRecordDataSize);
>>> + BootPerformanceData = BootPerformanceData + SmmBootRecordDataSize;
>>> + }
>>> +
>>> + //
>>> + // Save Boot Performance Table address to Variable for use in S4 resume.
>>> + //
>>> + PerformanceVariable.BootPerformanceTablePointer = (EFI_PHYSICAL_ADDRESS) (UINTN) mAcpiBootPerformanceTable;
>>> +
>>> + //
>>> + // Save Runtime Performance Table pointers to Variable.
>>> + // Don't check SetVariable return status. It doesn't impact FPDT table generation.
>>> + //
>>> + gRT->SetVariable (
>>> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
>>> + &gEfiFirmwarePerformanceGuid,
>>> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
>>> + sizeof (PerformanceVariable),
>>> + &PerformanceVariable
>>> + );
>>> +
>>> + mBootRecordBuffer = (UINT8 *) mAcpiBootPerformanceTable;
>>> + mBootRecordSize = mAcpiBootPerformanceTable->Header.Length;
>>> + mBootRecordMaxSize = mBootRecordSize + PcdGet32 (PcdExtFpdtBootRecordPadSize);
>>> +
>>> + return EFI_SUCCESS;
>>> +}
>>> +
>>> +/**
>>> + Get a human readable module name and module guid for the given image handle.
>>> + If module name can't be found, "" string will return.
>>> + If module guid can't be found, Zero Guid will return.
>>> +
>>> + @param Handle Image handle or Controller handle.
>>> + @param NameString The ascii string will be filled into it. If not found, null string will return.
>>> + @param BufferSize Size of the input NameString buffer.
>>> + @param ModuleGuid Point to the guid buffer to store the got module guid value.
>>> +
>>> + @retval EFI_SUCCESS Successfully get module name and guid.
>>> + @retval EFI_INVALID_PARAMETER The input parameter NameString is NULL.
>>> + @retval other value Module Name can't be got.
>>> +**/
>>> +EFI_STATUS
>>> +GetModuleInfoFromHandle (
>>> + IN EFI_HANDLE Handle,
>>> + OUT CHAR8 *NameString,
>>> + IN UINTN BufferSize,
>>> + OUT EFI_GUID *ModuleGuid OPTIONAL
>>> + )
>>> +{
>>> + EFI_STATUS Status;
>>> + EFI_LOADED_IMAGE_PROTOCOL *LoadedImage;
>>> + EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
>>> + CHAR8 *PdbFileName;
>>> + EFI_GUID *TempGuid;
>>> + UINTN StartIndex;
>>> + UINTN Index;
>>> + INTN Count;
>>> + BOOLEAN ModuleGuidIsGet;
>>> + UINTN StringSize;
>>> + CHAR16 *StringPtr;
>>> + EFI_COMPONENT_NAME2_PROTOCOL *ComponentName2;
>>> + MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *FvFilePath;
>>> +
>>> + if (NameString == NULL || BufferSize == 0) {
>>> + return EFI_INVALID_PARAMETER;
>>> + }
>>> + //
>>> + // Try to get the ModuleGuid and name string form the caached array.
>>> + //
>>> + if (mCachePairCount > 0) {
>>> + for (Count = mCachePairCount -1; Count >= 0; Count--) {
>>> + if (Handle == mCacheHandleGuidTable[Count].Handle) {
>>> + CopyGuid (ModuleGuid, &mCacheHandleGuidTable[Count].ModuleGuid);
>>> + AsciiStrCpyS (NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, mCacheHandleGuidTable[Count].NameString);
>>> + return EFI_SUCCESS;
>>> + }
>>> + }
>>> + }
>>> +
>>> + Status = EFI_INVALID_PARAMETER;
>>> + LoadedImage = NULL;
>>> + ModuleGuidIsGet = FALSE;
>>> +
>>> + //
>>> + // Initialize GUID as zero value.
>>> + //
>>> + TempGuid = &gZeroGuid;
>>> + //
>>> + // Initialize it as "" string.
>>> + //
>>> + NameString[0] = 0;
>>> +
>>> + if (Handle != NULL) {
>>> + //
>>> + // Try Handle as ImageHandle.
>>> + //
>>> + Status = gBS->HandleProtocol (
>>> + Handle,
>>> + &gEfiLoadedImageProtocolGuid,
>>> + (VOID**) &LoadedImage
>>> + );
>>> +
>>> + if (EFI_ERROR (Status)) {
>>> + //
>>> + // Try Handle as Controller Handle
>>> + //
>>> + Status = gBS->OpenProtocol (
>>> + Handle,
>>> + &gEfiDriverBindingProtocolGuid,
>>> + (VOID **) &DriverBinding,
>>> + NULL,
>>> + NULL,
>>> + EFI_OPEN_PROTOCOL_GET_PROTOCOL
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + //
>>> + // Get Image protocol from ImageHandle
>>> + //
>>> + Status = gBS->HandleProtocol (
>>> + DriverBinding->ImageHandle,
>>> + &gEfiLoadedImageProtocolGuid,
>>> + (VOID**) &LoadedImage
>>> + );
>>> + }
>>> + }
>>> + }
>>> +
>>> + if (!EFI_ERROR (Status) && LoadedImage != NULL) {
>>> + //
>>> + // Get Module Guid from DevicePath.
>>> + //
>>> + if (LoadedImage->FilePath != NULL &&
>>> + LoadedImage->FilePath->Type == MEDIA_DEVICE_PATH &&
>>> + LoadedImage->FilePath->SubType == MEDIA_PIWG_FW_FILE_DP
>>> + ) {
>>> + //
>>> + // Determine GUID associated with module logging performance
>>> + //
>>> + ModuleGuidIsGet = TRUE;
>>> + FvFilePath = (MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *) LoadedImage->FilePath;
>>> + TempGuid = &FvFilePath->FvFileName;
>>> + }
>>> +
>>> + //
>>> + // Method 1 Get Module Name from PDB string.
>>> + //
>>> + PdbFileName = PeCoffLoaderGetPdbPointer (LoadedImage->ImageBase);
>>> + if (PdbFileName != NULL && BufferSize > 0) {
>>> + StartIndex = 0;
>>> + for (Index = 0; PdbFileName[Index] != 0; Index++) {
>>> + if ((PdbFileName[Index] == '\\') || (PdbFileName[Index] == '/')) {
>>> + StartIndex = Index + 1;
>>> + }
>>> + }
>>> + //
>>> + // Copy the PDB file name to our temporary string.
>>> + // If the length is bigger than BufferSize, trim the redudant characters to avoid overflow in array boundary.
>>> + //
>>> + for (Index = 0; Index < BufferSize - 1; Index++) {
>>> + NameString[Index] = PdbFileName[Index + StartIndex];
>>> + if (NameString[Index] == 0 || NameString[Index] == '.') {
>>> + NameString[Index] = 0;
>>> + break;
>>> + }
>>> + }
>>>
>>> - This internal function searches for the gauge entry in the gauge array.
>>> - If there is an entry that exactly matches the given keywords
>>> - and its end time stamp is zero, then the index of that gauge entry is returned;
>>> - otherwise, the the number of gauge entries in the array is returned.
>>> + if (Index == BufferSize - 1) {
>>> + NameString[Index] = 0;
>>> + }
>>> + //
>>> + // Module Name is got.
>>> + //
>>> + goto Done;
>>> + }
>>> + }
>>>
>>> + //
>>> + // Method 2: Get the name string from ComponentName2 protocol
>>> + //
>>> + Status = gBS->HandleProtocol (
>>> + Handle,
>>> + &gEfiComponentName2ProtocolGuid,
>>> + (VOID **) &ComponentName2
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + //
>>> + // Get the current platform language setting
>>> + //
>>> + if (mPlatformLanguage == NULL) {
>>> + GetEfiGlobalVariable2 (L"PlatformLang", (VOID **) &mPlatformLanguage, NULL);
>>> + }
>>> + if (mPlatformLanguage != NULL) {
>>> + Status = ComponentName2->GetDriverName (
>>> + ComponentName2,
>>> + mPlatformLanguage != NULL ? mPlatformLanguage : "en-US",
>>> + &StringPtr
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
>>> + NameString[Index] = (CHAR8) StringPtr[Index];
>>> + }
>>> + NameString[Index] = 0;
>>> + //
>>> + // Module Name is got.
>>> + //
>>> + goto Done;
>>> + }
>>> + }
>>> + }
>>> +
>>> + if (ModuleGuidIsGet) {
>>> + //
>>> + // Method 3 Try to get the image's FFS UI section by image GUID
>>> + //
>>> + StringPtr = NULL;
>>> + StringSize = 0;
>>> + Status = GetSectionFromAnyFv (
>>> + TempGuid,
>>> + EFI_SECTION_USER_INTERFACE,
>>> + 0,
>>> + (VOID **) &StringPtr,
>>> + &StringSize
>>> + );
>>> +
>>> + if (!EFI_ERROR (Status)) {
>>> + //
>>> + // Method 3. Get the name string from FFS UI section
>>> + //
>>> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
>>> + NameString[Index] = (CHAR8) StringPtr[Index];
>>> + }
>>> + NameString[Index] = 0;
>>> + FreePool (StringPtr);
>>> + }
>>> + }
>>> +
>>> +Done:
>>> + //
>>> + // Copy Module Guid
>>> + //
>>> + if (ModuleGuid != NULL) {
>>> + CopyGuid (ModuleGuid, TempGuid);
>>> + if (IsZeroGuid(TempGuid) && (Handle != NULL) && !ModuleGuidIsGet) {
>>> + // Handle is GUID
>>> + CopyGuid (ModuleGuid, (EFI_GUID *) Handle);
>>> + }
>>> + }
>>> +
>>> + //
>>> + // Cache the Handle and Guid pairs.
>>> + //
>>> + if (mCachePairCount < CACHE_HANDLE_GUID_COUNT) {
>>> + mCacheHandleGuidTable[mCachePairCount].Handle = Handle;
>>> + CopyGuid (&mCacheHandleGuidTable[mCachePairCount].ModuleGuid, ModuleGuid);
>>> + AsciiStrCpyS (mCacheHandleGuidTable[mCachePairCount].NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, NameString);
>>> + mCachePairCount ++;
>>> + }
>>> +
>>> + return Status;
>>> +}
>>> +
>>> +/**
>>> + Get the FPDT record info.
>>> +
>>> + @param IsStart TRUE if the performance log is start log.
>>> @param Handle Pointer to environment specific context used
>>> to identify the component being measured.
>>> @param Token Pointer to a Null-terminated ASCII string
>>> that identifies the component being measured.
>>> @param Module Pointer to a Null-terminated ASCII string
>>> that identifies the module being measured.
>>> - @param Identifier 32-bit identifier.
>>> + @param RecordInfo On return, pointer to the info of the record.
>>> + @param UseModuleName Only useful for DYNAMIC_STRING_EVENT_TYPE, indicate that whether need use
>>> + Module name to fill the string field in the DYNAMIC_STRING_EVENT_RECORD.
>>>
>>> - @retval The index of gauge entry in the array.
>>> + @retval EFI_SUCCESS Get record info successfully.
>>> + @retval EFI_UNSUPPORTED No matched FPDT record.
>>>
>>> **/
>>> -UINT32
>>> -InternalSearchForGaugeEntry (
>>> - IN CONST VOID *Handle, OPTIONAL
>>> - IN CONST CHAR8 *Token, OPTIONAL
>>> - IN CONST CHAR8 *Module, OPTIONAL
>>> - IN UINT32 Identifier
>>> +EFI_STATUS
>>> +GetFpdtRecordInfo (
>>> + IN BOOLEAN IsStart,
>>> + IN CONST VOID *Handle,
>>> + IN CONST CHAR8 *Token,
>>> + IN CONST CHAR8 *Module,
>>> + OUT BASIC_RECORD_INFO *RecordInfo,
>>> + IN OUT BOOLEAN *UseModuleName
>>> )
>>> {
>>> - UINT32 Index;
>>> - UINT32 Index2;
>>> - UINT32 NumberOfEntries;
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>> + UINT16 RecordType;
>>> + UINTN StringSize;
>>>
>>> - if (Token == NULL) {
>>> - Token = "";
>>> - }
>>> - if (Module == NULL) {
>>> - Module = "";
>>> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
>>> +
>>> + //
>>> + // Token to Type and Id.
>>> + //
>>> + if (Token != NULL) {
>>> + if (AsciiStrCmp (Token, START_IMAGE_TOK) == 0) { // "StartImage:"
>>> + *UseModuleName = TRUE;
>>> + RecordType = GUID_EVENT_TYPE;
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = MODULE_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = MODULE_END_ID;
>>> + }
>>> + } else if (AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) { // "LoadImage:"
>>> + *UseModuleName = TRUE;
>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = MODULE_LOADIMAGE_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = MODULE_LOADIMAGE_END_ID;
>>> + }
>>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0) { // "DB:Start:"
>>> + *UseModuleName = TRUE;
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = MODULE_DB_START_ID;
>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>> + } else {
>>> + RecordInfo->ProgressID = MODULE_DB_END_ID;
>>> + RecordType = GUID_QWORD_STRING_EVENT_TYPE;
>>> + }
>>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0) { // "DB:Support:"
>>> + *UseModuleName = TRUE;
>>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>>> + return RETURN_UNSUPPORTED;
>>> + }
>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_END_ID;
>>> + }
>>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0) { // "DB:Stop:"
>>> + *UseModuleName = TRUE;
>>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>>> + return RETURN_UNSUPPORTED;
>>> + }
>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = MODULE_DB_STOP_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = MODULE_DB_STOP_END_ID;
>>> + }
>>> + } else if (AsciiStrCmp (Token, PEI_TOK) == 0 || // "PEI"
>>> + AsciiStrCmp (Token, DXE_TOK) == 0 || // "DXE"
>>> + AsciiStrCmp (Token, BDS_TOK) == 0) { // "BDS"
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = PERF_CROSSMODULE_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = PERF_CROSSMODULE_END_ID;
>>> + }
>>> + } else { // Pref used in Modules.
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
>>> + }
>>> + }
>>> + } else if (Handle!= NULL || Module != NULL) { // Pref used in Modules.
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
>>> + }
>>> + } else {
>>> + return EFI_UNSUPPORTED;
>>> }
>>>
>>> - NumberOfEntries = mGaugeData->NumberOfEntries;
>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>> + //
>>> + // Get Record size baesed on the record type.
>>> + // When PcdEdkiiFpdtStringRecordEnableOnly is TRUE, all records are with type of DYNAMIC_STRING_EVENT_TYPE.
>>> + //
>>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>>> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
>>> + RecordInfo->RecordSize = sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE;
>>> + } else {
>>> + switch (RecordType) {
>>> + case GUID_EVENT_TYPE:
>>> + RecordInfo->RecordSize = sizeof (GUID_EVENT_RECORD);
>>> + break;
>>>
>>> - Index2 = 0;
>>> + case DYNAMIC_STRING_EVENT_TYPE:
>>> + if (*UseModuleName) {
>>> + StringSize = STRING_SIZE;
>>> + } else if (Token != NULL) {
>>> + StringSize = AsciiStrSize (Token);
>>> + } else if (Module != NULL) {
>>> + StringSize = AsciiStrSize (Module);
>>> + } else {
>>> + StringSize = STRING_SIZE;
>>> + }
>>> + if (StringSize > STRING_SIZE) {
>>> + StringSize = STRING_SIZE;
>>> + }
>>> + RecordInfo->RecordSize = (UINT8)(sizeof (DYNAMIC_STRING_EVENT_RECORD) + StringSize);
>>> + break;
>>>
>>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>>> - Index2 = NumberOfEntries - 1 - Index;
>>> - if (GaugeEntryExArray[Index2].EndTimeStamp == 0 &&
>>> - (GaugeEntryExArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&
>>> - AsciiStrnCmp (GaugeEntryExArray[Index2].Token, Token, DXE_PERFORMANCE_STRING_LENGTH) == 0 &&
>>> - AsciiStrnCmp (GaugeEntryExArray[Index2].Module, Module, DXE_PERFORMANCE_STRING_LENGTH) == 0) {
>>> - Index = Index2;
>>> + case GUID_QWORD_EVENT_TYPE:
>>> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_EVENT_RECORD);
>>> break;
>>> +
>>> + case GUID_QWORD_STRING_EVENT_TYPE:
>>> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_STRING_EVENT_RECORD);
>>> + break;
>>> +
>>> + default:
>>> + //
>>> + // Record is unsupported yet, return EFI_UNSUPPORTED
>>> + //
>>> + return EFI_UNSUPPORTED;
>>> }
>>> }
>>>
>>> - return Index;
>>> + RecordInfo->Type = RecordType;
>>> + return EFI_SUCCESS;
>>> }
>>>
>>> /**
>>> - Adds a record at the end of the performance measurement log
>>> - that records the start time of a performance measurement.
>>> -
>>> - Adds a record to the end of the performance measurement log
>>> - that contains the Handle, Token, Module and Identifier.
>>> - The end time of the new record must be set to zero.
>>> - If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
>>> - If TimeStamp is zero, the start time in the record is filled in with the value
>>> - read from the current time stamp.
>>> + Add performance log to FPDT boot record table.
>>>
>>> + @param IsStart TRUE if the performance log is start log.
>>> @param Handle Pointer to environment specific context used
>>> to identify the component being measured.
>>> @param Token Pointer to a Null-terminated ASCII string
>>> that identifies the component being measured.
>>> @param Module Pointer to a Null-terminated ASCII string
>>> that identifies the module being measured.
>>> - @param TimeStamp 64-bit time stamp.
>>> + @param Ticker 64-bit time stamp.
>>> @param Identifier 32-bit identifier. If the value is 0, the created record
>>> is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>>>
>>> - @retval EFI_SUCCESS The data was read correctly from the device.
>>> + @retval EFI_SUCCESS Add FPDT boot record.
>>> @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>>> + @retval EFI_UNSUPPORTED No matched FPDT record.
>>>
>>> **/
>>> EFI_STATUS
>>> -EFIAPI
>>> -StartGaugeEx (
>>> +InsertFpdtMeasurement (
>>> + IN BOOLEAN IsStart,
>>> IN CONST VOID *Handle, OPTIONAL
>>> IN CONST CHAR8 *Token, OPTIONAL
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> - IN UINT64 TimeStamp,
>>> + IN UINT64 Ticker,
>>> IN UINT32 Identifier
>>> )
>>> {
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>> - UINTN GaugeDataSize;
>>> - GAUGE_DATA_HEADER *NewGaugeData;
>>> - UINTN OldGaugeDataSize;
>>> - GAUGE_DATA_HEADER *OldGaugeData;
>>> - UINT32 Index;
>>> - EFI_STATUS Status;
>>> + EFI_GUID ModuleGuid;
>>> + CHAR8 ModuleName[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
>>> + UINT8 FpdtRecord[MAX_RECORD_SIZE];
>>> + EFI_STATUS Status;
>>> + FPDT_RECORD_PTR FpdtRecordPtr;
>>> + BASIC_RECORD_INFO RecordInfo;
>>> + UINT64 TimeStamp;
>>> + UINTN DestMax;
>>> + UINTN StrLength;
>>> + CONST CHAR8 *StringPtr;
>>> + BOOLEAN UseModuleName;
>>> +
>>> + StringPtr = NULL;
>>> + UseModuleName = FALSE;
>>> + ZeroMem (ModuleName, sizeof (ModuleName));
>>> + ZeroMem (FpdtRecord, sizeof (FpdtRecord));
>>>
>>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>>> + //
>>> + // Get record info (type, size, ProgressID and Module Guid).
>>> + //
>>> + Status = GetFpdtRecordInfo (IsStart, Handle, Token, Module, &RecordInfo, &UseModuleName);
>>> if (EFI_ERROR (Status)) {
>>> return Status;
>>> }
>>>
>>> - Index = mGaugeData->NumberOfEntries;
>>> - if (Index >= mMaxGaugeRecords) {
>>> + //
>>> + // If PERF_START()/PERF_END() have specified the ProgressID,it has high priority.
>>> + // !!! Note: If the Pref is not the known Token used in the core but have same
>>> + // ID with the core Token, this case will not be supported.
>>> + // And in currtnt usage mode, for the unkown ID, there is a general rule:
>>> + // If it is start pref: the lower 4 bits of the ID should be 0.
>>> + // If it is end pref: the lower 4 bits of the ID should not be 0.
>>> + // If input ID doesn't follow the rule, we will adjust it.
>>> + //
>>> + if ((Identifier != 0) && (IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
>>> + return EFI_UNSUPPORTED;
>>> + } else if ((Identifier != 0) && (!IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
>>> + if (IsStart && ((Identifier & 0x000F) != 0)) {
>>> + Identifier &= 0xFFF0;
>>> + } else if ((!IsStart) && ((Identifier & 0x000F) == 0)) {
>>> + Identifier += 1;
>>> + }
>>> + RecordInfo.ProgressID = (UINT16)Identifier;
>>> + }
>>> +
>>> + if (mFpdtBufferIsReported) {
>>> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)FpdtRecord;
>>> + } else {
>>> + //
>>> + // Check if pre-allocated buffer is full
>>> //
>>> - // Try to enlarge the scale of gauge array.
>>> + if (mPerformanceLength + RecordInfo.RecordSize > mMaxPerformanceLength) {
>>> + mPerformancePointer = ReallocatePool (
>>> + mPerformanceLength,
>>> + mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER,
>>> + mPerformancePointer
>>> + );
>>> +
>>> + if (mPerformancePointer == NULL) {
>>> + return EFI_OUT_OF_RESOURCES;
>>> + }
>>> + mMaxPerformanceLength = mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER;
>>> + }
>>> //
>>> - OldGaugeData = mGaugeData;
>>> - OldGaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords;
>>> + // Covert buffer to FPDT Ptr Union type.
>>> + //
>>> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(mPerformancePointer + mPerformanceLength);
>>> + }
>>> + FpdtRecordPtr.RecordHeader->Length = 0;
>>>
>>> - GaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords * 2;
>>> + //
>>> + // Get the TimeStamp.
>>> + //
>>> + if (Ticker == 0) {
>>> + Ticker = GetPerformanceCounter ();
>>> + TimeStamp = GetTimeInNanoSecond (Ticker);
>>> + } else if (Ticker == 1) {
>>> + TimeStamp = 0;
>>> + } else {
>>> + TimeStamp = GetTimeInNanoSecond (Ticker);
>>> + }
>>>
>>> - NewGaugeData = AllocateZeroPool (GaugeDataSize);
>>> - if (NewGaugeData == NULL) {
>>> - EfiReleaseLock (&mPerfRecordLock);
>>> - return EFI_OUT_OF_RESOURCES;
>>> + //
>>> + // Get the ModuleName and ModuleGuid form the handle.
>>> + //
>>> + GetModuleInfoFromHandle ((EFI_HANDLE *)Handle, ModuleName, sizeof (ModuleName), &ModuleGuid);
>>> +
>>> + //
>>> + // Fill in the record information.
>>> + //
>>> + switch (RecordInfo.Type) {
>>> + case GUID_EVENT_TYPE:
>>> + FpdtRecordPtr.GuidEvent->Header.Type = GUID_EVENT_TYPE;
>>> + FpdtRecordPtr.GuidEvent->Header.Length = RecordInfo.RecordSize;
>>> + FpdtRecordPtr.GuidEvent->Header.Revision = RECORD_REVISION_1;
>>> + FpdtRecordPtr.GuidEvent->ProgressID = RecordInfo.ProgressID;
>>> + FpdtRecordPtr.GuidEvent->Timestamp = TimeStamp;
>>> + CopyMem (&FpdtRecordPtr.GuidEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidEvent->Guid));
>>> + break;
>>> +
>>> + case DYNAMIC_STRING_EVENT_TYPE:
>>> + FpdtRecordPtr.DynamicStringEvent->Header.Type = DYNAMIC_STRING_EVENT_TYPE;
>>> + FpdtRecordPtr.DynamicStringEvent->Header.Length = RecordInfo.RecordSize;
>>> + FpdtRecordPtr.DynamicStringEvent->Header.Revision = RECORD_REVISION_1;
>>> + FpdtRecordPtr.DynamicStringEvent->ProgressID = RecordInfo.ProgressID;
>>> + FpdtRecordPtr.DynamicStringEvent->Timestamp = TimeStamp;
>>> + CopyMem (&FpdtRecordPtr.DynamicStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.DynamicStringEvent->Guid));
>>> +
>>> + if (UseModuleName) {
>>> + StringPtr = ModuleName;
>>> + } else if (Token != NULL) {
>>> + StringPtr = Token;
>>> + } else if (Module != NULL) {
>>> + StringPtr = Module;
>>> + } else if (ModuleName != NULL) {
>>> + StringPtr = ModuleName;
>>> + }
>>> + if (StringPtr != NULL && AsciiStrLen (StringPtr) != 0) {
>>> + StrLength = AsciiStrLen (StringPtr);
>>> + DestMax = (RecordInfo.RecordSize - sizeof (DYNAMIC_STRING_EVENT_RECORD)) / sizeof (CHAR8);
>>> + if (StrLength >= DestMax) {
>>> + StrLength = DestMax -1;
>>> + }
>>> + AsciiStrnCpyS (FpdtRecordPtr.DynamicStringEvent->String, DestMax, StringPtr, StrLength);
>>> }
>>> + break;
>>> +
>>> + case GUID_QWORD_EVENT_TYPE:
>>> + FpdtRecordPtr.GuidQwordEvent->Header.Type = GUID_QWORD_EVENT_TYPE;
>>> + FpdtRecordPtr.GuidQwordEvent->Header.Length = RecordInfo.RecordSize;
>>> + FpdtRecordPtr.GuidQwordEvent->Header.Revision = RECORD_REVISION_1;
>>> + FpdtRecordPtr.GuidQwordEvent->ProgressID = RecordInfo.ProgressID;
>>> + FpdtRecordPtr.GuidQwordEvent->Timestamp = TimeStamp;
>>> + CopyMem (&FpdtRecordPtr.GuidQwordEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordEvent->Guid));
>>> + if ((MODULE_LOADIMAGE_START_ID == RecordInfo.ProgressID) && AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) {
>>> + mLoadImageCount++;
>>> + FpdtRecordPtr.GuidQwordEvent->Qword = mLoadImageCount;
>>> + }
>>> + break;
>>> +
>>> + case GUID_QWORD_STRING_EVENT_TYPE:
>>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Type = GUID_QWORD_STRING_EVENT_TYPE;
>>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Length = RecordInfo.RecordSize;
>>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Revision = RECORD_REVISION_1;
>>> + FpdtRecordPtr.GuidQwordStringEvent->ProgressID = RecordInfo.ProgressID;
>>> + FpdtRecordPtr.GuidQwordStringEvent->Timestamp = TimeStamp;
>>> + CopyMem (&FpdtRecordPtr.GuidQwordStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordStringEvent->Guid));
>>> + break;
>>> +
>>> + default:
>>> + //
>>> + // Record is not supported in current DXE phase, return EFI_ABORTED
>>> + //
>>> + return EFI_UNSUPPORTED;
>>> + }
>>> +
>>> + //
>>> + // Report record one by one after records have been reported together.
>>> + //
>>> + if (mFpdtBufferIsReported) {
>>> + //
>>> + // Append Boot records to the boot performance table.
>>> + //
>>> + if (mBootRecordSize + FpdtRecordPtr.RecordHeader->Length > mBootRecordMaxSize) {
>>> + if (!mLackSpaceIsReported) {
>>> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: No enough space to save boot records\n"));
>>> + mLackSpaceIsReported = TRUE;
>>> + }
>>> + return EFI_OUT_OF_RESOURCES;
>>> + } else {
>>> + //
>>> + // Save boot record into BootPerformance table
>>> + //
>>> + CopyMem (mBootRecordBuffer + mBootRecordSize, FpdtRecordPtr.RecordHeader, FpdtRecordPtr.RecordHeader->Length);
>>> + mBootRecordSize += FpdtRecordPtr.RecordHeader->Length;
>>> + mAcpiBootPerformanceTable->Header.Length += FpdtRecordPtr.RecordHeader->Length;
>>> + }
>>> + } else {
>>> + //
>>> + // Update the cached FPDT record buffer.
>>> + //
>>> + mPerformanceLength += FpdtRecordPtr.RecordHeader->Length;
>>> + }
>>> +
>>> + return EFI_SUCCESS;
>>> +}
>>> +
>>> +/**
>>> + Dumps all the PEI performance.
>>> +
>>> + @param HobStart A pointer to a Guid.
>>>
>>> - mGaugeData = NewGaugeData;
>>> - mMaxGaugeRecords *= 2;
>>> + This internal function dumps all the PEI performance log to the DXE performance gauge array.
>>> + It retrieves the optional GUID HOB for PEI performance and then saves the performance data
>>> + to DXE performance data structures.
>>>
>>> +**/
>>> +VOID
>>> +InternalGetPeiPerformance (
>>> + VOID *HobStart
>>> + )
>>> +{
>>> + UINT8 *FirmwarePerformanceHob;
>>> + PEI_EXT_FIRMWARE_PERF_HEADER *PeiPerformanceLogHeader;
>>> + UINT8 *EventRec;
>>> + EFI_HOB_GUID_TYPE *GuidHob;
>>> +
>>> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, HobStart);
>>> + while (GuidHob != NULL) {
>>> + FirmwarePerformanceHob = GET_GUID_HOB_DATA (GuidHob);
>>> + PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *)FirmwarePerformanceHob;
>>> +
>>> + if (mPerformanceLength + PeiPerformanceLogHeader->SizeOfAllEntries > mMaxPerformanceLength) {
>>> + mPerformancePointer = ReallocatePool (
>>> + mPerformanceLength,
>>> + mPerformanceLength +
>>> + (UINTN)PeiPerformanceLogHeader->SizeOfAllEntries +
>>> + FIRMWARE_RECORD_BUFFER,
>>> + mPerformancePointer
>>> + );
>>> + ASSERT (mPerformancePointer != NULL);
>>> + mMaxPerformanceLength = mPerformanceLength +
>>> + (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries) +
>>> + FIRMWARE_RECORD_BUFFER;
>>> + }
>>> +
>>> + EventRec = mPerformancePointer + mPerformanceLength;
>>> + CopyMem (EventRec, FirmwarePerformanceHob + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER), (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries));
>>> //
>>> - // Initialize new data array and migrate old data one.
>>> + // Update the used buffer size.
>>> //
>>> - mGaugeData = CopyMem (mGaugeData, OldGaugeData, OldGaugeDataSize);
>>> + mPerformanceLength += (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries);
>>> + mLoadImageCount += PeiPerformanceLogHeader->LoadImageCount;
>>>
>>> - FreePool (OldGaugeData);
>>> + //
>>> + // Get next performance guid hob
>>> + //
>>> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, GET_NEXT_HOB (GuidHob));
>>> }
>>> +}
>>>
>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>> - GaugeEntryExArray[Index].Handle = (EFI_PHYSICAL_ADDRESS) (UINTN) Handle;
>>> +/**
>>> + Report Boot Perforamnce table address as report status code.
>>>
>>> - if (Token != NULL) {
>>> - AsciiStrnCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, Token, DXE_PERFORMANCE_STRING_LENGTH);
>>> - }
>>> - if (Module != NULL) {
>>> - AsciiStrnCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, Module, DXE_PERFORMANCE_STRING_LENGTH);
>>> + @param Event The event of notify protocol.
>>> + @param Context Notify event context.
>>> +
>>> +**/
>>> +VOID
>>> +EFIAPI
>>> +ReportFpdtRecordBuffer (
>>> + IN EFI_EVENT Event,
>>> + IN VOID *Context
>>> + )
>>> +{
>>> + EFI_STATUS Status;
>>> + UINT64 BPDTAddr;
>>> +
>>> + if (!mFpdtBufferIsReported) {
>>> + Status = AllocateBootPerformanceTable ();
>>> + if (!EFI_ERROR(Status)) {
>>> + BPDTAddr = (UINT64)(UINTN)mAcpiBootPerformanceTable;
>>> + REPORT_STATUS_CODE_EX (
>>> + EFI_PROGRESS_CODE,
>>> + EFI_SOFTWARE_DXE_BS_DRIVER,
>>> + 0,
>>> + NULL,
>>> + &gEfiFirmwarePerformanceGuid,
>>> + &BPDTAddr,
>>> + sizeof (UINT64)
>>> + );
>>> + }
>>> + //
>>> + // Free Cached FPDT record Buffer
>>> + //
>>> + if (mPerformancePointer != NULL) {
>>> + FreePool (mPerformancePointer);
>>> + mPerformancePointer = NULL;
>>> + }
>>> + mPerformanceLength = 0;
>>> + mMaxPerformanceLength = 0;
>>> + //
>>> + // Set FPDT report state to TRUE.
>>> + //
>>> + mFpdtBufferIsReported = TRUE;
>>> }
>>> +}
>>>
>>> - GaugeEntryExArray[Index].EndTimeStamp = 0;
>>> - GaugeEntryExArray[Index].Identifier = Identifier;
>>> +/**
>>> + Adds a record at the end of the performance measurement log
>>> + that records the start time of a performance measurement.
>>>
>>> - if (TimeStamp == 0) {
>>> - TimeStamp = GetPerformanceCounter ();
>>> - }
>>> - GaugeEntryExArray[Index].StartTimeStamp = TimeStamp;
>>> + Adds a record to the end of the performance measurement log
>>> + that contains the Handle, Token, Module and Identifier.
>>> + The end time of the new record must be set to zero.
>>> + If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
>>> + If TimeStamp is zero, the start time in the record is filled in with the value
>>> + read from the current time stamp.
>>>
>>> - mGaugeData->NumberOfEntries++;
>>> + @param Handle Pointer to environment specific context used
>>> + to identify the component being measured.
>>> + @param Token Pointer to a Null-terminated ASCII string
>>> + that identifies the component being measured.
>>> + @param Module Pointer to a Null-terminated ASCII string
>>> + that identifies the module being measured.
>>> + @param TimeStamp 64-bit time stamp.
>>> + @param Identifier 32-bit identifier. If the value is 0, the created record
>>> + is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>>>
>>> - EfiReleaseLock (&mPerfRecordLock);
>>> + @retval EFI_SUCCESS The data was read correctly from the device.
>>> + @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>>>
>>> - return EFI_SUCCESS;
>>> +**/
>>> +EFI_STATUS
>>> +EFIAPI
>>> +StartGaugeEx (
>>> + IN CONST VOID *Handle, OPTIONAL
>>> + IN CONST CHAR8 *Token, OPTIONAL
>>> + IN CONST CHAR8 *Module, OPTIONAL
>>> + IN UINT64 TimeStamp,
>>> + IN UINT32 Identifier
>>> + )
>>> +{
>>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
>>> }
>>>
>>> /**
>>> Searches the performance measurement log from the beginning of the log
>>> for the first matching record that contains a zero end time and fills in a valid end time.
>>>
>>> Searches the performance measurement log from the beginning of the log
>>> - for the first record that matches Handle, Token and Module and has an end time value of zero.
>>> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
>>> If the record can not be found then return EFI_NOT_FOUND.
>>> If the record is found and TimeStamp is not zero,
>>> then the end time in the record is filled in with the value specified by TimeStamp.
>>> If the record is found and TimeStamp is zero, then the end time in the matching record
>>> is filled in with the current time stamp value.
>>> @@ -260,89 +1188,19 @@ EndGaugeEx (
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> IN UINT64 TimeStamp,
>>> IN UINT32 Identifier
>>> )
>>> {
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>> - UINT32 Index;
>>> - EFI_STATUS Status;
>>> -
>>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>>> - if (EFI_ERROR (Status)) {
>>> - return Status;
>>> - }
>>> -
>>> - if (TimeStamp == 0) {
>>> - TimeStamp = GetPerformanceCounter ();
>>> - }
>>> -
>>> - Index = InternalSearchForGaugeEntry (Handle, Token, Module, Identifier);
>>> - if (Index >= mGaugeData->NumberOfEntries) {
>>> - EfiReleaseLock (&mPerfRecordLock);
>>> - return EFI_NOT_FOUND;
>>> - }
>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>> - GaugeEntryExArray[Index].EndTimeStamp = TimeStamp;
>>> -
>>> - EfiReleaseLock (&mPerfRecordLock);
>>> - return EFI_SUCCESS;
>>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
>>> }
>>>
>>> /**
>>> Retrieves a previously logged performance measurement.
>>> It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
>>> and then assign the Identifier with 0.
>>>
>>> - Retrieves the performance log entry from the performance log specified by LogEntryKey.
>>> - If it stands for a valid entry, then EFI_SUCCESS is returned and
>>> - GaugeDataEntryEx stores the pointer to that entry.
>>> -
>>> - This internal function is added to avoid releasing lock before each return statement.
>>> -
>>> - @param LogEntryKey The key for the previous performance measurement log entry.
>>> - If 0, then the first performance measurement log entry is retrieved.
>>> - @param GaugeDataEntryEx The indirect pointer to the extended gauge data entry specified by LogEntryKey
>>> - if the retrieval is successful.
>>> -
>>> - @retval EFI_SUCCESS The GuageDataEntryEx is successfully found based on LogEntryKey.
>>> - @retval EFI_NOT_FOUND The LogEntryKey is the last entry (equals to the total entry number).
>>> - @retval EFI_INVALIDE_PARAMETER The LogEntryKey is not a valid entry (greater than the total entry number).
>>> - @retval EFI_INVALIDE_PARAMETER GaugeDataEntryEx is NULL.
>>> -
>>> -**/
>>> -EFI_STATUS
>>> -EFIAPI
>>> -InternalGetGaugeEx (
>>> - IN UINTN LogEntryKey,
>>> - OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
>>> - )
>>> -{
>>> - UINTN NumberOfEntries;
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>> -
>>> - NumberOfEntries = (UINTN) (mGaugeData->NumberOfEntries);
>>> - if (LogEntryKey > NumberOfEntries) {
>>> - return EFI_INVALID_PARAMETER;
>>> - }
>>> - if (LogEntryKey == NumberOfEntries) {
>>> - return EFI_NOT_FOUND;
>>> - }
>>> -
>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>> -
>>> - if (GaugeDataEntryEx == NULL) {
>>> - return EFI_INVALID_PARAMETER;
>>> - }
>>> - *GaugeDataEntryEx = &GaugeEntryExArray[LogEntryKey];
>>> -
>>> - return EFI_SUCCESS;
>>> -}
>>> -
>>> -/**
>>> - Retrieves a previously logged performance measurement.
>>> - It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
>>> - and then assign the Identifier with 0.
>>> + !!! Not support!!!
>>>
>>> Retrieves the performance log entry from the performance log specified by LogEntryKey.
>>> If it stands for a valid entry, then EFI_SUCCESS is returned and
>>> GaugeDataEntryEx stores the pointer to that entry.
>>>
>>> @@ -362,22 +1220,11 @@ EFIAPI
>>> GetGaugeEx (
>>> IN UINTN LogEntryKey,
>>> OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
>>> )
>>> {
>>> - EFI_STATUS Status;
>>> -
>>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>>> - if (EFI_ERROR (Status)) {
>>> - return Status;
>>> - }
>>> -
>>> - Status = InternalGetGaugeEx (LogEntryKey, GaugeDataEntryEx);
>>> -
>>> - EfiReleaseLock (&mPerfRecordLock);
>>> -
>>> - return Status;
>>> + return EFI_UNSUPPORTED;
>>> }
>>>
>>> /**
>>> Adds a record at the end of the performance measurement log
>>> that records the start time of a performance measurement.
>>> @@ -452,10 +1299,12 @@ EndGauge (
>>> /**
>>> Retrieves a previously logged performance measurement.
>>> It can also retrieve the log created by StartGaugeEx and EndGaugeEx of PERFORMANCE_EX_PROTOCOL,
>>> and then eliminate the Identifier.
>>>
>>> + !!! Not support!!!
>>> +
>>> Retrieves the performance log entry from the performance log specified by LogEntryKey.
>>> If it stands for a valid entry, then EFI_SUCCESS is returned and
>>> GaugeDataEntry stores the pointer to that entry.
>>>
>>> @param LogEntryKey The key for the previous performance measurement log entry.
>>> @@ -474,81 +1323,13 @@ EFIAPI
>>> GetGauge (
>>> IN UINTN LogEntryKey,
>>> OUT GAUGE_DATA_ENTRY **GaugeDataEntry
>>> )
>>> {
>>> - EFI_STATUS Status;
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryEx;
>>> -
>>> - GaugeEntryEx = NULL;
>>> -
>>> - Status = GetGaugeEx (LogEntryKey, &GaugeEntryEx);
>>> - if (EFI_ERROR (Status)) {
>>> - return Status;
>>> - }
>>> -
>>> - if (GaugeDataEntry == NULL) {
>>> - return EFI_INVALID_PARAMETER;
>>> - }
>>> -
>>> - *GaugeDataEntry = (GAUGE_DATA_ENTRY *) GaugeEntryEx;
>>> -
>>> - return EFI_SUCCESS;
>>> + return EFI_UNSUPPORTED;
>>> }
>>>
>>> -/**
>>> - Dumps all the PEI performance log to DXE performance gauge array.
>>> -
>>> - This internal function dumps all the PEI performance log to the DXE performance gauge array.
>>> - It retrieves the optional GUID HOB for PEI performance and then saves the performance data
>>> - to DXE performance data structures.
>>> -
>>> -**/
>>> -VOID
>>> -InternalGetPeiPerformance (
>>> - VOID
>>> - )
>>> -{
>>> - EFI_HOB_GUID_TYPE *GuidHob;
>>> - PEI_PERFORMANCE_LOG_HEADER *LogHob;
>>> - PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
>>> - UINT32 *LogIdArray;
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>> - UINT32 Index;
>>> - UINT32 NumberOfEntries;
>>> -
>>> - NumberOfEntries = 0;
>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>> -
>>> - //
>>> - // Dump PEI Log Entries to DXE Guage Data structure.
>>> - //
>>> - GuidHob = GetFirstGuidHob (&gPerformanceProtocolGuid);
>>> - if (GuidHob != NULL) {
>>> - LogHob = GET_GUID_HOB_DATA (GuidHob);
>>> - LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (LogHob + 1);
>>> -
>>> - NumberOfEntries = LogHob->NumberOfEntries;
>>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>>> - GaugeEntryExArray[Index].Handle = LogEntryArray[Index].Handle;
>>> - AsciiStrCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Token);
>>> - AsciiStrCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Module);
>>> - GaugeEntryExArray[Index].StartTimeStamp = LogEntryArray[Index].StartTimeStamp;
>>> - GaugeEntryExArray[Index].EndTimeStamp = LogEntryArray[Index].EndTimeStamp;
>>> - GaugeEntryExArray[Index].Identifier = 0;
>>> - }
>>> -
>>> - GuidHob = GetFirstGuidHob (&gPerformanceExProtocolGuid);
>>> - if (GuidHob != NULL) {
>>> - LogIdArray = GET_GUID_HOB_DATA (GuidHob);
>>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>>> - GaugeEntryExArray[Index].Identifier = LogIdArray[Index];
>>> - }
>>> - }
>>> - }
>>> - mGaugeData->NumberOfEntries = NumberOfEntries;
>>> -}
>>>
>>> /**
>>> The constructor function initializes Performance infrastructure for DXE phase.
>>>
>>> The constructor function publishes Performance and PerformanceEx protocol, allocates memory to log DXE performance
>>> @@ -567,40 +1348,53 @@ DxeCorePerformanceLibConstructor (
>>> IN EFI_HANDLE ImageHandle,
>>> IN EFI_SYSTEM_TABLE *SystemTable
>>> )
>>> {
>>> EFI_STATUS Status;
>>> + EFI_HANDLE Handle;
>>> + EFI_EVENT ReadyToBootEvent;
>>> PERFORMANCE_PROPERTY *PerformanceProperty;
>>>
>>> -
>>> if (!PerformanceMeasurementEnabled ()) {
>>> //
>>> // Do not initialize performance infrastructure if not required.
>>> //
>>> return EFI_SUCCESS;
>>> }
>>> +
>>> + //
>>> + // Dump normal PEI performance records
>>> + //
>>> + InternalGetPeiPerformance (GetHobList());
>>> +
>>> //
>>> - // Install the protocol interfaces.
>>> + // Install the protocol interfaces for DXE performance library instance.
>>> //
>>> + Handle = NULL;
>>> Status = gBS->InstallMultipleProtocolInterfaces (
>>> - &mHandle,
>>> + &Handle,
>>> &gPerformanceProtocolGuid,
>>> &mPerformanceInterface,
>>> &gPerformanceExProtocolGuid,
>>> &mPerformanceExInterface,
>>> NULL
>>> );
>>> ASSERT_EFI_ERROR (Status);
>>>
>>> - mMaxGaugeRecords = INIT_DXE_GAUGE_DATA_ENTRIES + (UINT16) (PcdGet16 (PcdMaxPeiPerformanceLogEntries16) != 0 ?
>>> - PcdGet16 (PcdMaxPeiPerformanceLogEntries16) :
>>> - PcdGet8 (PcdMaxPeiPerformanceLogEntries));
>>> -
>>> - mGaugeData = AllocateZeroPool (sizeof (GAUGE_DATA_HEADER) + (sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords));
>>> - ASSERT (mGaugeData != NULL);
>>> + //
>>> + // Register ReadyToBoot event to report StatusCode data
>>> + //
>>> + Status = gBS->CreateEventEx (
>>> + EVT_NOTIFY_SIGNAL,
>>> + TPL_CALLBACK,
>>> + ReportFpdtRecordBuffer,
>>> + NULL,
>>> + &gEfiEventReadyToBootGuid,
>>> + &ReadyToBootEvent
>>> + );
>>>
>>> - InternalGetPeiPerformance ();
>>> + ASSERT_EFI_ERROR (Status);
>>>
>>> Status = EfiGetSystemConfigurationTable (&gPerformanceProtocolGuid, (VOID **) &PerformanceProperty);
>>> if (EFI_ERROR (Status)) {
>>> //
>>> // Install configuration table for performance property.
>>> @@ -651,19 +1445,19 @@ StartPerformanceMeasurementEx (
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> IN UINT64 TimeStamp,
>>> IN UINT32 Identifier
>>> )
>>> {
>>> - return (RETURN_STATUS) StartGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
>>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
>>> }
>>>
>>> /**
>>> Searches the performance measurement log from the beginning of the log
>>> for the first matching record that contains a zero end time and fills in a valid end time.
>>>
>>> Searches the performance measurement log from the beginning of the log
>>> - for the first record that matches Handle, Token and Module and has an end time value of zero.
>>> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
>>> If the record can not be found then return RETURN_NOT_FOUND.
>>> If the record is found and TimeStamp is not zero,
>>> then the end time in the record is filled in with the value specified by TimeStamp.
>>> If the record is found and TimeStamp is zero, then the end time in the matching record
>>> is filled in with the current time stamp value.
>>> @@ -690,18 +1484,20 @@ EndPerformanceMeasurementEx (
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> IN UINT64 TimeStamp,
>>> IN UINT32 Identifier
>>> )
>>> {
>>> - return (RETURN_STATUS) EndGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
>>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
>>> }
>>>
>>> /**
>>> Attempts to retrieve a performance measurement log entry from the performance measurement log.
>>> It can also retrieve the log created by StartPerformanceMeasurement and EndPerformanceMeasurement,
>>> and then assign the Identifier with 0.
>>>
>>> + !!! Not support!!!
>>> +
>>> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
>>> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
>>> and the key for the second entry in the log is returned. If the performance log is empty,
>>> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
>>> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
>>> @@ -729,63 +1525,29 @@ EndPerformanceMeasurementEx (
>>> being measured.
>>> @param StartTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
>>> was started.
>>> @param EndTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
>>> was ended.
>>> - @param Identifier Pointer to the 32-bit identifier that was recorded.
>>> + @param Identifier Pointer to the 32-bit identifier that was recorded when the measurement
>>> + was ended.
>>>
>>> @return The key for the next performance log entry (in general case).
>>>
>>> **/
>>> UINTN
>>> EFIAPI
>>> GetPerformanceMeasurementEx (
>>> - IN UINTN LogEntryKey,
>>> + IN UINTN LogEntryKey,
>>> OUT CONST VOID **Handle,
>>> OUT CONST CHAR8 **Token,
>>> OUT CONST CHAR8 **Module,
>>> OUT UINT64 *StartTimeStamp,
>>> OUT UINT64 *EndTimeStamp,
>>> OUT UINT32 *Identifier
>>> )
>>> {
>>> - EFI_STATUS Status;
>>> - GAUGE_DATA_ENTRY_EX *GaugeData;
>>> -
>>> - GaugeData = NULL;
>>> -
>>> - ASSERT (Handle != NULL);
>>> - ASSERT (Token != NULL);
>>> - ASSERT (Module != NULL);
>>> - ASSERT (StartTimeStamp != NULL);
>>> - ASSERT (EndTimeStamp != NULL);
>>> - ASSERT (Identifier != NULL);
>>> -
>>> - Status = GetGaugeEx (LogEntryKey++, &GaugeData);
>>> -
>>> - //
>>> - // Make sure that LogEntryKey is a valid log entry key,
>>> - //
>>> - ASSERT (Status != EFI_INVALID_PARAMETER);
>>> -
>>> - if (EFI_ERROR (Status)) {
>>> - //
>>> - // The LogEntryKey is the last entry (equals to the total entry number).
>>> - //
>>> - return 0;
>>> - }
>>> -
>>> - ASSERT (GaugeData != NULL);
>>> -
>>> - *Handle = (VOID *) (UINTN) GaugeData->Handle;
>>> - *Token = GaugeData->Token;
>>> - *Module = GaugeData->Module;
>>> - *StartTimeStamp = GaugeData->StartTimeStamp;
>>> - *EndTimeStamp = GaugeData->EndTimeStamp;
>>> - *Identifier = GaugeData->Identifier;
>>> -
>>> - return LogEntryKey;
>>> + return 0;
>>> }
>>>
>>> /**
>>> Adds a record at the end of the performance measurement log
>>> that records the start time of a performance measurement.
>>> @@ -816,11 +1578,11 @@ StartPerformanceMeasurement (
>>> IN CONST CHAR8 *Token, OPTIONAL
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> IN UINT64 TimeStamp
>>> )
>>> {
>>> - return StartPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
>>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, 0);
>>> }
>>>
>>> /**
>>> Searches the performance measurement log from the beginning of the log
>>> for the first matching record that contains a zero end time and fills in a valid end time.
>>> @@ -852,18 +1614,20 @@ EndPerformanceMeasurement (
>>> IN CONST CHAR8 *Token, OPTIONAL
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> IN UINT64 TimeStamp
>>> )
>>> {
>>> - return EndPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
>>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, 0);
>>> }
>>>
>>> /**
>>> Attempts to retrieve a performance measurement log entry from the performance measurement log.
>>> It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
>>> and then eliminate the Identifier.
>>>
>>> + !!! Not support!!!
>>> +
>>> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
>>> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
>>> and the key for the second entry in the log is returned. If the performance log is empty,
>>> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
>>> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
>>> @@ -905,12 +1669,11 @@ GetPerformanceMeasurement (
>>> OUT CONST CHAR8 **Module,
>>> OUT UINT64 *StartTimeStamp,
>>> OUT UINT64 *EndTimeStamp
>>> )
>>> {
>>> - UINT32 Identifier;
>>> - return GetPerformanceMeasurementEx (LogEntryKey, Handle, Token, Module, StartTimeStamp, EndTimeStamp, &Identifier);
>>> + return 0;
>>> }
>>>
>>> /**
>>> Returns TRUE if the performance measurement macros are enabled.
>>>
>>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>>> index 5b89ce2..71c181f 100644
>>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>>> @@ -7,11 +7,11 @@
>>> # It initializes DXE phase performance logging by publishing the Performance and PerformanceEx Protocol,
>>> # which is consumed by DxePerformanceLib to logging performance data in DXE phase.
>>> # This library is mainly used by DxeCore to start performance logging to ensure that
>>> # Performance and PerformanceEx Protocol are installed at the very beginning of DXE phase.
>>> #
>>> -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>>> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>>> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>>> # This program and the accompanying materials
>>> # are licensed and made available under the terms and conditions of the BSD License
>>> # which accompanies this distribution. The full text of the license may be found at
>>> # http://opensource.org/licenses/bsd-license.php
>>> @@ -48,27 +48,39 @@
>>>
>>>
>>> [LibraryClasses]
>>> MemoryAllocationLib
>>> UefiBootServicesTableLib
>>> + UefiRuntimeServicesTableLib
>>> PcdLib
>>> TimerLib
>>> BaseMemoryLib
>>> BaseLib
>>> HobLib
>>> DebugLib
>>> UefiLib
>>> + ReportStatusCodeLib
>>> + DxeServicesLib
>>> + PeCoffGetEntryPointLib
>>> +
>>> +[Protocols]
>>> + gEfiSmmCommunicationProtocolGuid ## SOMETIMES_CONSUMES
>>>
>>>
>>> [Guids]
>>> ## SOMETIMES_CONSUMES ## HOB
>>> ## PRODUCES ## UNDEFINED # Install protocol
>>> ## PRODUCES ## SystemTable
>>> gPerformanceProtocolGuid
>>> ## SOMETIMES_CONSUMES ## HOB
>>> ## PRODUCES ## UNDEFINED # Install protocol
>>> gPerformanceExProtocolGuid
>>> + gZeroGuid ## SOMETIMES_CONSUMES ## GUID
>>> + gEfiFirmwarePerformanceGuid ## SOMETIMES_PRODUCES ## UNDEFINED # StatusCode Data
>>> + gEdkiiExtendedFirmwarePerformanceGuid ## SOMETIMES_CONSUMES ## HOB # StatusCode Data
>>> + gEfiEventReadyToBootGuid ## CONSUMES ## Event
>>> + gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable
>>>
>>> [Pcd]
>>> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries ## CONSUMES
>>> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16 ## CONSUMES
>>> - gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
>>> + gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
>>> + gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly ## CONSUMES
>>> + gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES
>>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>>> index f1540d8..7e79675 100644
>>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>>> @@ -2,11 +2,11 @@
>>> Master header files for DxeCorePerformanceLib instance.
>>>
>>> This header file holds the prototypes of the Performance and PerformanceEx Protocol published by this
>>> library instance at its constructor.
>>>
>>> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>>> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>>> This program and the accompanying materials
>>> are licensed and made available under the terms and conditions of the BSD License
>>> which accompanies this distribution. The full text of the license may be found at
>>> http://opensource.org/licenses/bsd-license.php
>>>
>>> @@ -20,21 +20,36 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>>>
>>>
>>> #include <PiDxe.h>
>>>
>>> #include <Guid/Performance.h>
>>> +#include <Guid/ExtendedFirmwarePerformance.h>
>>> +#include <Guid/ZeroGuid.h>
>>> +#include <Guid/EventGroup.h>
>>> +#include <Guid/FirmwarePerformance.h>
>>> +#include <Guid/PiSmmCommunicationRegionTable.h>
>>> +
>>> +#include <Protocol/DriverBinding.h>
>>> +#include <Protocol/LoadedImage.h>
>>> +#include <Protocol/ComponentName2.h>
>>> +#include <Protocol/DevicePathToText.h>
>>> +#include <Protocol/SmmCommunication.h>
>>>
>>> #include <Library/PerformanceLib.h>
>>> #include <Library/DebugLib.h>
>>> #include <Library/HobLib.h>
>>> #include <Library/BaseLib.h>
>>> #include <Library/BaseMemoryLib.h>
>>> #include <Library/TimerLib.h>
>>> #include <Library/PcdLib.h>
>>> #include <Library/UefiBootServicesTableLib.h>
>>> +#include <Library/UefiRuntimeServicesTableLib.h>
>>> #include <Library/MemoryAllocationLib.h>
>>> #include <Library/UefiLib.h>
>>> +#include <Library/ReportStatusCodeLib.h>
>>> +#include <Library/DxeServicesLib.h>
>>> +#include <Library/PeCoffGetEntryPointLib.h>
>>>
>>> //
>>> // Interface declarations for PerformanceEx Protocol.
>>> //
>>> /**
>>> --
>>> 1.9.5.msysgit.1
>>>
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-05-22 9:02 ` Ard Biesheuvel
@ 2018-05-22 9:38 ` Zeng, Star
2018-05-22 10:00 ` Laszlo Ersek
2018-05-22 10:00 ` Ard Biesheuvel
0 siblings, 2 replies; 21+ messages in thread
From: Zeng, Star @ 2018-05-22 9:38 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Bi, Dandan, Laszlo Ersek, Andrew Fish, Kinney, Michael D,
Leif Lindholm, edk2-devel@lists.01.org, Gao, Liming, Matt Sealey,
Zeng, Star
It comes to an old question: how to know PEI is 32bit/64bit? But not DXE is 32bit/64bit.
Thanks,
Star
-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
Sent: Tuesday, May 22, 2018 5:03 PM
To: Zeng, Star <star.zeng@intel.com>
Cc: Bi, Dandan <dandan.bi@intel.com>; Laszlo Ersek <lersek@redhat.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
pd On 22 May 2018 at 10:58, Zeng, Star <star.zeng@intel.com> wrote:
> How about the code to try allocating <4G memory, then try allocating any memory if failed to allocate <4G memory?
>
> For example, the code snippet in SmbiosDxe.c.
>
> PhysicalAddress = 0xffffffff;
> Status = gBS->AllocatePages (
> AllocateMaxAddress,
> EfiRuntimeServicesData,
> EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
> &PhysicalAddress
> );
> if (EFI_ERROR (Status)) {
> DEBUG ((EFI_D_ERROR, "SmbiosCreateTable () could not allocate EntryPointStructure < 4GB\n"));
> Status = gBS->AllocatePages (
> AllocateAnyPages,
> EfiRuntimeServicesData,
> EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
> &PhysicalAddress
> );
> if (EFI_ERROR (Status)) {
> return EFI_OUT_OF_RESOURCES;
> }
> }
>
Yes, that should do the trick.
But perhaps we should add something like
AllocatePeiAccessiblePages()
to MemoryAllocationLib, which just uses AllocateMaxAddress or
AllocateAnyPages depending on whether MDE_CPU_X64 is #defined.
--
Ard.
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, May 22, 2018 4:52 PM
> To: Bi, Dandan <dandan.bi@intel.com>; Laszlo Ersek <lersek@redhat.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>; edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
> Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>
> (+ Laszlo, Andrew, Mike)
>
> On 22 May 2018 at 02:33, Bi, Dandan <dandan.bi@intel.com> wrote:
>> Sorry for the delayed response.
>>
>> The allocated performance table ( below 4G ) is to save the boot performance data in normal boot and S3 phase.
>> PEIM FirmwarePerformancePei will get the address of the performance table and update the performance date of S3 phase to the table.
>> The address need to be handled in PEI phase(32bit), that's the main reason why we allocate it below 4G.
>>
>
> The 32-bit PEI + 64-bit DXE combo is specific to X64. You have added
> code to a generic library that ASSERT()s if allocating memory below 4
> GB fails, breaking non-PC architectures.
>
> So please, fix this. Or at least suggest a way around it so that other
> architectures can keep using this library.
>
> This is another consequence of our failure to model the special 32-bit
> PEI/64-bit DXE combination using proper PI interfaces, resulting in
> these kinds of breakages and open coded 4 GB allocations all
> throughout the code. Can we please work on getting this fixed?
>
>
>> -----Original Message-----
>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>> Sent: Wednesday, May 2, 2018 12:27 AM
>> To: Bi, Dandan <dandan.bi@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
>> Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>>
>> On 30 January 2018 at 14:53, Dandan Bi <dandan.bi@intel.com> wrote:
>>> V2:
>>> Update DxecorePerformanceLib to report the boot performance table
>>> address instead of records contents.
>>>
>>> Updated to convert Pref entry to FPDT record in DXE phase and then
>>> allocate boot performance table to save the record and report
>>> the address of boot performance table to FirmwarePerformanceDxe.
>>>
>>> Cc: Liming Gao <liming.gao@intel.com>
>>> Cc: Star Zeng <star.zeng@intel.com>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>>> ---
>>> .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 1389 +++++++++++++++-----
>>> .../DxeCorePerformanceLib.inf | 20 +-
>>> .../DxeCorePerformanceLibInternal.h | 17 +-
>>> 3 files changed, 1108 insertions(+), 318 deletions(-)
>>>
>>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>>> index 7c0e207..c6f8a16 100644
>>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>>> @@ -8,11 +8,11 @@
>>> which are consumed by DxePerformanceLib to logging performance data in DXE phase.
>>>
>>> This library is mainly used by DxeCore to start performance logging to ensure that
>>> Performance Protocol is installed at the very beginning of DXE phase.
>>>
>>> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>>> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>>> This program and the accompanying materials
>>> are licensed and made available under the terms and conditions of the BSD License
>>> which accompanies this distribution. The full text of the license may be found at
>>> http://opensource.org/licenses/bsd-license.php
>>> @@ -23,27 +23,65 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>>> **/
>>>
>>>
>>> #include "DxeCorePerformanceLibInternal.h"
>>>
>>> -
>>> //
>>> -// The data structure to hold global performance data.
>>> +// Data for FPDT performance records.
>>> //
>>> -GAUGE_DATA_HEADER *mGaugeData;
>>> +#define SMM_BOOT_RECORD_COMM_SIZE (OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + sizeof(SMM_BOOT_RECORD_COMMUNICATE))
>>> +#define STRING_SIZE (EDKII_STRING_EVENT_RECORD_NAME_LENGTH * sizeof (CHAR8))
>>> +#define MAX_RECORD_SIZE (sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE)
>>> +#define FIRMWARE_RECORD_BUFFER 0x10000
>>> +#define CACHE_HANDLE_GUID_COUNT 0x1000
>>> +
>>> +BOOT_PERFORMANCE_TABLE *mAcpiBootPerformanceTable = NULL;
>>> +BOOT_PERFORMANCE_TABLE mBootPerformanceTableTemplate = {
>>> + {
>>> + EFI_ACPI_5_0_FPDT_BOOT_PERFORMANCE_TABLE_SIGNATURE,
>>> + sizeof (BOOT_PERFORMANCE_TABLE)
>>> + },
>>> + {
>>> + {
>>> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_TYPE_FIRMWARE_BASIC_BOOT, // Type
>>> + sizeof (EFI_ACPI_5_0_FPDT_FIRMWARE_BASIC_BOOT_RECORD), // Length
>>> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_REVISION_FIRMWARE_BASIC_BOOT // Revision
>>> + },
>>> + 0, // Reserved
>>> + //
>>> + // These values will be updated at runtime.
>>> + //
>>> + 0, // ResetEnd
>>> + 0, // OsLoaderLoadImageStart
>>> + 0, // OsLoaderStartImageStart
>>> + 0, // ExitBootServicesEntry
>>> + 0 // ExitBootServicesExit
>>> + }
>>> +};
>>>
>>> -//
>>> -// The current maximum number of logging entries. If current number of
>>> -// entries exceeds this value, it will re-allocate a larger array and
>>> -// migration the old data to the larger array.
>>> -//
>>> -UINT32 mMaxGaugeRecords;
>>> +typedef struct {
>>> + EFI_HANDLE Handle;
>>> + CHAR8 NameString[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
>>> + EFI_GUID ModuleGuid;
>>> +} HANDLE_GUID_MAP;
>>>
>>> -//
>>> -// The handle to install Performance Protocol instance.
>>> -//
>>> -EFI_HANDLE mHandle = NULL;
>>> +HANDLE_GUID_MAP mCacheHandleGuidTable[CACHE_HANDLE_GUID_COUNT];
>>> +UINTN mCachePairCount = 0;
>>> +
>>> +UINT32 mLoadImageCount = 0;
>>> +UINT32 mPerformanceLength = 0;
>>> +UINT32 mMaxPerformanceLength = 0;
>>> +UINT32 mBootRecordSize = 0;
>>> +UINT32 mBootRecordMaxSize = 0;
>>> +
>>> +BOOLEAN mFpdtBufferIsReported = FALSE;
>>> +BOOLEAN mLackSpaceIsReported = FALSE;
>>> +CHAR8 *mPlatformLanguage = NULL;
>>> +UINT8 *mPerformancePointer = NULL;
>>> +UINT8 *mBootRecordBuffer = NULL;
>>> +
>>> +EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *mDevicePathToText = NULL;
>>>
>>> //
>>> // Interfaces for Performance Protocol.
>>> //
>>> PERFORMANCE_PROTOCOL mPerformanceInterface = {
>>> @@ -61,179 +99,1069 @@ PERFORMANCE_EX_PROTOCOL mPerformanceExInterface = {
>>> GetGaugeEx
>>> };
>>>
>>> PERFORMANCE_PROPERTY mPerformanceProperty;
>>>
>>> -//
>>> -// Gauge record lock to avoid data corruption or even memory overflow
>>> -//
>>> -STATIC EFI_LOCK mPerfRecordLock = EFI_INITIALIZE_LOCK_VARIABLE (TPL_NOTIFY);
>>> +/**
>>> +Check whether the Token is a known one which is uesed by core.
>>> +
>>> +@param Token Pointer to a Null-terminated ASCII string
>>> +
>>> +@retval TRUE Is a known one used by core.
>>> +@retval FALSE Not a known one.
>>> +
>>> +**/
>>> +BOOLEAN
>>> +IsKnownTokens (
>>> + IN CONST CHAR8 *Token
>>> + )
>>> +{
>>> + if (AsciiStrCmp (Token, SEC_TOK) == 0 ||
>>> + AsciiStrCmp (Token, PEI_TOK) == 0 ||
>>> + AsciiStrCmp (Token, DXE_TOK) == 0 ||
>>> + AsciiStrCmp (Token, BDS_TOK) == 0 ||
>>> + AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0 ||
>>> + AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0 ||
>>> + AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0 ||
>>> + AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0 ||
>>> + AsciiStrCmp (Token, START_IMAGE_TOK) == 0 ||
>>> + AsciiStrCmp (Token, PEIM_TOK) == 0) {
>>> + return TRUE;
>>> + } else {
>>> + return FALSE;
>>> + }
>>> +}
>>> +
>>> +/**
>>> +Check whether the ID is a known one which map to the known Token.
>>> +
>>> +@param Identifier 32-bit identifier.
>>> +
>>> +@retval TRUE Is a known one used by core.
>>> +@retval FALSE Not a known one.
>>> +
>>> +**/
>>> +BOOLEAN
>>> +IsKnownID (
>>> + IN UINT32 Identifier
>>> + )
>>> +{
>>> + if (Identifier == MODULE_START_ID ||
>>> + Identifier == MODULE_END_ID ||
>>> + Identifier == MODULE_LOADIMAGE_START_ID ||
>>> + Identifier == MODULE_LOADIMAGE_END_ID ||
>>> + Identifier == MODULE_DB_START_ID ||
>>> + Identifier == MODULE_DB_END_ID ||
>>> + Identifier == MODULE_DB_SUPPORT_START_ID ||
>>> + Identifier == MODULE_DB_SUPPORT_END_ID ||
>>> + Identifier == MODULE_DB_STOP_START_ID ||
>>> + Identifier == MODULE_DB_STOP_END_ID) {
>>> + return TRUE;
>>> + } else {
>>> + return FALSE;
>>> + }
>>> +}
>>>
>>> /**
>>> - Searches in the gauge array with keyword Handle, Token, Module and Identifier.
>>> + Allocate EfiReservedMemoryType below 4G memory address.
>>> +
>>> + This function allocates EfiReservedMemoryType below 4G memory address.
>>> +
>>> + @param[in] Size Size of memory to allocate.
>>> +
>>> + @return Allocated address for output.
>>> +
>>> +**/
>>> +VOID *
>>> +FpdtAllocateReservedMemoryBelow4G (
>>> + IN UINTN Size
>>> + )
>>> +{
>>> + UINTN Pages;
>>> + EFI_PHYSICAL_ADDRESS Address;
>>> + EFI_STATUS Status;
>>> + VOID *Buffer;
>>> +
>>> + Buffer = NULL;
>>> + Pages = EFI_SIZE_TO_PAGES (Size);
>>> + Address = 0xffffffff;
>>> +
>>> + Status = gBS->AllocatePages (
>>> + AllocateMaxAddress,
>>> + EfiReservedMemoryType,
>>> + Pages,
>>> + &Address
>>> + );
>>> + ASSERT_EFI_ERROR (Status);
>>
>> This code is breaking DEBUG builds on ARM systems that have no memory
>> below 4 GB.
>>
>>> +
>>> + if (!EFI_ERROR (Status)) {
>>> + Buffer = (VOID *) (UINTN) Address;
>>> + ZeroMem (Buffer, Size);
>>> + }
>>> +
>>> + return Buffer;
>>> +}
>>> +
>>> +/**
>>> + Allocate buffer for Boot Performance table.
>>> +
>>> + @return Status code.
>>> +
>>> +**/
>>> +EFI_STATUS
>>> +AllocateBootPerformanceTable (
>>> + )
>>> +{
>>> + EFI_STATUS Status;
>>> + UINTN Size;
>>> + UINT8 *SmmBootRecordCommBuffer;
>>> + EFI_SMM_COMMUNICATE_HEADER *SmmCommBufferHeader;
>>> + SMM_BOOT_RECORD_COMMUNICATE *SmmCommData;
>>> + UINTN CommSize;
>>> + UINTN BootPerformanceDataSize;
>>> + UINT8 *BootPerformanceData;
>>> + EFI_SMM_COMMUNICATION_PROTOCOL *Communication;
>>> + FIRMWARE_PERFORMANCE_VARIABLE PerformanceVariable;
>>> + EDKII_PI_SMM_COMMUNICATION_REGION_TABLE *SmmCommRegionTable;
>>> + EFI_MEMORY_DESCRIPTOR *SmmCommMemRegion;
>>> + UINTN Index;
>>> + VOID *SmmBootRecordData;
>>> + UINTN SmmBootRecordDataSize;
>>> + UINTN ReservedMemSize;
>>> +
>>> + //
>>> + // Collect boot records from SMM drivers.
>>> + //
>>> + SmmBootRecordCommBuffer = NULL;
>>> + SmmCommData = NULL;
>>> + SmmBootRecordData = NULL;
>>> + SmmBootRecordDataSize = 0;
>>> + ReservedMemSize = 0;
>>> + Status = gBS->LocateProtocol (&gEfiSmmCommunicationProtocolGuid, NULL, (VOID **) &Communication);
>>> + if (!EFI_ERROR (Status)) {
>>> + //
>>> + // Initialize communicate buffer
>>> + // Get the prepared Reserved Memory Range
>>> + //
>>> + Status = EfiGetSystemConfigurationTable (
>>> + &gEdkiiPiSmmCommunicationRegionTableGuid,
>>> + (VOID **) &SmmCommRegionTable
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + ASSERT (SmmCommRegionTable != NULL);
>>> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) (SmmCommRegionTable + 1);
>>> + for (Index = 0; Index < SmmCommRegionTable->NumberOfEntries; Index ++) {
>>> + if (SmmCommMemRegion->Type == EfiConventionalMemory) {
>>> + break;
>>> + }
>>> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) ((UINT8 *) SmmCommMemRegion + SmmCommRegionTable->DescriptorSize);
>>> + }
>>> + ASSERT (Index < SmmCommRegionTable->NumberOfEntries);
>>> + ASSERT (SmmCommMemRegion->PhysicalStart > 0);
>>> + ASSERT (SmmCommMemRegion->NumberOfPages > 0);
>>> + ReservedMemSize = (UINTN) SmmCommMemRegion->NumberOfPages * EFI_PAGE_SIZE;
>>> +
>>> + //
>>> + // Check enough reserved memory space
>>> + //
>>> + if (ReservedMemSize > SMM_BOOT_RECORD_COMM_SIZE) {
>>> + SmmBootRecordCommBuffer = (VOID *) (UINTN) SmmCommMemRegion->PhysicalStart;
>>> + SmmCommBufferHeader = (EFI_SMM_COMMUNICATE_HEADER*)SmmBootRecordCommBuffer;
>>> + SmmCommData = (SMM_BOOT_RECORD_COMMUNICATE*)SmmCommBufferHeader->Data;
>>> + ZeroMem((UINT8*)SmmCommData, sizeof(SMM_BOOT_RECORD_COMMUNICATE));
>>> +
>>> + CopyGuid (&SmmCommBufferHeader->HeaderGuid, &gEfiFirmwarePerformanceGuid);
>>> + SmmCommBufferHeader->MessageLength = sizeof(SMM_BOOT_RECORD_COMMUNICATE);
>>> + CommSize = SMM_BOOT_RECORD_COMM_SIZE;
>>> +
>>> + //
>>> + // Get the size of boot records.
>>> + //
>>> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_SIZE;
>>> + SmmCommData->BootRecordData = NULL;
>>> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
>>> + ASSERT_EFI_ERROR (Status);
>>> +
>>> + if (!EFI_ERROR (SmmCommData->ReturnStatus) && SmmCommData->BootRecordSize != 0) {
>>> + //
>>> + // Get all boot records
>>> + //
>>> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
>>> + SmmBootRecordDataSize = SmmCommData->BootRecordSize;
>>> + SmmBootRecordData = AllocateZeroPool(SmmBootRecordDataSize);
>>> + ASSERT (SmmBootRecordData != NULL);
>>> + SmmCommData->BootRecordOffset = 0;
>>> + SmmCommData->BootRecordData = (VOID *) ((UINTN) SmmCommMemRegion->PhysicalStart + SMM_BOOT_RECORD_COMM_SIZE);
>>> + SmmCommData->BootRecordSize = ReservedMemSize - SMM_BOOT_RECORD_COMM_SIZE;
>>> + while (SmmCommData->BootRecordOffset < SmmBootRecordDataSize) {
>>> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
>>> + ASSERT_EFI_ERROR (Status);
>>> + ASSERT_EFI_ERROR(SmmCommData->ReturnStatus);
>>> + if (SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize > SmmBootRecordDataSize) {
>>> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmBootRecordDataSize - SmmCommData->BootRecordOffset);
>>> + } else {
>>> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmCommData->BootRecordSize);
>>> + }
>>> + SmmCommData->BootRecordOffset = SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize;
>>> + }
>>> + }
>>> + }
>>> + }
>>> + }
>>> +
>>> + //
>>> + // Prepare memory for Boot Performance table.
>>> + // Boot Performance table includes BasicBoot record, and one or more appended Boot Records.
>>> + //
>>> + BootPerformanceDataSize = sizeof (BOOT_PERFORMANCE_TABLE) + mPerformanceLength + PcdGet32 (PcdExtFpdtBootRecordPadSize);
>>> + if (SmmCommData != NULL) {
>>> + BootPerformanceDataSize += SmmBootRecordDataSize;
>>> + }
>>> +
>>> + //
>>> + // Try to allocate the same runtime buffer as last time boot.
>>> + //
>>> + ZeroMem (&PerformanceVariable, sizeof (PerformanceVariable));
>>> + Size = sizeof (PerformanceVariable);
>>> + Status = gRT->GetVariable (
>>> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
>>> + &gEfiFirmwarePerformanceGuid,
>>> + NULL,
>>> + &Size,
>>> + &PerformanceVariable
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + Status = gBS->AllocatePages (
>>> + AllocateAddress,
>>> + EfiReservedMemoryType,
>>> + EFI_SIZE_TO_PAGES (BootPerformanceDataSize),
>>> + &PerformanceVariable.BootPerformanceTablePointer
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) (UINTN) PerformanceVariable.BootPerformanceTablePointer;
>>> + }
>>> + }
>>> +
>>> + if (mAcpiBootPerformanceTable == NULL) {
>>> + //
>>> + // Fail to allocate at specified address, continue to allocate at any address.
>>> + //
>>> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) FpdtAllocateReservedMemoryBelow4G (BootPerformanceDataSize);
>>
>> Why does this allocation need to live below 4 GB?
>>
>> If there is no good reason, can we please get rid of this?
>> If there is a good reason, can we please document it in the code?
>>
>>> + }
>>> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: ACPI Boot Performance Table address = 0x%x\n", mAcpiBootPerformanceTable));
>>> +
>>> + if (mAcpiBootPerformanceTable == NULL) {
>>> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
>>> + FreePool (SmmBootRecordData);
>>> + }
>>> + return EFI_OUT_OF_RESOURCES;
>>> + }
>>> +
>>> + //
>>> + // Prepare Boot Performance Table.
>>> + //
>>> + BootPerformanceData = (UINT8 *) mAcpiBootPerformanceTable;
>>> + //
>>> + // Fill Basic Boot record to Boot Performance Table.
>>> + //
>>> + CopyMem (mAcpiBootPerformanceTable, &mBootPerformanceTableTemplate, sizeof (mBootPerformanceTableTemplate));
>>> + BootPerformanceData = BootPerformanceData + mAcpiBootPerformanceTable->Header.Length;
>>> + //
>>> + // Fill Boot records from boot drivers.
>>> + //
>>> + if (mPerformancePointer != NULL) {
>>> + CopyMem (BootPerformanceData, mPerformancePointer, mPerformanceLength);
>>> + mAcpiBootPerformanceTable->Header.Length += mPerformanceLength;
>>> + BootPerformanceData = BootPerformanceData + mPerformanceLength;
>>> + }
>>> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
>>> + //
>>> + // Fill Boot records from SMM drivers.
>>> + //
>>> + CopyMem (BootPerformanceData, SmmBootRecordData, SmmBootRecordDataSize);
>>> + FreePool (SmmBootRecordData);
>>> + mAcpiBootPerformanceTable->Header.Length = (UINT32) (mAcpiBootPerformanceTable->Header.Length + SmmBootRecordDataSize);
>>> + BootPerformanceData = BootPerformanceData + SmmBootRecordDataSize;
>>> + }
>>> +
>>> + //
>>> + // Save Boot Performance Table address to Variable for use in S4 resume.
>>> + //
>>> + PerformanceVariable.BootPerformanceTablePointer = (EFI_PHYSICAL_ADDRESS) (UINTN) mAcpiBootPerformanceTable;
>>> +
>>> + //
>>> + // Save Runtime Performance Table pointers to Variable.
>>> + // Don't check SetVariable return status. It doesn't impact FPDT table generation.
>>> + //
>>> + gRT->SetVariable (
>>> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
>>> + &gEfiFirmwarePerformanceGuid,
>>> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
>>> + sizeof (PerformanceVariable),
>>> + &PerformanceVariable
>>> + );
>>> +
>>> + mBootRecordBuffer = (UINT8 *) mAcpiBootPerformanceTable;
>>> + mBootRecordSize = mAcpiBootPerformanceTable->Header.Length;
>>> + mBootRecordMaxSize = mBootRecordSize + PcdGet32 (PcdExtFpdtBootRecordPadSize);
>>> +
>>> + return EFI_SUCCESS;
>>> +}
>>> +
>>> +/**
>>> + Get a human readable module name and module guid for the given image handle.
>>> + If module name can't be found, "" string will return.
>>> + If module guid can't be found, Zero Guid will return.
>>> +
>>> + @param Handle Image handle or Controller handle.
>>> + @param NameString The ascii string will be filled into it. If not found, null string will return.
>>> + @param BufferSize Size of the input NameString buffer.
>>> + @param ModuleGuid Point to the guid buffer to store the got module guid value.
>>> +
>>> + @retval EFI_SUCCESS Successfully get module name and guid.
>>> + @retval EFI_INVALID_PARAMETER The input parameter NameString is NULL.
>>> + @retval other value Module Name can't be got.
>>> +**/
>>> +EFI_STATUS
>>> +GetModuleInfoFromHandle (
>>> + IN EFI_HANDLE Handle,
>>> + OUT CHAR8 *NameString,
>>> + IN UINTN BufferSize,
>>> + OUT EFI_GUID *ModuleGuid OPTIONAL
>>> + )
>>> +{
>>> + EFI_STATUS Status;
>>> + EFI_LOADED_IMAGE_PROTOCOL *LoadedImage;
>>> + EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
>>> + CHAR8 *PdbFileName;
>>> + EFI_GUID *TempGuid;
>>> + UINTN StartIndex;
>>> + UINTN Index;
>>> + INTN Count;
>>> + BOOLEAN ModuleGuidIsGet;
>>> + UINTN StringSize;
>>> + CHAR16 *StringPtr;
>>> + EFI_COMPONENT_NAME2_PROTOCOL *ComponentName2;
>>> + MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *FvFilePath;
>>> +
>>> + if (NameString == NULL || BufferSize == 0) {
>>> + return EFI_INVALID_PARAMETER;
>>> + }
>>> + //
>>> + // Try to get the ModuleGuid and name string form the caached array.
>>> + //
>>> + if (mCachePairCount > 0) {
>>> + for (Count = mCachePairCount -1; Count >= 0; Count--) {
>>> + if (Handle == mCacheHandleGuidTable[Count].Handle) {
>>> + CopyGuid (ModuleGuid, &mCacheHandleGuidTable[Count].ModuleGuid);
>>> + AsciiStrCpyS (NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, mCacheHandleGuidTable[Count].NameString);
>>> + return EFI_SUCCESS;
>>> + }
>>> + }
>>> + }
>>> +
>>> + Status = EFI_INVALID_PARAMETER;
>>> + LoadedImage = NULL;
>>> + ModuleGuidIsGet = FALSE;
>>> +
>>> + //
>>> + // Initialize GUID as zero value.
>>> + //
>>> + TempGuid = &gZeroGuid;
>>> + //
>>> + // Initialize it as "" string.
>>> + //
>>> + NameString[0] = 0;
>>> +
>>> + if (Handle != NULL) {
>>> + //
>>> + // Try Handle as ImageHandle.
>>> + //
>>> + Status = gBS->HandleProtocol (
>>> + Handle,
>>> + &gEfiLoadedImageProtocolGuid,
>>> + (VOID**) &LoadedImage
>>> + );
>>> +
>>> + if (EFI_ERROR (Status)) {
>>> + //
>>> + // Try Handle as Controller Handle
>>> + //
>>> + Status = gBS->OpenProtocol (
>>> + Handle,
>>> + &gEfiDriverBindingProtocolGuid,
>>> + (VOID **) &DriverBinding,
>>> + NULL,
>>> + NULL,
>>> + EFI_OPEN_PROTOCOL_GET_PROTOCOL
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + //
>>> + // Get Image protocol from ImageHandle
>>> + //
>>> + Status = gBS->HandleProtocol (
>>> + DriverBinding->ImageHandle,
>>> + &gEfiLoadedImageProtocolGuid,
>>> + (VOID**) &LoadedImage
>>> + );
>>> + }
>>> + }
>>> + }
>>> +
>>> + if (!EFI_ERROR (Status) && LoadedImage != NULL) {
>>> + //
>>> + // Get Module Guid from DevicePath.
>>> + //
>>> + if (LoadedImage->FilePath != NULL &&
>>> + LoadedImage->FilePath->Type == MEDIA_DEVICE_PATH &&
>>> + LoadedImage->FilePath->SubType == MEDIA_PIWG_FW_FILE_DP
>>> + ) {
>>> + //
>>> + // Determine GUID associated with module logging performance
>>> + //
>>> + ModuleGuidIsGet = TRUE;
>>> + FvFilePath = (MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *) LoadedImage->FilePath;
>>> + TempGuid = &FvFilePath->FvFileName;
>>> + }
>>> +
>>> + //
>>> + // Method 1 Get Module Name from PDB string.
>>> + //
>>> + PdbFileName = PeCoffLoaderGetPdbPointer (LoadedImage->ImageBase);
>>> + if (PdbFileName != NULL && BufferSize > 0) {
>>> + StartIndex = 0;
>>> + for (Index = 0; PdbFileName[Index] != 0; Index++) {
>>> + if ((PdbFileName[Index] == '\\') || (PdbFileName[Index] == '/')) {
>>> + StartIndex = Index + 1;
>>> + }
>>> + }
>>> + //
>>> + // Copy the PDB file name to our temporary string.
>>> + // If the length is bigger than BufferSize, trim the redudant characters to avoid overflow in array boundary.
>>> + //
>>> + for (Index = 0; Index < BufferSize - 1; Index++) {
>>> + NameString[Index] = PdbFileName[Index + StartIndex];
>>> + if (NameString[Index] == 0 || NameString[Index] == '.') {
>>> + NameString[Index] = 0;
>>> + break;
>>> + }
>>> + }
>>>
>>> - This internal function searches for the gauge entry in the gauge array.
>>> - If there is an entry that exactly matches the given keywords
>>> - and its end time stamp is zero, then the index of that gauge entry is returned;
>>> - otherwise, the the number of gauge entries in the array is returned.
>>> + if (Index == BufferSize - 1) {
>>> + NameString[Index] = 0;
>>> + }
>>> + //
>>> + // Module Name is got.
>>> + //
>>> + goto Done;
>>> + }
>>> + }
>>>
>>> + //
>>> + // Method 2: Get the name string from ComponentName2 protocol
>>> + //
>>> + Status = gBS->HandleProtocol (
>>> + Handle,
>>> + &gEfiComponentName2ProtocolGuid,
>>> + (VOID **) &ComponentName2
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + //
>>> + // Get the current platform language setting
>>> + //
>>> + if (mPlatformLanguage == NULL) {
>>> + GetEfiGlobalVariable2 (L"PlatformLang", (VOID **) &mPlatformLanguage, NULL);
>>> + }
>>> + if (mPlatformLanguage != NULL) {
>>> + Status = ComponentName2->GetDriverName (
>>> + ComponentName2,
>>> + mPlatformLanguage != NULL ? mPlatformLanguage : "en-US",
>>> + &StringPtr
>>> + );
>>> + if (!EFI_ERROR (Status)) {
>>> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
>>> + NameString[Index] = (CHAR8) StringPtr[Index];
>>> + }
>>> + NameString[Index] = 0;
>>> + //
>>> + // Module Name is got.
>>> + //
>>> + goto Done;
>>> + }
>>> + }
>>> + }
>>> +
>>> + if (ModuleGuidIsGet) {
>>> + //
>>> + // Method 3 Try to get the image's FFS UI section by image GUID
>>> + //
>>> + StringPtr = NULL;
>>> + StringSize = 0;
>>> + Status = GetSectionFromAnyFv (
>>> + TempGuid,
>>> + EFI_SECTION_USER_INTERFACE,
>>> + 0,
>>> + (VOID **) &StringPtr,
>>> + &StringSize
>>> + );
>>> +
>>> + if (!EFI_ERROR (Status)) {
>>> + //
>>> + // Method 3. Get the name string from FFS UI section
>>> + //
>>> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
>>> + NameString[Index] = (CHAR8) StringPtr[Index];
>>> + }
>>> + NameString[Index] = 0;
>>> + FreePool (StringPtr);
>>> + }
>>> + }
>>> +
>>> +Done:
>>> + //
>>> + // Copy Module Guid
>>> + //
>>> + if (ModuleGuid != NULL) {
>>> + CopyGuid (ModuleGuid, TempGuid);
>>> + if (IsZeroGuid(TempGuid) && (Handle != NULL) && !ModuleGuidIsGet) {
>>> + // Handle is GUID
>>> + CopyGuid (ModuleGuid, (EFI_GUID *) Handle);
>>> + }
>>> + }
>>> +
>>> + //
>>> + // Cache the Handle and Guid pairs.
>>> + //
>>> + if (mCachePairCount < CACHE_HANDLE_GUID_COUNT) {
>>> + mCacheHandleGuidTable[mCachePairCount].Handle = Handle;
>>> + CopyGuid (&mCacheHandleGuidTable[mCachePairCount].ModuleGuid, ModuleGuid);
>>> + AsciiStrCpyS (mCacheHandleGuidTable[mCachePairCount].NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, NameString);
>>> + mCachePairCount ++;
>>> + }
>>> +
>>> + return Status;
>>> +}
>>> +
>>> +/**
>>> + Get the FPDT record info.
>>> +
>>> + @param IsStart TRUE if the performance log is start log.
>>> @param Handle Pointer to environment specific context used
>>> to identify the component being measured.
>>> @param Token Pointer to a Null-terminated ASCII string
>>> that identifies the component being measured.
>>> @param Module Pointer to a Null-terminated ASCII string
>>> that identifies the module being measured.
>>> - @param Identifier 32-bit identifier.
>>> + @param RecordInfo On return, pointer to the info of the record.
>>> + @param UseModuleName Only useful for DYNAMIC_STRING_EVENT_TYPE, indicate that whether need use
>>> + Module name to fill the string field in the DYNAMIC_STRING_EVENT_RECORD.
>>>
>>> - @retval The index of gauge entry in the array.
>>> + @retval EFI_SUCCESS Get record info successfully.
>>> + @retval EFI_UNSUPPORTED No matched FPDT record.
>>>
>>> **/
>>> -UINT32
>>> -InternalSearchForGaugeEntry (
>>> - IN CONST VOID *Handle, OPTIONAL
>>> - IN CONST CHAR8 *Token, OPTIONAL
>>> - IN CONST CHAR8 *Module, OPTIONAL
>>> - IN UINT32 Identifier
>>> +EFI_STATUS
>>> +GetFpdtRecordInfo (
>>> + IN BOOLEAN IsStart,
>>> + IN CONST VOID *Handle,
>>> + IN CONST CHAR8 *Token,
>>> + IN CONST CHAR8 *Module,
>>> + OUT BASIC_RECORD_INFO *RecordInfo,
>>> + IN OUT BOOLEAN *UseModuleName
>>> )
>>> {
>>> - UINT32 Index;
>>> - UINT32 Index2;
>>> - UINT32 NumberOfEntries;
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>> + UINT16 RecordType;
>>> + UINTN StringSize;
>>>
>>> - if (Token == NULL) {
>>> - Token = "";
>>> - }
>>> - if (Module == NULL) {
>>> - Module = "";
>>> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
>>> +
>>> + //
>>> + // Token to Type and Id.
>>> + //
>>> + if (Token != NULL) {
>>> + if (AsciiStrCmp (Token, START_IMAGE_TOK) == 0) { // "StartImage:"
>>> + *UseModuleName = TRUE;
>>> + RecordType = GUID_EVENT_TYPE;
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = MODULE_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = MODULE_END_ID;
>>> + }
>>> + } else if (AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) { // "LoadImage:"
>>> + *UseModuleName = TRUE;
>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = MODULE_LOADIMAGE_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = MODULE_LOADIMAGE_END_ID;
>>> + }
>>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0) { // "DB:Start:"
>>> + *UseModuleName = TRUE;
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = MODULE_DB_START_ID;
>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>> + } else {
>>> + RecordInfo->ProgressID = MODULE_DB_END_ID;
>>> + RecordType = GUID_QWORD_STRING_EVENT_TYPE;
>>> + }
>>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0) { // "DB:Support:"
>>> + *UseModuleName = TRUE;
>>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>>> + return RETURN_UNSUPPORTED;
>>> + }
>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_END_ID;
>>> + }
>>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0) { // "DB:Stop:"
>>> + *UseModuleName = TRUE;
>>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>>> + return RETURN_UNSUPPORTED;
>>> + }
>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = MODULE_DB_STOP_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = MODULE_DB_STOP_END_ID;
>>> + }
>>> + } else if (AsciiStrCmp (Token, PEI_TOK) == 0 || // "PEI"
>>> + AsciiStrCmp (Token, DXE_TOK) == 0 || // "DXE"
>>> + AsciiStrCmp (Token, BDS_TOK) == 0) { // "BDS"
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = PERF_CROSSMODULE_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = PERF_CROSSMODULE_END_ID;
>>> + }
>>> + } else { // Pref used in Modules.
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
>>> + }
>>> + }
>>> + } else if (Handle!= NULL || Module != NULL) { // Pref used in Modules.
>>> + if (IsStart) {
>>> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
>>> + } else {
>>> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
>>> + }
>>> + } else {
>>> + return EFI_UNSUPPORTED;
>>> }
>>>
>>> - NumberOfEntries = mGaugeData->NumberOfEntries;
>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>> + //
>>> + // Get Record size baesed on the record type.
>>> + // When PcdEdkiiFpdtStringRecordEnableOnly is TRUE, all records are with type of DYNAMIC_STRING_EVENT_TYPE.
>>> + //
>>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>>> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
>>> + RecordInfo->RecordSize = sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE;
>>> + } else {
>>> + switch (RecordType) {
>>> + case GUID_EVENT_TYPE:
>>> + RecordInfo->RecordSize = sizeof (GUID_EVENT_RECORD);
>>> + break;
>>>
>>> - Index2 = 0;
>>> + case DYNAMIC_STRING_EVENT_TYPE:
>>> + if (*UseModuleName) {
>>> + StringSize = STRING_SIZE;
>>> + } else if (Token != NULL) {
>>> + StringSize = AsciiStrSize (Token);
>>> + } else if (Module != NULL) {
>>> + StringSize = AsciiStrSize (Module);
>>> + } else {
>>> + StringSize = STRING_SIZE;
>>> + }
>>> + if (StringSize > STRING_SIZE) {
>>> + StringSize = STRING_SIZE;
>>> + }
>>> + RecordInfo->RecordSize = (UINT8)(sizeof (DYNAMIC_STRING_EVENT_RECORD) + StringSize);
>>> + break;
>>>
>>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>>> - Index2 = NumberOfEntries - 1 - Index;
>>> - if (GaugeEntryExArray[Index2].EndTimeStamp == 0 &&
>>> - (GaugeEntryExArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&
>>> - AsciiStrnCmp (GaugeEntryExArray[Index2].Token, Token, DXE_PERFORMANCE_STRING_LENGTH) == 0 &&
>>> - AsciiStrnCmp (GaugeEntryExArray[Index2].Module, Module, DXE_PERFORMANCE_STRING_LENGTH) == 0) {
>>> - Index = Index2;
>>> + case GUID_QWORD_EVENT_TYPE:
>>> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_EVENT_RECORD);
>>> break;
>>> +
>>> + case GUID_QWORD_STRING_EVENT_TYPE:
>>> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_STRING_EVENT_RECORD);
>>> + break;
>>> +
>>> + default:
>>> + //
>>> + // Record is unsupported yet, return EFI_UNSUPPORTED
>>> + //
>>> + return EFI_UNSUPPORTED;
>>> }
>>> }
>>>
>>> - return Index;
>>> + RecordInfo->Type = RecordType;
>>> + return EFI_SUCCESS;
>>> }
>>>
>>> /**
>>> - Adds a record at the end of the performance measurement log
>>> - that records the start time of a performance measurement.
>>> -
>>> - Adds a record to the end of the performance measurement log
>>> - that contains the Handle, Token, Module and Identifier.
>>> - The end time of the new record must be set to zero.
>>> - If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
>>> - If TimeStamp is zero, the start time in the record is filled in with the value
>>> - read from the current time stamp.
>>> + Add performance log to FPDT boot record table.
>>>
>>> + @param IsStart TRUE if the performance log is start log.
>>> @param Handle Pointer to environment specific context used
>>> to identify the component being measured.
>>> @param Token Pointer to a Null-terminated ASCII string
>>> that identifies the component being measured.
>>> @param Module Pointer to a Null-terminated ASCII string
>>> that identifies the module being measured.
>>> - @param TimeStamp 64-bit time stamp.
>>> + @param Ticker 64-bit time stamp.
>>> @param Identifier 32-bit identifier. If the value is 0, the created record
>>> is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>>>
>>> - @retval EFI_SUCCESS The data was read correctly from the device.
>>> + @retval EFI_SUCCESS Add FPDT boot record.
>>> @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>>> + @retval EFI_UNSUPPORTED No matched FPDT record.
>>>
>>> **/
>>> EFI_STATUS
>>> -EFIAPI
>>> -StartGaugeEx (
>>> +InsertFpdtMeasurement (
>>> + IN BOOLEAN IsStart,
>>> IN CONST VOID *Handle, OPTIONAL
>>> IN CONST CHAR8 *Token, OPTIONAL
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> - IN UINT64 TimeStamp,
>>> + IN UINT64 Ticker,
>>> IN UINT32 Identifier
>>> )
>>> {
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>> - UINTN GaugeDataSize;
>>> - GAUGE_DATA_HEADER *NewGaugeData;
>>> - UINTN OldGaugeDataSize;
>>> - GAUGE_DATA_HEADER *OldGaugeData;
>>> - UINT32 Index;
>>> - EFI_STATUS Status;
>>> + EFI_GUID ModuleGuid;
>>> + CHAR8 ModuleName[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
>>> + UINT8 FpdtRecord[MAX_RECORD_SIZE];
>>> + EFI_STATUS Status;
>>> + FPDT_RECORD_PTR FpdtRecordPtr;
>>> + BASIC_RECORD_INFO RecordInfo;
>>> + UINT64 TimeStamp;
>>> + UINTN DestMax;
>>> + UINTN StrLength;
>>> + CONST CHAR8 *StringPtr;
>>> + BOOLEAN UseModuleName;
>>> +
>>> + StringPtr = NULL;
>>> + UseModuleName = FALSE;
>>> + ZeroMem (ModuleName, sizeof (ModuleName));
>>> + ZeroMem (FpdtRecord, sizeof (FpdtRecord));
>>>
>>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>>> + //
>>> + // Get record info (type, size, ProgressID and Module Guid).
>>> + //
>>> + Status = GetFpdtRecordInfo (IsStart, Handle, Token, Module, &RecordInfo, &UseModuleName);
>>> if (EFI_ERROR (Status)) {
>>> return Status;
>>> }
>>>
>>> - Index = mGaugeData->NumberOfEntries;
>>> - if (Index >= mMaxGaugeRecords) {
>>> + //
>>> + // If PERF_START()/PERF_END() have specified the ProgressID,it has high priority.
>>> + // !!! Note: If the Pref is not the known Token used in the core but have same
>>> + // ID with the core Token, this case will not be supported.
>>> + // And in currtnt usage mode, for the unkown ID, there is a general rule:
>>> + // If it is start pref: the lower 4 bits of the ID should be 0.
>>> + // If it is end pref: the lower 4 bits of the ID should not be 0.
>>> + // If input ID doesn't follow the rule, we will adjust it.
>>> + //
>>> + if ((Identifier != 0) && (IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
>>> + return EFI_UNSUPPORTED;
>>> + } else if ((Identifier != 0) && (!IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
>>> + if (IsStart && ((Identifier & 0x000F) != 0)) {
>>> + Identifier &= 0xFFF0;
>>> + } else if ((!IsStart) && ((Identifier & 0x000F) == 0)) {
>>> + Identifier += 1;
>>> + }
>>> + RecordInfo.ProgressID = (UINT16)Identifier;
>>> + }
>>> +
>>> + if (mFpdtBufferIsReported) {
>>> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)FpdtRecord;
>>> + } else {
>>> + //
>>> + // Check if pre-allocated buffer is full
>>> //
>>> - // Try to enlarge the scale of gauge array.
>>> + if (mPerformanceLength + RecordInfo.RecordSize > mMaxPerformanceLength) {
>>> + mPerformancePointer = ReallocatePool (
>>> + mPerformanceLength,
>>> + mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER,
>>> + mPerformancePointer
>>> + );
>>> +
>>> + if (mPerformancePointer == NULL) {
>>> + return EFI_OUT_OF_RESOURCES;
>>> + }
>>> + mMaxPerformanceLength = mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER;
>>> + }
>>> //
>>> - OldGaugeData = mGaugeData;
>>> - OldGaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords;
>>> + // Covert buffer to FPDT Ptr Union type.
>>> + //
>>> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(mPerformancePointer + mPerformanceLength);
>>> + }
>>> + FpdtRecordPtr.RecordHeader->Length = 0;
>>>
>>> - GaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords * 2;
>>> + //
>>> + // Get the TimeStamp.
>>> + //
>>> + if (Ticker == 0) {
>>> + Ticker = GetPerformanceCounter ();
>>> + TimeStamp = GetTimeInNanoSecond (Ticker);
>>> + } else if (Ticker == 1) {
>>> + TimeStamp = 0;
>>> + } else {
>>> + TimeStamp = GetTimeInNanoSecond (Ticker);
>>> + }
>>>
>>> - NewGaugeData = AllocateZeroPool (GaugeDataSize);
>>> - if (NewGaugeData == NULL) {
>>> - EfiReleaseLock (&mPerfRecordLock);
>>> - return EFI_OUT_OF_RESOURCES;
>>> + //
>>> + // Get the ModuleName and ModuleGuid form the handle.
>>> + //
>>> + GetModuleInfoFromHandle ((EFI_HANDLE *)Handle, ModuleName, sizeof (ModuleName), &ModuleGuid);
>>> +
>>> + //
>>> + // Fill in the record information.
>>> + //
>>> + switch (RecordInfo.Type) {
>>> + case GUID_EVENT_TYPE:
>>> + FpdtRecordPtr.GuidEvent->Header.Type = GUID_EVENT_TYPE;
>>> + FpdtRecordPtr.GuidEvent->Header.Length = RecordInfo.RecordSize;
>>> + FpdtRecordPtr.GuidEvent->Header.Revision = RECORD_REVISION_1;
>>> + FpdtRecordPtr.GuidEvent->ProgressID = RecordInfo.ProgressID;
>>> + FpdtRecordPtr.GuidEvent->Timestamp = TimeStamp;
>>> + CopyMem (&FpdtRecordPtr.GuidEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidEvent->Guid));
>>> + break;
>>> +
>>> + case DYNAMIC_STRING_EVENT_TYPE:
>>> + FpdtRecordPtr.DynamicStringEvent->Header.Type = DYNAMIC_STRING_EVENT_TYPE;
>>> + FpdtRecordPtr.DynamicStringEvent->Header.Length = RecordInfo.RecordSize;
>>> + FpdtRecordPtr.DynamicStringEvent->Header.Revision = RECORD_REVISION_1;
>>> + FpdtRecordPtr.DynamicStringEvent->ProgressID = RecordInfo.ProgressID;
>>> + FpdtRecordPtr.DynamicStringEvent->Timestamp = TimeStamp;
>>> + CopyMem (&FpdtRecordPtr.DynamicStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.DynamicStringEvent->Guid));
>>> +
>>> + if (UseModuleName) {
>>> + StringPtr = ModuleName;
>>> + } else if (Token != NULL) {
>>> + StringPtr = Token;
>>> + } else if (Module != NULL) {
>>> + StringPtr = Module;
>>> + } else if (ModuleName != NULL) {
>>> + StringPtr = ModuleName;
>>> + }
>>> + if (StringPtr != NULL && AsciiStrLen (StringPtr) != 0) {
>>> + StrLength = AsciiStrLen (StringPtr);
>>> + DestMax = (RecordInfo.RecordSize - sizeof (DYNAMIC_STRING_EVENT_RECORD)) / sizeof (CHAR8);
>>> + if (StrLength >= DestMax) {
>>> + StrLength = DestMax -1;
>>> + }
>>> + AsciiStrnCpyS (FpdtRecordPtr.DynamicStringEvent->String, DestMax, StringPtr, StrLength);
>>> }
>>> + break;
>>> +
>>> + case GUID_QWORD_EVENT_TYPE:
>>> + FpdtRecordPtr.GuidQwordEvent->Header.Type = GUID_QWORD_EVENT_TYPE;
>>> + FpdtRecordPtr.GuidQwordEvent->Header.Length = RecordInfo.RecordSize;
>>> + FpdtRecordPtr.GuidQwordEvent->Header.Revision = RECORD_REVISION_1;
>>> + FpdtRecordPtr.GuidQwordEvent->ProgressID = RecordInfo.ProgressID;
>>> + FpdtRecordPtr.GuidQwordEvent->Timestamp = TimeStamp;
>>> + CopyMem (&FpdtRecordPtr.GuidQwordEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordEvent->Guid));
>>> + if ((MODULE_LOADIMAGE_START_ID == RecordInfo.ProgressID) && AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) {
>>> + mLoadImageCount++;
>>> + FpdtRecordPtr.GuidQwordEvent->Qword = mLoadImageCount;
>>> + }
>>> + break;
>>> +
>>> + case GUID_QWORD_STRING_EVENT_TYPE:
>>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Type = GUID_QWORD_STRING_EVENT_TYPE;
>>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Length = RecordInfo.RecordSize;
>>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Revision = RECORD_REVISION_1;
>>> + FpdtRecordPtr.GuidQwordStringEvent->ProgressID = RecordInfo.ProgressID;
>>> + FpdtRecordPtr.GuidQwordStringEvent->Timestamp = TimeStamp;
>>> + CopyMem (&FpdtRecordPtr.GuidQwordStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordStringEvent->Guid));
>>> + break;
>>> +
>>> + default:
>>> + //
>>> + // Record is not supported in current DXE phase, return EFI_ABORTED
>>> + //
>>> + return EFI_UNSUPPORTED;
>>> + }
>>> +
>>> + //
>>> + // Report record one by one after records have been reported together.
>>> + //
>>> + if (mFpdtBufferIsReported) {
>>> + //
>>> + // Append Boot records to the boot performance table.
>>> + //
>>> + if (mBootRecordSize + FpdtRecordPtr.RecordHeader->Length > mBootRecordMaxSize) {
>>> + if (!mLackSpaceIsReported) {
>>> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: No enough space to save boot records\n"));
>>> + mLackSpaceIsReported = TRUE;
>>> + }
>>> + return EFI_OUT_OF_RESOURCES;
>>> + } else {
>>> + //
>>> + // Save boot record into BootPerformance table
>>> + //
>>> + CopyMem (mBootRecordBuffer + mBootRecordSize, FpdtRecordPtr.RecordHeader, FpdtRecordPtr.RecordHeader->Length);
>>> + mBootRecordSize += FpdtRecordPtr.RecordHeader->Length;
>>> + mAcpiBootPerformanceTable->Header.Length += FpdtRecordPtr.RecordHeader->Length;
>>> + }
>>> + } else {
>>> + //
>>> + // Update the cached FPDT record buffer.
>>> + //
>>> + mPerformanceLength += FpdtRecordPtr.RecordHeader->Length;
>>> + }
>>> +
>>> + return EFI_SUCCESS;
>>> +}
>>> +
>>> +/**
>>> + Dumps all the PEI performance.
>>> +
>>> + @param HobStart A pointer to a Guid.
>>>
>>> - mGaugeData = NewGaugeData;
>>> - mMaxGaugeRecords *= 2;
>>> + This internal function dumps all the PEI performance log to the DXE performance gauge array.
>>> + It retrieves the optional GUID HOB for PEI performance and then saves the performance data
>>> + to DXE performance data structures.
>>>
>>> +**/
>>> +VOID
>>> +InternalGetPeiPerformance (
>>> + VOID *HobStart
>>> + )
>>> +{
>>> + UINT8 *FirmwarePerformanceHob;
>>> + PEI_EXT_FIRMWARE_PERF_HEADER *PeiPerformanceLogHeader;
>>> + UINT8 *EventRec;
>>> + EFI_HOB_GUID_TYPE *GuidHob;
>>> +
>>> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, HobStart);
>>> + while (GuidHob != NULL) {
>>> + FirmwarePerformanceHob = GET_GUID_HOB_DATA (GuidHob);
>>> + PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *)FirmwarePerformanceHob;
>>> +
>>> + if (mPerformanceLength + PeiPerformanceLogHeader->SizeOfAllEntries > mMaxPerformanceLength) {
>>> + mPerformancePointer = ReallocatePool (
>>> + mPerformanceLength,
>>> + mPerformanceLength +
>>> + (UINTN)PeiPerformanceLogHeader->SizeOfAllEntries +
>>> + FIRMWARE_RECORD_BUFFER,
>>> + mPerformancePointer
>>> + );
>>> + ASSERT (mPerformancePointer != NULL);
>>> + mMaxPerformanceLength = mPerformanceLength +
>>> + (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries) +
>>> + FIRMWARE_RECORD_BUFFER;
>>> + }
>>> +
>>> + EventRec = mPerformancePointer + mPerformanceLength;
>>> + CopyMem (EventRec, FirmwarePerformanceHob + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER), (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries));
>>> //
>>> - // Initialize new data array and migrate old data one.
>>> + // Update the used buffer size.
>>> //
>>> - mGaugeData = CopyMem (mGaugeData, OldGaugeData, OldGaugeDataSize);
>>> + mPerformanceLength += (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries);
>>> + mLoadImageCount += PeiPerformanceLogHeader->LoadImageCount;
>>>
>>> - FreePool (OldGaugeData);
>>> + //
>>> + // Get next performance guid hob
>>> + //
>>> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, GET_NEXT_HOB (GuidHob));
>>> }
>>> +}
>>>
>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>> - GaugeEntryExArray[Index].Handle = (EFI_PHYSICAL_ADDRESS) (UINTN) Handle;
>>> +/**
>>> + Report Boot Perforamnce table address as report status code.
>>>
>>> - if (Token != NULL) {
>>> - AsciiStrnCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, Token, DXE_PERFORMANCE_STRING_LENGTH);
>>> - }
>>> - if (Module != NULL) {
>>> - AsciiStrnCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, Module, DXE_PERFORMANCE_STRING_LENGTH);
>>> + @param Event The event of notify protocol.
>>> + @param Context Notify event context.
>>> +
>>> +**/
>>> +VOID
>>> +EFIAPI
>>> +ReportFpdtRecordBuffer (
>>> + IN EFI_EVENT Event,
>>> + IN VOID *Context
>>> + )
>>> +{
>>> + EFI_STATUS Status;
>>> + UINT64 BPDTAddr;
>>> +
>>> + if (!mFpdtBufferIsReported) {
>>> + Status = AllocateBootPerformanceTable ();
>>> + if (!EFI_ERROR(Status)) {
>>> + BPDTAddr = (UINT64)(UINTN)mAcpiBootPerformanceTable;
>>> + REPORT_STATUS_CODE_EX (
>>> + EFI_PROGRESS_CODE,
>>> + EFI_SOFTWARE_DXE_BS_DRIVER,
>>> + 0,
>>> + NULL,
>>> + &gEfiFirmwarePerformanceGuid,
>>> + &BPDTAddr,
>>> + sizeof (UINT64)
>>> + );
>>> + }
>>> + //
>>> + // Free Cached FPDT record Buffer
>>> + //
>>> + if (mPerformancePointer != NULL) {
>>> + FreePool (mPerformancePointer);
>>> + mPerformancePointer = NULL;
>>> + }
>>> + mPerformanceLength = 0;
>>> + mMaxPerformanceLength = 0;
>>> + //
>>> + // Set FPDT report state to TRUE.
>>> + //
>>> + mFpdtBufferIsReported = TRUE;
>>> }
>>> +}
>>>
>>> - GaugeEntryExArray[Index].EndTimeStamp = 0;
>>> - GaugeEntryExArray[Index].Identifier = Identifier;
>>> +/**
>>> + Adds a record at the end of the performance measurement log
>>> + that records the start time of a performance measurement.
>>>
>>> - if (TimeStamp == 0) {
>>> - TimeStamp = GetPerformanceCounter ();
>>> - }
>>> - GaugeEntryExArray[Index].StartTimeStamp = TimeStamp;
>>> + Adds a record to the end of the performance measurement log
>>> + that contains the Handle, Token, Module and Identifier.
>>> + The end time of the new record must be set to zero.
>>> + If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
>>> + If TimeStamp is zero, the start time in the record is filled in with the value
>>> + read from the current time stamp.
>>>
>>> - mGaugeData->NumberOfEntries++;
>>> + @param Handle Pointer to environment specific context used
>>> + to identify the component being measured.
>>> + @param Token Pointer to a Null-terminated ASCII string
>>> + that identifies the component being measured.
>>> + @param Module Pointer to a Null-terminated ASCII string
>>> + that identifies the module being measured.
>>> + @param TimeStamp 64-bit time stamp.
>>> + @param Identifier 32-bit identifier. If the value is 0, the created record
>>> + is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>>>
>>> - EfiReleaseLock (&mPerfRecordLock);
>>> + @retval EFI_SUCCESS The data was read correctly from the device.
>>> + @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>>>
>>> - return EFI_SUCCESS;
>>> +**/
>>> +EFI_STATUS
>>> +EFIAPI
>>> +StartGaugeEx (
>>> + IN CONST VOID *Handle, OPTIONAL
>>> + IN CONST CHAR8 *Token, OPTIONAL
>>> + IN CONST CHAR8 *Module, OPTIONAL
>>> + IN UINT64 TimeStamp,
>>> + IN UINT32 Identifier
>>> + )
>>> +{
>>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
>>> }
>>>
>>> /**
>>> Searches the performance measurement log from the beginning of the log
>>> for the first matching record that contains a zero end time and fills in a valid end time.
>>>
>>> Searches the performance measurement log from the beginning of the log
>>> - for the first record that matches Handle, Token and Module and has an end time value of zero.
>>> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
>>> If the record can not be found then return EFI_NOT_FOUND.
>>> If the record is found and TimeStamp is not zero,
>>> then the end time in the record is filled in with the value specified by TimeStamp.
>>> If the record is found and TimeStamp is zero, then the end time in the matching record
>>> is filled in with the current time stamp value.
>>> @@ -260,89 +1188,19 @@ EndGaugeEx (
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> IN UINT64 TimeStamp,
>>> IN UINT32 Identifier
>>> )
>>> {
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>> - UINT32 Index;
>>> - EFI_STATUS Status;
>>> -
>>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>>> - if (EFI_ERROR (Status)) {
>>> - return Status;
>>> - }
>>> -
>>> - if (TimeStamp == 0) {
>>> - TimeStamp = GetPerformanceCounter ();
>>> - }
>>> -
>>> - Index = InternalSearchForGaugeEntry (Handle, Token, Module, Identifier);
>>> - if (Index >= mGaugeData->NumberOfEntries) {
>>> - EfiReleaseLock (&mPerfRecordLock);
>>> - return EFI_NOT_FOUND;
>>> - }
>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>> - GaugeEntryExArray[Index].EndTimeStamp = TimeStamp;
>>> -
>>> - EfiReleaseLock (&mPerfRecordLock);
>>> - return EFI_SUCCESS;
>>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
>>> }
>>>
>>> /**
>>> Retrieves a previously logged performance measurement.
>>> It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
>>> and then assign the Identifier with 0.
>>>
>>> - Retrieves the performance log entry from the performance log specified by LogEntryKey.
>>> - If it stands for a valid entry, then EFI_SUCCESS is returned and
>>> - GaugeDataEntryEx stores the pointer to that entry.
>>> -
>>> - This internal function is added to avoid releasing lock before each return statement.
>>> -
>>> - @param LogEntryKey The key for the previous performance measurement log entry.
>>> - If 0, then the first performance measurement log entry is retrieved.
>>> - @param GaugeDataEntryEx The indirect pointer to the extended gauge data entry specified by LogEntryKey
>>> - if the retrieval is successful.
>>> -
>>> - @retval EFI_SUCCESS The GuageDataEntryEx is successfully found based on LogEntryKey.
>>> - @retval EFI_NOT_FOUND The LogEntryKey is the last entry (equals to the total entry number).
>>> - @retval EFI_INVALIDE_PARAMETER The LogEntryKey is not a valid entry (greater than the total entry number).
>>> - @retval EFI_INVALIDE_PARAMETER GaugeDataEntryEx is NULL.
>>> -
>>> -**/
>>> -EFI_STATUS
>>> -EFIAPI
>>> -InternalGetGaugeEx (
>>> - IN UINTN LogEntryKey,
>>> - OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
>>> - )
>>> -{
>>> - UINTN NumberOfEntries;
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>> -
>>> - NumberOfEntries = (UINTN) (mGaugeData->NumberOfEntries);
>>> - if (LogEntryKey > NumberOfEntries) {
>>> - return EFI_INVALID_PARAMETER;
>>> - }
>>> - if (LogEntryKey == NumberOfEntries) {
>>> - return EFI_NOT_FOUND;
>>> - }
>>> -
>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>> -
>>> - if (GaugeDataEntryEx == NULL) {
>>> - return EFI_INVALID_PARAMETER;
>>> - }
>>> - *GaugeDataEntryEx = &GaugeEntryExArray[LogEntryKey];
>>> -
>>> - return EFI_SUCCESS;
>>> -}
>>> -
>>> -/**
>>> - Retrieves a previously logged performance measurement.
>>> - It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
>>> - and then assign the Identifier with 0.
>>> + !!! Not support!!!
>>>
>>> Retrieves the performance log entry from the performance log specified by LogEntryKey.
>>> If it stands for a valid entry, then EFI_SUCCESS is returned and
>>> GaugeDataEntryEx stores the pointer to that entry.
>>>
>>> @@ -362,22 +1220,11 @@ EFIAPI
>>> GetGaugeEx (
>>> IN UINTN LogEntryKey,
>>> OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
>>> )
>>> {
>>> - EFI_STATUS Status;
>>> -
>>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>>> - if (EFI_ERROR (Status)) {
>>> - return Status;
>>> - }
>>> -
>>> - Status = InternalGetGaugeEx (LogEntryKey, GaugeDataEntryEx);
>>> -
>>> - EfiReleaseLock (&mPerfRecordLock);
>>> -
>>> - return Status;
>>> + return EFI_UNSUPPORTED;
>>> }
>>>
>>> /**
>>> Adds a record at the end of the performance measurement log
>>> that records the start time of a performance measurement.
>>> @@ -452,10 +1299,12 @@ EndGauge (
>>> /**
>>> Retrieves a previously logged performance measurement.
>>> It can also retrieve the log created by StartGaugeEx and EndGaugeEx of PERFORMANCE_EX_PROTOCOL,
>>> and then eliminate the Identifier.
>>>
>>> + !!! Not support!!!
>>> +
>>> Retrieves the performance log entry from the performance log specified by LogEntryKey.
>>> If it stands for a valid entry, then EFI_SUCCESS is returned and
>>> GaugeDataEntry stores the pointer to that entry.
>>>
>>> @param LogEntryKey The key for the previous performance measurement log entry.
>>> @@ -474,81 +1323,13 @@ EFIAPI
>>> GetGauge (
>>> IN UINTN LogEntryKey,
>>> OUT GAUGE_DATA_ENTRY **GaugeDataEntry
>>> )
>>> {
>>> - EFI_STATUS Status;
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryEx;
>>> -
>>> - GaugeEntryEx = NULL;
>>> -
>>> - Status = GetGaugeEx (LogEntryKey, &GaugeEntryEx);
>>> - if (EFI_ERROR (Status)) {
>>> - return Status;
>>> - }
>>> -
>>> - if (GaugeDataEntry == NULL) {
>>> - return EFI_INVALID_PARAMETER;
>>> - }
>>> -
>>> - *GaugeDataEntry = (GAUGE_DATA_ENTRY *) GaugeEntryEx;
>>> -
>>> - return EFI_SUCCESS;
>>> + return EFI_UNSUPPORTED;
>>> }
>>>
>>> -/**
>>> - Dumps all the PEI performance log to DXE performance gauge array.
>>> -
>>> - This internal function dumps all the PEI performance log to the DXE performance gauge array.
>>> - It retrieves the optional GUID HOB for PEI performance and then saves the performance data
>>> - to DXE performance data structures.
>>> -
>>> -**/
>>> -VOID
>>> -InternalGetPeiPerformance (
>>> - VOID
>>> - )
>>> -{
>>> - EFI_HOB_GUID_TYPE *GuidHob;
>>> - PEI_PERFORMANCE_LOG_HEADER *LogHob;
>>> - PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
>>> - UINT32 *LogIdArray;
>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>> - UINT32 Index;
>>> - UINT32 NumberOfEntries;
>>> -
>>> - NumberOfEntries = 0;
>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>> -
>>> - //
>>> - // Dump PEI Log Entries to DXE Guage Data structure.
>>> - //
>>> - GuidHob = GetFirstGuidHob (&gPerformanceProtocolGuid);
>>> - if (GuidHob != NULL) {
>>> - LogHob = GET_GUID_HOB_DATA (GuidHob);
>>> - LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (LogHob + 1);
>>> -
>>> - NumberOfEntries = LogHob->NumberOfEntries;
>>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>>> - GaugeEntryExArray[Index].Handle = LogEntryArray[Index].Handle;
>>> - AsciiStrCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Token);
>>> - AsciiStrCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Module);
>>> - GaugeEntryExArray[Index].StartTimeStamp = LogEntryArray[Index].StartTimeStamp;
>>> - GaugeEntryExArray[Index].EndTimeStamp = LogEntryArray[Index].EndTimeStamp;
>>> - GaugeEntryExArray[Index].Identifier = 0;
>>> - }
>>> -
>>> - GuidHob = GetFirstGuidHob (&gPerformanceExProtocolGuid);
>>> - if (GuidHob != NULL) {
>>> - LogIdArray = GET_GUID_HOB_DATA (GuidHob);
>>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>>> - GaugeEntryExArray[Index].Identifier = LogIdArray[Index];
>>> - }
>>> - }
>>> - }
>>> - mGaugeData->NumberOfEntries = NumberOfEntries;
>>> -}
>>>
>>> /**
>>> The constructor function initializes Performance infrastructure for DXE phase.
>>>
>>> The constructor function publishes Performance and PerformanceEx protocol, allocates memory to log DXE performance
>>> @@ -567,40 +1348,53 @@ DxeCorePerformanceLibConstructor (
>>> IN EFI_HANDLE ImageHandle,
>>> IN EFI_SYSTEM_TABLE *SystemTable
>>> )
>>> {
>>> EFI_STATUS Status;
>>> + EFI_HANDLE Handle;
>>> + EFI_EVENT ReadyToBootEvent;
>>> PERFORMANCE_PROPERTY *PerformanceProperty;
>>>
>>> -
>>> if (!PerformanceMeasurementEnabled ()) {
>>> //
>>> // Do not initialize performance infrastructure if not required.
>>> //
>>> return EFI_SUCCESS;
>>> }
>>> +
>>> + //
>>> + // Dump normal PEI performance records
>>> + //
>>> + InternalGetPeiPerformance (GetHobList());
>>> +
>>> //
>>> - // Install the protocol interfaces.
>>> + // Install the protocol interfaces for DXE performance library instance.
>>> //
>>> + Handle = NULL;
>>> Status = gBS->InstallMultipleProtocolInterfaces (
>>> - &mHandle,
>>> + &Handle,
>>> &gPerformanceProtocolGuid,
>>> &mPerformanceInterface,
>>> &gPerformanceExProtocolGuid,
>>> &mPerformanceExInterface,
>>> NULL
>>> );
>>> ASSERT_EFI_ERROR (Status);
>>>
>>> - mMaxGaugeRecords = INIT_DXE_GAUGE_DATA_ENTRIES + (UINT16) (PcdGet16 (PcdMaxPeiPerformanceLogEntries16) != 0 ?
>>> - PcdGet16 (PcdMaxPeiPerformanceLogEntries16) :
>>> - PcdGet8 (PcdMaxPeiPerformanceLogEntries));
>>> -
>>> - mGaugeData = AllocateZeroPool (sizeof (GAUGE_DATA_HEADER) + (sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords));
>>> - ASSERT (mGaugeData != NULL);
>>> + //
>>> + // Register ReadyToBoot event to report StatusCode data
>>> + //
>>> + Status = gBS->CreateEventEx (
>>> + EVT_NOTIFY_SIGNAL,
>>> + TPL_CALLBACK,
>>> + ReportFpdtRecordBuffer,
>>> + NULL,
>>> + &gEfiEventReadyToBootGuid,
>>> + &ReadyToBootEvent
>>> + );
>>>
>>> - InternalGetPeiPerformance ();
>>> + ASSERT_EFI_ERROR (Status);
>>>
>>> Status = EfiGetSystemConfigurationTable (&gPerformanceProtocolGuid, (VOID **) &PerformanceProperty);
>>> if (EFI_ERROR (Status)) {
>>> //
>>> // Install configuration table for performance property.
>>> @@ -651,19 +1445,19 @@ StartPerformanceMeasurementEx (
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> IN UINT64 TimeStamp,
>>> IN UINT32 Identifier
>>> )
>>> {
>>> - return (RETURN_STATUS) StartGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
>>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
>>> }
>>>
>>> /**
>>> Searches the performance measurement log from the beginning of the log
>>> for the first matching record that contains a zero end time and fills in a valid end time.
>>>
>>> Searches the performance measurement log from the beginning of the log
>>> - for the first record that matches Handle, Token and Module and has an end time value of zero.
>>> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
>>> If the record can not be found then return RETURN_NOT_FOUND.
>>> If the record is found and TimeStamp is not zero,
>>> then the end time in the record is filled in with the value specified by TimeStamp.
>>> If the record is found and TimeStamp is zero, then the end time in the matching record
>>> is filled in with the current time stamp value.
>>> @@ -690,18 +1484,20 @@ EndPerformanceMeasurementEx (
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> IN UINT64 TimeStamp,
>>> IN UINT32 Identifier
>>> )
>>> {
>>> - return (RETURN_STATUS) EndGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
>>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
>>> }
>>>
>>> /**
>>> Attempts to retrieve a performance measurement log entry from the performance measurement log.
>>> It can also retrieve the log created by StartPerformanceMeasurement and EndPerformanceMeasurement,
>>> and then assign the Identifier with 0.
>>>
>>> + !!! Not support!!!
>>> +
>>> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
>>> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
>>> and the key for the second entry in the log is returned. If the performance log is empty,
>>> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
>>> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
>>> @@ -729,63 +1525,29 @@ EndPerformanceMeasurementEx (
>>> being measured.
>>> @param StartTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
>>> was started.
>>> @param EndTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
>>> was ended.
>>> - @param Identifier Pointer to the 32-bit identifier that was recorded.
>>> + @param Identifier Pointer to the 32-bit identifier that was recorded when the measurement
>>> + was ended.
>>>
>>> @return The key for the next performance log entry (in general case).
>>>
>>> **/
>>> UINTN
>>> EFIAPI
>>> GetPerformanceMeasurementEx (
>>> - IN UINTN LogEntryKey,
>>> + IN UINTN LogEntryKey,
>>> OUT CONST VOID **Handle,
>>> OUT CONST CHAR8 **Token,
>>> OUT CONST CHAR8 **Module,
>>> OUT UINT64 *StartTimeStamp,
>>> OUT UINT64 *EndTimeStamp,
>>> OUT UINT32 *Identifier
>>> )
>>> {
>>> - EFI_STATUS Status;
>>> - GAUGE_DATA_ENTRY_EX *GaugeData;
>>> -
>>> - GaugeData = NULL;
>>> -
>>> - ASSERT (Handle != NULL);
>>> - ASSERT (Token != NULL);
>>> - ASSERT (Module != NULL);
>>> - ASSERT (StartTimeStamp != NULL);
>>> - ASSERT (EndTimeStamp != NULL);
>>> - ASSERT (Identifier != NULL);
>>> -
>>> - Status = GetGaugeEx (LogEntryKey++, &GaugeData);
>>> -
>>> - //
>>> - // Make sure that LogEntryKey is a valid log entry key,
>>> - //
>>> - ASSERT (Status != EFI_INVALID_PARAMETER);
>>> -
>>> - if (EFI_ERROR (Status)) {
>>> - //
>>> - // The LogEntryKey is the last entry (equals to the total entry number).
>>> - //
>>> - return 0;
>>> - }
>>> -
>>> - ASSERT (GaugeData != NULL);
>>> -
>>> - *Handle = (VOID *) (UINTN) GaugeData->Handle;
>>> - *Token = GaugeData->Token;
>>> - *Module = GaugeData->Module;
>>> - *StartTimeStamp = GaugeData->StartTimeStamp;
>>> - *EndTimeStamp = GaugeData->EndTimeStamp;
>>> - *Identifier = GaugeData->Identifier;
>>> -
>>> - return LogEntryKey;
>>> + return 0;
>>> }
>>>
>>> /**
>>> Adds a record at the end of the performance measurement log
>>> that records the start time of a performance measurement.
>>> @@ -816,11 +1578,11 @@ StartPerformanceMeasurement (
>>> IN CONST CHAR8 *Token, OPTIONAL
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> IN UINT64 TimeStamp
>>> )
>>> {
>>> - return StartPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
>>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, 0);
>>> }
>>>
>>> /**
>>> Searches the performance measurement log from the beginning of the log
>>> for the first matching record that contains a zero end time and fills in a valid end time.
>>> @@ -852,18 +1614,20 @@ EndPerformanceMeasurement (
>>> IN CONST CHAR8 *Token, OPTIONAL
>>> IN CONST CHAR8 *Module, OPTIONAL
>>> IN UINT64 TimeStamp
>>> )
>>> {
>>> - return EndPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
>>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, 0);
>>> }
>>>
>>> /**
>>> Attempts to retrieve a performance measurement log entry from the performance measurement log.
>>> It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
>>> and then eliminate the Identifier.
>>>
>>> + !!! Not support!!!
>>> +
>>> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
>>> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
>>> and the key for the second entry in the log is returned. If the performance log is empty,
>>> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
>>> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
>>> @@ -905,12 +1669,11 @@ GetPerformanceMeasurement (
>>> OUT CONST CHAR8 **Module,
>>> OUT UINT64 *StartTimeStamp,
>>> OUT UINT64 *EndTimeStamp
>>> )
>>> {
>>> - UINT32 Identifier;
>>> - return GetPerformanceMeasurementEx (LogEntryKey, Handle, Token, Module, StartTimeStamp, EndTimeStamp, &Identifier);
>>> + return 0;
>>> }
>>>
>>> /**
>>> Returns TRUE if the performance measurement macros are enabled.
>>>
>>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>>> index 5b89ce2..71c181f 100644
>>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>>> @@ -7,11 +7,11 @@
>>> # It initializes DXE phase performance logging by publishing the Performance and PerformanceEx Protocol,
>>> # which is consumed by DxePerformanceLib to logging performance data in DXE phase.
>>> # This library is mainly used by DxeCore to start performance logging to ensure that
>>> # Performance and PerformanceEx Protocol are installed at the very beginning of DXE phase.
>>> #
>>> -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>>> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>>> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>>> # This program and the accompanying materials
>>> # are licensed and made available under the terms and conditions of the BSD License
>>> # which accompanies this distribution. The full text of the license may be found at
>>> # http://opensource.org/licenses/bsd-license.php
>>> @@ -48,27 +48,39 @@
>>>
>>>
>>> [LibraryClasses]
>>> MemoryAllocationLib
>>> UefiBootServicesTableLib
>>> + UefiRuntimeServicesTableLib
>>> PcdLib
>>> TimerLib
>>> BaseMemoryLib
>>> BaseLib
>>> HobLib
>>> DebugLib
>>> UefiLib
>>> + ReportStatusCodeLib
>>> + DxeServicesLib
>>> + PeCoffGetEntryPointLib
>>> +
>>> +[Protocols]
>>> + gEfiSmmCommunicationProtocolGuid ## SOMETIMES_CONSUMES
>>>
>>>
>>> [Guids]
>>> ## SOMETIMES_CONSUMES ## HOB
>>> ## PRODUCES ## UNDEFINED # Install protocol
>>> ## PRODUCES ## SystemTable
>>> gPerformanceProtocolGuid
>>> ## SOMETIMES_CONSUMES ## HOB
>>> ## PRODUCES ## UNDEFINED # Install protocol
>>> gPerformanceExProtocolGuid
>>> + gZeroGuid ## SOMETIMES_CONSUMES ## GUID
>>> + gEfiFirmwarePerformanceGuid ## SOMETIMES_PRODUCES ## UNDEFINED # StatusCode Data
>>> + gEdkiiExtendedFirmwarePerformanceGuid ## SOMETIMES_CONSUMES ## HOB # StatusCode Data
>>> + gEfiEventReadyToBootGuid ## CONSUMES ## Event
>>> + gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable
>>>
>>> [Pcd]
>>> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries ## CONSUMES
>>> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16 ## CONSUMES
>>> - gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
>>> + gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
>>> + gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly ## CONSUMES
>>> + gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES
>>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>>> index f1540d8..7e79675 100644
>>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>>> @@ -2,11 +2,11 @@
>>> Master header files for DxeCorePerformanceLib instance.
>>>
>>> This header file holds the prototypes of the Performance and PerformanceEx Protocol published by this
>>> library instance at its constructor.
>>>
>>> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>>> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>>> This program and the accompanying materials
>>> are licensed and made available under the terms and conditions of the BSD License
>>> which accompanies this distribution. The full text of the license may be found at
>>> http://opensource.org/licenses/bsd-license.php
>>>
>>> @@ -20,21 +20,36 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>>>
>>>
>>> #include <PiDxe.h>
>>>
>>> #include <Guid/Performance.h>
>>> +#include <Guid/ExtendedFirmwarePerformance.h>
>>> +#include <Guid/ZeroGuid.h>
>>> +#include <Guid/EventGroup.h>
>>> +#include <Guid/FirmwarePerformance.h>
>>> +#include <Guid/PiSmmCommunicationRegionTable.h>
>>> +
>>> +#include <Protocol/DriverBinding.h>
>>> +#include <Protocol/LoadedImage.h>
>>> +#include <Protocol/ComponentName2.h>
>>> +#include <Protocol/DevicePathToText.h>
>>> +#include <Protocol/SmmCommunication.h>
>>>
>>> #include <Library/PerformanceLib.h>
>>> #include <Library/DebugLib.h>
>>> #include <Library/HobLib.h>
>>> #include <Library/BaseLib.h>
>>> #include <Library/BaseMemoryLib.h>
>>> #include <Library/TimerLib.h>
>>> #include <Library/PcdLib.h>
>>> #include <Library/UefiBootServicesTableLib.h>
>>> +#include <Library/UefiRuntimeServicesTableLib.h>
>>> #include <Library/MemoryAllocationLib.h>
>>> #include <Library/UefiLib.h>
>>> +#include <Library/ReportStatusCodeLib.h>
>>> +#include <Library/DxeServicesLib.h>
>>> +#include <Library/PeCoffGetEntryPointLib.h>
>>>
>>> //
>>> // Interface declarations for PerformanceEx Protocol.
>>> //
>>> /**
>>> --
>>> 1.9.5.msysgit.1
>>>
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-05-22 9:38 ` Zeng, Star
@ 2018-05-22 10:00 ` Laszlo Ersek
2018-05-22 10:38 ` Zeng, Star
2018-05-22 10:00 ` Ard Biesheuvel
1 sibling, 1 reply; 21+ messages in thread
From: Laszlo Ersek @ 2018-05-22 10:00 UTC (permalink / raw)
To: Zeng, Star, Ard Biesheuvel
Cc: Bi, Dandan, Andrew Fish, Kinney, Michael D, Leif Lindholm,
edk2-devel@lists.01.org, Gao, Liming, Matt Sealey
Hi Star,
On 05/22/18 11:38, Zeng, Star wrote:
> It comes to an old question: how to know PEI is 32bit/64bit? But not DXE is 32bit/64bit.
we've discussed this question in the past (as you remember :) ) and
people suggested both HOBs and PCDs to expose the "PEI phase max
address" to DXE. All of those ideas were rejected -- I'm unsure why, to
this day --, but assuming people who opposed those ideas are going to
oppose them again, I think Ard's idea is good, about introducing
dedicated MemoryAllocationLib interfaces, for PEI-targeted memory
allocation.
Once drivers adopt these new interfaces, platforms can at least fork the
MemoryAllocationLib instance(s) they need, and customize the PEI phase
max address one way or another.
Thanks,
Laszlo
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, May 22, 2018 5:03 PM
> To: Zeng, Star <star.zeng@intel.com>
> Cc: Bi, Dandan <dandan.bi@intel.com>; Laszlo Ersek <lersek@redhat.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
> Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>
> pd On 22 May 2018 at 10:58, Zeng, Star <star.zeng@intel.com> wrote:
>> How about the code to try allocating <4G memory, then try allocating any memory if failed to allocate <4G memory?
>>
>> For example, the code snippet in SmbiosDxe.c.
>>
>> PhysicalAddress = 0xffffffff;
>> Status = gBS->AllocatePages (
>> AllocateMaxAddress,
>> EfiRuntimeServicesData,
>> EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
>> &PhysicalAddress
>> );
>> if (EFI_ERROR (Status)) {
>> DEBUG ((EFI_D_ERROR, "SmbiosCreateTable () could not allocate EntryPointStructure < 4GB\n"));
>> Status = gBS->AllocatePages (
>> AllocateAnyPages,
>> EfiRuntimeServicesData,
>> EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
>> &PhysicalAddress
>> );
>> if (EFI_ERROR (Status)) {
>> return EFI_OUT_OF_RESOURCES;
>> }
>> }
>>
>
> Yes, that should do the trick.
>
> But perhaps we should add something like
>
> AllocatePeiAccessiblePages()
>
> to MemoryAllocationLib, which just uses AllocateMaxAddress or
> AllocateAnyPages depending on whether MDE_CPU_X64 is #defined.
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-05-22 9:38 ` Zeng, Star
2018-05-22 10:00 ` Laszlo Ersek
@ 2018-05-22 10:00 ` Ard Biesheuvel
1 sibling, 0 replies; 21+ messages in thread
From: Ard Biesheuvel @ 2018-05-22 10:00 UTC (permalink / raw)
To: Zeng, Star
Cc: Bi, Dandan, Laszlo Ersek, Andrew Fish, Kinney, Michael D,
Leif Lindholm, edk2-devel@lists.01.org, Gao, Liming, Matt Sealey
On 22 May 2018 at 11:38, Zeng, Star <star.zeng@intel.com> wrote:
> It comes to an old question: how to know PEI is 32bit/64bit? But not DXE is 32bit/64bit.
>
True. But the current approach is to always assume that PEI is 32-bit,
on every architecture. We can improve upon that by only making this
assumption on X64 builds of DXE, and do so in an abstracted manner
rather than putting the hardcoded limit everywhere in the code.
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, May 22, 2018 5:03 PM
> To: Zeng, Star <star.zeng@intel.com>
> Cc: Bi, Dandan <dandan.bi@intel.com>; Laszlo Ersek <lersek@redhat.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
> Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>
> pd On 22 May 2018 at 10:58, Zeng, Star <star.zeng@intel.com> wrote:
>> How about the code to try allocating <4G memory, then try allocating any memory if failed to allocate <4G memory?
>>
>> For example, the code snippet in SmbiosDxe.c.
>>
>> PhysicalAddress = 0xffffffff;
>> Status = gBS->AllocatePages (
>> AllocateMaxAddress,
>> EfiRuntimeServicesData,
>> EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
>> &PhysicalAddress
>> );
>> if (EFI_ERROR (Status)) {
>> DEBUG ((EFI_D_ERROR, "SmbiosCreateTable () could not allocate EntryPointStructure < 4GB\n"));
>> Status = gBS->AllocatePages (
>> AllocateAnyPages,
>> EfiRuntimeServicesData,
>> EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
>> &PhysicalAddress
>> );
>> if (EFI_ERROR (Status)) {
>> return EFI_OUT_OF_RESOURCES;
>> }
>> }
>>
>
> Yes, that should do the trick.
>
> But perhaps we should add something like
>
> AllocatePeiAccessiblePages()
>
> to MemoryAllocationLib, which just uses AllocateMaxAddress or
> AllocateAnyPages depending on whether MDE_CPU_X64 is #defined.
>
> --
> Ard.
>
>> -----Original Message-----
>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>> Sent: Tuesday, May 22, 2018 4:52 PM
>> To: Bi, Dandan <dandan.bi@intel.com>; Laszlo Ersek <lersek@redhat.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>; edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
>> Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>>
>> (+ Laszlo, Andrew, Mike)
>>
>> On 22 May 2018 at 02:33, Bi, Dandan <dandan.bi@intel.com> wrote:
>>> Sorry for the delayed response.
>>>
>>> The allocated performance table ( below 4G ) is to save the boot performance data in normal boot and S3 phase.
>>> PEIM FirmwarePerformancePei will get the address of the performance table and update the performance date of S3 phase to the table.
>>> The address need to be handled in PEI phase(32bit), that's the main reason why we allocate it below 4G.
>>>
>>
>> The 32-bit PEI + 64-bit DXE combo is specific to X64. You have added
>> code to a generic library that ASSERT()s if allocating memory below 4
>> GB fails, breaking non-PC architectures.
>>
>> So please, fix this. Or at least suggest a way around it so that other
>> architectures can keep using this library.
>>
>> This is another consequence of our failure to model the special 32-bit
>> PEI/64-bit DXE combination using proper PI interfaces, resulting in
>> these kinds of breakages and open coded 4 GB allocations all
>> throughout the code. Can we please work on getting this fixed?
>>
>>
>>> -----Original Message-----
>>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>>> Sent: Wednesday, May 2, 2018 12:27 AM
>>> To: Bi, Dandan <dandan.bi@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>
>>> Cc: edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
>>> Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>>>
>>> On 30 January 2018 at 14:53, Dandan Bi <dandan.bi@intel.com> wrote:
>>>> V2:
>>>> Update DxecorePerformanceLib to report the boot performance table
>>>> address instead of records contents.
>>>>
>>>> Updated to convert Pref entry to FPDT record in DXE phase and then
>>>> allocate boot performance table to save the record and report
>>>> the address of boot performance table to FirmwarePerformanceDxe.
>>>>
>>>> Cc: Liming Gao <liming.gao@intel.com>
>>>> Cc: Star Zeng <star.zeng@intel.com>
>>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>>>> ---
>>>> .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 1389 +++++++++++++++-----
>>>> .../DxeCorePerformanceLib.inf | 20 +-
>>>> .../DxeCorePerformanceLibInternal.h | 17 +-
>>>> 3 files changed, 1108 insertions(+), 318 deletions(-)
>>>>
>>>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>>>> index 7c0e207..c6f8a16 100644
>>>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>>>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
>>>> @@ -8,11 +8,11 @@
>>>> which are consumed by DxePerformanceLib to logging performance data in DXE phase.
>>>>
>>>> This library is mainly used by DxeCore to start performance logging to ensure that
>>>> Performance Protocol is installed at the very beginning of DXE phase.
>>>>
>>>> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>>>> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>>>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>>>> This program and the accompanying materials
>>>> are licensed and made available under the terms and conditions of the BSD License
>>>> which accompanies this distribution. The full text of the license may be found at
>>>> http://opensource.org/licenses/bsd-license.php
>>>> @@ -23,27 +23,65 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>>>> **/
>>>>
>>>>
>>>> #include "DxeCorePerformanceLibInternal.h"
>>>>
>>>> -
>>>> //
>>>> -// The data structure to hold global performance data.
>>>> +// Data for FPDT performance records.
>>>> //
>>>> -GAUGE_DATA_HEADER *mGaugeData;
>>>> +#define SMM_BOOT_RECORD_COMM_SIZE (OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + sizeof(SMM_BOOT_RECORD_COMMUNICATE))
>>>> +#define STRING_SIZE (EDKII_STRING_EVENT_RECORD_NAME_LENGTH * sizeof (CHAR8))
>>>> +#define MAX_RECORD_SIZE (sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE)
>>>> +#define FIRMWARE_RECORD_BUFFER 0x10000
>>>> +#define CACHE_HANDLE_GUID_COUNT 0x1000
>>>> +
>>>> +BOOT_PERFORMANCE_TABLE *mAcpiBootPerformanceTable = NULL;
>>>> +BOOT_PERFORMANCE_TABLE mBootPerformanceTableTemplate = {
>>>> + {
>>>> + EFI_ACPI_5_0_FPDT_BOOT_PERFORMANCE_TABLE_SIGNATURE,
>>>> + sizeof (BOOT_PERFORMANCE_TABLE)
>>>> + },
>>>> + {
>>>> + {
>>>> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_TYPE_FIRMWARE_BASIC_BOOT, // Type
>>>> + sizeof (EFI_ACPI_5_0_FPDT_FIRMWARE_BASIC_BOOT_RECORD), // Length
>>>> + EFI_ACPI_5_0_FPDT_RUNTIME_RECORD_REVISION_FIRMWARE_BASIC_BOOT // Revision
>>>> + },
>>>> + 0, // Reserved
>>>> + //
>>>> + // These values will be updated at runtime.
>>>> + //
>>>> + 0, // ResetEnd
>>>> + 0, // OsLoaderLoadImageStart
>>>> + 0, // OsLoaderStartImageStart
>>>> + 0, // ExitBootServicesEntry
>>>> + 0 // ExitBootServicesExit
>>>> + }
>>>> +};
>>>>
>>>> -//
>>>> -// The current maximum number of logging entries. If current number of
>>>> -// entries exceeds this value, it will re-allocate a larger array and
>>>> -// migration the old data to the larger array.
>>>> -//
>>>> -UINT32 mMaxGaugeRecords;
>>>> +typedef struct {
>>>> + EFI_HANDLE Handle;
>>>> + CHAR8 NameString[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
>>>> + EFI_GUID ModuleGuid;
>>>> +} HANDLE_GUID_MAP;
>>>>
>>>> -//
>>>> -// The handle to install Performance Protocol instance.
>>>> -//
>>>> -EFI_HANDLE mHandle = NULL;
>>>> +HANDLE_GUID_MAP mCacheHandleGuidTable[CACHE_HANDLE_GUID_COUNT];
>>>> +UINTN mCachePairCount = 0;
>>>> +
>>>> +UINT32 mLoadImageCount = 0;
>>>> +UINT32 mPerformanceLength = 0;
>>>> +UINT32 mMaxPerformanceLength = 0;
>>>> +UINT32 mBootRecordSize = 0;
>>>> +UINT32 mBootRecordMaxSize = 0;
>>>> +
>>>> +BOOLEAN mFpdtBufferIsReported = FALSE;
>>>> +BOOLEAN mLackSpaceIsReported = FALSE;
>>>> +CHAR8 *mPlatformLanguage = NULL;
>>>> +UINT8 *mPerformancePointer = NULL;
>>>> +UINT8 *mBootRecordBuffer = NULL;
>>>> +
>>>> +EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *mDevicePathToText = NULL;
>>>>
>>>> //
>>>> // Interfaces for Performance Protocol.
>>>> //
>>>> PERFORMANCE_PROTOCOL mPerformanceInterface = {
>>>> @@ -61,179 +99,1069 @@ PERFORMANCE_EX_PROTOCOL mPerformanceExInterface = {
>>>> GetGaugeEx
>>>> };
>>>>
>>>> PERFORMANCE_PROPERTY mPerformanceProperty;
>>>>
>>>> -//
>>>> -// Gauge record lock to avoid data corruption or even memory overflow
>>>> -//
>>>> -STATIC EFI_LOCK mPerfRecordLock = EFI_INITIALIZE_LOCK_VARIABLE (TPL_NOTIFY);
>>>> +/**
>>>> +Check whether the Token is a known one which is uesed by core.
>>>> +
>>>> +@param Token Pointer to a Null-terminated ASCII string
>>>> +
>>>> +@retval TRUE Is a known one used by core.
>>>> +@retval FALSE Not a known one.
>>>> +
>>>> +**/
>>>> +BOOLEAN
>>>> +IsKnownTokens (
>>>> + IN CONST CHAR8 *Token
>>>> + )
>>>> +{
>>>> + if (AsciiStrCmp (Token, SEC_TOK) == 0 ||
>>>> + AsciiStrCmp (Token, PEI_TOK) == 0 ||
>>>> + AsciiStrCmp (Token, DXE_TOK) == 0 ||
>>>> + AsciiStrCmp (Token, BDS_TOK) == 0 ||
>>>> + AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0 ||
>>>> + AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0 ||
>>>> + AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0 ||
>>>> + AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0 ||
>>>> + AsciiStrCmp (Token, START_IMAGE_TOK) == 0 ||
>>>> + AsciiStrCmp (Token, PEIM_TOK) == 0) {
>>>> + return TRUE;
>>>> + } else {
>>>> + return FALSE;
>>>> + }
>>>> +}
>>>> +
>>>> +/**
>>>> +Check whether the ID is a known one which map to the known Token.
>>>> +
>>>> +@param Identifier 32-bit identifier.
>>>> +
>>>> +@retval TRUE Is a known one used by core.
>>>> +@retval FALSE Not a known one.
>>>> +
>>>> +**/
>>>> +BOOLEAN
>>>> +IsKnownID (
>>>> + IN UINT32 Identifier
>>>> + )
>>>> +{
>>>> + if (Identifier == MODULE_START_ID ||
>>>> + Identifier == MODULE_END_ID ||
>>>> + Identifier == MODULE_LOADIMAGE_START_ID ||
>>>> + Identifier == MODULE_LOADIMAGE_END_ID ||
>>>> + Identifier == MODULE_DB_START_ID ||
>>>> + Identifier == MODULE_DB_END_ID ||
>>>> + Identifier == MODULE_DB_SUPPORT_START_ID ||
>>>> + Identifier == MODULE_DB_SUPPORT_END_ID ||
>>>> + Identifier == MODULE_DB_STOP_START_ID ||
>>>> + Identifier == MODULE_DB_STOP_END_ID) {
>>>> + return TRUE;
>>>> + } else {
>>>> + return FALSE;
>>>> + }
>>>> +}
>>>>
>>>> /**
>>>> - Searches in the gauge array with keyword Handle, Token, Module and Identifier.
>>>> + Allocate EfiReservedMemoryType below 4G memory address.
>>>> +
>>>> + This function allocates EfiReservedMemoryType below 4G memory address.
>>>> +
>>>> + @param[in] Size Size of memory to allocate.
>>>> +
>>>> + @return Allocated address for output.
>>>> +
>>>> +**/
>>>> +VOID *
>>>> +FpdtAllocateReservedMemoryBelow4G (
>>>> + IN UINTN Size
>>>> + )
>>>> +{
>>>> + UINTN Pages;
>>>> + EFI_PHYSICAL_ADDRESS Address;
>>>> + EFI_STATUS Status;
>>>> + VOID *Buffer;
>>>> +
>>>> + Buffer = NULL;
>>>> + Pages = EFI_SIZE_TO_PAGES (Size);
>>>> + Address = 0xffffffff;
>>>> +
>>>> + Status = gBS->AllocatePages (
>>>> + AllocateMaxAddress,
>>>> + EfiReservedMemoryType,
>>>> + Pages,
>>>> + &Address
>>>> + );
>>>> + ASSERT_EFI_ERROR (Status);
>>>
>>> This code is breaking DEBUG builds on ARM systems that have no memory
>>> below 4 GB.
>>>
>>>> +
>>>> + if (!EFI_ERROR (Status)) {
>>>> + Buffer = (VOID *) (UINTN) Address;
>>>> + ZeroMem (Buffer, Size);
>>>> + }
>>>> +
>>>> + return Buffer;
>>>> +}
>>>> +
>>>> +/**
>>>> + Allocate buffer for Boot Performance table.
>>>> +
>>>> + @return Status code.
>>>> +
>>>> +**/
>>>> +EFI_STATUS
>>>> +AllocateBootPerformanceTable (
>>>> + )
>>>> +{
>>>> + EFI_STATUS Status;
>>>> + UINTN Size;
>>>> + UINT8 *SmmBootRecordCommBuffer;
>>>> + EFI_SMM_COMMUNICATE_HEADER *SmmCommBufferHeader;
>>>> + SMM_BOOT_RECORD_COMMUNICATE *SmmCommData;
>>>> + UINTN CommSize;
>>>> + UINTN BootPerformanceDataSize;
>>>> + UINT8 *BootPerformanceData;
>>>> + EFI_SMM_COMMUNICATION_PROTOCOL *Communication;
>>>> + FIRMWARE_PERFORMANCE_VARIABLE PerformanceVariable;
>>>> + EDKII_PI_SMM_COMMUNICATION_REGION_TABLE *SmmCommRegionTable;
>>>> + EFI_MEMORY_DESCRIPTOR *SmmCommMemRegion;
>>>> + UINTN Index;
>>>> + VOID *SmmBootRecordData;
>>>> + UINTN SmmBootRecordDataSize;
>>>> + UINTN ReservedMemSize;
>>>> +
>>>> + //
>>>> + // Collect boot records from SMM drivers.
>>>> + //
>>>> + SmmBootRecordCommBuffer = NULL;
>>>> + SmmCommData = NULL;
>>>> + SmmBootRecordData = NULL;
>>>> + SmmBootRecordDataSize = 0;
>>>> + ReservedMemSize = 0;
>>>> + Status = gBS->LocateProtocol (&gEfiSmmCommunicationProtocolGuid, NULL, (VOID **) &Communication);
>>>> + if (!EFI_ERROR (Status)) {
>>>> + //
>>>> + // Initialize communicate buffer
>>>> + // Get the prepared Reserved Memory Range
>>>> + //
>>>> + Status = EfiGetSystemConfigurationTable (
>>>> + &gEdkiiPiSmmCommunicationRegionTableGuid,
>>>> + (VOID **) &SmmCommRegionTable
>>>> + );
>>>> + if (!EFI_ERROR (Status)) {
>>>> + ASSERT (SmmCommRegionTable != NULL);
>>>> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) (SmmCommRegionTable + 1);
>>>> + for (Index = 0; Index < SmmCommRegionTable->NumberOfEntries; Index ++) {
>>>> + if (SmmCommMemRegion->Type == EfiConventionalMemory) {
>>>> + break;
>>>> + }
>>>> + SmmCommMemRegion = (EFI_MEMORY_DESCRIPTOR *) ((UINT8 *) SmmCommMemRegion + SmmCommRegionTable->DescriptorSize);
>>>> + }
>>>> + ASSERT (Index < SmmCommRegionTable->NumberOfEntries);
>>>> + ASSERT (SmmCommMemRegion->PhysicalStart > 0);
>>>> + ASSERT (SmmCommMemRegion->NumberOfPages > 0);
>>>> + ReservedMemSize = (UINTN) SmmCommMemRegion->NumberOfPages * EFI_PAGE_SIZE;
>>>> +
>>>> + //
>>>> + // Check enough reserved memory space
>>>> + //
>>>> + if (ReservedMemSize > SMM_BOOT_RECORD_COMM_SIZE) {
>>>> + SmmBootRecordCommBuffer = (VOID *) (UINTN) SmmCommMemRegion->PhysicalStart;
>>>> + SmmCommBufferHeader = (EFI_SMM_COMMUNICATE_HEADER*)SmmBootRecordCommBuffer;
>>>> + SmmCommData = (SMM_BOOT_RECORD_COMMUNICATE*)SmmCommBufferHeader->Data;
>>>> + ZeroMem((UINT8*)SmmCommData, sizeof(SMM_BOOT_RECORD_COMMUNICATE));
>>>> +
>>>> + CopyGuid (&SmmCommBufferHeader->HeaderGuid, &gEfiFirmwarePerformanceGuid);
>>>> + SmmCommBufferHeader->MessageLength = sizeof(SMM_BOOT_RECORD_COMMUNICATE);
>>>> + CommSize = SMM_BOOT_RECORD_COMM_SIZE;
>>>> +
>>>> + //
>>>> + // Get the size of boot records.
>>>> + //
>>>> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_SIZE;
>>>> + SmmCommData->BootRecordData = NULL;
>>>> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
>>>> + ASSERT_EFI_ERROR (Status);
>>>> +
>>>> + if (!EFI_ERROR (SmmCommData->ReturnStatus) && SmmCommData->BootRecordSize != 0) {
>>>> + //
>>>> + // Get all boot records
>>>> + //
>>>> + SmmCommData->Function = SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
>>>> + SmmBootRecordDataSize = SmmCommData->BootRecordSize;
>>>> + SmmBootRecordData = AllocateZeroPool(SmmBootRecordDataSize);
>>>> + ASSERT (SmmBootRecordData != NULL);
>>>> + SmmCommData->BootRecordOffset = 0;
>>>> + SmmCommData->BootRecordData = (VOID *) ((UINTN) SmmCommMemRegion->PhysicalStart + SMM_BOOT_RECORD_COMM_SIZE);
>>>> + SmmCommData->BootRecordSize = ReservedMemSize - SMM_BOOT_RECORD_COMM_SIZE;
>>>> + while (SmmCommData->BootRecordOffset < SmmBootRecordDataSize) {
>>>> + Status = Communication->Communicate (Communication, SmmBootRecordCommBuffer, &CommSize);
>>>> + ASSERT_EFI_ERROR (Status);
>>>> + ASSERT_EFI_ERROR(SmmCommData->ReturnStatus);
>>>> + if (SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize > SmmBootRecordDataSize) {
>>>> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmBootRecordDataSize - SmmCommData->BootRecordOffset);
>>>> + } else {
>>>> + CopyMem ((UINT8 *) SmmBootRecordData + SmmCommData->BootRecordOffset, SmmCommData->BootRecordData, SmmCommData->BootRecordSize);
>>>> + }
>>>> + SmmCommData->BootRecordOffset = SmmCommData->BootRecordOffset + SmmCommData->BootRecordSize;
>>>> + }
>>>> + }
>>>> + }
>>>> + }
>>>> + }
>>>> +
>>>> + //
>>>> + // Prepare memory for Boot Performance table.
>>>> + // Boot Performance table includes BasicBoot record, and one or more appended Boot Records.
>>>> + //
>>>> + BootPerformanceDataSize = sizeof (BOOT_PERFORMANCE_TABLE) + mPerformanceLength + PcdGet32 (PcdExtFpdtBootRecordPadSize);
>>>> + if (SmmCommData != NULL) {
>>>> + BootPerformanceDataSize += SmmBootRecordDataSize;
>>>> + }
>>>> +
>>>> + //
>>>> + // Try to allocate the same runtime buffer as last time boot.
>>>> + //
>>>> + ZeroMem (&PerformanceVariable, sizeof (PerformanceVariable));
>>>> + Size = sizeof (PerformanceVariable);
>>>> + Status = gRT->GetVariable (
>>>> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
>>>> + &gEfiFirmwarePerformanceGuid,
>>>> + NULL,
>>>> + &Size,
>>>> + &PerformanceVariable
>>>> + );
>>>> + if (!EFI_ERROR (Status)) {
>>>> + Status = gBS->AllocatePages (
>>>> + AllocateAddress,
>>>> + EfiReservedMemoryType,
>>>> + EFI_SIZE_TO_PAGES (BootPerformanceDataSize),
>>>> + &PerformanceVariable.BootPerformanceTablePointer
>>>> + );
>>>> + if (!EFI_ERROR (Status)) {
>>>> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) (UINTN) PerformanceVariable.BootPerformanceTablePointer;
>>>> + }
>>>> + }
>>>> +
>>>> + if (mAcpiBootPerformanceTable == NULL) {
>>>> + //
>>>> + // Fail to allocate at specified address, continue to allocate at any address.
>>>> + //
>>>> + mAcpiBootPerformanceTable = (BOOT_PERFORMANCE_TABLE *) FpdtAllocateReservedMemoryBelow4G (BootPerformanceDataSize);
>>>
>>> Why does this allocation need to live below 4 GB?
>>>
>>> If there is no good reason, can we please get rid of this?
>>> If there is a good reason, can we please document it in the code?
>>>
>>>> + }
>>>> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: ACPI Boot Performance Table address = 0x%x\n", mAcpiBootPerformanceTable));
>>>> +
>>>> + if (mAcpiBootPerformanceTable == NULL) {
>>>> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
>>>> + FreePool (SmmBootRecordData);
>>>> + }
>>>> + return EFI_OUT_OF_RESOURCES;
>>>> + }
>>>> +
>>>> + //
>>>> + // Prepare Boot Performance Table.
>>>> + //
>>>> + BootPerformanceData = (UINT8 *) mAcpiBootPerformanceTable;
>>>> + //
>>>> + // Fill Basic Boot record to Boot Performance Table.
>>>> + //
>>>> + CopyMem (mAcpiBootPerformanceTable, &mBootPerformanceTableTemplate, sizeof (mBootPerformanceTableTemplate));
>>>> + BootPerformanceData = BootPerformanceData + mAcpiBootPerformanceTable->Header.Length;
>>>> + //
>>>> + // Fill Boot records from boot drivers.
>>>> + //
>>>> + if (mPerformancePointer != NULL) {
>>>> + CopyMem (BootPerformanceData, mPerformancePointer, mPerformanceLength);
>>>> + mAcpiBootPerformanceTable->Header.Length += mPerformanceLength;
>>>> + BootPerformanceData = BootPerformanceData + mPerformanceLength;
>>>> + }
>>>> + if (SmmCommData != NULL && SmmBootRecordData != NULL) {
>>>> + //
>>>> + // Fill Boot records from SMM drivers.
>>>> + //
>>>> + CopyMem (BootPerformanceData, SmmBootRecordData, SmmBootRecordDataSize);
>>>> + FreePool (SmmBootRecordData);
>>>> + mAcpiBootPerformanceTable->Header.Length = (UINT32) (mAcpiBootPerformanceTable->Header.Length + SmmBootRecordDataSize);
>>>> + BootPerformanceData = BootPerformanceData + SmmBootRecordDataSize;
>>>> + }
>>>> +
>>>> + //
>>>> + // Save Boot Performance Table address to Variable for use in S4 resume.
>>>> + //
>>>> + PerformanceVariable.BootPerformanceTablePointer = (EFI_PHYSICAL_ADDRESS) (UINTN) mAcpiBootPerformanceTable;
>>>> +
>>>> + //
>>>> + // Save Runtime Performance Table pointers to Variable.
>>>> + // Don't check SetVariable return status. It doesn't impact FPDT table generation.
>>>> + //
>>>> + gRT->SetVariable (
>>>> + EFI_FIRMWARE_PERFORMANCE_VARIABLE_NAME,
>>>> + &gEfiFirmwarePerformanceGuid,
>>>> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
>>>> + sizeof (PerformanceVariable),
>>>> + &PerformanceVariable
>>>> + );
>>>> +
>>>> + mBootRecordBuffer = (UINT8 *) mAcpiBootPerformanceTable;
>>>> + mBootRecordSize = mAcpiBootPerformanceTable->Header.Length;
>>>> + mBootRecordMaxSize = mBootRecordSize + PcdGet32 (PcdExtFpdtBootRecordPadSize);
>>>> +
>>>> + return EFI_SUCCESS;
>>>> +}
>>>> +
>>>> +/**
>>>> + Get a human readable module name and module guid for the given image handle.
>>>> + If module name can't be found, "" string will return.
>>>> + If module guid can't be found, Zero Guid will return.
>>>> +
>>>> + @param Handle Image handle or Controller handle.
>>>> + @param NameString The ascii string will be filled into it. If not found, null string will return.
>>>> + @param BufferSize Size of the input NameString buffer.
>>>> + @param ModuleGuid Point to the guid buffer to store the got module guid value.
>>>> +
>>>> + @retval EFI_SUCCESS Successfully get module name and guid.
>>>> + @retval EFI_INVALID_PARAMETER The input parameter NameString is NULL.
>>>> + @retval other value Module Name can't be got.
>>>> +**/
>>>> +EFI_STATUS
>>>> +GetModuleInfoFromHandle (
>>>> + IN EFI_HANDLE Handle,
>>>> + OUT CHAR8 *NameString,
>>>> + IN UINTN BufferSize,
>>>> + OUT EFI_GUID *ModuleGuid OPTIONAL
>>>> + )
>>>> +{
>>>> + EFI_STATUS Status;
>>>> + EFI_LOADED_IMAGE_PROTOCOL *LoadedImage;
>>>> + EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
>>>> + CHAR8 *PdbFileName;
>>>> + EFI_GUID *TempGuid;
>>>> + UINTN StartIndex;
>>>> + UINTN Index;
>>>> + INTN Count;
>>>> + BOOLEAN ModuleGuidIsGet;
>>>> + UINTN StringSize;
>>>> + CHAR16 *StringPtr;
>>>> + EFI_COMPONENT_NAME2_PROTOCOL *ComponentName2;
>>>> + MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *FvFilePath;
>>>> +
>>>> + if (NameString == NULL || BufferSize == 0) {
>>>> + return EFI_INVALID_PARAMETER;
>>>> + }
>>>> + //
>>>> + // Try to get the ModuleGuid and name string form the caached array.
>>>> + //
>>>> + if (mCachePairCount > 0) {
>>>> + for (Count = mCachePairCount -1; Count >= 0; Count--) {
>>>> + if (Handle == mCacheHandleGuidTable[Count].Handle) {
>>>> + CopyGuid (ModuleGuid, &mCacheHandleGuidTable[Count].ModuleGuid);
>>>> + AsciiStrCpyS (NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, mCacheHandleGuidTable[Count].NameString);
>>>> + return EFI_SUCCESS;
>>>> + }
>>>> + }
>>>> + }
>>>> +
>>>> + Status = EFI_INVALID_PARAMETER;
>>>> + LoadedImage = NULL;
>>>> + ModuleGuidIsGet = FALSE;
>>>> +
>>>> + //
>>>> + // Initialize GUID as zero value.
>>>> + //
>>>> + TempGuid = &gZeroGuid;
>>>> + //
>>>> + // Initialize it as "" string.
>>>> + //
>>>> + NameString[0] = 0;
>>>> +
>>>> + if (Handle != NULL) {
>>>> + //
>>>> + // Try Handle as ImageHandle.
>>>> + //
>>>> + Status = gBS->HandleProtocol (
>>>> + Handle,
>>>> + &gEfiLoadedImageProtocolGuid,
>>>> + (VOID**) &LoadedImage
>>>> + );
>>>> +
>>>> + if (EFI_ERROR (Status)) {
>>>> + //
>>>> + // Try Handle as Controller Handle
>>>> + //
>>>> + Status = gBS->OpenProtocol (
>>>> + Handle,
>>>> + &gEfiDriverBindingProtocolGuid,
>>>> + (VOID **) &DriverBinding,
>>>> + NULL,
>>>> + NULL,
>>>> + EFI_OPEN_PROTOCOL_GET_PROTOCOL
>>>> + );
>>>> + if (!EFI_ERROR (Status)) {
>>>> + //
>>>> + // Get Image protocol from ImageHandle
>>>> + //
>>>> + Status = gBS->HandleProtocol (
>>>> + DriverBinding->ImageHandle,
>>>> + &gEfiLoadedImageProtocolGuid,
>>>> + (VOID**) &LoadedImage
>>>> + );
>>>> + }
>>>> + }
>>>> + }
>>>> +
>>>> + if (!EFI_ERROR (Status) && LoadedImage != NULL) {
>>>> + //
>>>> + // Get Module Guid from DevicePath.
>>>> + //
>>>> + if (LoadedImage->FilePath != NULL &&
>>>> + LoadedImage->FilePath->Type == MEDIA_DEVICE_PATH &&
>>>> + LoadedImage->FilePath->SubType == MEDIA_PIWG_FW_FILE_DP
>>>> + ) {
>>>> + //
>>>> + // Determine GUID associated with module logging performance
>>>> + //
>>>> + ModuleGuidIsGet = TRUE;
>>>> + FvFilePath = (MEDIA_FW_VOL_FILEPATH_DEVICE_PATH *) LoadedImage->FilePath;
>>>> + TempGuid = &FvFilePath->FvFileName;
>>>> + }
>>>> +
>>>> + //
>>>> + // Method 1 Get Module Name from PDB string.
>>>> + //
>>>> + PdbFileName = PeCoffLoaderGetPdbPointer (LoadedImage->ImageBase);
>>>> + if (PdbFileName != NULL && BufferSize > 0) {
>>>> + StartIndex = 0;
>>>> + for (Index = 0; PdbFileName[Index] != 0; Index++) {
>>>> + if ((PdbFileName[Index] == '\\') || (PdbFileName[Index] == '/')) {
>>>> + StartIndex = Index + 1;
>>>> + }
>>>> + }
>>>> + //
>>>> + // Copy the PDB file name to our temporary string.
>>>> + // If the length is bigger than BufferSize, trim the redudant characters to avoid overflow in array boundary.
>>>> + //
>>>> + for (Index = 0; Index < BufferSize - 1; Index++) {
>>>> + NameString[Index] = PdbFileName[Index + StartIndex];
>>>> + if (NameString[Index] == 0 || NameString[Index] == '.') {
>>>> + NameString[Index] = 0;
>>>> + break;
>>>> + }
>>>> + }
>>>>
>>>> - This internal function searches for the gauge entry in the gauge array.
>>>> - If there is an entry that exactly matches the given keywords
>>>> - and its end time stamp is zero, then the index of that gauge entry is returned;
>>>> - otherwise, the the number of gauge entries in the array is returned.
>>>> + if (Index == BufferSize - 1) {
>>>> + NameString[Index] = 0;
>>>> + }
>>>> + //
>>>> + // Module Name is got.
>>>> + //
>>>> + goto Done;
>>>> + }
>>>> + }
>>>>
>>>> + //
>>>> + // Method 2: Get the name string from ComponentName2 protocol
>>>> + //
>>>> + Status = gBS->HandleProtocol (
>>>> + Handle,
>>>> + &gEfiComponentName2ProtocolGuid,
>>>> + (VOID **) &ComponentName2
>>>> + );
>>>> + if (!EFI_ERROR (Status)) {
>>>> + //
>>>> + // Get the current platform language setting
>>>> + //
>>>> + if (mPlatformLanguage == NULL) {
>>>> + GetEfiGlobalVariable2 (L"PlatformLang", (VOID **) &mPlatformLanguage, NULL);
>>>> + }
>>>> + if (mPlatformLanguage != NULL) {
>>>> + Status = ComponentName2->GetDriverName (
>>>> + ComponentName2,
>>>> + mPlatformLanguage != NULL ? mPlatformLanguage : "en-US",
>>>> + &StringPtr
>>>> + );
>>>> + if (!EFI_ERROR (Status)) {
>>>> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
>>>> + NameString[Index] = (CHAR8) StringPtr[Index];
>>>> + }
>>>> + NameString[Index] = 0;
>>>> + //
>>>> + // Module Name is got.
>>>> + //
>>>> + goto Done;
>>>> + }
>>>> + }
>>>> + }
>>>> +
>>>> + if (ModuleGuidIsGet) {
>>>> + //
>>>> + // Method 3 Try to get the image's FFS UI section by image GUID
>>>> + //
>>>> + StringPtr = NULL;
>>>> + StringSize = 0;
>>>> + Status = GetSectionFromAnyFv (
>>>> + TempGuid,
>>>> + EFI_SECTION_USER_INTERFACE,
>>>> + 0,
>>>> + (VOID **) &StringPtr,
>>>> + &StringSize
>>>> + );
>>>> +
>>>> + if (!EFI_ERROR (Status)) {
>>>> + //
>>>> + // Method 3. Get the name string from FFS UI section
>>>> + //
>>>> + for (Index = 0; Index < BufferSize - 1 && StringPtr[Index] != 0; Index++) {
>>>> + NameString[Index] = (CHAR8) StringPtr[Index];
>>>> + }
>>>> + NameString[Index] = 0;
>>>> + FreePool (StringPtr);
>>>> + }
>>>> + }
>>>> +
>>>> +Done:
>>>> + //
>>>> + // Copy Module Guid
>>>> + //
>>>> + if (ModuleGuid != NULL) {
>>>> + CopyGuid (ModuleGuid, TempGuid);
>>>> + if (IsZeroGuid(TempGuid) && (Handle != NULL) && !ModuleGuidIsGet) {
>>>> + // Handle is GUID
>>>> + CopyGuid (ModuleGuid, (EFI_GUID *) Handle);
>>>> + }
>>>> + }
>>>> +
>>>> + //
>>>> + // Cache the Handle and Guid pairs.
>>>> + //
>>>> + if (mCachePairCount < CACHE_HANDLE_GUID_COUNT) {
>>>> + mCacheHandleGuidTable[mCachePairCount].Handle = Handle;
>>>> + CopyGuid (&mCacheHandleGuidTable[mCachePairCount].ModuleGuid, ModuleGuid);
>>>> + AsciiStrCpyS (mCacheHandleGuidTable[mCachePairCount].NameString, EDKII_STRING_EVENT_RECORD_NAME_LENGTH, NameString);
>>>> + mCachePairCount ++;
>>>> + }
>>>> +
>>>> + return Status;
>>>> +}
>>>> +
>>>> +/**
>>>> + Get the FPDT record info.
>>>> +
>>>> + @param IsStart TRUE if the performance log is start log.
>>>> @param Handle Pointer to environment specific context used
>>>> to identify the component being measured.
>>>> @param Token Pointer to a Null-terminated ASCII string
>>>> that identifies the component being measured.
>>>> @param Module Pointer to a Null-terminated ASCII string
>>>> that identifies the module being measured.
>>>> - @param Identifier 32-bit identifier.
>>>> + @param RecordInfo On return, pointer to the info of the record.
>>>> + @param UseModuleName Only useful for DYNAMIC_STRING_EVENT_TYPE, indicate that whether need use
>>>> + Module name to fill the string field in the DYNAMIC_STRING_EVENT_RECORD.
>>>>
>>>> - @retval The index of gauge entry in the array.
>>>> + @retval EFI_SUCCESS Get record info successfully.
>>>> + @retval EFI_UNSUPPORTED No matched FPDT record.
>>>>
>>>> **/
>>>> -UINT32
>>>> -InternalSearchForGaugeEntry (
>>>> - IN CONST VOID *Handle, OPTIONAL
>>>> - IN CONST CHAR8 *Token, OPTIONAL
>>>> - IN CONST CHAR8 *Module, OPTIONAL
>>>> - IN UINT32 Identifier
>>>> +EFI_STATUS
>>>> +GetFpdtRecordInfo (
>>>> + IN BOOLEAN IsStart,
>>>> + IN CONST VOID *Handle,
>>>> + IN CONST CHAR8 *Token,
>>>> + IN CONST CHAR8 *Module,
>>>> + OUT BASIC_RECORD_INFO *RecordInfo,
>>>> + IN OUT BOOLEAN *UseModuleName
>>>> )
>>>> {
>>>> - UINT32 Index;
>>>> - UINT32 Index2;
>>>> - UINT32 NumberOfEntries;
>>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>>> + UINT16 RecordType;
>>>> + UINTN StringSize;
>>>>
>>>> - if (Token == NULL) {
>>>> - Token = "";
>>>> - }
>>>> - if (Module == NULL) {
>>>> - Module = "";
>>>> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
>>>> +
>>>> + //
>>>> + // Token to Type and Id.
>>>> + //
>>>> + if (Token != NULL) {
>>>> + if (AsciiStrCmp (Token, START_IMAGE_TOK) == 0) { // "StartImage:"
>>>> + *UseModuleName = TRUE;
>>>> + RecordType = GUID_EVENT_TYPE;
>>>> + if (IsStart) {
>>>> + RecordInfo->ProgressID = MODULE_START_ID;
>>>> + } else {
>>>> + RecordInfo->ProgressID = MODULE_END_ID;
>>>> + }
>>>> + } else if (AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) { // "LoadImage:"
>>>> + *UseModuleName = TRUE;
>>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>>> + if (IsStart) {
>>>> + RecordInfo->ProgressID = MODULE_LOADIMAGE_START_ID;
>>>> + } else {
>>>> + RecordInfo->ProgressID = MODULE_LOADIMAGE_END_ID;
>>>> + }
>>>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_START_TOK) == 0) { // "DB:Start:"
>>>> + *UseModuleName = TRUE;
>>>> + if (IsStart) {
>>>> + RecordInfo->ProgressID = MODULE_DB_START_ID;
>>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>>> + } else {
>>>> + RecordInfo->ProgressID = MODULE_DB_END_ID;
>>>> + RecordType = GUID_QWORD_STRING_EVENT_TYPE;
>>>> + }
>>>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_SUPPORT_TOK) == 0) { // "DB:Support:"
>>>> + *UseModuleName = TRUE;
>>>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>>>> + return RETURN_UNSUPPORTED;
>>>> + }
>>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>>> + if (IsStart) {
>>>> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_START_ID;
>>>> + } else {
>>>> + RecordInfo->ProgressID = MODULE_DB_SUPPORT_END_ID;
>>>> + }
>>>> + } else if (AsciiStrCmp (Token, DRIVERBINDING_STOP_TOK) == 0) { // "DB:Stop:"
>>>> + *UseModuleName = TRUE;
>>>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>>>> + return RETURN_UNSUPPORTED;
>>>> + }
>>>> + RecordType = GUID_QWORD_EVENT_TYPE;
>>>> + if (IsStart) {
>>>> + RecordInfo->ProgressID = MODULE_DB_STOP_START_ID;
>>>> + } else {
>>>> + RecordInfo->ProgressID = MODULE_DB_STOP_END_ID;
>>>> + }
>>>> + } else if (AsciiStrCmp (Token, PEI_TOK) == 0 || // "PEI"
>>>> + AsciiStrCmp (Token, DXE_TOK) == 0 || // "DXE"
>>>> + AsciiStrCmp (Token, BDS_TOK) == 0) { // "BDS"
>>>> + if (IsStart) {
>>>> + RecordInfo->ProgressID = PERF_CROSSMODULE_START_ID;
>>>> + } else {
>>>> + RecordInfo->ProgressID = PERF_CROSSMODULE_END_ID;
>>>> + }
>>>> + } else { // Pref used in Modules.
>>>> + if (IsStart) {
>>>> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
>>>> + } else {
>>>> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
>>>> + }
>>>> + }
>>>> + } else if (Handle!= NULL || Module != NULL) { // Pref used in Modules.
>>>> + if (IsStart) {
>>>> + RecordInfo->ProgressID = PERF_INMODULE_START_ID;
>>>> + } else {
>>>> + RecordInfo->ProgressID = PERF_INMODULE_END_ID;
>>>> + }
>>>> + } else {
>>>> + return EFI_UNSUPPORTED;
>>>> }
>>>>
>>>> - NumberOfEntries = mGaugeData->NumberOfEntries;
>>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>>> + //
>>>> + // Get Record size baesed on the record type.
>>>> + // When PcdEdkiiFpdtStringRecordEnableOnly is TRUE, all records are with type of DYNAMIC_STRING_EVENT_TYPE.
>>>> + //
>>>> + if (PcdGetBool (PcdEdkiiFpdtStringRecordEnableOnly)) {
>>>> + RecordType = DYNAMIC_STRING_EVENT_TYPE;
>>>> + RecordInfo->RecordSize = sizeof (DYNAMIC_STRING_EVENT_RECORD) + STRING_SIZE;
>>>> + } else {
>>>> + switch (RecordType) {
>>>> + case GUID_EVENT_TYPE:
>>>> + RecordInfo->RecordSize = sizeof (GUID_EVENT_RECORD);
>>>> + break;
>>>>
>>>> - Index2 = 0;
>>>> + case DYNAMIC_STRING_EVENT_TYPE:
>>>> + if (*UseModuleName) {
>>>> + StringSize = STRING_SIZE;
>>>> + } else if (Token != NULL) {
>>>> + StringSize = AsciiStrSize (Token);
>>>> + } else if (Module != NULL) {
>>>> + StringSize = AsciiStrSize (Module);
>>>> + } else {
>>>> + StringSize = STRING_SIZE;
>>>> + }
>>>> + if (StringSize > STRING_SIZE) {
>>>> + StringSize = STRING_SIZE;
>>>> + }
>>>> + RecordInfo->RecordSize = (UINT8)(sizeof (DYNAMIC_STRING_EVENT_RECORD) + StringSize);
>>>> + break;
>>>>
>>>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>>>> - Index2 = NumberOfEntries - 1 - Index;
>>>> - if (GaugeEntryExArray[Index2].EndTimeStamp == 0 &&
>>>> - (GaugeEntryExArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&
>>>> - AsciiStrnCmp (GaugeEntryExArray[Index2].Token, Token, DXE_PERFORMANCE_STRING_LENGTH) == 0 &&
>>>> - AsciiStrnCmp (GaugeEntryExArray[Index2].Module, Module, DXE_PERFORMANCE_STRING_LENGTH) == 0) {
>>>> - Index = Index2;
>>>> + case GUID_QWORD_EVENT_TYPE:
>>>> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_EVENT_RECORD);
>>>> break;
>>>> +
>>>> + case GUID_QWORD_STRING_EVENT_TYPE:
>>>> + RecordInfo->RecordSize = (UINT8)sizeof (GUID_QWORD_STRING_EVENT_RECORD);
>>>> + break;
>>>> +
>>>> + default:
>>>> + //
>>>> + // Record is unsupported yet, return EFI_UNSUPPORTED
>>>> + //
>>>> + return EFI_UNSUPPORTED;
>>>> }
>>>> }
>>>>
>>>> - return Index;
>>>> + RecordInfo->Type = RecordType;
>>>> + return EFI_SUCCESS;
>>>> }
>>>>
>>>> /**
>>>> - Adds a record at the end of the performance measurement log
>>>> - that records the start time of a performance measurement.
>>>> -
>>>> - Adds a record to the end of the performance measurement log
>>>> - that contains the Handle, Token, Module and Identifier.
>>>> - The end time of the new record must be set to zero.
>>>> - If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
>>>> - If TimeStamp is zero, the start time in the record is filled in with the value
>>>> - read from the current time stamp.
>>>> + Add performance log to FPDT boot record table.
>>>>
>>>> + @param IsStart TRUE if the performance log is start log.
>>>> @param Handle Pointer to environment specific context used
>>>> to identify the component being measured.
>>>> @param Token Pointer to a Null-terminated ASCII string
>>>> that identifies the component being measured.
>>>> @param Module Pointer to a Null-terminated ASCII string
>>>> that identifies the module being measured.
>>>> - @param TimeStamp 64-bit time stamp.
>>>> + @param Ticker 64-bit time stamp.
>>>> @param Identifier 32-bit identifier. If the value is 0, the created record
>>>> is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>>>>
>>>> - @retval EFI_SUCCESS The data was read correctly from the device.
>>>> + @retval EFI_SUCCESS Add FPDT boot record.
>>>> @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>>>> + @retval EFI_UNSUPPORTED No matched FPDT record.
>>>>
>>>> **/
>>>> EFI_STATUS
>>>> -EFIAPI
>>>> -StartGaugeEx (
>>>> +InsertFpdtMeasurement (
>>>> + IN BOOLEAN IsStart,
>>>> IN CONST VOID *Handle, OPTIONAL
>>>> IN CONST CHAR8 *Token, OPTIONAL
>>>> IN CONST CHAR8 *Module, OPTIONAL
>>>> - IN UINT64 TimeStamp,
>>>> + IN UINT64 Ticker,
>>>> IN UINT32 Identifier
>>>> )
>>>> {
>>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>>> - UINTN GaugeDataSize;
>>>> - GAUGE_DATA_HEADER *NewGaugeData;
>>>> - UINTN OldGaugeDataSize;
>>>> - GAUGE_DATA_HEADER *OldGaugeData;
>>>> - UINT32 Index;
>>>> - EFI_STATUS Status;
>>>> + EFI_GUID ModuleGuid;
>>>> + CHAR8 ModuleName[EDKII_STRING_EVENT_RECORD_NAME_LENGTH];
>>>> + UINT8 FpdtRecord[MAX_RECORD_SIZE];
>>>> + EFI_STATUS Status;
>>>> + FPDT_RECORD_PTR FpdtRecordPtr;
>>>> + BASIC_RECORD_INFO RecordInfo;
>>>> + UINT64 TimeStamp;
>>>> + UINTN DestMax;
>>>> + UINTN StrLength;
>>>> + CONST CHAR8 *StringPtr;
>>>> + BOOLEAN UseModuleName;
>>>> +
>>>> + StringPtr = NULL;
>>>> + UseModuleName = FALSE;
>>>> + ZeroMem (ModuleName, sizeof (ModuleName));
>>>> + ZeroMem (FpdtRecord, sizeof (FpdtRecord));
>>>>
>>>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>>>> + //
>>>> + // Get record info (type, size, ProgressID and Module Guid).
>>>> + //
>>>> + Status = GetFpdtRecordInfo (IsStart, Handle, Token, Module, &RecordInfo, &UseModuleName);
>>>> if (EFI_ERROR (Status)) {
>>>> return Status;
>>>> }
>>>>
>>>> - Index = mGaugeData->NumberOfEntries;
>>>> - if (Index >= mMaxGaugeRecords) {
>>>> + //
>>>> + // If PERF_START()/PERF_END() have specified the ProgressID,it has high priority.
>>>> + // !!! Note: If the Pref is not the known Token used in the core but have same
>>>> + // ID with the core Token, this case will not be supported.
>>>> + // And in currtnt usage mode, for the unkown ID, there is a general rule:
>>>> + // If it is start pref: the lower 4 bits of the ID should be 0.
>>>> + // If it is end pref: the lower 4 bits of the ID should not be 0.
>>>> + // If input ID doesn't follow the rule, we will adjust it.
>>>> + //
>>>> + if ((Identifier != 0) && (IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
>>>> + return EFI_UNSUPPORTED;
>>>> + } else if ((Identifier != 0) && (!IsKnownID (Identifier)) && (!IsKnownTokens (Token))) {
>>>> + if (IsStart && ((Identifier & 0x000F) != 0)) {
>>>> + Identifier &= 0xFFF0;
>>>> + } else if ((!IsStart) && ((Identifier & 0x000F) == 0)) {
>>>> + Identifier += 1;
>>>> + }
>>>> + RecordInfo.ProgressID = (UINT16)Identifier;
>>>> + }
>>>> +
>>>> + if (mFpdtBufferIsReported) {
>>>> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)FpdtRecord;
>>>> + } else {
>>>> + //
>>>> + // Check if pre-allocated buffer is full
>>>> //
>>>> - // Try to enlarge the scale of gauge array.
>>>> + if (mPerformanceLength + RecordInfo.RecordSize > mMaxPerformanceLength) {
>>>> + mPerformancePointer = ReallocatePool (
>>>> + mPerformanceLength,
>>>> + mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER,
>>>> + mPerformancePointer
>>>> + );
>>>> +
>>>> + if (mPerformancePointer == NULL) {
>>>> + return EFI_OUT_OF_RESOURCES;
>>>> + }
>>>> + mMaxPerformanceLength = mPerformanceLength + RecordInfo.RecordSize + FIRMWARE_RECORD_BUFFER;
>>>> + }
>>>> //
>>>> - OldGaugeData = mGaugeData;
>>>> - OldGaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords;
>>>> + // Covert buffer to FPDT Ptr Union type.
>>>> + //
>>>> + FpdtRecordPtr.RecordHeader = (EFI_ACPI_5_0_FPDT_PERFORMANCE_RECORD_HEADER *)(mPerformancePointer + mPerformanceLength);
>>>> + }
>>>> + FpdtRecordPtr.RecordHeader->Length = 0;
>>>>
>>>> - GaugeDataSize = sizeof (GAUGE_DATA_HEADER) + sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords * 2;
>>>> + //
>>>> + // Get the TimeStamp.
>>>> + //
>>>> + if (Ticker == 0) {
>>>> + Ticker = GetPerformanceCounter ();
>>>> + TimeStamp = GetTimeInNanoSecond (Ticker);
>>>> + } else if (Ticker == 1) {
>>>> + TimeStamp = 0;
>>>> + } else {
>>>> + TimeStamp = GetTimeInNanoSecond (Ticker);
>>>> + }
>>>>
>>>> - NewGaugeData = AllocateZeroPool (GaugeDataSize);
>>>> - if (NewGaugeData == NULL) {
>>>> - EfiReleaseLock (&mPerfRecordLock);
>>>> - return EFI_OUT_OF_RESOURCES;
>>>> + //
>>>> + // Get the ModuleName and ModuleGuid form the handle.
>>>> + //
>>>> + GetModuleInfoFromHandle ((EFI_HANDLE *)Handle, ModuleName, sizeof (ModuleName), &ModuleGuid);
>>>> +
>>>> + //
>>>> + // Fill in the record information.
>>>> + //
>>>> + switch (RecordInfo.Type) {
>>>> + case GUID_EVENT_TYPE:
>>>> + FpdtRecordPtr.GuidEvent->Header.Type = GUID_EVENT_TYPE;
>>>> + FpdtRecordPtr.GuidEvent->Header.Length = RecordInfo.RecordSize;
>>>> + FpdtRecordPtr.GuidEvent->Header.Revision = RECORD_REVISION_1;
>>>> + FpdtRecordPtr.GuidEvent->ProgressID = RecordInfo.ProgressID;
>>>> + FpdtRecordPtr.GuidEvent->Timestamp = TimeStamp;
>>>> + CopyMem (&FpdtRecordPtr.GuidEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidEvent->Guid));
>>>> + break;
>>>> +
>>>> + case DYNAMIC_STRING_EVENT_TYPE:
>>>> + FpdtRecordPtr.DynamicStringEvent->Header.Type = DYNAMIC_STRING_EVENT_TYPE;
>>>> + FpdtRecordPtr.DynamicStringEvent->Header.Length = RecordInfo.RecordSize;
>>>> + FpdtRecordPtr.DynamicStringEvent->Header.Revision = RECORD_REVISION_1;
>>>> + FpdtRecordPtr.DynamicStringEvent->ProgressID = RecordInfo.ProgressID;
>>>> + FpdtRecordPtr.DynamicStringEvent->Timestamp = TimeStamp;
>>>> + CopyMem (&FpdtRecordPtr.DynamicStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.DynamicStringEvent->Guid));
>>>> +
>>>> + if (UseModuleName) {
>>>> + StringPtr = ModuleName;
>>>> + } else if (Token != NULL) {
>>>> + StringPtr = Token;
>>>> + } else if (Module != NULL) {
>>>> + StringPtr = Module;
>>>> + } else if (ModuleName != NULL) {
>>>> + StringPtr = ModuleName;
>>>> + }
>>>> + if (StringPtr != NULL && AsciiStrLen (StringPtr) != 0) {
>>>> + StrLength = AsciiStrLen (StringPtr);
>>>> + DestMax = (RecordInfo.RecordSize - sizeof (DYNAMIC_STRING_EVENT_RECORD)) / sizeof (CHAR8);
>>>> + if (StrLength >= DestMax) {
>>>> + StrLength = DestMax -1;
>>>> + }
>>>> + AsciiStrnCpyS (FpdtRecordPtr.DynamicStringEvent->String, DestMax, StringPtr, StrLength);
>>>> }
>>>> + break;
>>>> +
>>>> + case GUID_QWORD_EVENT_TYPE:
>>>> + FpdtRecordPtr.GuidQwordEvent->Header.Type = GUID_QWORD_EVENT_TYPE;
>>>> + FpdtRecordPtr.GuidQwordEvent->Header.Length = RecordInfo.RecordSize;
>>>> + FpdtRecordPtr.GuidQwordEvent->Header.Revision = RECORD_REVISION_1;
>>>> + FpdtRecordPtr.GuidQwordEvent->ProgressID = RecordInfo.ProgressID;
>>>> + FpdtRecordPtr.GuidQwordEvent->Timestamp = TimeStamp;
>>>> + CopyMem (&FpdtRecordPtr.GuidQwordEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordEvent->Guid));
>>>> + if ((MODULE_LOADIMAGE_START_ID == RecordInfo.ProgressID) && AsciiStrCmp (Token, LOAD_IMAGE_TOK) == 0) {
>>>> + mLoadImageCount++;
>>>> + FpdtRecordPtr.GuidQwordEvent->Qword = mLoadImageCount;
>>>> + }
>>>> + break;
>>>> +
>>>> + case GUID_QWORD_STRING_EVENT_TYPE:
>>>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Type = GUID_QWORD_STRING_EVENT_TYPE;
>>>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Length = RecordInfo.RecordSize;
>>>> + FpdtRecordPtr.GuidQwordStringEvent->Header.Revision = RECORD_REVISION_1;
>>>> + FpdtRecordPtr.GuidQwordStringEvent->ProgressID = RecordInfo.ProgressID;
>>>> + FpdtRecordPtr.GuidQwordStringEvent->Timestamp = TimeStamp;
>>>> + CopyMem (&FpdtRecordPtr.GuidQwordStringEvent->Guid, &ModuleGuid, sizeof (FpdtRecordPtr.GuidQwordStringEvent->Guid));
>>>> + break;
>>>> +
>>>> + default:
>>>> + //
>>>> + // Record is not supported in current DXE phase, return EFI_ABORTED
>>>> + //
>>>> + return EFI_UNSUPPORTED;
>>>> + }
>>>> +
>>>> + //
>>>> + // Report record one by one after records have been reported together.
>>>> + //
>>>> + if (mFpdtBufferIsReported) {
>>>> + //
>>>> + // Append Boot records to the boot performance table.
>>>> + //
>>>> + if (mBootRecordSize + FpdtRecordPtr.RecordHeader->Length > mBootRecordMaxSize) {
>>>> + if (!mLackSpaceIsReported) {
>>>> + DEBUG ((DEBUG_INFO, "DxeCorePerformanceLib: No enough space to save boot records\n"));
>>>> + mLackSpaceIsReported = TRUE;
>>>> + }
>>>> + return EFI_OUT_OF_RESOURCES;
>>>> + } else {
>>>> + //
>>>> + // Save boot record into BootPerformance table
>>>> + //
>>>> + CopyMem (mBootRecordBuffer + mBootRecordSize, FpdtRecordPtr.RecordHeader, FpdtRecordPtr.RecordHeader->Length);
>>>> + mBootRecordSize += FpdtRecordPtr.RecordHeader->Length;
>>>> + mAcpiBootPerformanceTable->Header.Length += FpdtRecordPtr.RecordHeader->Length;
>>>> + }
>>>> + } else {
>>>> + //
>>>> + // Update the cached FPDT record buffer.
>>>> + //
>>>> + mPerformanceLength += FpdtRecordPtr.RecordHeader->Length;
>>>> + }
>>>> +
>>>> + return EFI_SUCCESS;
>>>> +}
>>>> +
>>>> +/**
>>>> + Dumps all the PEI performance.
>>>> +
>>>> + @param HobStart A pointer to a Guid.
>>>>
>>>> - mGaugeData = NewGaugeData;
>>>> - mMaxGaugeRecords *= 2;
>>>> + This internal function dumps all the PEI performance log to the DXE performance gauge array.
>>>> + It retrieves the optional GUID HOB for PEI performance and then saves the performance data
>>>> + to DXE performance data structures.
>>>>
>>>> +**/
>>>> +VOID
>>>> +InternalGetPeiPerformance (
>>>> + VOID *HobStart
>>>> + )
>>>> +{
>>>> + UINT8 *FirmwarePerformanceHob;
>>>> + PEI_EXT_FIRMWARE_PERF_HEADER *PeiPerformanceLogHeader;
>>>> + UINT8 *EventRec;
>>>> + EFI_HOB_GUID_TYPE *GuidHob;
>>>> +
>>>> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, HobStart);
>>>> + while (GuidHob != NULL) {
>>>> + FirmwarePerformanceHob = GET_GUID_HOB_DATA (GuidHob);
>>>> + PeiPerformanceLogHeader = (PEI_EXT_FIRMWARE_PERF_HEADER *)FirmwarePerformanceHob;
>>>> +
>>>> + if (mPerformanceLength + PeiPerformanceLogHeader->SizeOfAllEntries > mMaxPerformanceLength) {
>>>> + mPerformancePointer = ReallocatePool (
>>>> + mPerformanceLength,
>>>> + mPerformanceLength +
>>>> + (UINTN)PeiPerformanceLogHeader->SizeOfAllEntries +
>>>> + FIRMWARE_RECORD_BUFFER,
>>>> + mPerformancePointer
>>>> + );
>>>> + ASSERT (mPerformancePointer != NULL);
>>>> + mMaxPerformanceLength = mPerformanceLength +
>>>> + (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries) +
>>>> + FIRMWARE_RECORD_BUFFER;
>>>> + }
>>>> +
>>>> + EventRec = mPerformancePointer + mPerformanceLength;
>>>> + CopyMem (EventRec, FirmwarePerformanceHob + sizeof (PEI_EXT_FIRMWARE_PERF_HEADER), (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries));
>>>> //
>>>> - // Initialize new data array and migrate old data one.
>>>> + // Update the used buffer size.
>>>> //
>>>> - mGaugeData = CopyMem (mGaugeData, OldGaugeData, OldGaugeDataSize);
>>>> + mPerformanceLength += (UINTN)(PeiPerformanceLogHeader->SizeOfAllEntries);
>>>> + mLoadImageCount += PeiPerformanceLogHeader->LoadImageCount;
>>>>
>>>> - FreePool (OldGaugeData);
>>>> + //
>>>> + // Get next performance guid hob
>>>> + //
>>>> + GuidHob = GetNextGuidHob (&gEdkiiExtendedFirmwarePerformanceGuid, GET_NEXT_HOB (GuidHob));
>>>> }
>>>> +}
>>>>
>>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>>> - GaugeEntryExArray[Index].Handle = (EFI_PHYSICAL_ADDRESS) (UINTN) Handle;
>>>> +/**
>>>> + Report Boot Perforamnce table address as report status code.
>>>>
>>>> - if (Token != NULL) {
>>>> - AsciiStrnCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, Token, DXE_PERFORMANCE_STRING_LENGTH);
>>>> - }
>>>> - if (Module != NULL) {
>>>> - AsciiStrnCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, Module, DXE_PERFORMANCE_STRING_LENGTH);
>>>> + @param Event The event of notify protocol.
>>>> + @param Context Notify event context.
>>>> +
>>>> +**/
>>>> +VOID
>>>> +EFIAPI
>>>> +ReportFpdtRecordBuffer (
>>>> + IN EFI_EVENT Event,
>>>> + IN VOID *Context
>>>> + )
>>>> +{
>>>> + EFI_STATUS Status;
>>>> + UINT64 BPDTAddr;
>>>> +
>>>> + if (!mFpdtBufferIsReported) {
>>>> + Status = AllocateBootPerformanceTable ();
>>>> + if (!EFI_ERROR(Status)) {
>>>> + BPDTAddr = (UINT64)(UINTN)mAcpiBootPerformanceTable;
>>>> + REPORT_STATUS_CODE_EX (
>>>> + EFI_PROGRESS_CODE,
>>>> + EFI_SOFTWARE_DXE_BS_DRIVER,
>>>> + 0,
>>>> + NULL,
>>>> + &gEfiFirmwarePerformanceGuid,
>>>> + &BPDTAddr,
>>>> + sizeof (UINT64)
>>>> + );
>>>> + }
>>>> + //
>>>> + // Free Cached FPDT record Buffer
>>>> + //
>>>> + if (mPerformancePointer != NULL) {
>>>> + FreePool (mPerformancePointer);
>>>> + mPerformancePointer = NULL;
>>>> + }
>>>> + mPerformanceLength = 0;
>>>> + mMaxPerformanceLength = 0;
>>>> + //
>>>> + // Set FPDT report state to TRUE.
>>>> + //
>>>> + mFpdtBufferIsReported = TRUE;
>>>> }
>>>> +}
>>>>
>>>> - GaugeEntryExArray[Index].EndTimeStamp = 0;
>>>> - GaugeEntryExArray[Index].Identifier = Identifier;
>>>> +/**
>>>> + Adds a record at the end of the performance measurement log
>>>> + that records the start time of a performance measurement.
>>>>
>>>> - if (TimeStamp == 0) {
>>>> - TimeStamp = GetPerformanceCounter ();
>>>> - }
>>>> - GaugeEntryExArray[Index].StartTimeStamp = TimeStamp;
>>>> + Adds a record to the end of the performance measurement log
>>>> + that contains the Handle, Token, Module and Identifier.
>>>> + The end time of the new record must be set to zero.
>>>> + If TimeStamp is not zero, then TimeStamp is used to fill in the start time in the record.
>>>> + If TimeStamp is zero, the start time in the record is filled in with the value
>>>> + read from the current time stamp.
>>>>
>>>> - mGaugeData->NumberOfEntries++;
>>>> + @param Handle Pointer to environment specific context used
>>>> + to identify the component being measured.
>>>> + @param Token Pointer to a Null-terminated ASCII string
>>>> + that identifies the component being measured.
>>>> + @param Module Pointer to a Null-terminated ASCII string
>>>> + that identifies the module being measured.
>>>> + @param TimeStamp 64-bit time stamp.
>>>> + @param Identifier 32-bit identifier. If the value is 0, the created record
>>>> + is same as the one created by StartGauge of PERFORMANCE_PROTOCOL.
>>>>
>>>> - EfiReleaseLock (&mPerfRecordLock);
>>>> + @retval EFI_SUCCESS The data was read correctly from the device.
>>>> + @retval EFI_OUT_OF_RESOURCES There are not enough resources to record the measurement.
>>>>
>>>> - return EFI_SUCCESS;
>>>> +**/
>>>> +EFI_STATUS
>>>> +EFIAPI
>>>> +StartGaugeEx (
>>>> + IN CONST VOID *Handle, OPTIONAL
>>>> + IN CONST CHAR8 *Token, OPTIONAL
>>>> + IN CONST CHAR8 *Module, OPTIONAL
>>>> + IN UINT64 TimeStamp,
>>>> + IN UINT32 Identifier
>>>> + )
>>>> +{
>>>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
>>>> }
>>>>
>>>> /**
>>>> Searches the performance measurement log from the beginning of the log
>>>> for the first matching record that contains a zero end time and fills in a valid end time.
>>>>
>>>> Searches the performance measurement log from the beginning of the log
>>>> - for the first record that matches Handle, Token and Module and has an end time value of zero.
>>>> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
>>>> If the record can not be found then return EFI_NOT_FOUND.
>>>> If the record is found and TimeStamp is not zero,
>>>> then the end time in the record is filled in with the value specified by TimeStamp.
>>>> If the record is found and TimeStamp is zero, then the end time in the matching record
>>>> is filled in with the current time stamp value.
>>>> @@ -260,89 +1188,19 @@ EndGaugeEx (
>>>> IN CONST CHAR8 *Module, OPTIONAL
>>>> IN UINT64 TimeStamp,
>>>> IN UINT32 Identifier
>>>> )
>>>> {
>>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>>> - UINT32 Index;
>>>> - EFI_STATUS Status;
>>>> -
>>>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>>>> - if (EFI_ERROR (Status)) {
>>>> - return Status;
>>>> - }
>>>> -
>>>> - if (TimeStamp == 0) {
>>>> - TimeStamp = GetPerformanceCounter ();
>>>> - }
>>>> -
>>>> - Index = InternalSearchForGaugeEntry (Handle, Token, Module, Identifier);
>>>> - if (Index >= mGaugeData->NumberOfEntries) {
>>>> - EfiReleaseLock (&mPerfRecordLock);
>>>> - return EFI_NOT_FOUND;
>>>> - }
>>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>>> - GaugeEntryExArray[Index].EndTimeStamp = TimeStamp;
>>>> -
>>>> - EfiReleaseLock (&mPerfRecordLock);
>>>> - return EFI_SUCCESS;
>>>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
>>>> }
>>>>
>>>> /**
>>>> Retrieves a previously logged performance measurement.
>>>> It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
>>>> and then assign the Identifier with 0.
>>>>
>>>> - Retrieves the performance log entry from the performance log specified by LogEntryKey.
>>>> - If it stands for a valid entry, then EFI_SUCCESS is returned and
>>>> - GaugeDataEntryEx stores the pointer to that entry.
>>>> -
>>>> - This internal function is added to avoid releasing lock before each return statement.
>>>> -
>>>> - @param LogEntryKey The key for the previous performance measurement log entry.
>>>> - If 0, then the first performance measurement log entry is retrieved.
>>>> - @param GaugeDataEntryEx The indirect pointer to the extended gauge data entry specified by LogEntryKey
>>>> - if the retrieval is successful.
>>>> -
>>>> - @retval EFI_SUCCESS The GuageDataEntryEx is successfully found based on LogEntryKey.
>>>> - @retval EFI_NOT_FOUND The LogEntryKey is the last entry (equals to the total entry number).
>>>> - @retval EFI_INVALIDE_PARAMETER The LogEntryKey is not a valid entry (greater than the total entry number).
>>>> - @retval EFI_INVALIDE_PARAMETER GaugeDataEntryEx is NULL.
>>>> -
>>>> -**/
>>>> -EFI_STATUS
>>>> -EFIAPI
>>>> -InternalGetGaugeEx (
>>>> - IN UINTN LogEntryKey,
>>>> - OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
>>>> - )
>>>> -{
>>>> - UINTN NumberOfEntries;
>>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>>> -
>>>> - NumberOfEntries = (UINTN) (mGaugeData->NumberOfEntries);
>>>> - if (LogEntryKey > NumberOfEntries) {
>>>> - return EFI_INVALID_PARAMETER;
>>>> - }
>>>> - if (LogEntryKey == NumberOfEntries) {
>>>> - return EFI_NOT_FOUND;
>>>> - }
>>>> -
>>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>>> -
>>>> - if (GaugeDataEntryEx == NULL) {
>>>> - return EFI_INVALID_PARAMETER;
>>>> - }
>>>> - *GaugeDataEntryEx = &GaugeEntryExArray[LogEntryKey];
>>>> -
>>>> - return EFI_SUCCESS;
>>>> -}
>>>> -
>>>> -/**
>>>> - Retrieves a previously logged performance measurement.
>>>> - It can also retrieve the log created by StartGauge and EndGauge of PERFORMANCE_PROTOCOL,
>>>> - and then assign the Identifier with 0.
>>>> + !!! Not support!!!
>>>>
>>>> Retrieves the performance log entry from the performance log specified by LogEntryKey.
>>>> If it stands for a valid entry, then EFI_SUCCESS is returned and
>>>> GaugeDataEntryEx stores the pointer to that entry.
>>>>
>>>> @@ -362,22 +1220,11 @@ EFIAPI
>>>> GetGaugeEx (
>>>> IN UINTN LogEntryKey,
>>>> OUT GAUGE_DATA_ENTRY_EX **GaugeDataEntryEx
>>>> )
>>>> {
>>>> - EFI_STATUS Status;
>>>> -
>>>> - Status = EfiAcquireLockOrFail (&mPerfRecordLock);
>>>> - if (EFI_ERROR (Status)) {
>>>> - return Status;
>>>> - }
>>>> -
>>>> - Status = InternalGetGaugeEx (LogEntryKey, GaugeDataEntryEx);
>>>> -
>>>> - EfiReleaseLock (&mPerfRecordLock);
>>>> -
>>>> - return Status;
>>>> + return EFI_UNSUPPORTED;
>>>> }
>>>>
>>>> /**
>>>> Adds a record at the end of the performance measurement log
>>>> that records the start time of a performance measurement.
>>>> @@ -452,10 +1299,12 @@ EndGauge (
>>>> /**
>>>> Retrieves a previously logged performance measurement.
>>>> It can also retrieve the log created by StartGaugeEx and EndGaugeEx of PERFORMANCE_EX_PROTOCOL,
>>>> and then eliminate the Identifier.
>>>>
>>>> + !!! Not support!!!
>>>> +
>>>> Retrieves the performance log entry from the performance log specified by LogEntryKey.
>>>> If it stands for a valid entry, then EFI_SUCCESS is returned and
>>>> GaugeDataEntry stores the pointer to that entry.
>>>>
>>>> @param LogEntryKey The key for the previous performance measurement log entry.
>>>> @@ -474,81 +1323,13 @@ EFIAPI
>>>> GetGauge (
>>>> IN UINTN LogEntryKey,
>>>> OUT GAUGE_DATA_ENTRY **GaugeDataEntry
>>>> )
>>>> {
>>>> - EFI_STATUS Status;
>>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryEx;
>>>> -
>>>> - GaugeEntryEx = NULL;
>>>> -
>>>> - Status = GetGaugeEx (LogEntryKey, &GaugeEntryEx);
>>>> - if (EFI_ERROR (Status)) {
>>>> - return Status;
>>>> - }
>>>> -
>>>> - if (GaugeDataEntry == NULL) {
>>>> - return EFI_INVALID_PARAMETER;
>>>> - }
>>>> -
>>>> - *GaugeDataEntry = (GAUGE_DATA_ENTRY *) GaugeEntryEx;
>>>> -
>>>> - return EFI_SUCCESS;
>>>> + return EFI_UNSUPPORTED;
>>>> }
>>>>
>>>> -/**
>>>> - Dumps all the PEI performance log to DXE performance gauge array.
>>>> -
>>>> - This internal function dumps all the PEI performance log to the DXE performance gauge array.
>>>> - It retrieves the optional GUID HOB for PEI performance and then saves the performance data
>>>> - to DXE performance data structures.
>>>> -
>>>> -**/
>>>> -VOID
>>>> -InternalGetPeiPerformance (
>>>> - VOID
>>>> - )
>>>> -{
>>>> - EFI_HOB_GUID_TYPE *GuidHob;
>>>> - PEI_PERFORMANCE_LOG_HEADER *LogHob;
>>>> - PEI_PERFORMANCE_LOG_ENTRY *LogEntryArray;
>>>> - UINT32 *LogIdArray;
>>>> - GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;
>>>> - UINT32 Index;
>>>> - UINT32 NumberOfEntries;
>>>> -
>>>> - NumberOfEntries = 0;
>>>> - GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);
>>>> -
>>>> - //
>>>> - // Dump PEI Log Entries to DXE Guage Data structure.
>>>> - //
>>>> - GuidHob = GetFirstGuidHob (&gPerformanceProtocolGuid);
>>>> - if (GuidHob != NULL) {
>>>> - LogHob = GET_GUID_HOB_DATA (GuidHob);
>>>> - LogEntryArray = (PEI_PERFORMANCE_LOG_ENTRY *) (LogHob + 1);
>>>> -
>>>> - NumberOfEntries = LogHob->NumberOfEntries;
>>>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>>>> - GaugeEntryExArray[Index].Handle = LogEntryArray[Index].Handle;
>>>> - AsciiStrCpyS (GaugeEntryExArray[Index].Token, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Token);
>>>> - AsciiStrCpyS (GaugeEntryExArray[Index].Module, DXE_PERFORMANCE_STRING_SIZE, LogEntryArray[Index].Module);
>>>> - GaugeEntryExArray[Index].StartTimeStamp = LogEntryArray[Index].StartTimeStamp;
>>>> - GaugeEntryExArray[Index].EndTimeStamp = LogEntryArray[Index].EndTimeStamp;
>>>> - GaugeEntryExArray[Index].Identifier = 0;
>>>> - }
>>>> -
>>>> - GuidHob = GetFirstGuidHob (&gPerformanceExProtocolGuid);
>>>> - if (GuidHob != NULL) {
>>>> - LogIdArray = GET_GUID_HOB_DATA (GuidHob);
>>>> - for (Index = 0; Index < NumberOfEntries; Index++) {
>>>> - GaugeEntryExArray[Index].Identifier = LogIdArray[Index];
>>>> - }
>>>> - }
>>>> - }
>>>> - mGaugeData->NumberOfEntries = NumberOfEntries;
>>>> -}
>>>>
>>>> /**
>>>> The constructor function initializes Performance infrastructure for DXE phase.
>>>>
>>>> The constructor function publishes Performance and PerformanceEx protocol, allocates memory to log DXE performance
>>>> @@ -567,40 +1348,53 @@ DxeCorePerformanceLibConstructor (
>>>> IN EFI_HANDLE ImageHandle,
>>>> IN EFI_SYSTEM_TABLE *SystemTable
>>>> )
>>>> {
>>>> EFI_STATUS Status;
>>>> + EFI_HANDLE Handle;
>>>> + EFI_EVENT ReadyToBootEvent;
>>>> PERFORMANCE_PROPERTY *PerformanceProperty;
>>>>
>>>> -
>>>> if (!PerformanceMeasurementEnabled ()) {
>>>> //
>>>> // Do not initialize performance infrastructure if not required.
>>>> //
>>>> return EFI_SUCCESS;
>>>> }
>>>> +
>>>> + //
>>>> + // Dump normal PEI performance records
>>>> + //
>>>> + InternalGetPeiPerformance (GetHobList());
>>>> +
>>>> //
>>>> - // Install the protocol interfaces.
>>>> + // Install the protocol interfaces for DXE performance library instance.
>>>> //
>>>> + Handle = NULL;
>>>> Status = gBS->InstallMultipleProtocolInterfaces (
>>>> - &mHandle,
>>>> + &Handle,
>>>> &gPerformanceProtocolGuid,
>>>> &mPerformanceInterface,
>>>> &gPerformanceExProtocolGuid,
>>>> &mPerformanceExInterface,
>>>> NULL
>>>> );
>>>> ASSERT_EFI_ERROR (Status);
>>>>
>>>> - mMaxGaugeRecords = INIT_DXE_GAUGE_DATA_ENTRIES + (UINT16) (PcdGet16 (PcdMaxPeiPerformanceLogEntries16) != 0 ?
>>>> - PcdGet16 (PcdMaxPeiPerformanceLogEntries16) :
>>>> - PcdGet8 (PcdMaxPeiPerformanceLogEntries));
>>>> -
>>>> - mGaugeData = AllocateZeroPool (sizeof (GAUGE_DATA_HEADER) + (sizeof (GAUGE_DATA_ENTRY_EX) * mMaxGaugeRecords));
>>>> - ASSERT (mGaugeData != NULL);
>>>> + //
>>>> + // Register ReadyToBoot event to report StatusCode data
>>>> + //
>>>> + Status = gBS->CreateEventEx (
>>>> + EVT_NOTIFY_SIGNAL,
>>>> + TPL_CALLBACK,
>>>> + ReportFpdtRecordBuffer,
>>>> + NULL,
>>>> + &gEfiEventReadyToBootGuid,
>>>> + &ReadyToBootEvent
>>>> + );
>>>>
>>>> - InternalGetPeiPerformance ();
>>>> + ASSERT_EFI_ERROR (Status);
>>>>
>>>> Status = EfiGetSystemConfigurationTable (&gPerformanceProtocolGuid, (VOID **) &PerformanceProperty);
>>>> if (EFI_ERROR (Status)) {
>>>> //
>>>> // Install configuration table for performance property.
>>>> @@ -651,19 +1445,19 @@ StartPerformanceMeasurementEx (
>>>> IN CONST CHAR8 *Module, OPTIONAL
>>>> IN UINT64 TimeStamp,
>>>> IN UINT32 Identifier
>>>> )
>>>> {
>>>> - return (RETURN_STATUS) StartGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
>>>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, Identifier);
>>>> }
>>>>
>>>> /**
>>>> Searches the performance measurement log from the beginning of the log
>>>> for the first matching record that contains a zero end time and fills in a valid end time.
>>>>
>>>> Searches the performance measurement log from the beginning of the log
>>>> - for the first record that matches Handle, Token and Module and has an end time value of zero.
>>>> + for the first record that matches Handle, Token, Module and Identifier and has an end time value of zero.
>>>> If the record can not be found then return RETURN_NOT_FOUND.
>>>> If the record is found and TimeStamp is not zero,
>>>> then the end time in the record is filled in with the value specified by TimeStamp.
>>>> If the record is found and TimeStamp is zero, then the end time in the matching record
>>>> is filled in with the current time stamp value.
>>>> @@ -690,18 +1484,20 @@ EndPerformanceMeasurementEx (
>>>> IN CONST CHAR8 *Module, OPTIONAL
>>>> IN UINT64 TimeStamp,
>>>> IN UINT32 Identifier
>>>> )
>>>> {
>>>> - return (RETURN_STATUS) EndGaugeEx (Handle, Token, Module, TimeStamp, Identifier);
>>>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, Identifier);
>>>> }
>>>>
>>>> /**
>>>> Attempts to retrieve a performance measurement log entry from the performance measurement log.
>>>> It can also retrieve the log created by StartPerformanceMeasurement and EndPerformanceMeasurement,
>>>> and then assign the Identifier with 0.
>>>>
>>>> + !!! Not support!!!
>>>> +
>>>> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
>>>> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
>>>> and the key for the second entry in the log is returned. If the performance log is empty,
>>>> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
>>>> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
>>>> @@ -729,63 +1525,29 @@ EndPerformanceMeasurementEx (
>>>> being measured.
>>>> @param StartTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
>>>> was started.
>>>> @param EndTimeStamp Pointer to the 64-bit time stamp that was recorded when the measurement
>>>> was ended.
>>>> - @param Identifier Pointer to the 32-bit identifier that was recorded.
>>>> + @param Identifier Pointer to the 32-bit identifier that was recorded when the measurement
>>>> + was ended.
>>>>
>>>> @return The key for the next performance log entry (in general case).
>>>>
>>>> **/
>>>> UINTN
>>>> EFIAPI
>>>> GetPerformanceMeasurementEx (
>>>> - IN UINTN LogEntryKey,
>>>> + IN UINTN LogEntryKey,
>>>> OUT CONST VOID **Handle,
>>>> OUT CONST CHAR8 **Token,
>>>> OUT CONST CHAR8 **Module,
>>>> OUT UINT64 *StartTimeStamp,
>>>> OUT UINT64 *EndTimeStamp,
>>>> OUT UINT32 *Identifier
>>>> )
>>>> {
>>>> - EFI_STATUS Status;
>>>> - GAUGE_DATA_ENTRY_EX *GaugeData;
>>>> -
>>>> - GaugeData = NULL;
>>>> -
>>>> - ASSERT (Handle != NULL);
>>>> - ASSERT (Token != NULL);
>>>> - ASSERT (Module != NULL);
>>>> - ASSERT (StartTimeStamp != NULL);
>>>> - ASSERT (EndTimeStamp != NULL);
>>>> - ASSERT (Identifier != NULL);
>>>> -
>>>> - Status = GetGaugeEx (LogEntryKey++, &GaugeData);
>>>> -
>>>> - //
>>>> - // Make sure that LogEntryKey is a valid log entry key,
>>>> - //
>>>> - ASSERT (Status != EFI_INVALID_PARAMETER);
>>>> -
>>>> - if (EFI_ERROR (Status)) {
>>>> - //
>>>> - // The LogEntryKey is the last entry (equals to the total entry number).
>>>> - //
>>>> - return 0;
>>>> - }
>>>> -
>>>> - ASSERT (GaugeData != NULL);
>>>> -
>>>> - *Handle = (VOID *) (UINTN) GaugeData->Handle;
>>>> - *Token = GaugeData->Token;
>>>> - *Module = GaugeData->Module;
>>>> - *StartTimeStamp = GaugeData->StartTimeStamp;
>>>> - *EndTimeStamp = GaugeData->EndTimeStamp;
>>>> - *Identifier = GaugeData->Identifier;
>>>> -
>>>> - return LogEntryKey;
>>>> + return 0;
>>>> }
>>>>
>>>> /**
>>>> Adds a record at the end of the performance measurement log
>>>> that records the start time of a performance measurement.
>>>> @@ -816,11 +1578,11 @@ StartPerformanceMeasurement (
>>>> IN CONST CHAR8 *Token, OPTIONAL
>>>> IN CONST CHAR8 *Module, OPTIONAL
>>>> IN UINT64 TimeStamp
>>>> )
>>>> {
>>>> - return StartPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
>>>> + return InsertFpdtMeasurement (TRUE, Handle, Token, Module, TimeStamp, 0);
>>>> }
>>>>
>>>> /**
>>>> Searches the performance measurement log from the beginning of the log
>>>> for the first matching record that contains a zero end time and fills in a valid end time.
>>>> @@ -852,18 +1614,20 @@ EndPerformanceMeasurement (
>>>> IN CONST CHAR8 *Token, OPTIONAL
>>>> IN CONST CHAR8 *Module, OPTIONAL
>>>> IN UINT64 TimeStamp
>>>> )
>>>> {
>>>> - return EndPerformanceMeasurementEx (Handle, Token, Module, TimeStamp, 0);
>>>> + return InsertFpdtMeasurement (FALSE, Handle, Token, Module, TimeStamp, 0);
>>>> }
>>>>
>>>> /**
>>>> Attempts to retrieve a performance measurement log entry from the performance measurement log.
>>>> It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
>>>> and then eliminate the Identifier.
>>>>
>>>> + !!! Not support!!!
>>>> +
>>>> Attempts to retrieve the performance log entry specified by LogEntryKey. If LogEntryKey is
>>>> zero on entry, then an attempt is made to retrieve the first entry from the performance log,
>>>> and the key for the second entry in the log is returned. If the performance log is empty,
>>>> then no entry is retrieved and zero is returned. If LogEntryKey is not zero, then the performance
>>>> log entry associated with LogEntryKey is retrieved, and the key for the next entry in the log is
>>>> @@ -905,12 +1669,11 @@ GetPerformanceMeasurement (
>>>> OUT CONST CHAR8 **Module,
>>>> OUT UINT64 *StartTimeStamp,
>>>> OUT UINT64 *EndTimeStamp
>>>> )
>>>> {
>>>> - UINT32 Identifier;
>>>> - return GetPerformanceMeasurementEx (LogEntryKey, Handle, Token, Module, StartTimeStamp, EndTimeStamp, &Identifier);
>>>> + return 0;
>>>> }
>>>>
>>>> /**
>>>> Returns TRUE if the performance measurement macros are enabled.
>>>>
>>>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>>>> index 5b89ce2..71c181f 100644
>>>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>>>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
>>>> @@ -7,11 +7,11 @@
>>>> # It initializes DXE phase performance logging by publishing the Performance and PerformanceEx Protocol,
>>>> # which is consumed by DxePerformanceLib to logging performance data in DXE phase.
>>>> # This library is mainly used by DxeCore to start performance logging to ensure that
>>>> # Performance and PerformanceEx Protocol are installed at the very beginning of DXE phase.
>>>> #
>>>> -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>>>> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>>>> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>>>> # This program and the accompanying materials
>>>> # are licensed and made available under the terms and conditions of the BSD License
>>>> # which accompanies this distribution. The full text of the license may be found at
>>>> # http://opensource.org/licenses/bsd-license.php
>>>> @@ -48,27 +48,39 @@
>>>>
>>>>
>>>> [LibraryClasses]
>>>> MemoryAllocationLib
>>>> UefiBootServicesTableLib
>>>> + UefiRuntimeServicesTableLib
>>>> PcdLib
>>>> TimerLib
>>>> BaseMemoryLib
>>>> BaseLib
>>>> HobLib
>>>> DebugLib
>>>> UefiLib
>>>> + ReportStatusCodeLib
>>>> + DxeServicesLib
>>>> + PeCoffGetEntryPointLib
>>>> +
>>>> +[Protocols]
>>>> + gEfiSmmCommunicationProtocolGuid ## SOMETIMES_CONSUMES
>>>>
>>>>
>>>> [Guids]
>>>> ## SOMETIMES_CONSUMES ## HOB
>>>> ## PRODUCES ## UNDEFINED # Install protocol
>>>> ## PRODUCES ## SystemTable
>>>> gPerformanceProtocolGuid
>>>> ## SOMETIMES_CONSUMES ## HOB
>>>> ## PRODUCES ## UNDEFINED # Install protocol
>>>> gPerformanceExProtocolGuid
>>>> + gZeroGuid ## SOMETIMES_CONSUMES ## GUID
>>>> + gEfiFirmwarePerformanceGuid ## SOMETIMES_PRODUCES ## UNDEFINED # StatusCode Data
>>>> + gEdkiiExtendedFirmwarePerformanceGuid ## SOMETIMES_CONSUMES ## HOB # StatusCode Data
>>>> + gEfiEventReadyToBootGuid ## CONSUMES ## Event
>>>> + gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable
>>>>
>>>> [Pcd]
>>>> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries ## CONSUMES
>>>> - gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16 ## CONSUMES
>>>> - gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
>>>> + gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask ## CONSUMES
>>>> + gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiFpdtStringRecordEnableOnly ## CONSUMES
>>>> + gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES
>>>> diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>>>> index f1540d8..7e79675 100644
>>>> --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>>>> +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLibInternal.h
>>>> @@ -2,11 +2,11 @@
>>>> Master header files for DxeCorePerformanceLib instance.
>>>>
>>>> This header file holds the prototypes of the Performance and PerformanceEx Protocol published by this
>>>> library instance at its constructor.
>>>>
>>>> -Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>>>> +Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>>>> This program and the accompanying materials
>>>> are licensed and made available under the terms and conditions of the BSD License
>>>> which accompanies this distribution. The full text of the license may be found at
>>>> http://opensource.org/licenses/bsd-license.php
>>>>
>>>> @@ -20,21 +20,36 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>>>>
>>>>
>>>> #include <PiDxe.h>
>>>>
>>>> #include <Guid/Performance.h>
>>>> +#include <Guid/ExtendedFirmwarePerformance.h>
>>>> +#include <Guid/ZeroGuid.h>
>>>> +#include <Guid/EventGroup.h>
>>>> +#include <Guid/FirmwarePerformance.h>
>>>> +#include <Guid/PiSmmCommunicationRegionTable.h>
>>>> +
>>>> +#include <Protocol/DriverBinding.h>
>>>> +#include <Protocol/LoadedImage.h>
>>>> +#include <Protocol/ComponentName2.h>
>>>> +#include <Protocol/DevicePathToText.h>
>>>> +#include <Protocol/SmmCommunication.h>
>>>>
>>>> #include <Library/PerformanceLib.h>
>>>> #include <Library/DebugLib.h>
>>>> #include <Library/HobLib.h>
>>>> #include <Library/BaseLib.h>
>>>> #include <Library/BaseMemoryLib.h>
>>>> #include <Library/TimerLib.h>
>>>> #include <Library/PcdLib.h>
>>>> #include <Library/UefiBootServicesTableLib.h>
>>>> +#include <Library/UefiRuntimeServicesTableLib.h>
>>>> #include <Library/MemoryAllocationLib.h>
>>>> #include <Library/UefiLib.h>
>>>> +#include <Library/ReportStatusCodeLib.h>
>>>> +#include <Library/DxeServicesLib.h>
>>>> +#include <Library/PeCoffGetEntryPointLib.h>
>>>>
>>>> //
>>>> // Interface declarations for PerformanceEx Protocol.
>>>> //
>>>> /**
>>>> --
>>>> 1.9.5.msysgit.1
>>>>
>>>> _______________________________________________
>>>> edk2-devel mailing list
>>>> edk2-devel@lists.01.org
>>>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-05-22 10:00 ` Laszlo Ersek
@ 2018-05-22 10:38 ` Zeng, Star
2018-05-22 10:43 ` Ard Biesheuvel
0 siblings, 1 reply; 21+ messages in thread
From: Zeng, Star @ 2018-05-22 10:38 UTC (permalink / raw)
To: Laszlo Ersek, Ard Biesheuvel
Cc: Bi, Dandan, Andrew Fish, Kinney, Michael D, Leif Lindholm,
edk2-devel@lists.01.org, Gao, Liming, Matt Sealey, Zeng, Star
I could not recall the whole background.
Let us separate the problem into two parts.
1. For this special case in DxeCorePerformanceLib, we at least have approach (although just for short term).
2. For the general problem about whether introducing new interface (PCD and API, seemingly it needs to be in MdePkg), it depends on whether we agree to add new interface and seems need more time to discuss. If yes, then library/driver could be updated to consume it.
If we agree to add new interface, as current instances of MemoryAllocationLib are very nature by phases (PEI, DXE (Uefi/DxeCore), SMM, etc), but the new interface is just needed in DXE (Uefi/DxeCore) instances, how about adding it in UefiLib?
Thanks,
Star
-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com]
Sent: Tuesday, May 22, 2018 6:00 PM
To: Zeng, Star <star.zeng@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Bi, Dandan <dandan.bi@intel.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
Subject: Re: [edk2] [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
Hi Star,
On 05/22/18 11:38, Zeng, Star wrote:
> It comes to an old question: how to know PEI is 32bit/64bit? But not DXE is 32bit/64bit.
we've discussed this question in the past (as you remember :) ) and people suggested both HOBs and PCDs to expose the "PEI phase max address" to DXE. All of those ideas were rejected -- I'm unsure why, to this day --, but assuming people who opposed those ideas are going to oppose them again, I think Ard's idea is good, about introducing dedicated MemoryAllocationLib interfaces, for PEI-targeted memory allocation.
Once drivers adopt these new interfaces, platforms can at least fork the MemoryAllocationLib instance(s) they need, and customize the PEI phase max address one way or another.
Thanks,
Laszlo
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, May 22, 2018 5:03 PM
> To: Zeng, Star <star.zeng@intel.com>
> Cc: Bi, Dandan <dandan.bi@intel.com>; Laszlo Ersek
> <lersek@redhat.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Leif Lindholm
> <leif.lindholm@linaro.org>; edk2-devel@lists.01.org; Gao, Liming
> <liming.gao@intel.com>; Matt Sealey <neko@bakuhatsu.net>
> Subject: Re: [edk2] [PATCH v2 3/8]
> MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
>
> pd On 22 May 2018 at 10:58, Zeng, Star <star.zeng@intel.com> wrote:
>> How about the code to try allocating <4G memory, then try allocating any memory if failed to allocate <4G memory?
>>
>> For example, the code snippet in SmbiosDxe.c.
>>
>> PhysicalAddress = 0xffffffff;
>> Status = gBS->AllocatePages (
>> AllocateMaxAddress,
>> EfiRuntimeServicesData,
>> EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
>> &PhysicalAddress
>> );
>> if (EFI_ERROR (Status)) {
>> DEBUG ((EFI_D_ERROR, "SmbiosCreateTable () could not allocate EntryPointStructure < 4GB\n"));
>> Status = gBS->AllocatePages (
>> AllocateAnyPages,
>> EfiRuntimeServicesData,
>> EFI_SIZE_TO_PAGES (sizeof (SMBIOS_TABLE_ENTRY_POINT)),
>> &PhysicalAddress
>> );
>> if (EFI_ERROR (Status)) {
>> return EFI_OUT_OF_RESOURCES;
>> }
>> }
>>
>
> Yes, that should do the trick.
>
> But perhaps we should add something like
>
> AllocatePeiAccessiblePages()
>
> to MemoryAllocationLib, which just uses AllocateMaxAddress or
> AllocateAnyPages depending on whether MDE_CPU_X64 is #defined.
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase
2018-05-22 10:38 ` Zeng, Star
@ 2018-05-22 10:43 ` Ard Biesheuvel
0 siblings, 0 replies; 21+ messages in thread
From: Ard Biesheuvel @ 2018-05-22 10:43 UTC (permalink / raw)
To: Zeng, Star
Cc: Laszlo Ersek, Bi, Dandan, Andrew Fish, Kinney, Michael D,
Leif Lindholm, edk2-devel@lists.01.org, Gao, Liming, Matt Sealey
On 22 May 2018 at 12:38, Zeng, Star <star.zeng@intel.com> wrote:
> I could not recall the whole background.
>
> Let us separate the problem into two parts.
>
> 1. For this special case in DxeCorePerformanceLib, we at least have approach (although just for short term).
I disagree. The approach involves attempting to allocate below 4 GB,
and fall back to allocating elsewhere if that fails.
On X64, the fallback should not exist. If the first allocation fails,
you will end up with an allocation that PEI may not be able to access,
and you will not get any error or warning about this condition.
On other architectures, allocating below 4 GB unnecessarily may be
wasteful, since it uses up 32-bit addressable that we may prefer to
use for DMA, for instance, given that 32-bit DMA is more efficient
even on PCIe systems.
So even if it makes the error go away, I think it is not a solution at all.
> 2. For the general problem about whether introducing new interface (PCD and API, seemingly it needs to be in MdePkg), it depends on whether we agree to add new interface and seems need more time to discuss. If yes, then library/driver could be updated to consume it.
>
> If we agree to add new interface, as current instances of MemoryAllocationLib are very nature by phases (PEI, DXE (Uefi/DxeCore), SMM, etc), but the new interface is just needed in DXE (Uefi/DxeCore) instances, how about adding it in UefiLib?
>
That is a good point, actually. I will look into this.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table
2018-01-30 13:53 [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table Dandan Bi
` (7 preceding siblings ...)
2018-01-30 13:53 ` [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table Dandan Bi
@ 2020-04-28 7:45 ` boonewang
8 siblings, 0 replies; 21+ messages in thread
From: boonewang @ 2020-04-28 7:45 UTC (permalink / raw)
To: Dandan Bi, devel
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
Hi, Dandan
I have seen an email named “ [edk2] [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table “ in mail-archive ” and I know there is an update of Dp.
But I feel uncertain that:
- // Determine in which direction the performance counter counts. - TimerInfo.CountUp = (BOOLEAN) (TimerInfo.EndCount >= TimerInfo.StartCount); + TimerInfo.StartCount = 0; + TimerInfo.EndCount = 0xFFFF; + TimerInfo.CountUp = TRUE;
So it looks like we would not use timer count down feature , does it mean we should use count up timer such as TSC or ACPI Timer? Maybe is there any other cause?
I am looking forward your reply! Thanks!
[-- Attachment #2: Type: text/html, Size: 38741 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2020-04-28 7:45 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-30 13:53 [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table Dandan Bi
2018-01-30 13:53 ` [PATCH v2 1/8] MdeModulePkg:Add definitions for new Performance infrastructure Dandan Bi
2018-01-31 2:07 ` Zeng, Star
2018-01-30 13:53 ` [PATCH v2 2/8] MdeModulePkg/PeiPerformance:Updated to track FPDT record in PEI phase Dandan Bi
2018-01-30 13:53 ` [PATCH v2 3/8] MdeModulePkg/DxeCorePerformanceLib:Track FPDT record in DXE phase Dandan Bi
2018-05-01 16:26 ` Ard Biesheuvel
2018-05-22 0:33 ` Bi, Dandan
2018-05-22 8:51 ` Ard Biesheuvel
2018-05-22 8:58 ` Zeng, Star
2018-05-22 9:02 ` Ard Biesheuvel
2018-05-22 9:38 ` Zeng, Star
2018-05-22 10:00 ` Laszlo Ersek
2018-05-22 10:38 ` Zeng, Star
2018-05-22 10:43 ` Ard Biesheuvel
2018-05-22 10:00 ` Ard Biesheuvel
2018-01-30 13:53 ` [PATCH v2 4/8] MdeModulePkg/SmmCorePerformanceLib:Track FPDT record in SMM phase Dandan Bi
2018-01-30 13:53 ` [PATCH v2 5/8] MdeModulePkg/FirmwarePerformancePei:Add FPDT records for S3 phase Dandan Bi
2018-01-30 13:53 ` [PATCH v2 6/8] MdeModulePkg/FirmwarePerfDxe:Enhance for new pref infrastructure Dandan Bi
2018-01-30 13:53 ` [PATCH v2 7/8] MdeModulePkg/FirmwarePerfSmm:Enhance " Dandan Bi
2018-01-30 13:53 ` [PATCH v2 8/8] ShellPkg/Dp: Updated to dump perf log based on FPDT table Dandan Bi
2020-04-28 7:45 ` [edk2-devel] [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI " boonewang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox