From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 906B02096AEDC for ; Thu, 31 May 2018 02:12:39 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2018 02:12:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,463,1520924400"; d="scan'208";a="53679361" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 31 May 2018 02:12:39 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 31 May 2018 02:12:39 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 31 May 2018 02:12:39 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.82]) with mapi id 14.03.0319.002; Thu, 31 May 2018 17:12:37 +0800 From: "Zeng, Star" To: Ard Biesheuvel , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "leif.lindholm@linaro.org" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] SignedCapsulePkg: add PcdLowestSupportedFirmwareVersion Thread-Index: AQHT+L4NlVWL2QEVUki6Edxvh8YK9qRJjPlA Date: Thu, 31 May 2018 09:12:36 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB5009F@shsmsx102.ccr.corp.intel.com> References: <20180531090149.29202-1-ard.biesheuvel@linaro.org> In-Reply-To: <20180531090149.29202-1-ard.biesheuvel@linaro.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SignedCapsulePkg: add PcdLowestSupportedFirmwareVersion X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 May 2018 09:12:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It could be reused by platform SystemFirmwareDescriptor, for example. Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDe= scriptor.inf QuarkPlatformPkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDes= criptor.inf So, I agree this patch, Reviewed-by: Star Zeng . Please also get Jiewen's RB for the patch. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard = Biesheuvel Sent: Thursday, May 31, 2018 5:02 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zeng, Star ; l= eif.lindholm@linaro.org; Ard Biesheuvel Subject: [edk2] [PATCH] SignedCapsulePkg: add PcdLowestSupportedFirmwareVer= sion Add a PCD that holds the lowest supported version number, so that we can al= low the platform to configure this at build time. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- As discussed a while ago: https://lists.01.org/pipermail/edk2-devel/2018-March/022914.html SignedCapsulePkg/SignedCapsulePkg.dec | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/SignedCapsulePkg/SignedCapsulePkg.dec b/SignedCapsulePkg/Signe= dCapsulePkg.dec index b27e87409b19..f06e07656de9 100644 --- a/SignedCapsulePkg/SignedCapsulePkg.dec +++ b/SignedCapsulePkg/SignedCapsulePkg.dec @@ -52,6 +52,10 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, P= cdsDynamicEx] # @Prompt GUID of the FFS which contains the Pkcs7TestPublicKeyFile. gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiPkcs7TestPublicKeyFileGuid|{0= xba, 0xf5, 0x93, 0xf0, 0x37, 0x6f, 0x16, 0x48, 0x9e, 0x52, 0x91, 0xbe, 0xa0= , 0xf7, 0xe0, 0xb8}|VOID*|0xA0010002 =20 + ## This is the lowest supported version number that can be upgraded to, = as exposed via the System Firmware descriptor. + # @Prompt Lowest support version number that can be upgraded to via=20 + capsule update + =20 + gEfiSignedCapsulePkgTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|0 + x1|UINT32|0xA0010003 + [PcdsDynamicEx] ## This dynamic PCD holds the EDKII system firmware image descriptor. # This information can be used for version check in EDKII system FMP ca= psule. -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel