From: "Zeng, Star" <star.zeng@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Marcin Wojtas <mw@semihalf.com>,
"Dong, Eric" <eric.dong@intel.com>
Cc: "Tian, Feng" <feng.tian@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
"Gao, Liming" <liming.gao@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV
Date: Mon, 4 Jun 2018 05:30:16 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB52D98@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu-JrbB2fdv4ZNE94HP+wuvq3Tz8jRhYGN73e+kEpZ4keA@mail.gmail.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Pushed at 38c977c148e92e2af17c5d346d9b4b2e7a18680a.
Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
Sent: Friday, June 1, 2018 10:00 PM
To: Marcin Wojtas <mw@semihalf.com>; Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
Cc: Tian, Feng <feng.tian@intel.com>; edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2] [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV
(+ MdeModulePkg maintainers)
On 1 June 2018 at 15:58, Marcin Wojtas <mw@semihalf.com> wrote:
> Until now the possible errors returned from processing boot firmware
> volume were not checked, which could cause misbehavior in further
> booting stages. Add relevant assert.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Signed-off-by: Jan Dabros <jsd@semihalf.com>
> ---
> MdeModulePkg/Core/Pei/FwVol/FwVol.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> index 8009546..4150b33 100644
> --- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> +++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> @@ -495,12 +495,13 @@ PeiInitializeFv (
> //
> // Get handle of BFV
> //
> - FvPpi->ProcessVolume (
> - FvPpi,
> - SecCoreData->BootFirmwareVolumeBase,
> - (UINTN)BfvHeader->FvLength,
> - &FvHandle
> - );
> + Status = FvPpi->ProcessVolume (
> + FvPpi,
> + SecCoreData->BootFirmwareVolumeBase,
> + (UINTN)BfvHeader->FvLength,
> + &FvHandle
> + );
> + ASSERT_EFI_ERROR (Status);
>
> //
> // Update internal PEI_CORE_FV array.
> --
> 2.7.4
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-06-04 5:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 13:58 [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV Marcin Wojtas
2018-06-01 14:00 ` Ard Biesheuvel
2018-06-04 5:30 ` Zeng, Star [this message]
2018-06-01 14:35 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103BB52D98@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox