From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C70BF2096F343 for ; Sun, 3 Jun 2018 22:30:19 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jun 2018 22:30:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,475,1520924400"; d="scan'208";a="61520624" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 03 Jun 2018 22:30:19 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 3 Jun 2018 22:30:19 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 3 Jun 2018 22:30:19 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.70]) with mapi id 14.03.0319.002; Mon, 4 Jun 2018 13:30:17 +0800 From: "Zeng, Star" To: Ard Biesheuvel , Marcin Wojtas , "Dong, Eric" CC: "Tian, Feng" , "edk2-devel@lists.01.org" , Leif Lindholm , "Gao, Liming" , "Kinney, Michael D" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV Thread-Index: AQHT+bCljKEUDrTOHUqnpfjtW7NAv6RK6D2AgASuVcA= Date: Mon, 4 Jun 2018 05:30:16 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB52D98@shsmsx102.ccr.corp.intel.com> References: <1527861493-17332-1-git-send-email-mw@semihalf.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 05:30:20 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng Pushed at 38c977c148e92e2af17c5d346d9b4b2e7a18680a. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard = Biesheuvel Sent: Friday, June 1, 2018 10:00 PM To: Marcin Wojtas ; Zeng, Star ; Dong= , Eric Cc: Tian, Feng ; edk2-devel@lists.01.org; Leif Lindhol= m ; Gao, Liming ; Kinney, M= ichael D Subject: Re: [edk2] [PATCH] MdeModulePkg PeiCore: Check error status when p= rocessing boot FV (+ MdeModulePkg maintainers) On 1 June 2018 at 15:58, Marcin Wojtas wrote: > Until now the possible errors returned from processing boot firmware=20 > volume were not checked, which could cause misbehavior in further=20 > booting stages. Add relevant assert. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > Signed-off-by: Jan Dabros > --- > MdeModulePkg/Core/Pei/FwVol/FwVol.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c=20 > b/MdeModulePkg/Core/Pei/FwVol/FwVol.c > index 8009546..4150b33 100644 > --- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c > +++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c > @@ -495,12 +495,13 @@ PeiInitializeFv ( > // > // Get handle of BFV > // > - FvPpi->ProcessVolume ( > - FvPpi, > - SecCoreData->BootFirmwareVolumeBase, > - (UINTN)BfvHeader->FvLength, > - &FvHandle > - ); > + Status =3D FvPpi->ProcessVolume ( > + FvPpi, > + SecCoreData->BootFirmwareVolumeBase, > + (UINTN)BfvHeader->FvLength, > + &FvHandle > + ); > + ASSERT_EFI_ERROR (Status); > > // > // Update internal PEI_CORE_FV array. > -- > 2.7.4 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel