public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol
Date: Mon, 4 Jun 2018 06:40:06 +0000	[thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB52EDC@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2923AA@SHSMSX104.ccr.corp.intel.com>

With update, Reviewed-by: Star Zeng <star.zeng@intel.com>.

-----Original Message-----
From: Gao, Liming 
Sent: Monday, June 4, 2018 2:39 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: RE: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol

Good catch. I will update the commit message.

>-----Original Message-----
>From: Zeng, Star
>Sent: Monday, June 04, 2018 2:37 PM
>To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: RE: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update 
>usage info for BootLogo protocol
>
>Liming,
>
>Should " If it is installed " be " If it is not installed " in the commit message?
>
>
>Thanks,
>Star
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
>Liming Gao
>Sent: Tuesday, May 29, 2018 1:54 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage 
>info for BootLogo protocol
>
>BootLogo protocol is not always required. If it is installed, 
>BootManagerMenuApp can work.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Liming Gao <liming.gao@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>---
>
>MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuAp
>p.inf | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git
>a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>index dd60ef4..392a970 100644
>---
>a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>+++
>b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
>pp.inf
>@@ -4,7 +4,7 @@
> #  The application pops up a menu showing all the boot options 
>referenced by #  BootOrder NV variable and user can choose to boot from one of them.
> #
>-#  Copyright (c) 2011 - 2015, Intel Corporation. All rights 
>reserved.<BR>
>+#  Copyright (c) 2011 - 2018, Intel Corporation. All rights 
>+reserved.<BR>
> #  This program and the accompanying materials  #  are licensed and 
>made available under the terms and conditions of the BSD License  #  
>which accompanies this distribution.  The full text of the license may 
>be found at @@ -51,7 +51,7 @@  [Guids]
>
> [Protocols]
>-  gEfiBootLogoProtocolGuid                      ## CONSUMES
>+  gEfiBootLogoProtocolGuid                      ## SOMETIMES_CONSUMES
>   gEfiLoadedImageDevicePathProtocolGuid         ## CONSUMES
>
> [Pcd]
>--
>2.8.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2018-06-04  6:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29  5:53 [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol Liming Gao
2018-06-04  6:20 ` Ni, Ruiyu
2018-06-04  6:37 ` Zeng, Star
2018-06-04  6:38   ` Gao, Liming
2018-06-04  6:40     ` Zeng, Star [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103BB52EDC@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox