From: "Zeng, Star" <star.zeng@intel.com>
To: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Pipat/メタワニットポン ピパット" <methavanitpong.pipat@socionext.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read
Date: Wed, 6 Jun 2018 10:21:43 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB540D8@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu-vLZY5wV3kcbYasqZ-L1Ghc8mA8htnbJDh8=6UWmy4cA@mail.gmail.com>
I am ok with that, you can propose patch.
Thanks,
Star
-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
Sent: Tuesday, June 5, 2018 8:15 PM
To: Pipat/メタワニットポン ピパット <methavanitpong.pipat@socionext.com>
Cc: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: Re: [edk2] MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read
On 5 June 2018 at 13:45, <methavanitpong.pipat@socionext.com> wrote:
> Hi,
>
> My team is developing a board booting Linux from an on-board eMMC, and
> we find that EmmcReadWrite() debug print is too verbose for INFO level.
>
> // https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c#L904
> DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba ...
>
> Is this an intended level?
> I wonder if the level should be `DEBUG_BLKIO` instead.
>
I agree. I noticed the same, when loading GRUB, kernel and initrd from eMMC, a significant amount of time is spent in these debug prints
prev parent reply other threads:[~2018-06-06 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 11:45 MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read methavanitpong.pipat
2018-06-05 12:15 ` Ard Biesheuvel
2018-06-06 10:21 ` Zeng, Star [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103BB540D8@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox