public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read
@ 2018-06-05 11:45 methavanitpong.pipat
  2018-06-05 12:15 ` Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: methavanitpong.pipat @ 2018-06-05 11:45 UTC (permalink / raw)
  To: edk2-devel; +Cc: star.zeng, eric.dong, ruiyu.ni

Hi,

My team is developing a board booting Linux from an on-board eMMC,
and we find that EmmcReadWrite() debug print is too verbose for INFO level. 

    // https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c#L904
    DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba ...

Is this an intended level?
I wonder if the level should be `DEBUG_BLKIO` instead. 


Thanks,
--
Pipat Methavanitpong
Software Developer, S-Project 3
Socionext Inc.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read
  2018-06-05 11:45 MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read methavanitpong.pipat
@ 2018-06-05 12:15 ` Ard Biesheuvel
  2018-06-06 10:21   ` Zeng, Star
  0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-06-05 12:15 UTC (permalink / raw)
  To: Pipat/メタワニットポン ピパット
  Cc: edk2-devel@lists.01.org, Ruiyu Ni, Eric Dong, Zeng, Star

On 5 June 2018 at 13:45,  <methavanitpong.pipat@socionext.com> wrote:
> Hi,
>
> My team is developing a board booting Linux from an on-board eMMC,
> and we find that EmmcReadWrite() debug print is too verbose for INFO level.
>
>     // https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c#L904
>     DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba ...
>
> Is this an intended level?
> I wonder if the level should be `DEBUG_BLKIO` instead.
>

I agree. I noticed the same, when loading GRUB, kernel and initrd from
eMMC, a significant amount of time is spent in these debug prints


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read
  2018-06-05 12:15 ` Ard Biesheuvel
@ 2018-06-06 10:21   ` Zeng, Star
  0 siblings, 0 replies; 3+ messages in thread
From: Zeng, Star @ 2018-06-06 10:21 UTC (permalink / raw)
  To: Ard Biesheuvel,
	Pipat/メタワニットポン ピパット
  Cc: edk2-devel@lists.01.org, Ni, Ruiyu, Dong, Eric, Zeng, Star

I am ok with that, you can propose patch.


Thanks,
Star
-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] 
Sent: Tuesday, June 5, 2018 8:15 PM
To: Pipat/メタワニットポン ピパット <methavanitpong.pipat@socionext.com>
Cc: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: Re: [edk2] MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read

On 5 June 2018 at 13:45,  <methavanitpong.pipat@socionext.com> wrote:
> Hi,
>
> My team is developing a board booting Linux from an on-board eMMC, and 
> we find that EmmcReadWrite() debug print is too verbose for INFO level.
>
>     // https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c#L904
>     DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba ...
>
> Is this an intended level?
> I wonder if the level should be `DEBUG_BLKIO` instead.
>

I agree. I noticed the same, when loading GRUB, kernel and initrd from eMMC, a significant amount of time is spent in these debug prints

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-06 10:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-05 11:45 MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read methavanitpong.pipat
2018-06-05 12:15 ` Ard Biesheuvel
2018-06-06 10:21   ` Zeng, Star

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox