From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AF83921106F20 for ; Wed, 6 Jun 2018 22:41:55 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2018 22:41:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,486,1520924400"; d="scan'208";a="206014941" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 06 Jun 2018 22:41:54 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Jun 2018 22:41:54 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Jun 2018 22:41:54 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Thu, 7 Jun 2018 13:41:52 +0800 From: "Zeng, Star" To: Ard Biesheuvel CC: "Ni, Ruiyu" , "edk2-devel@lists.01.org" , Leif Lindholm , "Yao, Jiewen" , "Gao, Liming" , "Kinney, Michael D" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdeModulePkg/CapsulePei: clean Dcache before consuming capsule data Thread-Index: AQHT/Xws8+sQHdZJdE2R/MRK1zEavKRSnX+AgAFnCPD//7BugIAAkwhw Date: Thu, 7 Jun 2018 05:41:51 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB54543@shsmsx102.ccr.corp.intel.com> References: <20180606095235.20822-1-ard.biesheuvel@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103BB542D7@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/CapsulePei: clean Dcache before consuming capsule data X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 05:41:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks, got the point. It seems vague that who to ensure the cache coherency. MMU? Caller of Updat= eCapsule? UpdateCapsule? Consumer of capsule data? Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard = Biesheuvel Sent: Thursday, June 7, 2018 12:50 PM To: Zeng, Star Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Leif Lindholm = ; Yao, Jiewen ; Gao, Liming= ; Kinney, Michael D Subject: Re: [edk2] [PATCH] MdeModulePkg/CapsulePei: clean Dcache before co= nsuming capsule data On 7 June 2018 at 03:37, Zeng, Star wrote: > Hi Ard, > > The input parameter CapsuleHeaderArray of UpdateCapsule has the virtual a= ddress. > It has the virtual address of the capsules yes. But how about the data stru= ctures passed as the ScatterGatherList? > CapsuleHeaderArray > Virtual pointer to an array of virtual pointers to the capsules being=20 > passed into update capsule. Each capsules is assumed to stored in=20 > contiguous virtual memory. The capsules in the CapsuleHeaderArray must=20 > be the same capsules as the ScatterGatherList. The CapsuleHeaderArray=20 > must have the > > > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Ard Biesheuvel > Sent: Wednesday, June 6, 2018 8:10 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Ard Biesheuvel=20 > ; Gao, Liming ; Yao,=20 > Jiewen ; Leif Lindholm=20 > ; Kinney, Michael D=20 > ; Zeng, Star > Subject: Re: [edk2] [PATCH] MdeModulePkg/CapsulePei: clean Dcache=20 > before consuming capsule data > > On 6 June 2018 at 11:52, Ard Biesheuvel wrote= : >> When capsule updates are staged for processing after a warm reboot,=20 >> they are copied into memory with the MMU and caches enabled. When the=20 >> capsule PEI gets around to coalescing the capsule, the MMU and caches=20 >> may still be disabled, and so on architectures where uncached=20 >> accesses are incoherent with the caches (such as ARM and AARCH64), we=20 >> may read stale data if we don't clean the caches to memory first. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Leif asked me to include a note why this cannot be done when > UpdateCapsule() is called. > > > """ > Note that this cache maintenance cannot be done during the invocation of = UpdateCapsule(), since the ScatterGatherList structures are only identified= by physical address, and at runtime, the firmware doesn't know whether and= where this memory is mapped, and cache maintenance requires a virtual addr= ess. > """ > >> --- >> MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 1 + >> MdeModulePkg/Universal/CapsulePei/Common/CapsuleCoalesce.c | 4 ++++ >> 2 files changed, 5 insertions(+) >> >> diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf >> b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf >> index c54bc21a95a8..594e110d1f8a 100644 >> --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf >> +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf >> @@ -48,6 +48,7 @@ [Packages] >> >> [LibraryClasses] >> BaseLib >> + CacheMaintenanceLib >> HobLib >> BaseMemoryLib >> PeiServicesLib >> diff --git >> a/MdeModulePkg/Universal/CapsulePei/Common/CapsuleCoalesce.c >> b/MdeModulePkg/Universal/CapsulePei/Common/CapsuleCoalesce.c >> index 3e7054cd38a9..1730f925adc5 100644 >> --- a/MdeModulePkg/Universal/CapsulePei/Common/CapsuleCoalesce.c >> +++ b/MdeModulePkg/Universal/CapsulePei/Common/CapsuleCoalesce.c >> @@ -27,6 +27,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EIT= HER EXPRESS OR IMPLIED. >> #include >> >> #include >> +#include >> #include >> #include >> #include >> @@ -283,6 +284,9 @@ ValidateCapsuleByMemoryResource ( >> DEBUG ((EFI_D_INFO, "Address(0x%lx) Size(0x%lx) in MemoryResource= [0x%x] - Start(0x%lx) Length(0x%lx)\n", >> Address, Size, >> Index,=20 >> MemoryResource[Index].PhysicalStart, >> MemoryResource[Index].ResourceLength)); >> + >> + WriteBackDataCacheRange ((VOID *)(UINTN)Address, Size); >> + >> return TRUE; >> } >> } >> -- >> 2.17.0 >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel