From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6DF2D211CCD5C for ; Wed, 20 Jun 2018 18:38:32 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2018 18:38:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,249,1526367600"; d="scan'208";a="50638703" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 20 Jun 2018 18:38:31 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 20 Jun 2018 18:38:31 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 20 Jun 2018 18:38:30 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0319.002; Thu, 21 Jun 2018 09:38:29 +0800 From: "Zeng, Star" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Yao, Jiewen" , "Zeng, Star" Thread-Topic: [edk2] [patch] SignedCapsulePkg/SystemFirmwareUpdateDxe: Fix ECC issues Thread-Index: AQHUB6C1j0P5YZgIsEu1tJ2AoHKxAqRp8cLQ Date: Thu, 21 Jun 2018 01:38:28 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB5AA30@shsmsx102.ccr.corp.intel.com> References: <20180619073847.142588-1-dandan.bi@intel.com> In-Reply-To: <20180619073847.142588-1-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] SignedCapsulePkg/SystemFirmwareUpdateDxe: Fix ECC issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 01:38:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dand= an Bi Sent: Tuesday, June 19, 2018 3:39 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Yao, Jiewen ; Zeng, Star Subject: [edk2] [patch] SignedCapsulePkg/SystemFirmwareUpdateDxe: Fix ECC i= ssues Make function comments align with functions. Cc: Star Zeng Cc: Michael D Kinney Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 5 += ++++ 1 file changed, 5 insertions(+) diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmware= UpdateDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwar= eUpdateDxe.c index 8e66aedf627..a1ce5b486f7 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateD= xe.c +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateD= xe.c @@ -57,10 +57,13 @@ ParseUpdateDataFile ( @param[in] SystemFirmwareImage Points to the System Firmware image. @param[in] SystemFirmwareImageSize The length of the System Firmware im= age in bytes. @param[in] ConfigData Points to the component configuratio= n structure. @param[out] LastAttemptVersion The last attempt version, which will= be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR. @param[out] LastAttemptStatus The last attempt status, which will = be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR. + @param[in] Progress A function used by the driver to rep= ort the progress of the firmware update. + @param[in] StartPercentage The start completion percentage valu= e that may be used to report progress during the flash write operation. + @param[in] EndPercentage The end completion percentage value = that may be used to report progress during the flash write operation. =20 @retval EFI_SUCCESS The System Firmware image is updated. @retval EFI_WRITE_PROTECTED The flash device is read only. **/ EFI_STATUS @@ -115,10 +118,11 @@ PerformUpdate ( @param[in] SystemFirmwareImageSize The length of the System Firmware im= age in bytes. @param[in] ConfigImage Points to the config file image. @param[in] ConfigImageSize The length of the config file image = in bytes. @param[out] LastAttemptVersion The last attempt version, which will= be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR. @param[out] LastAttemptStatus The last attempt status, which will = be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR. + @param[in] Progress A function used by the driver to rep= ort the progress of the firmware update. =20 @retval EFI_SUCCESS The System Firmware image is updated. @retval EFI_WRITE_PROTECTED The flash device is read only. **/ EFI_STATUS @@ -243,10 +247,11 @@ UpdateImage ( =20 @param[in] Image The EDKII system FMP capsule image. @param[in] ImageSize The size of the EDKII system FMP capsule = image in bytes. @param[out] LastAttemptVersion The last attempt version, which will be r= ecorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR. @param[out] LastAttemptStatus The last attempt status, which will be re= corded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR. + @param[in] Progress A function used by the driver to report t= he progress of the firmware update. =20 @retval EFI_SUCCESS EDKII system FMP capsule passes authenti= cation and the System Firmware image is updated. @retval EFI_SECURITY_VIOLATION EDKII system FMP capsule fails authentic= ation and the System Firmware image is not updated. @retval EFI_WRITE_PROTECTED The flash device is read only. **/ --=20 2.14.3.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel