From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3962B210DA17F for ; Thu, 21 Jun 2018 18:42:13 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 18:42:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,255,1526367600"; d="scan'208";a="239582326" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 21 Jun 2018 18:42:12 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 18:42:12 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 18:42:11 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.51]) with mapi id 14.03.0319.002; Fri, 22 Jun 2018 09:42:10 +0800 From: "Zeng, Star" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Ni, Ruiyu" , "Yao, Jiewen" , "Zeng, Star" Thread-Topic: [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI Thread-Index: AQHUBHcBgvT0M1IutUmjgRqI3WpD+aRri0Qg Date: Fri, 22 Jun 2018 01:42:09 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB5B3B1@shsmsx102.ccr.corp.intel.com> References: <20180615070342.13388-1-hao.a.wu@intel.com> <20180615070342.13388-2-hao.a.wu@intel.com> In-Reply-To: <20180615070342.13388-2-hao.a.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2018 01:42:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please fix typo 'DevicePathLenth' to 'DevicePathLength'. With that, Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Wu, Hao A=20 Sent: Friday, June 15, 2018 3:04 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star ; Dong,= Eric ; Ni, Ruiyu ; Yao, Jiewen Subject: [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host = controller PPI Introduces the below PPI: struct EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI { EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar; EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATH GetNvmeHcDevicePath; }; The GetNvmeHcMmioBar service will provide the caller with the MMIO BAR addr= ess of each NVMe HC within the system; The GetNvmeHcDevicePath service will provide the caller with the device pat= h information of each NVMe HC. Cc: Star Zeng Cc: Eric Dong Cc: Ruiyu Ni Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- MdeModulePkg/Include/Ppi/NvmExpressHostController.h | 97 +++++++++++++++++= +++ MdeModulePkg/MdeModulePkg.dec | 3 + 2 files changed, 100 insertions(+) diff --git a/MdeModulePkg/Include/Ppi/NvmExpressHostController.h b/MdeModul= ePkg/Include/Ppi/NvmExpressHostController.h new file mode 100644 index 0000000000..de9ae4a59c --- /dev/null +++ b/MdeModulePkg/Include/Ppi/NvmExpressHostController.h @@ -0,0 +1,97 @@ +/** @file + + Copyright (c) 2018, Intel Corporation. All rights reserved.
This=20 + program and the accompanying materials are licensed and made=20 + available under the terms and conditions of the BSD License which=20 + accompanies this distribution. The full text of the license may be=20 + found at http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, =20 + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPL= IED. + +**/ + +#ifndef _EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI_H_ +#define _EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI_H_ + +#include + +/// +/// Global ID for the EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI. +/// +#define EDKII_NVME_EXPRESS_HOST_CONTROLLER_PPI_GUID \ + { \ + 0xcae3aa63, 0x676f, 0x4da3, { 0xbd, 0x50, 0x6c, 0xc5, 0xed, 0xde,=20 +0x9a, 0xad } \ + } + +// +// Forward declaration for the EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI. +// +typedef struct _EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI =20 +EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI; + +/** + Get the MMIO base address of NVM Express host controller. + + @param[in] PeiServices Describes the list of possible PEI Serv= ices. + @param[in] This The PPI instance pointer. + @param[in] ControllerId The ID of the NVM Express host controll= er. + @param[out] MmioBar The MMIO base address of the controller= . + + @retval EFI_SUCCESS The operation succeeds. + @retval EFI_INVALID_PARAMETER The parameters are invalid. + @retval EFI_NOT_FOUND The specified NVM Express host controll= er not + found. + +**/ +typedef +EFI_STATUS +(EFIAPI *EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR) ( + IN EFI_PEI_SERVICES **PeiServices, + IN EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI *This, + IN UINT8 ControllerId, + OUT UINTN *MmioBar + ); + +/** + Get the device path of NVM Express host controller. + + @param[in] PeiServices Describes the list of possible PEI Serv= ices. + @param[in] This The PPI instance pointer. + @param[in] ControllerId The ID of the NVM Express host controll= er. + @param[out] DevicePathLenth The length of the device path in bytes = specified + by DevicePath. + @param[out] DevicePath The device path of NVM Express host con= troller. + The caller is responsible for freeing i= t. + This field re-uses EFI Device Path Prot= ocol as + defined by Section 10.2 EFI Device Path= Protocol + of UEFI 2.7 Specification. + + @retval EFI_SUCCESS The operation succeeds. + @retval EFI_INVALID_PARAMETER The parameters are invalid. + @retval EFI_NOT_FOUND The specified NVM Express host controll= er not + found. + @retval EFI_OUT_OF_RESOURCES The operation fails due to lack of reso= urces. + +**/ +typedef +EFI_STATUS +(EFIAPI *EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATH) ( + IN EFI_PEI_SERVICES **PeiServices, + IN EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI *This, + IN UINT8 ControllerId, + OUT UINTN *DevicePathLenth, + OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath + ); + +// +// This PPI contains a set of services to interact with the NVM Express=20 +host // controller. +// +struct _EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI { + EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar; + EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATH GetNvmeHcDevicePath; +}; + +extern EFI_GUID gEdkiiPeiNvmExpressHostControllerPpiGuid; + +#endif diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec = index 3802b6e0b8..8d7c97ee91 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -471,6 +471,9 @@ ## Include/Ppi/PlatformSpecificResetHandler.h gEdkiiPlatformSpecificResetHandlerPpiGuid =3D { 0x75cf14ae, 0x3441, 0x49= dc, { 0xaa, 0x10, 0xbb, 0x35, 0xa7, 0xba, 0x8b, 0xab } } =20 + ## Include/Ppi/NvmExpressHostController.h + gEdkiiPeiNvmExpressHostControllerPpiGuid =3D { 0xcae3aa63, 0x676f,=20 + 0x4da3, { 0xbd, 0x50, 0x6c, 0xc5, 0xed, 0xde, 0x9a, 0xad } } + [Protocols] ## Load File protocol provides capability to load and unload EFI image i= nto memory and execute it. # Include/Protocol/LoadPe32Image.h -- 2.12.0.windows.1