From: "Zeng, Star" <star.zeng@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Shi, Steven" <steven.shi@intel.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v2] MdeModulePkg/AtaPassThru: Add missing NULL ptr check in BindingStart
Date: Fri, 29 Jun 2018 08:45:59 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB5FBD8@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A0931E0BB54@SHSMSX104.ccr.corp.intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Wu, Hao A
Sent: Thursday, June 28, 2018 9:41 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Shi, Steven <steven.shi@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: RE: [PATCH v2] MdeModulePkg/AtaPassThru: Add missing NULL ptr check in BindingStart
Correction:
Should be V1 of the patch.
Best Regards,
Hao Wu
> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, June 28, 2018 9:39 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Zeng, Star; Shi, Steven; Dong, Eric
> Subject: [PATCH v2] MdeModulePkg/AtaPassThru: Add missing NULL ptr
> check in BindingStart
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=916
>
> Within function AtaAtapiPassThruStart():
> Add missing NULL pointer check for variable 'Instance' under the
> 'ErrorExit' code logics.
>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Steven Shi <steven.shi@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c | 9
> ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
> b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
> index aab704bcd3..4108bafd85 100644
> --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
> +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
> @@ -827,12 +827,11 @@ ErrorExit:
> gBS->CloseEvent (Instance->TimerEvent);
> }
>
> - //
> - // Remove all inserted ATA devices.
> - //
> - DestroyDeviceInfoList(Instance);
> -
> if (Instance != NULL) {
> + //
> + // Remove all inserted ATA devices.
> + //
> + DestroyDeviceInfoList (Instance);
> FreePool (Instance);
> }
> return EFI_UNSUPPORTED;
> --
> 2.12.0.windows.1
prev parent reply other threads:[~2018-06-29 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 1:38 [PATCH v2] MdeModulePkg/AtaPassThru: Add missing NULL ptr check in BindingStart Hao Wu
2018-06-28 1:40 ` Wu, Hao A
2018-06-29 8:45 ` Zeng, Star [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103BB5FBD8@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox