From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 01225210C0F72 for ; Tue, 24 Jul 2018 03:06:11 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 03:06:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,397,1526367600"; d="scan'208";a="75000312" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 24 Jul 2018 03:05:05 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Jul 2018 03:05:02 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.173]) with mapi id 14.03.0319.002; Tue, 24 Jul 2018 18:05:00 +0800 From: "Zeng, Star" To: "Gao, Liming" , "Marvin.Haeuser@outlook.com" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Dong, Eric" , "Ni, Ruiyu" , "lersek@redhat.com" , "Steele, Kelly" , "Justen, Jordan L" , "ard.biesheuvel@linaro.org" , "Zeng, Star" Thread-Topic: [PATCH 8/8] MdeModulePkg: Deprecate Smm* PPIs. Thread-Index: AQHUIu9UdCOyCymcE0qr9Kj6S2geZaSd6x9AgAA4aLA= Date: Tue, 24 Jul 2018 10:04:59 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB87A6F@shsmsx102.ccr.corp.intel.com> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2C018E@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2C018E@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 8/8] MdeModulePkg: Deprecate Smm* PPIs. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 10:06:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable I do not think we prefer to deprecate the definitions in MdeModulePkg. The = definitions are also referred by platforms. And I do not think we prefer to update the consumer code at this moment. Th= e SMM driver refers the SMM_ prefix definitions, that definitely makes sens= e. I agree Liming's suggestion. Thanks, Star -----Original Message----- From: Gao, Liming=20 Sent: Tuesday, July 24, 2018 2:39 PM To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Zeng, Star ; Dong, Eric ; Ni, Ruiyu = ; lersek@redhat.com; Steele, Kelly ; Justen, Jordan= L ; ard.biesheuvel@linaro.org Subject: RE: [PATCH 8/8] MdeModulePkg: Deprecate Smm* PPIs. To keep compatibility, I suggest to update MdeModulePkg PPI definition to i= nclude MdePkg one, then typedef structure name and define macro name for SM= M one. MdePkg SMM protocol uses this way to refer to MM protocol.=20 Thanks Liming >-----Original Message----- >From: Marvin H=E4user [mailto:Marvin.Haeuser@outlook.com] >Sent: Tuesday, July 24, 2018 9:41 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming=20 >; Zeng, Star ; Dong, Eric=20 >; Ni, Ruiyu ;=20 >lersek@redhat.com; Steele, Kelly ; Justen,=20 >Jordan L ; ard.biesheuvel@linaro.org >Subject: [PATCH 8/8] MdeModulePkg: Deprecate Smm* PPIs. > >MdeModulePkg's Smm* PPIs have been deprecated entirely by UEFI PI PPIs.=20 >Do not allow their usage when DISABLE_NEW_DEPRECATED_INTERFACES is=20 >defined. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Marvin Haeuser >--- > MdeModulePkg/Include/Ppi/SmmAccess.h | 4 ++++ > MdeModulePkg/Include/Ppi/SmmCommunication.h | 4 ++++ > MdeModulePkg/Include/Ppi/SmmControl.h | 4 ++++ > 3 files changed, 12 insertions(+) > >diff --git a/MdeModulePkg/Include/Ppi/SmmAccess.h >b/MdeModulePkg/Include/Ppi/SmmAccess.h >index 795c8815a9c1..0ca6d0e3af22 100644 >--- a/MdeModulePkg/Include/Ppi/SmmAccess.h >+++ b/MdeModulePkg/Include/Ppi/SmmAccess.h >@@ -24,6 +24,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND,=20 >EITHER EXPRESS OR IMPLIED. > > **/ > >+#ifndef DISABLE_NEW_DEPRECATED_INTERFACES >+ > #ifndef _SMM_ACCESS_PPI_H_ > #define _SMM_ACCESS_PPI_H_ > >@@ -144,3 +146,5 @@ struct _PEI_SMM_ACCESS_PPI { extern EFI_GUID=20 >gPeiSmmAccessPpiGuid; > > #endif >+ >+#endif >diff --git a/MdeModulePkg/Include/Ppi/SmmCommunication.h >b/MdeModulePkg/Include/Ppi/SmmCommunication.h >index 8ac86a443a15..7f24d851ae09 100644 >--- a/MdeModulePkg/Include/Ppi/SmmCommunication.h >+++ b/MdeModulePkg/Include/Ppi/SmmCommunication.h >@@ -19,6 +19,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND,=20 >EITHER EXPRESS OR IMPLIED. > > **/ > >+#ifndef DISABLE_NEW_DEPRECATED_INTERFACES >+ > > #ifndef _SMM_COMMUNICATION_PPI_H_ > #define _SMM_COMMUNICATION_PPI_H_ >@@ -62,3 +64,5 @@ struct _EFI_PEI_SMM_COMMUNICATION_PPI { extern=20 >EFI_GUID gEfiPeiSmmCommunicationPpiGuid; > > #endif >+ >+#endif >diff --git a/MdeModulePkg/Include/Ppi/SmmControl.h >b/MdeModulePkg/Include/Ppi/SmmControl.h >index 0c62196fb44c..597a6db07f2c 100644 >--- a/MdeModulePkg/Include/Ppi/SmmControl.h >+++ b/MdeModulePkg/Include/Ppi/SmmControl.h >@@ -22,6 +22,8 @@ > > **/ > >+#ifndef DISABLE_NEW_DEPRECATED_INTERFACES >+ > > #ifndef _SMM_CONTROL_PPI_H_ > #define _SMM_CONTROL_PPI_H_ >@@ -94,3 +96,5 @@ struct _PEI_SMM_CONTROL_PPI { extern EFI_GUID=20 >gPeiSmmControlPpiGuid; > > #endif >+ >+#endif >-- >2.18.0.windows.1