From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 045E6210C42CD for ; Sat, 28 Jul 2018 05:49:33 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jul 2018 05:49:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,413,1526367600"; d="scan'208";a="76292567" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 28 Jul 2018 05:49:19 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 28 Jul 2018 05:49:19 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 28 Jul 2018 05:49:18 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Sat, 28 Jul 2018 20:49:16 +0800 From: "Zeng, Star" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's declaration Thread-Index: AQHUJhaJ/69iZJXkPkGY5ZgKP0/UlaSjnogAgAD32uA= Date: Sat, 28 Jul 2018 12:49:15 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB89C6C@shsmsx102.ccr.corp.intel.com> References: <1532743124-15120-1-git-send-email-star.zeng@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTBjYjdkMzQtNTU3Zi00M2NlLWI1YzYtNjkxNDJkY2I1MTczIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSXFDU1FxdGJ5Ym5pRWs2VnlmQkJZemRxc0hxZUVOQitiZUlmbTYwemgrd2FMMHpCRUNBTmtja2o1UldiYVwvT3oifQ== dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's declaration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jul 2018 12:49:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agree. :) Will send a V2 patch soon. Thanks, Star -----Original Message----- From: Kinney, Michael D=20 Sent: Saturday, July 28, 2018 2:01 PM To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Mich= ael D Cc: Zeng, Star Subject: RE: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDx= e: Add comment in mFmpDeviceLocked's declaration Star, I recommend using the following comment to describe this module global variable. // // Indicates if an attempt has been made to lock a=20 // FLASH storage device by calling FmpDeviceLock(). // A FLASH storage device may not support being locked, // so this variable is set to TRUE even if FmpDeviceLock() // returns an error. // Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Star Zeng > Sent: Friday, July 27, 2018 6:59 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Zeng, Star > Subject: [edk2] [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's > declaration >=20 > Add comment in mFmpDeviceLocked's declaration to make > it more clear. >=20 > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > FmpDevicePkg/FmpDxe/FmpDxe.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c > b/FmpDevicePkg/FmpDxe/FmpDxe.c > index 94fdf5608529..37bcaf19ec6d 100644 > --- a/FmpDevicePkg/FmpDxe/FmpDxe.c > +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c > @@ -89,6 +89,10 @@ UINT64 mImageId =3D 0x1; > CHAR16 *mVersionName =3D NULL; >=20 > EFI_EVENT mFmpDeviceLockEvent; > +// > +// Indicates whether the FMP device is locked / the > lock operation is attempted or not. > +// It will be set to TRUE after calling > FmpDeviceLock(). > +// > BOOLEAN mFmpDeviceLocked =3D FALSE; >=20 > /** > -- > 2.7.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel