From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BF756210D6CFE for ; Thu, 2 Aug 2018 03:02:55 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2018 03:02:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,435,1526367600"; d="scan'208";a="61784076" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga008.jf.intel.com with ESMTP; 02 Aug 2018 03:02:54 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 2 Aug 2018 03:02:54 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 2 Aug 2018 03:02:53 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.173]) with mapi id 14.03.0319.002; Thu, 2 Aug 2018 18:02:51 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdeModulePkg: Remove redundant library classes and GUIDs Thread-Index: AQHUKj0+A1mg260GhkOto9zG+lyGGaSsOyvw Date: Thu, 2 Aug 2018 10:02:50 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BB8BDF6@shsmsx102.ccr.corp.intel.com> References: <20180802084525.17352-1-shenglei.zhang@intel.com> In-Reply-To: <20180802084525.17352-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg: Remove redundant library classes and GUIDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 10:02:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Shenglei, I suggest merging this patch with https://lists.01.org/pipermail/edk2-devel= /2018-August/027883.html to one patch. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of shen= glei Sent: Thursday, August 2, 2018 4:45 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg: Remove redundant library classes and = GUIDs Some redundant library classes and GUIDs have been removed in inf, .c and .= h files. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1044 https://bugzilla.tianocore.org/show_bug.cgi?id=3D1045 https://bugzilla.tianocore.org/show_bug.cgi?id=3D1047 https://bugzilla.tianocore.org/show_bug.cgi?id=3D1049 https://bugzilla.tianocore.org/show_bug.cgi?id=3D1051 https://bugzilla.tianocore.org/show_bug.cgi?id=3D1052 https://bugzilla.tianocore.org/show_bug.cgi?id=3D1053 https://bugzilla.tianocore.org/show_bug.cgi?id=3D1054 https://bugzilla.tianocore.org/show_bug.cgi?id=3D1055 https://bugzilla.tianocore.org/show_bug.cgi?id=3D1056 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 1 - MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf | 1 - .../Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 1 - .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.inf | 1 - MdeModulePkg/Bus/I2c/I2cDxe/I2cHostDxe.inf | 1 - MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h | 1 - MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf | 1 - .../Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf | 3 +-- .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c | 2 -- .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf | 2 -- MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 2 -- MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h | 2 -- MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf | 1 - MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h | 1 - MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h | 1 - .../Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf | 1 - .../SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.c | 1 - .../SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.inf | 1 - 18 files changed, 1 insertion(+), 23 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c b/MdeModulePk= g/Application/CapsuleApp/CapsuleApp.c index 894da2f2d9..4d907242f3 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf b/MdeModule= Pkg/Application/CapsuleApp/CapsuleApp.inf index 3a67c6b909..d1b11318bb 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf @@ -40,7 +40,6 @@ MdeModulePkg/MdeModulePkg.dec =20 [Guids] - gEfiGlobalVariableGuid ## CONSUMES ## GUID gEfiCapsuleReportGuid ## CONSUMES ## GUID gEfiFmpCapsuleGuid ## CONSUMES ## GUID gWindowsUxCapsuleGuid ## CONSUMES ## GUID diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfi= leInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfile= Info.c index 96e9977aad..a77164b436 100644 --- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.= c +++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileIn +++ fo.c @@ -22,7 +22,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include #include #include -#include #include #include #include diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfi= leInfo.inf b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfi= leInfo.inf index 73cc052cc3..cc189fd480 100644 --- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.= inf +++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileIn +++ fo.inf @@ -42,7 +42,6 @@ UefiLib PrintLib DevicePathLib - PeCoffGetEntryPointLib DxeServicesLib =20 [Protocols] diff --git a/MdeModulePkg/Bus/I2c/I2cDxe/I2cHostDxe.inf b/MdeModulePkg/Bus/= I2c/I2cDxe/I2cHostDxe.inf index 2fb1085c6d..c9b87eb50c 100644 --- a/MdeModulePkg/Bus/I2c/I2cDxe/I2cHostDxe.inf +++ b/MdeModulePkg/Bus/I2c/I2cDxe/I2cHostDxe.inf @@ -36,7 +36,6 @@ [LibraryClasses] BaseMemoryLib DebugLib - DevicePathLib MemoryAllocationLib UefiBootServicesTableLib UefiDriverEntryPoint diff --git a/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h b/MdeModulePkg/= Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h index a2e61d6128..5a83be968f 100644 --- a/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h +++ b/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h @@ -32,7 +32,6 @@ #include #include #include -#include #include #include #include diff --git a/MdeModulePkg/Bus/Pc= i/UfsPciHcDxe/UfsPciHcDxe.inf b/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDx= e.inf index 525235635a..900fa01698 100644 --- a/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf +++ b/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf @@ -42,7 +42,6 @@ [LibraryClasses] BaseLib DebugLib - DevicePathLib UefiDriverEntryPoint UefiBootServicesTableLib UefiLib diff --git a/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.in= f b/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf index f4860cdc0b..ea7207504d 100644 --- a/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf +++ b/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf @@ -36,15 +36,14 @@ =20 [LibraryClasses] UefiLib - DxeServicesLib PcdLib - BaseMemoryLib DebugLib UefiBootServicesTableLib UefiDriverEntryPoint =20 [Protocols] gEfiAcpiTableProtocolGuid ## CONSUMES + gEfiFirmwareVolume2ProtocolGuid ## CONSUMES =20 [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile ## CONSUMES diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Fi= rmwarePerformanceDxe.c b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDat= aTableDxe/FirmwarePerformanceDxe.c index 3d8e83250e..d286a48db2 100644 --- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwareP= erformanceDxe.c +++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa +++ rePerformanceDxe.c @@ -25,8 +25,6 @@ =20 #include #include -#include -#include =20 #include #include diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Fi= rmwarePerformanceDxe.inf b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceD= ataTableDxe/FirmwarePerformanceDxe.inf index 843cda7021..983ce41b48 100644 --- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwareP= erformanceDxe.inf +++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa +++ rePerformanceDxe.inf @@ -61,8 +61,6 @@ =20 [Guids] gEfiEventExitBootServicesGuid ## CONSUMES ##= Event - gEfiEventReadyToBootGuid ## CONSUMES ##= Event - gEfiEventLegacyBootGuid ## SOMETIMES_CONSUMES ##= Event ## SOMETIMES_CONSUMES ## HOB ## SOMETIMES_CONSUMES ## Variable:L"FirmwarePerformance" ## PRODUCES ## Variable:L"FirmwarePerformance" diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf b/MdeModulePkg/U= niversal/EbcDxe/EbcDebugger.inf index 4554eb485d..10a6b2c06e 100644 --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf @@ -106,8 +106,6 @@ =20 [Guids] gEfiFileInfoGuid ## SOMETIMES_CONSUMES ## G= UID - gEfiFileSystemInfoGuid ## SOMETIMES_CONSUMES ## G= UID - gEfiFileSystemVolumeLabelInfoIdGuid ## SOMETIMES_CONSUMES ## G= UID gEfiDebugImageInfoTableGuid ## SOMETIMES_CONSUMES ## G= UID =20 [Depex] diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h b/MdeMod= ulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h index d452b2bb2e..c8d8768abd 100644 --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h @@ -29,8 +29,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include #include #include -#include -#include #include =20 typedef UINTN EFI_DEBUG_STATUS; diff --git a/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf b/MdeModulePkg/Univ= ersal/EsrtDxe/EsrtDxe.inf index 5eb7ef924a..7f2499b33d 100644 --- a/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf +++ b/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf @@ -49,7 +49,6 @@ DxeServicesTableLib UefiBootServicesTableLib UefiRuntimeServicesTableLib - PrintLib =20 [Guids] gEfiSystemResourceTableGuid ## PRODUCES ## Syste= mTable diff --git a/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h b/MdeModulePkg/Unive= rsal/EsrtDxe/EsrtImpl.h index e0e9673c70..e6372458b9 100644 --- a/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h +++ b/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h @@ -28,7 +28,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include #include #include -#include =20 #include #include diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.= h b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h index 1848a92872..8529de675c 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h @@ -27,7 +27,6 @@ #include #include #include -#include #include #include #include diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntim= eDxe.inf b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeD= xe.inf index da9e8e118b..2b9eabd85d 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.in= f +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe +++ .inf @@ -43,7 +43,6 @@ UefiRuntimeLib UefiBootServicesTableLib UefiDriverEntryPoint - IoLib UefiLib DebugLib BaseLib diff --git a/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicat= ionBufferDxe.c b/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommun= icationBufferDxe.c index 3ad264b117..7d0baf8d92 100644 --- a/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBuff= erDxe.c +++ b/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationB +++ ufferDxe.c @@ -26,7 +26,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include #include #= include -#include #include =20 #define DEFAULT_COMMON_PI_SMM_COMMUNIATION_REGION_PAGES 4 diff --git a/Md= eModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.in= f b/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBuffer= Dxe.inf index 84a2318173..cc0f136c2b 100644 --- a/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBuff= erDxe.inf +++ b/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationB +++ ufferDxe.inf @@ -50,7 +50,6 @@ MemoryAllocationLib HobLib DebugLib - PcdLib =20 [Guids] gEdkiiPiSmmCommunicationRegionTableGuid ## PRODUCES ## SystemTable -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel