From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 12934210E38A2 for ; Wed, 8 Aug 2018 20:37:11 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 20:37:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,213,1531810800"; d="scan'208";a="81885859" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 08 Aug 2018 20:37:10 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:37:10 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:37:09 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 11:33:01 +0800 From: "Zeng, Star" To: Leif Lindholm , "Zhang, Shenglei" CC: "edk2-devel@lists.01.org" , "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 00/26] MdeModulePkg Remove redundant functions Thread-Index: AQHULvSFV0lpSeHeJU+GyxwIom06VaS1a4kAgAFZVuA= Date: Thu, 9 Aug 2018 03:33:00 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBA9131@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808145500.sh4dt3rwwdgcern6@bivouac.eciton.net> In-Reply-To: <20180808145500.sh4dt3rwwdgcern6@bivouac.eciton.net> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 00/26] MdeModulePkg Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 03:37:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, Do not worry, it is still in review progress. Yes, we will make sure the patches do not get pushed until after the 201808= stable tag has been made. Thanks, Star -----Original Message----- From: Leif Lindholm [mailto:leif.lindholm@linaro.org]=20 Sent: Wednesday, August 8, 2018 10:55 PM To: Zhang, Shenglei Cc: edk2-devel@lists.01.org; Dong, Eric ; Zeng, Star <= star.zeng@intel.com> Subject: Re: [edk2] [PATCH 00/26] MdeModulePkg Remove redundant functions Eric, Star, On Wed, Aug 08, 2018 at 04:46:46PM +0800, shenglei wrote: > A lot of redundant functions which are never calld have been removed.I=20 > manually search these fuctions in source files to make sure that they are= not used elsewhere. > Also the MdeModulePkg was built to ensure that. I have no objection to this set, but it is quite invasive. So can we please ensure it does not get pushed until after the 201808 stabl= e tag has been made? (Mike has just announced the quiet period.) Best Regards, = Leif =20 > shenglei (26): > MdeModulePkg CapsuleApp: Remove a redundant function > MdeModulePkg UiApp: Remove redundant functions > MdeModulePkg AtaAtapiPassThru: Remove redundant functions > MdeModulePkg EhciDxe: Remove redundant functions > MdeModulePkg NvmExpressDxe: Remove redundant functions > MdeModulePkg PciBusDxe: Remove redundant functions > MdeModulePkg SdMmcPciHcDxe: Remove redundant functions > MdeModulePkg UhciPei: Remove redundant functions > MdeModulePkg XhciDxe: Remove redundant functions > MdeModulePkg XhciPei: Remove redundant functions > MdeModulePkg UfsBlockIoPei: Remove redundant functions > MdeModulePkg UfsPassThruDxe: Remove redundant functions > MdeModulePkg UsbBotPei: Remove redundant functions > MdeModulePkg UsbBusDxe: Remove redundant functions > MdeModulePkg UsbBusPei: Remove redundant functions > MdeModulePkg Core/Dxe: Remove redundant functions > MdeModulePkg PiSmmCore: Remove redundant functions > MdeModulePkg Ps2KeyboardDxe: Remove a redundant function > MdeModulePkg EmmcBlockIoPei: Remove a redundant function > MdeModulePkg SdBlockIoPei: Remove a redundant function > MdeModulePkg TerminalDxe: Remove a redundant function > MdeModulePkg HiiDatabaseDxe: Remove a redundant function > MdeModulePkg Ip4Dxe: Remove a redundant function > MdeModulePkg IScsiDxe: Remove a redundant function > MdeModulePkg Tcp4Dxe: Remove redundant functions > MdeModulePkg SetupBrowserDxe: Remove a redundant function >=20 > .../Application/CapsuleApp/CapsuleDump.c | 31 --- > MdeModulePkg/Application/UiApp/FrontPage.c | 40 --- > MdeModulePkg/Application/UiApp/Ui.h | 30 -- > .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 104 ------- > .../Bus/Ata/AtaAtapiPassThru/IdeMode.c | 257 ------------------ > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 26 -- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 12 - > MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 27 -- > MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h | 11 - > MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c | 44 --- > .../Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 110 -------- > .../Bus/Pci/PciBusDxe/PciDeviceSupport.c | 80 ------ > .../Bus/Pci/PciBusDxe/PciDeviceSupport.h | 17 -- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 41 --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 21 -- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 107 -------- > MdeModulePkg/Bus/Pci/UhciPei/DmaMem.c | 22 -- > MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c | 125 --------- > MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.h | 78 ------ > MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c | 66 ----- > MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h | 28 -- > MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c | 24 -- > MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c | 22 -- > MdeModulePkg/Bus/Pci/XhciPei/XhciReg.h | 14 - > .../Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 24 -- > MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 24 -- > .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 101 ------- > MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c | 24 -- > MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 180 ------------ > .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 49 ---- > MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c | 190 ------------- > MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h | 98 ------- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c | 68 ----- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 146 ---------- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h | 114 -------- > MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c | 39 --- > MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h | 18 -- > MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c | 77 ------ > MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h | 35 --- > MdeModulePkg/Core/Dxe/DxeMain.h | 13 - > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 22 -- > MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 78 ------ > MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 166 ----------- > .../Core/PiSmmCore/MemoryAttributesTable.c | 131 --------- > MdeModulePkg/Core/PiSmmCore/Page.c | 121 --------- > .../Universal/Console/TerminalDxe/Terminal.h | 12 - > .../Console/TerminalDxe/TerminalConIn.c | 25 -- > .../Universal/HiiDatabaseDxe/ConfigRouting.c | 47 ---- > .../Universal/Network/IScsiDxe/IScsiProto.c | 31 --- > .../Universal/Network/Ip4Dxe/Ip4Config2Impl.c | 16 -- > .../Universal/Network/Tcp4Dxe/SockImpl.c | 35 --- > .../Universal/Network/Tcp4Dxe/SockInterface.c | 41 --- > .../Universal/Network/Tcp4Dxe/Socket.h | 32 --- > .../Universal/Network/Tcp4Dxe/Tcp4Option.c | 28 -- > .../Universal/Network/Tcp4Dxe/Tcp4Option.h | 15 - > .../Universal/SetupBrowserDxe/IfrParse.c | 33 --- > 56 files changed, 3370 deletions(-) >=20 > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel