From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD6C9210E38D9 for ; Thu, 9 Aug 2018 03:18:43 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 03:18:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,214,1531810800"; d="scan'208";a="223232979" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 09 Aug 2018 03:18:34 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 03:18:27 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 03:18:26 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 18:18:25 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant functions Thread-Index: AQHULvR6tgDhRyvMbE6fz5q+AFCLDqS3NqMg Date: Thu, 9 Aug 2018 10:18:24 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBAA45A@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-5-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-5-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 10:18:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant functions The functions that are never called have been removed. They are EhcDumpRegs,EhcDisableAsyncSchd and EhcDisablePeriodSchd https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 27 --------------- MdeModulePk= g/Bus/Pci/EhciDxe/EhciDebug.h | 11 ------ MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c | 44 ------------------------ 3 files changed, 82 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c b/MdeModulePkg/Bus/Pc= i/EhciDxe/EhciDebug.c index 76368b4748..71755d421b 100644 --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c @@ -228,31 +228,4 @@ EhcDumpBuf ( DEBUG ((EFI_D_VERBOSE, "\n")); } =20 -/** - Dump the EHCI status registers. - - @param Ehc USB EHCI Host Controller instance =20 -**/ -VOID -EhcDumpRegs ( - IN USB2_HC_DEV *Ehc - ) -{ - UINT8 Index; - - DEBUG ((EFI_D_VERBOSE, " EHC_CAPLENGTH_OFFSET =3D 0x%08x\n", EhcReadC= apRegister (Ehc, EHC_CAPLENGTH_OFFSET))); - DEBUG ((EFI_D_VERBOSE, " EHC_HCSPARAMS_OFFSET =3D 0x%08x\n", EhcReadC= apRegister (Ehc, EHC_HCSPARAMS_OFFSET))); - DEBUG ((EFI_D_VERBOSE, " EHC_HCCPARAMS_OFFSET =3D 0x%08x\n", EhcReadC= apRegister (Ehc, EHC_HCCPARAMS_OFFSET))); - DEBUG ((EFI_D_VERBOSE, " EHC_USBCMD_OFFSET =3D 0x%08x\n", EhcReadO= pReg (Ehc, EHC_USBCMD_OFFSET))); - DEBUG ((EFI_D_VERBOSE, " EHC_USBSTS_OFFSET =3D 0x%08x\n", EhcReadO= pReg (Ehc, EHC_USBSTS_OFFSET))); - DEBUG ((EFI_D_VERBOSE, " EHC_USBINTR_OFFSET =3D 0x%08x\n", EhcReadO= pReg (Ehc, EHC_USBINTR_OFFSET))); - DEBUG ((EFI_D_VERBOSE, " EHC_FRINDEX_OFFSET =3D 0x%08x\n", EhcReadO= pReg (Ehc, EHC_FRINDEX_OFFSET))); - DEBUG ((EFI_D_VERBOSE, " EHC_CTRLDSSEG_OFFSET =3D 0x%08x\n", EhcReadO= pReg (Ehc, EHC_CTRLDSSEG_OFFSET))); - DEBUG ((EFI_D_VERBOSE, " EHC_FRAME_BASE_OFFSET =3D 0x%08x\n", EhcReadO= pReg (Ehc, EHC_FRAME_BASE_OFFSET))); - DEBUG ((EFI_D_VERBOSE, " EHC_ASYNC_HEAD_OFFSET =3D 0x%08x\n", EhcReadO= pReg (Ehc, EHC_ASYNC_HEAD_OFFSET))); - DEBUG ((EFI_D_VERBOSE, " EHC_CONFIG_FLAG_OFFSET =3D 0x%08x\n", EhcReadO= pReg (Ehc, EHC_CONFIG_FLAG_OFFSET))); - for (Index =3D 0; Index < (UINT8) (Ehc->HcStructParams & HCSP_NPORTS); I= ndex++) { - DEBUG ((EFI_D_VERBOSE, " EHC_PORT_STAT_OFFSET(%d) =3D 0x%08x\n", Ind= ex, EhcReadOpReg (Ehc, EHC_PORT_STAT_OFFSET + (4 * Index)))); - } -} diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h b/MdeModulePkg/Bus/Pc= i/EhciDxe/EhciDebug.h index bc84bb7864..a64b0551a0 100644 --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h @@ -61,15 +61,4 @@ EhcDumpBuf ( ); =20 =20 -/** - Dump the EHCI status registers. - - @param Ehc USB EHCI Host Controller instance - -**/ -VOID -EhcDumpRegs ( - IN USB2_HC_DEV *Ehc - ); - #endif diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c b/MdeModulePkg/Bus/Pci/= EhciDxe/EhciReg.c index 34836eccf5..59752d1bdc 100644 --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c @@ -372,29 +372,7 @@ EhcEnablePeriodSchd ( } =20 =20 -/** - Disable periodic schedule. =20 - @param Ehc The EHCI device. - @param Timeout Time to wait before abort (in millisecond, ms)= . - - @retval EFI_SUCCESS Periodic schedule is disabled. - @retval EFI_DEVICE_ERROR Fail to disable periodic schedule. - -**/ -EFI_STATUS -EhcDisablePeriodSchd ( - IN USB2_HC_DEV *Ehc, - IN UINT32 Timeout - ) -{ - EFI_STATUS Status; - - EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_PERIOD); - - Status =3D EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET, USBSTS_PERIOD_ENABLE= D, FALSE, Timeout); - return Status; -} =20 =20 =20 @@ -424,29 +402,7 @@ EhcEnableAsyncSchd ( =20 =20 =20 -/** - Disable asynchrounous schedule. =20 - @param Ehc The EHCI device. - @param Timeout Time to wait before abort (in millisecond, ms). - - @retval EFI_SUCCESS The asynchronous schedule is disabled. - @return Others Failed to disable the asynchronous schedule. - -**/ -EFI_STATUS -EhcDisableAsyncSchd ( - IN USB2_HC_DEV *Ehc, - IN UINT32 Timeout - ) -{ - EFI_STATUS Status; - - EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_ASYNC); - - Status =3D EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET, USBSTS_ASYNC_ENABLED= , FALSE, Timeout); - return Status; -} =20 =20 =20 -- 2.18.0.windows.1