From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AF86A210E38DB for ; Thu, 9 Aug 2018 03:21:42 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 03:21:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,214,1531810800"; d="scan'208";a="61096608" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 09 Aug 2018 03:21:42 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 03:21:41 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 03:21:41 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 18:21:39 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Fu, Siyuan" , "Wu, Jiaxin" , "Zeng, Star" Thread-Topic: [PATCH 24/26] MdeModulePkg IScsiDxe: Remove a redundant function Thread-Index: AQHULvSRiDcLMkNUtky0iXy8c4hsYaS3N4nQ Date: Thu, 9 Aug 2018 10:21:38 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBAA49C@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-25-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-25-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 24/26] MdeModulePkg IScsiDxe: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 10:21:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc Siyuan and Jiaxin. Thanks, Star -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 24/26] MdeModulePkg IScsiDxe: Remove a redundant function The function IScsiFindTcbByITT that is never calld has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- .../Universal/Network/IScsiDxe/IScsiProto.c | 31 ------------------- 1 file changed, 31 deletions(-) diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.c b/MdeModu= lePkg/Universal/Network/IScsiDxe/IScsiProto.c index 9fb848080a..b4a5c2d024 100644 --- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.c +++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.c @@ -1738,37 +1738,6 @@ IScsiDelTcb ( FreePool (Tcb); } =20 -/** - Find the task control block by the initator task tag. - - @param[in] TcbList The tcb list. - @param[in] InitiatorTaskTag The initiator task tag. - - @return The task control block found. -**/ -ISCSI_TCB * -IScsiFindTcbByITT ( - IN LIST_ENTRY *TcbList, - IN UINT32 InitiatorTaskTag - ) -{ - ISCSI_TCB *Tcb; - LIST_ENTRY *Entry; - - Tcb =3D NULL; - - NET_LIST_FOR_EACH (Entry, TcbList) { - Tcb =3D NET_LIST_USER_STRUCT (Entry, ISCSI_TCB, Link); - - if (Tcb->InitiatorTaskTag =3D=3D InitiatorTaskTag) { - break; - } - - Tcb =3D NULL; - } - - return Tcb; -} =20 /** Create a data segment, pad it and calculate the CRC if needed. -- 2.18.0.windows.1