From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 60F0C21962301 for ; Thu, 9 Aug 2018 03:23:45 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 03:23:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,214,1531810800"; d="scan'208";a="223233991" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 09 Aug 2018 03:23:41 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 03:23:41 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 03:23:41 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 18:23:39 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH 22/26] MdeModulePkg HiiDatabaseDxe: Remove a redundant function Thread-Index: AQHULvSPTWnelT4pK0+aTdgrd/rhaqS3OB8Q Date: Thu, 9 Aug 2018 10:23:39 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBAA4DF@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-23-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-23-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 22/26] MdeModulePkg HiiDatabaseDxe: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 10:23:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable There is a typo in commit log. 'calld' should be 'callled'. With the typo fixed, Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 22/26] MdeModulePkg HiiDatabaseDxe: Remove a redundant func= tion The function GetStorageWidth that is never calld has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- .../Universal/HiiDatabaseDxe/ConfigRouting.c | 47 ------------------- 1 file changed, 47 deletions(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b/MdeMod= ulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c index c778cd92f8..39e1811e69 100644 --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c @@ -3590,53 +3590,6 @@ Done: return Status; } =20 -/** - Get Data buffer size based on data type. - - @param ValueType The input data type. - - @retval The data buffer size for the input type. -**/ -UINT16 -GetStorageWidth ( - IN UINT8 ValueType - ) -{ - UINT16 StorageWidth; - - switch (ValueType) { - case EFI_IFR_NUMERIC_SIZE_1: - case EFI_IFR_TYPE_BOOLEAN: - StorageWidth =3D (UINT16) sizeof (UINT8); - break; - - case EFI_IFR_NUMERIC_SIZE_2: - StorageWidth =3D (UINT16) sizeof (UINT16); - break; - - case EFI_IFR_NUMERIC_SIZE_4: - StorageWidth =3D (UINT16) sizeof (UINT32); - break; - - case EFI_IFR_NUMERIC_SIZE_8: - StorageWidth =3D (UINT16) sizeof (UINT64); - break; - - case EFI_IFR_TYPE_TIME: - StorageWidth =3D (UINT16) sizeof (EFI_IFR_TIME); - break; - - case EFI_IFR_TYPE_DATE: - StorageWidth =3D (UINT16) sizeof (EFI_IFR_DATE); - break; - - default: - StorageWidth =3D 0; - break; - } - - return StorageWidth; -} =20 /** Update the default value in the block data which is used as bit var stor= e. -- 2.18.0.windows.1