From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 35180210EB11A for ; Fri, 10 Aug 2018 01:42:59 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 01:42:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,218,1531810800"; d="scan'208";a="75450244" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 10 Aug 2018 01:42:44 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 01:42:44 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 01:42:43 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 16:42:42 +0800 From: "Zeng, Star" To: "Yao, Jiewen" , "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] [PATCH] SignedCapsulePkg: Remove redundant things in inf, .h and .c files Thread-Index: AQHUMHD8DK2UUSEGB0iZ39xRoO/Z9qS4EjgAgACYWmA= Date: Fri, 10 Aug 2018 08:42:42 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABDB7@shsmsx102.ccr.corp.intel.com> References: <20180810061047.31768-1-shenglei.zhang@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AD02399@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AD02399@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SignedCapsulePkg: Remove redundant things in inf, .h and .c files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 08:42:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Shenglei, I know PrintLib is used by ParseConfigProfile.c that is included by SystemF= irmwareUpdateDxe.inf. But could you evaluate whether DxeServicesLib could be removed from SystemF= irmwareUpdateDxe.inf or not? Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,= Jiewen Sent: Friday, August 10, 2018 3:35 PM To: Zhang, Shenglei ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] SignedCapsulePkg: Remove redundant things in in= f, .h and .c files Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > shenglei > Sent: Friday, August 10, 2018 2:11 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH] SignedCapsulePkg: Remove redundant things in inf,= .h > and .c files >=20 > Two redundant library classes have been removed. > The redundant function "IsSystemFmp" has been removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1067 >=20 > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > .../SystemFirmwareCommonDxe.c | 27 ------------------- > .../SystemFirmwareUpdate/SystemFirmwareDxe.h | 1 - > .../SystemFirmwareReportDxe.inf | 2 -- > 3 files changed, 30 deletions(-) >=20 > diff --git > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom > monDxe.c > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom > monDxe.c > index 7f7a9a1982..8e16763597 100644 > --- > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom > monDxe.c > +++ > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom > monDxe.c > @@ -343,31 +343,4 @@ InitializePrivateData ( > return EFI_SUCCESS; > } >=20 > -/** > - Return if this FMP is a system FMP or a device FMP, based upon > FmpImageInfo. > - > - @param[in] FmpImageInfo A pointer to > EFI_FIRMWARE_IMAGE_DESCRIPTOR > - > - @retval TRUE It is a system FMP. > - @retval FALSE It is a device FMP. > -**/ > -BOOLEAN > -IsSystemFmp ( > - IN EFI_FIRMWARE_IMAGE_DESCRIPTOR *FmpImageInfo > - ) > -{ > - GUID *Guid; > - UINTN Count; > - UINTN Index; > - > - Guid =3D PcdGetPtr(PcdSystemFmpCapsuleImageTypeIdGuid); > - Count =3D PcdGetSize(PcdSystemFmpCapsuleImageTypeIdGuid) / > sizeof(GUID); >=20 > - for (Index =3D 0; Index < Count; Index++, Guid++) { > - if (CompareGuid(&FmpImageInfo->ImageTypeId, Guid)) { > - return TRUE; > - } > - } > - > - return FALSE; > -} > diff --git > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe. > h > index 999b2b2501..cd6601e815 100644 > --- > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h > +++ > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe. > h > @@ -36,7 +36,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo > rtDxe.inf > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo > rtDxe.inf > index cc9614ef14..b15736cf0d 100644 > --- > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo > rtDxe.inf > +++ > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo > rtDxe.inf > @@ -50,9 +50,7 @@ > HobLib > UefiRuntimeServicesTableLib > UefiDriverEntryPoint > - DxeServicesLib > DxeServicesTableLib > - PrintLib > EdkiiSystemCapsuleLib >=20 > [Pcd] > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel