From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E70A8210EB11A for ; Fri, 10 Aug 2018 01:47:33 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 01:47:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,218,1531810800"; d="scan'208";a="253630613" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 10 Aug 2018 01:47:33 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 01:47:33 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 01:47:18 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 16:47:15 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdeModulePkg: Remove redundant things in inf and .h files Thread-Index: AQHUL7ygzM46nePu2U2DcGrl+jSkEqS4rbkw Date: Fri, 10 Aug 2018 08:47:14 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABDD7@shsmsx102.ccr.corp.intel.com> References: <20180809084008.26376-1-shenglei.zhang@intel.com> In-Reply-To: <20180809084008.26376-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg: Remove redundant things in inf and .h files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 08:47:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I suggest merging this patch with https://lists.01.org/pipermail/edk2-devel= /2018-August/027953.html to one patch. And remember to update the new patch's version. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of shen= glei Sent: Thursday, August 9, 2018 4:40 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg: Remove redundant things in inf and .h= files A redundant GUID and some library classes are removed https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.h | 1 - MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf | 1 - MdeModulePkg/Core/Dxe/DxeMain.h | 1 - MdeModulePkg/Core/Dxe/DxeMain.inf | 1 - MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 1 - MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 2 -- MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf | 1 - MdeModulePkg/U= niversal/Network/IScsiDxe/IScsiImpl.h | 1 - 8 files changed, 9 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.h b/MdeModule= Pkg/Bus/Pci/NvmExpressPei/NvmExpressPei.h index 5e6f66892f..0bd62c2459 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.h +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.h @@ -33,7 +33,6 @@ #include #include #include -#include #include =20 // diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf b/MdeModu= lePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf index 8b2523a39c..9591572fec 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf @@ -50,7 +50,6 @@ MemoryAllocationLib BaseMemoryLib IoLib - PciLib TimerLib PeimEntryPoint =20 diff --git a/MdeModulePkg/Core/Dxe/DxeMain.h b/MdeModulePkg/Core/Dxe/DxeMai= n.h index 8f0b28d095..2dec9da5e3 100644 --- a/MdeModulePkg/Core/Dxe/DxeMain.h +++ b/MdeModulePkg/Core/Dxe/DxeMain.h @@ -89,7 +89,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include #include #include -#include #= include #include #in= clude diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeM= ain.inf index fc8af3d293..69065d1305 100644 --- a/MdeModulePkg/Core/Dxe/DxeMain.inf +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf @@ -97,7 +97,6 @@ UefiBootServicesTableLib DevicePathLib ReportStatusCodeLib - TimerLib DxeServicesLib DebugAgentLib CpuExceptionHandlerLib diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h b/MdeModulePkg/Core/Pi= SmmCore/PiSmmCore.h index 2d3447e338..cbc27e717d 100644 --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h @@ -58,7 +58,6 @@ #include #include #include -#include #include #include =20 diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf b/MdeModulePkg/Core/= PiSmmCore/PiSmmCore.inf index f11ccb0e07..f3ece22121 100644 --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf @@ -63,7 +63,6 @@ PcdLib SmmCorePlatformHookLib PerformanceLib - TimerLib HobLib SmmMemLib =20 @@ -89,7 +88,6 @@ gEfiSmmGpiDispatch2ProtocolGuid ## SOMETIMES_CONSUMES gEfiSmmIoTrapDispatch2ProtocolGuid ## SOMETIMES_CONSUMES gEfiSmmUsbDispatch2ProtocolGuid ## SOMETIMES_CONSUMES - gEfiSmmCpuProtocolGuid ## SOMETIMES_CONSUMES gEdkiiSmmMemoryAttributeProtocolGuid ## CONSUMES gEfiSmmSxDispatch2ProtocolGuid ## SOMETIMES_CONSUMES =20 diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf b/MdeModu= lePkg/Universal/Network/IScsiDxe/IScsiDxe.inf index dce39681d1..c6e7262cea 100644 --- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf +++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf @@ -108,7 +108,6 @@ gEfiIfrTianoGuid ## SOMETIMES_PRODUCES ## U= NDEFINED gEfiAcpiTableGuid ## SOMETIMES_CONSUMES ## S= ystemTable gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## S= ystemTable - gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## S= ystemTable ## SOMETIMES_PRODUCES ## Variable:L"iSCSIDeviceList" ## SOMETIMES_CONSUMES ## Variable:L"iSCSIDeviceList" ## SOMETIMES_CONSUMES ## UNDEFINED # HiiIsConfigHdrMatch mVendorStorag= eName diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiImpl.h b/MdeModul= ePkg/Universal/Network/IScsiDxe/IScsiImpl.h index 082199c1b7..8a5ee2149e 100644 --- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiImpl.h +++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiImpl.h @@ -26,7 +26,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include =20 #include -#include =20 #include "IScsiCommon.h" #include "IScsiDriver.h" -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel