From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8B37C210EB13F for ; Fri, 10 Aug 2018 01:49:45 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 01:49:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,218,1531810800"; d="scan'208";a="61383035" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 10 Aug 2018 01:49:44 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 01:49:44 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 01:49:44 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 16:49:42 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH] MdeModulePkg: Remove some comments Thread-Index: AQHUMHPFRRUuTjjku02fq+vRicC8zKS4rO6Q Date: Fri, 10 Aug 2018 08:49:41 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABDFB@shsmsx102.ccr.corp.intel.com> References: <20180810063014.3400-1-shenglei.zhang@intel.com> In-Reply-To: <20180810063014.3400-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg: Remove some comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 08:49:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I suggest merging this patch to thread https://lists.01.org/pipermail/edk2-= devel/2018-August/028167.html. Thanks, Star -----Original Message----- From: Zhang, Shenglei=20 Sent: Friday, August 10, 2018 2:30 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH] MdeModulePkg: Remove some comments Some comments including the redundant functions removed before have been re= moved. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 2 -- MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 2 -- MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c b/MdeModulePkg/= Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c index 217736c1a6..a55a34a3dc 100644 --- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c +++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c @@ -281,8 +281,6 @@ EmmcPeimFreeMemPool ( =20 // // Unlink all the memory blocks from the pool, then free them. - // EmmcPeimUnlinkMemBlock can't be used to unlink and free the - // first block. // for (Block =3D Pool->Head->Next; Block !=3D NULL; Block =3D Pool->Head->= Next) { EmmcPeimFreeMemBlock (Pool, Block); diff --git a/MdeModulePkg/Bus/Sd/S= dBlockIoPei/SdHcMem.c b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c index 0c3a424e3b..03b7963716 100644 --- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c +++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c @@ -281,8 +281,6 @@ SdPeimFreeMemPool ( =20 // // Unlink all the memory blocks from the pool, then free them. - // SdPeimUnlinkMemBlock can't be used to unlink and free the - // first block. // for (Block =3D Pool->Head->Next; Block !=3D NULL; Block =3D Pool->Head->= Next) { SdPeimFreeMemBlock (Pool, Block); diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c b/MdeModulePkg/B= us/Ufs/UfsBlockIoPei/UfsHcMem.c index d334faa0bb..6c0b271e68 100644 --- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c +++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c @@ -281,8 +281,6 @@ UfsPeimFreeMemPool ( =20 // // Unlink all the memory blocks from the pool, then free them. - // UfsPeimUnlinkMemBlock can't be used to unlink and free the - // first block. // for (Block =3D Pool->Head->Next; Block !=3D NULL; Block =3D Pool->Head->= Next) { UfsPeimFreeMemBlock (Pool, Block); -- 2.18.0.windows.1