From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B5424210EB129 for ; Fri, 10 Aug 2018 01:57:47 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 01:57:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,218,1531810800"; d="scan'208";a="61384359" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga007.fm.intel.com with ESMTP; 10 Aug 2018 01:57:47 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 01:57:47 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 01:57:46 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 16:57:44 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH 08/26] MdeModulePkg UhciPei: Remove redundant functions Thread-Index: AQHULvR85FNd5Nn6qU+PdGE38Oc1saS4sjYQ Date: Fri, 10 Aug 2018 08:57:44 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABE6A@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-9-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-9-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 08/26] MdeModulePkg UhciPei: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 08:57:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 08/26] MdeModulePkg UhciPei: Remove redundant functions The functions that are never called have been removed. They are IoMmuFreeBuffer,DelinkMemoryBlock,IsMemoryBlockEmptied ,IsTDLinkPtrQHOrTD,GetCurrentFrameNumber,GetQHHorizontalLinkPtr and GetQHHorizontalValidorInvalid. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/UhciPei/DmaMem.c | 22 ----- MdeModulePkg/Bus/Pci/U= hciPei/UhcPeim.c | 125 ------------------------- MdeModulePkg/Bus/Pci/Uhci= Pei/UhcPeim.h | 78 --------------- 3 files changed, 225 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/UhciPei/DmaMem.c b/MdeModulePkg/Bus/Pci/U= hciPei/DmaMem.c index c92bee4298..f4202ba6e6 100644 --- a/MdeModulePkg/Bus/Pci/UhciPei/DmaMem.c +++ b/MdeModulePkg/Bus/Pci/UhciPei/DmaMem.c @@ -205,29 +205,7 @@ IoMmuAllocateBuffer ( return Status; } =20 -/** - Frees memory that was allocated with AllocateBuffer(). - - @param IoMmu Pointer to IOMMU PPI. - @param Pages The number of pages to free. - @param HostAddress The base system memory address of the allocate= d range. - @param Mapping The mapping value returned from Map(). =20 -**/ -VOID -IoMmuFreeBuffer ( - IN EDKII_IOMMU_PPI *IoMmu, - IN UINTN Pages, - IN VOID *HostAddress, - IN VOID *Mapping - ) -{ - if (IoMmu !=3D NULL) { - IoMmu->SetAttribute (IoMmu, Mapping, 0); - IoMmu->Unmap (IoMmu, Mapping); - IoMmu->FreeBuffer (IoMmu, Pages, HostAddress); - } -} =20 /** Initialize IOMMU. diff --git a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c b/MdeModulePkg/Bus/Pci/= UhciPei/UhcPeim.c index ec2daf1649..645c946f29 100644 --- a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c +++ b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c @@ -1252,26 +1252,7 @@ IsStatusOK ( } } =20 -/** - Get Current Frame Number. - - @param UhcDev The UHCI device. - @param FrameNumberAddr The address of frame list register. - - @retval The content of the frame list register. =20 -**/ -UINT16 -GetCurrentFrameNumber ( - IN USB_UHC_DEV *UhcDev, - IN UINT32 FrameNumberAddr - ) -{ - // - // Gets value in the USB frame number register. - // - return (UINT16) (USBReadPortW (UhcDev, FrameNumberAddr) & 0x03FF); -} =20 /** Set Frame List Base Address. @@ -1349,25 +1330,7 @@ SetQHHorizontalLinkPtr ( PtrQH->QueueHead.QHHorizontalPtr =3D (UINT32) (UINTN) PtrNext >> 4; } =20 -/** - Get the horizontal link pointer in QH. - - @param PtrQH Place to store QH_STRUCT pointer. =20 - @retval The horizontal link pointer in QH. - -**/ -VOID * -GetQHHorizontalLinkPtr ( - IN QH_STRUCT *PtrQH - ) -{ - // - // Restore the 28bit address to 32bit address - // (take 32bit address as an example) - // - return (VOID *) (UINTN) ((PtrQH->QueueHead.QHHorizontalPtr) << 4); -} =20 /** Set a QH or TD horizontally to be connected with a specific QH. @@ -1470,25 +1433,7 @@ SetQHVerticalValidorInvalid ( PtrQH->QueueHead.QHVerticalTerminate =3D IsValid ? 0 : 1; } =20 -/** - Get the vertical validor bit in QH. =20 - @param PtrQH Place to store QH_STRUCT pointer. - - @retval The vertical linker is valid or not. - -**/ -BOOLEAN -GetQHHorizontalValidorInvalid ( - IN QH_STRUCT *PtrQH - ) -{ - // - // If TRUE, meaning the Horizontal Link Pointer field is valid, - // else, the field is invalid. - // - return (BOOLEAN) (!(PtrQH->QueueHead.QHHorizontalTerminate)); -} =20 /** Allocate TD or QH Struct. @@ -2000,26 +1945,7 @@ GetTDLinkPtr ( return (VOID *) (UINTN) ((PtrTDStruct->TDData.TDLinkPtr) << 4); } =20 -/** - Get the information about whether the Link Pointer field pointing to - a QH or a TD. =20 - @param PtrTDStruct Place to store TD_STRUCT pointer. - - @retval whether the Link Pointer field pointing to a QH or a TD. - -**/ -BOOLEAN -IsTDLinkPtrQHOrTD ( - IN TD_STRUCT *PtrTDStruct - ) -{ - // - // Get the information about whether the Link Pointer field pointing to - // a QH or a TD. - // - return (BOOLEAN) (PtrTDStruct->TDData.TDLinkPtrQSelect); -} =20 /** Enable/Disable short packet detection mechanism. @@ -3239,60 +3165,9 @@ InsertMemoryHeaderToList ( } } =20 -/** - Judge the memory block in the memory header is empty or not. - - @param MemoryHeaderPtr A pointer to the memory header list. - - @retval Whether the memory block in the memory header is empty or not. - -**/ -BOOLEAN -IsMemoryBlockEmptied ( - IN MEMORY_MANAGE_HEADER *MemoryHeaderPtr - ) -{ - UINTN Index; - - for (Index =3D 0; Index < MemoryHeaderPtr->BitArraySizeInBytes; Index++)= { - if (MemoryHeaderPtr->BitArrayPtr[Index] !=3D 0) { - return FALSE; - } - } - - return TRUE; -} - -/** - remove a memory header from list. =20 - @param FirstMemoryHeader A pointer to the memory header list. - @param FreeMemoryHeader A memory header to be removed into the list. =20 -**/ -VOID -DelinkMemoryBlock ( - IN MEMORY_MANAGE_HEADER *FirstMemoryHeader, - IN MEMORY_MANAGE_HEADER *FreeMemoryHeader - ) -{ - MEMORY_MANAGE_HEADER *TempHeaderPtr; =20 - if ((FirstMemoryHeader =3D=3D NULL) || (FreeMemoryHeader =3D=3D NULL)) { - return ; - } - - for (TempHeaderPtr =3D FirstMemoryHeader; TempHeaderPtr !=3D NULL; TempH= eaderPtr =3D TempHeaderPtr->Next) { - - if (TempHeaderPtr->Next =3D=3D FreeMemoryHeader) { - // - // Link the before and after - // - TempHeaderPtr->Next =3D FreeMemoryHeader->Next; - break; - } - } -} =20 /** Map address of request structure buffer. diff --git a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.h b/MdeModulePkg/Bus/Pci/= UhciPei/UhcPeim.h index 33d4f2f65f..01a9782d76 100644 --- a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.h +++ b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.h @@ -472,21 +472,6 @@ IsStatusOK ( IN UINT32 StatusRegAddr ); =20 -/** - Get Current Frame Number. - - @param UhcDev The UHCI device. - @param FrameNumberAddr The address of frame list register. - - @retval The content of the frame list register. - -**/ -UINT16 -GetCurrentFrameNumber ( - IN USB_UHC_DEV *UhcDev, - IN UINT32 FrameNumberAddr - ); - /** Set Frame List Base Address. =20 @@ -531,19 +516,6 @@ SetQHHorizontalLinkPtr ( IN VOID *PtrNext ); =20 -/** - Get the horizontal link pointer in QH. - - @param PtrQH Place to store QH_STRUCT pointer. - - @retval The horizontal link pointer in QH. - -**/ -VOID * -GetQHHorizontalLinkPtr ( - IN QH_STRUCT *PtrQH - ); - /** Set a QH or TD horizontally to be connected with a specific QH. =20 @@ -609,18 +581,6 @@ SetQHVerticalValidorInvalid ( IN BOOLEAN IsValid ); =20 -/** - Get the vertical validor bit in QH. - - @param PtrQH Place to store QH_STRUCT pointer. - - @retval The vertical linker is valid or not. - -**/ -BOOLEAN -GetQHHorizontalValidorInvalid ( - IN QH_STRUCT *PtrQH - ); =20 /** Allocate TD or QH Struct. @@ -805,19 +765,6 @@ GetTDLinkPtr ( IN TD_STRUCT *PtrTDStruct ); =20 -/** - Get the information about whether the Link Pointer field pointing to - a QH or a TD. - - @param PtrTDStruct Place to store TD_STRUCT pointer. - - @retval whether the Link Pointer field pointing to a QH or a TD. - -**/ -BOOLEAN -IsTDLinkPtrQHOrTD ( - IN TD_STRUCT *PtrTDStruct - ); =20 /** Enable/Disable short packet detection mechanism. @@ -1317,31 +1264,6 @@ InsertMemoryHeaderToList ( IN MEMORY_MANAGE_HEADER *NewMemoryHeader ); =20 -/** - Judge the memory block in the memory header is empty or not. - - @param MemoryHeaderPtr A pointer to the memory header list. - - @retval Whether the memory block in the memory header is empty or not. - -**/ -BOOLEAN -IsMemoryBlockEmptied ( - IN MEMORY_MANAGE_HEADER *MemoryHeaderPtr - ); - -/** - remove a memory header from list. - - @param FirstMemoryHeader A pointer to the memory header list. - @param FreeMemoryHeader A memory header to be removed into the list. - -**/ -VOID -DelinkMemoryBlock ( - IN MEMORY_MANAGE_HEADER *FirstMemoryHeader, - IN MEMORY_MANAGE_HEADER *FreeMemoryHeader - ); =20 /** Map address of request structure buffer. -- 2.18.0.windows.1