From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CA68B210EB129 for ; Fri, 10 Aug 2018 02:01:23 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 02:01:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,218,1531810800"; d="scan'208";a="223535010" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 10 Aug 2018 02:01:11 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:01:11 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:01:10 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.143]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 17:01:08 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH 09/26] MdeModulePkg XhciDxe: Remove redundant functions Thread-Index: AQHULvR9z0Ztnh10BE2KYFimdfYGW6S4s1pQ Date: Fri, 10 Aug 2018 09:01:08 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABE7F@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-10-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-10-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 09/26] MdeModulePkg XhciDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 09:01:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 09/26] MdeModulePkg XhciDxe: Remove redundant functions The functions that are never called have been removed. They are XhcReadDoorBellReg and XhcWriteOpReg16. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c | 66 -------------------------- Md= eModulePkg/Bus/Pci/XhciDxe/XhciReg.h | 28 ----------- 2 files changed, 94 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c b/MdeModulePkg/Bus/Pci/= XhciDxe/XhciReg.c index 4d5937de53..5f0736a516 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c @@ -158,75 +158,9 @@ XhcWriteOpReg ( } } =20 -/** - Write the data to the 2-bytes width XHCI operational register. =20 - @param Xhc The XHCI Instance. - @param Offset The offset of the 2-bytes width operational registe= r. - @param Data The data to write. =20 -**/ -VOID -XhcWriteOpReg16 ( - IN USB_XHCI_INSTANCE *Xhc, - IN UINT32 Offset, - IN UINT16 Data - ) -{ - EFI_STATUS Status; - - ASSERT (Xhc->CapLength !=3D 0); - - Status =3D Xhc->PciIo->Mem.Write ( - Xhc->PciIo, - EfiPciIoWidthUint16, - XHC_BAR_INDEX, - Xhc->CapLength + Offset, - 1, - &Data - ); - - if (EFI_ERROR (Status)) { - DEBUG ((EFI_D_ERROR, "XhcWriteOpReg16: Pci Io Write error: %r at %d\n"= , Status, Offset)); - } -} - -/** - Read XHCI door bell register. - - @param Xhc The XHCI Instance. - @param Offset The offset of the door bell register. =20 - @return The register content read - -**/ -UINT32 -XhcReadDoorBellReg ( - IN USB_XHCI_INSTANCE *Xhc, - IN UINT32 Offset - ) -{ - UINT32 Data; - EFI_STATUS Status; - - ASSERT (Xhc->DBOff !=3D 0); - - Status =3D Xhc->PciIo->Mem.Read ( - Xhc->PciIo, - EfiPciIoWidthUint32, - XHC_BAR_INDEX, - Xhc->DBOff + Offset, - 1, - &Data - ); - - if (EFI_ERROR (Status)) { - DEBUG ((EFI_D_ERROR, "XhcReadDoorBellReg: Pci Io Read error - %r at %d= \n", Status, Offset)); - Data =3D 0xFFFFFFFF; - } - - return Data; -} =20 /** Write the data to the XHCI door bell register. diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h b/MdeModulePkg/Bus/Pci/= XhciDxe/XhciReg.h index 838a44628c..20e7ac0e8f 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h @@ -286,20 +286,6 @@ XhcWriteOpReg ( IN UINT32 Data ); =20 -/** - Write the data to the 2-bytes width XHCI operational register. - - @param Xhc The XHCI Instance. - @param Offset The offset of the 2-bytes width operational registe= r. - @param Data The data to write. - -**/ -VOID -XhcWriteOpReg16 ( - IN USB_XHCI_INSTANCE *Xhc, - IN UINT32 Offset, - IN UINT16 Data - ); =20 /** Read XHCI runtime register. @@ -331,20 +317,6 @@ XhcWriteRuntimeReg ( IN UINT32 Data ); =20 -/** - Read XHCI door bell register. - - @param Xhc The XHCI Instance. - @param Offset The offset of the door bell register. - - @return The register content read - -**/ -UINT32 -XhcReadDoorBellReg ( - IN USB_XHCI_INSTANCE *Xhc, - IN UINT32 Offset - ); =20 /** Write the data to the XHCI door bell register. -- 2.18.0.windows.1