From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0BCAC210EB122 for ; Fri, 10 Aug 2018 02:01:22 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 02:01:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,218,1531810800"; d="scan'208";a="80578453" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 10 Aug 2018 02:01:22 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:01:22 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:01:21 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.143]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 17:01:19 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant functions Thread-Index: AQHULvR+n0vqbXovYEyYiAOT3WUPsaS4s3jQ Date: Fri, 10 Aug 2018 09:01:18 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABE93@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-11-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-11-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 09:01:23 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant functions The functions that are never called have been removed. They are XhcPeiReadDoorBellReg and UsbHcUnlinkMemBlock. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c | 24 ------------------------ Mde= ModulePkg/Bus/Pci/XhciPei/XhcPeim.c | 22 ---------------------- MdeModule= Pkg/Bus/Pci/XhciPei/XhciReg.h | 14 -------------- 3 files changed, 60 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c b/MdeModulePkg/Bus/Pci= /XhciPei/UsbHcMem.c index 5d0232ca56..442a613095 100644 --- a/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c +++ b/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c @@ -328,31 +328,7 @@ UsbHcIsMemBlockEmpty ( return TRUE; } =20 -/** - Unlink the memory block from the pool's list. - - @param Head The block list head of the memory's pool. - @param BlockToUnlink The memory block to unlink. =20 -**/ -VOID -UsbHcUnlinkMemBlock ( - IN USBHC_MEM_BLOCK *Head, - IN USBHC_MEM_BLOCK *BlockToUnlink - ) -{ - USBHC_MEM_BLOCK *Block; - - ASSERT ((Head !=3D NULL) && (BlockToUnlink !=3D NULL)); - - for (Block =3D Head; Block !=3D NULL; Block =3D Block->Next) { - if (Block->Next =3D=3D BlockToUnlink) { - Block->Next =3D BlockToUnlink->Next; - BlockToUnlink->Next =3D NULL; - break; - } - } -} =20 /** Initialize the memory management pool for the host controller. diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c b/MdeModulePkg/Bus/Pci/= XhciPei/XhcPeim.c index c5631e87ca..ee4d1f97bd 100644 --- a/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c @@ -211,29 +211,7 @@ XhcPeiReadCapRegister ( return Data; } =20 -/** - Read XHCI door bell register. - - @param Xhc The XHCI device. - @param Offset The offset of the door bell register. - - @return The register content read =20 -**/ -UINT32 -XhcPeiReadDoorBellReg ( - IN PEI_XHC_DEV *Xhc, - IN UINT32 Offset - ) -{ - UINT32 Data; - - ASSERT (Xhc->DBOff !=3D 0); - - Data =3D MmioRead32 (Xhc->UsbHostControllerBaseAddress + Xhc->DBOff + Of= fset); - - return Data; -} =20 /** Write the data to the XHCI door bell register. diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhciReg.h b/MdeModulePkg/Bus/Pci/= XhciPei/XhciReg.h index 0297072ffd..3787aeccf5 100644 --- a/MdeModulePkg/Bus/Pci/XhciPei/XhciReg.h +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhciReg.h @@ -302,20 +302,6 @@ XhcPeiWaitOpRegBit ( IN UINT32 Timeout ); =20 -/** - Read XHCI door bell register. - - @param Xhc The XHCI device. - @param Offset The offset of the door bell register. - - @return The register content read - -**/ -UINT32 -XhcPeiReadDoorBellReg ( - IN PEI_XHC_DEV *Xhc, - IN UINT32 Offset - ); =20 /** Write the data to the XHCI door bell register. -- 2.18.0.windows.1