From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6D4AF210EB136 for ; Fri, 10 Aug 2018 02:08:47 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 02:08:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,218,1531810800"; d="scan'208";a="223536614" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 10 Aug 2018 02:08:27 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:08:25 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:08:24 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 17:08:22 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH 15/26] MdeModulePkg UsbBusPei: Remove redundant functions Thread-Index: AQHULvSDtVvF9LF4uEuAXU0qJbplm6S4tXEA Date: Fri, 10 Aug 2018 09:08:22 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABEE9@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-16-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-16-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 15/26] MdeModulePkg UsbBusPei: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 09:08:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 15/26] MdeModulePkg UsbBusPei: Remove redundant functions The functions that are never called have been removed. They are PeiHubSetHubFeature,IsPortConnectChange and PeiUsbClearDeviceFeatu= re. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c | 39 ----------- MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h | 18 ----- MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c | 77 ---------------------- Md= eModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h | 35 ---------- 4 files changed, 169 deletions(-) diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c b/MdeModulePkg/Bus/Us= b/UsbBusPei/HubPeim.c index 806602511c..5607c65b13 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c +++ b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c @@ -193,46 +193,7 @@ PeiHubGetHubStatus ( ); } =20 -/** - Set specified feature to a given hub. - - @param PeiServices General-purpose services that are available to eve= ry PEIM. - @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance. - @param Value New feature value. - - @retval EFI_SUCCESS Port feature is set successfully. - @retval EFI_DEVICE_ERROR Cannot set the port feature due to a hardware = error. - @retval Others Other failure occurs. - -**/ -EFI_STATUS -PeiHubSetHubFeature ( - IN EFI_PEI_SERVICES **PeiServices, - IN PEI_USB_IO_PPI *UsbIoPpi, - IN UINT8 Value - ) -{ - EFI_USB_DEVICE_REQUEST DeviceRequest; =20 - ZeroMem (&DeviceRequest, sizeof (EFI_USB_DEVICE_REQUEST)); - - // - // Fill Device request packet - // - DeviceRequest.RequestType =3D USB_HUB_SET_HUB_FEATURE_REQ_TYPE; - DeviceRequest.Request =3D USB_HUB_SET_HUB_FEATURE; - DeviceRequest.Value =3D Value; - - return UsbIoPpi->UsbControlTransfer ( - PeiServices, - UsbIoPpi, - &DeviceRequest, - EfiUsbNoData, - PcdGet32 (PcdUsbTransferTimeoutValue), - NULL, - 0 - ); -} =20 /** Clear specified feature on a given hub. diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h b/MdeModulePkg/Bus/Us= b/UsbBusPei/HubPeim.h index 385a14ec0d..d21057c349 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h +++ b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h @@ -145,24 +145,6 @@ PeiHubSetPortFeature ( IN UINT8 Value ); =20 -/** - Set specified feature to a given hub. - - @param PeiServices General-purpose services that are available to eve= ry PEIM. - @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance. - @param Value New feature value. - - @retval EFI_SUCCESS Port feature is set successfully. - @retval EFI_DEVICE_ERROR Cannot set the port feature due to a hardware = error. - @retval Others Other failure occurs. - -**/ -EFI_STATUS -PeiHubSetHubFeature ( - IN EFI_PEI_SERVICES **PeiServices, - IN PEI_USB_IO_PPI *UsbIoPpi, - IN UINT8 Value - ); =20 /** Get a given hub status. diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c b/MdeModulePkg/Bus/= Usb/UsbBusPei/PeiUsbLib.c index c5e599e2f7..73a163e7a0 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c +++ b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c @@ -104,62 +104,7 @@ PeiUsbSetDeviceAddress ( ); } =20 -/** - Clear a given usb feature. - - @param PeiServices General-purpose services that are available to= every PEIM. - @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance. - @param Recipient The recipient of ClearFeature Request, should = be one of Device/Interface/Endpoint. - @param Value Request Value. - @param Target Request Index. - - @retval EFI_SUCCESS Usb feature is cleared successfully. - @retval EFI_DEVICE_ERROR Cannot clear the usb feature due to a hardware= error. - @retval Others Other failure occurs. =20 -**/ -EFI_STATUS -PeiUsbClearDeviceFeature ( - IN EFI_PEI_SERVICES **PeiServices, - IN PEI_USB_IO_PPI *UsbIoPpi, - IN EFI_USB_RECIPIENT Recipient, - IN UINT16 Value, - IN UINT16 Target - ) -{ - EFI_USB_DEVICE_REQUEST DevReq; - - ASSERT (UsbIoPpi !=3D NULL); - - switch (Recipient) { - case EfiUsbDevice: - DevReq.RequestType =3D USB_DEV_CLEAR_FEATURE_REQ_TYPE_D; - break; - - case EfiUsbInterface: - DevReq.RequestType =3D USB_DEV_CLEAR_FEATURE_REQ_TYPE_I; - break; - - case EfiUsbEndpoint: - DevReq.RequestType =3D USB_DEV_CLEAR_FEATURE_REQ_TYPE_E; - break; - } - - DevReq.Request =3D USB_DEV_CLEAR_FEATURE; - DevReq.Value =3D Value; - DevReq.Index =3D Target; - DevReq.Length =3D 0; - - return UsbIoPpi->UsbControlTransfer ( - PeiServices, - UsbIoPpi, - &DevReq, - EfiUsbNoData, - PcdGet32 (PcdUsbTransferTimeoutValue), - NULL, - 0 - ); -} =20 /** Configure a usb device to Configuration 1. @@ -244,26 +189,4 @@ PeiUsbGetDeviceSpeed ( } } =20 -/** - Judge if the port is in "connection change" status or not. - - @param PortChangeStatus The usb port change status gotten. - - @retval TRUE The port is in "connection change" status. - @retval FALSE The port is NOT in "connection change" status. =20 -**/ -BOOLEAN -IsPortConnectChange ( - IN UINT16 PortChangeStatus - ) -{ - // - // return the bit 0 value of PortChangeStatus - // - if ((PortChangeStatus & USB_PORT_STAT_C_CONNECTION) !=3D 0) { - return TRUE; - } else { - return FALSE; - } -} diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h b/MdeModulePkg/Bus/= Usb/UsbBusPei/PeiUsbLib.h index 35f47a35ec..e3afee6e84 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h +++ b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h @@ -148,28 +148,6 @@ PeiUsbSetDeviceAddress ( IN UINT16 AddressValue ); =20 -/** - Clear a given usb feature. - - @param PeiServices General-purpose services that are available to= every PEIM. - @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance. - @param Recipient The recipient of ClearFeature Request, should = be one of Device/Interface/Endpoint. - @param Value Request Value. - @param Target Request Index. - - @retval EFI_SUCCESS Usb feature is cleared successfully. - @retval EFI_DEVICE_ERROR Cannot clear the usb feature due to a hardware= error. - @retval Others Other failure occurs. - -**/ -EFI_STATUS -PeiUsbClearDeviceFeature ( - IN EFI_PEI_SERVICES **PeiServices, - IN PEI_USB_IO_PPI *UsbIoPpi, - IN EFI_USB_RECIPIENT Recipient, - IN UINT16 Value, - IN UINT16 Target - ); =20 /** Configure a usb device to Configuration 1. @@ -215,17 +193,4 @@ PeiUsbGetDeviceSpeed ( IN UINT16 PortStatus ); =20 -/** - Judge if the port is in "connection change" status or not. - - @param PortChangeStatus The usb port change status gotten. - - @retval TRUE The port is in "connection change" status. - @retval FALSE The port is NOT in "connection change" status. - -**/ -BOOLEAN -IsPortConnectChange ( - IN UINT16 PortChangeStatus - ); #endif -- 2.18.0.windows.1