From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE822210EB136 for ; Fri, 10 Aug 2018 02:09:38 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 02:09:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,218,1531810800"; d="scan'208";a="223536778" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 10 Aug 2018 02:09:23 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:09:18 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:09:18 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.143]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 17:09:16 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH 14/26] MdeModulePkg UsbBusDxe: Remove redundant functions Thread-Index: AQHULvSDfMO1JrKQ5UC5L3vZXBD4haS4tbDw Date: Fri, 10 Aug 2018 09:09:15 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABEFE@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-15-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-15-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 14/26] MdeModulePkg UsbBusDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 09:09:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 14/26] MdeModulePkg UsbBusDxe: Remove redundant functions The functions that are never called have been removed. They are UsbHubCtrlSetHubFeature,UsbHubCtrlResetTT,UsbHcReset, UsbHcAsyncIsochronousTransfer,UsbHcGetState,UsbHcSetState and UsbHcIsochron= ousTransfer. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c | 68 --------- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 146 -------------------- Md= eModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h | 114 --------------- 3 files changed, 328 deletions(-) diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c b/MdeModulePkg/Bus/Usb= /UsbBusDxe/UsbHub.c index 2ce5726e63..fdb3276a82 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c @@ -317,74 +317,6 @@ UsbHubCtrlGetPortStatus ( } =20 =20 -/** - Usb hub control transfer to reset the TT (Transaction Transaltor). - - @param HubDev The hub device. - @param Port The port of the hub. - - @retval EFI_SUCCESS The TT of the hub is reset. - @retval Others Failed to reset the port. - -**/ -EFI_STATUS -UsbHubCtrlResetTT ( - IN USB_DEVICE *HubDev, - IN UINT8 Port - ) -{ - EFI_STATUS Status; - - Status =3D UsbCtrlRequest ( - HubDev, - EfiUsbNoData, - USB_REQ_TYPE_CLASS, - USB_HUB_TARGET_HUB, - USB_HUB_REQ_RESET_TT, - 0, - (UINT16) (Port + 1), - NULL, - 0 - ); - - return Status; -} - - -/** - Usb hub control transfer to set the hub feature. - - @param HubDev The hub device. - @param Feature The feature to set. - - @retval EFI_SUCESS The feature is set for the hub. - @retval Others Failed to set the feature. - -**/ -EFI_STATUS -UsbHubCtrlSetHubFeature ( - IN USB_DEVICE *HubDev, - IN UINT8 Feature - ) -{ - EFI_STATUS Status; - - Status =3D UsbCtrlRequest ( - HubDev, - EfiUsbNoData, - USB_REQ_TYPE_CLASS, - USB_HUB_TARGET_HUB, - USB_HUB_REQ_SET_FEATURE, - Feature, - 0, - NULL, - 0 - ); - - return Status; -} - - /** Usb hub control transfer to set the port feature. =20 diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c b/MdeModulePkg/Bus= /Usb/UsbBusDxe/UsbUtility.c index e9b5fefb9a..e405edfd4a 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c @@ -90,90 +90,12 @@ UsbHcGetCapability ( } =20 =20 -/** - Reset the host controller. =20 - @param UsbBus The usb bus driver. - @param Attributes The reset type, only global reset is used = by this driver. =20 - @retval EFI_SUCCESS The reset operation succeeded. - @retval EFI_INVALID_PARAMETER Attributes is not valid. - @retval EFI_UNSUPPOURTED The type of reset specified by Attributes = is - not currently supported by the host contro= ller. - @retval EFI_DEVICE_ERROR Host controller isn't halted to reset. -**/ -EFI_STATUS -UsbHcReset ( - IN USB_BUS *UsbBus, - IN UINT16 Attributes - ) -{ - EFI_STATUS Status; =20 - if (UsbBus->Usb2Hc !=3D NULL) { - Status =3D UsbBus->Usb2Hc->Reset (UsbBus->Usb2Hc, Attributes); - } else { - Status =3D UsbBus->UsbHc->Reset (UsbBus->UsbHc, Attributes); - } =20 - return Status; -} =20 =20 -/** - Get the current operation state of the host controller. - - @param UsbBus The USB bus driver. - @param State The host controller operation state. - - @retval EFI_SUCCESS The operation state is returned in State. - @retval Others Failed to get the host controller state. - -**/ -EFI_STATUS -UsbHcGetState ( - IN USB_BUS *UsbBus, - OUT EFI_USB_HC_STATE *State - ) -{ - EFI_STATUS Status; - - if (UsbBus->Usb2Hc !=3D NULL) { - Status =3D UsbBus->Usb2Hc->GetState (UsbBus->Usb2Hc, State); - } else { - Status =3D UsbBus->UsbHc->GetState (UsbBus->UsbHc, State); - } - - return Status; -} - - -/** - Set the host controller operation state. - - @param UsbBus The USB bus driver. - @param State The state to set. - - @retval EFI_SUCCESS The host controller is now working at State. - @retval Others Failed to set operation state. - -**/ -EFI_STATUS -UsbHcSetState ( - IN USB_BUS *UsbBus, - IN EFI_USB_HC_STATE State - ) -{ - EFI_STATUS Status; - - if (UsbBus->Usb2Hc !=3D NULL) { - Status =3D UsbBus->Usb2Hc->SetState (UsbBus->Usb2Hc, State); - } else { - Status =3D UsbBus->UsbHc->SetState (UsbBus->UsbHc, State); - } - - return Status; -} =20 =20 /** @@ -563,78 +485,10 @@ UsbHcSyncInterruptTransfer ( } =20 =20 -/** - Execute a synchronous Isochronous USB transfer. - - @param UsbBus The USB bus driver. - @param DevAddr The target device address. - @param EpAddr The target endpoint address, with direction enc= oded in - bit 7. - @param DevSpeed The device's speed. - @param MaxPacket The endpoint's max packet size. - @param BufferNum The number of data buffer. - @param Data Array of pointers to data buffer. - @param DataLength The length of data buffer. - @param Translator The transaction translator for low/full speed d= evice. - @param UsbResult The result of USB execution. - - @retval EFI_UNSUPPORTED The isochronous transfer isn't supported now. - -**/ -EFI_STATUS -UsbHcIsochronousTransfer ( - IN USB_BUS *UsbBus, - IN UINT8 DevAddr, - IN UINT8 EpAddr, - IN UINT8 DevSpeed, - IN UINTN MaxPacket, - IN UINT8 BufferNum, - IN OUT VOID *Data[EFI_USB_MAX_ISO_BUFFER_NUM= ], - IN UINTN DataLength, - IN EFI_USB2_HC_TRANSACTION_TRANSLATOR *Translator, - OUT UINT32 *UsbResult - ) -{ - return EFI_UNSUPPORTED; -} =20 =20 -/** - Queue an asynchronous isochronous transfer. =20 - @param UsbBus The USB bus driver. - @param DevAddr The target device address. - @param EpAddr The target endpoint address, with direction enc= oded in - bit 7. - @param DevSpeed The device's speed. - @param MaxPacket The endpoint's max packet size. - @param BufferNum The number of data buffer. - @param Data Array of pointers to data buffer. - @param DataLength The length of data buffer. - @param Translator The transaction translator for low/full speed d= evice. - @param Callback The function to call when data is transferred. - @param Context The context to the callback function. - - @retval EFI_UNSUPPORTED The asynchronous isochronous transfer isn't sup= ported. =20 -**/ -EFI_STATUS -UsbHcAsyncIsochronousTransfer ( - IN USB_BUS *UsbBus, - IN UINT8 DevAddr, - IN UINT8 EpAddr, - IN UINT8 DevSpeed, - IN UINTN MaxPacket, - IN UINT8 BufferNum, - IN OUT VOID *Data[EFI_USB_MAX_ISO_BUFFER_NUM= ], - IN UINTN DataLength, - IN EFI_USB2_HC_TRANSACTION_TRANSLATOR *Translator, - IN EFI_ASYNC_USB_TRANSFER_CALLBACK Callback, - IN VOID *Context - ) -{ - return EFI_UNSUPPORTED; -} =20 =20 /** diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h b/MdeModulePkg/Bus= /Usb/UsbBusDxe/UsbUtility.h index 26709caa36..ef19e77c40 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h @@ -36,55 +36,6 @@ UsbHcGetCapability ( OUT UINT8 *Is64BitCapable ); =20 -/** - Reset the host controller. - - @param UsbBus The usb bus driver. - @param Attributes The reset type, only global reset is used = by this driver. - - @retval EFI_SUCCESS The reset operation succeeded. - @retval EFI_INVALID_PARAMETER Attributes is not valid. - @retval EFI_UNSUPPOURTED The type of reset specified by Attributes = is - not currently supported by the host contro= ller. - @retval EFI_DEVICE_ERROR Host controller isn't halted to reset. -**/ -EFI_STATUS -UsbHcReset ( - IN USB_BUS *UsbBus, - IN UINT16 Attributes - ); - -/** - Get the current operation state of the host controller. - - @param UsbBus The USB bus driver. - @param State The host controller operation state. - - @retval EFI_SUCCESS The operation state is returned in State. - @retval Others Failed to get the host controller state. - -**/ -EFI_STATUS -UsbHcGetState ( - IN USB_BUS *UsbBus, - OUT EFI_USB_HC_STATE *State - ); - -/** - Set the host controller operation state. - - @param UsbBus The USB bus driver. - @param State The state to set. - - @retval EFI_SUCCESS The host controller is now working at State. - @retval Others Failed to set operation state. - -**/ -EFI_STATUS -UsbHcSetState ( - IN USB_BUS *UsbBus, - IN EFI_USB_HC_STATE State - ); =20 /** Get the root hub port state. @@ -286,71 +237,6 @@ UsbHcSyncInterruptTransfer ( OUT UINT32 *UsbResult ); =20 -/** - Execute a synchronous Isochronous USB transfer. - - @param UsbBus The USB bus driver. - @param DevAddr The target device address. - @param EpAddr The target endpoint address, with direction enc= oded in - bit 7. - @param DevSpeed The device's speed. - @param MaxPacket The endpoint's max packet size. - @param BufferNum The number of data buffer. - @param Data Array of pointers to data buffer. - @param DataLength The length of data buffer. - @param Translator The transaction translator for low/full speed d= evice. - @param UsbResult The result of USB execution. - - @retval EFI_UNSUPPORTED The isochronous transfer isn't supported now. - -**/ -EFI_STATUS -UsbHcIsochronousTransfer ( - IN USB_BUS *UsbBus, - IN UINT8 DevAddr, - IN UINT8 EpAddr, - IN UINT8 DevSpeed, - IN UINTN MaxPacket, - IN UINT8 BufferNum, - IN OUT VOID *Data[EFI_USB_MAX_ISO_BUFFER_NUM= ], - IN UINTN DataLength, - IN EFI_USB2_HC_TRANSACTION_TRANSLATOR *Translator, - OUT UINT32 *UsbResult - ); - -/** - Queue an asynchronous isochronous transfer. - - @param UsbBus The USB bus driver. - @param DevAddr The target device address. - @param EpAddr The target endpoint address, with direction enc= oded in - bit 7. - @param DevSpeed The device's speed. - @param MaxPacket The endpoint's max packet size. - @param BufferNum The number of data buffer. - @param Data Array of pointers to data buffer. - @param DataLength The length of data buffer. - @param Translator The transaction translator for low/full speed d= evice. - @param Callback The function to call when data is transferred. - @param Context The context to the callback function. - - @retval EFI_UNSUPPORTED The asynchronous isochronous transfer isn't sup= ported. - -**/ -EFI_STATUS -UsbHcAsyncIsochronousTransfer ( - IN USB_BUS *UsbBus, - IN UINT8 DevAddr, - IN UINT8 EpAddr, - IN UINT8 DevSpeed, - IN UINTN MaxPacket, - IN UINT8 BufferNum, - IN OUT VOID *Data[EFI_USB_MAX_ISO_BUFFER_NUM= ], - IN UINTN DataLength, - IN EFI_USB2_HC_TRANSACTION_TRANSLATOR *Translator, - IN EFI_ASYNC_USB_TRANSFER_CALLBACK Callback, - IN VOID *Context - ); =20 /** Open the USB host controller protocol BY_CHILD. -- 2.18.0.windows.1