From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 403C3210EB4C0 for ; Fri, 10 Aug 2018 02:13:55 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 02:13:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,218,1531810800"; d="scan'208";a="252962552" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 10 Aug 2018 02:13:55 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:13:55 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:13:55 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 17:13:53 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function Thread-Index: AQHULvR5AR3IGlmdjU2wVU3nyjW5TKS3NCdAgAGCvXA= Date: Fri, 10 Aug 2018 09:13:51 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABF44@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-2-shenglei.zhang@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BBAA422@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BBAA422@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 09:13:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry, I meant 'called'. -----Original Message----- From: Zeng, Star=20 Sent: Thursday, August 9, 2018 6:10 PM To: Zhang, Shenglei ; edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star Subject: RE: [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant func= tion There is a typo in commit log. 'calld' should be 'callled'. With the typo fixed, Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function The function DumpImageAuthentication that is never calld has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- .../Application/CapsuleApp/CapsuleDump.c | 31 ------------------- 1 file changed, 31 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModuleP= kg/Application/CapsuleApp/CapsuleDump.c index 45c3ecd050..7a3eb94362 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c @@ -106,37 +106,6 @@ DumpUxCapsule ( Print(L" OffsetY - 0x%x\n", DisplayCapsule->ImagePayload.Offse= tY); } =20 -/** - Dump FMP image authentication information. - - @param[in] Image The FMP capsule image - @param[in] ImageSize The size of the FMP capsule image in bytes. - - @return the size of FMP authentication. -**/ -UINTN -DumpImageAuthentication ( - IN VOID *Image, - IN UINTN ImageSize - ) -{ - EFI_FIRMWARE_IMAGE_AUTHENTICATION *ImageAuthentication; - - ImageAuthentication =3D Image; - if (CompareGuid(&ImageAuthentication->AuthInfo.CertType, &gEfiCertPkcs7G= uid) || - CompareGuid(&ImageAuthentication->AuthInfo.CertType, &gEfiCertTypeRs= a2048Sha256Guid)) { - Print(L"[ImageAuthentication]\n"); - Print(L" MonotonicCount - 0x%lx\n", ImageAuthentication->MonotonicC= ount); - Print(L"WIN_CERTIFICATE:\n"); - Print(L" dwLength - 0x%x\n", ImageAuthentication->AuthInfo.Hd= r.dwLength); - Print(L" wRevision - 0x%x\n", ImageAuthentication->AuthInfo.Hd= r.wRevision); - Print(L" wCertificateType - 0x%x\n", ImageAuthentication->AuthInfo.Hd= r.wCertificateType); - Print(L" CertType - %g\n", &ImageAuthentication->AuthInfo.Cer= tType); - return sizeof(ImageAuthentication->MonotonicCount) + ImageAuthenticati= on->AuthInfo.Hdr.dwLength; - } else { - return 0; - } -} =20 /** Dump a non-nested FMP capsule. -- 2.18.0.windows.1