From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F748210EB4C9 for ; Fri, 10 Aug 2018 02:17:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 02:17:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,219,1531810800"; d="scan'208";a="79171078" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 10 Aug 2018 02:16:48 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:16:47 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Aug 2018 02:16:47 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 17:16:45 +0800 From: "Zeng, Star" To: "Wu, Hao A" , "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 20/26] MdeModulePkg SdBlockIoPei: Remove a redundant function Thread-Index: AQHULvSKoBU+i4Lxi0eNhOi7ztqeo6S3x96AgADv4DA= Date: Fri, 10 Aug 2018 09:16:44 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABFB9@shsmsx102.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-21-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 20/26] MdeModulePkg SdBlockIoPei: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 09:17:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I agree with Hao. And there is a typo in commit log. 'calld' should be 'called'. With the typo fixed, Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Wu, Hao A=20 Sent: Friday, August 10, 2018 10:58 AM To: Zhang, Shenglei ; edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star Subject: RE: [edk2] [PATCH 20/26] MdeModulePkg SdBlockIoPei: Remove a redun= dant function One minor comment: Please help to remove the comment that mentioned 'SdPeimUnlinkMemBlock' within function SdPeimFreeMemPool(). For me, // // Unlink all the memory blocks from the pool, then free them. // will be fine. With that change, Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > shenglei > Sent: Wednesday, August 08, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Zeng, Star > Subject: [edk2] [PATCH 20/26] MdeModulePkg SdBlockIoPei: Remove a=20 > redundant function >=20 > The function SdPeimUnlinkMemBlock that is never calld has been=20 > removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 24=20 > ---------------------- > 1 file changed, 24 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c > b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c > index 24ad3dc6c2..0c3a424e3b 100644 > --- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c > +++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c > @@ -219,31 +219,7 @@ SdPeimIsMemBlockEmpty ( > return TRUE; > } >=20 > -/** > - Unlink the memory block from the pool's list. > - > - @param Head The block list head of the memory's pool. > - @param BlockToUnlink The memory block to unlink. >=20 > -**/ > -VOID > -SdPeimUnlinkMemBlock ( > - IN SD_PEIM_MEM_BLOCK *Head, > - IN SD_PEIM_MEM_BLOCK *BlockToUnlink > - ) > -{ > - SD_PEIM_MEM_BLOCK *Block; > - > - ASSERT ((Head !=3D NULL) && (BlockToUnlink !=3D NULL)); > - > - for (Block =3D Head; Block !=3D NULL; Block =3D Block->Next) { > - if (Block->Next =3D=3D BlockToUnlink) { > - Block->Next =3D BlockToUnlink->Next; > - BlockToUnlink->Next =3D NULL; > - break; > - } > - } > -} >=20 > /** > Initialize the memory management pool for the host controller. > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel