From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 143CA210EE4FB for ; Mon, 13 Aug 2018 19:34:57 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2018 19:34:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,236,1531810800"; d="scan'208";a="64697060" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 13 Aug 2018 19:34:54 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 13 Aug 2018 19:34:54 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 13 Aug 2018 19:34:53 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Tue, 14 Aug 2018 10:34:51 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Zeng, Star" Thread-Topic: [edk2] [PATCH v2] SignedCapsulePkg: Remove redundant things in inf, .h and .c files Thread-Index: AQHUM3UnxP6Kqk9DJkq6YnLqfeU4EqS+h77g Date: Tue, 14 Aug 2018 02:34:51 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBACDF6@shsmsx102.ccr.corp.intel.com> References: <20180814021828.16936-1-shenglei.zhang@intel.com> In-Reply-To: <20180814021828.16936-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] SignedCapsulePkg: Remove redundant things in inf, .h and .c files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 02:34:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of shen= glei Sent: Tuesday, August 14, 2018 10:18 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [edk2] [PATCH v2] SignedCapsulePkg: Remove redundant things in inf= , .h and .c files Two redundant library classes have been removed. The redundant function "IsSystemFmp" has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1067 v2: Remove DxeServicesLib from SystemFirmwareUpdateDxe.inf. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Jiewen Yao --- .../SystemFirmwareCommonDxe.c | 27 ------------------- .../SystemFirmwareUpdate/SystemFirmwareDxe.h | 1 - .../SystemFirmwareReportDxe.inf | 2 -- .../SystemFirmwareUpdateDxe.inf | 1 - 4 files changed, 31 deletions(-) diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmware= CommonDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwar= eCommonDxe.c index 7f7a9a1982..8e16763597 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonD= xe.c +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareComm +++ onDxe.c @@ -343,31 +343,4 @@ InitializePrivateData ( return EFI_SUCCESS; } =20 -/** - Return if this FMP is a system FMP or a device FMP, based upon FmpImageI= nfo. - - @param[in] FmpImageInfo A pointer to EFI_FIRMWARE_IMAGE_DESCRIPTOR - - @retval TRUE It is a system FMP. - @retval FALSE It is a device FMP. -**/ -BOOLEAN -IsSystemFmp ( - IN EFI_FIRMWARE_IMAGE_DESCRIPTOR *FmpImageInfo - ) -{ - GUID *Guid; - UINTN Count; - UINTN Index; - - Guid =3D PcdGetPtr(PcdSystemFmpCapsuleImageTypeIdGuid); - Count =3D PcdGetSize(PcdSystemFmpCapsuleImageTypeIdGuid) / sizeof(GUID); =20 - for (Index =3D 0; Index < Count; Index++, Guid++) { - if (CompareGuid(&FmpImageInfo->ImageTypeId, Guid)) { - return TRUE; - } - } - - return FALSE; -} diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmware= Dxe.h b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h index 999b2b2501..cd6601e815 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe. +++ h @@ -36,7 +36,6 @@ #include #include #include -#include #inc= lude #include #include diff --git a/SignedCapsulePkg/U= niversal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf b/SignedCapsulePk= g/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf index cc9614ef14..b15736cf0d 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportD= xe.inf +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo +++ rtDxe.inf @@ -50,9 +50,7 @@ HobLib UefiRuntimeServicesTableLib UefiDriverEntryPoint - DxeServicesLib DxeServicesTableLib - PrintLib EdkiiSystemCapsuleLib =20 [Pcd] diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmware= UpdateDxe.inf b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmw= areUpdateDxe.inf index 2695fb6eb5..7ddea3679e 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateD= xe.inf +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpda +++ teDxe.inf @@ -51,7 +51,6 @@ HobLib UefiRuntimeServicesTableLib UefiDriverEntryPoint - DxeServicesLib EdkiiSystemCapsuleLib PlatformFlashAccessLib IniParsingLib -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel