From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A984C210F52BD for ; Sun, 19 Aug 2018 21:56:53 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2018 21:56:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,263,1531810800"; d="scan'208";a="84720215" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 19 Aug 2018 21:56:53 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 19 Aug 2018 21:56:52 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 19 Aug 2018 21:56:52 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Mon, 20 Aug 2018 12:56:50 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH v2 26/27] MdeModulePkg SetupBrowserDxe: Remove a redundant function Thread-Index: AQHUNDn1KLCaMAeG6UKObvkJQxrqSqTIG5NA Date: Mon, 20 Aug 2018 04:56:50 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBAF4BD@shsmsx102.ccr.corp.intel.com> References: <20180815014609.19948-1-shenglei.zhang@intel.com> <20180815014609.19948-27-shenglei.zhang@intel.com> In-Reply-To: <20180815014609.19948-27-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 26/27] MdeModulePkg SetupBrowserDxe: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2018 04:56:53 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable We have gave Reviewed-by to the patch at https://lists.01.org/pipermail/edk= 2-devel/2018-August/028283.html and https://lists.01.org/pipermail/edk2-dev= el/2018-August/028319.html. Thanks, Star -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 15, 2018 9:46 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH v2 26/27] MdeModulePkg SetupBrowserDxe: Remove a redundant = function The function IsDevicePathExist that is never called has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- .../Universal/SetupBrowserDxe/IfrParse.c | 33 ------------------- 1 file changed, 33 deletions(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c b/MdeModuleP= kg/Universal/SetupBrowserDxe/IfrParse.c index 3d28e7aa50..042bd4b30d 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c @@ -452,39 +452,6 @@ IntializeBrowserStorage ( } } =20 -/** - Check whether exist device path info in the ConfigHdr string. - - @param String UEFI configuration string - - @retval TRUE Device Path exist. - @retval FALSE Not exist device path info. - -**/ -BOOLEAN -IsDevicePathExist ( - IN EFI_STRING String - ) -{ - UINTN Length; - - for (; (*String !=3D 0 && StrnCmp (String, L"PATH=3D", StrLen (L"PATH=3D= ")) !=3D 0); String++); - if (*String =3D=3D 0) { - return FALSE; - } - - String +=3D StrLen (L"PATH=3D"); - if (*String =3D=3D 0) { - return FALSE; - } - - for (Length =3D 0; *String !=3D 0 && *String !=3D L'&'; String++, Length= ++); - if (((Length + 1) / 2) < sizeof (EFI_DEVICE_PATH_PROTOCOL)) { - return FALSE; - } - - return TRUE; -} =20 /** Allocate a FORMSET_STORAGE data structure and insert to FormSet Storage = List. -- 2.18.0.windows.1